Timeline

Dec 13, 2006:

11:52 PM Changeset in webkit [18208] by hyatt

• 5 edits in trunk/WebCore

Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects Dashboard). Make sure
to clear the paintingRoot properly when recurring into children. It would be nice to find a design
that prevented this mistake from being made and didn't require explicit clearing of the root.

Reviewed by olliej

• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
• rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
• rendering/RenderTable.cpp: (WebCore::RenderTable::paint):

11:33 PM Changeset in webkit [18207] by bdash

• 3 edits in branches/Safari-2-0-branch/WebKit

2006-12-13 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2005-09-06 David Hyatt <​hyatt@apple.com>

Reduce the # of cached pages for a back/forward list. The old cache would cache the
following per tab:

1gb memory = 16 pages per tab/window
512mb memory = 8 pages per tab/window

<= 512mb memory = 4 pages per tab/window

This consumes far too much memory and is way too aggressive. The new cache sizes are
as follows:

1gb memory = 3 pages per tab/window

512mb memory = 2 pages per tab/window

< 512mb memory = 1 page per tab/window

Reviewed by john

• History.subproj/WebBackForwardList.m: (-[WebBackForwardList pageCacheSize]):
• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

5:30 PM Changeset in webkit [18206] by andersca

• 2 edits in trunk/WebCore

• loader/FrameLoader.h: id is mac-only.

5:04 PM Changeset in webkit [22663] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Fix the build.

• platform/win/TemporaryLinkStubs.cpp: (PolicyCheck::call): (DocumentLoader::URL):

3:34 PM Changeset in webkit [18205] by beidson

• 2 edits in trunk/WebCore

Implicitly reviewed by Darin, Hyatt, Maciej, and others!

Fixes a document tear down crash.
Changes a few long standing assertions to our new style

• dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::topDocument):

3:22 PM Changeset in webkit [18204] by mjs

• 2 edits in trunk

Reviewed by Brady and Anders.

• Makefile.shared: Stop spewing the environment all the time, at least for command-line builds.

3:20 PM Changeset in webkit [18203] by mjs

• 30 edits in trunk

JavaScriptCore:

Reviewed by Anders.

• added equality and inequality operations for HashMap and Vector, useful for comparing more complex types

• wtf/HashMap.h: (WTF::operator==): (WTF::operator!=):
• wtf/Vector.h: (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Anders.

• converted many places to use ResourceRequest instead of NSURLRequest

• WebCore.exp:
• loader/DocumentLoader.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck):
• loader/FrameLoader.h: (WebCore::PolicyCheck::request):
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::URLForHistory):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::applyUserAgent): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::originalRequestURL): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
• loader/mac/WebDataProtocol.h:
• loader/mac/WebDataProtocol.mm:
• platform/KURL.cpp: (WebCore::operator!=):
• platform/KURL.h:
• platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL):
• platform/network/FormData.h: (WebCore::operator==): (WebCore::operator!=):
• platform/network/ResourceRequest.cpp: (WebCore::operator==):
• platform/network/ResourceRequest.h:
• platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

Reviewed by Anders.

• adjusted for changes from NSURLRequest to ResourceRequest

• Plugins/WebPluginController.mm:
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::createDocumentLoader):
• WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
• WebView/WebDocumentLoaderMac.h:
• WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
• WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame loadArchive:]):

3:19 PM Changeset in webkit [22662] by ggaren

• 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Minor problems remain with focus in frames, but basic editing / cursor
focus works.

I moved tracking of the focused frame from the Widget hiearchy to Page's
FocusController. Not all widgets are frames, so this change cleaned up a
dubious static cast. Also, the DOM needs to track frame focus because (1)
it needs to respond to focus changes and (2) you can focus an element /
frame even before it has a renderer / widget.

• page/win/EventHandlerWin.cpp: (WebCore::EventHandler::focusDocumentView): Implemented. This function is poorly named, based on the Mac design. (WebCore::PluginViewWin::hasFocus): Added for completeness. It's not really used on Windows, though.

WebKitWin:

Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Updated WebKit to use new FocusController tracking of the focused frame.

• WebView.cpp: (WebViewWndProc): Fixed a minor bug where we wouldn't fire the blur event when changing focus to the location bar.

3:10 PM Changeset in webkit [18202] by ggaren

• 8 edits in trunk/WebCore

Reviewed by Darin Adler, Dave Hyatt.

Beefed up FocusController to handle frame focus. Changed implementors to
use FocusController, rather than the widget hierarchy, to focus frames.

(WebCore::FocusController::focusedNode): Made a minor change to focus a frame
before focusing the element inside of it. This matches FF.
(WebCore::FocusController::focusedFrame):

• platform/Widget.h:

1:33 PM Changeset in webkit [18201] by justing

• 2 edits
  4 adds in trunk

Reviewed by adele

<rdar://problem/4818145>
Cannot setSelectedDOMRange to non-editable island unless it has editable content on both sides

There are editable positions before/after a "non-editable island" if its
a table, but the code in canonicalPosition was not using
editableRootForPosition to find root editable elements.

• editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Use editableRootForPosition to fix the table case.

1:08 PM Changeset in webkit [22661] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

1:01 PM Changeset in webkit [18200] by sfalken

• 1 copy in tags/Safari-521.32.2b

New tag.

12:12 PM Changeset in webkit [22660] by sfalken

• 3 edits in branches/WindowsMerge/WebCore

2006-12-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Add WebCore forwarding headers to include paths

2006-11-14 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

2006-12-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Add missing ForwardingHeaders to project

• WebCore.vcproj/WebCore.make: Fixed line endings
• WebCore.vcproj/WebCore.vcproj: Added missing headers

12:02 PM Changeset in webkit [18199] by sfalken

• 1 edit
  2 adds in trunk/WebCore

2006-12-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Added missing forwarding headers.

• ForwardingHeaders/kjs/value.h: Added.
• ForwardingHeaders/wtf/HashTable.h: Added.

9:05 AM Changeset in webkit [18198] by ggaren

• 2 edits in trunk/LayoutTests

Updated results to match Justin Garcia's addition of rangeCount to
the selection object.

• fast/dom/Window/window-properties-expected.txt:

6:45 AM Changeset in webkit [18197] by zack

• 3 edits in trunk/WebKitTools

Make qmake the default build environment for the Qt port.
CMake currently doesn't work and updates to qmake will happen
a lot faster. Review by Rob

5:16 AM Changeset in webkit [18196] by zack

• 6 edits in trunk

make it compile after last nights changes from lars (r=maciej,me)

Dec 12, 2006:

11:02 PM Changeset in webkit [22659] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-12-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

B&I build fix

• WebCore.vcproj/build-generated-files.sh:

6:48 PM Changeset in webkit [22658] by aliceli1

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

Fixed <rdar://problem/4853199> extra whitespace at beginning and end of pasted fragment into contenteditable region

• platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):

6:41 PM Changeset in webkit [22657] by aroben

• 5 edits in branches/WindowsMerge/WebCore

6:34 PM Changeset in webkit [18195] by aroben

• 2 edits in trunk/WebCore

Reviewed by Anders.

Changed #import to #include to match the rest of our ForwardingHeaders.

• ForwardingHeaders/wtf/StringExtras.h:

5:46 PM Changeset in webkit [18194] by zbujtas

• 4 edits in S60/trunk/WebCore

2006-12-11 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
​http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/css/html4.css:
• khtml/css/html4_gcce.css:
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):

5:41 PM Changeset in webkit [18193] by zbujtas

• 4 edits in S60/branches/3.1m/WebCore

2006-12-12 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
​http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/css/html4.css:
• khtml/css/html4_gcce.css:
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):

5:23 PM Changeset in webkit [22656] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:16 PM Changeset in webkit [18192] by sfalken

• 1 copy in tags/Safari-521.32.0b

New tag.

4:48 PM Changeset in webkit [18191] by justing

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4757667>
GoogleDocs: Style menu does not open

• editing/selection/rangeCount-expected.txt: Added.
• editing/selection/rangeCount.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4757667>
GoogleDocs: Style menu does not open

• bindings/js/kjs_window.cpp: (KJS::Selection::getValueProperty): Added rangeCount.
• bindings/js/kjs_window.h: (KJS::Selection::):
• editing/SelectionController.h: (WebCore::SelectionController::rangeCount): Added.

3:58 PM Changeset in webkit [18190] by aliceli1

• 2 edits in trunk/WebCore

Reviewed by Oliver.

• bindings/js/JSSVGMatrixCustom.cpp: added #ifdef SVG_SUPPORT

3:45 PM Changeset in webkit [18189] by andersca

• 2 edits in trunk/WebCore

Suggested by Darin.

• loader/ResourceLoader.cpp: Move down include of ResourceHandle.h.

3:30 PM Changeset in webkit [18188] by ggaren

• 2 edits in trunk/WebCore/page

Fixing up svn properties on FocusController.*

2:19 PM Changeset in webkit [22655] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Added FocusController to project.

• WebCore.vcproj/WebCore.vcproj:

2:11 PM Changeset in webkit [18187] by ggaren

• 7 edits
  2 adds in trunk/WebCore

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Factored focus control into a FocusController class. I inted to use this
class for handling window active state and the focused frame, as well.

Layout tests pass.

• WebCore.xcodeproj/project.pbxproj:
• dom/Document.cpp: (WebCore::Document::view): (WebCore::Document::page): New helper function.
• dom/Document.h: Moved setters before getters. (WebCore::Document::hoverNode): (WebCore::Document::activeNode):
• dom/Node.cpp: (WebCore::Node::detach): Use the FocusController.
• page/FocusController.cpp: Added. (WebCore::shouldFocus): renamed and refactored this helper function. (WebCore::shouldUnfocus): ditto.
• page/FocusController.h: Added.

2:03 PM Changeset in webkit [18186] by andersca

• 3 edits in trunk/WebCore

Rubber Stamped by Geoff.

• platform/Base64.cpp:
• platform/Base64.h: Put functions inside of the WebCore namespace.

1:50 PM Changeset in webkit [22654] by andersca

• 6 edits in branches/WindowsMerge

WebCoreWin:

• loader/win/ResourceLoaderWin.cpp:
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
• platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadsBlocked): Update for changes to ResourceHandle.

WebKitWin:

• WebFrame.cpp: (WebFrame::loadDataSource): Update for changes to ResourceHandle.

1:42 PM Changeset in webkit [18185] by andersca

• 4 edits in trunk/WebCore

Try fixing the non-Mac builds.

• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail):
• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
• loader/SubresourceLoader.h:

1:14 PM Changeset in webkit [18184] by andersca

• 18 edits in trunk

WebCore:

Reviewed by Darin.

Turn ResourceLoader into a ResourceHandleClient and stop using NSURLConnection in the loader.

• WebCore.exp: Add new methods needed by WebKit.

• WebCore.xcodeproj/project.pbxproj: Make ResourceHandle.h a private header.

• loader/FrameLoaderClient.h: Change the download method to take a ResourceHandle instead of an NSURLConnection.

• loader/MainResourceLoader.h: Get rid of the proxy instance variable, that's handled by ResourceHandlw now.

• loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::willCacheResponse): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation): (WebCore::ResourceLoader::handle):
• loader/SubresourceLoader.h: Make ResourceLoader a ResourceHandleClient, moving the methods from SubresourceLoader.

• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): Use a ResourceHandle instead of an NSURLConnection.

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail): Remove the WebCoreResourceLoaderAsDelegate class, use a ResourceHandle instead of an NSURLConnection.

• loader/mac/SubresourceLoaderMac.mm: Remove ResourceHandleClient methods.

• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add an extra argument denoting whether this ResourceHandle can possibly be "converted" into one used for downloads.

• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseProxy): (WebCore::ResourceHandle::connection): New methods for creating a NSURLConnectionDelegateProxy which is used when creating a NSURLDownload from an existing connection.

WebKit:

Reviewed by Darin.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Get the handle and proxy from the ResourceHandle now that they aren't passed to us.

12:13 PM Changeset in webkit [18183] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-12-12 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):

12:09 PM Changeset in webkit [18182] by ap

• 7 edits in trunk

Reviewed by Geoff. Based on a patch by Maks Orlovich.

​http://bugs.webkit.org/show_bug.cgi?id=6257
Throw errors on invalid expressions (KJS merge)

JavaScriptCore:

• kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
• kjs/regexp.h: (KJS::RegExp::flags): (KJS::RegExp::isValid): (KJS::RegExp::errorMessage): (KJS::RegExp::subPatterns): Remember and report RegExp construction failures. Renamed data members not to start with underscores.

• kjs/regexp_object.cpp: (RegExpObjectImp::construct): Raise an exception if RegExp construction fails. (RegExpObjectImp::callAsFunction): Removed an obsolete comment.

• tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to a value supported by PCRE.

LayoutTests:

• fast/js/kde/RegExp-expected.txt: One more test passes.

11:50 AM SVG TODO List - Short notes edited by ojh16@student.canterbury.ac.nz

text+filter stuff (diff)

11:42 AM Changeset in webkit [18181] by andersca

• 3 edits in trunk/WebCore

Reviewed by Geoff.

• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Move the didTellBridgeAboutLoad call to SubresourceLoader in preparation for getting rid of the DocLoader parameter to ResourceHandle::create.

11:41 AM Changeset in webkit [22653] by darin

• 2 edits in branches/WindowsMerge/WebCore

• fix build

• WebCore.vcproj/WebCore.vcproj: Added missing files, removed obsolete files.

11:32 AM Changeset in webkit [18180] by ggaren

• 1 edit in trunk/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt

Oops. Forgot to check in this file.

9:52 AM SVG TODO List - Short notes edited by zimmermann@kde.org

(diff)

9:01 AM Changeset in webkit [18179] by spadma

• 5 edits in S60/branches/3.1m/WebKit

2006-12-11 sareen <​shyam.sareen@nokia.com>

Reviewed Sachin Padma.
DESC: Saved Pages: Some Images not saved with the page.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11721

• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
• ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
• ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):

4:09 AM Changeset in webkit [18178] by staikos

• 3 edits in trunk/WebCore

Make the last checkin compile

3:19 AM Changeset in webkit [18177] by zimmermann

• 55 edits
  1 add
  2 deletes in trunk

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11797

Remove SVGMatrix, replace it by AffineTransform usage everywhere.
Changed AffineTransform API to be able to be used within generation
(m11() -> a(), m12() -> b(), ...). Add some methods needed for SVG.

1:55 AM Changeset in webkit [18176] by staikos

• 9 edits in trunk

Fix the Qt build

1:02 AM Changeset in webkit [18175] by ggaren

• 8 edits
  4 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Added some focus-related tests.

• editing/undo/undo-iframe-location-change-expected.txt: Updated to reflect the fact that we now unfocus nodes when they're removed from the document.

• fast/events/keypress-removed-node-expected.txt: Added.
• fast/events/keypress-removed-node.html: Added.
• fast/forms/focus2-expected.txt: Added.
• fast/forms/focus2.html: Added.

WebCore:

Reviewed by Beth Dakin.

Moved focus control to the page level. Fixed a minor bug where a node
would retain keyboard focus even when removed from the document.

We should probably move this, along with hover and active, into a separate
FocusController. But I'm too tired right now.

• dom/Document.cpp: Migrated code to Page (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::setFocusedNode): (WebCore::Document::focusedNode):
• dom/Document.h:
• dom/Node.cpp: (WebCore::Node::detach): Clear ourselves from keyboard focus. This fixes the minor bug and was also necessary to prevent regressions caused by hanging on to a focused node after the document was replaced.
• dom/Node.h: (WebCore::Node::inDetach):
• page/Page.cpp: Migrated code from Document (WebCore::shouldAcquireEditingFocus): (WebCore::shouldRelinquishEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::widgetForNode): (WebCore::Page::setFocusedNode):
• page/Page.h: (WebCore::Page::focusedNode):

12:45 AM Changeset in webkit [18174] by ggaren

• 1 edit in trunk/WebCore/platform/Base64.cpp

build fix

12:28 AM Changeset in webkit [18173] by ap

• 2 edits in trunk/LayoutTests

Added the new XHR EventTarget methods to test results.

• fast/dom/Window/window-properties-expected.txt: