Context Navigation

← Previous Period
Next Period →

Timeline

Dec 14, 2006:

11:50 PM Changeset in webkit [22673] by ggaren

1 edit in branches/WindowsMerge/WebCore/ChangeLog

ChangeLog fixup

11:46 PM Changeset in webkit [22672] by ggaren

2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

WARNING: NO TEST CASES ADDED OR CHANGED

page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe):

8:10 PM Changeset in webkit [22671] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Update PopupMenu code to use new PopupMenuClient instead of RenderMenuList.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::focusFirst): (WebCore::PopupMenu::focusLast): (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::PopupMenu::paint): (WebCore::PopupWndProc):

8:04 PM Changeset in webkit [18231] by andersca

21 edits in trunk

WebCore:

Reviewed by Maciej.

Use char* pointer + length instead of NSData in a bunch of places.

loader/DocumentLoader.h:
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/MainResourceLoader.h:
loader/NetscapePlugInStreamLoader.h:
loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData):
loader/SubresourceLoader.h:
loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::committedLoad):
loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::didReceiveData):
loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveData):
loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData):
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveData):
platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):

WebKit:

Reviewed by Maciej.

Update for WebCore changes.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::deliverArchivedResources):
WebView/WebView.mm: (-[WebView _incrementProgressForIdentifier:length:]):
WebView/WebViewInternal.h:

8:02 PM Changeset in webkit [18230] by adele

5 edits in trunk/WebCore

Reviewed by Adam.

Added PopupMenuClient class so the PopupMenu class no longer needs to know
about the RenderMenuList or the DOM.

platform/PopupMenu.h: (WebCore::PopupMenuClient::~PopupMenuClient): (WebCore::PopupMenu::create): Made this protected so PopupMenu can be subclassed. (WebCore::PopupMenu::disconnectClient): Renamed from disconnectMenuList. (WebCore::PopupMenu::client): Added.
platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): Created using PopupMenuClient instead of RenderMenuList. (WebCore::PopupMenu::populate): Asks the client for info about the list items instead of looking at the DOM or the renderer. (WebCore::PopupMenu::show): ditto. (WebCore::PopupMenu::hide): ditto.
rendering/RenderMenuList.h: Now also inherits from PopupMenuClient. (WebCore::RenderMenuList::shouldPopOver): Added. Tells the popup whether the menu should pop over the client, or under.
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls disconnectClient(). (WebCore::RenderMenuList::calcMinMaxWidth): Removed unnecessary (and harmful) call to updateFromElement. updateFromElmeent can add children, and you don't want to do that in the middle of calculating width. (WebCore::RenderMenuList::itemText): Added PopupClient method to provide information about the items in the menu list. (WebCore::RenderMenuList::itemIsEnabled): ditto. (WebCore::RenderMenuList::itemStyle): ditto. (WebCore::RenderMenuList::clientStyle): ditto. (WebCore::RenderMenuList::clientDocument): ditto. (WebCore::RenderMenuList::clientPaddingLeft): ditto. (WebCore::RenderMenuList::clientPaddingRight): ditto. (WebCore::RenderMenuList::listSize): ditto. (WebCore::RenderMenuList::selectedIndex): ditto. (WebCore::RenderMenuList::itemIsSeparator): ditto. (WebCore::RenderMenuList::itemIsLabel): ditto. (WebCore::RenderMenuList::itemIsSelected): ditto. (WebCore::RenderMenuList::setTextFromItem): ditto.

7:43 PM Changeset in webkit [18229] by ggaren

8 edits
2 adds in trunk

LayoutTests:

Updated these results now that I've rolled out my change to move focus
to the page level:

editing/undo/undo-iframe-location-change-expected.txt:
fast/forms/focus2-expected.txt:

Added this test for one of the regressions that moving focus to the page
level caused:

editing/selection/inactive-selection-expected.txt: Added.
editing/selection/inactive-selection.html: Added.

WebCore:

Fixed <rdar://problem/4882713> GMAIL (REGRESSION): Can't apply font style,
foreground or background to selected text

Also <rdar://problem/4883751> REGRESSION: Caret fails to insert itself
automatically in a new note window

I'm rolling out my change to move focus to the page level because it caused
too many unexpected and bizarre regressions. Our code relies on focus
being per-document so that it can make focus changes that are effectively
no-ops, and so that it can conflate focus and selection in some cases (a bad
idea, since they're not the same).

Hopefully we can revisit this, along with hover and active, in the future.

dom/Document.cpp: (WebCore::widgetForNode): (WebCore::relinquishesEditingFocus): (WebCore::acceptsEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::focusedNodeDetached): (WebCore::Document::setFocusedNode):
dom/Document.h: (WebCore::Document::focusedNode):
page/FocusController.cpp:
page/FocusController.h:

7:34 PM Changeset in webkit [22670] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:27 PM Changeset in webkit [18228] by sfalken

1 copy in tags/Safari-521.32.3b

New tag.

7:14 PM Changeset in webkit [18227] by mjs

2 edits in trunk/WebCore

Reviewed by Geoff.

fix failing drag & drop layout tests

platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL): Turn empty KURL into empty NSURL, but null KURL into nil.

6:25 PM Changeset in webkit [18226] by thatcher

4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4827549> need NSRange-based selection support exposed.

WebView/WebFrame.mm: (-[WebFrame _selectedNSRange]): (-[WebFrame _selectNSRange:]):
WebView/WebFramePrivate.h:

6:18 PM Changeset in webkit [22669] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <sfalken@apple.com>

Build fix.

platform/win/TemporaryLinkStubs.cpp: (SubresourceLoader::didCancel):

5:30 PM Changeset in webkit [18225] by sfalken

2 edits in trunk/WebCore

2006-12-14 Steve Falkenburg <sfalken@apple.com>

Build fix.

loader/MainResourceLoader.h:

5:24 PM Changeset in webkit [18224] by bdash

3 edits in branches/Safari-2-0-branch/WebKit

2006-12-14 Mark Rowe <mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-11-14 Alexey Proskuryakov <ap@webkit.org>

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.

For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
WebView/WebHTMLViewInternal.h:

4:58 PM Changeset in webkit [22668] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <sfalken@apple.com>

B&I build fix. Added JSSVGPODTypeWrapper.h to the vcproj.

WebCore.vcproj/WebCore.vcproj:

4:41 PM Changeset in webkit [18223] by andersca

18 edits in trunk

WebCore:

Reviewed by John.

Convert a bunch of NSErrors to ResourceError.

Make the ResourceError accessor functions const.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/MainResourceLoader.h:
loader/NetscapePlugInStreamLoader.h:
loader/ResourceLoader.h:
loader/SubresourceLoader.h:
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::interruptionForPolicyChangeError):
loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::didFail):
loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
platform/network/ResourceError.h: (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):

WebKit:

Reviewed by John.

Update for WebKit changes.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack):

4:10 PM Changeset in webkit [18222] by staikos

3 edits in trunk

Link, after the last loader changes. Please update this directory with stubs when modifying the loader. (also fixes some Changelog typos)

3:48 PM Changeset in webkit [22667] by adele

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Build Fix.

WebContextMenuClient.h:

3:40 PM Changeset in webkit [22666] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Build fix.

platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::URL): (ResourceHandle::loadResourceSynchronously):

3:30 PM Changeset in webkit [18221] by justing

11 edits
8 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

editing/deleting/4866671-expected.checksum: Added.
editing/deleting/4866671-expected.png: Added.
editing/deleting/4866671-expected.txt: Added.
editing/deleting/4866671.html: Added.
editing/pasteboard/4866671-expected.checksum: Added.
editing/pasteboard/4866671-expected.png: Added.
editing/pasteboard/4866671-expected.txt: Added.
editing/pasteboard/4866671.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

Don't allow VisiblePositions inside -webkit-user-select:none regions.
Renamed inRenderedContent to isCandidate.

dom/Document.cpp: (WebCore::Document::updateSelection):
dom/Position.cpp: (WebCore::Position::previousCharacterPosition): (WebCore::Position::nextCharacterPosition): (WebCore::nodeIsUserSelectNone): (WebCore::Position::isCandidate): (WebCore::Position::rendersInDifferentPosition):
dom/Position.h:
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
editing/htmlediting.cpp: (WebCore::nextCandidate): (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousCandidate): (WebCore::previousVisuallyDistinctCandidate):
editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph):
page/Frame.cpp: (WebCore::Frame::styleForSelectionStart):

3:16 PM Changeset in webkit [18220] by hyatt

2 edits in trunk/WebCore

Get rid of the containsStart check and just rely on the selectionState
bits. This allows selection gap filling to behave properly in the presence
of inline blocks and inline tables on lines when the selection originates
inside the inline block.

Reviewed by ggaren

rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillInlineSelectionGaps):

2:13 PM Changeset in webkit [18219] by andersca

6 edits in trunk/WebCore

Reviewed by John.

General loader cleanup, convert NSURLResponse to ResourceResponse in some places.

loader/DocumentLoader.h:
loader/SubresourceLoader.h:
loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::addResponse):
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::opened):
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):

1:04 PM Changeset in webkit [22665] by andersca

2 edits in branches/WindowsMerge/WebCore

Fix the build.

platform/win/TemporaryLinkStubs.cpp: (FrameLoader::loadResourceSynchronously): (ResourceHandle::loadResourceSynchronously):

12:56 PM Changeset in webkit [22664] by adachan

6 edits in branches/WindowsMerge/WebKitWin

2006-12-14 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Implemented WebChromeClient::pageRect() to return the bounds of the WebView.
Implemented WebFrame::parentFrame().
Added a temporary implementation of WebDataSource::isLoading().

12:50 PM Changeset in webkit [18218] by andersca

15 edits in trunk/WebCore

Reviewed by Darin.

Add loadResourceSynchronously to ResourceHandle and have FrameLoader use it instead of
calling NSURLConnection directly.

Add an isNull flag to ResourceError so we can convert correctly between nil NSErrors and ResourceErrors.

Get rid of ServeSynchronousRequest and use the loader instead.

WebCore.exp:
dom/XMLTokenizer.cpp: (WebCore::openFunc):
loader/FrameLoader.h:
loader/LoaderFunctions.h:
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::loadResourceSynchronously):
loader/mac/LoaderFunctionsMac.mm:
platform/network/ResourceError.h: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::isNull):
platform/network/ResourceHandle.h:
platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isConditional):
platform/network/ResourceRequest.h:
platform/network/mac/ResourceErrorMac.mm: (-[NSError WebCore]):
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously):
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

12:42 PM Changeset in webkit [18217] by zimmermann

6 edits
1 add in trunk/WebCore

Reviewed by Darin.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11830

Fix fundamental problems with JS SVG POD types.
(currently: FloatPoint/FloatRect/AffineTransform)

11:30 AM Changeset in webkit [18216] by thatcher

4 edits in trunk

top level:

Reviewed by Brady.

Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

WebKitTools:

Reviewed by Brady.

Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

10:05 AM Changeset in webkit [18215] by ap

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11828
Fix a leak of NSURLRequest on each update - RetainPtr retains the object itself.

platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

9:32 AM Changeset in webkit [18214] by hausmann

2 edits in trunk/WebKitQt

2006-12-14 Simon Hausmann <hausmann@kde.org>

Reviewed by Zack.

QtLauncher/QtLauncher.pro: Link this little test program with rpath, for convenience. (This is never going to get installed anyway)

8:47 AM Changeset in webkit [18213] by hausmann

2 edits in trunk/WebCore

2006-12-14 Simon Hausmann <hausmann@kde.org>

Reviewed by Zack Rusin.

WebCore.pro: Clean up the xpath grammar generation rule.

6:22 AM Changeset in webkit [18212] by zack

2 edits in trunk/WebCore

Make it link with temporary stubs (from lars, icefox)

3:40 AM Changeset in webkit [18211] by zack

4 edits in trunk/WebCore

Compilation fixes for the Qt port after last nights changes

2:36 AM Changeset in webkit [18210] by rwlbuis

10 edits
4 adds in trunk

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=11726
SVG Image do not take into account clip/overflow when hit testing

Take into account the overflowRect when hit-testing <svg> container.

12:50 AM Changeset in webkit [18209] by bdash

2 edits in branches/Safari-2-0-branch/WebKit

2006-12-13 Mark Rowe <mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-05-14 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8739 Crash in RenderTableSection::paint due to manipulating DOM on resize

Manual test: manual-tests/dom-manipulation-on-resize.html

WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.

Dec 13, 2006:

11:52 PM Changeset in webkit [18208] by hyatt

5 edits in trunk/WebCore

Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects Dashboard). Make sure
to clear the paintingRoot properly when recurring into children. It would be nice to find a design
that prevented this mistake from being made and didn't require explicit clearing of the root.

Reviewed by olliej

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
rendering/RenderTable.cpp: (WebCore::RenderTable::paint):

11:33 PM Changeset in webkit [18207] by bdash

3 edits in branches/Safari-2-0-branch/WebKit

2006-12-13 Mark Rowe <mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2005-09-06 David Hyatt <hyatt@apple.com>

Reduce the # of cached pages for a back/forward list. The old cache would cache the
following per tab:

1gb memory = 16 pages per tab/window
512mb memory = 8 pages per tab/window

<= 512mb memory = 4 pages per tab/window

This consumes far too much memory and is way too aggressive. The new cache sizes are
as follows:

1gb memory = 3 pages per tab/window

512mb memory = 2 pages per tab/window

< 512mb memory = 1 page per tab/window

Reviewed by john

History.subproj/WebBackForwardList.m: (-[WebBackForwardList pageCacheSize]):
WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

5:30 PM Changeset in webkit [18206] by andersca

2 edits in trunk/WebCore

loader/FrameLoader.h: id is mac-only.

5:04 PM Changeset in webkit [22663] by andersca

2 edits in branches/WindowsMerge/WebCore

Fix the build.

platform/win/TemporaryLinkStubs.cpp: (PolicyCheck::call): (DocumentLoader::URL):

3:34 PM Changeset in webkit [18205] by beidson

2 edits in trunk/WebCore

Implicitly reviewed by Darin, Hyatt, Maciej, and others!

Fixes a document tear down crash.
Changes a few long standing assertions to our new style

dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::topDocument):

3:22 PM Changeset in webkit [18204] by mjs

2 edits in trunk

Reviewed by Brady and Anders.

Makefile.shared: Stop spewing the environment all the time, at least for command-line builds.

3:20 PM Changeset in webkit [18203] by mjs

30 edits in trunk

JavaScriptCore:

Reviewed by Anders.

added equality and inequality operations for HashMap and Vector, useful for comparing more complex types

wtf/HashMap.h: (WTF::operator==): (WTF::operator!=):
wtf/Vector.h: (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Anders.

converted many places to use ResourceRequest instead of NSURLRequest

WebCore.exp:
loader/DocumentLoader.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck):
loader/FrameLoader.h: (WebCore::PolicyCheck::request):
loader/FrameLoaderClient.h:
loader/MainResourceLoader.h:
loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::URLForHistory):
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::applyUserAgent): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::originalRequestURL): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
loader/mac/WebDataProtocol.h:
loader/mac/WebDataProtocol.mm:
platform/KURL.cpp: (WebCore::operator!=):
platform/KURL.h:
platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL):
platform/network/FormData.h: (WebCore::operator==): (WebCore::operator!=):
platform/network/ResourceRequest.cpp: (WebCore::operator==):
platform/network/ResourceRequest.h:
platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

Reviewed by Anders.

adjusted for changes from NSURLRequest to ResourceRequest

Plugins/WebPluginController.mm:
WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::createDocumentLoader):
WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
WebView/WebDocumentLoaderMac.h:
WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame loadArchive:]):

3:19 PM Changeset in webkit [22662] by ggaren

9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Minor problems remain with focus in frames, but basic editing / cursor
focus works.

I moved tracking of the focused frame from the Widget hiearchy to Page's
FocusController. Not all widgets are frames, so this change cleaned up a
dubious static cast. Also, the DOM needs to track frame focus because (1)
it needs to respond to focus changes and (2) you can focus an element /
frame even before it has a renderer / widget.

page/win/EventHandlerWin.cpp: (WebCore::EventHandler::focusDocumentView): Implemented. This function is poorly named, based on the Mac design. (WebCore::PluginViewWin::hasFocus): Added for completeness. It's not really used on Windows, though.

WebKitWin:

Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Updated WebKit to use new FocusController tracking of the focused frame.

WebView.cpp: (WebViewWndProc): Fixed a minor bug where we wouldn't fire the blur event when changing focus to the location bar.

3:10 PM Changeset in webkit [18202] by ggaren

8 edits in trunk/WebCore

Reviewed by Darin Adler, Dave Hyatt.

Beefed up FocusController to handle frame focus. Changed implementors to
use FocusController, rather than the widget hierarchy, to focus frames.

(WebCore::FocusController::focusedNode): Made a minor change to focus a frame
before focusing the element inside of it. This matches FF.
(WebCore::FocusController::focusedFrame):

platform/Widget.h:

1:33 PM Changeset in webkit [18201] by justing

2 edits
4 adds in trunk

Reviewed by adele

<rdar://problem/4818145>
Cannot setSelectedDOMRange to non-editable island unless it has editable content on both sides

There are editable positions before/after a "non-editable island" if its
a table, but the code in canonicalPosition was not using
editableRootForPosition to find root editable elements.