⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 15, 2006:

6:50 PM Changeset in webkit [18244] by bdash
  • 3 edits in trunk/WebCore

2006-12-15 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Oliver.

Allow images to load into frames again. Tidy up code a bit and
add some much needed documentation.

  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes):
  • platform/MimeTypeRegistry.h:
5:50 PM Changeset in webkit [22675] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/win/TemporaryLinkStubs.cpp: Remove DocumentLoader::isStopped because it's now in DocumentLoader.cpp.
4:41 PM Changeset in webkit [18243] by andersca
  • 3 edits in trunk/WebCore

Fix build.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::mainDocumentError):
  • loader/DocumentLoader.h:
4:05 PM Changeset in webkit [18242] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Geoff.

More loader cleanup.

  • loader/DocumentLoader.h: (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::setResponse):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::prepareForLoadStart):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::setResponse):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):

WebKit:

Reviewed by Geoff.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
  • WebView/WebDataSource.mm: (-[WebDataSource response]):
2:58 PM Changeset in webkit [18241] by andersca
  • 2 edits in trunk/WebCore
  • loader/DocumentLoader.h: Whoops, didn't mean to commit this.
2:57 PM Changeset in webkit [18240] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Darin and Brady (in no particular order).


More loader cleanup.


  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError):
  • loader/mac/MainResourceLoaderMac.mm:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm:
2:24 PM Changeset in webkit [22674] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

I'm in ur prjct, fxng ur build.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadResourceSynchronously):
2:02 PM Changeset in webkit [18239] by ap
  • 2 edits in trunk/WebCore

Try to fix Windows build: add EventTarget.{h,cpp}.

1:49 PM Changeset in webkit [18238] by ap
  • 22 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11610
XMLHttpRequest.onreadystatechange doesn't provide access to the request object

Created a separate EventTarget class, now that EventTargetNode isn't the only kind.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added EventTarget.{h,cpp}
  • bindings/js/kjs_dom.cpp: (KJS::toJS): Added an EventTarget variant.
  • bindings/js/kjs_dom.h: Added toJS() for EventTarget; some minor style fixes.
  • bindings/objc/DOM.mm: (+[DOMNode _eventTargetWith:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm: Added an EventTarget->DOMEventTarget converter in DOMNode (WebCoreInternal). It only works for nodes, since we don't have an ObjC binding for XMLHttpRequest. Corrected spelling of internalHeaderContent.
  • dom/Event.cpp: (WebCore::Event::setTarget):
  • dom/Event.h: (WebCore::Event::target): (WebCore::Event::currentTarget): (WebCore::Event::setCurrentTarget): These methods now work with EventTargets instead of Nodes.
  • dom/EventTarget.cpp: Added. (WebCore::EventTarget::~EventTarget): (WebCore::EventTarget::toNode): (WebCore::EventTarget::toXMLHttpRequest):
  • dom/EventTarget.h: Added. (WebCore::EventTarget::ref): (WebCore::EventTarget::deref): Originally, my intention was to share much of the implementation between EventTargetNode and XHR, but now I don't see anything substantial worth sharing.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Cast Node to EventTargetNode.
  • dom/EventTargetNode.h: Made EventTarget methods virtual. (WebCore::EventTargetNode::toNode): Added poor man's RTTI to upcast from EventTarget. (WebCore::EventTargetNode::refEventTarget): (WebCore::EventTargetNode::derefEventTarget):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::toElement): (WebCore::MouseEvent::fromElement):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): Cast from EventTarget to Node as appropriate.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener): Set target and currentTarget before dispatching.
  • xml/xmlhttprequest.h: Made EventTarget methods virtual, added a bool tempEvent parameter to match EventTargetNode. (WebCore::XMLHttpRequest::toXMLHttpRequest): Added poor man's RTTI to upcast from EventTarget. (WebCore::XMLHttpRequest::refEventTarget): (WebCore::XMLHttpRequest::derefEventTarget):

LayoutTests:

  • fast/dom/xmlhttprequest-get-expected.txt:
  • http/tests/xmlhttprequest/event-target-expected.txt:
  • http/tests/xmlhttprequest/event-target.html:
1:08 PM Changeset in webkit [18237] by andersca
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

More loader cleanup, use KURL instead of NSURL in a couple of places.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::prepareForLoadStart):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willUseArchive):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load):

WebKit:

Reviewed by Darin.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive):
  • WebView/WebDataSource.mm: (-[WebDataSource _URLForHistory]):
12:40 PM Changeset in webkit [18236] by ap
  • 13 edits
    3 moves
    5 adds
    2 deletes in trunk

2006-12-15 Marvin Decker <​marv.decker@gmail.com>

Reviewed by Darin and Alexey.

Fix the Windows build, move various Client implementations out of
WebCore and into WebKit.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h: Removed.
  • bridge/win/ContextMenuClientWin.h: Removed.
  • bridge/win/EditorClientWin.h: Removed.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderClientWin.cpp: Removed.
  • loader/win/FrameLoaderClientWin.h: Removed.
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::DocumentLoader::URL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::~Pasteboard): (WebCore::PolicyCheck::call): (WebCore::PopupMenu::PopupMenu): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceLoader::cancel):

WebKit:

  • COM/ChromeClientWin.cpp: Added. (ChromeClientWin::~ChromeClientWin): (ChromeClientWin::chromeDestroyed): (ChromeClientWin::setWindowRect): (ChromeClientWin::windowRect): (ChromeClientWin::pageRect): (ChromeClientWin::scaleFactor): (ChromeClientWin::focus): (ChromeClientWin::unfocus): (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog): (ChromeClientWin::show): (ChromeClientWin::canRunModal): (ChromeClientWin::runModal): (ChromeClientWin::setToolbarsVisible): (ChromeClientWin::toolbarsVisible): (ChromeClientWin::setStatusbarVisible): (ChromeClientWin::statusbarVisible): (ChromeClientWin::setScrollbarsVisible): (ChromeClientWin::scrollbarsVisible): (ChromeClientWin::setMenubarVisible): (ChromeClientWin::menubarVisible): (ChromeClientWin::setResizable): (ChromeClientWin::addMessageToConsole):
  • COM/ChromeClientWin.h: Added.
  • COM/ContextMenuClientWin.cpp: Added. (ContextMenuClientWin::~ContextMenuClientWin): (ContextMenuClientWin::contextMenuDestroyed): (ContextMenuClientWin::addCustomContextMenuItems): (ContextMenuClientWin::contextMenuItemSelected): (ContextMenuClientWin::copyLinkToClipboard): (ContextMenuClientWin::downloadURL): (ContextMenuClientWin::copyImageToClipboard): (ContextMenuClientWin::lookUpInDictionary): (ContextMenuClientWin::speak): (ContextMenuClientWin::stopSpeaking):
  • COM/ContextMenuClientWin.h: Added.
  • COM/EditorClientWin.cpp: Added. (EditorClientWin::~EditorClientWin): (EditorClientWin::pageDestroyed): (EditorClientWin::shouldDeleteRange): (EditorClientWin::shouldShowDeleteInterface): (EditorClientWin::smartInsertDeleteEnabled): (EditorClientWin::isContinuousSpellCheckingEnabled): (EditorClientWin::toggleContinuousSpellChecking): (EditorClientWin::isGrammarCheckingEnabled): (EditorClientWin::toggleGrammarChecking): (EditorClientWin::spellCheckerDocumentTag): (EditorClientWin::selectWordBeforeMenuEvent): (EditorClientWin::isEditable): (EditorClientWin::shouldBeginEditing): (EditorClientWin::shouldEndEditing): (EditorClientWin::shouldInsertNode): (EditorClientWin::shouldInsertText): (EditorClientWin::shouldApplyStyle): (EditorClientWin::didBeginEditing): (EditorClientWin::respondToChangedContents): (EditorClientWin::didEndEditing): (EditorClientWin::registerCommandForUndo): (EditorClientWin::registerCommandForRedo): (EditorClientWin::clearUndoRedoOperations): (EditorClientWin::canUndo): (EditorClientWin::canRedo): (EditorClientWin::undo): (EditorClientWin::redo):
  • COM/EditorClientWin.h: Added.
  • COM/WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::initWithName):
  • COM/WebFrame.h:
  • COM/WebFrameLoaderClient.cpp: Added. (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::~WebFrameLoaderClient): (WebFrameLoaderClient::frameLoaderDestroyed): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent):
  • COM/WebFrameLoaderClient.h: Added.
  • COM/WebKitDLL.h:
  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

  • Spinneret/Spinneret.sln:
12:11 PM Changeset in webkit [18235] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11842
REGRESSION: Using Safari's snippet editor leaves applewebdata: URLs in history


  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URLForHistory): Don't return appleweburls without an unreachable url.
11:48 AM Changeset in webkit [18234] by andersca
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

Replace more instances of NSError with ResourceError.


Also remove a check for a selector that was added pre-Tiger.


  • WebCore.exp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/ResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::cancelledError):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didCancel):

WebKit:

Reviewed by Darin.

Include ResourceError.h.


  • Plugins/WebNetscapePluginStream.mm:
  • WebKit.xcodeproj/project.pbxproj:
11:31 AM Changeset in webkit [18233] by rwlbuis
  • 13 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11824
CSSStyleSheet.title property is always null

Set title on the stylesheet just after creating it, for the HTML
elements <link> and <style>.

4:26 AM Changeset in webkit [18232] by zack
  • 3 edits in trunk/WebCore

Fix compilation (from lars)

Dec 14, 2006:

11:50 PM Changeset in webkit [22673] by ggaren
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

ChangeLog fixup

11:46 PM Changeset in webkit [22672] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

WARNING: NO TEST CASES ADDED OR CHANGED

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe):
8:10 PM Changeset in webkit [22671] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Update PopupMenu code to use new PopupMenuClient instead of RenderMenuList.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::focusFirst): (WebCore::PopupMenu::focusLast): (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::PopupMenu::paint): (WebCore::PopupWndProc):
8:04 PM Changeset in webkit [18231] by andersca
  • 21 edits in trunk

WebCore:

Reviewed by Maciej.

Use char* pointer + length instead of NSData in a bunch of places.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData):
  • loader/SubresourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::committedLoad):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::didReceiveData):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveData):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveData):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):

WebKit:

Reviewed by Maciej.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::deliverArchivedResources):
  • WebView/WebView.mm: (-[WebView _incrementProgressForIdentifier:length:]):
  • WebView/WebViewInternal.h:
8:02 PM Changeset in webkit [18230] by adele
  • 5 edits in trunk/WebCore

Reviewed by Adam.

Added PopupMenuClient class so the PopupMenu class no longer needs to know
about the RenderMenuList or the DOM.

  • platform/PopupMenu.h: (WebCore::PopupMenuClient::~PopupMenuClient): (WebCore::PopupMenu::create): Made this protected so PopupMenu can be subclassed. (WebCore::PopupMenu::disconnectClient): Renamed from disconnectMenuList. (WebCore::PopupMenu::client): Added.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): Created using PopupMenuClient instead of RenderMenuList. (WebCore::PopupMenu::populate): Asks the client for info about the list items instead of looking at the DOM or the renderer. (WebCore::PopupMenu::show): ditto. (WebCore::PopupMenu::hide): ditto.
  • rendering/RenderMenuList.h: Now also inherits from PopupMenuClient. (WebCore::RenderMenuList::shouldPopOver): Added. Tells the popup whether the menu should pop over the client, or under.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls disconnectClient(). (WebCore::RenderMenuList::calcMinMaxWidth): Removed unnecessary (and harmful) call to updateFromElement. updateFromElmeent can add children, and you don't want to do that in the middle of calculating width. (WebCore::RenderMenuList::itemText): Added PopupClient method to provide information about the items in the menu list. (WebCore::RenderMenuList::itemIsEnabled): ditto. (WebCore::RenderMenuList::itemStyle): ditto. (WebCore::RenderMenuList::clientStyle): ditto. (WebCore::RenderMenuList::clientDocument): ditto. (WebCore::RenderMenuList::clientPaddingLeft): ditto. (WebCore::RenderMenuList::clientPaddingRight): ditto. (WebCore::RenderMenuList::listSize): ditto. (WebCore::RenderMenuList::selectedIndex): ditto. (WebCore::RenderMenuList::itemIsSeparator): ditto. (WebCore::RenderMenuList::itemIsLabel): ditto. (WebCore::RenderMenuList::itemIsSelected): ditto. (WebCore::RenderMenuList::setTextFromItem): ditto.
7:43 PM Changeset in webkit [18229] by ggaren
  • 8 edits
    2 adds in trunk

LayoutTests:

Updated these results now that I've rolled out my change to move focus
to the page level:


  • editing/undo/undo-iframe-location-change-expected.txt:
  • fast/forms/focus2-expected.txt:


Added this test for one of the regressions that moving focus to the page
level caused:


  • editing/selection/inactive-selection-expected.txt: Added.
  • editing/selection/inactive-selection.html: Added.

WebCore:

Fixed <rdar://problem/4882713> GMAIL (REGRESSION): Can't apply font style,
foreground or background to selected text


Also <rdar://problem/4883751> REGRESSION: Caret fails to insert itself
automatically in a new note window


I'm rolling out my change to move focus to the page level because it caused
too many unexpected and bizarre regressions. Our code relies on focus
being per-document so that it can make focus changes that are effectively
no-ops, and so that it can conflate focus and selection in some cases (a bad
idea, since they're not the same).


Hopefully we can revisit this, along with hover and active, in the future.

  • dom/Document.cpp: (WebCore::widgetForNode): (WebCore::relinquishesEditingFocus): (WebCore::acceptsEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::focusedNodeDetached): (WebCore::Document::setFocusedNode):
  • dom/Document.h: (WebCore::Document::focusedNode):
  • page/FocusController.cpp:
  • page/FocusController.h:
7:34 PM Changeset in webkit [22670] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:27 PM Changeset in webkit [18228] by sfalken
  • 1 copy in tags/Safari-521.32.3b

New tag.

7:14 PM Changeset in webkit [18227] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • fix failing drag & drop layout tests
  • platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL): Turn empty KURL into empty NSURL, but null KURL into nil.
6:25 PM Changeset in webkit [18226] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4827549> need NSRange-based selection support exposed.

  • WebView/WebFrame.mm: (-[WebFrame _selectedNSRange]): (-[WebFrame _selectNSRange:]):
  • WebView/WebFramePrivate.h:
6:18 PM Changeset in webkit [22669] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: (SubresourceLoader::didCancel):
5:30 PM Changeset in webkit [18225] by sfalken
  • 2 edits in trunk/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • loader/MainResourceLoader.h:
5:24 PM Changeset in webkit [18224] by bdash
  • 3 edits in branches/Safari-2-0-branch/WebKit

2006-12-14 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-11-14 Alexey Proskuryakov <​ap@webkit.org>

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

  1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.
  1. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

  • WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
  • WebView/WebHTMLViewInternal.h:
4:58 PM Changeset in webkit [22668] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

B&I build fix. Added JSSVGPODTypeWrapper.h to the vcproj.

  • WebCore.vcproj/WebCore.vcproj:
4:41 PM Changeset in webkit [18223] by andersca
  • 18 edits in trunk

WebCore:

Reviewed by John.

Convert a bunch of NSErrors to ResourceError.


Make the ResourceError accessor functions const.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::interruptionForPolicyChangeError):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::didFail):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceError.h: (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):

WebKit:

Reviewed by John.

Update for WebKit changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack):
4:10 PM Changeset in webkit [18222] by staikos
  • 3 edits in trunk

Link, after the last loader changes. Please update this directory with stubs when modifying the loader. (also fixes some Changelog typos)

3:48 PM Changeset in webkit [22667] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Build Fix.

  • WebContextMenuClient.h:
3:40 PM Changeset in webkit [22666] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::URL): (ResourceHandle::loadResourceSynchronously):
3:30 PM Changeset in webkit [18221] by justing
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

  • editing/deleting/4866671-expected.checksum: Added.
  • editing/deleting/4866671-expected.png: Added.
  • editing/deleting/4866671-expected.txt: Added.
  • editing/deleting/4866671.html: Added.
  • editing/pasteboard/4866671-expected.checksum: Added.
  • editing/pasteboard/4866671-expected.png: Added.
  • editing/pasteboard/4866671-expected.txt: Added.
  • editing/pasteboard/4866671.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()


Don't allow VisiblePositions inside -webkit-user-select:none regions.
Renamed inRenderedContent to isCandidate.

  • dom/Document.cpp: (WebCore::Document::updateSelection):
  • dom/Position.cpp: (WebCore::Position::previousCharacterPosition): (WebCore::Position::nextCharacterPosition): (WebCore::nodeIsUserSelectNone): (WebCore::Position::isCandidate): (WebCore::Position::rendersInDifferentPosition):
  • dom/Position.h:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
  • editing/htmlediting.cpp: (WebCore::nextCandidate): (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousCandidate): (WebCore::previousVisuallyDistinctCandidate):
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph):
  • page/Frame.cpp: (WebCore::Frame::styleForSelectionStart):
3:16 PM Changeset in webkit [18220] by hyatt
  • 2 edits in trunk/WebCore

Get rid of the containsStart check and just rely on the selectionState
bits. This allows selection gap filling to behave properly in the presence
of inline blocks and inline tables on lines when the selection originates
inside the inline block.

Reviewed by ggaren

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillInlineSelectionGaps):
2:13 PM Changeset in webkit [18219] by andersca
  • 6 edits in trunk/WebCore

Reviewed by John.


General loader cleanup, convert NSURLResponse to ResourceResponse in some places.


  • loader/DocumentLoader.h:
  • loader/SubresourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::addResponse):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::opened):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
1:04 PM Changeset in webkit [22665] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Fix the build.


  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::loadResourceSynchronously): (ResourceHandle::loadResourceSynchronously):
12:56 PM Changeset in webkit [22664] by adachan
  • 6 edits in branches/WindowsMerge/WebKitWin

2006-12-14 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

Implemented WebChromeClient::pageRect() to return the bounds of the WebView.
Implemented WebFrame::parentFrame().
Added a temporary implementation of WebDataSource::isLoading().

12:50 PM Changeset in webkit [18218] by andersca
  • 15 edits in trunk/WebCore

Reviewed by Darin.

Add loadResourceSynchronously to ResourceHandle and have FrameLoader use it instead of
calling NSURLConnection directly.

Add an isNull flag to ResourceError so we can convert correctly between nil NSErrors and ResourceErrors.

Get rid of ServeSynchronousRequest and use the loader instead.


  • WebCore.exp:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/FrameLoader.h:
  • loader/LoaderFunctions.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/LoaderFunctionsMac.mm:
  • platform/network/ResourceError.h: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::isNull):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isConditional):
  • platform/network/ResourceRequest.h:
  • platform/network/mac/ResourceErrorMac.mm: (-[NSError WebCore]):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
12:42 PM Changeset in webkit [18217] by zimmermann
  • 6 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11830

Fix fundamental problems with JS SVG POD types.
(currently: FloatPoint/FloatRect/AffineTransform)

11:30 AM Changeset in webkit [18216] by thatcher
  • 4 edits in trunk

top level:

Reviewed by Brady.

  • Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

WebKitTools:

Reviewed by Brady.

  • Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status
10:05 AM Changeset in webkit [18215] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11828
Fix a leak of NSURLRequest on each update - RetainPtr retains the object itself.

  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
9:32 AM Changeset in webkit [18214] by hausmann
  • 2 edits in trunk/WebKitQt

2006-12-14 Simon Hausmann <​hausmann@kde.org>

Reviewed by Zack.

  • QtLauncher/QtLauncher.pro: Link this little test program with rpath, for convenience. (This is never going to get installed anyway)
8:47 AM Changeset in webkit [18213] by hausmann
  • 2 edits in trunk/WebCore

2006-12-14 Simon Hausmann <​hausmann@kde.org>

Reviewed by Zack Rusin.

  • WebCore.pro: Clean up the xpath grammar generation rule.
6:22 AM Changeset in webkit [18212] by zack
  • 2 edits in trunk/WebCore

Make it link with temporary stubs (from lars, icefox)

3:40 AM Changeset in webkit [18211] by zack
  • 4 edits in trunk/WebCore

Compilation fixes for the Qt port after last nights changes

2:36 AM Changeset in webkit [18210] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=11726
SVG Image do not take into account clip/overflow when hit testing

Take into account the overflowRect when hit-testing <svg> container.

12:50 AM Changeset in webkit [18209] by bdash
  • 2 edits in branches/Safari-2-0-branch/WebKit

2006-12-13 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-05-14 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.
Note: See TracTimeline for information about the timeline view.