⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 18, 2006:

11:45 PM Changeset in webkit [18303] by hyatt
  • 2 edits in trunk/WebCore

Make sure a stroke style is set for list bullets.

Reviewed by mitz

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
10:28 PM Changeset in webkit [22690] by adachan
  • 10 edits in branches/WindowsMerge

2006-12-18 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


Fixed <rdar://4850800> Pop-up window opens with same size as parent window, and app crashes when closing pop-up

  • Corrected the height set on the max/min/restore/close buttons on the top-right of the safari win to take into account its top margin.
  • Implemented the calls we need to close window via script.
  • Added runBeforeUnloadConfirmPanelWithMessage to IWebUIDelegate.
  • implemented canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon in WebChromeClient
  • implemented WebView::closeWindow().

Removed scheduleClose() from FrameWin. The implementation has
been moved to Frame.cpp.

10:15 PM Changeset in webkit [18302] by adachan
  • 22 edits in trunk

2006-12-18 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


Moved canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon
from WebCoreFrameBridge to Chrome.
Moved implementation of Frame::scheduleClose to Frame.cpp.

9:53 PM Changeset in webkit [22689] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/PopupMenuWin.cpp

Fix Boomer build bustage from Pen conversion.

9:48 PM Changeset in webkit [22688] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Alice


Fixes <rdar://4821724> - Wrong site icon displays for sites who don't actually have an icon


We judged whether or not a site has an icon based on whether or not the IconDatabase returned
a valid Image.
In the case of sites without an icon, we actually get returned a valid Image with dimensions 0x0.
WebKit on OS X correctly handles this case via NSImage goodness - now we manually handle it on Windows

  • WebIconDatabase.cpp: (WebIconDatabase::iconForURL): Check the width() as an additional case to fallback to the default icon
9:30 PM Changeset in webkit [18301] by aliceli1
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adam.

Test case for <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

  • http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
  • http/tests/misc/location-test-xsl-style-sheet.xml: Added.
  • http/tests/misc/resources/location-test-xsl-style-sheet.xsl: Added.

WebCore:

Reviewed by Adam.

Fixed <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
9:23 PM Changeset in webkit [18300] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:22 PM Changeset in webkit [22687] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-12-18 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Added loadType to IWebFramePrivate.

  • Interfaces/IWebFramePrivate.idl: Added loadType
  • WebFrame.cpp: Fixed line endings (WebFrame::loadType): Added
  • WebFrame.h: Fixed line endings
  • WebKit.vcproj/WebKit.vcproj: Moved WebLocalizableStrings.h to proper folder
9:18 PM Changeset in webkit [18299] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix spelling error in Qt code..

9:17 PM Changeset in webkit [18298] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:02 PM Changeset in webkit [18297] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing setPlatformPen.

8:58 PM Changeset in webkit [18296] by hyatt
  • 2 edits in trunk/WebCore

Add save/restore calls around the painting of text areas on Mac, since the methods in question
alter the current fill color in CG destructively.

Reviewed by olliej

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb):
8:31 PM Changeset in webkit [18295] by hyatt
  • 2 edits in trunk/WebCore

Fix list markers to properly stroke and fill. I screwed this up when changing how text draws.

Reviewed by olliej

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
8:21 PM Changeset in webkit [22686] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam and Oliver.

<rdar://problem/4856014> Target weekly ad doesn't work.


Store the real base URL and use it for requests.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
8:16 PM Changeset in webkit [22685] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Boomer side of pen removal changes.

8:00 PM Changeset in webkit [18294] by hyatt
  • 18 edits in trunk/WebCore

Eliminate the Pen object in favor of separate stroke variables, since most code just wants to set the
stroke color. This also makes it easier for us to push only stroke color through into CG synchronously
while leaving the others alone.

Reviewed by olliej

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/graphics/GraphicsContext.h: (WebCore::):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::setPlatformStrokeColor):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQPenStyle): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineTextBox.cpp: (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderText.cpp:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton):
6:44 PM Changeset in webkit [22684] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Fix build, wrong variable name.
6:30 PM Changeset in webkit [18293] by darin
  • 7 edits in trunk/WebCore

Reviewed by Adele.

  • change DOMActivate events to be created as a part of default handling of click events instead of having the sender of the click event also send a DOMActivate event
  • fixed some edge cases in the slider thumb element handler; since this is inside a shadow DOM, it's likely none of these can arise in practice

No easy way to test the command-click part since the behavior is in Safari.
To make a test we'd have to provide JavaScript access to the modifiers passed
to the policy delegate or have some way to query the underlying event from
JavaScript.

  • dom/EventTargetNode.cpp: Change all assert to ASSERT. (WebCore::EventTargetNode::dispatchMouseEvent): Renamed some local variables for clarity. Added a RefPtr for relatedTarget since it might be deallocated by the handlers for the click event and is used in the code that creates the dblclick event. Removed the code to create a DOMActivate event, since that's now done in the default event handler for the click event. (WebCore::EventTargetNode::defaultEventHandler): Added code to check for a click event and dispatch a DOMActivate event using the click event as the underlying event. The part of this that fixes the bug is that we use the click event as the underlying event; the old code used the same underlying event as for the click event, not the click event itself. The underlying event for the click event is usually 0, since we propagate the key state to the click event instead of using an underlying event in the common case.
  • dom/Document.cpp: (WebCore::Document::defaultEventHandler): Added call to the base class's defaultEventHandler function, except in the case where the event is already handled.
  • html/HTMLInputElement.h: Removed clickX() and clickY().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Use xPos and yPos directly, so we can remove clickX() and clickY(). (WebCore::HTMLInputElement::defaultEventHandler): Removed code that calls setDefaultHandled for click events since we are just recording the x and y coordinates of the events; that's not "handling" an event, and setting the flag prevents us from calling the base class's default event handler, which is now needed to submmit the form.
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Added some missing isMouseEvent checks in code that casts to a MouseEvent. Added check document()->frame() in code that manipulates the frame so that fake events, which might happen when there's no frame, can't cause a crash. Added an m_inDragMode check so we don't try to handle mouseup events when we are not handling a drag. Remove the setDefaultHandled call from the mousemove case, because mousemove events are observed, and not "handled" in the "nobody else should look at this event" sense. Added a call to the base class's default event handler, and some return statements so that we won't call it when the event has been handled.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Removed an unneeded "return" for a function that has no return value.
6:04 PM Changeset in webkit [18292] by bdash
  • 2 edits in trunk/LayoutTests

2006-12-18 Mark Rowe <​bdash@webkit.org>

Reviewed by Brady.

Bug 11870: Bug 11866 caused layout test regression in fast/forms/input-value.html
​http://bugs.webkit.org/show_bug.cgi?id=11870

  • fast/forms/input-value-expected.txt: Updated results.
5:38 PM Changeset in webkit [18291] by bdakin
  • 4 edits
    4 adds in trunk

WebCore:

Fix for <rdar://problem/4749770> WebCore crashes on a blog website
in WebCore::InlineBox::root() + 6

We null-check inlineBoxWrapper everywhere else in the code except
for these 3 spots. This patch adds them in. Only one of the checks
is required to fix the crash. What we render for the test case now
matches shipping Safari, but still seems wrong because we do not
match Firefox. I will file a follow-up about the rendering problem.

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): This is the required null-check.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setSelectionState): Null-check for safety. (WebCore::RenderListMarker::selectionRect): Same.

LayoutTests:

Reviewed by Adele.

Test case for <rdar://problem/4749770> WebCore crashes on a blog
website in WebCore::InlineBox::root() + 6

  • fast/lists/inlineBoxWrapperNullCheck-expected.checksum: Added.
  • fast/lists/inlineBoxWrapperNullCheck-expected.png: Added.
  • fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
  • fast/lists/inlineBoxWrapperNullCheck.html: Added.
5:26 PM Changeset in webkit [22683] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Boomer side of my changes for filling/stroking of text.

Reviewed by olliej

  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
5:18 PM Changeset in webkit [18290] by hyatt
  • 14 edits in trunk/WebCore

Fix performance regression caused by adding setting of stroke colors as well as fill colors to every font drawing
call on Mac. Fix is rather involved:

(1) Fill color is now updated in CG synchronously. There is no more delay in the push. I used the model that
Qt added for this, setPlatformFillColor, so we're the same now.

(2) Text was being drawn using the pen color, which is tantamount to using the stroke color. Since text in HTML
is really a fill and not a stroke, all cross-platform code that draws text has been patched to use fill instead
of the pen.

(3) Added a new API to GraphicsContext to set the text drawing mode to any combination of fill/stroke/clip.
Ports should implement setPlatformTextDrawingMode or just query the mode in their drawGlyphs/drawComplexText
method on their Font class to get the new functionality.

(4) InlineTextBox will set the fill and stroke colors appropriately now rather than always assuming fill.

(5) Fixed a bug in GraphicsContextCG where fillRectWithColor was updating the CG fill color in the state object
as a side effect, creating a mismatch between CG's fill color and the stored cross-platform fill color.

Reviewed by olliej

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformPen):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformFillColor):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::setup):
  • platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::teardown):
  • platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::correctedTextColor): (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
3:28 PM Changeset in webkit [18289] by bdash
  • 3 edits
    5 adds in trunk

2006-12-18 Dex Deacon <​occupant4@gmail.com>

Reviewed by Maciej.

Bug 11760: Animated GIFs with offsets crash WebKit
​http://bugs.webkit.org/show_bug.cgi?id=11760

  • platform/image-decoders/gif/GIFImageDecoder.cpp: ensure we don't write past the end of the image buffer when the offset is nonzero. also fix the way we composite frames when animating. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):

2006-12-18 Dex Deacon <​occupant4@gmail.com>

Reviewed by Maciej.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=11760

  • ChangeLog:
  • fast/images/animated-gif-with-offsets-expected.txt: Added.
  • fast/images/animated-gif-with-offsets.html: Added.
  • fast/images/resources/animated-gif-with-offsets.gif: Added.
3:22 PM Changeset in webkit [18288] by bdash
  • 3 edits
    4 adds in trunk

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Changed hidden input controls to reset to their initial values
when the form is reset. Also added layout tests for resetting
other input controls.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11866

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=11866

  • fast/dom/HTMLInputElement/input-checked-reset-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-checked-reset.html: Added.
  • fast/dom/HTMLInputElement/input-text-reset-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-text-reset.html: Added.
2:57 PM Changeset in webkit [22682] by aliceli1
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

  • WebCore.vcproj/WebCore.vcproj: Added file EditorDeleteAction.h

WebKitWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

  • WebView.cpp: (WebView::execCommand): Removed the case for ForwardDelete, since it shouldn't be handled there (WebView::deleteSelection): Implemented (WebView::copy): (WebView::cut): (WebView::paste): (WebView::delete_): Use the Editor's execCommand for these editor-responsible functions
2:49 PM Changeset in webkit [18287] by aliceli1
  • 1 edit
    1 add in trunk/WebCore

Oops forgot a file.

  • editing/EditorDeleteAction.h: Added. (WebCore::):
2:47 PM Changeset in webkit [18286] by aliceli1
  • 11 edits in trunk

WebCore:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

  • WebCore.exp: Exposed Editor::deleteWithDirection and ::deleteRange()
  • WebCore.xcodeproj/project.pbxproj: Added EditorDeleteAction.h
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): (WebCore::Editor::deleteWithDirection): Implemented

(WebCore::Editor::deleteSelectionWithSmartDelete):
Overloaded to take no params, in which case canSmartCopyOrDelete is called

(WebCore::execCopy):
(WebCore::execCut):
(WebCore::execDelete):
(WebCore::execPaste):
Call the editor instead of asking frame to cut/copy/paste/delete

(WebCore::execBackwardDelete):
(WebCore::execForwardDelete):
Call deleteWithDirection instead of just executing a TypingCommand

(WebCore::CommandEntry::):
distinguished delete (which deletes selection) from backwards delete (single character, no selection)

(WebCore::Editor::cut):
(WebCore::Editor::performDelete):
Trivial changes

  • editing/Editor.h: Added some functons. (WebCore::Editor::setStartNewKillRingSequence): (WebCore::Editor::propogateDOMException): (WebCore::Editor::addToKillRing):
  • editing/mac/EditorMac.mm: Factored out support for Kill Rings to this file
  • platform/mac/PasteboardMac.mm: Trivial change

WebKit:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

  • WebKitPrefix.h: Turned on WebCore deletion
  • WebView/WebHTMLViewInternal.h: Moved ownership of startNewKillRingSequence to the WebCore::Editor
  • WebView/WebHTMLView.m: (-[NSArray becomeFirstResponder]): Use the Editor's startNewKillRingSequence flag

(-[NSArray deleteForward:]):
(-[NSArray deleteBackward:]):
(-[NSArray deleteWordForward:]):
(-[NSArray deleteWordBackward:]):
(-[NSArray deleteToBeginningOfLine:]):
(-[NSArray deleteToEndOfLine:]):
(-[NSArray deleteToBeginningOfParagraph:]):
(-[NSArray deleteToEndOfParagraph:]):
(-[NSArray deleteToMark:]):
use Editor::deleteWithDirection instead of WebHTMLView's

2:39 PM Changeset in webkit [22681] by kmccullo
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

  • Remove CG header includes in OpenSource files
  • config.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivate.h:

WebKitWin:

Reviewed by Oliver.

  • Remove CG header includes in open source files
  • WebView.cpp:
2:32 PM Changeset in webkit [18285] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • Removed CG header include
  • platform/graphics/ImageSource.h:
2:18 PM Changeset in webkit [18284] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4887764> GMAIL: Crash occurs at WebCore::Range::cloneRange() when I ctrl-click in a empty list item
  • editing/mac/EditorMac.mm: (WebCore::isRangeUngrammatical): bail out immediately for nil range (which selectionController()->toRange().get() can return). Also save some work by bailing out immediately for collapsed ranges.
1:36 PM Changeset in webkit [18283] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-13 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
​http://bugs.webkit.org/show_bug.cgi?id=11817

  • ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):
1:31 PM Changeset in webkit [18282] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2006-12-15 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):
1:28 PM Changeset in webkit [18281] by spadma
  • 6 edits in S60/branches/3.1m

2006-12-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
​http://bugs.webkit.org/show_bug.cgi?id=11707

  • BrowserView/inc/WebKitToolBarInterface.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):
1:21 PM Changeset in webkit [18280] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-13 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
​http://bugs.webkit.org/show_bug.cgi?id=11817

  • ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):
1:00 PM Changeset in webkit [18279] by spadma
  • 6 edits in S60/trunk

2006-12-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
​http://bugs.webkit.org/show_bug.cgi?id=11707

  • BrowserView/inc/WebKitToolBarInterface.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):
12:27 PM Changeset in webkit [18278] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=7170
`window.parent.[frameName].location=' fails if the target frame has not yet loaded a document

  • fast/frames/resources/set-unloaded-frame-location-1.html: Added.
  • fast/frames/resources/set-unloaded-frame-location-2.html: Added.
  • fast/frames/set-unloaded-frame-location-expected.txt: Added.
  • fast/frames/set-unloaded-frame-location.html: Added.
11:41 AM Changeset in webkit [18277] by thatcher
  • 1 copy in tags/WebKit-419/WebKit

New tag (part 2.)

11:41 AM Changeset in webkit [18276] by thatcher
  • 1 add in tags/WebKit-419

new tag (part 1.)

11:27 AM Changeset in webkit [18275] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning.

10:44 AM Changeset in webkit [18274] by aliceli1
  • 2 edits in trunk/WebCore

Leopard build fix.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
9:58 AM Changeset in webkit [22680] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fixes.

  • WebCore.vcproj/WebCore.vcproj: Removed deleted files.
  • platform/win/CursorWin.cpp: Added missing method. (WebCore::noneCursor):

Dec 17, 2006:

2:23 PM Changeset in webkit [18273] by zack
  • 2 edits in trunk/WebCore

fix compiltion, after the const changes

1:48 PM Changeset in webkit [18272] by rwlbuis
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by Eric.

Add missing checksum file, thnx to Wildfox for noticing.

1:29 PM Changeset in webkit [18271] by zimmermann
  • 6 edits in trunk

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10956

Long standing regression. The old code in FontMac.mm, used set the fill/stroke
color "[nsColor(graphicsContext->pen().color()) set];", and current code only
sets the fill color. Reverting to old behaviour fixes gradient-on-stroke-of-text.

11:25 AM Changeset in webkit [18270] by ap
  • 14 edits
    1 add in trunk/WebCore

2006-12-17 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed, tweaked and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11798
[CSS 3] missing cursor support for 'none'

  • Resources/noneCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: Also fixed previously broken -webkit-background-composite: copy.
  • manual-tests/cursor.html:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::noneCursor):
  • platform/mac/CursorMac.mm: (WebCore::noneCursor):
  • platform/qt/CursorQt.cpp: (WebCore::noneCursor):
  • platform/win/CursorWin.cpp: (WebCore::noneCursor):
  • rendering/RenderStyle.h: (WebCore::):
5:24 AM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
4:52 AM Changeset in webkit [18269] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.

This should hopefully fix Qt build.

  • ksvg2/svg/SVGLength.cpp: Include math.h for Qt/Linux build.
4:47 AM Changeset in webkit [18268] by zimmermann
  • 55 edits
    2 deletes in trunk/WebCore

Reviewed by Rob.

Remove SVGHelper class. Move the last static function "parseSeparatedList"
to the only place using it: SVGAnimationElement. Update all build files.

Remove any lazy_create macro usage, by what it does - cleaner.

4:16 AM Changeset in webkit [18267] by zimmermann
  • 60 edits in trunk

Reviewed by Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11813

Pass SVGLength around by value, remove any SVGLength* usage.
Bindings work fine, as the SVG POD JS Wrapper stuff is already in svn.

No new regressions, none fixed. But the code itself is much cleaner.
And some problems with width-full-percentage.svg have been fixed, viewport
clipping works in any case now, also for percentual width/height values set on <svg>.

Still unsure if we can simulate window resizes in a layout test,
not through "width/height" property changes, but directly in any way.
If anyone knows if we can do that, please drop me a line.

3:58 AM Changeset in webkit [18266] by hausmann
  • 2 edits in trunk/JavaScriptCore

make testkjs.pro work on machines other than mine :)

2:50 AM Changeset in webkit [18265] by hausmann
  • 3 edits
    1 add in trunk

for the Qt build also build testkjs now

Note: See TracTimeline for information about the timeline view.