⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 25, 2006:

9:36 PM Changeset in webkit [18420] by ggaren
  • 6 edits in trunk/WebKit

More "plugin" => "pluginPackage" renaming that I forgot to check in.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setPluginPackage:]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
9:24 PM Changeset in webkit [18419] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Eric Seidel.


Fixed crash when opening view source window.

  • WebView/WebView.mm: (-[WebView initWithCoder:]): Don't use the WebView until calling _commonInitialization...
7:43 PM Changeset in webkit [22716] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Fixed build. Tsk, tsk, Oliver.

  • WebCore.vcproj/WebCore.vcproj:
5:44 PM Changeset in webkit [18418] by zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.

In the DOMParser class, we have to create content-type specific
documents, instead of a pure "Document" object. Real-life SVG
files us this way to convert strings "<svg><rect x=...></svg>
to a new Document structure.

Add new testcase dynamic-svg-document-creation.svg.

5:30 PM Changeset in webkit [22715] by ggaren
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebCore.vcproj/WebCore.vcproj: Added Settings.cpp to the project.
  • bridge/win/FrameWin.cpp: Updated to use new preferences names. (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
  • loader/win/FrameLoaderWin.cpp: ditto. (WebCore::FrameLoader::partClearedInBegin):
  • plugins/win/PluginViewWin.cpp: ditto. (WebCore::PluginViewWin::load):

WebKitWin:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Used core() here, now that WebView::settings() is gone.
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Simplified this code, now that WebCore handles most of it.
  • WebView.h: Removed settings() accessor. Settings belong to the WebCore page, not the WebView.
5:22 PM Changeset in webkit [18417] by ggaren
  • 37 edits
    1 add
    2 deletes in trunk

WebCore:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebCore.exp: Exported Settings for use by WebKit, removed WebCoreSettings class.


  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreSetttings.h/.mm. Added Settings.cpp.
  • page/Frame.cpp: Removed cruft that duplicated Settings data. Callers now call through to Settings to get Settings data.
  • page/Page.cpp: Added Settings data member, to replace the one that WebView used to hold.
  • page/Settings.cpp: Added.
  • page/Settings.h:
    • Renamed all functions to match WebKit API. Renamed all variables to match functions. Favorite old name: "isPluginsEnabled."
    • Moved EditableLinkBehavior outside of the class. Having it inside just made it harder to type.
    • Merged in old WebCoreSettings functionality, like guarding against re-setting to the same value, and making sure to update page layout.
    • Paired setters and getters, putting setters first.

WebKit:

Reviewed by Oliver Hunt.


Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebView/WebFrame.mm: Added helper functions for converting between WebKitEditableLinkBehavior and WebCore::EditableLinkBehavior. I'm not sure that this is the best place for these functions, but it's where all the other functions like them reside. (core): (kit):
  • WebView/WebFrameInternal.h:
  • WebView/WebView.mm: Removed uses of WebCoreSettings. Replaced with direct use of underlying page's settings.
4:45 PM Changeset in webkit [18416] by zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Oliver.
Fix some minor style issues.

4:37 PM Changeset in webkit [18415] by zimmermann
  • 22 edits
    9 adds in trunk

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11963
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11123

Fix SVGList JS wrappers, which operate on POD types (ie. Point).
There exists a special JSSVGPODTypeWrapperCreatorForList class now,
which operators on specialized SVGPODList's. It makes it possible
to support stuff like "myList.getItem(0).value = 200", for POD lists.

Adding two new testcases demonstrating the usage of SVG DOM & SVGAnimatedPoints.

2:32 PM Changeset in webkit [18414] by ggaren
  • 8 edits in trunk/WebKit

Reviewed by Oliver Hunt.


Some refactoring in preparation for fixing <rdar://problem/4778898>
REGRESSION: crash in getInstanceForView() when quitting from kcbs.com


Two renames:

  • "plugin" => "pluginPackage" (since the type is WebNetscapePluginPackage *)
  • "instance" and/or "pluginPointer" => plugin (since NPP is an opaque handle to a plug-in)


Removed braces around single-line 'if' statements.


Made plugin a pointer instead of an inline ivar. This allows us to NULL
it out once we call NPP_Destroy on it.


Added helper functions for creating and destroying plugin. The destroy function
NULLs out plugin, which helps with debugging.


(-[WebBaseNetscapePluginView willCallPlugInFunction]): Added an ASSERT
to catch attempts to call functions on destroyed plug-ins.

(-[WebBaseNetscapePluginView _createPlugin]): New helper function.
(-[WebBaseNetscapePluginView _destroyPlugin]): New helper function.

10:37 AM Changeset in webkit [18413] by ap
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=10313
Reproducible crash when doing importStylesheet in javascript with
xsl files that use xsl:import

This doesn't fully address the bug, but makes a couple of steps
in that direction.

  • xml/XSLTProcessor.cpp: (WebCore::transformToString): Set m_stylesheet even if it's created implicitly, rather than passed from outside. Always reset it in the end (this doesn't affect Document::applyXSLTransform(), which was the only user of setXSLStylesheet()).
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the loaded document's URL.

Dec 24, 2006:

10:02 AM Changeset in webkit [18412] by ddkilzer
  • 1 edit
    1 delete in trunk/WebKit

2006-12-24 David Kilzer <​ddkilzer@webkit.org>

Removed empty directory.

  • WebKit/Loader: Removed.
8:46 AM Changeset in webkit [18411] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Maciej and Geoff.

  • remove unused member variable m_styleSelectorDirty

No test possible (no functionality change)

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
7:48 AM Changeset in webkit [18410] by weinig
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

  • fast/dom/css-mediarule-deleteRule-update-expected.checksum: Added.
  • fast/dom/css-mediarule-deleteRule-update-expected.png: Added.
  • fast/dom/css-mediarule-deleteRule-update-expected.txt: Added.
  • fast/dom/css-mediarule-deleteRule-update.html: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.checksum: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.png: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.txt: Added.
  • fast/dom/css-mediarule-insertRule-update.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

Tests added:

  • fast/dom/css-mediarule-deleteRule-update.html
  • fast/dom/css-mediarule-insertRule-update.html
  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
7:45 AM Changeset in webkit [18409] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Alexey.

Get rid of unused variable.

Note: See TracTimeline for information about the timeline view.