⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 30, 2006:

3:02 PM Changeset in webkit [18489] by rwlbuis
  • 15 edits
    2 deletes in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12004
Webkit doesnt handle omitting M at the start of path syntax well

Improve path parsing error handling.

1:54 PM Changeset in webkit [18488] by rwlbuis
  • 6 edits in trunk

Reviewed by Darin.

The marker is used for start, mid and end.

12:53 PM Changeset in webkit [18487] by rwlbuis
  • 15 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12035
Use SVGParserUtilities in lists of values

Use SVGParserUtilities in some more places.

8:09 AM Changeset in webkit [18486] by rwlbuis
  • 5 edits
    4 adds in trunk

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12034
Adapt preserveAspectRatio parsing to SVGParserUtilities

Use the new SVGParserUtilities methods to parse prserveAspectRatio attribute.

2:12 AM Changeset in webkit [18485] by ap
  • 3 edits in trunk/WebCore

2006-12-30 Mitz Pettel <​mitz@webkit.org>

Reviewed by Alexey.

  • remove unused member variables m_loadingSheet and m_bAllDataReceived

No test possible (no change to functionality).

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setCSSStyleSheet):
  • dom/Document.h:
12:34 AM Changeset in webkit [18484] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11998
Incorrect serialization of quotation marks in XML attributes.

Test: fast/dom/serialize-attribute.xhtml

  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Added an isAttributeValue parameter, as the quotation mark only needs to be encoded in attribute values. (WebCore::startMarkup): Pass appropriate isAttributeValue to escapeTextForMarkup().

Dec 29, 2006:

7:03 PM Changeset in webkit [18483] by ddkilzer
  • 4 edits in trunk/JavaScriptCore

2006-12-29 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Geoff.

Update embedded pcre library from version 6.1 to 6.2. From the pcre ChangeLog:

  1. Added "b" to the 2nd argument of fopen() in dftables.c, for non-Unix-like operating environments where this matters.
  1. Named capturing subpatterns were not being correctly counted when a pattern was compiled. This caused two problems: (a) If there were more than 100 such subpatterns, the calculation of the memory needed for the whole compiled pattern went wrong, leading to an overflow error. (b) Numerical back references of the form \12, where the number was greater than 9, were not recognized as back references, even though there were sufficient previous subpatterns.
  • pcre/dftables.c: Item 3. (main):
  • pcre/pcre.h: Updated version.
  • pcre/pcre_compile.c: Item 5. (read_repeat_counts): (pcre_compile2):
5:30 PM Changeset in webkit [18482] by ddkilzer
  • 3 edits in trunk/WebCore

2006-12-29 David Kilzer <​ddkilzer@webkit.org>

Build fix for no-svg build.

Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
5:27 PM Changeset in webkit [22720] by ggaren
  • 1 edit in branches/WindowsMerge/WebCore/bridge/win/FrameWin.cpp

build fix

5:24 PM Changeset in webkit [22719] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::bindingRootObject):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance):
4:48 PM Changeset in webkit [18481] by ggaren
  • 13 edits in trunk

JavaScriptCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


The key change here is to RootObject::RootObject().


  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Changed to use new constructor.
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): Changed to use new constructor. Replaced large 'if' followed by default condition with "if !" and explicit default condition.
  • bindings/objc/objc_runtime.mm: (convertValueToObjcObject): Changed to use new constructor.
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::destroy): "removeAllNativeReferences" => "destroy" because this function actually destroys the RootObject.
  • bindings/runtime_root.h: Changed Interpreter* to RefPtr<Interpreter> to prevent a RootObject from holding a stale Interperter*.


(KJS::Bindings::RootObject::RootObject): Changed constructor to take an
Interpreter*, since it's pointless to create a RootObject without one.
Removed setRootObjectImp() and rootObjectImp() because they were just
a confusing way of setting and getting the Interpreter's global object.

(KJS::Bindings::RootObject::nativeHandle): "_nativeHandle" => "m_nativeHandle"
(KJS::Bindings::RootObject::interpreter): "_interpreter" => "m_interpreter"

WebCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


The key change here is to RootObject::RootObject().


Layout tests pass.


Renamed "_bindingRoot" => "_bindingRootObject" because "RootObject" is the
type name.


  • bindings/objc/WebScriptObject.mm: (_didExecute): Use Interpreter::globalObject(), since RootObject::rootObjectImp() no longer exists.
  • page/mac/FrameMac.mm: (WebCore::FrameMac::bindingRootObject): Use the new RootObject constructor. Stop lying about who deletes _bindingRoot.

(WebCore::FrameMac::cleanupPluginObjects): => "destroy". Fixed a bug where
the RootObject would only free its own memory if there were a ReferencesSet*
associated with it.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rootObjectForView:]): Use new constructor. Changed misleading comment.
2:14 PM Changeset in webkit [18480] by rwlbuis
  • 12 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12007
SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing

Refactor code so svg reuses cssparser methods. Also make
SVGColor and SVGPaint more efficient by avoiding using
setRGBColor internally.

12:59 PM Changeset in webkit [18479] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12022
typo in SVGTransformable.cpp introduce in r18440


Use the helper method proposed by Eric.

12:47 PM Changeset in webkit [18478] by rwlbuis
  • 3 edits
    4 adds
    8 deletes in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12028
Adapt viewBox parsing to SVGParserUtilities

Use the new parseNumber and add tests for viewBox parsing.

12:00 PM Changeset in webkit [18477] by ggaren
  • 2 edits in trunk/WebCore

Build fix: SVGImage only works on Mac.

  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
11:28 AM Changeset in webkit [18476] by weinig
  • 17 edits in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12018
Cleanup of CSSRule and its subclasses

  • Make CSSRule::type() virtual instead of using a member variable.
  • General style cleanup.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCharsetRule.cpp: (WebCore::CSSCharsetRule::CSSCharsetRule):
  • css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::isCharsetRule): (WebCore::CSSCharsetRule::type):
  • css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::CSSFontFaceRule): (WebCore::CSSFontFaceRule::cssText):
  • css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::isFontFaceRule): (WebCore::CSSFontFaceRule::type):
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::CSSImportRule): (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent):
  • css/CSSImportRule.h: (WebCore::CSSImportRule::isImportRule): (WebCore::CSSImportRule::type):
  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule): (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule): (WebCore::CSSMediaRule::cssText):
  • css/CSSMediaRule.h: (WebCore::CSSMediaRule::isMediaRule): (WebCore::CSSMediaRule::type):
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText): (WebCore::CSSPageRule::setSelectorText): (WebCore::CSSPageRule::cssText):
  • css/CSSPageRule.h: (WebCore::CSSPageRule::style): (WebCore::CSSPageRule::type):
  • css/CSSRule.cpp: (WebCore::CSSRule::cssText): (WebCore::CSSRule::setCssText):
  • css/CSSRule.h: (WebCore::CSSRule::): (WebCore::CSSRule::CSSRule):
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::setSelectorText): (WebCore::CSSStyleRule::cssText): (WebCore::CSSStyleRule::parseString):
  • css/CSSStyleRule.h: (WebCore::CSSStyleRule::isStyleRule): (WebCore::CSSStyleRule::style): (WebCore::CSSStyleRule::type):
  • css/CSSUnknownRule.h: (WebCore::CSSUnknownRule::CSSUnknownRule): (WebCore::CSSUnknownRule::type):
9:45 AM Changeset in webkit [18475] by eseidel
  • 2 edits in trunk/WebCore

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::size): explicitly cast to integers to prevent compile error
6:47 AM Changeset in webkit [18474] by staikos
  • 5 edits in trunk

Make the Qt port not crash on many sites such as www.apple.com: painter was closed too
early, and I think also there is a Qt bug that it complains about a painter being
around on a destroyed object that's really just a QShared reference going away. Worked
around.

3:17 AM Changeset in webkit [18473] by zimmermann
  • 2 edits in trunk/WebCore

Build fixed, not reviewed. Noticed by Daniel Molkentin.

  • platform/graphics/svg/SVGImage.h: s/WTF/wtf/ in include.
1:17 AM Changeset in webkit [18472] by eseidel
  • 2 edits in trunk/WebCore

2006-12-29 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyCromeClient::scaleFactor): build fix, use 1.f instead of 1f
12:36 AM Changeset in webkit [18471] by eseidel
  • 3 edits
    9 adds in trunk/LayoutTests

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by olliej.


Add updated SVGImage results, forgotten in last commit.

  • fast/images/svg-as-background-expected.checksum: Added.
  • fast/images/svg-as-background-expected.png: Added.
  • fast/images/svg-as-background-expected.txt: Added.
  • fast/images/svg-as-image-expected.checksum: Added.
  • fast/images/svg-as-image-expected.png: Added.
  • fast/images/svg-as-image-expected.txt: Added.
  • fast/images/svg-as-tiled-background-expected.checksum: Added.
  • fast/images/svg-as-tiled-background-expected.png: Added.
  • fast/images/svg-as-tiled-background-expected.txt: Added.
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
12:27 AM Changeset in webkit [18470] by eseidel
  • 10 edits
    9 adds in trunk

2006-12-29 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

New tests:

  • fast/images/svg-as-image.html
  • fast/images/svg-as-background.html
  • fast/images/svg-as-tiled-background.html


Implement basic SVGImage support.
​http://bugs.webkit.org/show_bug.cgi?id=5971


This implementation depends on (rather ugly) stub Page and Frame clients in SVGImageEmptyClients.h

  • WebCore.xcodeproj/project.pbxproj: add SVGImage.*
  • ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::parseMappedAttribute): ignore fragment urls
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • platform/graphics/Image.h: made setData virtual
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::drawTiled): stub method
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/svg/SVGImage.cpp: Added. (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::~SVGImage): (WebCore::SVGImage::size): (WebCore::SVGImage::draw): (WebCore::SVGImage::drawTiled): stub method (WebCore::SVGImage::setData):
  • platform/graphics/svg/SVGImage.h: Added. (WebCore::SVGImage::frameAtIndex):
  • platform/graphics/svg/SVGImageEmptyClients.h: Added. (WebCore::SVGEmptyCromeClient::~SVGEmptyCromeClient): (WebCore::SVGEmptyCromeClient::chromeDestroyed): (WebCore::SVGEmptyCromeClient::setWindowRect): (WebCore::SVGEmptyCromeClient::windowRect): (WebCore::SVGEmptyCromeClient::pageRect): (WebCore::SVGEmptyCromeClient::scaleFactor): (WebCore::SVGEmptyCromeClient::focus): (WebCore::SVGEmptyCromeClient::unfocus): (WebCore::SVGEmptyCromeClient::createWindow): (WebCore::SVGEmptyCromeClient::createModalDialog): (WebCore::SVGEmptyCromeClient::show): (WebCore::SVGEmptyCromeClient::canRunModal): (WebCore::SVGEmptyCromeClient::runModal): (WebCore::SVGEmptyCromeClient::setToolbarsVisible): (WebCore::SVGEmptyCromeClient::toolbarsVisible): (WebCore::SVGEmptyCromeClient::setStatusbarVisible): (WebCore::SVGEmptyCromeClient::statusbarVisible): (WebCore::SVGEmptyCromeClient::setScrollbarsVisible): (WebCore::SVGEmptyCromeClient::scrollbarsVisible): (WebCore::SVGEmptyCromeClient::setMenubarVisible): (WebCore::SVGEmptyCromeClient::menubarVisible): (WebCore::SVGEmptyCromeClient::setResizable): (WebCore::SVGEmptyCromeClient::addMessageToConsole): (WebCore::SVGEmptyCromeClient::canRunBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::runBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::closeWindowSoon): (WebCore::SVGEmptyFrameLoaderClient::~SVGEmptyFrameLoaderClient): (WebCore::SVGEmptyFrameLoaderClient::frameLoaderDestroyed): (WebCore::SVGEmptyFrameLoaderClient::hasWebView): (WebCore::SVGEmptyFrameLoaderClient::hasFrameView): (WebCore::SVGEmptyFrameLoaderClient::hasBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::resetBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::provisionalItemIsTarget): (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemPageCache): (WebCore::SVGEmptyFrameLoaderClient::privateBrowsingEnabled): (WebCore::SVGEmptyFrameLoaderClient::makeDocumentView): (WebCore::SVGEmptyFrameLoaderClient::makeRepresentation): (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::forceLayout): (WebCore::SVGEmptyFrameLoaderClient::forceLayoutForNonHTML): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForCommit): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForInternalLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryAfterClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::setCopiesOnScroll): (WebCore::SVGEmptyFrameLoaderClient::tokenForLoadErrorReset): (WebCore::SVGEmptyFrameLoaderClient::resetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::doNotResetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent1): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent2): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent3): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent4): (WebCore::SVGEmptyFrameLoaderClient::loadedFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillPerformClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillClose): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveIcon): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveTitle): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCommitLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFirstLayout): (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage): (WebCore::SVGEmptyFrameLoaderClient::dispatchShow): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebCore::SVGEmptyFrameLoaderClient::cancelPolicyCheck): (WebCore::SVGEmptyFrameLoaderClient::dispatchUnableToImplementPolicy): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSubmitForm): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadMainResource): (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::revertToProvisionalState): (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError): (WebCore::SVGEmptyFrameLoaderClient::clearUnarchivingState): (WebCore::SVGEmptyFrameLoaderClient::progressStarted): (WebCore::SVGEmptyFrameLoaderClient::progressCompleted): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress): (WebCore::SVGEmptyFrameLoaderClient::setMainFrameDocumentReady): (WebCore::SVGEmptyFrameLoaderClient::startDownload): (WebCore::SVGEmptyFrameLoaderClient::willChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::didChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::committedLoad): (WebCore::SVGEmptyFrameLoaderClient::finishedLoading): (WebCore::SVGEmptyFrameLoaderClient::finalSetupForReplace): (WebCore::SVGEmptyFrameLoaderClient::cancelledError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowURLError): (WebCore::SVGEmptyFrameLoaderClient::interruptForPolicyChangeError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowMIMETypeError): (WebCore::SVGEmptyFrameLoaderClient::fileDoesNotExistError): (WebCore::SVGEmptyFrameLoaderClient::shouldFallBack): (WebCore::SVGEmptyFrameLoaderClient::setDefersLoading): (WebCore::SVGEmptyFrameLoaderClient::willUseArchive): (WebCore::SVGEmptyFrameLoaderClient::isArchiveLoadPending): (WebCore::SVGEmptyFrameLoaderClient::cancelPendingArchiveLoad): (WebCore::SVGEmptyFrameLoaderClient::clearArchivedResources): (WebCore::SVGEmptyFrameLoaderClient::canHandleRequest): (WebCore::SVGEmptyFrameLoaderClient::canShowMIMEType): (WebCore::SVGEmptyFrameLoaderClient::representationExistsForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::generatedMIMETypeForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::frameLoadCompleted): (WebCore::SVGEmptyFrameLoaderClient::restoreScrollPositionAndViewState): (WebCore::SVGEmptyFrameLoaderClient::provisionalLoadStarted): (WebCore::SVGEmptyFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebCore::SVGEmptyFrameLoaderClient::addHistoryItemForFragmentScroll): (WebCore::SVGEmptyFrameLoaderClient::didFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::prepareForDataSourceReplacement): (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader): (WebCore::SVGEmptyFrameLoaderClient::setTitle): (WebCore::SVGEmptyFrameLoaderClient::userAgent): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient): (WebCore::SVGEmptyEditorClient::pageDestroyed): (WebCore::SVGEmptyEditorClient::shouldDeleteRange): (WebCore::SVGEmptyEditorClient::shouldShowDeleteInterface): (WebCore::SVGEmptyEditorClient::smartInsertDeleteEnabled): (WebCore::SVGEmptyEditorClient::isContinuousSpellCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleContinuousSpellChecking): (WebCore::SVGEmptyEditorClient::isGrammarCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleGrammarChecking): (WebCore::SVGEmptyEditorClient::spellCheckerDocumentTag): (WebCore::SVGEmptyEditorClient::selectWordBeforeMenuEvent): (WebCore::SVGEmptyEditorClient::isEditable): (WebCore::SVGEmptyEditorClient::shouldBeginEditing): (WebCore::SVGEmptyEditorClient::shouldEndEditing): (WebCore::SVGEmptyEditorClient::shouldInsertNode): (WebCore::SVGEmptyEditorClient::shouldInsertText): (WebCore::SVGEmptyEditorClient::shouldApplyStyle): (WebCore::SVGEmptyEditorClient::didBeginEditing): (WebCore::SVGEmptyEditorClient::respondToChangedContents): (WebCore::SVGEmptyEditorClient::didEndEditing): (WebCore::SVGEmptyEditorClient::registerCommandForUndo): (WebCore::SVGEmptyEditorClient::registerCommandForRedo): (WebCore::SVGEmptyEditorClient::clearUndoRedoOperations): (WebCore::SVGEmptyEditorClient::canUndo): (WebCore::SVGEmptyEditorClient::canRedo): (WebCore::SVGEmptyEditorClient::undo): (WebCore::SVGEmptyEditorClient::redo): (WebCore::SVGEmptyEditorClient::dataForArchivedSelection): (WebCore::SVGEmptyEditorClient::userVisibleString): (WebCore::SVGEmptyContextMenuClient::~SVGEmptyContextMenuClient): (WebCore::SVGEmptyContextMenuClient::contextMenuDestroyed): (WebCore::SVGEmptyContextMenuClient::addCustomContextMenuItems): (WebCore::SVGEmptyContextMenuClient::contextMenuItemSelected): (WebCore::SVGEmptyContextMenuClient::downloadURL): (WebCore::SVGEmptyContextMenuClient::copyImageToClipboard): (WebCore::SVGEmptyContextMenuClient::lookUpInDictionary): (WebCore::SVGEmptyContextMenuClient::speak): (WebCore::SVGEmptyContextMenuClient::stopSpeaking): (WebCore::SVGEmptyContextMenuClient::searchWithSpotlight):
12:27 AM Changeset in webkit [18469] by eseidel
  • 2 edits in trunk/WebKitTools

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by olliej.

Stop DumpRenderTree from reporting false Frame/Node leaks due to new SVGImage

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): clear WebCore cache before exiting
12:15 AM Changeset in webkit [18468] by ddkilzer
  • 3 edits
    1 delete in trunk

LayoutTests:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

  • webarchive/resources/apple.gif: Removed.
  • webarchive/resources/dump-webarchive.js: Removed.
  • webarchive/resources/test-frame.html: Removed.
  • webarchive/resources/test-style.css: Removed.
  • webarchive/test-body-background-expected.txt: Removed.
  • webarchive/test-body-background.html: Removed.
  • webarchive/test-duplicate-resources-expected.txt: Removed.
  • webarchive/test-duplicate-resources.html: Removed.
  • webarchive/test-frameset-expected.txt: Removed.
  • webarchive/test-frameset.html: Removed.
  • webarchive/test-img-src-expected.txt: Removed.
  • webarchive/test-img-src.html: Removed.
  • webarchive/test-input-src-expected.txt: Removed.
  • webarchive/test-input-src.html: Removed.
  • webarchive/test-link-href-expected.txt: Removed.
  • webarchive/test-link-href.html: Removed.
  • webarchive/test-object-data-expected.txt: Removed.
  • webarchive/test-object-data.html: Removed.
  • webarchive/test-script-src-expected.txt: Removed.
  • webarchive/test-script-src.html: Removed.
  • webarchive/test-table-background-expected.txt: Removed.
  • webarchive/test-table-background.html: Removed.
  • webarchive/test-td-background-expected.txt: Removed.
  • webarchive/test-td-background.html: Removed.

WebKitTools:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

  • DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML): Removed. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Removed. (runTest):
Note: See TracTimeline for information about the timeline view.