⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 4, 2007:

11:44 PM Changeset in webkit [18614] by aroben
  • 7 edits in trunk

WebCore:

Reviewed by Geoff, cheered by others.

Dead code elimination.

All layout tests pass.

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

WebKit:

Reviewed by Geoff, cheered by others.

Dead code elimination.

  • WebView/WebHTMLView.m:
11:26 PM Changeset in webkit [18613] by aroben
  • 2 edits in trunk/WebKit

Boo on me for undoing Beth's hard work.

  • WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Undo a mistaken roll out of r18597.
11:21 PM Changeset in webkit [18612] by ddkilzer
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Brady.

  • DefaultDelegates/WebDefaultPolicyDelegate.m: Initialize isDirectory.
10:36 PM Changeset in webkit [18611] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

Speed up svn-create-patch for copied and moved files.

  • Scripts/svn-create-patch: (manufacturePatchForAdditionWithHistory($$)): Use 'svn cat' instead of 'svn cat -rNNNNN' so svn pulls original from local disk.
10:28 PM Changeset in webkit [22730] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Fix: <rdar://4763580> Support tabbing between subframes
Fix: <rdar://4763595> Support tabbing out of the document back into the
Safari UI

  • Interfaces/IWebUIDelegate.idl: Added declarations of new methods.
  • WebBackForwardList.cpp: (WebBackForwardList::backItem): Changed to return E_FAIL if returning a null pointer. (WebBackForwardList::currentItem): Ditto. (WebBackForwardList::forwardItem): Ditto.
  • WebChromeClient.cpp: (WebChromeClient::canTakeFocus): Added new click method. (WebChromeClient::takeFocus): Ditto. (WebChromeClient::focus): Removed unnecessary null check. (WebChromeClient::unfocus): Ditto. (WebChromeClient::createWindow): Ditto. (WebChromeClient::createModalDialog): Ditto. (WebChromeClient::show): Ditto. (WebChromeClient::canRunModal): Ditto. (WebChromeClient::runModal): Ditto. (WebChromeClient::setToolbarsVisible): Ditto. (WebChromeClient::toolbarsVisible): Ditto. (WebChromeClient::setStatusbarVisible): Ditto. (WebChromeClient::statusbarVisible): Ditto. (WebChromeClient::setMenubarVisible): Ditto. (WebChromeClient::menubarVisible): Ditto. (WebChromeClient::setResizable): Ditto. (WebChromeClient::addMessageToConsole): Ditto.
  • WebChromeClient.h: Added declarations.
10:18 PM Changeset in webkit [18610] by aroben
  • 36 edits
    14 adds in trunk

LayoutTests:

Reviewed by Geoff.

Added new tests for tabindex and tabbing into/out of subframes.

  • fast/dom/tabindex-clamp-expected.txt: Added.
  • fast/dom/tabindex-clamp.html: Added.
  • fast/events/frame-click-focus-expected.txt: Added.
  • fast/events/frame-click-focus.html: Added.
  • fast/events/frame-tab-focus-expected.txt: Added.
  • fast/events/frame-tab-focus.html: Added.
  • fast/events/resources/frame-tab-focus-child.html: Added.
  • fast/events/resources/frame-tab-focus-empty-child.html: Added.
  • fast/events/resources/frame-tab-focus-empty-middle.html: Added.
  • fast/events/resources/frame-tab-focus-middle.html: Added.
  • fast/events/resources/frame-tab-focus-upper.html: Added.
  • fast/html/tab-order-expected.txt: Added.
  • fast/html/tab-order.html: Added.

Updated test to match new behavior.

  • fast/forms/focus2-expected.txt: Updated results.
  • fast/forms/focus2.html: Fixed typo, and reduced the number of tab events dispatched now that frames containing focusable elements aren't themselves in the tab order.

WebCore:

Reviewed by Geoff.

Fix: <rdar://4800335> REGRESSION: shift-tabbing from location field
goes to first field rather than last (businessweek.com)

Fix: <rdar://4800373> REGRESSION: tabbing from last control focuses
nothing visible (busniessweek.com)

Handle tabbing into/out of subframes in WebCore instead of letting
AppKit do the dirty work. This change also fixes a number of bugs and
changes some behavior to match other browsers:

  • No frames receive a focus event when the page is first loaded.
  • When a frame is clicked or focused with the keyboard, it receives a focus event and all other frames receive a blur event.
  • tabindex values are clamped to the range of a signed short, rather than overflowing within an unsigned short.
  • tabindex is respected on frame owner elements, even though HTML4 says it shouldn't be.
  • Subframes will be focused when tabbing if they don't contain any focusable elements within them (it would be nice to only focus the frame if it has scrollbars).

Renamed SelectionDirection to FocusDirection and put it in its own file.

  • page/FocusDirection.h: Added. (WebCore::):
  • page/mac/WebCoreFrameBridge.mm: Updated for renames. (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):

Moved advanceFocus from EventHandler to FocusController and added
support for moving into/out of subframes..

  • page/EventHandler.cpp: Moved advanceFocus to FocusController.
  • page/EventHandler.h: Ditto.
  • page/FocusController.cpp: (WebCore::deepFocusableNode): Static helper function to find focusable nodes nested within frames. (WebCore::FocusController::advanceFocus): Moved from EventHandler and rewritten to handle subframes.
  • page/FocusController.h: Added advanceFocus declaration.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Updated for the move of advanceFocus to FocusController.
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::isFrameOwnerElement): New method. (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable): New virtual implementation used to trick Document::nextFocusableNode so that we can focus frames.

Rewrote/renamed
Document::nextFocusableNode/Document::previousFocusableNode.

  • dom/Document.cpp: (WebCore::nextNodeWithExactTabIndex): New static helper function. (WebCore::previousNodeWithExactTabIndex): Ditto. (WebCore::nextNodeWithGreaterTabIndex): Ditto. (WebCore::previousNodeWithLowerTabIndex): Ditto. (WebCore::Document::nextFocusableNode): Renamed from nextFocusedNode, and rewritten with much simpler logic. (WebCore::Document::previousFocusableNode): Ditto.
  • dom/Document.h: Updated declarations for renames.
  • page/mac/EventHandlerMac.mm: Updated for rename of SelectionDirection to FocusDirection. (WebCore::EventHandler::nextKeyViewInFrame): Updated for renames. (WebCore::EventHandler::nextKeyViewInFrameHierarchy): Ditto. (WebCore::EventHandler::nextKeyView): Ditto. (WebCore::EventHandler::focusDocumentView): Added call to setFocusedFrame when focusing the document view. (WebCore::EventHandler::passMouseDownEventToWidget): Removed LOG_ERROR when a nil NSView is returned from AppKit, as this is a fairly common occurrence when a RenderWidget has a border. (WebCore::EventHandler::passWheelEventToWidget): Added a nil-check of the hit-tested NSView.

Changed storage of tabIndex to a signed short, and added clamping of
tabindex attribute values to match Firefox's behavior.

  • dom/Node.h: Use a signed short to store m_tabIndex. (WebCore::Node::isFrameOwnerElement): New method. (WebCore::Node::tabIndex): Updated for signedness. (WebCore::Node::setTabIndex): Ditto.
  • html/HTMLAnchorElement.cpp: Remove implementation of tabIndex() so that Node::tabIndex() will be called instead and return the clamped value (which matches Firefox's behavior).
  • html/HTMLAnchorElement.h: Ditto.
  • html/HTMLAreaElement.cpp: Ditto.
  • html/HTMLAreaElement.h: Ditto.
  • html/HTMLGenericFormElement.cpp: Ditto.
  • html/HTMLGenericFormElement.h: Ditto.
  • html/HTMLObjectElement.cpp: Ditto.
  • html/HTMLObjectElement.h: Ditto.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Clamp tabIndex to the range of a signed short to match Firefox.

Added two new Chrome methods for transferring focus out of the
WebView.

  • page/Chrome.cpp: (WebCore::Chrome::canTakeFocus): (WebCore::Chrome::takeFocus):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: Fixed typo "CromeClient" -> "ChromeClient". (WebCore::SVGEmptyChromeClient::~SVGEmptyChromeClient): (WebCore::SVGEmptyChromeClient::canTakeFocus): (WebCore::SVGEmptyChromeClient::takeFocus):
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData): Fixed typo.

Miscellaneous:

  • WebCore.exp: Updated/sorted symbols.
  • WebCore.xcodeproj/project.pbxproj: Made FocusController.h Private so WebKit can access it.

WebKit:

Reviewed by Geoff.

Remove WebKit/AppKit from handling tabbing between subframes.

  • WebCoreSupport/WebChromeClient.h: Added new ChromeClient methods for moving focus out of the WebView.
  • WebCoreSupport/WebChromeClient.mm: Ditto. (WebChromeClient::canTakeFocus): (WebChromeClient::takeFocus):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): Added null-check of m_frame.
  • WebView/WebHTMLView.m: Removed -[WebHTMLView nextValidKeyView]. (-[WebHTMLView _updateActiveState]): Changed to focus the frame if WebCore believes it to be the focused frame. (-[WebHTMLView becomeFirstResponder]): Rewrote to call into FocusController to place focus correctly within the WebView.
9:58 PM Changeset in webkit [18609] by beidson
  • 2 edits in trunk/WebCore

Reverted Anders' change to fix the world

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse):
9:56 PM Changeset in webkit [18608] by ddkilzer
  • 14 edits in trunk/WebCore

WebCore:

Reviewed by Sam Weinig.

  • Coding style cleanup.
  • Canceled AutoTableLayout and FixedTableLayout being friend classes of RenderTable. Instead, added public accessors to RenderTable for what the table layout classes need and changed TableLayout::calcMinMaxWidth() to take references to the caller's min and max widths.
  • Made RenderTableSection's grid protected and moved code that accessed it from RenderTable into RenderTableSection.

No test possible (no change to functionality).

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::layout):
  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout):
  • rendering/FixedTableLayout.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::~RenderTable): (WebCore::RenderTable::setStyle): (WebCore::RenderTable::addChild): (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::setCellWidths): (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::calcMinMaxWidth): (WebCore::RenderTable::splitColumn): Factored out the section work to RenderTableSection::splitColumn(). (WebCore::RenderTable::appendColumn): Factored out the section work to RenderTableSection::appendColumn(). (WebCore::RenderTable::colElement): (WebCore::RenderTable::recalcSections): (WebCore::RenderTable::removeChildNode): (WebCore::RenderTable::calcBorderLeft): (WebCore::RenderTable::calcBorderRight): (WebCore::RenderTable::outerBorderTop): (WebCore::RenderTable::outerBorderBottom): (WebCore::RenderTable::outerBorderLeft): (WebCore::RenderTable::outerBorderRight): (WebCore::RenderTable::sectionAbove): (WebCore::RenderTable::sectionBelow): (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): (WebCore::RenderTable::cellBefore): (WebCore::RenderTable::getOverflowClipRect): (WebCore::RenderTable::dump):
  • rendering/RenderTable.h: (WebCore::RenderTable::getColumnPos): (WebCore::RenderTable::hBorderSpacing): (WebCore::RenderTable::vBorderSpacing): (WebCore::RenderTable::getRules): (WebCore::RenderTable::cellPadding): (WebCore::RenderTable::setCellPadding): (WebCore::RenderTable::ColumnStruct::ColumnStruct): (WebCore::RenderTable::columns): Added this accessor. (WebCore::RenderTable::columnPositions): Added this accessor. (WebCore::RenderTable::header): (WebCore::RenderTable::footer): (WebCore::RenderTable::firstBody): (WebCore::RenderTable::numEffCols): (WebCore::RenderTable::spanOfEffCol): (WebCore::RenderTable::colToEffCol): (WebCore::RenderTable::effColToCol): (WebCore::RenderTable::bordersPaddingAndSpacing): (WebCore::RenderTable::needsSectionRecalc): (WebCore::RenderTable::setNeedsSectionRecalc): Renamed setNeedSectionRecalc() to this. (WebCore::RenderTable::hasSections): (WebCore::RenderTable::recalcSectionsIfNeeded):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::destroy): (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::styleOrColWidth): (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::absolutePosition): (WebCore::RenderTableCell::baselinePosition): (WebCore::RenderTableCell::setStyle): (WebCore::compareBorders): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::paint): (WebCore::collapsedBorderStyle): (WebCore::CollapsedBorder::CollapsedBorder): (WebCore::CollapsedBorders::CollapsedBorders): (WebCore::CollapsedBorders::addBorder): (WebCore::CollapsedBorders::nextBorder): (WebCore::RenderTableCell::paintCollapsedBorder): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations): (WebCore::RenderTableCell::dump):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::colSpan): (WebCore::RenderTableCell::setColSpan): (WebCore::RenderTableCell::rowSpan): (WebCore::RenderTableCell::setRowSpan): (WebCore::RenderTableCell::col): (WebCore::RenderTableCell::setCol): (WebCore::RenderTableCell::row): (WebCore::RenderTableCell::setRow): (WebCore::RenderTableCell::section): (WebCore::RenderTableCell::table): (WebCore::RenderTableCell::yPos): (WebCore::RenderTableCell::setCellTopExtra): (WebCore::RenderTableCell::setCellBottomExtra): (WebCore::RenderTableCell::borderTopExtra): (WebCore::RenderTableCell::borderBottomExtra):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::destroy): (WebCore::RenderTableRow::setStyle): (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::layout): (WebCore::RenderTableRow::getAbsoluteRepaintRect): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::section): (WebCore::RenderTableRow::table): (WebCore::RenderTableRow::lineHeight):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::destroy): (WebCore::RenderTableSection::setStyle): (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::calcOuterBorderTop): (WebCore::RenderTableSection::calcOuterBorderBottom): (WebCore::RenderTableSection::calcOuterBorderLeft): (WebCore::RenderTableSection::calcOuterBorderRight): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::clearGrid): (WebCore::RenderTableSection::numColumns): (WebCore::RenderTableSection::appendColumn): Added. Moved code from RenderTable::appendColumn() into here. (WebCore::RenderTableSection::splitColumn): Added. Moved code from RenderTable::splitColumn() into here. (WebCore::RenderTableSection::removeChildNode): (WebCore::RenderTableSection::dump):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::renderName): (WebCore::RenderTableSection::isTableSection): (WebCore::RenderTableSection::lineHeight): (WebCore::RenderTableSection::table): (WebCore::RenderTableSection::cellAt): (WebCore::RenderTableSection::numRows): (WebCore::RenderTableSection::recalcCellsIfNeeded): (WebCore::RenderTableSection::needsCellRecalc): (WebCore::RenderTableSection::setNeedsCellRecalc): (WebCore::RenderTableSection::getBaseline):
  • rendering/TableLayout.h:
9:14 PM Changeset in webkit [18607] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=12120
REGRESSION(r18605): Safari snippet editor no longer works


  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Fix logic so applewebdata: URLs no longer cause the underlying URL to be fetched .
7:34 PM Changeset in webkit [18606] by andersca
  • 10 edits in trunk/WebCore

Reviewed by Adam.

Move all remaining instances of NSURLRequest over to ResourceRequest (well, pretty much all).

  • loader/MainResourceLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoadingMainResource):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create):
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
6:46 PM Changeset in webkit [22729] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

6:40 PM Changeset in webkit [18605] by andersca
  • 17 edits in trunk

WebCore:

Reviewed by Brady.

Move more NSURLRequests over to ResourceRequests.


  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::request):
  • loader/SubresourceLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::setDefersLoading):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::cancelledError):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
  • platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isNull):
  • platform/network/ResourceRequest.h:

WebKit:

Reviewed by Brady.

FrameLoaderClient changed yet again.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchWillSendRequest):
6:38 PM Changeset in webkit [18604] by sfalken
  • 1 copy in tags/Safari-521.32.9b

New tag.

6:20 PM Changeset in webkit [18603] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe

​http://bugs.webkit.org/show_bug.cgi?id=12119
Changing the behavior of HistoryItem::pageCache() this morning also necessitated
changing the behavior of HistoryItem::hasPageCache()

  • history/HistoryItem.cpp: (WebCore::HistoryItem::hasPageCache): Add the same pendingRelease check pageCache() has
4:36 PM Changeset in webkit [18602] by bdash
  • 4 edits
    4 adds in trunk

2007-01-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

Test: fast/borders/border-radius-huge-assert.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Fixed the check for border radii that do not fit in the given width or height to work with radii that sum up to more than MAX_INT.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder): Ditto.

2007-01-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

  • fast/borders/border-radius-huge-assert-expected.checksum: Added.
  • fast/borders/border-radius-huge-assert-expected.png: Added.
  • fast/borders/border-radius-huge-assert-expected.txt: Added.
  • fast/borders/border-radius-huge-assert.html: Added.
4:35 PM Changeset in webkit [18601] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4861080>
GMail Editor: Crash when dropping content into certain list items

  • editing/pasteboard/4861080-expected.checksum: Added.
  • editing/pasteboard/4861080-expected.png: Added.
  • editing/pasteboard/4861080-expected.txt: Added.
  • editing/pasteboard/4861080.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4861080>
GMail Editor: Crash when dropping content into certain list items


A rendering bug (4907469) creates unwanted space at the top of a
list item when its contents are wrapped in span. Dropping content
inside that space causes a crash because positionForCoordinates
fails there and the code that creates drag carets can't handle it.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]): Added the that's inside click handling for the case where positionForCoordinates returns null. We should also fix positionForCoordinates but that's less important: now its only side effect is that a no-op drop is performed instead of a snap back when you drop the contents of one of these list items its own unwanted space.
4:14 PM Changeset in webkit [18600] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12118 REGRESSION
(Context menus): No context menu displayed when clicking outside a
short document

No test case added since we do not currently have a way to automate
context menus.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): If the hit test does not find a node, use the document node.
4:04 PM Changeset in webkit [18599] by hyatt
  • 1 edit in trunk/LayoutTests/fast/table/absolute-table-at-bottom-expected.txt

Fix table test for bold change. No idea why this changed by a pixel though.

3:59 PM Changeset in webkit [18598] by andersca
  • 10 edits in trunk

WebCore:

Reviewed by Adam.

Convert NSURLRequest to ResourceRequest in a few places

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willUseArchive):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::willUseArchive):

WebKit:

Reviewed by Adam.

FrameLoaderClient changed again.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): (WebFrameLoaderClient::willUseArchive):
3:22 PM Changeset in webkit [18597] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Adam.

No need to hit test twice.

  • WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
3:13 PM Changeset in webkit [18596] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-01-04 sareen <​shyam.sareen@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Submit button can not be pressed after unsuccessful login to gmail.com
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12113

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
2:58 PM Changeset in webkit [18595] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float

New layout test for bug 12114.

2:58 PM Changeset in webkit [18594] by hyatt
  • 2 edits in trunk/WebCore

Bug 12114 fix, make sure left/right floats are allowed to go above
other floats of opposite alignment.

Reviewed by aroben

fast/block/float/independent-align-positioning.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):
2:56 PM Changeset in webkit [18593] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=12116
REGRESSION: ASSERTION FAILED: URL in +[WebDataProtocol _webIsDataProtocolURL:]


<rdar://problem/4908910>
REGRESSION: After switching to Bookmarks view, the browser window is completely empty (no bookmarks are displayed)


  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): Initialize m_isNull
1:57 PM Changeset in webkit [22728] by bdakin
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

A few changes needed to turn on WebCore context menus on the Mac.

  • WebContextMenuClient.cpp: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description. (WebContextMenuClient::getCustomMenuFromDefaultItems): Same.
  • WebContextMenuClient.h: Same.
1:47 PM Changeset in webkit [18592] by bdakin
  • 13 edits in trunk

WebCore:

Reviewed by Adam.

Turn on WebCore context menus.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Turn on WebCore menus.
  • page/ContextMenuClient.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Above name change. (WebCore::ContextMenuController::contextMenuItemSelected): Use local variable.
  • platform/ContextMenu.cpp: (WebCore::createAndAppendSpeechSubMenu): Fix silly mistake -- make "Stop speaking" actually stop speaking.
  • platform/graphics/svg/SVGImageEmptyClients.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.

(WebCore::SVGEmptyContextMenuClient::getCustomMenuFromDefaultItems):

WebKit:

Reviewed by Adam.

Turn on WebCore context menus. Delete a bunch of WebKit context
menu code that is no longer needed.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed a lot of code from this class. This class only still needs to exist for PDF context menus, so we only need to deal with the menu items that might possibly be added to a PDF context menu. (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Same. (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Same.
  • WebCoreSupport/WebContextMenuClient.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.
  • WebCoreSupport/WebContextMenuClient.mm: Same. (WebContextMenuClient::getCustomMenuFromDefaultItems): Same. Also move in some code that used to be in _menuForElement.
  • WebView/WebHTMLView.m: Deleted a bunch of un-used functions (-[WebHTMLView menuForEvent:]): Turn on menus, and append the Inspect Element item.
  • WebView/WebHTMLViewPrivate.h: Deleted a bunch of un-used functions.
  • WebView/WebView.mm: (-[WebView _menuForElement:defaultItems:]): Removed a lot of code from _menuForElement that now makes more sense elsewhere. Only PDF context menus use this function now. Hopefully we can just get rid of it soon, too.
1:27 PM Changeset in webkit [18591] by yongjzha
  • 2 edits in S60/trunk/WebKit

2007-01-02 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin Padma.
DESC: Clicking links does not work after browser looses focus (TMCN-6UVJRL)
​http://bugs.webkit.org/show_bug.cgi?id=11983

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL): (CWebKitControl::FinalProgressComplete):
1:03 PM Changeset in webkit [18590] by hyatt
  • 3 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update for synthetic bold change.

1:02 PM Changeset in webkit [18589] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-04 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Clicking links does not work after browser looses focus (TMCN-6UVJRL)
​http://bugs.webkit.org/show_bug.cgi?id=11983

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL): (CWebKitControl::FinalProgressComplete):
12:59 PM Changeset in webkit [22727] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Always use 1.0 as the synthetic bold offset for now. Fixes bug 9534.

Reviewed by olliej

  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit):
12:52 PM Changeset in webkit [18588] by beidson
  • 5 edits in trunk/WebCore

Reviewed and landed by Brady

Allow a PageCache that is pending release to be resurrected by its
HistoryItem instead of creating a new PageCache. This avoids the
the condition of having two PageCaches for the same HistoryItem, one
current and one pending release but not yet released, which was causing
this and other bugs before.


Replaced the vector of PageCaches pending release with a set of
HistoryItems that are pending release of their PageCache.

  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setHasPageCache): Check for an existing PageCache pending release, and if found, resurrect it by canceling the release. (WebCore::HistoryItem::pageCache): Return 0 if the PageCache is pending release. (WebCore::itemsWithPendingPageCacheToRelease): Renamed pendingPageCacheToRelease to this. This method now returns a HashSet of HistoryItems that have scheduled their PageCaches for release. (WebCore::HistoryItem::releasePageCachesOrReschedule): Renamed releasePageCache to this. (WebCore::HistoryItem::releasePageCache): Added. Actually closes and releases the PageCache. (WebCore::HistoryItem::releaseAllPendingPageCaches): Rolled closeObjectsInPendingPageCaches into this method. (WebCore::HistoryItem::scheduleRelease): (WebCore::HistoryItem::cancelRelease): Added.
  • history/HistoryItem.h: Removed unused declaration of scheduleReleaseTimer()
  • history/HistoryItemTimer.cpp: (WebCore::HistoryItemTimer::HistoryItemTimer): (WebCore::HistoryItemTimer::callReleasePageCachesOrReschedule):
  • history/HistoryItemTimer.h:
12:50 PM Changeset in webkit [18587] by hyatt
  • 2 edits in trunk/WebCore

Just make the synthetic bold offset always be 1.0. This fixes bug
9534, synthetic bold looks doubled.

Reviewed by olliej

  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
11:25 AM Changeset in webkit [18586] by andersca
  • 26 edits in trunk

WebCore:

Reviewed by Brady.

Convert almost all occurrences of NSURLResponse to ResourceResponse.

  • WebCore.exp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/loader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::loadNow):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::response):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isHTTP):
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isNull):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):

WebKit:

Reviewed by Brady.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::incrementProgress):
11:21 AM Changeset in webkit [18585] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4887422>
​http://bugs.webkit.org/show_bug.cgi?id=11848
REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)

  • fast/forms/searchfield-heights-expected.checksum: Added.
  • fast/forms/searchfield-heights-expected.png: Added.
  • fast/forms/searchfield-heights-expected.txt: Added.
  • fast/forms/searchfield-heights.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/searchfield-heights.html

Override the border and the height for search fields that use -webkit-appearance: searchfield.

  • css/html4.css: Use box-sizing: border-box for search fields. We don't need to have the border-box quirk that we use for the other text fields for this control.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::searchFieldSizes): Added. (WebCore::RenderThemeMac::setSearchFieldSize): Added. (WebCore::RenderThemeMac::adjustSearchFieldStyle): Override the border and the height of the search field.
10:58 AM Changeset in webkit [18584] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

  • kjs/DateMath.cpp: (KJS::getUTCOffset): Don't cache UTC offset.
10:42 AM Changeset in webkit [18583] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2007-01-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301
​http://bugs.webkit.org/show_bug.cgi?id=11787

  • BrowserView/inc/HttpLoaderEventToUiListener.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):
10:31 AM Changeset in webkit [18582] by yongjzha
  • 2 edits in S60/trunk/WebKit

2007-01-03 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongjun Zhang.
DESC: fix for aol.co.uk crash (3.2)
​http://bugs.webkit.org/show_bug.cgi?id=12102

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::TileInRect):
6:09 AM Changeset in webkit [18581] by lars
  • 2 edits in trunk/WebKitTools

compile DumpRenderTree with RPATH. Hopefully this will
fix the automatic regression tests.

6:08 AM Changeset in webkit [18580] by lars
  • 2 edits in trunk/WebCore

Add some missing stubs

4:49 AM Changeset in webkit [18579] by ap
  • 19 edits in trunk

2007-01-04 Don Gibson <​dgibson77@gmail.com>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11900:
Windows build bustage

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
  • platform/graphics/Image.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::adjustLineToPixelBoundaries): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawTiled):
  • platform/graphics/win/ImageWin.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource):
  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::userIdleTime): (WebCore::BitmapImage::drawTiled): (WebCore::BitmapImage::getHBITMAP): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::urlForHistory): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::FrameLoader::load): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::applyUserAgent): (WebCore::GraphicsContext::strokeRect): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): (WebCore::PageCache::close): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::SearchPopupMenu):

WebKit:

  • COM/ChromeClientWin.cpp: (ChromeClientWin::addMessageToConsole): (ChromeClientWin::runBeforeUnloadConfirmPanel):
  • COM/ChromeClientWin.h:
  • COM/ContextMenuClientWin.cpp: (ContextMenuClientWin::contextMenuItemSelected):
  • COM/ContextMenuClientWin.h:
  • COM/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebFrameLoaderClient::updateGlobalHistoryForReload): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::saveDocumentViewToPageCache): (WebFrameLoaderClient::canCachePage):
  • COM/WebFrameLoaderClient.h:
  • WebKit.vcproj/WebKit.vcproj:
3:38 AM Changeset in webkit [18578] by ap
  • 2 edits in trunk/WebKitSite

2007-01-04 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11295
Nightly download size is misleading

  • images/download.png: Changed the size to 6 MB.
3:23 AM Changeset in webkit [18577] by ap
  • 7 edits
    3 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11611
REGRESSION: No http referer header sent on XMLHttpRequest

Test: http/tests/xmlhttprequest/referer.html

  • loader/FrameLoader.h: Removed FrameLoader::addExtraFieldsToRequest(NSMutableURLRequest*, bool, bool), which is no longer used.
  • loader/mac/FrameLoaderMac.mm: Ditto.
  • WebCore.exp: Do not export this method (WebKit doesn't use it).
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create): Rewrote to create the request with ResourceRequest::nsURLRequest.
  • platform/PlatformString.h: (WebCore::operator!): Added. Previously, attempts to use operator! on a String would result with an NSString* conversion, which never returns nil. This was causing a problem in SubresourceLoader::create().

Jan 3, 2007:

11:48 PM Changeset in webkit [18576] by lars
  • 2 edits in trunk/WebCore

fix the Qt build

10:36 PM Changeset in webkit [18575] by bdash
  • 4 edits in trunk/LayoutTests

2007-01-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

  • css1/box_properties/acid_test-expected.checksum:
  • css1/box_properties/acid_test-expected.png:
  • css1/box_properties/acid_test-expected.txt:
9:28 PM Changeset in webkit [18574] by ddkilzer
  • 37 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum:
  • css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum:
  • css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
  • css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • css2.1/t09-c5526c-display-00-e-expected.checksum:
  • css2.1/t09-c5526c-display-00-e-expected.png:
  • css2.1/t09-c5526c-display-00-e-expected.txt:
  • fast/block/basic/011-expected.checksum:
  • fast/block/basic/011-expected.png:
  • fast/block/basic/011-expected.txt:
  • fast/css/percentage-non-integer-expected.checksum: Added.
  • fast/css/percentage-non-integer-expected.png: Added.
  • fast/css/percentage-non-integer-expected.txt: Added.
  • fast/css/percentage-non-integer.html: Added.
  • tables/mozilla/bugs/bug4385-expected.checksum:
  • tables/mozilla/bugs/bug4385-expected.png:
  • tables/mozilla/bugs/bug4385-expected.txt:
  • tables/mozilla_expected_failures/core/col_span2-expected.checksum:
  • tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

Reviewed by Hyatt.

Test: fast/css/percentage-non-integer.html

Added floating point constructor and accessors to Length for use with
Percent lengths only. The raw value of a percent length is the integer
part of a constant multiple of the original double value. The constant
is percentScaleFactor, which is currently 128.


Added assertions that the correct constructors and accessors are used
depending on the type: the double-based percent(), setValue() and Length()
for the Percent type, and the integer-based value(), setValue() and Length()
for all other types.


calcValue() and calcMinValue() work the same as before, regardless of the
type.

Added helpers for testing if the value is 0, positive, negative or undefined
without having to check the type first.


Added raw value accessors. These are useful for doing integer math and
comparisons with scaled percent values or doing Length type-agnostic math.

Changed the rest of the code to use the appropriate accessors and helpers.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): (WebCore::primitiveValueFromLength): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • platform/StringImpl.cpp: (WebCore::parseLength):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/Length.h: (WebCore::Length::Length): (WebCore::Length::value): (WebCore::Length::rawValue): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/RenderBR.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock):
  • rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/RenderLayer.cpp: (WebCore::Marquee::direction): (WebCore::Marquee::start):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::lineHeight):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Added FIXMEs.
  • rendering/RenderStyle.h: (WebCore::LengthBox::nonZero): (WebCore::RenderStyle::initialLineHeight):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
9:25 PM Changeset in webkit [18573] by bdash
  • 2 edits in tags/WebKit-521.32.1/WebKit

Versioning.

9:23 PM Changeset in webkit [18572] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css/content-dynamic-expected.checksum: Added.
  • fast/css/content-dynamic-expected.png: Added.
  • fast/css/content-dynamic-expected.txt: Added.
  • fast/css/content-dynamic.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css/content-dynamic.html

  • dom/Node.cpp: (WebCore::Node::diff): Changed to return 'Detach' if the styles' content data are not equivalent.
9:19 PM Changeset in webkit [18571] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/frames/negative-remaining-length-crash-expected.txt: Added.
  • fast/frames/negative-remaining-length-crash.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/frames/negative-remaining-length-crash.html

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Treat negative availableLength as zero.
6:17 PM Changeset in webkit [18570] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

  • Scripts/run-webkit-tests: Launch Safari using the same WebKit build configuration as the layout tests used.
6:01 PM Changeset in webkit [18569] by sullivan
  • 2 edits in trunk/WebCore

Written by Darin over my shoulder; reviewed by me

  • fixed <rdar://problem/4907437> Find doesn't work if invoked when a form field is focused
  • page/Frame.cpp: (WebCore::isInShadowTree): new helper function used by findString (WebCore::Frame::findString): when deciding whether to start from the selection, ignore selections that are in a shadow tree (i.e. in a form control)
5:21 PM Changeset in webkit [18568] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=12089

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader
5:20 PM Changeset in webkit [18567] by sullivan
  • 2 edits in trunk/WebKit
  • WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]
5:07 PM Changeset in webkit [18566] by hyatt
  • 4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for inline generated content.

5:07 PM Changeset in webkit [18565] by hyatt
  • 2 edits in trunk/WebCore

Relax the display type restriction a little bit for generated content inside
inlines. We still don't allow block display types like we should (since this
will cause a crash), but we at least handle inline-table and inline-block now.

Reviewed by beth

fast/css-generated-content/inline-display-types.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updatePseudoChildForObject):
5:05 PM Changeset in webkit [18564] by justing
  • 4 edits in trunk

LayoutTests:

Reviewed by john

  • editing/pasteboard/merge-end-blockquote-expected.txt: A recent change caused an acceptable change in these expected results.

WebCore:

Reviewed by john


<rdar://problem/4663571> Spell checking won't cross boundary of individual To-Do item


No layout tests because advanceToNextMisspelling isn't yet exposed to automated tests.

  • editing/mac/EditorMac.mm: (WebCore::Editor::advanceToNextMisspelling): Confine spell checking to the highest editable root, instead of the lowest. Use firstEditablePosition... to look for an editable position.
4:57 PM Changeset in webkit [18563] by bdakin
  • 2 edits in trunk/WebCore

Fixing silly mistake.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Called wrong string function.
4:55 PM Changeset in webkit [18562] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker

  • fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the PDF in /tmp, both group and world-readable
  • WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Make the file only readable by the current user
4:53 PM Changeset in webkit [18561] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Anders

​http://bugs.webkit.org/show_bug.cgi?id=12093 - Assertion in certain SVG layout tests
I can't really think of a cleaner way to fix this then to help these SVG cases avoid
the ASSERT - hopefully we can clean up the svg-as-image situation as the loader stabilizes
and we find better ways to handle it...

  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::urlForHistory): empty-check the url before passing it to the ASSERTing method
4:49 PM Changeset in webkit [22726] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • removed some obsolete source files
  • WebCore.vcproj/WebCore.vcproj: Removed obsolete files.
4:40 PM Changeset in webkit [18560] by darin
  • 7 edits
    8 deletes in trunk/WebCore

Reviewed by Adele.

  • removed some obsolete source files
  • CMakeLists.txt: Removed obsolete files.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • html/HTMLGenericFormElement.h: Removed reference to RenderFormElement.
  • platform/qt/ComboBoxQt.cpp: Removed.
  • platform/qt/LineEditQt.cpp: Removed.
  • platform/qt/ListBoxQt.cpp: Removed.
  • platform/qt/TextEditQt.cpp: Removed.
  • rendering/RenderFormElement.cpp: Removed.
  • rendering/RenderFormElement.h: Removed.
  • rendering/RenderLabel.cpp: Removed.
  • rendering/RenderLabel.h: Removed.
4:27 PM Changeset in webkit [18559] by darin
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • test for bug where :after content appeared in the wrong order
  • fast/css-generated-content/after-order-expected.checksum: Added.
  • fast/css-generated-content/after-order-expected.png: Added.
  • fast/css-generated-content/after-order-expected.txt: Added.
  • fast/css-generated-content/after-order.html: Added.
  • fast/css-generated-content/resources/greenbox.png: Added.

WebCore:

Reviewed by Hyatt.

  • fix bug where :after content appears backwards

Test: fast/css-generated-content/after-order.html

  • rendering/RenderBlock.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderBlock::addChildToFlow): Use isAfterContent.
  • rendering/RenderInline.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderInline::addChildToFlow): Use isAfterContent.
4:15 PM Changeset in webkit [18558] by thatcher
  • 5 edits in tags/WebKit-521.32.1/WebKit

Merging r18381 and r18388.

4:04 PM Changeset in webkit [18557] by hyatt
  • 7 edits in trunk/WebCore

Implement box-shadow parsing... getting it all into the RenderStyle.

Reviewed by beth

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==): (WebCore::StyleCSS3NonInheritedData::shadowDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setBoxShadow):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::boxShadow):
3:48 PM Changeset in webkit [22725] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Add stubs for all of the localized context menu item titles. The
stubs just return English Strings until we have a localization
solution in WebKit.

3:47 PM Changeset in webkit [18556] by thatcher
  • 1 copy in tags/WebKit-521.32.1/WebKit

New tag (part 2).

3:46 PM Changeset in webkit [18555] by thatcher
  • 1 add in tags/WebKit-521.32.1

New tag (part 1).

3:38 PM Changeset in webkit [18554] by bdakin
  • 8 edits in trunk

WebCore:

Reviewed by John.

Call into WebKit to get localized strings for all of the context
menu item titles.

WebKit:

Reviewed by John.

Make localized strings for all of the context menu item titles that
are accessible to WebCore.

2:24 PM Changeset in webkit [22724] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4857027>
ragnarok online misrenders (due to lack of support for windowless plugins)

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Rename from updateHwnd since this now handles updating the clip rect for windowless plugins.


(WebCore::PluginViewWin::paintMissingPluginIcon):
New function which paints the missing plugin icon.


(WebCore::PluginViewWin::paint):
Do windowless painting here.


(WebCore::PluginViewWin::handleKeyboardEvent):
(WebCore::PluginViewWin::handleMouseEvent):
(WebCore::PluginViewWin::handleEvent):
New functions for handling mouse and keyboard events, translating them and handing them to the plugin.


(WebCore::PluginViewWin::setNPWindowRect):
Set correct window rect for windowless plugins.


(WebCore::PluginViewWin::getValue):
Add variable for containing HWND.


(WebCore::PluginViewWin::setValue):
Add windowless and transparent variables.


(WebCore::PluginViewWin::invalidateRect):
(WebCore::PluginViewWin::invalidateRegion):
(WebCore::PluginViewWin::forceRedraw):
Implement these.


(WebCore::PluginViewWin::determineQuirks):
Set quirks now that we support windowless flash.


(WebCore::PluginViewWin::PluginViewWin):
Only create the window if the plugin isn't windowless.


  • plugins/win/PluginViewWin.h: New declarations.


  • plugins/win/npapi.cpp: (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): Implement these and forward them to the plugin view.
2:19 PM Changeset in webkit [18553] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Darin and Geoff

​http://bugs.webkit.org/show_bug.cgi?id=12105 - Crash visiting Acid2 test page
-Replace lost "free nil checking" in the WebKit->WebCore conversion of the BackForwardList
-Changed ::createItem and ::createItemTree to ::createHistoryItem and ::createHistoryItemTree

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createHistoryItemTree): (WebCore::FrameLoader::updateHistoryForInternalLoad):
  • loader/FrameLoader.h:
1:48 PM Changeset in webkit [18552] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Geoff.


Allow plugin elements to handle off events to their widgets.


  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
  • html/HTMLPlugInElement.h:
  • platform/Widget.h: (WebCore::Widget::handleEvent):
12:56 PM Changeset in webkit [18551] by beidson
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan

In the Bookmarks View/History View, favicon may be the incorrect size

  • History/WebHistoryItem.mm: (-[WebHistoryItem icon]): Call to the WebIconDatabase until a WebCore issue is resolved
11:35 AM Changeset in webkit [18550] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Fix for <rdar://problem/4455147> Safari allows division slash character in URLs, which looks like slash character (not fixed by IDNScriptWhiteList.txt)
  • Misc/WebNSURLExtras.m: (allCharactersInIDNScriptWhiteList): Always disallow the division slash character.
11:16 AM Changeset in webkit [18549] by ap
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=3420
XMLHttpRequest does not handle set-cookie headers

  • http/tests/xmlhttprequest/cookies-expected.txt: Added.
  • http/tests/xmlhttprequest/cookies.html: Added.
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Added.
10:38 AM Changeset in webkit [18548] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2006-12-28 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Fix the issue with the SQL query associated with the checkin made for the following bug:
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::ReadLongTextL):
10:25 AM Changeset in webkit [18547] by yongjzha
  • 2 edits in S60/trunk/WebKit

2007-01-03 sareen <​shyam.sareen@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Vodafone Specific Storage test failing.
​http://bugs.webkit.org/show_bug.cgi?id=12101

  • ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::VSSCacheContent):
10:17 AM Changeset in webkit [18546] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-28 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Put back the patches r18389, r18183 as well as fix the issue with the SQL query.
Patches r18389, r18183 fix the following two bugs:
TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
​http://bugs.webkit.org/show_bug.cgi?id=11927
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::CFormDataAutoFillStore): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::~CFormDataAutoFillStore): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::ClearData): (CFormDataAutoFillStore::OpenDatabase): (CFormDataAutoFillStore::CloseDatabase): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):
4:04 AM Changeset in webkit [18545] by lars
  • 10 edits
    2 adds in trunk

Fix the Qt build

12:31 AM Changeset in webkit [18544] by beidson
  • 2 edits in trunk/WebKit

Controversially reviewed by Tim H. and Maciej

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=12086, ​http://bugs.webkit.org/show_bug.cgi?id=12088,
possibly ​http://bugs.webkit.org/show_bug.cgi?id=12087, and probably a slew of others

WebHistoryItems returned from the WebBackForwardList accessors were being release/retained out-of-order
by the Safari app. This bug never surfaced before because the WebBackForwardList had a retain on the
item, preventing deallocation. Since the items are now just temporary wrappers, the list
is no longer actually retaining them.

This solution is to simulate the ownership with a [[id retain] autorelease] - gross, but maybe the
only solution for now... =/

We can possibly consider reverting this fix at a later date - that task is marked by
<rdar://problem/4905705>

  • History/WebBackForwardList.mm: (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (-[WebBackForwardList itemAtIndex:]):
Note: See TracTimeline for information about the timeline view.