⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 8, 2007:

11:55 PM Changeset in webkit [18700] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Brian Dash

<rdar://problem/4895178>
WebCore::BackForwardList vector should be backed by a HashSet to remove
the potential expense in frequently calling BackForwardList::containsItem()

  • history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector (WebCore::BackForwardList::setCapacity): Ditto (WebCore::BackForwardList::close): Ditto (WebCore::BackForwardList::removeItem): Ditto (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate through the Vector
  • history/BackForwardList.h:
9:53 PM Changeset in webkit [18699] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison
in the multicol assignment operator.

  • rendering/RenderStyle.cpp: (WebCore::StyleMultiColData::operator==):
9:25 PM Changeset in webkit [18698] by darin
  • 1 edit in trunk/WebCore/ChangeLog

And forgot change log.

9:25 PM Changeset in webkit [18697] by darin
  • 1 edit in trunk/WebCore/rendering/InlineBox.cpp

Oops, forgot one file.

9:18 PM Changeset in webkit [18696] by darin
  • 2 edits in trunk/WebCore
  • rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): Used svn merge to roll the change out.
7:52 PM Changeset in webkit [18695] by bdash
  • 3 edits in trunk/WebCore

2007-01-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim H.

Build fix for 64-bit platforms.

  • platform/graphics/svg/SVGPaintServerGradient.h:
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
7:23 PM Changeset in webkit [22738] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Remove FrameLoader functions that have been implemented.


  • platform/win/TemporaryLinkStubs.cpp:
6:54 PM Changeset in webkit [18694] by andersca
  • 6 edits in trunk

WebCore:

Reviewed by Brady.

Move some history related functions off the bridge and into FrameLoader directly.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::historyURL):
  • loader/mac/FrameLoaderMac.mm:
  • page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Brady.

Remove bridge functions that are implemented directly in FrameLoader now.


  • WebCoreSupport/WebFrameBridge.mm:
6:48 PM Changeset in webkit [18693] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Mark.

Update results to include outline-color.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style.html:

WebCore:

Reviewed by Mark.

Adds outline-color to list of computable styles.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::):

WebKit:

Reviewed by Mark.

Adds default value for outline-color and fixes default
values of the recently fixed *-color properties.

6:01 PM Changeset in webkit [18692] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-01-08 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: XMLHttpRequest object not gcprotected when !USE_CONSERVATIVE_GC
​http://bugs.webkit.org/show_bug.cgi?id=12157

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
5:54 PM Changeset in webkit [18691] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-01-08 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: XMLHttpRequest object not gcprotected when !USE_CONSERVATIVE_GC
​http://bugs.webkit.org/show_bug.cgi?id=12157

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
5:21 PM Applications using WebKit edited by markmalone@mac.com
Added Vienna (diff)
5:03 PM Changeset in webkit [18690] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for a bug that Adam, Hyatt, and I noticed when debugging
another problem.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::root): Added assertion. If we are casting to a root, we should make sure we are root.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): It is not enough to remove the child boxes for anonymous blocks. We need to be more thorough when cleaning these up. Adam's test case illustrates the problem well.
4:54 PM Changeset in webkit [18689] by hyatt
  • 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Land updated computed style results.

4:51 PM Changeset in webkit [18688] by hyatt
  • 2 edits in trunk/LayoutTests/fast/text

Land updated stroke results.

4:12 PM Changeset in webkit [18687] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderTreeAsText.cpp

Only dump stroke/fill if it's different from color

3:28 PM Changeset in webkit [18686] by ddkilzer
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix typo.

3:14 PM Changeset in webkit [18685] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Fixed text of previous comment.

3:11 PM Changeset in webkit [18684] by sullivan
  • 2 edits in trunk/WebCore

Tweak to previous checkin

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Adam suggested I should nil-check page->frame()
3:06 PM Changeset in webkit [22737] by lamadio
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-08 Lou Amadio <​lamadio@apple.com>

Reviewed by ggaren

  • DOMCoreClasses.cpp: (DOMNode::createInstance):

Build break

  • WebView.cpp: (WebView::handleMouseEvent):

passing incorrect flag

3:05 PM Changeset in webkit [18683] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady and Beth


  • fixed <rdar://problem/4912541> GMAIL: With selected text in a rich text message, choosing "Search in Google" displays search results in the message body field
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Visit google URL in main frame rather than in current frame
3:01 PM Changeset in webkit [18682] by hyatt
  • 2 edits in trunk/WebCore

Fix computed style errors for color properties that had invalid colors.
They should return the value of the 'color' property when their colors
are not valid.

Fixed the computed style value for border-top-color (a typo was causing it to
use border-left-color instead).

Implement outline-color computed style.

Reviewed by harrison

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::currentColorOrValidColor): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2:51 PM Changeset in webkit [18681] by weinig
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin and Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12150
Corrected results for W3C's pservers-grad-16-b.
Add a test for stop calues corner cases.

  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • svg/custom/gradient-stop-corner-cases-expected.checksum: Added.
  • svg/custom/gradient-stop-corner-cases-expected.png: Added.
  • svg/custom/gradient-stop-corner-cases-expected.txt: Added.
  • svg/custom/gradient-stop-corner-cases.svg: Added.

WebCore:

Reviewed by Darin and Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12150
Handle correctly cases where no stops are defined, cases where a
stop offset value is less than previous stops offset value, and cases
where a stop offset value is greater than 1.0.


  • platform/graphics/svg/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setGradientStops): Don't sort stops
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback): When there are no stops, use a transparent fill (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache): a stop offset must always be considered at greater or equal to all preceding stop offsets, but no more than 1.0
2:45 PM Changeset in webkit [22736] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.


Use a WebCore HistoryItem object to back WebHistoryItem.


  • WebHistoryItem.cpp: (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::hasURLString): (WebHistoryItem::visitCount): (WebHistoryItem::setVisitCount): (WebHistoryItem::mergeAutoCompleteHints): (WebHistoryItem::setLastVisitedTimeInterval): (WebHistoryItem::setTitle): (WebHistoryItem::RSSFeedReferrer): (WebHistoryItem::setRSSFeedReferrer): (WebHistoryItem::initWithURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval):
  • WebHistoryItem.h:
2:15 PM Changeset in webkit [18680] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4865325> please re-add auto font activation support in WebKit

  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
1:36 PM Changeset in webkit [18679] by darin
  • 5 edits in trunk/LayoutTests
  • turn off the Armenian part of this test for now, since it gives different results with different fonts
  • fast/lists/w3-list-styles-expected.checksum:
  • fast/lists/w3-list-styles-expected.png:
  • fast/lists/w3-list-styles-expected.txt:
  • fast/lists/w3-list-styles.html:
1:32 PM Changeset in webkit [18678] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12161 REGRESSION:
Crash when control-clicking on an image for contextual menu

  • WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): We need to nil-check coreMenu since it will be nil if the DOM popped up a menu instead. I cleaned up the function to make all the nil checks early returns instead of nesting all of the content. Also moved the autorelease to be with the creation of the menu instead of at the return.
12:55 PM Changeset in webkit [18677] by weinig
  • 28 edits in trunk/WebCore

Reviewed by Adam.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]): Removed useless implementation that would only work with NSView-based <select> elements, and added a FIXME about the fact that this function doesn't do anything any more. I think it's used by Safari forms auto-fill.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]): Removed code that depends on elementForView:, since that always returns nil now.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): Use a formDestroyed() function rather than clearing m_form directly so that this class doesn't have to be a friend of HTMLGenericFormElement.
  • html/HTMLGenericFormElement.h: Removed now-unneeded friend declaration for HTMLFormElement. Moved definition of supportsFocus into the .cpp file. Added a public formDestroyed function for use by HTMLFormElement.
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::attach): Removed widget-specific code. (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto. (WebCore::HTMLGenericFormElement::isMouseFocusable): Ditto. (WebCore::HTMLGenericFormElement::supportsFocus): Added this here; it was in the header file before, for no good reason.
  • page/EventHandler.h: Removed unused Mac-specific currentEventIsMouseDownInWidget.
  • page/mac/EventHandlerMac.mm: Ditto.
  • page/Frame.cpp: (WebCore::Frame::frameForWidget): Changed to use RenderWidget to find the frame rather than the WigetClient element() function.
  • page/mac/FrameMac.h: Removed unused bridgeForWidget.
  • page/mac/FrameMac.mm: Ditto.
  • page/mac/WebCoreFrameBridge.h: Removed elementForView.
  • page/mac/WebCoreFrameBridge.mm: Ditto. While the scroll bar still did implement WebCoreWidgetHolder, it does not correspond to a DOM element, so this method was always returning nil.
  • platform/Widget.h: Moved unused types and functions that are still in the platform-specific implementations into a "to be deleted" section: FocusPolicy, NoFocus, TabFocus, ClickFocus, StrongFocus, WheelFocus, lockDrawingFocus, font, focusPolicy, hasFocus, clearFocus, setFont, disableFlushDrawing, enableFlushDrawing, unlockDrawingFocus. Removed unused functions that are not in platform-specific implementations: sizeHint, baselinePosition, checksDescendantsForFocus.
  • platform/Widget.cpp: Removed functions.
  • platform/WidgetClient.h: Emptied out the class. Soon we can delete it.
  • platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar mouseDown:]): Got rid of unneeded includes, removed use of the WebCoreWidgetHolder protocol and the one method in it, and changed the calls to beforeMouseDown and afterMouseDown to pass the widget pointer in.
  • platform/mac/WebCoreWidgetHolder.h: Emptied out the file -- to be deleted later.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget): Removed code to manage deferredFirstResponder. (WebCore::Widget::hasFocus): Removed body of function and replaced with an assertion that it's never called. Later we'll remove it. (WebCore::Widget::setFocus): Tweaked a bit to work given changes to the FrameMac class. Also added a FIXME. Given how this works, it does not belong in the platform layer. (WebCore::Widget::clearFocus): Removed body of function and replaced with an assertion that it's never called. Later we'll remove it. (WebCore::Widget::focusPolicy): Ditto. (WebCore::Widget::font): Ditto. (WebCore::Widget::setFont): Ditto. (WebCore::Widget::lockDrawingFocus): Ditto. (WebCore::Widget::unlockDrawingFocus): Ditto. (WebCore::Widget::disableFlushDrawing): Ditto. (WebCore::Widget::enableFlushDrawing): Ditto. (WebCore::Widget::paint): Removed obsolete comment. (WebCore::Widget::sendConsumedMouseUp): Removed body of function and replaced with an assertion that it's never called. Later we'll remove it. (WebCore::Widget::setIsSelected): Tweaked a bit to work given changes to the FrameMac class. Also added a FIXME. Given how this works, it does not belong in the platform layer. (WebCore::Widget::beforeMouseDown): Changed to take an explicit Widget parameter. (WebCore::Widget::afterMouseDown): Ditto.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::intrinsicWidth): Changed to not call sizeHint() any more. I didn't change the values returned by the function, but they make no sense and this should probably be fixed later. (WebCore::RenderApplet::intrinsicHeight): Ditto.
  • rendering/RenderWidget.h: Removed unneeded WidgetClient.h include. Changed RenderWidget to no longer inherit from WidgetClient. Added a find function to find a RenderWidget given a Widget. Removed all the virtual functions that override WidgetClient hooks.
  • rendering/RenderWidget.cpp: Removed all the WidgetClient functions. (WebCore::widgetRendererMap): Added. Map that gives the RenderWidget for each Widget that is owned by a RenderWidget. (WebCore::RenderWidget::destroy): Removed the setClient call and added a call to remove the widget from the widgetRendererMap. (WebCore::RenderWidget::setWidget): Ditto. (WebCore::RenderWidget::setStyle): Removed the call to Widget::setFont. (WebCore::RenderWidget::find): Added. Returns the RenderWidget for a Widget, if any.
  • other changes
  • dom/Node.cpp: (WebCore::Node::dump): Removed unnecessary use of DeprecatedString. (WebCore::appendAttributeDesc): Ditto. (WebCore::Node::showNode): Ditto. (WebCore::Node::formatForDebugger): Ditto.
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Cleaned up conditional compilation so adding more MIME types here doesn't make the function more and more difficult to read.
  • page/Frame.h: Removed unneeded includes and declarations. Tweaked formatting.
  • page/Page.h: Removed unneeded declarations.
  • platform/ScrollView.h: Removed unneeded includes.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::renderName): Tweaked formatting.
11:55 AM Changeset in webkit [18676] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

No test possible (no change to functionality).

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom): Added. Removes the inheritable properties that CSSComputedStyleDeclaration knows how to compute from the given mutable declaration.
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp: Removed one copy of the inheritableProperties array.
  • css/CSSMutableStyleDeclaration.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Changed to call CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom.
11:48 AM Changeset in webkit [18675] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12099
XMLHttpRequest shouldn't honor a charset specified via setRequestHeader

Test: http/tests/xmlhttprequest/request-encoding.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Don't try to get the charset from Content-Type. Keep checking for unknown charsets, because that will be needed again when we start using document.xmlEncoding.
11:42 AM Changeset in webkit [18674] by ap
  • 10 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7640
Menu items are displayed as "undefined"

WebCore:

  • bindings/js/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • bindings/js/kjs_domnode.h: (KJS::DOMNode::): Removed Node::item. No idea why it was there in the first place.
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Added HTMLSelectElement::item. It is not in DOM2 IDL, but the spec seems to mentions it anyway: "The contained options can be directly accessed through the select element as a collection."
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): (WebCore::HTMLSelectElement::item):
  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.idl: Added this method to DOM and IDL, too. Made namedItem() non-virtual.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt: Updated the results.
  • fast/dom/node-item-expected.txt: Added.
  • fast/dom/node-item.html: Added. Check that there is no Node:item or HTMLElement:item.
11:31 AM Changeset in webkit [18673] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4912254> REGRESSION: After copying text to
the clipboard, the paste contextual remains dimmed when it should
be active

No layout test for context menu problems.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Remove check to see if the content is richly editable; it only has to be regular editable and the call to canPaste() takes care of that.
11:17 AM Changeset in webkit [18672] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Attempt to fix build for buildbots.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::columnGap): (WebCore::RenderBlock::calcColumnWidth):
11:15 AM Changeset in webkit [18671] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

  • added a W3C list style test that was cited in a bug
  • fast/lists/w3-list-styles-expected.checksum: Added.
  • fast/lists/w3-list-styles-expected.png: Added.
  • fast/lists/w3-list-styles-expected.txt: Added.
  • fast/lists/w3-list-styles.html: Added.

WebCore:

Reviewed by Maciej.

Test case showed problems in cjk-ideographic and hebrew
Test: fast/lists/w3-list-styles.html

  • rendering/RenderListMarker.cpp: (WebCore::toCJKIdeographic): Fix the algorithm so it doesn't include leading zeroes. I had misread the part that says you start with the decimal form of the number. Fix an assertion that was too stringent. Fix the code to collapse consecutive zeroes so that it doesn't get confused by intervening "noChar" characters. (WebCore::RenderListMarker::paint): Reverse the text before painting if the first character's direction is right to left.
11:10 AM Changeset in webkit [22735] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
10:59 AM Changeset in webkit [18670] by darin
  • 138 edits in trunk

LayoutTests:

Reviewed by Beth.

  • css1/basic/class_as_selector-expected.txt:
  • css1/basic/containment-expected.txt:
  • css1/basic/contextual_selectors-expected.txt:
  • css1/basic/id_as_selector-expected.txt:
  • css1/box_properties/border_bottom-expected.txt:
  • css1/box_properties/border_left-expected.txt:
  • css1/box_properties/border_right_inline-expected.txt:
  • css1/box_properties/border_top-expected.txt:
  • css1/box_properties/clear_float-expected.txt:
  • css1/box_properties/margin-expected.txt:
  • css1/box_properties/margin_bottom-expected.txt:
  • css1/box_properties/margin_left-expected.txt:
  • css1/box_properties/margin_right-expected.txt:
  • css1/box_properties/margin_top-expected.txt:
  • css1/box_properties/padding_left-expected.txt:
  • css1/box_properties/padding_right-expected.txt:
  • css1/cascade/cascade_order-expected.txt:
  • css1/classification/display-expected.txt:
  • css1/classification/list_style-expected.txt:
  • css1/classification/list_style_image-expected.txt:
  • css1/classification/list_style_position-expected.txt:
  • css1/classification/list_style_type-expected.txt:
  • css1/conformance/forward_compatible_parsing-expected.txt:
  • css1/pseudo/anchor-expected.txt:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • css2.1/t0505-c16-descendant-01-e-expected.txt:
  • css2.1/t050803-c14-classes-00-e-expected.txt:
  • css2.1/t0509-c15-ids-01-e-expected.txt:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-01-b-expected.txt:
  • css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • editing/deleting/4866671-expected.txt:
  • editing/deleting/delete-first-list-item-expected.txt:
  • editing/deleting/delete-link-1-expected.txt:
  • editing/deleting/delete-listitem-002-expected.txt:
  • editing/deleting/list-item-1-expected.txt:
  • editing/deleting/merge-into-empty-block-2-expected.txt:
  • editing/execCommand/4641880-1-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-div-022-expected.txt:
  • editing/inserting/insert-div-023-expected.txt:
  • editing/inserting/insert-div-024-expected.txt:
  • editing/pasteboard/4861080-expected.txt:
  • editing/pasteboard/drop-link-expected.txt:
  • editing/pasteboard/innerText-inline-table-expected.txt:
  • editing/pasteboard/input-field-1-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-start-list-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-line-002-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • editing/selection/selectNode-expected.txt:
  • editing/selection/selectNodeContents-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-before-expected.txt:
  • fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
  • fast/block/float/014-expected.txt:
  • fast/css-generated-content/009-expected.txt:
  • fast/css/001-expected.txt:
  • fast/css/continuationCrash-expected.txt:
  • fast/css/css2-system-fonts-expected.txt:
  • fast/css/css3-modsel-22-expected.txt:
  • fast/css/list-outline-expected.txt:
  • fast/doctypes/001-expected.txt:
  • fast/doctypes/002-expected.txt:
  • fast/doctypes/003-expected.txt:
  • fast/doctypes/004-expected.txt:
  • fast/dom/Window/window-onFocus-expected.txt:
  • fast/forms/form-hides-table-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
  • fast/lists/001-expected.txt:
  • fast/lists/002-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/lists/004-expected.txt:
  • fast/lists/005-expected.txt:
  • fast/lists/006-expected.txt:
  • fast/lists/007-expected.txt:
  • fast/lists/008-expected.txt:
  • fast/lists/alpha-list-wrap-expected.txt:
  • fast/lists/decimal-leading-zero-expected.txt:
  • fast/lists/drag-into-marker-expected.txt:
  • fast/lists/dynamic-marker-crash-expected.txt:
  • fast/lists/inlineBoxWrapperNullCheck-expected.txt:
  • fast/lists/li-br-expected.txt:
  • fast/lists/li-style-alpha-huge-value-crash-expected.txt:
  • fast/lists/li-values-expected.txt:
  • fast/lists/markers-in-selection-expected.txt:
  • fast/lists/numeric-markers-outside-list-expected.txt:
  • fast/lists/ol-display-types-expected.txt:
  • fast/lists/olstart-expected.txt:
  • fast/lists/ordered-list-with-no-ol-tag-expected.txt:
  • fast/lists/scrolled-marker-paint-expected.txt:
  • fast/overflow/overflow-rtl-expected.txt:
  • fast/selectors/001-expected.txt:
  • fast/selectors/013-expected.txt:
  • fast/selectors/015-expected.txt:
  • fast/selectors/166-expected.txt:
  • fast/table/018-expected.txt:
  • fast/table/form-with-table-style-expected.txt:
  • fast/text/whitespace/tab-character-basics-expected.txt:
  • fast/tokenizer/004-expected.txt:
  • tables/mozilla/bugs/bug23235-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.txt:
  • tables/mozilla/bugs/bug3191-expected.txt:
  • tables/mozilla/bugs/bug32205-2-expected.txt:
  • tables/mozilla/marvin/backgr_index-expected.txt:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/x_table-expected.txt:
  • tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • traversal/stay-within-root-expected.txt:

WebCore:

Reviewed by Beth.

  • rendering/RenderTreeAsText.cpp: (WebCore::getTagName): Changed to use String instead of DeprecatedString. (WebCore::quoteAndEscapeNonPrintables): Ditto. Also moved up so it can be used in the operator below. (WebCore::operator<<): Added clause for RenderListMarker that dumps the value of the list marker's text. (WebCore::nodePosition): Changed to use String instead of DeprecatedString.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::TextStreamSeparator::TextStreamSeparator): Changed to use String instead of DeprecatedString. (WebCore::getTagName): Ditto. (WebCore::write): Ditto.
9:50 AM Changeset in webkit [18669] by weinig
  • 8 edits
    1 copy in trunk/WebCore

Reviewed by ap and the rubber stamp of Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12164
Cleanup Tokenizers

  • Moves Tokenizer class into its own file.
  • Move XMLTokenizer declaration from XMLTokenizer.cpp to XMLTokenizer.h
  • Fixup #includes.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::createTokenizer):
  • dom/Tokenizer.h: Added. (WebCore::Tokenizer::Tokenizer): (WebCore::Tokenizer::~Tokenizer): (WebCore::Tokenizer::stopParsing): (WebCore::Tokenizer::processingData): (WebCore::Tokenizer::executingScript): (WebCore::Tokenizer::wantsRawData): (WebCore::Tokenizer::writeRawData): (WebCore::Tokenizer::inViewSourceMode): (WebCore::Tokenizer::setInViewSourceMode): (WebCore::Tokenizer::wellFormed): (WebCore::Tokenizer::lineNumber): (WebCore::Tokenizer::columnNumber):
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizer.h: (WebCore::XMLTokenizer::): (WebCore::XMLTokenizer::setIsXHTMLDocument): (WebCore::XMLTokenizer::isXHTMLDocument): (WebCore::XMLTokenizer::wellFormed):
  • html/HTMLElement.cpp:
  • html/HTMLTokenizer.h: (WebCore::Token::reset): (WebCore::HTMLTokenizer::checkBuffer): (WebCore::HTMLTokenizer::checkScriptBuffer): (WebCore::HTMLTokenizer::State::State): (WebCore::HTMLTokenizer::State::setBit):
  • xml/XSLTProcessor.cpp:
9:49 AM S60Reindeer edited by mboudreau@ftrd.us
fixed grammatical typo (diff)
9:31 AM Changeset in webkit [18668] by spadma
  • 9 edits in S60/branches/3.1m

2007-01-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OOM notification when browser running out of memory.
TSW Id : AHUN-6X6PW3
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitOOMNotifier::NewL): (CWebKitOOMNotifier::~CWebKitOOMNotifier): (CWebKitOOMNotifier::Notify): (CStaticObjectContainer::Instance): (CStaticObjectContainer::CStaticObjectContainer): (CStaticObjectContainer::~CStaticObjectContainer):
  • data/Webkit.rss:
  • data/Webkit_sdk.loc:
  • data/Webkit_sdk.rss:
8:45 AM Changeset in webkit [18667] by spadma
  • 9 edits in S60/trunk

2007-01-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OOM notification when browser running out of memory.
TSW Id : AHUN-6X6PW3
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitOOMNotifier::NewL): (CWebKitOOMNotifier::~CWebKitOOMNotifier): (CWebKitOOMNotifier::Notify): (CStaticObjectContainer::Instance): (CStaticObjectContainer::CStaticObjectContainer): (CStaticObjectContainer::~CStaticObjectContainer):
  • data/Webkit.rss:
  • data/Webkit_sdk.loc:
  • data/Webkit_sdk.rss:
7:42 AM Changeset in webkit [18666] by weinig
  • 6 edits in trunk

LayoutTests:

Reviewed by Tim H.

Update results to include -webkit-box-shadow.

  • fast/css/computed-style-expected.txt:

WebCore:

Reviewed by Tim H.

Adds -webkit-box-shadow to list of computable styles.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::):

WebKit:

Reviewed by Tim H.

Adds default value for -webkit-box-shadow and fixes default
value of -webkit-column-count to be "auto". Also sorts the
list of defaults.

5:43 AM Changeset in webkit [18665] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by bdash.

Initialize the member vars, fixes testcases
pointer-events-path.svg and pointer-events-text.svg
on the PPC build.

4:36 AM Changeset in webkit [18664] by bdash
  • 4 edits in trunk

2007-01-08 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Mark.

2007-01-08 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Mark.

  • fast/css/computed-style-expected.txt: Update results to include -webkit-column styles.
3:57 AM Changeset in webkit [18663] by hyatt
  • 4 edits in trunk/WebCore

This patch computes the correct column width and column count. It ensures that content lays out constrained
to the column width in one long strip. It does not yet balance the long strip into multiple columns.

Reviewed by Mark

  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::columnGap): (WebCore::RenderBlock::calcColumnWidth):
  • rendering/RenderBlock.h:
  • rendering/RenderStyle.h: (WebCore::RenderStyle::setColumnWidth):
2:30 AM Changeset in webkit [18662] by hyatt
  • 11 edits in trunk/WebCore

Fix column-count so that it supports auto just like column-width does.

Add a new function, availableWidth(), that will be used to return the width available to content placed inside
a block. For now it still returns contentWidth(), so no behavioral change has occurred yet.

Subclass calcWidth() in RenderBlock, but don't change anything yet. This is where RenderBlock will calc the
correct column width.

Reviewed by mark

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcWidth):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidth):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlockWidth): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight):
  • rendering/RenderObject.h: (WebCore::RenderObject::availableWidth):
  • rendering/RenderStyle.cpp: (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleMultiColData::operator==):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasAutoColumnCount): (WebCore::RenderStyle::setColumnCount): (WebCore::RenderStyle::setHasAutoColumnCount):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
12:45 AM Changeset in webkit [18661] by hyatt
  • 3 edits
    4 adds in trunk

LayoutTests:

Add layout test for inheritance of auto z-index.

Reviewed by eric

  • fast/layers/zindex-inherit-expected.checksum: Added.
  • fast/layers/zindex-inherit-expected.png: Added.
  • fast/layers/zindex-inherit-expected.txt: Added.
  • fast/layers/zindex-inherit.html: Added.

WebCore:

Fix z-index:inherit so that it works properly when inheriting from z-index:auto.

Reviewed by eric

fast/layers/zindex-inherit.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:41 AM Changeset in webkit [18660] by hyatt
  • 8 edits in trunk/WebCore

Add support for all of the CSS3 multi-column properties in preparation for implementing the
feature.

Reviewed by eric

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderStyle.cpp: (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleMultiColData::operator==): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::StyleMultiColData::operator!=): (WebCore::StyleMultiColData::ruleWidth): (WebCore::RenderStyle::columnWidth): (WebCore::RenderStyle::hasAutoColumnWidth): (WebCore::RenderStyle::columnCount): (WebCore::RenderStyle::columnGap): (WebCore::RenderStyle::hasAutoColumnGap): (WebCore::RenderStyle::columnRuleColor): (WebCore::RenderStyle::columnRuleStyle): (WebCore::RenderStyle::columnRuleWidth): (WebCore::RenderStyle::columnBreakBefore): (WebCore::RenderStyle::columnBreakInside): (WebCore::RenderStyle::columnBreakAfter): (WebCore::RenderStyle::setColumnWidth): (WebCore::RenderStyle::setHasAutoColumnWidth): (WebCore::RenderStyle::setColumnCount): (WebCore::RenderStyle::setColumnGap): (WebCore::RenderStyle::setHasAutoColumnGap): (WebCore::RenderStyle::setColumnRuleColor): (WebCore::RenderStyle::setColumnRuleStyle): (WebCore::RenderStyle::setColumnRuleWidth): (WebCore::RenderStyle::resetColumnRule): (WebCore::RenderStyle::setColumnBreakBefore): (WebCore::RenderStyle::setColumnBreakInside): (WebCore::RenderStyle::setColumnBreakAfter): (WebCore::RenderStyle::initialColumnCount): (WebCore::RenderStyle::initialColumnWidth):

Jan 7, 2007:

10:45 PM Changeset in webkit [18659] by rwlbuis
  • 10 edits
    10 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10587
pointer-events is not implemented for RenderSVGImage or RenderSVGText
Implement pointer-events for raster images and svg text.

9:17 PM Changeset in webkit [18658] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Removed dead code.
9:11 PM Changeset in webkit [18657] by ddkilzer
  • 6 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

Change JNI so that it is not wrapped in the PLATFORM(MAC) ifdef, enabling
other platforms who have JNI to use it.

  • bindings/jni/jni_instance.h: Removed unnecessary include of <CoreFoundation/CoreFoundation.h>
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::setJavaVM):
  • bindings/jni/jni_utility.h: Added new method for clients to set the JavaVM
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): Changed code to utilize new #if HAVE(JNI)
  • kjs/config.h: Added new #define for JNI, ie HAVE_JNI
9:08 PM Changeset in webkit [18656] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=11431
ARM platform has some byte alignment issues

Fix for NaN being 4 bytes and it must start on a byte boundary
for ARM architectures.

  • kjs/fpconst.cpp: (KJS::):
5:16 PM Changeset in webkit [18655] by hyatt
  • 5 edits in trunk/WebCore

Fix a regression where border-radius was not clipping the background when border was set to none.
Fix multi-line inline flow painting to properly apply border-radius to the background only at the
beginning of the first line and end of the last line.

Reviewed by eric

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackground):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderBox.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::paintBackgroundExtended):
3:31 PM Changeset in webkit [18654] by hyatt
  • 22 edits
    5 adds in trunk

LayoutTests:

Add support for the CSS3 box-shadow property.

Reviewed by olliej

  • fast/box-shadow/basic-shadows-expected.checksum: Added.
  • fast/box-shadow/basic-shadows-expected.png: Added.
  • fast/box-shadow/basic-shadows-expected.txt: Added.
  • fast/box-shadow/basic-shadows.html: Added.

WebCore:

Add support for the CSS3 box-shadow property.

Reviewed by olliej

fast/box-shadow/ contains the tests for this feature.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::shouldDrawTextDecoration): (WebCore::InlineFlowBox::paintTextDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBoxDecorations): (WebCore::InlineRunBox::paintTextDecorations):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderImage.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBoxShadow): (WebCore::RenderObject::dump): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasBoxDecorations): (WebCore::RenderObject::setHasBoxDecorations):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::setStyle): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
2:37 PM New features in WebKit since Safari 2.0 edited by eric@webkit.org
(diff)
2:36 PM New features in WebKit since Safari 2.0 edited by eric@webkit.org
(diff)
2:35 PM New features in WebKit since Safari 2.0 created by eric@webkit.org
2:29 PM WikiStart edited by eric@webkit.org
(diff)
10:15 AM Changeset in webkit [18653] by rwlbuis
  • 2 edits in trunk/LayoutTests

Reviewed by weinig.

Correct results from previous patch.

8:47 AM Changeset in webkit [18652] by rwlbuis
  • 22 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=10362
SVG needs to support SVGError events and some form of "error state"
Report SVG warnings and errors on (JS) console.
Expose line and column number getters in Tokenizer in
order to display them with the error message.

6:00 AM Changeset in webkit [18651] by zimmermann
  • 58 edits in trunk

Reviewed by Sam.
Cleanup code & fix InlineBox positioning when text-anchor is used.

4:47 AM Changeset in webkit [18650] by staikos
  • 12 edits
    1 add in trunk

Make it compile and link again. (Qt) Includes implementation of a few stubs
which should be moved to other locations, as well as a non-Qt-specific change
to make it compile (nil->ResourceResponse()). Qt port continues to function as
well as before.

4:01 AM Changeset in webkit [18649] by ap
  • 3 edits in trunk/LayoutTests

Updated pixel results that weren't landed with r17141.

  • http/tests/incremental/slow-utf8-css-expected.checksum:
  • http/tests/incremental/slow-utf8-css-expected.png:
3:47 AM Changeset in webkit [18648] by ap
  • 4 edits
    4 adds in trunk

2007-01-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

Test: fast/forms/listbox-clip.html

  • platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar initWithPlatformScrollbar:]): Get the correct scrollbar width/height based on control size.
  • rendering/RenderListBox.cpp: Renamed optionsSpacingLeft to optionsSpacingHorizontal since it is applied on both sides. (WebCore::RenderListBox::calcMinMaxWidth): Account for optionsSpacingHorizontal. Not including the spacing before went unnoticed since the scrollbar was lying about its width by exactly the same amount. (WebCore::RenderListBox::paintObject): Clip out the scrollbar. (WebCore::RenderListBox::paintItemForeground): Changed for the rename.
3:35 AM Changeset in webkit [18647] by ap
  • 3 edits
    4 adds in trunk

2007-01-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/repaint/erase-overflow.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Added a repaint before changing hasOverflowClip to true, to ensure that the current overflow is erased.
3:26 AM Changeset in webkit [18646] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12106
Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored

3:26 AM Changeset in webkit [18645] by ap
  • 5 edits in trunk/LayoutTests

Re-apply r17618, which got reverted with CSS suite update.

Reviewed by Sam Weinig.

Fix a layout test failure that happened with additional fonts installed - replace a fancy
Unicode character with a plain asterisk.

  • css2.1/t0905-c414-flt-00-d-expected.checksum:
  • css2.1/t0905-c414-flt-00-d-expected.png:
  • css2.1/t0905-c414-flt-00-d-expected.txt:
  • css2.1/t0905-c414-flt-00-d.html:
3:14 AM Changeset in webkit [18644] by ap
  • 3 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10313
xsl:import doesn't work in stylesheets loaded via XMLHttpRequest

This is a partial fix that makes a couple more steps towards fixing the problem.

Test: fast/xsl/transform-xhr-doc.xhtml

  • xml/XSLTProcessor.cpp: (WebCore::xsltStylesheetPointer): Pass an URL for the stylesheet. I'm not sure why this constructor even needs it, given that it has a Node, but this is a small modifications that makes XSLImportRule try to load from a correct URL. (WebCore::XSLTProcessor::transformToString): Fix the crash for real this time.
12:37 AM Changeset in webkit [18643] by rwlbuis
  • 8 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12125
overflow attribute of the symbol element not respected

Copy the attribute map to the cloned node so the overflow on
the symbol is respected.

Note: See TracTimeline for information about the timeline view.