Context Navigation

← Previous Period
Next Period →

Timeline

Jan 10, 2007:

11:48 PM Changeset in webkit [18759] by hyatt

1 edit in trunk/WebCore/rendering/RenderBlock.cpp

Remove unused variable.

11:26 PM Changeset in webkit [18758] by hyatt

30 edits in trunk/WebCore

Rework positionForCoordinates to be more efficient and to handle multi-column content. This entailed
adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
space of the renderer.

positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
absolute positions over and over again.

Reviewed by darin

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXTextMarkerRangeForLine:]): (-[WebCoreAXObject doAXTextMarkerForPosition:]):
dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
editing/SelectionController.cpp: (WebCore::SelectionController::contains):
editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::sendContextMenuEvent):
page/EventHandler.h:
page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::localPoint):
page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]):
rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
rendering/HitTestResult.h: (WebCore::HitTestResult::localPoint): (WebCore::HitTestResult::setLocalPoint):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::positionForCoordinates):
rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines):
rendering/RenderInline.cpp: (WebCore::RenderInline::positionForCoordinates):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::hitTestLayer):
rendering/RenderObject.cpp: (WebCore::RenderObject::updateHitTestResult):
rendering/RenderObject.h:
rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForCoordinates):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates):
rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): (WebCore::RootInlineBox::closestLeafChildForXPos):
rendering/RootInlineBox.h:

11:12 PM Changeset in webkit [18757] by staikos

9 edits in trunk

Fix Qt build again

8:44 PM Changeset in webkit [18756] by bdash

2 edits in trunk/WebKit

2007-01-10 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=11775 'Show URLs in Tool Tips' preference is ignored

WebView/WebHTMLView.mm: (-[WebHTMLView _resetCachedWebPreferences:]): (-[WebHTMLView setDataSource:]): Added a call to _resetCachedWebPreferences:. Added an assertion that the view is not closed, instead of reopening it. Reopening should not occur, now that <http://bugs.webkit.org/show_bug.cgi?id=12087> is fixed.

6:24 PM Changeset in webkit [18755] by bdash

11 edits
12 adds in trunk

2007-01-10 Kirby White <KWhiteRight@gmail.com>

Reviewed by Darin.

Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841

Set image size to fit alt text when image or input-image element
has no src attribute, so that those images show their alt text instead
of showing nothing at all.

html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::attach):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach):
rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::imageChanged):
rendering/RenderImage.h:

2007-01-10 Kirby White <KWhiteRight@gmail.com>

Reviewed by Darin.

New and adjusted test cases for
http://bugs.webkit.org/show_bug.cgi?id=11841

fast/dom/HTMLImageElement/image-alt-text-expected.checksum: Added.
fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
fast/dom/HTMLImageElement/image-alt-text-expected.txt: Added.
fast/dom/HTMLImageElement/image-alt-text.html: Added.
fast/dom/HTMLImageElement/resources/blue_rect.jpg: Added.
fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
fast/dom/HTMLInputElement/input-image-alt-text.html: Added.
fast/dom/HTMLInputElement/resources/blue_rect.jpg: Added.
fast/forms/focus2-expected.txt:
fast/forms/focus2.html:
fast/forms/input-value-expected.checksum:
fast/forms/input-value-expected.png:
fast/forms/input-value-expected.txt:

6:18 PM Changeset in webkit [18754] by bdash

2 edits in trunk/WebCore

2007-01-11 Mark Rowe <mrowe@apple.com>

Build fix.

rendering/RenderView.cpp: (WebCore::RenderView::printing):

5:47 PM Changeset in webkit [22753] by sfalken

3 edits in branches/WindowsMerge/WebCore

2007-01-10 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.

<rdar://problem/4818840> Crash occurs after selecting Print Preview from under the File menu if no printer is selected

bridge/win/FrameWin.cpp: (WebCore::FrameWin::computePageRects): removed calls to setupRootForPrinting
bridge/win/FrameWin.h: removed setupRootForPrinting

5:46 PM Changeset in webkit [18753] by bdash

4 edits
2 adds in trunk

2007-01-10 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=9284 Quirksmode (CSS1): Removing inline border styles is impossible

Test: fast/css/remove-shorthand.html

css/CSSMutableStyleDeclaration.cpp: (WebCore::PropertyLonghand::PropertyLonghand): Added this structure containing a pointer to an array if properties and the array's length. (WebCore::PropertyLonghand::properties): (WebCore::PropertyLonghand::length): (WebCore::initShorthandMap): Initialize the mapping from shorthand properties to their dependent properties. (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check if the property being removed is a shorthand, and if so, to remove all of its dependent properties. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a 'notifyChanged' boolean parameter which controls whether this method calls setChanged() if it actually removes any property.
css/CSSMutableStyleDeclaration.h:

2007-01-10 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=9284 Quirksmode (CSS1): Removing inline border styles is impossible

fast/css/remove-shorthand-expected.txt: Added.
fast/css/remove-shorthand.html: Added.

5:39 PM Changeset in webkit [18752] by sfalken

9 edits in trunk/WebCore

2007-01-10 Steve Falkenburg <sfalken@apple.com>

Reviewed by Kevin.

Removed unnecessary printing state

5:23 PM Changeset in webkit [22752] by andersca

3 edits in branches/WindowsMerge/WebKitWin

Another build fix.

WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):
WebContextMenuClient.h:

5:20 PM Changeset in webkit [22751] by andersca

2 edits in branches/WindowsMerge/WebKitWin

Another build fix.

WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):

5:11 PM Changeset in webkit [22750] by andersca

2 edits in branches/WindowsMerge/WebCore

Yet another build fix.

platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::getResponseModifiedHeader):

4:56 PM Changeset in webkit [18751] by andersca

4 edits in trunk/WebCore

Reviewed by Maciej.

Get the Refresh header directly from the ResourceResponse.

loader/DocumentLoader.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad):
loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::getResponseModifiedHeader):

4:17 PM Applications using WebKit edited by markmalone@mac.com

(diff)

4:16 PM Changeset in webkit [18750] by ggaren

2 edits in trunk/WebKitSite

coding/coding-style.html: Fixed minor validation error.

4:10 PM Changeset in webkit [18749] by ggaren

2 edits in trunk/WebKitSite

Reviewed by Beth Dakin.

Updated coding style guidelines to cover a lot of stuff previously absent.

coding/coding-style.html:

3:42 PM Changeset in webkit [22749] by bdakin

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Do all of the work we used to do in WebCore over here in WebKit.
WebContextMenuClient.h:

3:32 PM Changeset in webkit [18748] by bdakin

8 edits in trunk

WebCore:

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

page/ContextMenuClient.h: New call to the client to search in google.
page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the client instead of forming a new url string and loading it.
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.

WebKit:

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

WebCoreSupport/WebContextMenuClient.h:
WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::searchWithGoogle): Call into WebView to search in Google.
WebView/WebViewInternal.h: Make _searchWithGoogleFromMenu available.

1:38 PM Changeset in webkit [18747] by aroben

2 edits in trunk/WebCore

Rubberstamped by Darin.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0 instead of an empty Event to FrameLoader::load and FrameLoader::urlSelected.

12:58 PM Changeset in webkit [22748] by andersca

6 edits in branches/WindowsMerge

WebCoreWin:

Another build fix.

bridge/win/FrameWin.h:
loader/win/FrameLoaderWin.cpp:

WebKitWin:

Build fix.

WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
WebFrame.h:

12:57 PM Changeset in webkit [18746] by andersca

2 edits in trunk/WebCore

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): Disable assertion (I forgot to do this even though I added the comment!)

12:53 PM Changeset in webkit [18745] by andersca

2 edits in trunk/WebCore

Reviewed and landed by Anders.

Fix case in vcproj file (the GTK+ port uses the vcproj file).

WebCore.vcproj/WebCore/WebCore.vcproj:

12:12 PM Changeset in webkit [18744] by lars

6 edits
2 deletes in trunk/WebCore

Make the Qt build compile again after
the ResourceLoader was made platform
independent.

12:01 PM Changeset in webkit [22747] by andersca

5 edits
2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Add WebDocumentLoader. Implement some of the FrameLoaderClient methods.
Add a resourceRequest() getter to WebMutableURLRequest.

WebDocumentLoader.cpp: Added. (WebDocumentLoader::WebDocumentLoader): (WebDocumentLoader::setDataSource): (WebDocumentLoader::dataSource): (WebDocumentLoader::attachToFrame): (WebDocumentLoader::detachFromFrame):
WebDocumentLoader.h: Added.
WebFrame.cpp: (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::updateGlobalHistoryForReload): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad):
WebKit.vcproj/WebKit.vcproj:
WebMutableURLRequest.cpp: (WebMutableURLRequest::resourceRequest):
WebMutableURLRequest.h:

11:59 AM Changeset in webkit [22746] by andersca

2 edits in branches/WindowsMerge/WebCore

Build fix.

platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::setDefersLoading):

11:39 AM Changeset in webkit [18743] by andersca

9 edits
1 delete in trunk/WebCore

Rubber-stamped by Maciej.

Move most of ResourceLoader and MainResourceLoader into the platform-independent files.

WebCore.xcodeproj/project.pbxproj:
loader/FrameLoader.cpp: (WebCore::FrameLoader::didFinishLoad):
loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::~MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
loader/MainResourceLoader.h:
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::frameLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::clearResourceData): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::response): (WebCore::ResourceLoader::cancelledError):
loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::setRequest):
loader/mac/FrameLoaderMac.mm:
loader/mac/MainResourceLoaderMac.mm: Removed.
loader/mac/ResourceLoaderMac.mm:

10:46 AM Changeset in webkit [18742] by lars

2 edits
5 adds
5 deletes in trunk/WebCore

Move files to the correct location, and remove a few
unused methods from LoaderFunctionsQt.cpp

10:45 AM Changeset in webkit [22745] by andersca

5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Make WebBackForwardList wrap a WebCore::BackForwardList. Add wrapper map to WebHistoryItem.

WebBackForwardList.cpp: (backForwardListWrappers): (WebBackForwardList::WebBackForwardList): (WebBackForwardList::~WebBackForwardList): (WebBackForwardList::createInstance): (WebBackForwardList::addItem): (WebBackForwardList::goBack): (WebBackForwardList::goForward): (WebBackForwardList::goToItem): (WebBackForwardList::backItem): (WebBackForwardList::currentItem): (WebBackForwardList::forwardItem): (WebBackForwardList::backListWithLimit): (WebBackForwardList::forwardListWithLimit): (WebBackForwardList::capacity): (WebBackForwardList::setCapacity): (WebBackForwardList::backListCount): (WebBackForwardList::forwardListCount): (WebBackForwardList::containsItem): (WebBackForwardList::itemAtIndex): (WebBackForwardList::setPageCacheSize): (WebBackForwardList::pageCacheSize): (WebBackForwardList::setDefaultPageCacheSizeIfNecessary):
WebBackForwardList.h:
WebHistoryItem.cpp: (historyItemWrappers): (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::QueryInterface): (WebHistoryItem::initWithURLString): (WebHistoryItem::historyItem):
WebHistoryItem.h:

9:20 AM Changeset in webkit [18741] by aroben

1 edit in trunk/WebCore/ChangeLog

Corrected Radar reference.

9:15 AM Changeset in webkit [18740] by aroben

2 edits in trunk/WebCore

Reviewed by Geoff.

Fix: <rdar://problem/4903003> ContextMenuController leaks Events

No layout tests possible.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr to manage the lifetime of Shared objects.

6:11 AM Changeset in webkit [18739] by rwlbuis

3 edits in trunk/WebCore

Reviewed by Sam.

http://bugs.webkit.org/show_bug.cgi?id=12196
SVGPatternElement should not be locatable

Replace SVGStyledLocatableElement derivation with
SVGStyledElement.

4:14 AM Changeset in webkit [18738] by zimmermann

2 edits in trunk/WebCore

Build fix, not reviewed.
Use correct method name in the ASSERT in RenderSVGText.

3:40 AM Changeset in webkit [18737] by zimmermann

102 edits in trunk

Reviewed by Eric.
Large SVG dynamic update rework/optimization.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)

Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)

1:57 AM Changeset in webkit [18736] by lars

2 edits in trunk/JavaScriptCore

Use the new functionality in Qt 4.3, to make
the methods closer compliant with the Unicode
spec.

Keep the old code so that it still compiles against
Qt 4.2.

12:59 AM Changeset in webkit [18735] by hyatt

2 edits in trunk/WebCore

Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect. This enables
the method to be multi-column aware and also to understand when the selection is clipped out by overflow.

Reviewed by bdash

rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):

12:09 AM Changeset in webkit [18734] by hyatt

5 edits in trunk/WebCore

Make the absolutePosition method multi-column aware. Note that there is now a real problem with the
absoluteRects method, since an object can split across multiple columns and break into multiple rects.
absolutePosition just returns the top-left corner of the element's box in the first column in which it
appears.

Reviewed by bdash

rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustRectForColumns):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::computeAbsoluteRepaintRect):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):

Jan 9, 2007:

11:47 PM Changeset in webkit [22744] by adachan

8 edits
1 add in branches/WindowsMerge/WebKitWin

2007-01-09 Ada Chan <adachan@apple.com>

Reviewed by Steve.

<rdar://4602355> Undo/Redo

WebKitWin changes:

Added new undo methods in the IWebUIDelegate.
Removed the internal WebUndoManager in WebEditorClient. Instead, we'll call methods on the ui delegate to register undo operations, execute undo/redo, etc.

11:39 PM Changeset in webkit [18733] by hyatt

2 edits in trunk/WebCore

Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
not the newly-computed column count.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustRepaintRectForColumns):

11:24 PM Changeset in webkit [18732] by hyatt

5 edits in trunk/WebCore

Break up painting and hit testing of children into helper methods and add multi-column versions for both.

Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
hover works.

Turn off selection gap filling in columns for now until it can be made to work correctly.

Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
account for column break adjustments that shrink the columns slightly. Avoid clipping of the last column's
contents by ensuring it gets all the remaining available height.

Reviewed by mitz

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustRepaintRectForColumns):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):

8:42 PM Changeset in webkit [18731] by ddkilzer

2 edits in trunk/WebCore

WebCore:

Reviewed by Darin and Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150

Don't use memset to set float to 0

platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback):

7:45 PM Changeset in webkit [22743] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:36 PM Changeset in webkit [18730] by sfalken

1 copy in tags/Safari-521.32.10b

New tag.

5:21 PM Changeset in webkit [22742] by andersca

6 edits
1 add in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Add COMPtr. Make MemoryStream backed by a SharedBuffer. Use SharedBuffer in
WebFrame.

COMPtr.h: Added. (COMPtr::COMPtr): (COMPtr::~COMPtr): (COMPtr::get): (COMPtr::operator*): (COMPtr::operator->): (COMPtr::operator&): (COMPtr::operator!): (COMPtr::operator UnspecifiedBoolType): (::copyTo): (::adopt): (::operator):
MemoryStream.cpp: (MemoryStream::MemoryStream): (MemoryStream::~MemoryStream): (MemoryStream::createInstance): (MemoryStream::Clone):
MemoryStream.h:
WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::didReceiveResponse): (WebFrame::didReceiveData):
WebFrame.h: (WebFrame::data):
WebKit.vcproj/WebKit.vcproj:

5:19 PM Changeset in webkit [22741] by sfalken

2 edits in branches/WindowsMerge/WebCore

2007-01-09 Steve Falkenburg <sfalken@apple.com>

B&I build fix

WebCore.vcproj/WebCore.vcproj:

5:09 PM Changeset in webkit [18729] by hyatt

30 edits
4 adds in trunk/LayoutTests/fast/overflow

Update overflow tests. Add new overflow test.

4:54 PM Changeset in webkit [18728] by andersca

3 edits in trunk/WebCore

Reviewed by Brady.

Add default constructor to SharedBuffer.

platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer):
platform/SharedBuffer.h:

4:52 PM Changeset in webkit [18727] by hyatt

11 edits in trunk/WebCore

This patch gets rudimentary column layout working. Normal flow content only gets laid out into
columns properly and painted correctly initially. What doesn't work: hit testing, incremental repainting,
column rule painting, child layers.

Some work needs to be done on the render tree dumper before column tests will be
meaningful.

Also reworked overflow and fixed a bunch of bugs with the computation of overflow. These include an error
in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
by not checking overflow in lowest/rightmostPosition. Existing tests improve their rendering to match
Firefox with this change.

Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
This should not have happened. Covered by new test fast/overflow/table-overflow-float.html.

Reviewed by mitz

page/Frame.cpp:
rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::avoidsFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::layoutColumns):
rendering/RenderBlock.h: (WebCore::RenderBlock::hasOverhangingFloats): (WebCore::RenderBlock::hasColumns):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition):
rendering/RenderFlow.h: (WebCore::RenderFlow::hasColumns):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverflow):
rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverflow):
rendering/RenderView.cpp: (WebCore::RenderView::paint):

4:23 PM Changeset in webkit [18726] by justing

1 edit in trunk/LayoutTests/editing/pasteboard/4840662.html

Removed some extraneous text from this layout test. It passes now.

4:21 PM Changeset in webkit [22740] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-01-09 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.

<rdar://4906546> Win2K: crash when entering new URL in address field

Win2K compatibility fix. SafeArrayCreateVector doesn't work correctly on older systems (Win2K, etc.)

Some references to people stumbling across this bug (apologies for not being able to find a Microsoft support article):
http://discuss.develop.com/archives/wa.exe?A2=ind0104a&L=dotnet&D=0&T=0&P=69575
http://www.eggheadcafe.com/ng/microsoft.public.platformsdk.com_ole/Jul2005/post22989606.asp
http://www.pcreview.co.uk/forums/thread-1470025.php

MarshallingHelpers.cpp: (MarshallingHelpers::stringArrayToSafeArray): (MarshallingHelpers::intArrayToSafeArray): (MarshallingHelpers::intRectToSafeArray): (MarshallingHelpers::iunknownArrayToSafeArray):

4:11 PM Changeset in webkit [18725] by thatcher

3 edits
17 moves in trunk/WebKit

Reviewed by Darin.

Rename the now ObjC++ files to be .mm and remove the explicit file types.

DOM/WebDOMOperations.m: Removed.
DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed.
English.lproj/StringsNotToBeLocalized.txt:
Misc/WebCoreStatistics.m: Removed.
Misc/WebElementDictionary.m: Removed.
Misc/WebIconDatabase.m: Removed.
Misc/WebNSAttributedStringExtras.m: Removed.
Misc/WebNSPasteboardExtras.m: Removed.
Plugins/WebNetscapePluginEmbeddedView.m: Removed.
Plugins/WebNullPluginView.m: Removed.
Plugins/WebPluginContainerCheck.m: Removed.
WebCoreSupport/WebViewFactory.m: Removed.
WebKit.xcodeproj/project.pbxproj:
WebView/WebArchiver.m: Removed.
WebView/WebHTMLRepresentation.m: Removed.
WebView/WebHTMLView.m: Removed.
WebView/WebRenderNode.m: Removed.
WebView/WebResource.m: Removed.
WebView/WebScriptDebugDelegate.m: Removed.

4:08 PM Changeset in webkit [18724] by darin

30 edits in trunk

JavaScriptCore:

update 2007 Apple copyright for the new company name

kjs/DateMath.cpp:

WebCore:

update all 2007 Apple copyrights for the new company name

css/cssstyleselector.cpp:
html/HTMLLIElement.cpp:
platform/CharacterNames.h:
platform/TextBreakIterator.h:
platform/TextBreakIteratorICU.cpp:
platform/graphics/ImageBuffer.h:
rendering/CounterNode.cpp:
rendering/CounterNode.h:
rendering/RenderBox.h:
rendering/RenderContainer.cpp:
rendering/RenderCounter.cpp:
rendering/RenderCounter.h:
rendering/RenderImage.h:
rendering/RenderListItem.h:
rendering/RenderListMarker.h:
rendering/RenderObject.cpp:
rendering/RenderObject.h:
rendering/RenderStyle.cpp:
rendering/RenderStyle.h:
rendering/RenderTable.cpp:
rendering/RenderTableCell.cpp:
rendering/RenderTableCell.h:
rendering/RenderText.cpp:
rendering/RenderText.h:
rendering/RenderTreeAsText.cpp:
rendering/SVGRenderTreeAsText.cpp:
rendering/break_lines.cpp:

2:49 PM Changeset in webkit [18723] by justing

3 edits
8 adds in trunk

LayoutTests:

Reviewed by john

editing/inserting/4840662-expected.checksum: Added.
editing/inserting/4840662-expected.png: Added.
editing/inserting/4840662-expected.txt: Added.
editing/inserting/4840662.html: Added.
editing/pasteboard/4840662-expected.checksum: Added.
editing/pasteboard/4840662-expected.png: Added.
editing/pasteboard/4840662-expected.txt: Added.
editing/pasteboard/4840662.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4840662>
REGRESSION: Mail crash when dragging text into a link

moveParagraphs fails to move content into a display:block
anchor because of code in positionAvoidingSpecialElementBoundary,
and so it infinitely recurs.

editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors that have display:block so that content is inserted in the expected paragraph. This fixes the bug and weird behavior when typing before/after anchors with display:block.

2:29 PM Changeset in webkit [18722] by rwlbuis

4 edits
8 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12145
Color parsing is too relaxed in strict mode
http://bugs.webkit.org/show_bug.cgi?id=12166
REGRESSION (r18480): "336633" is not parsed as a color

Fix a regression by using String::format return value.
Also make strict mode more strict for cases where hexcolors
lack a #.

1:48 PM Changeset in webkit [18721] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed regression where redirects did not have user-agent any more

Showed up as a failure in one of the http tests, so no new test needed.

loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Don't use a copy of the ResourceRequest; pass the original so it can be modified.

1:39 PM Changeset in webkit [22739] by andersca

2 edits in branches/WindowsMerge/WebCore

Build fix.

platform/win/TextBoundariesWin.cpp:

1:36 PM Changeset in webkit [18720] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-01-09 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: Switching to landscape while graphical back is open causes UI problem.
http://bugs.webkit.org/show_bug.cgi?id=12168

BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):

1:32 PM Changeset in webkit [18719] by spadma

2 edits in S60/trunk/WebKit

2007-01-09 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: Switching to landscape while graphical back is open causes UI problem.
http://bugs.webkit.org/show_bug.cgi?id=12168

BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):

1:19 PM Changeset in webkit [18718] by darin

2 edits in trunk/JavaScriptCore

fix build

kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Actually compile it this time.

1:13 PM Changeset in webkit [18717] by darin

2 edits in trunk/JavaScriptCore

fix build

kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Change types.

1:11 PM Changeset in webkit [18716] by darin

2 edits in trunk/JavaScriptCore

fix build on platforms where Unicode::UChar is != uint16_t

kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Change types.

9:38 AM Changeset in webkit [18715] by ap

7 edits
2 adds in trunk

2007-01-09 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

changes for http://bugs.webkit.org/show_bug.cgi?id=11078 Forms Don't Submit (ASP Pages)

JavaScriptCore:

JavaScriptCore.exp:
kjs/value.cpp: (KJS::JSValue::toInt32): Folded toInt32Inline into this method, which was its only caller. (KJS::JSValue::toUInt32): Added a variant that reports if the conversion has succeeded.
kjs/value.h:

WebCore:

bindings/js/kjs_html.cpp: (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back to namedItem() if its argument does not convert to a number.

LayoutTests:

fast/dom/collection-namedItem-via-item-expected.txt: Added.
fast/dom/collection-namedItem-via-item.html: Added.

7:13 AM Changeset in webkit [18714] by spadma

2 edits in S60/branches/3.1m/MemoryManager

2007-01-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Fix build break caused by removing simple notifier
http://bugzilla.opendarwin.org/show_bug.cgi?id=

EABI/MemManU.DEF:

6:57 AM Changeset in webkit [18713] by spadma

2 edits in S60/trunk/MemoryManager

2007-01-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Fix build break by removing SimpleNotifier.
http://bugs.webkit.org/show_bug.cgi?id=

EABI/MemManU.DEF:

6:54 AM Changeset in webkit [18712] by darin

39 edits
1 add in trunk

JavaScriptCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=12174 improve Unicode use (less WTF::Unicode:: prefix, centralized character names)

wtf/unicode/icu/UnicodeIcu.h: Change parameter and return types to UChar32 and UChar. Removed unneeded type casts and added some const to functions that lacked it. Removed WTF::Unicode::memcmp. (WTF::Unicode::umemcasecmp): Renamed from strcasecmp since this doesn't work on 0-terminated strings as the str functions do.
wtf/unicode/qt4/UnicodeQt4.h: Ditto.

got rid of namespace prefixes from most uses of WTF::Unicode

kjs/function.cpp: (KJS::isStrWhiteSpace): (KJS::escapeStringForPrettyPrinting):
kjs/lexer.cpp: (KJS::Lexer::isWhiteSpace): (KJS::Lexer::isIdentStart): (KJS::Lexer::isIdentPart):
kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):

WebCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=12174 improve Unicode use (less WTF::Unicode:: prefix, centralized character names)

got rid of namespace prefixes from most uses of WTF::Unicode

updated for removal of WTF::Unicode::memcmp
updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.

unified constants for special Unicode characters in a new CharacterNames.h header

WebCore.xcodeproj/project.pbxproj:
css/cssparser.cpp: (WebCore::ParseString::lower):
dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::trailingWhitespacePosition):
editing/CompositeEditCommand.cpp: (WebCore::isWhitespace):
editing/HTMLInterchange.cpp:
editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::CircularSearchBuffer): (WebCore::CircularSearchBuffer::append):
editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): (WebCore::nonBreakingSpaceString):
editing/htmlediting.h:
html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
platform/GlyphMap.cpp: (WebCore::GlyphMap::locatePage):
platform/MimeTypeRegistry.h:
platform/StringHash.h:
platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::StringImpl::append): (WebCore::StringImpl::insert): (WebCore::StringImpl::truncate): (WebCore::StringImpl::remove): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize):t (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
platform/TextBoundaries.h:
platform/TextCodec.h:
platform/TextCodecLatin1.cpp:
platform/TextEncoding.h:
platform/TextEncodingRegistry.h:
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
platform/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
rendering/RenderListMarker.cpp: (WebCore::listMarkerText): (WebCore::RenderListMarker::paint):
rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::setInternalString):
rendering/RenderTreeAsText.cpp: (WebCore::quoteAndEscapeNonPrintables): (WebCore::operator<<):
rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::findNextLineBreak):
rendering/break_lines.cpp: (WebCore::nextBreakablePosition):
rendering/break_lines.h:
xml/XPathParser.cpp: (WebCore::XPath::charCat):

6:43 AM Changeset in webkit [18711] by darin

1 edit in trunk/WebCore/ChangeLog

Another change log tweak.

6:42 AM Changeset in webkit [18710] by darin

1 edit in trunk/WebCore/ChangeLog

Add the bug number.

6:36 AM Changeset in webkit [18709] by darin

2 edits in trunk/WebCore

Reviewed by Darin.

rendering/RenderText.h: (WebCore::RenderText::selectionState): Change the m_selectionState enum-bitfield to an unsigned-bitfield, because enums on Windows are signed, which caused it to become negative (whereas the valid values are all positive).

6:28 AM Changeset in webkit [18708] by darin

5 edits in trunk/WebCore

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=12175 port break_lines.cpp to be platform independent

platform/TextBreakIterator.h: Added lineBreakIterator. Removed ICU-specific stuff from the header.

platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Added helper to be shared by the three different creation functions. (WebCore::characterBreakIterator): Changed to use setUpIterator. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Added.

platform/qt/TextBreakIteratorQt.cpp: (WebCore::lineBreakIterator): Added a stub.

rendering/break_lines.cpp: (WebCore::isBreakableSpace): Added. (WebCore::shouldBreakAfter): Added. (WebCore::needsAdvancedBreakAnalysis): Added. (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms other than Mac.

6:19 AM Changeset in webkit [18707] by darin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Mitz.

added a Thai line breaking test

fast/text/international/thai-line-breaks-expected.checksum: Added.
fast/text/international/thai-line-breaks-expected.png: Added.
fast/text/international/thai-line-breaks-expected.txt: Added.
fast/text/international/thai-line-breaks.html: Added.

6:15 AM Changeset in webkit [18706] by mjs

4 edits in trunk/WebCore

Reviewed by Darin.

move WebDataProtocol load handling from ResourceLoader to MainResourceLoader

(it's only ever used for main resources)

loader/ResourceLoader.h: (WebCore::ResourceLoader::setRequest):
loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy):
loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse):

5:56 AM Changeset in webkit [18705] by rwlbuis