⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 11, 2007:

10:46 PM Changeset in webkit [18798] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 8705, readonly text fields should not get focus rings. Add a rule to that effect to
html4.css and then also add readonly as a special case for style sharing so that we can retain the
performance boost from sharing styles on inputs.

Reviewed by bdash

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::checkOneSelector):
  • css/html4.css:
10:28 PM Changeset in webkit [18797] by hyatt
  • 3 edits in trunk/LayoutTests/fast/overflow

Update overflow layout test results after autoscroll fix.

10:25 PM Changeset in webkit [18796] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 11595. Autoscrolling of layers didn't really work at all unless the layer was coincidentally
in the root layer's coordinate space. The event point was an absolute position within the document, but
the layer's rect was only local coords. This patch makes sure to use absolute bounds for the layer
when comparing it with the point.

This is covered by the scrollRevealButton test case already in the tree... the results change to be more
correct.

Reviewed by ggaren

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
10:25 PM Changeset in webkit [18795] by ggaren
  • 9 edits in trunk/JavaScriptCore

RS by Brady Eidson.


Rolling out r18786 because it caused leaks.

9:50 PM Changeset in webkit [22759] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <​sfalken@apple.com>

  • WebKit.vcproj/WebKit.make:
9:33 PM Changeset in webkit [18794] by beidson
  • 9 edits in trunk/WebCore

Reviewed by Oliver

-Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
-Make more of ResourceLoader cross-platform

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCancellation):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willCacheResponse):
  • loader/mac/ResourceLoaderMac.mm:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation): (WebCore::ResourceHandle::clearAuthentication): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):


8:48 PM Changeset in webkit [18793] by hyatt
  • 2 edits in trunk/WebCore

A hit test is returning a null renderer. Make sure to null-check it in the autoscroll code.
This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
on the front page of yahoo.com!

Reviewed by mark

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
8:37 PM Changeset in webkit [18792] by hyatt
  • 3 edits
    5 adds in trunk

LayoutTests:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark


  • fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
  • fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • fast/multicol/columns-shorthand-parsing-expected.txt: Added.
  • fast/multicol/columns-shorthand-parsing.html: Added.

WebCore:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark

fast/multicol/columns-shorthand-parsing.html

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
8:29 PM Changeset in webkit [18791] by bdash
  • 27 edits in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • rendering/RenderTable.cpp: (WebCore::resetSectionPointerIfNotBefore): Added this function to help with checking if a section being inserted is the going to be the first of its kind. (WebCore::RenderTable::addChild): Changed to maintain the pointers to the header, the footer, the caption and the first table body properly when objects are inserted in the middle. Also changed to make the first caption win over any other captions. This matches Firefox and what already used to happen when a section recalc took place. (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating over the sections from top to bottom. (WebCore::RenderTable::calcBorderLeft): Changed to really find the section containing the first row. (WebCore::RenderTable::calcBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was skipped if the input was the footer. (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header" respectively.

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Collapsed borders changed in the "marvin" tests, as the footer cells now
collapse correctly with the last row of the body. Visual differences not
captured by the pixel results since they occurred below 600px.

The "other" test has changed since in a table with multiple captions,
now the first one wins. No visual difference in this case since both captions
are the same.

  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/backgr_position-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/other/test4-expected.txt:
8:28 PM Changeset in webkit [18790] by bdash
  • 13 edits in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Fixed fixed table layout. Implemented an algorithm that matches the behavior
of Firefox, up to rounding errors.

Fixes three existing table tests.

  • rendering/FixedTableLayout.cpp: Undid accidental search-and-replace of "width" to "m_width" in the comments. Removed an outdated comment, since WebKit no longer honors table-layout:fixed for variable-width tables. (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the first row. Changed to divide the width specified for a cell that spans multiple columns between the columns rather than assign its entire width to each column. (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): Implemented the behavior observed in Firefox.
  • rendering/FixedTableLayout.h:

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • tables/mozilla/bugs/bug157890-expected.checksum:
  • tables/mozilla/bugs/bug157890-expected.png:
  • tables/mozilla/bugs/bug157890-expected.txt:
  • tables/mozilla/bugs/bug44505-expected.checksum:
  • tables/mozilla/bugs/bug44505-expected.png:
  • tables/mozilla/bugs/bug44505-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
8:25 PM Changeset in webkit [18789] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Changed the ImageDiff tool not to use CoreImage filters.

  • DumpRenderTree/ImageDiff.m: (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap):
8:24 PM Changeset in webkit [18788] by bdash
  • 6 edits
    4 adds in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/block/basic/fieldset-stretch-to-legend.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic width if the object requires it. (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup. (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum intrinsic width if the object requires it.
  • rendering/RenderBox.h: (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's implementation to ensure that the legend's will fit in the fieldset's minimum intrinsic width. (WebCore::RenderFieldset::findLegend): Made const. (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when the legend does overflow the fieldset. This is the part of the fix that prevents the assertion failure. If the legend intersects with a corner of the fieldset's border, that corner will not be painted, even if it is not completely occluded. This edge case can be improved with clipping in the future. Added FIXME to implement border-radius.
  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to return true.

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • fast/block/basic/fieldset-stretch-to-legend-expected.checksum: Added.
  • fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • fast/block/basic/fieldset-stretch-to-legend-expected.txt: Added.
  • fast/block/basic/fieldset-stretch-to-legend.html: Added.
6:53 PM Changeset in webkit [22758] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::cfURLResponse): Add getter that I forgot to commit.
5:14 PM Changeset in webkit [22757] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:05 PM Changeset in webkit [18787] by sfalken
  • 1 copy in tags/Safari-521.32.11b

New tag.

4:46 PM Changeset in webkit [18786] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

ReferencesSet | ProtectCounts => ProtectCountSet (because it's a typename for a set of GC protect counts)
ReferencesByRootMap => RootObjectMap (because RootObjectToProtectCountSetMap would have been confusing)
pv => protectedValues
rootObjectForImp => getRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => getRootObject (ditto)
findReferenceSet => getProtectCountSet
imp => jsObject


(KJS::Bindings::getRootObjectMap): Changed to take advantage of built-in
facility for initializing static variables.

(KJS::Bindings::getProtectCountSet):
(KJS::Bindings::destroyProtectCountSet): Added. Helps encapsulate the fact
that getting a ProtectCountSet entails adding a RootObject to a hash table,
and destroying one entails the reverse.

(KJS::Bindings::getRootObject): Removed spurious NULL check.


(KJS::Bindings::findReferenceSet): Renamed. Changed to use getRootObject()
instead of iterating on its own.

(KJS::Bindings::addNativeReference): Changed to use an early return instead
of indenting the whole function.
(KJS::Bindings::removeNativeReference): Ditto.

3:35 PM Changeset in webkit [22756] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

Implement "Make Text Normal Size".

  • WebView.cpp: (WebView::canMakeTextStandardSize): Added (WebView::makeTextStandardSize): Added (WebView::toggleContinuousSpellChecking): Added (WebView::toggleSmartInsertDelete): Added
3:14 PM Changeset in webkit [18785] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Build Fix Karma

I broke the release build (debug build passed)

  • platform/network/mac/AuthenticationMac.mm: (WebCore::core):
3:04 PM Changeset in webkit [22755] by beidson
  • 5 edits in branches/WindowsMerge

Make it build again after my HTTP Auth opensource checkin

2:35 PM Changeset in webkit [18784] by beidson
  • 1 edit in trunk/WebCore/platform/network/mac/AuthenticationMac.mm

Blind build fix attempt

2:20 PM Changeset in webkit [18783] by beidson
  • 23 edits
    8 adds in trunk

WebCore:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::didCancel):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation): (WebCore::ResourceHandleClient::willCacheResponse):
  • platform/network/ResourceResponse.h: (WebCore::operator!=):
  • platform/network/URLAuthenticationChallenge.cpp: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::URLAuthenticationChallenge::previousFailureCount): (WebCore::URLAuthenticationChallenge::proposedCredential): (WebCore::URLAuthenticationChallenge::protectionSpace): (WebCore::URLAuthenticationChallenge::failureResponse): (WebCore::URLAuthenticationChallenge::error): (WebCore::URLAuthenticationChallenge::isNull): (WebCore::URLAuthenticationChallenge::nullify): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/URLAuthenticationChallenge.h: Added. (WebCore::URLAuthenticationChallenge::sender): (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/URLCredential.cpp: Added. (WebCore::URLCredential::URLCredential): (WebCore::URLCredential::user): (WebCore::URLCredential::password): (WebCore::URLCredential::hasPassword): (WebCore::URLCredential::persistence): (WebCore::operator==):
  • platform/network/URLCredential.h: Added. (WebCore::): (WebCore::operator!=):
  • platform/network/URLProtectionSpace.cpp: Added. (WebCore::URLProtectionSpace::URLProtectionSpace): (WebCore::URLProtectionSpace::host): (WebCore::URLProtectionSpace::port): (WebCore::URLProtectionSpace::serverType): (WebCore::URLProtectionSpace::realm): (WebCore::URLProtectionSpace::authenticationScheme): (WebCore::operator==):
  • platform/network/URLProtectionSpace.h: Added. (WebCore::): (WebCore::operator!=):
  • platform/network/mac/AuthenticationMac.h: Added.
  • platform/network/mac/AuthenticationMac.mm: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::mac): (WebCore::core):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::operator==):

WebKit:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
  • WebKit.xcodeproj/project.pbxproj:

WebKitQt:

Keep the fancy new FrameLoaderClientQt building with a small api change in WebCore
Yay for the loader on QT!

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientQt::dispatchDidCancelAuthenticationChallenge):
  • WebCoreSupport/FrameLoaderClientQt.h:
2:02 PM Changeset in webkit [18782] by ggaren
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction


Also removed unnecessary use of "Bindings::" prefix.

  • JavaScriptCore.exp:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::setCreateRootObject):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::createRootObject):

WebCore:

Reviewed by Anders Carlsson.


Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
rootForView => createRootObject
getInstanceForView => getPluginInstanceForWidget

  • page/mac/FrameMac.mm: (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void* variable named "nativeHandle" to be more explicit about the fact that JavaScript's "nativeHandle" is just an NSView *.

(WebCore::getPluginInstanceForWidget): This function now does the NSView *
fetching that its callers used to do.
(WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
(WebCore::FrameMac::getObjectInstanceForWidget): ditto

  • page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category, which was really more of a shmategory. (createRootObject): Removed rootObjectForView, folding it into its only caller, the similarly named rootForView. Renamed the pair to "createRootObject" because that's what they do.

(-[WebCoreFrameBridge init]): Updated for renames

1:52 PM Changeset in webkit [18781] by andersca
  • 1 edit in trunk/WebCore/loader/DocLoader.cpp

Get rid of garbage

1:47 PM Changeset in webkit [18780] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix crash on platforms that don't use the new loader yet.


  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
1:45 PM Changeset in webkit [18779] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam.

  • fast/forms/select-type-ahead-non-latin-expected.txt: Added.
  • fast/forms/select-type-ahead-non-latin.html: Added.

WebCore:

Reviewed by Adam.

Test: fast/forms/select-type-ahead-non-latin.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific isprint() condition to a Unicode isPrintableChar().
1:41 PM Changeset in webkit [18778] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by geoff


<rdar://problem/4889140>
GMail Editor: List creation fails in new message

  • editing/execCommand/insert-list-empty-div-expected.checksum: Added.
  • editing/execCommand/insert-list-empty-div-expected.png: Added.
  • editing/execCommand/insert-list-empty-div-expected.txt: Added.
  • editing/execCommand/insert-list-empty-div.html: Added.

WebCore:

Reviewed by geoff


<rdar://problem/4889140>
GMail Editor: List creation fails in new message

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Inserting the list into an empty paragraph not held open by a br or a '\n', will invalidate start and end. Insert a placeholder and then recompute start and end.
1:15 PM Changeset in webkit [18777] by lars
  • 2 edits
    1 delete in trunk/WebCore

This one is not needed any longer neither.

1:04 PM Changeset in webkit [18776] by lars
  • 2 edits in trunk/WebKitTools

fix compilation of DumpRenderTree. Will hopefully
make the built bot happy :)

12:45 PM Changeset in webkit [18775] by lars
  • 2 edits
    1 delete in trunk/WebCore

remove now unused file.

12:33 PM Changeset in webkit [18774] by ddkilzer
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

  • loader/mac/FrameLoaderMac.mm: Removed import of LoaderNSURLRequestExtras.h.
  • loader/mac/SubresourceLoaderMac.mm: Ditto.
12:03 PM Changeset in webkit [18773] by staikos
  • 2 edits in trunk/WebCore

Fix compile

12:00 PM Changeset in webkit [22754] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::advanceToNextMisspelling):
11:53 AM Changeset in webkit [18772] by andersca
  • 8 edits in trunk/WebCore

Fix build.


  • dom/XMLTokenizer.cpp:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedImage.cpp:
  • loader/DocLoader.cpp:
  • loader/loader.cpp:
  • xml/XSLTProcessor.cpp:
  • xml/xmlhttprequest.cpp:
11:30 AM Changeset in webkit [18771] by andersca
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Adam.

Loader cleanup, get rid of unused code.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedResource.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/DocLoader.h:
  • loader/LoaderFunctions.h: Removed.
  • loader/mac/CachedResourceMac.mm: Removed.
  • loader/mac/LoaderFunctionsMac.mm: Removed.
  • loader/mac/LoaderNSURLRequestExtras.h: Removed.
  • loader/mac/LoaderNSURLRequestExtras.m: Removed.
  • loader/mac/SubresourceLoaderMac.mm:
  • page/mac/WebCoreFrameBridge.mm:
  • platform/network/ResourceHandle.cpp:
10:25 AM Changeset in webkit [18770] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Better Changelog.

10:19 AM Changeset in webkit [18769] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION:
<input> and <textarea> not focused on right click (4908884 in
Radar)

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Ask if we *have* swallowed the event instead of if we *haven't* when deciding to perform a selection.
8:42 AM Changeset in webkit [18768] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Added null check.
8:39 AM Changeset in webkit [18767] by darin
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

  • WebView/WebDataSource.mm: (-[WebDataSource data]): Added null check.
6:55 AM Changeset in webkit [18766] by darin
  • 2 edits in trunk/WebCore
  • platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
4:34 AM Changeset in webkit [18765] by lars
  • 10 edits in trunk

Start using the loader in the Qt port.

4:23 AM Changeset in webkit [18764] by darin
  • 22 edits
    6 deletes in trunk

WebCore:

Reviewed by Hyatt.

  • removed a couple Mac bridging classes; put the code in WebKit instead
  • WebCore.exp: Updated for new WebKit uses.
  • WebCore.xcodeproj/project.pbxproj: Removed files.
  • bridge/mac/WebCoreEncodings.h: Removed.
  • bridge/mac/WebCoreEncodings.mm: Removed.
  • bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
  • bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
  • platform/mac/WebNSAttributedStringExtras.h: Removed.
  • platform/mac/WebNSAttributedStringExtras.mm: Removed.
  • platform/mac/PasteboardMac.mm: (WebCore::stripAttachmentCharacters): Added. Moved code from WebNSAttributedStringExtras.mm, and fixed a garbage collection problem (a global with a plain old retain rather than HardRetain). (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
  • removed some DeprecatedCString use
  • loader/FrameLoader.cpp: Changed to use String more to eliminate use of DeprecatedCString here in the mailto form support. But maybe we can remove this entirely. Do we really care about mailto forms any more?
  • platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
  • platform/PlatformString.h: Added replace that takes two strings.
  • platform/StringImpl.h: Ditto.
  • platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
  • platform/TextStream.h: Remove DeprecatedCString case.
  • platform/TextStream.cpp: Ditto.
  • made a few more files use CharacterNames.h
  • platform/CharacterNames.h: Added some more character names and sorted alphabetically.
  • bridge/mac/WebCoreStringTruncator.mm: (centerTruncateToBuffer): Use character name from CharacterNames.h. (rightTruncateToBuffer): Ditto. (truncateString): Ditto.
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.

WebKit:

Reviewed by Hyatt.

  • moved code from a couple WebCore bridging classes here instead
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge.
  • WebView/WebHTMLRepresentation.mm: (stringArray): Added. Helper to convert a HashSet to an NSArray. (concatenateArrays): Added. Helper to concatenate two NSArray objects. (+[WebHTMLRepresentation supportedMIMETypes]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. Also fix a potential GC problem by using a RetainPtr instead of a [retain] on a global variable. (+[WebHTMLRepresentation supportedNonImageMIMETypes]): Ditto. (+[WebHTMLRepresentation supportedImageMIMETypes]): Ditto.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. (-[WebHTMLView _documentFragmentWithPaths:]): Ditto.
  • WebView/WebView.mm: (+[WebView _decodeData:]): Moved code here from the old WebCoreEncodings class.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with this file. Moved WebRenderNode into the appropriate group.
4:22 AM Changeset in webkit [18763] by hyatt
  • 2 edits in trunk/LayoutTests/fast/overflow

Land reverted layout tests for the two overflow cases. Although the new results were better, there are issues with what I did to achieve them, so for now going back to the (broken) old results.

4:21 AM Changeset in webkit [18762] by hyatt
  • 3 edits in trunk/WebCore

Fix two bugs in positionForCoordinates. (Make it work when you have a margin in between your border and
your first child block.)

Rewrite column rebalancing to have two modes: constrained and unconstrained. In unconstrained mode,
the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
for the overall block. In constrained mode, columns flow into the fixed height block, and extra columns
spill out horizontally in the appropriate direction (RTL/LTR).

Make columns work properly with both LTR and RTL overflow blocks.

Initial column test suite coming soon now that the basic layout is right.

Reviewed by darin

  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::hasColumns):
3:13 AM Changeset in webkit [18761] by hyatt
  • 4 edits in trunk/LayoutTests/svg/custom

Fix SVG test cases.

12:51 AM Changeset in webkit [18760] by rwlbuis
  • 14 edits in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12201
Fix image dragging issues with ​http://www.carto.net/papers/svg/gui/scrollbar/index.svg

Fix calculation of absolute transform so that viewport x,y
translation is always done, also when viewBox is set.

Jan 10, 2007:

11:48 PM Changeset in webkit [18759] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderBlock.cpp

Remove unused variable.

11:26 PM Changeset in webkit [18758] by hyatt
  • 30 edits in trunk/WebCore

Rework positionForCoordinates to be more efficient and to handle multi-column content. This entailed
adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
space of the renderer.

positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
absolute positions over and over again.

Reviewed by darin

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXTextMarkerRangeForLine:]): (-[WebCoreAXObject doAXTextMarkerForPosition:]):
  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
  • editing/SelectionController.cpp: (WebCore::SelectionController::contains):
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::sendContextMenuEvent):
  • page/EventHandler.h:
  • page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
  • page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::localPoint):
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/HitTestResult.h: (WebCore::HitTestResult::localPoint): (WebCore::HitTestResult::setLocalPoint):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::positionForCoordinates):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateHitTestResult):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForCoordinates):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): (WebCore::RootInlineBox::closestLeafChildForXPos):
  • rendering/RootInlineBox.h:
11:12 PM Changeset in webkit [18757] by staikos
  • 9 edits in trunk

Fix Qt build again

8:44 PM Changeset in webkit [18756] by bdash
  • 2 edits in trunk/WebKit

2007-01-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _resetCachedWebPreferences:]): (-[WebHTMLView setDataSource:]): Added a call to _resetCachedWebPreferences:. Added an assertion that the view is not closed, instead of reopening it. Reopening should not occur, now that <​http://bugs.webkit.org/show_bug.cgi?id=12087> is fixed.
6:24 PM Changeset in webkit [18755] by bdash
  • 11 edits
    12 adds in trunk

2007-01-10 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Fixes for ​http://bugs.webkit.org/show_bug.cgi?id=11841

Set image size to fit alt text when image or input-image element
has no src attribute, so that those images show their alt text instead
of showing nothing at all.

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::imageChanged):
  • rendering/RenderImage.h:

2007-01-10 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

New and adjusted test cases for
​http://bugs.webkit.org/show_bug.cgi?id=11841

  • fast/dom/HTMLImageElement/image-alt-text-expected.checksum: Added.
  • fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
  • fast/dom/HTMLImageElement/image-alt-text-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-alt-text.html: Added.
  • fast/dom/HTMLImageElement/resources/blue_rect.jpg: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text.html: Added.
  • fast/dom/HTMLInputElement/resources/blue_rect.jpg: Added.
  • fast/forms/focus2-expected.txt:
  • fast/forms/focus2.html:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-value-expected.png:
  • fast/forms/input-value-expected.txt:
6:18 PM Changeset in webkit [18754] by bdash
  • 2 edits in trunk/WebCore

2007-01-11 Mark Rowe <​mrowe@apple.com>

Build fix.

  • rendering/RenderView.cpp: (WebCore::RenderView::printing):
5:47 PM Changeset in webkit [22753] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2007-01-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

<rdar://problem/4818840> Crash occurs after selecting Print Preview from under the File menu if no printer is selected


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::computePageRects): removed calls to setupRootForPrinting
  • bridge/win/FrameWin.h: removed setupRootForPrinting
5:46 PM Changeset in webkit [18753] by bdash
  • 4 edits
    2 adds in trunk

2007-01-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/css/remove-shorthand.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::PropertyLonghand::PropertyLonghand): Added this structure containing a pointer to an array if properties and the array's length. (WebCore::PropertyLonghand::properties): (WebCore::PropertyLonghand::length): (WebCore::initShorthandMap): Initialize the mapping from shorthand properties to their dependent properties. (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check if the property being removed is a shorthand, and if so, to remove all of its dependent properties. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a 'notifyChanged' boolean parameter which controls whether this method calls setChanged() if it actually removes any property.
  • css/CSSMutableStyleDeclaration.h:

2007-01-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/css/remove-shorthand-expected.txt: Added.
  • fast/css/remove-shorthand.html: Added.
5:39 PM Changeset in webkit [18752] by sfalken
  • 9 edits in trunk/WebCore

2007-01-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Kevin.

Removed unnecessary printing state

5:23 PM Changeset in webkit [22752] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Another build fix.


  • WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):
  • WebContextMenuClient.h:
5:20 PM Changeset in webkit [22751] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Another build fix.


  • WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):
5:11 PM Changeset in webkit [22750] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Yet another build fix.


  • platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::getResponseModifiedHeader):
4:56 PM Changeset in webkit [18751] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Get the Refresh header directly from the ResourceResponse.


  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad):
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::getResponseModifiedHeader):
4:17 PM Applications using WebKit edited by markmalone@mac.com
(diff)
4:16 PM Changeset in webkit [18750] by ggaren
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Fixed minor validation error.
4:10 PM Changeset in webkit [18749] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth Dakin.


Updated coding style guidelines to cover a lot of stuff previously absent.

  • coding/coding-style.html:
3:42 PM Changeset in webkit [22749] by bdakin
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

  • WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Do all of the work we used to do in WebCore over here in WebKit.
  • WebContextMenuClient.h:
3:32 PM Changeset in webkit [18748] by bdakin
  • 8 edits in trunk

WebCore:

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

  • page/ContextMenuClient.h: New call to the client to search in google.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the client instead of forming a new url string and loading it.
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.

WebKit:

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::searchWithGoogle): Call into WebView to search in Google.
  • WebView/WebViewInternal.h: Make _searchWithGoogleFromMenu available.
1:38 PM Changeset in webkit [18747] by aroben
  • 2 edits in trunk/WebCore

Rubberstamped by Darin.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0 instead of an empty Event to FrameLoader::load and FrameLoader::urlSelected.
12:58 PM Changeset in webkit [22748] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Another build fix.


  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp:

WebKitWin:

Build fix.


  • WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
  • WebFrame.h:
12:57 PM Changeset in webkit [18746] by andersca
  • 2 edits in trunk/WebCore
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): Disable assertion (I forgot to do this even though I added the comment!)
12:53 PM Changeset in webkit [18745] by andersca
  • 2 edits in trunk/WebCore

Reviewed and landed by Anders.

Fix case in vcproj file (the GTK+ port uses the vcproj file).

  • WebCore.vcproj/WebCore/WebCore.vcproj:
12:12 PM Changeset in webkit [18744] by lars
  • 6 edits
    2 deletes in trunk/WebCore

Make the Qt build compile again after
the ResourceLoader was made platform
independent.

12:01 PM Changeset in webkit [22747] by andersca
  • 5 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Add WebDocumentLoader. Implement some of the FrameLoaderClient methods.
Add a resourceRequest() getter to WebMutableURLRequest.


  • WebDocumentLoader.cpp: Added. (WebDocumentLoader::WebDocumentLoader): (WebDocumentLoader::setDataSource): (WebDocumentLoader::dataSource): (WebDocumentLoader::attachToFrame): (WebDocumentLoader::detachFromFrame):
  • WebDocumentLoader.h: Added.
  • WebFrame.cpp: (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::updateGlobalHistoryForReload): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad):
  • WebKit.vcproj/WebKit.vcproj:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::resourceRequest):
  • WebMutableURLRequest.h:
11:59 AM Changeset in webkit [22746] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::setDefersLoading):
11:39 AM Changeset in webkit [18743] by andersca
  • 9 edits
    1 delete in trunk/WebCore

Rubber-stamped by Maciej.


Move most of ResourceLoader and MainResourceLoader into the platform-independent files.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didFinishLoad):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::~MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
  • loader/MainResourceLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::frameLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::clearResourceData): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::response): (WebCore::ResourceLoader::cancelledError):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::setRequest):
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/MainResourceLoaderMac.mm: Removed.
  • loader/mac/ResourceLoaderMac.mm:
10:46 AM Changeset in webkit [18742] by lars
  • 2 edits
    5 adds
    5 deletes in trunk/WebCore

Move files to the correct location, and remove a few
unused methods from LoaderFunctionsQt.cpp

10:45 AM Changeset in webkit [22745] by andersca
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Make WebBackForwardList wrap a WebCore::BackForwardList. Add wrapper map to WebHistoryItem.

  • WebBackForwardList.cpp: (backForwardListWrappers): (WebBackForwardList::WebBackForwardList): (WebBackForwardList::~WebBackForwardList): (WebBackForwardList::createInstance): (WebBackForwardList::addItem): (WebBackForwardList::goBack): (WebBackForwardList::goForward): (WebBackForwardList::goToItem): (WebBackForwardList::backItem): (WebBackForwardList::currentItem): (WebBackForwardList::forwardItem): (WebBackForwardList::backListWithLimit): (WebBackForwardList::forwardListWithLimit): (WebBackForwardList::capacity): (WebBackForwardList::setCapacity): (WebBackForwardList::backListCount): (WebBackForwardList::forwardListCount): (WebBackForwardList::containsItem): (WebBackForwardList::itemAtIndex): (WebBackForwardList::setPageCacheSize): (WebBackForwardList::pageCacheSize): (WebBackForwardList::setDefaultPageCacheSizeIfNecessary):
  • WebBackForwardList.h:
  • WebHistoryItem.cpp: (historyItemWrappers): (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::QueryInterface): (WebHistoryItem::initWithURLString): (WebHistoryItem::historyItem):
  • WebHistoryItem.h:
9:20 AM Changeset in webkit [18741] by aroben
  • 1 edit in trunk/WebCore/ChangeLog

Corrected Radar reference.

9:15 AM Changeset in webkit [18740] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix: <rdar://problem/4903003> ContextMenuController leaks Events

No layout tests possible.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr to manage the lifetime of Shared objects.
6:11 AM Changeset in webkit [18739] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12196
SVGPatternElement should not be locatable

Replace SVGStyledLocatableElement derivation with
SVGStyledElement.

4:14 AM Changeset in webkit [18738] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.
Use correct method name in the ASSERT in RenderSVGText.

3:40 AM Changeset in webkit [18737] by zimmermann
  • 102 edits in trunk

Reviewed by Eric.
Large SVG dynamic update rework/optimization.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
Partly fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)

Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)

1:57 AM Changeset in webkit [18736] by lars
  • 2 edits in trunk/JavaScriptCore

Use the new functionality in Qt 4.3, to make
the methods closer compliant with the Unicode
spec.

Keep the old code so that it still compiles against
Qt 4.2.

12:59 AM Changeset in webkit [18735] by hyatt
  • 2 edits in trunk/WebCore

Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect. This enables
the method to be multi-column aware and also to understand when the selection is clipped out by overflow.

Reviewed by bdash

  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):
12:09 AM Changeset in webkit [18734] by hyatt
  • 5 edits in trunk/WebCore

Make the absolutePosition method multi-column aware. Note that there is now a real problem with the
absoluteRects method, since an object can split across multiple columns and break into multiple rects.
absolutePosition just returns the top-left corner of the element's box in the first column in which it
appears.

Reviewed by bdash

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustRectForColumns):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):
Note: See TracTimeline for information about the timeline view.