⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 12, 2007:

11:11 PM Changeset in webkit [18828] by hyatt
  • 4 adds in trunk/LayoutTests/fast/multicol

Add layout test for column rules.

11:08 PM Changeset in webkit [18827] by hyatt
  • 3 edits in trunk/WebCore

Add support for column rules.

Reviewed by bdash

fast/multicol/column-rules.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::columnRuleIsTransparent):
9:32 PM Changeset in webkit [18826] by hyatt
  • 3 edits in trunk/WebCore

Make multicolumn layout work with floats.

Reviewed by andersca

Added fast/multicol/float-multicol.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject):
  • rendering/RenderBlock.h:
9:31 PM Changeset in webkit [18825] by hyatt
  • 6 adds in trunk/LayoutTests/fast/multicol

New fancy float multicol test (thanks Mozilla!)

8:22 PM Changeset in webkit [18824] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for fast/css/line-height.html REGRESSION (r18816-r18818): Assertion failure in WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
  • fast/css/line-height-expected.checksum: Added.
  • fast/css/line-height-expected.png: Added.
  • fast/css/line-height-expected.txt: Added.
  • fast/css/line-height.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/css/line-height.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
6:15 PM Changeset in webkit [22763] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Build fixes.


  • WebFrame.cpp: (WebFrame::assignIdentifierToInitialRequest): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): (WebFrame::incrementProgress): (WebFrame::completeProgress): (WebFrame::dispatchDidReceiveAuthenticationChallenge): (WebFrame::dispatchDidCancelAuthenticationChallenge):
  • WebFrame.h:
5:47 PM Changeset in webkit [18823] by andersca
  • 1 edit in trunk/JavaScriptCore/wtf/HashTraits.h

Forgot to save.

5:44 PM Changeset in webkit [18822] by andersca
  • 16 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • wtf/HashTraits.h: Add hash traits for unsigned long and unsigned long long.

WebCore:

Reviewed by Darin.

Use unsigned long for identifiers instead of Objective-C objects.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::assignIdentifierToInitialRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::setIdentifier): (WebCore::ResourceLoader::identifier):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::createUniqueIdentifier):
  • page/Page.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress):

WebKit:

Reviewed by Darin.

Add a HashMap between unsigned longs and Objective-C objects and use it for
the resource load delegate.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress):
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _addObject:forIdentifier:]): (-[WebView _objectForIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
  • WebView/WebViewInternal.h:
5:19 PM Changeset in webkit [18821] by bdash
  • 2 edits in trunk/WebCore

2007-01-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value of 'overflow-x' and 'overflow-y'.
4:45 PM Changeset in webkit [22762] by adachan
  • 6 edits
    1 add in branches/WindowsMerge/WebKitWin

2007-01-12 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

WebKitWin:

  • Added IWebBackForwardListPrivate which contains the removeItem method, used in undo/redo of closing tabs.
  • Fixed a null dereference I ran into in WebFrame::dispatchDidFirstLayout.
  • Interfaces/IWebBackForwardListPrivate.idl: Added.
  • WebBackForwardList.cpp: (WebBackForwardList::QueryInterface): (WebBackForwardList::removeItem):
  • WebBackForwardList.h:
  • WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
3:07 PM Changeset in webkit [18820] by justing
  • 17 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt

<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work

Added to test changes:

  • editing/style/fontsize-1-expected.checksum: Added.
  • editing/style/fontsize-1-expected.png: Added.
  • editing/style/fontsize-1-expected.txt: Added.
  • editing/style/fontsize-1.html: Added.

Removed use of "px" and "pt" values passed to
execCommand("FontSize", ...) (other browsers don't
support them):

  • editing/input/attributed-substring-from-range-lines.html-disabled:
  • editing/style/block-style-004-expected.checksum:
  • editing/style/block-style-004-expected.png:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-004.html:
  • editing/style/block-style-005-expected.checksum:
  • editing/style/block-style-005-expected.png:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-005.html:
  • editing/style/block-style-006-expected.checksum:
  • editing/style/block-style-006-expected.png:
  • editing/style/block-style-006-expected.txt:
  • editing/style/block-style-006.html:

WebCore:

Reviewed by hyatt


<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work

Changed execCommand("FontSize", ...) to match the spec
and the behavior of other browsers. It expects a number,
n, which, the spec says can be 1 through 7. Other browsers
perform the font size change by creating a font element
wrapper with size="n". We convert n into one of the absolute
size CSS keywords (x-small, medium, etc.).

  • editing/JSEditor.cpp: Call cssValueFromFontSizeNumber. If successful, perform the style change.
  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::cssValueFromFontSizeNumber): Added. Moved this code from parsedMappedAttribute so that it could be called from the Editor. (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into cssValueFromFontSizeNumber.
  • html/HTMLFontElement.h:
2:53 PM Changeset in webkit [18819] by hyatt
  • 18 edits in trunk/WebCore

Fix for bug 11598, implement lightweight control clipping mechanism for
buttons, list boxes, and dropdown lists. Make sure list box respects
scrollLeft/Top/Width/Height as well as clientWidth/Height.

Fix bugs in RenderStyle::diff. CursorData was not being compared properly.
vertical-align had a non-inline display check that was wrong (preventing
dynamic changes to keyword-based vertical-align from working).

Reviewed by mitz

  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::layoutColumns):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::setStyle): (WebCore::RenderButton::controlClipRect):
  • rendering/RenderButton.h: (WebCore::RenderButton::hasControlClip):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::itemHeight): (WebCore::RenderListBox::verticalScrollbarWidth): (WebCore::RenderListBox::scrollWidth): (WebCore::RenderListBox::scrollHeight): (WebCore::RenderListBox::scrollLeft): (WebCore::RenderListBox::setScrollLeft): (WebCore::RenderListBox::scrollTop): (WebCore::RenderListBox::setScrollTop): (WebCore::RenderListBox::controlClipRect):
  • rendering/RenderListBox.h: (WebCore::RenderListBox::hasControlClip):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::controlClipRect):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasControlClip):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::verticalScrollbarWidth): (WebCore::RenderObject::horizontalScrollbarHeight): (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasControlClip): (WebCore::RenderObject::controlClipRect): (WebCore::RenderObject::contentWidth): (WebCore::RenderObject::contentHeight):
  • rendering/RenderStyle.cpp: (WebCore::StyleVisualData::StyleVisualData): (WebCore::cursorDataEqvuialent): (WebCore::StyleInheritedData::operator==): (WebCore::CursorList::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::LengthBox::operator!=): (WebCore::StyleVisualData::operator==): (WebCore::CursorData::operator==): (WebCore::CursorData::operator!=): (WebCore::CursorList::operator!=): (WebCore::RenderStyle::setTableLayout):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2:46 PM Changeset in webkit [18818] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderTextControl.cpp

Ooops left off paren.

2:43 PM Changeset in webkit [18817] by yongjzha
  • 13 edits in S60/branches/3.1m

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18804)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,24 @@
+2007-01-12 w3liu <​wei.liu@nokia.com>
+
+ Reviewed by ​yongjun.zhang@nokia.com.
+ DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
+ ​http://bugzilla.opendarwin.org/show_bug.cgi?id=12225
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * BWINS/WEBCOREU.DEF:
+ * EABI/WebCoreU.DEF:
+ * bridge/WebCoreBridge.cpp:
+ (CWebCoreBridge::CreateDocumentWithEncoding):
+ * bridge/WebCoreBridge.h:
+ * khtml/khtml_part.cpp:
+ (KHTMLPart::write):
+ (KHTMLPart::setEncoding):
+ * khtml/khtmlpart_p.h:
+ * kwq/KWQKHTMLPart.cpp:
+ (KWQKHTMLPart::setEncoding):
+ * kwq/KWQKHTMLPart.h:
+

2:35 PM Changeset in webkit [18816] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 9934, smaller line heights should not be allowed on
text fields.

Reviewed by darin

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle):
2:26 PM Changeset in webkit [18815] by ddkilzer
  • 6 edits in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • fast/css/remove-shorthand-expected.txt:
  • fast/css/remove-shorthand.html:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/css/remove-shorthand.html (updated)

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::initShorthandMap):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
1:49 PM Changeset in webkit [18814] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Mitz.

Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.

1:46 PM Changeset in webkit [18813] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by andersca.

Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the loader plumbing was moved to WebCore. Pinging the plug-in database to ask it if it supports a given mime type has the side effect of reading from disk on first call, therefore such a check should be a last resort.
1:23 PM Changeset in webkit [18812] by spadma
  • 10 edits in S60/trunk/WebKit

2007-01-12 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Autoform fill and key event handling
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlInputSkin.h:
  • BrowserCore/Formcontrols/inc/FControlInputWidget.h:
  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h: (CControlSelectWidget::GetSelectWidgetRect):
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::HandlePointerEventL): (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::HandlePointerEventL):
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::ConstructL): (CControlSelectWidget::PositionListBox): (CControlSelectWidget::HandlePointerEventL): (CControlSelectWidget::HandleListBoxEventL):
  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
1:11 PM Changeset in webkit [18811] by ggaren
  • 8 edits in trunk/JavaScriptCore

RS by Brady Eidson.


Rolling back in r18786 with leaks fixed, and these renames slightly reworked:

Because they can return 0:
rootObjectForImp => findRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => findRootObject (ditto)
findReferenceSet => findProtectCountSet

1:10 PM Changeset in webkit [18810] by ddkilzer
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Mitz.

No test possible (no change to functionality).

  • rendering/RenderObject.h: Removed unused forward declaration.
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Delete shadow data.
12:52 PM Changeset in webkit [18809] by spadma
  • 2 edits in S60/trunk/WebKit

2007-01-11 sareen sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: Can't change input mode in WAP CSS formatted fields.(TSW ID: TMCN-6S5HZR)
​http://bugs.webkit.org/show_bug.cgi?id=12188

  • BrowserCore/Formcontrols/src/FInputlFormattedEditor.cpp: (CInputFormattedEditor::UpdateEditingParameters):
12:24 PM Changeset in webkit [18808] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-12 sareen <​shyam.sareen@yahoo.com>

Reviewed by Yongjun.
DESC: Wrong rendering of danish national characters for UTF8 coded web pages.(TSW ID: TMCN-6UQNXY)
​http://bugs.webkit.org/show_bug.cgi?id=12217

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (validateUtf8):
12:20 PM Changeset in webkit [18807] by yongjzha
  • 13 edits in S60/trunk

2007-01-12 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
​http://bugs.webkit.org/show_bug.cgi?id=12225

  • BrowserView/inc/WebKitControl.h: (CWebKitControl::DefaultLocaleCharset):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::ConstructL):
12:06 PM Changeset in webkit [22761] by andersca
  • 11 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

WARNING: NO TEST CASES ADDED OR CHANGED

  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::didChangeTitle): Copied here from FrameLoaderMac.mm


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): Removed setting referrer and user-agend and added a check for null page.


(WebCore::ResourceHandle::cancel):
Don't call didFail.


  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::getAppletInstanceForWidget): Use LOG_NOIMPL here.

WebKitWin:

Reviewed by Darin.

Move WebKitWin over to the new WebCore loader. There are still some leftover functions
from FrameWinClient that aren't used and should be removed.


  • WebDataSource.cpp: (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource): (WebDataSource::createInstance): (WebDataSource::documentLoader): (WebDataSource::overrideEncoding): (WebDataSource::setOverrideEncoding): (WebDataSource::QueryInterface): (WebDataSource::initWithRequest): (WebDataSource::data): (WebDataSource::representation): (WebDataSource::webFrame): (WebDataSource::initialRequest): (WebDataSource::request): (WebDataSource::response): (WebDataSource::textEncodingName): (WebDataSource::isLoading): (WebDataSource::unreachableURL):
  • WebDataSource.h:
  • WebFrame.cpp: (WebFrame::WebFramePrivate::m_policyFunction): (WebFrame::WebFrame): (WebFrame::~WebFrame): (WebFrame::QueryInterface): (WebFrame::loadRequest): (WebFrame::loadData): (getWebDataSource): (WebFrame::dataSource): (WebFrame::provisionalDataSource): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::firstLayoutDone): (WebFrame::loadType): (WebFrame::stopMainResourceLoad): (WebFrame::canProvideDocumentSource): (WebFrame::createFrame): (WebFrame::submitForm): (WebFrame::setTitle): (WebFrame::originalRequestURL): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::finishedLoading): (WebFrame::canHandleRequest): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::shouldGoToHistoryItem): (WebFrame::createDocumentLoader): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::committedLoad): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchCreatePage): (WebFrame::dispatchDidCancelAuthenticationChallenge):
  • WebFrame.h:
  • WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebViewWndProc): (WebView::close): (WebView::frameLoadDelegate): (WebView::backForwardList): (WebView::setMaintainsBackForwardList): (WebView::goBack): (WebView::goForward): (WebView::goToBackForwardItem): (WebView::setCustomTextEncodingName): (WebView::customTextEncodingName): (WebView::canGoBack): (WebView::canGoForward): (WebView::frameLoadDelegatePrivate):
  • WebView.h:
11:59 AM Changeset in webkit [18806] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • WebCore.xcodeproj/project.pbxproj: Remove SubresourceLoaderMac.mm.
11:56 AM Changeset in webkit [18805] by andersca
  • 6 edits
    1 delete in trunk/WebCore

Reviewed by Darin and Anders.

Make some more of the loader code platform independent.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::referrer):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): (WebCore::SubresourceLoader::stopLoading):
  • loader/SubresourceLoader.h:
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm: Removed.
  • loader/qt/FrameLoaderQt.cpp:
10:53 AM Changeset in webkit [22760] by andersca
  • 9 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Geoff.

More loader preparations.


  • WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems): (WebContextMenuClient::contextMenuItemSelected): Use ::createInstance to create the element property bags.


  • WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::createInstance): (convertStringToVariant):
  • WebElementPropertyBag.h: Fix ownership issues so WebElementPropertyBag can one day be a value in another property bag.


  • WebFramePolicyListener.cpp: Added. (WebFramePolicyListener::WebFramePolicyListener): (WebFramePolicyListener::~WebFramePolicyListener): (WebFramePolicyListener::createInstance): (WebFramePolicyListener::QueryInterface): (WebFramePolicyListener::AddRef): (WebFramePolicyListener::Release): (WebFramePolicyListener::use): (WebFramePolicyListener::download): (WebFramePolicyListener::ignore): (WebFramePolicyListener::continueSubmit): (WebFramePolicyListener::receivedPolicyDecision): (WebFramePolicyListener::invalidate):
  • WebFramePolicyListener.h: Added. Add policy listener implementation.


  • WebFrame.cpp: (WebFrame::receivedPolicyDecision):
  • WebFrame.h: Add stub to be used by the policy listener.
  • WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::paint): (WebView::closeWindow): (WebView::handleMouseEvent): (WebViewWndProc): (WebView::initWithFrame): (WebView::setUIDelegate): (WebView::uiDelegate): (WebView::setFrameLoadDelegate): (WebView::frameLoadDelegate): (WebView::preferences): (WebView::elementAtPoint): (WebView::setFormDelegate): (WebView::formDelegate): (WebView::setFrameLoadDelegatePrivate): (WebView::frameLoadDelegatePrivate):
  • WebView.h: Cleanup, use COMPtr in a couple of places.
7:05 AM Changeset in webkit [18804] by lars
  • 7 edits in trunk/WebKitTools

Reviewed by Zack

Get DumpRenderTree to work again for the Qt build.

Make run-webkit-tests a little less verbose when testing
Qt, and add an option to run DumpRenderTree inside valgrind
(useful for debugging)

7:00 AM Changeset in webkit [18803] by lars
  • 2 edits in trunk/WebCore

Reviewed by Zack

Valgrind reported uninitialized variable.

  • platform/network/qt/ResourceHandleManagerQt.cpp: (WebCore::FileLoader::request):
4:40 AM Changeset in webkit [18802] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by rwlbuis.

  • add missing null check in new fixed table layout code
12:47 AM Changeset in webkit [18801] by zack
  • 2 edits in trunk/WebKitTools

Add WEBKIT_FULLBUILD to the qmake relevant build part to force
make clean before make as they fix stale dependencies (for buildbot mainly)

12:39 AM Changeset in webkit [18800] by lars
  • 3 edits in trunk/WebCore

Fix the Qt build after the Authentication changes.

12:11 AM Changeset in webkit [18799] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 9569. Make sure the selection offset for selection roots excludes border and padding.

Reviewed by Eric

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset):

Jan 11, 2007:

10:46 PM Changeset in webkit [18798] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 8705, readonly text fields should not get focus rings. Add a rule to that effect to
html4.css and then also add readonly as a special case for style sharing so that we can retain the
performance boost from sharing styles on inputs.

Reviewed by bdash

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::checkOneSelector):
  • css/html4.css:
10:28 PM Changeset in webkit [18797] by hyatt
  • 3 edits in trunk/LayoutTests/fast/overflow

Update overflow layout test results after autoscroll fix.

10:25 PM Changeset in webkit [18796] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 11595. Autoscrolling of layers didn't really work at all unless the layer was coincidentally
in the root layer's coordinate space. The event point was an absolute position within the document, but
the layer's rect was only local coords. This patch makes sure to use absolute bounds for the layer
when comparing it with the point.

This is covered by the scrollRevealButton test case already in the tree... the results change to be more
correct.

Reviewed by ggaren

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
10:25 PM Changeset in webkit [18795] by ggaren
  • 9 edits in trunk/JavaScriptCore

RS by Brady Eidson.


Rolling out r18786 because it caused leaks.

9:50 PM Changeset in webkit [22759] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <​sfalken@apple.com>

  • WebKit.vcproj/WebKit.make:
9:33 PM Changeset in webkit [18794] by beidson
  • 9 edits in trunk/WebCore

Reviewed by Oliver

-Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
-Make more of ResourceLoader cross-platform

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCancellation):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willCacheResponse):
  • loader/mac/ResourceLoaderMac.mm:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation): (WebCore::ResourceHandle::clearAuthentication): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):


8:48 PM Changeset in webkit [18793] by hyatt
  • 2 edits in trunk/WebCore

A hit test is returning a null renderer. Make sure to null-check it in the autoscroll code.
This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
on the front page of yahoo.com!

Reviewed by mark

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
8:37 PM Changeset in webkit [18792] by hyatt
  • 3 edits
    5 adds in trunk

LayoutTests:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark


  • fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
  • fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • fast/multicol/columns-shorthand-parsing-expected.txt: Added.
  • fast/multicol/columns-shorthand-parsing.html: Added.

WebCore:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark

fast/multicol/columns-shorthand-parsing.html

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
8:29 PM Changeset in webkit [18791] by bdash
  • 27 edits in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • rendering/RenderTable.cpp: (WebCore::resetSectionPointerIfNotBefore): Added this function to help with checking if a section being inserted is the going to be the first of its kind. (WebCore::RenderTable::addChild): Changed to maintain the pointers to the header, the footer, the caption and the first table body properly when objects are inserted in the middle. Also changed to make the first caption win over any other captions. This matches Firefox and what already used to happen when a section recalc took place. (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating over the sections from top to bottom. (WebCore::RenderTable::calcBorderLeft): Changed to really find the section containing the first row. (WebCore::RenderTable::calcBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was skipped if the input was the footer. (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header" respectively.

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Collapsed borders changed in the "marvin" tests, as the footer cells now
collapse correctly with the last row of the body. Visual differences not
captured by the pixel results since they occurred below 600px.

The "other" test has changed since in a table with multiple captions,
now the first one wins. No visual difference in this case since both captions
are the same.

  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/backgr_position-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/other/test4-expected.txt:
8:28 PM Changeset in webkit [18790] by bdash
  • 13 edits in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Fixed fixed table layout. Implemented an algorithm that matches the behavior
of Firefox, up to rounding errors.

Fixes three existing table tests.

  • rendering/FixedTableLayout.cpp: Undid accidental search-and-replace of "width" to "m_width" in the comments. Removed an outdated comment, since WebKit no longer honors table-layout:fixed for variable-width tables. (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the first row. Changed to divide the width specified for a cell that spans multiple columns between the columns rather than assign its entire width to each column. (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): Implemented the behavior observed in Firefox.
  • rendering/FixedTableLayout.h:

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • tables/mozilla/bugs/bug157890-expected.checksum:
  • tables/mozilla/bugs/bug157890-expected.png:
  • tables/mozilla/bugs/bug157890-expected.txt:
  • tables/mozilla/bugs/bug44505-expected.checksum:
  • tables/mozilla/bugs/bug44505-expected.png:
  • tables/mozilla/bugs/bug44505-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
8:25 PM Changeset in webkit [18789] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Changed the ImageDiff tool not to use CoreImage filters.

  • DumpRenderTree/ImageDiff.m: (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap):
8:24 PM Changeset in webkit [18788] by bdash
  • 6 edits
    4 adds in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/block/basic/fieldset-stretch-to-legend.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic width if the object requires it. (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup. (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum intrinsic width if the object requires it.
  • rendering/RenderBox.h: (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's implementation to ensure that the legend's will fit in the fieldset's minimum intrinsic width. (WebCore::RenderFieldset::findLegend): Made const. (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when the legend does overflow the fieldset. This is the part of the fix that prevents the assertion failure. If the legend intersects with a corner of the fieldset's border, that corner will not be painted, even if it is not completely occluded. This edge case can be improved with clipping in the future. Added FIXME to implement border-radius.
  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to return true.

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • fast/block/basic/fieldset-stretch-to-legend-expected.checksum: Added.
  • fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • fast/block/basic/fieldset-stretch-to-legend-expected.txt: Added.
  • fast/block/basic/fieldset-stretch-to-legend.html: Added.
6:53 PM Changeset in webkit [22758] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::cfURLResponse): Add getter that I forgot to commit.
5:14 PM Changeset in webkit [22757] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:05 PM Changeset in webkit [18787] by sfalken
  • 1 copy in tags/Safari-521.32.11b

New tag.

4:46 PM Changeset in webkit [18786] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

ReferencesSet | ProtectCounts => ProtectCountSet (because it's a typename for a set of GC protect counts)
ReferencesByRootMap => RootObjectMap (because RootObjectToProtectCountSetMap would have been confusing)
pv => protectedValues
rootObjectForImp => getRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => getRootObject (ditto)
findReferenceSet => getProtectCountSet
imp => jsObject


(KJS::Bindings::getRootObjectMap): Changed to take advantage of built-in
facility for initializing static variables.

(KJS::Bindings::getProtectCountSet):
(KJS::Bindings::destroyProtectCountSet): Added. Helps encapsulate the fact
that getting a ProtectCountSet entails adding a RootObject to a hash table,
and destroying one entails the reverse.

(KJS::Bindings::getRootObject): Removed spurious NULL check.


(KJS::Bindings::findReferenceSet): Renamed. Changed to use getRootObject()
instead of iterating on its own.

(KJS::Bindings::addNativeReference): Changed to use an early return instead
of indenting the whole function.
(KJS::Bindings::removeNativeReference): Ditto.

3:35 PM Changeset in webkit [22756] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

Implement "Make Text Normal Size".

  • WebView.cpp: (WebView::canMakeTextStandardSize): Added (WebView::makeTextStandardSize): Added (WebView::toggleContinuousSpellChecking): Added (WebView::toggleSmartInsertDelete): Added
3:14 PM Changeset in webkit [18785] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Build Fix Karma

I broke the release build (debug build passed)

  • platform/network/mac/AuthenticationMac.mm: (WebCore::core):
3:04 PM Changeset in webkit [22755] by beidson
  • 5 edits in branches/WindowsMerge

Make it build again after my HTTP Auth opensource checkin

2:35 PM Changeset in webkit [18784] by beidson
  • 1 edit in trunk/WebCore/platform/network/mac/AuthenticationMac.mm

Blind build fix attempt

2:20 PM Changeset in webkit [18783] by beidson
  • 23 edits
    8 adds in trunk

WebCore:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::didCancel):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation): (WebCore::ResourceHandleClient::willCacheResponse):
  • platform/network/ResourceResponse.h: (WebCore::operator!=):
  • platform/network/URLAuthenticationChallenge.cpp: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::URLAuthenticationChallenge::previousFailureCount): (WebCore::URLAuthenticationChallenge::proposedCredential): (WebCore::URLAuthenticationChallenge::protectionSpace): (WebCore::URLAuthenticationChallenge::failureResponse): (WebCore::URLAuthenticationChallenge::error): (WebCore::URLAuthenticationChallenge::isNull): (WebCore::URLAuthenticationChallenge::nullify): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/URLAuthenticationChallenge.h: Added. (WebCore::URLAuthenticationChallenge::sender): (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/URLCredential.cpp: Added. (WebCore::URLCredential::URLCredential): (WebCore::URLCredential::user): (WebCore::URLCredential::password): (WebCore::URLCredential::hasPassword): (WebCore::URLCredential::persistence): (WebCore::operator==):
  • platform/network/URLCredential.h: Added. (WebCore::): (WebCore::operator!=):
  • platform/network/URLProtectionSpace.cpp: Added. (WebCore::URLProtectionSpace::URLProtectionSpace): (WebCore::URLProtectionSpace::host): (WebCore::URLProtectionSpace::port): (WebCore::URLProtectionSpace::serverType): (WebCore::URLProtectionSpace::realm): (WebCore::URLProtectionSpace::authenticationScheme): (WebCore::operator==):
  • platform/network/URLProtectionSpace.h: Added. (WebCore::): (WebCore::operator!=):
  • platform/network/mac/AuthenticationMac.h: Added.
  • platform/network/mac/AuthenticationMac.mm: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::mac): (WebCore::core):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::operator==):

WebKit:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
  • WebKit.xcodeproj/project.pbxproj:

WebKitQt:

Keep the fancy new FrameLoaderClientQt building with a small api change in WebCore
Yay for the loader on QT!

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientQt::dispatchDidCancelAuthenticationChallenge):
  • WebCoreSupport/FrameLoaderClientQt.h:
2:02 PM Changeset in webkit [18782] by ggaren
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction


Also removed unnecessary use of "Bindings::" prefix.

  • JavaScriptCore.exp:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::setCreateRootObject):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::createRootObject):

WebCore:

Reviewed by Anders Carlsson.


Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
rootForView => createRootObject
getInstanceForView => getPluginInstanceForWidget

  • page/mac/FrameMac.mm: (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void* variable named "nativeHandle" to be more explicit about the fact that JavaScript's "nativeHandle" is just an NSView *.

(WebCore::getPluginInstanceForWidget): This function now does the NSView *
fetching that its callers used to do.
(WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
(WebCore::FrameMac::getObjectInstanceForWidget): ditto

  • page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category, which was really more of a shmategory. (createRootObject): Removed rootObjectForView, folding it into its only caller, the similarly named rootForView. Renamed the pair to "createRootObject" because that's what they do.

(-[WebCoreFrameBridge init]): Updated for renames

1:52 PM Changeset in webkit [18781] by andersca
  • 1 edit in trunk/WebCore/loader/DocLoader.cpp

Get rid of garbage

1:47 PM Changeset in webkit [18780] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix crash on platforms that don't use the new loader yet.


  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
1:45 PM Changeset in webkit [18779] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam.

  • fast/forms/select-type-ahead-non-latin-expected.txt: Added.
  • fast/forms/select-type-ahead-non-latin.html: Added.

WebCore:

Reviewed by Adam.

Test: fast/forms/select-type-ahead-non-latin.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific isprint() condition to a Unicode isPrintableChar().
1:41 PM Changeset in webkit [18778] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by geoff


<rdar://problem/4889140>
GMail Editor: List creation fails in new message

  • editing/execCommand/insert-list-empty-div-expected.checksum: Added.
  • editing/execCommand/insert-list-empty-div-expected.png: Added.
  • editing/execCommand/insert-list-empty-div-expected.txt: Added.
  • editing/execCommand/insert-list-empty-div.html: Added.

WebCore:

Reviewed by geoff


<rdar://problem/4889140>
GMail Editor: List creation fails in new message

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Inserting the list into an empty paragraph not held open by a br or a '\n', will invalidate start and end. Insert a placeholder and then recompute start and end.
1:15 PM Changeset in webkit [18777] by lars
  • 2 edits
    1 delete in trunk/WebCore

This one is not needed any longer neither.

1:04 PM Changeset in webkit [18776] by lars
  • 2 edits in trunk/WebKitTools

fix compilation of DumpRenderTree. Will hopefully
make the built bot happy :)

12:45 PM Changeset in webkit [18775] by lars
  • 2 edits
    1 delete in trunk/WebCore

remove now unused file.

12:33 PM Changeset in webkit [18774] by ddkilzer
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

  • loader/mac/FrameLoaderMac.mm: Removed import of LoaderNSURLRequestExtras.h.
  • loader/mac/SubresourceLoaderMac.mm: Ditto.
12:03 PM Changeset in webkit [18773] by staikos
  • 2 edits in trunk/WebCore

Fix compile

12:00 PM Changeset in webkit [22754] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::advanceToNextMisspelling):
11:53 AM Changeset in webkit [18772] by andersca
  • 8 edits in trunk/WebCore

Fix build.


  • dom/XMLTokenizer.cpp:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedImage.cpp:
  • loader/DocLoader.cpp:
  • loader/loader.cpp:
  • xml/XSLTProcessor.cpp:
  • xml/xmlhttprequest.cpp:
11:30 AM Changeset in webkit [18771] by andersca
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Adam.

Loader cleanup, get rid of unused code.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedResource.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/DocLoader.h:
  • loader/LoaderFunctions.h: Removed.
  • loader/mac/CachedResourceMac.mm: Removed.
  • loader/mac/LoaderFunctionsMac.mm: Removed.
  • loader/mac/LoaderNSURLRequestExtras.h: Removed.
  • loader/mac/LoaderNSURLRequestExtras.m: Removed.
  • loader/mac/SubresourceLoaderMac.mm:
  • page/mac/WebCoreFrameBridge.mm:
  • platform/network/ResourceHandle.cpp:
10:25 AM Changeset in webkit [18770] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Better Changelog.

10:19 AM Changeset in webkit [18769] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION:
<input> and <textarea> not focused on right click (4908884 in
Radar)

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Ask if we *have* swallowed the event instead of if we *haven't* when deciding to perform a selection.
8:42 AM Changeset in webkit [18768] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Added null check.
8:39 AM Changeset in webkit [18767] by darin
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

  • WebView/WebDataSource.mm: (-[WebDataSource data]): Added null check.
6:55 AM Changeset in webkit [18766] by darin
  • 2 edits in trunk/WebCore
  • platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
4:34 AM Changeset in webkit [18765] by lars
  • 10 edits in trunk

Start using the loader in the Qt port.

4:23 AM Changeset in webkit [18764] by darin
  • 22 edits
    6 deletes in trunk

WebCore:

Reviewed by Hyatt.

  • removed a couple Mac bridging classes; put the code in WebKit instead
  • WebCore.exp: Updated for new WebKit uses.
  • WebCore.xcodeproj/project.pbxproj: Removed files.
  • bridge/mac/WebCoreEncodings.h: Removed.
  • bridge/mac/WebCoreEncodings.mm: Removed.
  • bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
  • bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
  • platform/mac/WebNSAttributedStringExtras.h: Removed.
  • platform/mac/WebNSAttributedStringExtras.mm: Removed.
  • platform/mac/PasteboardMac.mm: (WebCore::stripAttachmentCharacters): Added. Moved code from WebNSAttributedStringExtras.mm, and fixed a garbage collection problem (a global with a plain old retain rather than HardRetain). (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
  • removed some DeprecatedCString use
  • loader/FrameLoader.cpp: Changed to use String more to eliminate use of DeprecatedCString here in the mailto form support. But maybe we can remove this entirely. Do we really care about mailto forms any more?
  • platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
  • platform/PlatformString.h: Added replace that takes two strings.
  • platform/StringImpl.h: Ditto.
  • platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
  • platform/TextStream.h: Remove DeprecatedCString case.
  • platform/TextStream.cpp: Ditto.
  • made a few more files use CharacterNames.h
  • platform/CharacterNames.h: Added some more character names and sorted alphabetically.
  • bridge/mac/WebCoreStringTruncator.mm: (centerTruncateToBuffer): Use character name from CharacterNames.h. (rightTruncateToBuffer): Ditto. (truncateString): Ditto.
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.

WebKit:

Reviewed by Hyatt.

  • moved code from a couple WebCore bridging classes here instead
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge.
  • WebView/WebHTMLRepresentation.mm: (stringArray): Added. Helper to convert a HashSet to an NSArray. (concatenateArrays): Added. Helper to concatenate two NSArray objects. (+[WebHTMLRepresentation supportedMIMETypes]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. Also fix a potential GC problem by using a RetainPtr instead of a [retain] on a global variable. (+[WebHTMLRepresentation supportedNonImageMIMETypes]): Ditto. (+[WebHTMLRepresentation supportedImageMIMETypes]): Ditto.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. (-[WebHTMLView _documentFragmentWithPaths:]): Ditto.
  • WebView/WebView.mm: (+[WebView _decodeData:]): Moved code here from the old WebCoreEncodings class.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with this file. Moved WebRenderNode into the appropriate group.
4:22 AM Changeset in webkit [18763] by hyatt
  • 2 edits in trunk/LayoutTests/fast/overflow

Land reverted layout tests for the two overflow cases. Although the new results were better, there are issues with what I did to achieve them, so for now going back to the (broken) old results.

4:21 AM Changeset in webkit [18762] by hyatt
  • 3 edits in trunk/WebCore

Fix two bugs in positionForCoordinates. (Make it work when you have a margin in between your border and
your first child block.)

Rewrite column rebalancing to have two modes: constrained and unconstrained. In unconstrained mode,
the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
for the overall block. In constrained mode, columns flow into the fixed height block, and extra columns
spill out horizontally in the appropriate direction (RTL/LTR).

Make columns work properly with both LTR and RTL overflow blocks.

Initial column test suite coming soon now that the basic layout is right.

Reviewed by darin

  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::hasColumns):
3:13 AM Changeset in webkit [18761] by hyatt
  • 4 edits in trunk/LayoutTests/svg/custom

Fix SVG test cases.

12:51 AM Changeset in webkit [18760] by rwlbuis
  • 14 edits in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12201
Fix image dragging issues with ​http://www.carto.net/papers/svg/gui/scrollbar/index.svg

Fix calculation of absolute transform so that viewport x,y
translation is always done, also when viewBox is set.

Note: See TracTimeline for information about the timeline view.