⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 13, 2007:

11:53 PM Changeset in webkit [18837] by bdash
  • 9 edits in trunk

2007-01-14 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Minor fixes to JavaScript pretty-printing.

  • JavaScriptCore.exp:
  • kjs/Parser.cpp: (KJS::Parser::prettyPrint): Return line number and error message if parsing fails.
  • kjs/Parser.h:
  • kjs/nodes2string.cpp: (ElementNode::streamTo): Include comma delimiters in array literals. (PropertyNameNode::streamTo): Quote property names in object literals to handle the case when the property name is not a valid identifier.
  • kjs/testkjs.cpp: (doIt): Print any errors encountered while pretty-printing.

2007-01-14 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Layout tests for fixes to JavaScript pretty-printing.

  • fast/js/pretty-print-expected.txt:
  • fast/js/resources/pretty-print.js: Test handling of object literal with non-identifier property name, and of array literals.
1:07 PM Changeset in webkit [18836] by hyatt
  • 2 edits in trunk/WebCore

While optimizing form controls and fixing their clipping, I caused this text zoom regression. The layout
of text is necessary because it needs to recalc minmaxwidth. This is still a really unfortunate
bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
as dirty when we don't have to.

Reviewed by mitz

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
12:01 PM Changeset in webkit [18835] by lars
  • 2 edits in trunk/WebCore

Reviewed by Alexey

String::format() was relying on undefined behaviour, which
happened to work on lots of systems (Mac and 32bit Linux at least)
but broke badly on 64bit Linux.

10:48 AM Changeset in webkit [18834] by lars
  • 2 edits in trunk/WebCore

Fix for bug 11924: WebCore would crash on any HTML content
with a non-empty <table> tag in it on a 64-bit machine. The
size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
and the clients of this function have been updated to check
for a false return code.

Reviewed by Darin

8:33 AM Changeset in webkit [18833] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12165
REGRESSION: text encoding problem at jn.sapo.pt

Test: fast/encoding/script-in-head.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Ignore tags within <script> elements in head, just like we do for <title>.
3:21 AM Changeset in webkit [18832] by lars
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Don't crash when constructing a GraphicsContext with a 0
PlatformGraphicsContext and don't do anything if painting
is disabled.

3:02 AM Changeset in webkit [18831] by lars
  • 3 edits in trunk/WebKitQt

Make the Qt port compile again.

1:49 AM Changeset in webkit [18830] by eseidel
  • 7 edits
    4 adds in trunk

2007-01-13 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

RichDraw demo does not live-update in Safari
(SVG elements should ignore CSS position)
​http://bugs.webkit.org/show_bug.cgi?id=10364

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): move path generation into layout()
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
12:16 AM Changeset in webkit [18829] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderBlock.cpp

Fix leak of column vector.

Jan 12, 2007:

11:11 PM Changeset in webkit [18828] by hyatt
  • 4 adds in trunk/LayoutTests/fast/multicol

Add layout test for column rules.

11:08 PM Changeset in webkit [18827] by hyatt
  • 3 edits in trunk/WebCore

Add support for column rules.

Reviewed by bdash

fast/multicol/column-rules.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::columnRuleIsTransparent):
9:32 PM Changeset in webkit [18826] by hyatt
  • 3 edits in trunk/WebCore

Make multicolumn layout work with floats.

Reviewed by andersca

Added fast/multicol/float-multicol.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject):
  • rendering/RenderBlock.h:
9:31 PM Changeset in webkit [18825] by hyatt
  • 6 adds in trunk/LayoutTests/fast/multicol

New fancy float multicol test (thanks Mozilla!)

8:22 PM Changeset in webkit [18824] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for fast/css/line-height.html REGRESSION (r18816-r18818): Assertion failure in WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
  • fast/css/line-height-expected.checksum: Added.
  • fast/css/line-height-expected.png: Added.
  • fast/css/line-height-expected.txt: Added.
  • fast/css/line-height.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/css/line-height.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
6:15 PM Changeset in webkit [22763] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Build fixes.


  • WebFrame.cpp: (WebFrame::assignIdentifierToInitialRequest): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): (WebFrame::incrementProgress): (WebFrame::completeProgress): (WebFrame::dispatchDidReceiveAuthenticationChallenge): (WebFrame::dispatchDidCancelAuthenticationChallenge):
  • WebFrame.h:
5:47 PM Changeset in webkit [18823] by andersca
  • 1 edit in trunk/JavaScriptCore/wtf/HashTraits.h

Forgot to save.

5:44 PM Changeset in webkit [18822] by andersca
  • 16 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • wtf/HashTraits.h: Add hash traits for unsigned long and unsigned long long.

WebCore:

Reviewed by Darin.

Use unsigned long for identifiers instead of Objective-C objects.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::assignIdentifierToInitialRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::setIdentifier): (WebCore::ResourceLoader::identifier):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::createUniqueIdentifier):
  • page/Page.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress):

WebKit:

Reviewed by Darin.

Add a HashMap between unsigned longs and Objective-C objects and use it for
the resource load delegate.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress):
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _addObject:forIdentifier:]): (-[WebView _objectForIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
  • WebView/WebViewInternal.h:
5:19 PM Changeset in webkit [18821] by bdash
  • 2 edits in trunk/WebCore

2007-01-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value of 'overflow-x' and 'overflow-y'.
4:45 PM Changeset in webkit [22762] by adachan
  • 6 edits
    1 add in branches/WindowsMerge/WebKitWin

2007-01-12 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

WebKitWin:

  • Added IWebBackForwardListPrivate which contains the removeItem method, used in undo/redo of closing tabs.
  • Fixed a null dereference I ran into in WebFrame::dispatchDidFirstLayout.
  • Interfaces/IWebBackForwardListPrivate.idl: Added.
  • WebBackForwardList.cpp: (WebBackForwardList::QueryInterface): (WebBackForwardList::removeItem):
  • WebBackForwardList.h:
  • WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
3:07 PM Changeset in webkit [18820] by justing
  • 17 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt

<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work

Added to test changes:

  • editing/style/fontsize-1-expected.checksum: Added.
  • editing/style/fontsize-1-expected.png: Added.
  • editing/style/fontsize-1-expected.txt: Added.
  • editing/style/fontsize-1.html: Added.

Removed use of "px" and "pt" values passed to
execCommand("FontSize", ...) (other browsers don't
support them):

  • editing/input/attributed-substring-from-range-lines.html-disabled:
  • editing/style/block-style-004-expected.checksum:
  • editing/style/block-style-004-expected.png:
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-004.html:
  • editing/style/block-style-005-expected.checksum:
  • editing/style/block-style-005-expected.png:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-005.html:
  • editing/style/block-style-006-expected.checksum:
  • editing/style/block-style-006-expected.png:
  • editing/style/block-style-006-expected.txt:
  • editing/style/block-style-006.html:

WebCore:

Reviewed by hyatt


<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work

Changed execCommand("FontSize", ...) to match the spec
and the behavior of other browsers. It expects a number,
n, which, the spec says can be 1 through 7. Other browsers
perform the font size change by creating a font element
wrapper with size="n". We convert n into one of the absolute
size CSS keywords (x-small, medium, etc.).

  • editing/JSEditor.cpp: Call cssValueFromFontSizeNumber. If successful, perform the style change.
  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::cssValueFromFontSizeNumber): Added. Moved this code from parsedMappedAttribute so that it could be called from the Editor. (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into cssValueFromFontSizeNumber.
  • html/HTMLFontElement.h:
2:53 PM Changeset in webkit [18819] by hyatt
  • 18 edits in trunk/WebCore

Fix for bug 11598, implement lightweight control clipping mechanism for
buttons, list boxes, and dropdown lists. Make sure list box respects
scrollLeft/Top/Width/Height as well as clientWidth/Height.

Fix bugs in RenderStyle::diff. CursorData was not being compared properly.
vertical-align had a non-inline display check that was wrong (preventing
dynamic changes to keyword-based vertical-align from working).

Reviewed by mitz

  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::layoutColumns):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::setStyle): (WebCore::RenderButton::controlClipRect):
  • rendering/RenderButton.h: (WebCore::RenderButton::hasControlClip):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::itemHeight): (WebCore::RenderListBox::verticalScrollbarWidth): (WebCore::RenderListBox::scrollWidth): (WebCore::RenderListBox::scrollHeight): (WebCore::RenderListBox::scrollLeft): (WebCore::RenderListBox::setScrollLeft): (WebCore::RenderListBox::scrollTop): (WebCore::RenderListBox::setScrollTop): (WebCore::RenderListBox::controlClipRect):
  • rendering/RenderListBox.h: (WebCore::RenderListBox::hasControlClip):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::controlClipRect):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasControlClip):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::verticalScrollbarWidth): (WebCore::RenderObject::horizontalScrollbarHeight): (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasControlClip): (WebCore::RenderObject::controlClipRect): (WebCore::RenderObject::contentWidth): (WebCore::RenderObject::contentHeight):
  • rendering/RenderStyle.cpp: (WebCore::StyleVisualData::StyleVisualData): (WebCore::cursorDataEqvuialent): (WebCore::StyleInheritedData::operator==): (WebCore::CursorList::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::LengthBox::operator!=): (WebCore::StyleVisualData::operator==): (WebCore::CursorData::operator==): (WebCore::CursorData::operator!=): (WebCore::CursorList::operator!=): (WebCore::RenderStyle::setTableLayout):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2:46 PM Changeset in webkit [18818] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderTextControl.cpp

Ooops left off paren.

2:43 PM Changeset in webkit [18817] by yongjzha
  • 13 edits in S60/branches/3.1m

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18804)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,24 @@
+2007-01-12 w3liu <​wei.liu@nokia.com>
+
+ Reviewed by ​yongjun.zhang@nokia.com.
+ DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
+ ​http://bugzilla.opendarwin.org/show_bug.cgi?id=12225
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * BWINS/WEBCOREU.DEF:
+ * EABI/WebCoreU.DEF:
+ * bridge/WebCoreBridge.cpp:
+ (CWebCoreBridge::CreateDocumentWithEncoding):
+ * bridge/WebCoreBridge.h:
+ * khtml/khtml_part.cpp:
+ (KHTMLPart::write):
+ (KHTMLPart::setEncoding):
+ * khtml/khtmlpart_p.h:
+ * kwq/KWQKHTMLPart.cpp:
+ (KWQKHTMLPart::setEncoding):
+ * kwq/KWQKHTMLPart.h:
+

2:35 PM Changeset in webkit [18816] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 9934, smaller line heights should not be allowed on
text fields.

Reviewed by darin

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle):
2:26 PM Changeset in webkit [18815] by ddkilzer
  • 6 edits in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • fast/css/remove-shorthand-expected.txt:
  • fast/css/remove-shorthand.html:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/css/remove-shorthand.html (updated)

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::initShorthandMap):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
1:49 PM Changeset in webkit [18814] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Mitz.

Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.

1:46 PM Changeset in webkit [18813] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by andersca.

Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the loader plumbing was moved to WebCore. Pinging the plug-in database to ask it if it supports a given mime type has the side effect of reading from disk on first call, therefore such a check should be a last resort.
1:23 PM Changeset in webkit [18812] by spadma
  • 10 edits in S60/trunk/WebKit

2007-01-12 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Autoform fill and key event handling
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlInputSkin.h:
  • BrowserCore/Formcontrols/inc/FControlInputWidget.h:
  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h: (CControlSelectWidget::GetSelectWidgetRect):
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::HandlePointerEventL): (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::HandlePointerEventL):
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::ConstructL): (CControlSelectWidget::PositionListBox): (CControlSelectWidget::HandlePointerEventL): (CControlSelectWidget::HandleListBoxEventL):
  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
1:11 PM Changeset in webkit [18811] by ggaren
  • 8 edits in trunk/JavaScriptCore

RS by Brady Eidson.


Rolling back in r18786 with leaks fixed, and these renames slightly reworked:

Because they can return 0:
rootObjectForImp => findRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => findRootObject (ditto)
findReferenceSet => findProtectCountSet

1:10 PM Changeset in webkit [18810] by ddkilzer
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Mitz.

No test possible (no change to functionality).

  • rendering/RenderObject.h: Removed unused forward declaration.
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Delete shadow data.
12:52 PM Changeset in webkit [18809] by spadma
  • 2 edits in S60/trunk/WebKit

2007-01-11 sareen sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: Can't change input mode in WAP CSS formatted fields.(TSW ID: TMCN-6S5HZR)
​http://bugs.webkit.org/show_bug.cgi?id=12188

  • BrowserCore/Formcontrols/src/FInputlFormattedEditor.cpp: (CInputFormattedEditor::UpdateEditingParameters):
12:24 PM Changeset in webkit [18808] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-12 sareen <​shyam.sareen@yahoo.com>

Reviewed by Yongjun.
DESC: Wrong rendering of danish national characters for UTF8 coded web pages.(TSW ID: TMCN-6UQNXY)
​http://bugs.webkit.org/show_bug.cgi?id=12217

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (validateUtf8):
12:20 PM Changeset in webkit [18807] by yongjzha
  • 13 edits in S60/trunk

2007-01-12 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
​http://bugs.webkit.org/show_bug.cgi?id=12225

  • BrowserView/inc/WebKitControl.h: (CWebKitControl::DefaultLocaleCharset):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::ConstructL):
12:06 PM Changeset in webkit [22761] by andersca
  • 11 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

WARNING: NO TEST CASES ADDED OR CHANGED

  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::didChangeTitle): Copied here from FrameLoaderMac.mm


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): Removed setting referrer and user-agend and added a check for null page.


(WebCore::ResourceHandle::cancel):
Don't call didFail.


  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::getAppletInstanceForWidget): Use LOG_NOIMPL here.

WebKitWin:

Reviewed by Darin.

Move WebKitWin over to the new WebCore loader. There are still some leftover functions
from FrameWinClient that aren't used and should be removed.


  • WebDataSource.cpp: (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource): (WebDataSource::createInstance): (WebDataSource::documentLoader): (WebDataSource::overrideEncoding): (WebDataSource::setOverrideEncoding): (WebDataSource::QueryInterface): (WebDataSource::initWithRequest): (WebDataSource::data): (WebDataSource::representation): (WebDataSource::webFrame): (WebDataSource::initialRequest): (WebDataSource::request): (WebDataSource::response): (WebDataSource::textEncodingName): (WebDataSource::isLoading): (WebDataSource::unreachableURL):
  • WebDataSource.h:
  • WebFrame.cpp: (WebFrame::WebFramePrivate::m_policyFunction): (WebFrame::WebFrame): (WebFrame::~WebFrame): (WebFrame::QueryInterface): (WebFrame::loadRequest): (WebFrame::loadData): (getWebDataSource): (WebFrame::dataSource): (WebFrame::provisionalDataSource): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::firstLayoutDone): (WebFrame::loadType): (WebFrame::stopMainResourceLoad): (WebFrame::canProvideDocumentSource): (WebFrame::createFrame): (WebFrame::submitForm): (WebFrame::setTitle): (WebFrame::originalRequestURL): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::finishedLoading): (WebFrame::canHandleRequest): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::shouldGoToHistoryItem): (WebFrame::createDocumentLoader): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::committedLoad): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchCreatePage): (WebFrame::dispatchDidCancelAuthenticationChallenge):
  • WebFrame.h:
  • WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebViewWndProc): (WebView::close): (WebView::frameLoadDelegate): (WebView::backForwardList): (WebView::setMaintainsBackForwardList): (WebView::goBack): (WebView::goForward): (WebView::goToBackForwardItem): (WebView::setCustomTextEncodingName): (WebView::customTextEncodingName): (WebView::canGoBack): (WebView::canGoForward): (WebView::frameLoadDelegatePrivate):
  • WebView.h:
11:59 AM Changeset in webkit [18806] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • WebCore.xcodeproj/project.pbxproj: Remove SubresourceLoaderMac.mm.
11:56 AM Changeset in webkit [18805] by andersca
  • 6 edits
    1 delete in trunk/WebCore

Reviewed by Darin and Anders.

Make some more of the loader code platform independent.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::referrer):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): (WebCore::SubresourceLoader::stopLoading):
  • loader/SubresourceLoader.h:
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm: Removed.
  • loader/qt/FrameLoaderQt.cpp:
10:53 AM Changeset in webkit [22760] by andersca
  • 9 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Geoff.

More loader preparations.


  • WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems): (WebContextMenuClient::contextMenuItemSelected): Use ::createInstance to create the element property bags.


  • WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::createInstance): (convertStringToVariant):
  • WebElementPropertyBag.h: Fix ownership issues so WebElementPropertyBag can one day be a value in another property bag.


  • WebFramePolicyListener.cpp: Added. (WebFramePolicyListener::WebFramePolicyListener): (WebFramePolicyListener::~WebFramePolicyListener): (WebFramePolicyListener::createInstance): (WebFramePolicyListener::QueryInterface): (WebFramePolicyListener::AddRef): (WebFramePolicyListener::Release): (WebFramePolicyListener::use): (WebFramePolicyListener::download): (WebFramePolicyListener::ignore): (WebFramePolicyListener::continueSubmit): (WebFramePolicyListener::receivedPolicyDecision): (WebFramePolicyListener::invalidate):
  • WebFramePolicyListener.h: Added. Add policy listener implementation.


  • WebFrame.cpp: (WebFrame::receivedPolicyDecision):
  • WebFrame.h: Add stub to be used by the policy listener.
  • WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::paint): (WebView::closeWindow): (WebView::handleMouseEvent): (WebViewWndProc): (WebView::initWithFrame): (WebView::setUIDelegate): (WebView::uiDelegate): (WebView::setFrameLoadDelegate): (WebView::frameLoadDelegate): (WebView::preferences): (WebView::elementAtPoint): (WebView::setFormDelegate): (WebView::formDelegate): (WebView::setFrameLoadDelegatePrivate): (WebView::frameLoadDelegatePrivate):
  • WebView.h: Cleanup, use COMPtr in a couple of places.
7:05 AM Changeset in webkit [18804] by lars
  • 7 edits in trunk/WebKitTools

Reviewed by Zack

Get DumpRenderTree to work again for the Qt build.

Make run-webkit-tests a little less verbose when testing
Qt, and add an option to run DumpRenderTree inside valgrind
(useful for debugging)

7:00 AM Changeset in webkit [18803] by lars
  • 2 edits in trunk/WebCore

Reviewed by Zack

Valgrind reported uninitialized variable.

  • platform/network/qt/ResourceHandleManagerQt.cpp: (WebCore::FileLoader::request):
4:40 AM Changeset in webkit [18802] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by rwlbuis.

  • add missing null check in new fixed table layout code
12:47 AM Changeset in webkit [18801] by zack
  • 2 edits in trunk/WebKitTools

Add WEBKIT_FULLBUILD to the qmake relevant build part to force
make clean before make as they fix stale dependencies (for buildbot mainly)

12:39 AM Changeset in webkit [18800] by lars
  • 3 edits in trunk/WebCore

Fix the Qt build after the Authentication changes.

12:11 AM Changeset in webkit [18799] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 9569. Make sure the selection offset for selection roots excludes border and padding.

Reviewed by Eric

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset):
Note: See TracTimeline for information about the timeline view.