⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 15, 2007:

11:50 PM Changeset in webkit [18882] by rwlbuis
  • 12 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12272
SVG picture is clipped (edges not visible)

Expose css dpi constant and use it for svg, making
1in amount to 96 pixels like for html.

11:23 PM Changeset in webkit [18881] by beidson
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej

  • coding/coding-style.html: Added switch/case indentation rules
10:50 PM Changeset in webkit [22773] by beidson
  • 3 edits
    3 adds in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam

Hook up AuthenticationChallenge to CF network.
Call up through appropriate client methods through to WebFrame (FrameLoaderClient) at
which point my upcoming implementation for the IWebURL<auth> classes will be used

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/AuthenticationCF.cpp: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::createCF): (WebCore::core):
  • platform/network/cf/AuthenticationCF.h: Added.
  • platform/network/cf/ResourceErrorCF.cpp: Added. (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::operator CFStreamError):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveChallenge): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):
10:39 PM Changeset in webkit [18880] by beidson
  • 6 edits in trunk/WebCore

WebCore:

Reviewed by Adam


CFNet additions

  • platform/network/AuthenticationChallenge.cpp: (WebCore::operator==):
  • platform/network/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::sourceHandle): (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
  • platform/network/ResourceError.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
9:25 PM Changeset in webkit [18879] by eseidel
  • 3 edits
    4 adds in trunk

2007-01-15 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

Don't map attributes in namespaces other than null to CSS properties.


Test: svg/custom/attribute-namespace-check.svg

  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
8:46 PM Changeset in webkit [18878] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • Resources/linkCursor.png: Added a drop shadow.
8:43 PM Changeset in webkit [18877] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

  • fast/forms/placeholder-set-attribute-expected.checksum: Added.
  • fast/forms/placeholder-set-attribute-expected.png: Added.
  • fast/forms/placeholder-set-attribute-expected.txt: Added.
  • fast/forms/placeholder-set-attribute.html: Added.

WebCore:

Reviewed by Adam.

Test: fast/forms/placeholder-set-attribute.html

  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): Call onSearch on the element since I removed it from the renderer.
  • rendering/RenderTextControl.h: Added explicit virtual keywords for overrides of virtual functions. Removed the unneeded onSearch function. Made the inheritance from PopupMenuClient be private, and made the overrides all private. Replaced the showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion. (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded. (WebCore::RenderTextControl::updateFromElement): Added call to updatePlaceholder before updating the value. Also improved the structure of the function and corrected incorrect use of copy and replace. (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an assertion and removed an unneeded local variable. (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded null check and virtual function calls. (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old functions with calls to updatePlaceholder. (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch the select event directly -- I plan to remove the onSelect function, which was only called here. (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and local variable. (WebCore::RenderTextControl::addSearchResult): Added assertion and changed variable name for clarity. (WebCore::RenderTextControl::valueChanged): Changed code to check for empty autosave name instead of null for consistency with other call sites that manage the autosave name. Also changed the code that dispatches an event to call onSearch on the input element so we don't need our own function.
8:01 PM Changeset in webkit [18876] by eseidel
  • 4 edits in trunk/WebCore

2007-01-15 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
(i.e. width is no longer mapped to CSS for SVG)
Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
​http://bugs.webkit.org/show_bug.cgi?id=12060

  • dom/MappedAttributeEntry.h: (WebCore::):
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::cssPropertyIdForName): new helper (WebCore::mapAttributeToCSSProperty): new helper (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper (WebCore::SVGStyledElement::mapToEntry): added. (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
  • ksvg2/svg/SVGStyledElement.h:
6:31 PM Changeset in webkit [22772] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.


Fix: <rdar://problem/4925504> ASSERT when finished running iBench HTML Load Speed

  • WebFrame.cpp: (WebFrame::cancelledError): Return a pseudo-CFNet cancelled error instead of a null ResourceError.
4:53 PM Changeset in webkit [18875] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by mjs

<rdar://problem/4810960>
Gmail Editor: window.focus() called on keyDown (9640)

  • editing/input/attributed-substring-from-range-lines.html-disabled:
  • fast/events/keydown-1-expected.checksum: Added.
  • fast/events/keydown-1-expected.png: Added.
  • fast/events/keydown-1-expected.txt: Added.
  • fast/events/keydown-1.html: Added.

WebKit:

Reviewed by mjs

<rdar://problem/4810960>
Gmail Editor: window.focus() called on keyDown (9640)

The window's keydown event handler was being called
instead of the editable subframe's if there was a key binding
for the key event.

  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Don't send the event to WebCore unless this WebHTMLView is the firstResponder.

WebKitTools:

Reviewed by mjs

<rdar://problem/4810960>
Gmail Editor: window.focus() called on keyDown (9640)

  • DumpRenderTree/EventSendingController.m: Send the keyDown event to the firstResponder, not the event's locationInWindow. A key press's locationInWindow is meaningless and just a dummy coordinate.
4:49 PM Changeset in webkit [18874] by eseidel
  • 472 edits in trunk/WebCore

2007-01-15 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

Update header guards to follow new style guidelines using new clean-header-guards script.

  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSHTMLOptionElementConstructor.h:
  • bindings/js/JSSVGElementWrapperFactory.h:
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.h:
  • bindings/js/kjs_navigator.h:
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_traversal.h:
  • bindings/js/kjs_window.h:
  • bridge/EditorClient.h:
  • bridge/History.h:
  • css/CSSStyleSheet.h:
  • css/CSSValue.h:
  • css/CSSValueList.h:
  • css/DashboardRegion.h:
  • css/FontFamilyValue.h:
  • css/FontValue.h:
  • css/MediaFeatureNames.h:
  • css/MediaList.h:
  • css/Pair.h:
  • css/RectImpl.h:
  • css/ShadowValue.h:
  • css/StyleBase.h:
  • css/StyleList.h:
  • css/StyleSheet.h:
  • css/StyleSheetList.h:
  • css/cssstyleselector.h:
  • dom/BeforeTextInsertedEvent.h:
  • dom/CDATASection.h:
  • dom/CharacterData.h:
  • dom/ChildNodeList.h:
  • dom/Comment.h:
  • dom/DOMImplementation.h:
  • dom/DocPtr.h:
  • dom/Document.h:
  • dom/DocumentFragment.h:
  • dom/DocumentMarker.h:
  • dom/DocumentType.h:
  • dom/EditingText.h:
  • dom/Entity.h:
  • dom/EntityReference.h:
  • dom/EventNames.h:
  • dom/EventTargetNode.h:
  • dom/NameNodeList.h:
  • dom/NamedNodeMap.h:
  • dom/Node.h:
  • dom/NodeList.h:
  • dom/Notation.h:
  • dom/Position.h:
  • dom/ProcessingInstruction.h:
  • dom/Range.h:
  • dom/StyleElement.h:
  • dom/Text.h:
  • editing/AppendNodeCommand.h:
  • editing/ApplyStyleCommand.h:
  • editing/BreakBlockquoteCommand.h:
  • editing/CommandByName.h:
  • editing/CompositeEditCommand.h:
  • editing/DeleteButton.h:
  • editing/DeleteButtonController.h:
  • editing/DeleteFromTextNodeCommand.h:
  • editing/DeleteSelectionCommand.h:
  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertLineBreakCommand.h:
  • editing/InsertNodeBeforeCommand.h:
  • editing/InsertParagraphSeparatorCommand.h:
  • editing/InsertTextCommand.h:
  • editing/JoinTextNodesCommand.h:
  • editing/MergeIdenticalElementsCommand.h:
  • editing/ModifySelectionListLevel.h:
  • editing/MoveSelectionCommand.h:
  • editing/RemoveCSSPropertyCommand.h:
  • editing/RemoveNodeAttributeCommand.h:
  • editing/RemoveNodeCommand.h:
  • editing/RemoveNodePreservingChildrenCommand.h:
  • editing/ReplaceSelectionCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • editing/SplitElementCommand.h:
  • editing/SplitTextNodeCommand.h:
  • editing/SplitTextNodeContainingElementCommand.h:
  • editing/TextGranularity.h:
  • editing/TypingCommand.h:
  • editing/WrapContentsInDummySpanCommand.h:
  • history/BackForwardList.h:
  • history/HistoryItem.h:
  • history/HistoryItemTimer.h:
  • history/PageCache.h:
  • html/CanvasGradient.h:
  • html/CanvasPattern.h:
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.h:
  • html/FormDataList.h:
  • html/HTMLAnchorElement.h:
  • html/HTMLAppletElement.h:
  • html/HTMLAreaElement.h:
  • html/HTMLBRElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBaseFontElement.h:
  • html/HTMLBlockquoteElement.h:
  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.h:
  • html/HTMLCanvasElement.h:
  • html/HTMLCollection.h:
  • html/HTMLDListElement.h:
  • html/HTMLDirectoryElement.h:
  • html/HTMLDivElement.h:
  • html/HTMLElement.h:
  • html/HTMLElementFactory.h:
  • html/HTMLEmbedElement.h:
  • html/HTMLFieldSetElement.h:
  • html/HTMLFontElement.h:
  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFrameSetElement.h:
  • html/HTMLGenericFormElement.h:
  • html/HTMLHRElement.h:
  • html/HTMLHeadElement.h:
  • html/HTMLHeadingElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLImageElement.h:
  • html/HTMLImageLoader.h:
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLLIElement.h:
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLMenuElement.h:
  • html/HTMLMetaElement.h:
  • html/HTMLModElement.h:
  • html/HTMLNameCollection.h:
  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLOptionsCollection.h:
  • html/HTMLParagraphElement.h:
  • html/HTMLParamElement.h:
  • html/HTMLParser.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.h:
  • html/HTMLTablePartElement.h:
  • html/HTMLTableRowElement.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFieldInnerElement.h:
  • html/HTMLTitleElement.h:
  • html/HTMLUListElement.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/events/JSSVGLazyEventListener.h:
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/PointerEventsHitRules.h:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/misc/TimeScheduler.h:
  • ksvg2/svg/GradientAttributes.h:
  • ksvg2/svg/LinearGradientAttributes.h:
  • ksvg2/svg/PatternAttributes.h:
  • ksvg2/svg/RadialGradientAttributes.h:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedPathData.h:
  • ksvg2/svg/SVGAnimatedPoints.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElementInstance.h:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLangSpace.h:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGListTraits.h:
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMetadataElement.h:
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegClosePath.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGRenderingIntent.h:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStylable.h:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUnitTypes.h:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.h:
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.h:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocumentLoader.h:
  • loader/Request.h:
  • loader/SubresourceLoader.h:
  • loader/icon/IconDataCache.h:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconLoader.h:
  • loader/icon/SQLDatabase.h:
  • loader/icon/SQLStatement.h:
  • loader/icon/SQLTransaction.h:
  • page/Frame.h:
  • page/FrameLoadRequest.h:
  • page/FrameTree.h:
  • page/FrameView.h:
  • page/PageState.h:
  • page/Plugin.h:
  • page/qt/FrameQt.h:
  • page/qt/FrameQtClient.h:
  • platform/Arena.h:
  • platform/ArrayImpl.h:
  • platform/Cursor.h:
  • platform/DeprecatedArray.h:
  • platform/DeprecatedCString.h:
  • platform/FileChooser.h:
  • platform/Font.h:
  • platform/FontCache.h:
  • platform/FontData.h:
  • platform/FontDescription.h:
  • platform/FontFamily.h:
  • platform/GlyphBuffer.h:
  • platform/GlyphMap.h:
  • platform/GlyphWidthMap.h:
  • platform/Logging.h:
  • platform/Pasteboard.h:
  • platform/PlatformString.h:
  • platform/PlugInInfoStore.h:
  • platform/PopupMenu.h:
  • platform/PopupMenuClient.h:
  • platform/ScrollBar.h:
  • platform/ScrollView.h:
  • platform/SearchPopupMenu.h:
  • platform/Shared.h:
  • platform/Sound.h:
  • platform/SystemTime.h:
  • platform/Timer.h:
  • platform/Widget.h:
  • platform/cf/RetainPtr.h:
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/FontPlatformData.h:
  • platform/gdk/FrameGdk.h:
  • platform/gdk/KeyboardCodes.h:
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/RenderThemeGdk.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/Icon.h:
  • platform/graphics/Image.h:
  • platform/graphics/ImageAnimationObserver.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/IntSizeHash.h:
  • platform/graphics/PathTraversalState.h:
  • platform/graphics/Pen.h:
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/svg/SVGImage.h:
  • platform/graphics/svg/SVGImageEmptyClients.h:
  • platform/graphics/svg/SVGPaintServer.h:
  • platform/graphics/svg/SVGPaintServerGradient.h:
  • platform/graphics/svg/SVGPaintServerLinearGradient.h:
  • platform/graphics/svg/SVGPaintServerPattern.h:
  • platform/graphics/svg/SVGPaintServerRadialGradient.h:
  • platform/graphics/svg/SVGPaintServerSolid.h:
  • platform/graphics/svg/SVGResource.h:
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/SVGResourceFilter.h:
  • platform/graphics/svg/SVGResourceMarker.h:
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/CgSupport.h:
  • platform/graphics/svg/filters/SVGDistantLightSource.h:
  • platform/graphics/svg/filters/SVGFEBlend.h:
  • platform/graphics/svg/filters/SVGFEColorMatrix.h:
  • platform/graphics/svg/filters/SVGFEComponentTransfer.h:
  • platform/graphics/svg/filters/SVGFEComposite.h:
  • platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
  • platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
  • platform/graphics/svg/filters/SVGFEDisplacementMap.h:
  • platform/graphics/svg/filters/SVGFEFlood.h:
  • platform/graphics/svg/filters/SVGFEGaussianBlur.h:
  • platform/graphics/svg/filters/SVGFEImage.h:
  • platform/graphics/svg/filters/SVGFEMerge.h:
  • platform/graphics/svg/filters/SVGFEMorphology.h:
  • platform/graphics/svg/filters/SVGFEOffset.h:
  • platform/graphics/svg/filters/SVGFESpecularLighting.h:
  • platform/graphics/svg/filters/SVGFETile.h:
  • platform/graphics/svg/filters/SVGFETurbulence.h:
  • platform/graphics/svg/filters/SVGFilterEffect.h:
  • platform/graphics/svg/filters/SVGLightSource.h:
  • platform/graphics/svg/filters/SVGPointLightSource.h:
  • platform/graphics/svg/filters/SVGSpotLightSource.h:
  • platform/mac/FontPlatformData.h:
  • platform/mac/PlatformScrollBar.h:
  • platform/network/AuthenticationChallenge.h:
  • platform/network/Credential.h:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/ProtectionSpace.h:
  • platform/network/ResourceError.h:
  • platform/network/ResourceRequest.h:
  • platform/network/ResourceResponse.h:
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/cf/ResourceRequestCFNet.h:
  • platform/network/cf/ResourceResponseCFNet.h:
  • platform/network/gdk/ResourceHandleManager.h:
  • platform/network/mac/AuthenticationMac.h:
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/qt/ResourceHandleManagerKDE.h:
  • platform/network/qt/ResourceHandleManagerQt.h:
  • platform/network/win/ResourceHandleWin.h:
  • platform/qt/FontPlatformData.h:
  • platform/qt/KeyboardCodes.h:
  • platform/qt/PlatformScrollBar.h:
  • platform/qt/ScrollViewCanvasQt.h:
  • platform/qt/SharedTimerQt.h:
  • platform/win/FontPlatformData.h:
  • platform/win/PlatformScrollBar.h:
  • rendering/AutoTableLayout.h:
  • rendering/HitTestRequest.h:
  • rendering/HitTestResult.h:
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.h:
  • rendering/Length.h:
  • rendering/ListMarkerBox.h:
  • rendering/RenderBox.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.h:
  • rendering/RenderPath.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGText.h:
  • rendering/RenderStyle.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderThemeWin.h:
  • rendering/bidi.h:
  • xml/DOMParser.h:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.h:
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.h:
  • xml/XPathNSResolver.h:
  • xml/XPathNamespace.h:
  • xml/XPathParser.h:
  • xml/XPathPath.h:
  • xml/XPathPredicate.h:
  • xml/XPathResult.h:
  • xml/XPathStep.h:
  • xml/XPathUtil.h:
  • xml/XPathValue.h:
  • xml/XPathVariableReference.h:
  • xml/XSLImportRule.h:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.h:
  • xml/xmlhttprequest.h:
4:47 PM Changeset in webkit [18873] by eseidel
  • 1 edit
    1 add in trunk/WebKitTools

2007-01-15 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.


Add a script to keep our header guards squeaky clean.

  • Scripts/clean-header-guards: Added.
4:46 PM Changeset in webkit [18872] by eseidel
  • 2 edits in trunk/WebKitSite

2007-01-15 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

  • coding/coding-style.html: update to include style for header guards
4:33 PM Changeset in webkit [22771] by andersca
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4889203>
Implement WebFrame::canHandleRequest.


  • WebDataSource.cpp: (WebDataSource::webFrame): Implement webFrame accessor.


  • WebFrame.cpp: (WebFrame::canHandleRequest):
  • WebView.cpp: (WebView::canHandleRequest):
  • WebView.h: Implement canHandleRequest.
3:33 PM Changeset in webkit [22770] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj: Add ProgressTracker.[cpp|h]
3:22 PM Changeset in webkit [18871] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • loader/ProgressTracker.cpp:
2:39 PM Changeset in webkit [22769] by andersca
  • 7 edits
    2 adds in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Loader related improvements.


  • Interfaces/IWebFrameLoadDelegate.idl: Change method signature to match what we have on Mac more closely.


  • WebDataSource.cpp: (WebDataSource::pageTitle): Implement.


  • WebError.cpp: Added.
  • WebError.h: Added. Add (currently stubbed out) IWebError implementation.


  • WebFrame.cpp: (WebFrame::dispatchDidCancelClientRedirect): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidReceiveIcon): (WebFrame::dispatchUnableToImplementPolicy): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad): Implement these.


  • WebKit.vcproj/WebKit.vcproj: Add WebError.h and WebError.cpp
2:13 PM Changeset in webkit [18870] by lars
  • 2 edits in trunk/WebCore

Compile and link the ProgressTracker into the Qt build.

2:12 PM Changeset in webkit [22768] by andersca
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.


  • WebFrame.cpp: (WebFrame::postProgressStartedNotification): (WebFrame::postProgressEstimateChangedNotification): (WebFrame::postProgressFinishedNotification):
  • WebFrame.h: Post the correct notifications.


  • WebView.cpp: (WebView::estimatedProgress): Ask the progress tracker for the estimated progress.
2:07 PM Changeset in webkit [18869] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • loader/ProgressTracker.cpp: Set finalProgressValue to its value explicitly instead of calculating it (which causes a global initializer to be generated).
1:55 PM Changeset in webkit [18868] by andersca
  • 16 edits
    2 adds in trunk

WebCore:

Reviewed by Darin and Adam.

Move progress tracking down to WebCore.


  • WebCore.exp: Add ProgressTracker::estimatedProgress() to be used by WebKit.


  • WebCore.xcodeproj/project.pbxproj: Add ProgressTracker.[cpp|h]


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::didFinishLoad): Call directly to the progress tracker instead of through the frame loader client.


  • loader/FrameLoaderClient.h: Get rid of the old methods and add new methods for tracking progress.


  • loader/ProgressTracker.cpp: Added. (WebCore::ProgressItem::ProgressItem): (WebCore::ProgressTracker::ProgressTracker): (WebCore::ProgressTracker::~ProgressTracker): (WebCore::ProgressTracker::estimatedProgress): (WebCore::ProgressTracker::reset): (WebCore::ProgressTracker::progressStarted): (WebCore::ProgressTracker::progressCompleted): (WebCore::ProgressTracker::finalProgressComplete): (WebCore::ProgressTracker::incrementProgress): (WebCore::ProgressTracker::completeProgress): (WebCore::ProgressTracker::createUniqueIdentifier):
  • loader/ProgressTracker.h: Added. New per page class which tracks progress.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::progress): Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress): (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress): (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification): (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification): (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification): Add new methods, get rid of the old ones.

WebKit:

Reviewed by Darin.

Update to match WebCore.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willChangeEstimatedProgress): (WebFrameLoaderClient::didChangeEstimatedProgress): (WebFrameLoaderClient::postProgressStartedNotification): (WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebFrameLoaderClient::postProgressFinishedNotification): Post the correct notifications.


  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): Get rid of all progress tracking code.


(-[WebView estimatedProgress]):
Call ProgressTracker::estimatedProgress()

WebKitQt:

Fix build.


  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::postProgressStartedNotification): (WebCore::FrameLoaderClientQt::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
  • WebCoreSupport/FrameLoaderClientQt.h:
12:57 PM Changeset in webkit [18867] by aroben
  • 5 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Anders.

Fix: ​http://bugs.webkit.org/show_bug.cgi?id=12288
fast/tokenizer/004 needs new results

  • fast/tokenizer/004.html: Changed to dump as text, changed tabs to spaces.
  • fast/tokenizer/004-expected.txt: Updated results.
  • fast/tokenizer/004-expected.checksum: Removed.
  • fast/tokenizer/004-expected.png: Removed.

WebCore:

Reviewed by Anders.

Fix comment.

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
12:00 PM Changeset in webkit [22767] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • Interfaces/IWebView.idl: Add progress notifications.
11:39 AM Changeset in webkit [18866] by sullivan
  • 2 edits in trunk/WebCore
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Leopard build fix; don't declare one of the case values twice
11:03 AM S60ConfigureComputer edited by bradley.morrison@nokia.com
Added a quick note re workaround for rare sdk installation problem (diff)
10:40 AM Changeset in webkit [18865] by ap
  • 7 edits
    4 moves
    12 adds
    12 deletes in trunk

2007-01-15 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

WebCore:

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc if row span or column span change.

LayoutTests:

  • fast/dom/HTMLTableElement/colSpan-expected.checksum: Updated.
  • fast/dom/HTMLTableElement/colSpan-expected.png: Updated.
  • fast/dom/HTMLTableElement/colSpan-expected.txt: Updated.
  • fast/dom/HTMLTableElement/colSpan.html: Removed comment about expected failure.
  • tables/mozilla/bugs/bug22246-2-expected.checksum: Added.
  • tables/mozilla/bugs/bug22246-2-expected.png: Added.
  • tables/mozilla/bugs/bug22246-2-expected.txt: Added.
  • tables/mozilla/bugs/bug22246-2a-expected.checksum: Added.
  • tables/mozilla/bugs/bug22246-2a-expected.png: Added.
  • tables/mozilla/bugs/bug22246-2a-expected.txt: Added.
  • tables/mozilla/bugs/bug22246-3-expected.checksum: Added.
  • tables/mozilla/bugs/bug22246-3-expected.png: Added.
  • tables/mozilla/bugs/bug22246-3-expected.txt: Added.
  • tables/mozilla/bugs/bug22246-3a-expected.checksum: Added.
  • tables/mozilla/bugs/bug22246-3a-expected.png: Added.
  • tables/mozilla/bugs/bug22246-3a-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug22246-2-expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-2-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-2-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-2.html: Moved to mozilla/ since it no longer fails.
  • tables/mozilla_expected_failures/bugs/bug22246-2a-expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-2a-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-2a-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-2a.html: Moved to mozilla/ since it no longer fails.
  • tables/mozilla_expected_failures/bugs/bug22246-3-expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-3-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-3-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-3.html: Moved to mozilla/ since it no longer fails.
  • tables/mozilla_expected_failures/bugs/bug22246-3a-expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-3a-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-3a-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug22246-3a.html: Moved to mozilla/ since it no longer fails.
10:30 AM Changeset in webkit [18864] by aroben
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

Small context menu fixes.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Fix typo. (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses Found", and added all enum values explicitly.

WebKit:

Reviewed by Darin.

Fix: ​http://bugs.webkit.org/show_bug.cgi?id=12134
REGRESSION: Assertion failure and crash when right clicking selection
in forms

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusFromOldApps): Static helper to fix up menus from applications compiled against Tiger WebKit. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call helper to fix menus.
  • WebView/WebUIDelegatePrivate.h: Fixed typo.
10:14 AM Changeset in webkit [22766] by andersca
  • 7 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Call resource load delegate methods.


  • Interfaces/IWebResourceLoadDelegate.idl: Use unsigned long instead of UINT.


  • WebBackForwardList.cpp:
  • WebBackForwardList.h: Get rid of the createInstance method that takes no arguments.
  • WebFrame.cpp: (WebFrame::assignIdentifierToInitialRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): Call the right resource load delegate methods.


  • WebView.cpp: (WebView::setResourceLoadDelegate): (WebView::resourceLoadDelegate): (WebView::setPolicyDelegate): (WebView::policyDelegate):
  • WebView.h: Add getters and setters for the resource load delegate and the policy delegate.
10:00 AM Changeset in webkit [18863] by ap
  • 9 edits
    6 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=6272
XMLHttpRequest freezes on getting a missing document with overridden Content-Length

​http://bugs.webkit.org/show_bug.cgi?id=6212
Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.

Tests:

  • http/tests/xmlhttprequest/connection-error-sync.html
  • http/tests/xmlhttprequest/set-dangerous-headers.html
  • bindings/js/kjs_binding.cpp: (KJS::): (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary PERMISSION_DENIED error into a special case.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/FrameLoader.h: Return the error object to the caller. Removed an extra local variable for error, which shadowed the one from enclosing block.
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Updated to pass an error object (currently ignored).
  • xml/xmlhttprequest.cpp: (WebCore::canSetRequestHeader): Added. The headers to block include the ones from the current XMLHttpRequest draft plus "Via", which is blocked by Firefox. (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in an error. (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
  • xml/xmlhttprequest.h: (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
9:19 AM Changeset in webkit [18862] by zack
  • 10 edits in trunk/WebCore

Optimizing rendering on the Qt platform. Mainly switch to QPixmap
from client-side QImage. Also clean up nasty hacks in ScrollViewCanvasQt

8:01 AM Changeset in webkit [18861] by lars
  • 9 edits in trunk

Reviewed by Zack

Fix weird crashes when running the layout tests. The
reason was that I used KURL (and thus DeprecatedString)
in a thread. Unfortunately that class is not threadsafe
at all.

DumpRenderTree: Fix a few smaller issues in there, and update
our list of skipped tests.

7:35 AM Changeset in webkit [18860] by eseidel
  • 2 edits in trunk/WebCore

2007-01-15 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Make isValid check not malloc 3 SVGStringLists for every element.


No test possible, performance fix only.

  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
7:04 AM Changeset in webkit [18859] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Remove unused member var.

3:58 AM Changeset in webkit [18858] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12069
Hit detection fails under some viewbox constraints

Do not take viewBox into account when hit testing svg container.

2:10 AM Changeset in webkit [18857] by hyatt
  • 2 edits in trunk/WebCore

Fix for 12275, negative margins confuse page breaks.

Reviewed by Eric

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
1:19 AM Changeset in webkit [18856] by eseidel
  • 4 edits
    4 adds in trunk

2007-01-15 Eric Seidel <​eric@eseidel.com>

Reviewed by mjs.


SVG gradients do not notice stop additions
​http://bugs.webkit.org/show_bug.cgi?id=12192

Test: svg/custom/gradient-add-stops.svg

  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
  • ksvg2/svg/SVGGradientElement.h:

Jan 14, 2007:

11:49 PM Changeset in webkit [18855] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML. Change the requiresLayer
check to use the DOM, since the old check would fail if the parent block had no element.

Reviewed by Eric

Added svg/custom/relative-positioning.html (absolute/fixed too)

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer):
11:05 PM Changeset in webkit [22765] by aliceli1
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.

Fixed: <rdar://problem/4888908> Find: "Use selection to find" and "Jump to selection" are not implemented

  • Interfaces/IWebView.idl:
  • WebView.cpp: (WebView::selectedText): (WebView::centerSelectionInVisibleArea):
  • WebView.h:
10:52 PM Changeset in webkit [18854] by eseidel
  • 3 edits
    4 adds in trunk

2007-01-14 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.


SVG does not correctly handle float: left
​http://bugs.webkit.org/show_bug.cgi?id=12210

Test: svg/custom/svg-float-border-padding.xml

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
7:33 PM Changeset in webkit [18853] by brmorris
  • 2 edits in S60/trunk/WebCore

2007-01-14 brmorris 3.0 sdk build fix.

  • BWINS/WebCore_sdkU.DEF:
5:29 PM Changeset in webkit [18852] by hyatt
  • 4 adds in trunk/LayoutTests/fast/replaced

Add layout test for select line breaking.

5:28 PM Changeset in webkit [18851] by hyatt
  • 2 edits in trunk/WebCore

More work to fix 10145, regression where form elements don't break properly. Make sure to really use
the parent of the replaced element's whitespace value everywhere.

Reviewed by olliej

fast/replaced/three-selects-break.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
5:08 PM Changeset in webkit [18850] by weinig
  • 33 edits in trunk/WebCore

Reviewed by Darin and then by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12228
Cleanup assorted CSS classes

  • css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue): (WebCore::CSSBorderImageValue::cssText):
  • css/CSSBorderImageValue.h:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): (WebCore::valueForBorderStyle): (WebCore::valueForTextAlign): (WebCore::valueForShadow): (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::cssText): (WebCore::primitiveValueFromLength): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyPriority): (WebCore::CSSComputedStyleDeclaration::removeProperty): (WebCore::CSSComputedStyleDeclaration::setProperty): (WebCore::CSSComputedStyleDeclaration::length): (WebCore::CSSComputedStyleDeclaration::item):
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::CSSCursorImageValue):
  • css/CSSCursorImageValue.h:
  • css/CSSGrammar.y:
  • css/CSSImageValue.cpp:
  • css/CSSImageValue.h:
  • css/CSSInheritedValue.cpp:
  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.cpp:
  • css/CSSInitialValue.h:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::operator=): (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::get4Values): (WebCore::CSSMutableStyleDeclaration::getShorthandValue): (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue): (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::setChanged): (WebCore::CSSMutableStyleDeclaration::getPropertyPriority): (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand): (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::setLengthProperty): (WebCore::CSSMutableStyleDeclaration::cssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::removeProperty):
  • css/CSSNamespace.h: (WebCore::CSSNamespace::CSSNamespace):
  • css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::setFloatValue): (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::setStringValue): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::parseString): (WebCore::CSSPrimitiveValue::getIdent): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getRGBColorValue): (WebCore::CSSPrimitiveValue::getPairValue): (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
  • css/CSSProperty.cpp: (WebCore::operator==):
  • css/CSSProperty.h: (WebCore::CSSProperty::operator=):
  • css/CSSQuirkPrimitiveValue.h: (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::insertRule):
  • css/CSSRuleList.h: (WebCore::CSSRuleList::item):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::print): (WebCore::CSSSelector::specificity): (WebCore::CSSSelector::extractPseudoType): (WebCore::CSSSelector::operator==): (WebCore::CSSSelector::selectorText):
  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::append): (WebCore::CSSSelector::next): (WebCore::CSSSelector::pseudoType): (WebCore::CSSSelector::hasTag): (WebCore::CSSSelector::hasAttribute):
  • css/CSSStyleDeclaration.cpp: (WebCore::propertyID): (WebCore::CSSStyleDeclaration::getPropertyPriority): (WebCore::CSSStyleDeclaration::getPropertyShorthand): (WebCore::CSSStyleDeclaration::isPropertyImplicit): (WebCore::CSSStyleDeclaration::setProperty): (WebCore::CSSStyleDeclaration::isPropertyName): (WebCore::CSSStyleDeclaration::parentRule): (WebCore::CSSStyleDeclaration::diff): (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
  • css/CSSStyleDeclaration.h:
  • css/Counter.h: (WebCore::Counter::Counter): (WebCore::Counter::listStyleNumber):
  • css/csshelper.cpp: (WebCore::parseURL):
  • css/csshelper.h:
  • css/cssparser.h: (WebCore::domString): (WebCore::atomicString): (WebCore::CSSParser::operator|):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSRuleSet::addRule):
4:53 PM Changeset in webkit [18849] by bdash
  • 5 edits in trunk/WebKitTools

2007-01-14 Mark Rowe <​mrowe@apple.com>

Reviewed by Adam.

<rdar://problem/4908909> Need to create Leopard nightly build

  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Always use the 10.4 Universal SDK. The disk images don't mount pre-10.4 so we aren't losing anything here.
  • WebKitLauncher/WebKitNightlyEnabler.m: (poseAsWebKitApp): Simplify CoreFoundation-related hackery by using _CFGetProcessPath instead of walking the mach-o symbol tables. The smaller timeframe where the CFProcessPath environment variable is set allows this to work correctly on Leopard where the old code failed. (enableWebKitNightlyBehaviour):
  • WebKitLauncher/main.m: (main): Pass executable path as WebKitAppPath rather than CFProcessPath to prevent it being picked up too early by CoreFoundation.
  • Drosera/launcher.m: (main): Ditto
4:39 PM Changeset in webkit [18848] by ddkilzer
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam. Patch by Mitz.

  • fast/tokenizer/ignore-tags-in-iframe-expected.txt: Added.
  • fast/tokenizer/ignore-tags-in-iframe.html: Added.

WebCore:

Reviewed by Adam. Patch by Mitz.

Test: fast/tokenizer/ignore-tags-in-iframe.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::reset): Removed unused inSelect member variable. (WebCore::HTMLParser::selectCreateErrorCheck): Ditto. (WebCore::HTMLParser::processCloseTag): Ditto.
  • html/HTMLParser.h: Ditto.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>, <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode (waiting for a close tag of an element whose contents are not parsed, such as iframe).
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit. (WebCore::HTMLTokenizer::State::): Ditto.
3:58 PM Changeset in webkit [18847] by brmorris
  • 2 edits in S60/trunk/WebKit

2007-01-14 brmorris <​bradley.morrison@nokia.com>

DESC: reverted revision 18809

  • BrowserCore/Formcontrols/src/FInputlFormattedEditor.cpp
1:45 PM Changeset in webkit [18846] by ddkilzer
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

  • WebView/WebView.mm: (-[WebView _objectForIdentifier:]): Removed assertion. (-[WebView _removeObjectForIdentifier:]): Removed assertion.
12:13 PM Changeset in webkit [22764] by aroben
  • 11 edits
    1 copy
    3 adds in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Fix: <rdar://4831292> Implement WebKitStatistics

Added object counting:

  • WebDataSource.cpp: (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource):
  • WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::~WebFrame):
  • WebHTMLRepresentation.cpp: (WebHTMLRepresentation::WebHTMLRepresentation): (WebHTMLRepresentation::~WebHTMLRepresentation):
  • WebView.cpp: (WebView::WebView): Initialize m_page member. (WebView::~WebView):
10:46 AM Changeset in webkit [18845] by ap
  • 2 edits in trunk/LayoutTests

Reviewed by Mitz.

  • fast/multicol/float-multicol.html: Fixed an URL not to point to a remote resource (we already have a local copy).
10:08 AM Changeset in webkit [18844] by ap
  • 12 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12258
fast/tokenizer/002 test broken

WebCore:

  • loader/FrameLoader.h: Added a flush parameter to write().
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::write): Ditto. (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(), call it directly.

LayoutTests:

  • editing/selection/designmode-no-caret-expected.txt:
  • fast/dom/HTMLHeadElement/textInHead4-expected.txt:
  • fast/parser/broken-comments-vs-parsing-mode-expected.txt:
  • fast/parser/tabs-in-scripts-expected.txt:
  • fast/tokenizer/external-script-document-write-expected.txt:
  • fast/tokenizer/missing-title-end-tag-1-expected.txt:
  • tables/mozilla/images/adforce_imgis_com-expected.txt:
  • tables/mozilla_expected_failures/images/adforce_imgis_com-expected.txt: Updated the results (inconsequential changes only).
2:04 AM Changeset in webkit [18843] by aroben
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • editing/deleting/4845371.html: Removed bogus "Javascript" type.
  • editing/selection/4397952.html: Ditto.
  • fast/html/script-allowed-types-languages-expected.txt: Added.
  • fast/html/script-allowed-types-languages.html: Added. Tests type/language whitelisting.

WebCore:

Reviewed by Maciej.

Make sure our whitelisting of the type and language attributes of the
<script> element is enforced in all HTMLTokenizer/HTMLScriptElement
code paths.

All layout tests pass.

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to determine whether the script should be executed, given its type and language attributes. (WebCore::HTMLScriptElement::evaluateScript): Check type/language before executing.
  • html/HTMLScriptElement.h: Added new declarations.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. (WebCore::HTMLTokenizer::scriptHandler): Check shouldExecuteAsJavaScript before executing. (WebCore::HTMLTokenizer::notifyFinished): Ditto. (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from here to HTMLScriptElement::shouldExecuteAsJavaScript.
  • html/HTMLTokenizer.h: Made scriptSrc a String, and removed the javascript member.
1:48 AM Changeset in webkit [18842] by hyatt
  • 4 adds in trunk/LayoutTests/fast/replaced

Add a second breaking test for replaced and text mixtures.

1:21 AM Changeset in webkit [18841] by hyatt
  • 4 adds in trunk/LayoutTests/fast/multicol

Add multicol float avoidance test.

1:16 AM Changeset in webkit [18840] by hyatt
  • 2 edits in trunk/WebCore

Make sure floats are avoided if you have non-auto column property values. Fixes the crazy layout
on ​http://weblogs.mozillazine.org/roc.

Reviewed by mitz

Added fast/multicol/float-avoidance.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::avoidsFloats):
12:25 AM Changeset in webkit [18839] by hyatt
  • 4 adds in trunk/LayoutTests/fast/replaced

Add layout test for replaced breaking.

12:22 AM Changeset in webkit [18838] by hyatt
  • 13 edits in trunk/WebCore

Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
When checking for break opportunities where replaced elements are involved, we ignore their white-space
values and use their parents' instead. The assumption/idea behind this change is that because the element
is replaced, its white-space value is irrelevant except as a means of applying style to its interior.

The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
do.

Reviewed by aroben

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::clear): (WebCore::EventHandler::handleWheelEvent):
  • page/EventHandler.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
  • rendering/RenderLayer.cpp: (WebCore::Marquee::Marquee): (WebCore::Marquee::start): (WebCore::Marquee::updateMarqueePosition): (WebCore::Marquee::updateMarqueeStyle): (WebCore::Marquee::timerFired):
  • rendering/RenderLayer.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):
  • rendering/RenderStyle.h: (WebCore::):
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
Note: See TracTimeline for information about the timeline view.