⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 19, 2007:

11:07 PM Changeset in webkit [18998] by aroben
  • 1 edit in branches/Safari-2-0-branch/WebKit/ChangeLog

Fixed ChangeLog.

7:21 PM Changeset in webkit [18997] by kdecker
  • 6 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Adam.


Merged r10259 and r15845 from TOT to Safari-2-0-branch.

2006-08-11 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

2005-09-13 Tim Omernick <​tomernick@apple.com>

Reviewed by Justin Garcia, Darin Adler.

  • <rdar://problem/3163393> Safari does not support Windowless mode in Flash
  • Plugins.subproj/WebBaseNetscapePluginView.h:

Added 'isTransparent' instance variable.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):

When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
region of the opaque ancestor. This means that a partially-transparent plugin, which
by definition does not clear its port on redraw, will not overdraw the valid parts
of its port.

(-[WebBaseNetscapePluginView sendEvent:]):

Disabled the "green debug background" for transparent plugins -- since they are not
expected to cover their entire port every redraw, this debug code makes no sense.

(-[WebBaseNetscapePluginView setVariable:value:]):

Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
unimplemented).
Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
plugin variables, then we may do so here.

  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:

Added SPI for -[WebBaseNetscapePluginView setVariable:value].

  • Plugins.subproj/npapi.m: (NPN_SetValue):

Implemented this function so that plugins may set state (such as window mode).


4:40 PM Changeset in webkit [18996] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

  • fast/forms/select-size-expected.checksum: Added.
  • fast/forms/select-size-expected.png: Added.
  • fast/forms/select-size-expected.txt: Added.
  • fast/forms/select-size.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

Update the size attribute value for select elements to match the numeric value. This is a special case since this
attribute is used to determine which control to use. We want to make sure that the size attribute is valid when we match
CSS rules.

Test: fast/forms/select-size.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the same as its integer value, then update the attribute value to match the integer.
  • dom/Attribute.h: Made setValue and setPrefix public.
4:33 PM Changeset in webkit [22799] by adachan
  • 4 edits
    1 add in branches/WindowsMerge/WebKitWin

2007-01-19 Ada Chan <​adachan@apple.com>

WebKitWin:

Fixed build.

Reviewed by Anders.
Added IWebResourceLoadDelegatePrivate which has one method: didLoadResourceFromMemoryCache.

  • ChangeLog:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl: Added.
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:


4:32 PM Changeset in webkit [18995] by aroben
  • 3 edits in trunk/WebKit

Reviewed by Beth.

Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
"Font", "Speech", and "Writing Direction" are missing from contextual
menu

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusForOldClients): Change our new SPI tags to WebMenuItemTagOther because old clients aren't expecting the new tags. (fixMenusFromOldClients): Use each menu item's title to figure out its correct tag again. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call fixMenusForOldClients before calling up to the delegate.
  • WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so that we can use it in WebContextMenuClient.
4:14 PM Changeset in webkit [22798] by sullivan
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.


Added mechanism for new callbacks, to try to avoid breaking the Windows build.

  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebFrame.h:
4:02 PM Changeset in webkit [18994] by sullivan
  • 13 edits in trunk

WebCore:

Reviewed by Darin

  • WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in
  • loader/FrameLoaderClient.h: new dispatchDidFinishDocumentLoad call
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): call dispatchDidFinishDocumentLoad


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishDocumentLoad): empty implementation for dispatchDidFinishDocumentLoad

WebKit:

Reviewed by Darin

  • WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in


Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up

  • WebView/WebViewPrivate.h: declare new delegate method
  • WebCoreSupport/WebFrameLoaderClient.h: declare dispatchDidFinishDocumentLoad()
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): new method, calls new delegate method
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): empty default implementation of new delegate method

WebKitQt:

Added stubs for new callbacks, to try to avoid breaking the Qt port.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
  • WebCoreSupport/FrameLoaderClientQt.h:
3:48 PM Changeset in webkit [18993] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php

  • fast/forms/control-restrict-line-height-expected.checksum: Added.
  • fast/forms/control-restrict-line-height-expected.png: Added.
  • fast/forms/control-restrict-line-height-expected.txt: Added.
  • fast/forms/control-restrict-line-height.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php


Test: fast/forms/control-restrict-line-height.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that have restricted font size.
3:18 PM Changeset in webkit [18992] by andersca
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

​http://bugs.webkit.org/show_bug.cgi?id=12308
REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Move code from initWithFrame in here.
3:15 PM Changeset in webkit [18991] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix date.

3:15 PM Changeset in webkit [18990] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug number.

3:12 PM Changeset in webkit [18989] by darin
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test for html4.css problem where we had a missing semicolon and thus missed parsing a style rule
  • fast/forms/radio-no-theme-padding-expected.txt: Added.
  • fast/forms/radio-no-theme-padding.html: Added.
  • fast/forms/select-list-box-mouse-focus-expected.txt: Added.
  • fast/forms/select-list-box-mouse-focus.html: Added.

Note: Only the pixel test shows the failure in the old version.

Note: I generated the pixel results on Leopard -- may need to be
regenated on Tiger.

  • fast/forms/select-list-box-with-height-expected.checksum: Added.
  • fast/forms/select-list-box-with-height-expected.png: Added.
  • fast/forms/select-list-box-with-height-expected.txt: Added.
  • fast/forms/select-list-box-with-height.html: Added.

WebCore:

Reviewed by Adele.

  • fix ​http://bugs.webkit.org/show_bug.cgi?id=11999 <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999) Fix was to use the actual size of the renderer in the RenderListBox case, instead of always using the size specified by the select element.

Test: fast/forms/select-list-box-with-height.html

Test: fast/forms/select-list-box-mouse-focus.html

  • fix bug where auto-scrolling was not working in list box select elements

No test yet.

  • fix a missing semicolon in the radio/checkbox section of html4.css

Test: fast/forms/radio-no-theme-padding.html

  • fix bug where the scroll bars for select elements were pixel-type scroll bars even though the scrolling is line at a time scrolling

No test.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Removed an explicit call to repaint, since the RenderListBox now does that in selectionChanged. (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new selectionChanged instead of the old setSelectionChanged. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call to focus. Removed an explicit call to repaint and added a call to the new setMouseDownMayStartAutoscroll function in EventHandler. Removed an explicit call to repaint as above. (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new selectionChanged instead of the old setSelectionChanged.
  • page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed because the existing code to set that flag won't get triggered when the select element's default event handler handles the event.
  • rendering/RenderListBox.h: Made ScrollbarClient a private base class. Removed setSelectionChanged and m_selectionChanged. Added selectionChanged, which is really just a synonym for repaint for now. Moved valueChanged, the ScrollbarClient function implementations, and itemHeight into the private part of the class. Added numVisibleItems() and listHeight() to the private section. Changed m_vBar to be a RefPtr.
  • rendering/RenderListBox.cpp: Removed unneeded includes. Moved all the constants to the top of the file. (WebCore::RenderListBox::RenderListBox): Removed initialization of m_selectionChanged because it was removed and of m_vBar because it's now a RefPtr which is automaticall initialized. (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of m_vBar because it's a RefPtr. Added null checking for FrameView. (WebCore::RenderListBox::updateFromElement): Use numItems(). (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for FrameView and used RefPtr for the newly-created scroll bar. (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the misleading minDefaultSize to maxDefaultSize, since it's a maximum. (WebCore::RenderListBox::numVisibleItems): Added. Used in many places where size() was used before. This computes the number of rows we have room for. We don't need a row space after the last row, and this takes that into account. (WebCore::RenderListBox::numItems): Tweaked to remove the local variable. (WebCore::RenderListBox::listHeight): Added. Total height of all the rows and spaces between them. (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the row height, and to subtract the last row spacing off since we don't need a space after the last row. Changed the scroll bar setup to make it correspond to row numbers, not pixel numbers. (WebCore::RenderListBox::baselinePosition): Moved the comment to the constant declaration at the top of the file. (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using the itemHeight() function. (WebCore::RenderListBox::paintObject): Changed to use numItems and to use numVisibleItems instead of size. (WebCore::RenderListBox::isPointInScrollbar): Added get() call since m_vBar is now a RefPtr. (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(), itemHeight(), and rearranged a min/max combo so it starts with the low, then the value, then the high value for pinning. (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of size(). (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check of the element. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed to use numItems() and to use numVisibleItems() instead of size(). Also changed scroll bar code to work more simply now that the scroll bar is row-based. (WebCore::RenderListBox::listIndexIsVisible): Changed to use numVisibleItems() instead of size(). (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar is now row-based. Also removed an unnecessary null check. (WebCore::RenderListBox::itemHeight): Updated for name change from optionsSpacingMiddle to rowSpacing. (WebCore::RenderListBox::scrollHeight): Changed to use listHeight(). (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code that does nothing if the computed list index is visible (which did not make sense for this function and seemed a cut and paste error from the scrollToReveal function). The scrollbar part is simpler now that it's row-based. (WebCore::RenderListBox::windowClipRect): Changed to use document()->view() so we don't have to include RenderView.h.
  • css/html4.css: Added a semicolon I noticed was missing.
2:36 PM Changeset in webkit [22797] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

Much more realistic WebDownload interface that delegates will actually have to implement


  • Interfaces/IWebDownload.idl:

Also updated svn:eol-style on .idls

1:57 PM Changeset in webkit [18988] by bdakin
  • 8 edits
    8 adds
    4 deletes in trunk

WebCore:

Reviewed by Maciej and Darin.

Fix for <rdar://problem/4702420> REGRESSION: Null characters need
to be stripped from text nodes (townhall.com)

This was a regression from the fix for <rdar://problem/3727939>
Safari strips \0 characters from HTML tags making them valid, which
was fixed with r12652. We still need to strip null characters in
text nodes.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): No behavior change here, this is just to make Darin happy. (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new createStrippingNull function instead of the normal StringImpl constructor.
  • platform/StringImpl.cpp: (WebCore::StringImpl::createStrippingNull): Strip null.
  • platform/StringImpl.h:

LayoutTests:

Reviewed by Maciej and Darin.

New layout tests and some updates results for the fix for <rdar://
problem/4702420> REGRESSION: Null characters need to be stripped
from text nodes (townhall.com)

  • fast/dom/stripNullFromTextNodes-expected.checksum: Added.
  • fast/dom/stripNullFromTextNodes-expected.png: Added.
  • fast/dom/stripNullFromTextNodes-expected.txt: Added.
  • fast/dom/stripNullFromTextNodes.html: Added.
  • fast/js/null-char-in-string-expected.txt: New results.
  • fast/text/stripNullFromText-expected.checksum: Added.
  • fast/text/stripNullFromText-expected.png: Added.
  • fast/text/stripNullFromText-expected.txt: Added.
  • fast/text/stripNullFromText.html: Added.
  • tables/mozilla/images/adforce_imgis_com-expected.txt: New results.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.checksum: Removed. This is the same test as the one above. The same test was in two places.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.png: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.txt: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com.html: Removed.
1:16 PM Changeset in webkit [18987] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.
12:47 PM Changeset in webkit [22796] by adachan
  • 10 edits
    2 adds in branches/WindowsMerge

2007-01-18 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


WebKitWin:

<rdar://4601522> Activity Window

  • Added some NSURL equivalent constants in IWebURLResponse.idl and IWebError.idl
  • Added IWebErrorPrivate.idl which contains some private error codes
  • Added IWebHTTPURLResponse interface which extends IWebURLResponse. It has the same API as NSHTTPURLResponse.

WebCoreWin:

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • Interfaces/IWebError.idl:
  • Interfaces/IWebErrorPrivate.idl: Added.
  • Interfaces/IWebHTTPURLResponse.idl: Added.
  • Interfaces/IWebResourceLoadDelegate.idl: fixed a typo in parameter name
  • Interfaces/IWebURLResponse.idl: added WebURLResponseUnknownLength
  • WebKit.vcproj/Interfaces.vcproj: for adding IWebErrorPrivate.idl and IWebHTTPURLResponse.idl
  • WebKit.vcproj/WebKitGUID.vcproj: for the new IID_IWebHTTPURLResponse
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): also returns the new IWebHTTPURLResponse interface (WebURLResponse::allHeaderFields): Added stub for IWebHTTPURLResponse::allHeaderFields. (WebURLResponse::localizedStringForStatusCode): Added stub for IWebHTTPURLResponse::localizedStringforStatusCode (WebURLResponse::statusCode): Implemented IWebHTTPURLResponse::statusCode.
  • WebURLResponse.h:


10:25 AM Changeset in webkit [18986] by andersca
  • 3 edits in trunk/WebKit

Yet another build fix.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
10:12 AM Changeset in webkit [22795] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add SVG files.
9:59 AM Changeset in webkit [18985] by andersca
  • 3 edits in trunk/WebKitQt

Try fixing the QT build.


  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::setStatusbarText):
  • WebCoreSupport/ChromeClientQt.h:
9:58 AM Changeset in webkit [22794] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::enabled): Use correct class name.
9:52 AM Changeset in webkit [18984] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::setStatusbarText):
9:42 AM Changeset in webkit [22793] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

The obligatory build fix.


  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
9:38 AM Changeset in webkit [22792] by andersca
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Remove some unused FrameWin functions.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusbarText):
  • WebChromeClient.h: Add new ChromeClient methods.


  • WebFrame.cpp: (WebFrame::userAgent): (WebFrame::updateGlobalHistoryForReload):
  • WebFrame.h: Remove unused FrameWinClient functions.
9:28 AM Changeset in webkit [18983] by andersca
  • 15 edits in trunk

WebCore:

Reviewed by Adam.

Move JavaScript alert and status bar functions to the chrome.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • page/Chrome.cpp: (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusBarText):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText):
  • page/Frame.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::runJavaScriptAlert): (WebCore::SVGEmptyChromeClient::runJavaScriptConfirm): (WebCore::SVGEmptyChromeClient::runJavaScriptPrompt): (WebCore::SVGEmptyChromeClient::setStatusBarText):

WebKit:

Reviewed by Adam.

Move functions from the bridge to the chrome client.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusBarText):
  • WebCoreSupport/WebFrameBridge.mm:
8:02 AM Changeset in webkit [18982] by zack
  • 2 edits in trunk/WebCore

Fix the build

6:27 AM Changeset in webkit [18981] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

More cleanup to SVGAnimated* classes.

No tests possible (only code cleanup)

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseBeginOrEndValue): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::isIndefinite):
  • ksvg2/svg/SVGAnimationElement.h:
6:09 AM Changeset in webkit [18980] by zimmermann
  • 2 edits in trunk/WebCore

Not reviewed.
Remove accidently commited debug output. Shame on me :-)

6:03 AM Changeset in webkit [18979] by zimmermann
  • 44 edits
    31 adds in trunk

Reviewed by Eric.

Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
AFAIK we're the first implementing this SVG feature - after ASV3 (!).

5:42 AM Changeset in webkit [18978] by eseidel
  • 5 edits
    2 adds in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Add support for SVGMPathElement parsing.

No test cases possible (SVGAnimateMotion doesn't work yet)

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • ksvg2/svg/SVGMPathElement.cpp: Added. (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::~SVGMPathElement): (WebCore::SVGMPathElement::parseMappedAttribute): (WebCore::SVGMPathElement::pathElement):
  • ksvg2/svg/SVGMPathElement.h: Added.
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): fix typo in comment
  • ksvg2/svg/svgtags.in: add back mpath
4:59 AM Changeset in webkit [18977] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Implement better parsing for keyTimes, keySplines and keyPoints.

Unfortunately none of this code is used much yet, thus isn't very testable.

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse):
2:09 AM Changeset in webkit [18976] by lars
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

run-webkit-tests does now not generate new results by default anymore.
You'll have to pass the --new-tests flag to it to force it to do so.

This is required to make it possible to have tests running on multiple
platforms peacefully together.

Jan 18, 2007:

11:01 PM Changeset in webkit [22791] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenu::enabled): Implemented.
10:49 PM Changeset in webkit [18975] by aroben
  • 9 edits in trunk

WebCore:

Reviewed by Beth.

Fix: <rdar://problem/4939672> REGRESSION: With text selected that is
not a link, the "Remove Link" contextual menu item remains active

  • platform/ContextMenuItem.h: Added enabled method.
  • platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::enabled): Implemented.
  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::enabled): Ditto.
  • platform/mac/ContextMenuMac.mm: (-[WebCoreMenuTarget validateMenuItem:]): Implemented to fulfill the NSMenuValidation protocol.

WebKit:

Reviewed by Beth.

Fix <rdar://problem/4939672> REGRESSION: With text selected that is
not a link, the "Remove Link" contextual menu item remains active

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Leave autoenabling of menu items on so that clients can implement validateMenuItem:.
10:28 PM Changeset in webkit [18974] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix for <rdar://problem/4939558> REGRESSION: "Search in Google",
"Search in Spotlight" and "Look up in Dictionary" are missing
initially from the contextual menu

The bug here is that we select the we were selecting the word after
the context menu event was dispatched and after the context menu
was built up.

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Select the word before dispatching the event. It is safe to remove the check for swallowEvent since WebCore context menus ensure that we always swallow the event anyway.
9:11 PM Changeset in webkit [18973] by bdash
  • 2 edits in trunk/WebCore

2007-01-18 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=7926
Bug 7926: Crash using -callWebScriptMethod to access offsetTop property

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): Bail out early if function value is an immediate, or if the function object is not callable.
7:34 PM Changeset in webkit [18972] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-01-18 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11853
REGRESSION (r17352): Whitespace in <title> is rendered

  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Changed to also collapse internal whitespace. This required removing an optimization that is no longer possible.
  • manual-tests/title-internal-whitespace.html: Added.
6:27 PM Changeset in webkit [22790] by andersca
  • 7 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

Major cleanups and bugfixes, such as:


Update for changes to the API.
Implement a timer which prevents test from hanging indefinitely.
Fix bugs which would cause the same test result to be dumped twice.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (DumpRenderTreeWndProc): Handle timer.


(initialize):
Initialize CoreGraphics so we get fonts.
(runTest):
Add timer.


(initializePreferences):
Turn off Java and Plug-ins.


(main):

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (waitUntilDoneCallback): (notifyDoneCallback): Fix bug where dump could be called twice.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Fix newlines, update for new API.
5:41 PM Changeset in webkit [22789] by andersca
  • 2 edits
    1 move in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/GlyphMapWin.cpp: Removed.
  • platform/win/GlyphPageTreeNodeWin.cpp: Added. (WebCore::GlyphPage::fill):
5:23 PM Changeset in webkit [18971] by bdash
  • 3 edits
    4 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/text/font-initial.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Give 'font: initial' the Standard generic family. This makes the FontDescription different from that of the initial font of a GraphicsContext, ensuring that the latter will not be used.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/text/font-initial-expected.checksum: Added.
  • fast/text/font-initial-expected.png: Added.
  • fast/text/font-initial-expected.txt: Added.
  • fast/text/font-initial.html: Added.
5:19 PM Changeset in webkit [18970] by bdash
  • 3 edits in trunk/WebKitSite

2007-01-19 Nicholas Shanks <​contact@nickshanks.com>

Reviewed by Maciej.

Change doctype for webkit.org/blog/ admin interface to HTML 4.01.

  • blog/wp-admin/admin-header.php:
  • blog/wp-login.php:
5:14 PM Changeset in webkit [18969] by bdash
  • 3 edits
    3 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: http/tests/misc/css-accept-any-type.html

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Changed the accept header for stylesheets to "text/css,*/*;q=0.1" to match Firefox, accepting CSS served as any type.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • http/tests/misc/css-accept-any-type-expected.txt: Added.
  • http/tests/misc/css-accept-any-type.html: Added.
  • http/tests/misc/resources/stylesheet.php: Added.
5:11 PM Changeset in webkit [18968] by bdash
  • 3 edits
    4 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: editing/selection/display-table-text.html

  • editing/htmlediting.cpp: (WebCore::isTableElement): Changed to return false for text nodes.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • editing/selection/display-table-text-expected.checksum: Added.
  • editing/selection/display-table-text-expected.png: Added.
  • editing/selection/display-table-text-expected.txt: Added.
  • editing/selection/display-table-text.html: Added.
5:10 PM Changeset in webkit [18967] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Adele

<rdar://problem/4917290> -
Null deref in WebFrameLoaderClient::restoreScrollPositionAndViewState()
after regaining network connection

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreScrollPositionAndViewState): Bail early with a null currentItem, preventing a crash in release builds. Leave the ASSERT to help find other cases where this might happen in debug builds.
5:08 PM Changeset in webkit [18966] by bdash
  • 12 edits
    6 moves in trunk/WebCore

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

This patch takes character-to-glyph mapping out of FontData and instead makes
each Font keep its own mapping, using a shared set of glyph page fallback trees.

For each page number there is (at most) one tree. A path from the root to a
node in the tree corresponds to a fallback list of FontDatas. The node points to
a page (which may be shared with other nodes) that maps each character in its range
to a glyph in the first FontData in the fallback list that has it, or to 0 if none of
the FontDatas has a glyph for that character. A special kind of node, that can
only occur as a leaf, corresponds to using system fallback fonts after the list
has been exhausted. This prevents system fallback from polluting non-leaf
nodes.

Nodes and pages are initialized lazily and employ "copy on write".

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/Font.cpp: (WebCore::WidthIterator::WidthIterator): Removed substituteFontData. (WebCore::WidthIterator::advance): Moved all character-to-glyph mapping logic out of here and replaced it with a call to Font::glyphDataForCharacter(). (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::glyphDataForCharacter): Added. This method performs the lookup in the page fallback trees, triggering lazy initialization as needed, and caching pointers to the retrieved page tree nodes in the font. (WebCore::Font::update): (WebCore::Font::drawSimpleText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): Removed substituteFont argument. (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h:
  • platform/FontData.cpp: (WebCore::FontData::FontData):
  • platform/FontData.h: (WebCore::FontData::missingGlyphData): Added. Returns the "missing glyph" GlyphData for this FontData.
  • platform/GlyphMap.cpp: Removed.
  • platform/GlyphMap.h: Removed.
  • platform/GlyphPageTreeNode.cpp: Renamed GlyphMap.cpp to this. (WebCore::GlyphPageTreeNode::getRoot): Added. Returns the root of the page fallback tree for the given page number. (WebCore::GlyphPageTreeNode::initializePage): Added. Helper method that initializes the page pointer of a node, possibly to a pointer to another node's page or to 0. (WebCore::GlyphPageTreeNode::getChild): Added.
  • platform/GlyphPageTreeNode.h: Renamed GlyphMap.h to this. (WebCore::GlyphPage::glyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForIndex): (WebCore::GlyphPageTreeNode::GlyphPageTreeNode): (WebCore::GlyphPageTreeNode::getRootChild): (WebCore::GlyphPageTreeNode::parent): (WebCore::GlyphPageTreeNode::page): (WebCore::GlyphPageTreeNode::level): (WebCore::GlyphPageTreeNode::isSystemFallback): Added. Returns whether the node corresponds to the system providing fallback fonts, which is done on a character-by-character basis.
  • platform/gdk/GlyphMapGdk.cpp: Removed.
  • platform/gdk/GlyphPageTreeNodeGdk.cpp: Renamed GlyphMapGdk.cpp to this. (WebCore::GlyphPage::fill):
  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
  • platform/mac/FontMac.mm: (WebCore::Font::Font):
  • platform/mac/GlyphMapMac.cpp: Removed.
  • platform/mac/GlyphPageTreeNodeMac.cpp: Renamed GlypMapMac.cpp to this. (WebCore::GlyphPage::fill): Changed to return false if the font has no glyphs in the page.
  • platform/qt/GlyphMapQt.cpp: Removed.
  • platform/qt/GlyphPageTreeNodeQt.cpp: Renamed GlyphMapQt.cpp to this. (WebCore::GlyphPage::fill):
  • platform/win/GlyphMapWin.cpp: Removed.
  • platform/win/GlyphPageTreeNodeWin.cpp: Renamed GlyphMapWin to this. (WebCore::GlyphPage::fill):
5:03 PM Changeset in webkit [18965] by bdash
  • 2 edits in trunk/WebCore

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Removed the call to Document::detach(). If this view is the current view, then the Frame should have already detached the document. Added an assertion that this is the case. If this view is not the current view, then it cannot access its document, but the page cache should have detached it already. Similarly, changed to call RenderPart::setWidget() only if this is the current view in the frame. (WebCore::FrameView::adjustViewSize): Added an assertion that this view is the current view in the frame. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::scheduleRelayout): Ditto. (WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto. (WebCore::FrameView::windowClipRect): Ditto.
5:00 PM Changeset in webkit [18964] by eseidel
  • 2 edits in trunk/WebCore

2007-01-18 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

No test needed, removed bogus debug-only ASSERT.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
5:00 PM Changeset in webkit [18963] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-01-18 Sanjay Madhav <​sanjay12@gmail.com>

Reviewed by Darin.

Add JavaScriptCore define to help with tracing of when objects are marked.

  • kjs/object.cpp: (KJS::JSObject::mark):
4:54 PM Changeset in webkit [18962] by aliceli1
  • 2 edits in trunk/WebCore

Build Fix

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
4:14 PM Changeset in webkit [22788] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:04 PM Changeset in webkit [18961] by sfalken
  • 1 copy in tags/Safari-521.32.13b

New tag.

4:01 PM Changeset in webkit [18960] by aliceli1
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fixes the leaks from my last patch, except for the first change below which is a missing delegate call for Mail purposes

  • editing/Editor.cpp: (WebCore::Editor::cut):
  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
3:27 PM Changeset in webkit [22787] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • WebView.cpp: (WebView::scrollBackingStore): Only try to scroll the backing store if it actually exists.
2:37 PM Changeset in webkit [18959] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

2007-01-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Phone doesn't recognises http link to a ram file (fix on 3.1m) AKKO-6X4B3D


​http://bugs.webkit.org/show_bug.cgi?id=12316

2:30 PM Changeset in webkit [18958] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
2:20 PM Changeset in webkit [18957] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/4939511> WebKit should set the CG clip path for plug-ins that draw using CoreGraphics

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView drawRect:]): Set the CG clip path to the plug-in dirty rect. This allows plug-ins to obtain their dirty rect using functions like CGContextGetClipBoundingBox().
2:07 PM Changeset in webkit [22786] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix ownership handling of CFRequestRef. A ResourceRequest holds on to its CFRequestRef
and doesn't ref it when returning it. Also, implement willCacheResponse.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::willCacheResponse): (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
2:03 PM Changeset in webkit [18956] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-18 brmorris

3.0 S60 sdk build fix: avkon.loc not visible on sdk,
flag out its inclusion in Webkit.rss

1:38 PM Changeset in webkit [18955] by sullivan
  • 1 edit in trunk/LayoutTests/ChangeLog

Removed accidentally-duplicated entries.

1:33 PM Changeset in webkit [18954] by brmorris
  • 3 edits in S60

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Phone doesn't recognises http link to a ram file


​http://bugs.webkit.org/show_bug.cgi?id=12316

1:33 PM Changeset in webkit [18953] by sullivan
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin


  • Tests for: <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string
  • editing/spelling/spelling-expected.checksum: Added.
  • editing/spelling/spelling-expected.png: Added.
  • editing/spelling/spelling-expected.txt: Added.
  • editing/spelling/spelling.html: Added.
  • editing/execCommand/find-after-replace-expected.checksum: Added.
  • editing/execCommand/find-after-replace-expected.png: Added.
  • editing/execCommand/find-after-replace-expected.txt: Added.
  • editing/execCommand/find-after-replace.html: Added.
1:25 PM Changeset in webkit [18952] by brmorris
  • 2 edits in S60

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
1:14 PM Changeset in webkit [18951] by hyatt
  • 3 edits in trunk/WebCore

Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before
calling hitTest on it. Fixes "flashy" selection in textareas.

Reviewed by darin

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint):
1:09 PM Changeset in webkit [18950] by andersca
  • 6 edits
    1 delete in trunk/WebCore

Reviewed by Adam.

Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse):
  • loader/ResourceLoader.h:
  • loader/mac/ResourceLoaderMac.mm: Removed.
  • platform/network/ResourceHandleClient.h: (WebCore::): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
1:01 PM Changeset in webkit [18949] by brmorris
  • 2 edits in S60/trunk/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
12:48 PM Changeset in webkit [22785] by andersca
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Improve wording.

12:44 PM Changeset in webkit [18948] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by John Sullivan.

  • Scripts/run-webkit-tests: Fix handling of configuration so it does the right thing when no explicit configuration is passed in. The old code assumed that the result of setConfiguration() was the configuration, but it's undefined when no configuration is explicitly passed in. The correct function to use is configuration(), and I also streamlined the code.
12:13 PM Changeset in webkit [18947] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.
DESC: Explicitly include avkon.loc in webkit.rss (AHUN-6X6PW3)

  • data/Webkit.rss:
12:11 PM Changeset in webkit [18946] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18870)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2007-01-15 raalexan <​rasvan.alexandrescu@nokia.com>
+
+ Reviewed by Yongjun Zhang.
+ DESC: Crashes in web pages with rss feeds like www.google.com/ig
+ ​http://bugs.webkit.org/show_bug.cgi?id=12289
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * khtml/xml/xml_tokenizer.cpp:
+ (khtml::createQStringParser):
+ (khtml::parseQString):

11:57 AM Changeset in webkit [22784] by andersca
  • 7 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Lou and Adam.

Dispatch all the right delegate methods.


  • Interfaces/IWebPolicyDelegate.idl: Add some definitions needed.


  • WebActionPropertyBag.cpp: Added. (WebActionPropertyBag::WebActionPropertyBag): (WebActionPropertyBag::~WebActionPropertyBag): (WebActionPropertyBag::createInstance): (WebActionPropertyBag::QueryInterface): (WebActionPropertyBag::AddRef): (WebActionPropertyBag::Release): (isEqual): (findMouseEvent): (WebActionPropertyBag::Read): (WebActionPropertyBag::Write):
  • WebActionPropertyBag.h: Added. New class which wraps a NavigationAction in a property bag.


  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::clearUnarchivingState): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidFailLoading):
  • WebFrame.h: Dispatch correct delegate methods.


  • WebKit.vcproj/WebKit.vcproj: Add WebActionPropertyBag files.


  • WebURLResponse.cpp: (WebURLResponse::createInstance): Return 0 for null responses.
11:54 AM Changeset in webkit [18945] by brmorris
  • 2 edits in S60/trunk/WebKit

2007-01-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.
DESC: Explicitly include avkon.loc in webkit.rss

  • data/Webkit.rss:
11:13 AM Changeset in webkit [18944] by mjs
  • 4 edits
    1 add in trunk/WebCore

Reviewed by John.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid nesting blocks in plaintext mode, since that's not an issue under normal circumstances.
  • html/HTMLInputElement.h:
  • manual-tests/drag-move-in-search-field.html: Added.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd rather truncate it than end up with an illegal value here.
10:47 AM Changeset in webkit [18943] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-17 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Secure icon shown in www.blogger.com and stays on afterwards
​http://bugs.webkit.org/show_bug.cgi?id=12303

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::HeadersL):
10:43 AM Changeset in webkit [18942] by spadma
  • 2 edits in S60/trunk/WebKit

2007-01-17 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Secure icon shown in www.blogger.com and stays on afterwards
​http://bugs.webkit.org/show_bug.cgi?id=12303

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::HeadersL):
9:23 AM Changeset in webkit [22783] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by John Sullivan

  • WebView.cpp: (WebView::searchFor): Build fix.
9:07 AM Changeset in webkit [18941] by hausmann
  • 2 edits in trunk/WebCore

parallel build fix

8:39 AM Changeset in webkit [18940] by darin
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin and Mitz.

  • fast/dom/HTMLImageElement/image-lowsrc-getset-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-lowsrc-getset.html: Added.

WebCore:

Reviewed by Darin and Mitz.

<rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)

Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html

  • html/HTMLAttributeNames.in: Added lowsrc.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc. (WebCore::HTMLImageElement::lowsrc): Added. (WebCore::HTMLImageElement::setLowsrc): Added.
  • html/HTMLImageElement.h: Added lowsrc and setLowsrc.
  • html/HTMLImageElement.idl: Added lowsrc.
8:32 AM Changeset in webkit [18939] by yongjzha
  • 3 edits in S60/trunk/WebCore

2007-01-14 sareen <​shyam.sareen@nokia.com>

Reviewed by Antti Kovisto.Browser
DESC: Browser - Form/The TC is not displayed, it's a white page displayed
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12269

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
  • khtml/html/htmltokenizer.h:
8:16 AM Changeset in webkit [18938] by yongjzha
  • 3 edits in S60/branches/3.1m/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18858)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2007-01-15 sareen <​shyam.sareen@nokia.com>
+
+ Reviewed by Antti Kovisto.Browser
+ DESC: Browser - Form/The TC is not displayed, it's a white page displayed
+ ​http://bugzilla.opendarwin.org/show_bug.cgi?id=12269
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * khtml/html/htmltokenizer.cpp:
+ (khtml::HTMLTokenizer::parseTag):
+ * khtml/html/htmltokenizer.h:

8:12 AM Changeset in webkit [18937] by yongjzha
  • 3 edits in S60/branches/3.1m/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by Yongjun Zhang <​yongjun.zhang@nokia.com>
DESC: [S60] TSW ID: AIYR-6W29Z7, Browser crashes when entered Hindi character in textbox as Search character in Search engine site.
​http://bugs.webkit.org/show_bug.cgi?id=12306

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::encoding):
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
8:03 AM Changeset in webkit [18936] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-18 sareen <​shyam.sareen@yahoo.com>

Reviewed by Yongjun.
DESC: Wrong rendering of danish national characters for UTF8 coded web pages.(TSW ID: TMCN-6UQNXY)

Additional fix.

​http://bugs.webkit.org/show_bug.cgi?id=12217

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (validateUtf8):
7:59 AM Changeset in webkit [18935] by yongjzha
  • 3 edits in S60/trunk/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=12306

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::encoding):
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
6:33 AM Changeset in webkit [18934] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-15 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Crashes in web pages with rss feeds like www.google.com/ig
​http://bugs.webkit.org/show_bug.cgi?id=12289

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/xml/xml_tokenizer.cpp: (khtml::createQStringParser): (khtml::parseQString):
5:00 AM Changeset in webkit [18933] by hausmann
  • 5 edits in trunk

fix make clean in the qt build to remove all generated files

2:04 AM Changeset in webkit [18932] by zack
  • 8 edits in trunk/WebKitQt

Implementing some load progress tracking in the Qt port.
Reviewed by Lars.

Note: See TracTimeline for information about the timeline view.