⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 20, 2007:

4:44 PM Changeset in webkit [19006] by weinig
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/text-set-value-crash-expected.txt: Added.
  • fast/forms/text-set-value-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/forms/text-set-value-crash.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Added a call to Document::updateRendering().
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Ditto.
4:35 PM Changeset in webkit [19005] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Added.
  • fast/layers/removed-by-scroll-handler-expected.png: Added.
  • fast/layers/removed-by-scroll-handler-expected.txt: Added.
  • fast/layers/removed-by-scroll-handler.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/layers/removed-by-scroll-handler.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::dispatchScrollEvent): Added. Called when the timer fires and dispatches the scroll event to the layer's element. (WebCore::RenderLayer::scrollToOffset): Instead of dispatching the scroll event from this function, which is called during layout, schedule a 0-duration timer to dispatch the event after layout. (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
3:45 PM Changeset in webkit [19004] by zimmermann
  • 1 edit
    12 adds in trunk/LayoutTests

Forgot to include the new layout tests in the last commit.

3:40 PM Changeset in webkit [19003] by zimmermann
  • 14 edits in trunk/WebCore

Reviewed by Sam.

Fix JS bindings for SVGAnimated{Boolean, Enumeration, Integer, Number, String}.

Dynamic SVG DOM updates (ie. "someUse.href.baseVal = '#rect'") with these types
didn't work. Existing gradient updating examples relied on calling setAttribute
after a SVG DOM update - that was the only reason it worked, added a new test
only using SVG DOM updates (js-update-stop.svg).

1:52 PM Changeset in webkit [19002] by rwlbuis
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12334
Respect <text> boundaries for svg text selecting

Make sure the text selection for svg stays inside
containing blocks.
Added one manual test since html selection does not
seem to work for SVG and selectSubString for SVG
is not implemented yet.

7:03 AM Changeset in webkit [19001] by darin
  • 27 edits
    88 adds in trunk/LayoutTests
  • updated results because my recent check-in made list boxes one pixel taller
  • fast/forms/HTMLOptionElement_label05-expected.checksum:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/listbox-clip-expected.checksum:
  • fast/forms/listbox-clip-expected.png:
  • fast/forms/listbox-clip-expected.txt:
  • fast/forms/listbox-width-change-expected.checksum:
  • fast/forms/listbox-width-change-expected.png:
  • fast/forms/listbox-width-change-expected.txt:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/select-change-popup-to-listbox-expected.checksum:
  • fast/forms/select-change-popup-to-listbox-expected.png:
  • fast/forms/select-change-popup-to-listbox-expected.txt:
  • fast/replaced/replaced-breaking-expected.checksum:
  • fast/replaced/replaced-breaking-expected.png:
  • fast/replaced/replaced-breaking-expected.txt:
  • fast/text/updateNewFont-expected.checksum:
  • fast/text/updateNewFont-expected.png:
  • fast/text/updateNewFont-expected.txt:
  • reset results since the ones I generated before were on Leopard
  • fast/forms/select-list-box-with-height-expected.checksum:
  • fast/forms/select-list-box-with-height-expected.png:
  • generated some missing pixel results
  • http/tests/navigation/anchor-basic-expected.checksum: Added.
  • http/tests/navigation/anchor-basic-expected.png: Added.
  • http/tests/navigation/anchor-frames-expected.checksum: Added.
  • http/tests/navigation/anchor-frames-expected.png: Added.
  • http/tests/navigation/anchor-goback-expected.checksum: Added.
  • http/tests/navigation/anchor-goback-expected.png: Added.
  • http/tests/navigation/anchor-subframeload-expected.checksum: Added.
  • http/tests/navigation/anchor-subframeload-expected.png: Added.
  • http/tests/navigation/error404-basic-expected.checksum: Added.
  • http/tests/navigation/error404-basic-expected.png: Added.
  • http/tests/navigation/error404-frames-expected.checksum: Added.
  • http/tests/navigation/error404-frames-expected.png: Added.
  • http/tests/navigation/error404-goback-expected.checksum: Added.
  • http/tests/navigation/error404-goback-expected.png: Added.
  • http/tests/navigation/error404-subframeload-expected.checksum: Added.
  • http/tests/navigation/error404-subframeload-expected.png: Added.
  • http/tests/navigation/javascriptlink-basic-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-basic-expected.png: Added.
  • http/tests/navigation/javascriptlink-frames-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • http/tests/navigation/javascriptlink-goback-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-goback-expected.png: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.png: Added.
  • http/tests/navigation/metaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/metaredirect-basic-expected.png: Added.
  • http/tests/navigation/metaredirect-frames-expected.checksum: Added.
  • http/tests/navigation/metaredirect-frames-expected.png: Added.
  • http/tests/navigation/metaredirect-goback-expected.checksum: Added.
  • http/tests/navigation/metaredirect-goback-expected.png: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.png: Added.
  • http/tests/navigation/post-basic-expected.checksum: Added.
  • http/tests/navigation/post-basic-expected.png: Added.
  • http/tests/navigation/post-frames-expected.checksum: Added.
  • http/tests/navigation/post-frames-expected.png: Added.
  • http/tests/navigation/post-goback1-expected.checksum: Added.
  • http/tests/navigation/post-goback1-expected.png: Added.
  • http/tests/navigation/post-goback2-expected.checksum: Added.
  • http/tests/navigation/post-goback2-expected.png: Added.
  • http/tests/navigation/postredirect-basic-expected.checksum: Added.
  • http/tests/navigation/postredirect-basic-expected.png: Added.
  • http/tests/navigation/postredirect-frames-expected.checksum: Added.
  • http/tests/navigation/postredirect-frames-expected.png: Added.
  • http/tests/navigation/postredirect-goback1-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback1-expected.png: Added.
  • http/tests/navigation/postredirect-goback2-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback2-expected.png: Added.
  • http/tests/navigation/redirect302-basic-expected.checksum: Added.
  • http/tests/navigation/redirect302-basic-expected.png: Added.
  • http/tests/navigation/redirect302-frames-expected.checksum: Added.
  • http/tests/navigation/redirect302-frames-expected.png: Added.
  • http/tests/navigation/redirect302-goback-expected.checksum: Added.
  • http/tests/navigation/redirect302-goback-expected.png: Added.
  • http/tests/navigation/redirect302-subframeload-expected.checksum: Added.
  • http/tests/navigation/redirect302-subframeload-expected.png: Added.
  • http/tests/navigation/relativeanchor-basic-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-basic-expected.png: Added.
  • http/tests/navigation/relativeanchor-frames-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-frames-expected.png: Added.
  • http/tests/navigation/relativeanchor-goback-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-goback-expected.png: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.png: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.png: Added.
  • http/tests/navigation/success200-basic-expected.checksum: Added.
  • http/tests/navigation/success200-basic-expected.png: Added.
  • http/tests/navigation/success200-frames-expected.checksum: Added.
  • http/tests/navigation/success200-frames-expected.png: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.png: Added.
  • http/tests/navigation/success200-goback-expected.checksum: Added.
  • http/tests/navigation/success200-goback-expected.png: Added.
  • http/tests/navigation/success200-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-loadsame-expected.png: Added.
  • http/tests/navigation/success200-reload-expected.checksum: Added.
  • http/tests/navigation/success200-reload-expected.png: Added.
  • http/tests/navigation/success200-subframeload-expected.checksum: Added.
  • http/tests/navigation/success200-subframeload-expected.png: Added.
  • http/tests/navigation/timerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/timerredirect-basic-expected.png: Added.
  • http/tests/navigation/timerredirect-frames-expected.checksum: Added.
  • http/tests/navigation/timerredirect-frames-expected.png: Added.
  • http/tests/navigation/timerredirect-goback-expected.checksum: Added.
  • http/tests/navigation/timerredirect-goback-expected.png: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.png: Added.
1:14 AM Changeset in webkit [19000] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Track the output of run-javascriptcore-tests, catch single regressions, and don't generate tests results for new tests.
12:45 AM Changeset in webkit [18999] by aroben
  • 2 edits in trunk/WebKitTools

Rubberstamped by Maciej.

  • Scripts/run-webkit-tests: Change the default behavior back to generating results for new tests (this can be disabled with --no-new-test-results)

Jan 19, 2007:

11:07 PM Changeset in webkit [18998] by aroben
  • 1 edit in branches/Safari-2-0-branch/WebKit/ChangeLog

Fixed ChangeLog.

7:21 PM Changeset in webkit [18997] by kdecker
  • 6 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Adam.


Merged r10259 and r15845 from TOT to Safari-2-0-branch.

2006-08-11 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

2005-09-13 Tim Omernick <​tomernick@apple.com>

Reviewed by Justin Garcia, Darin Adler.

  • <rdar://problem/3163393> Safari does not support Windowless mode in Flash
  • Plugins.subproj/WebBaseNetscapePluginView.h:

Added 'isTransparent' instance variable.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):

When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
region of the opaque ancestor. This means that a partially-transparent plugin, which
by definition does not clear its port on redraw, will not overdraw the valid parts
of its port.

(-[WebBaseNetscapePluginView sendEvent:]):

Disabled the "green debug background" for transparent plugins -- since they are not
expected to cover their entire port every redraw, this debug code makes no sense.

(-[WebBaseNetscapePluginView setVariable:value:]):

Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
unimplemented).
Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
plugin variables, then we may do so here.

  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:

Added SPI for -[WebBaseNetscapePluginView setVariable:value].

  • Plugins.subproj/npapi.m: (NPN_SetValue):

Implemented this function so that plugins may set state (such as window mode).


4:40 PM Changeset in webkit [18996] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

  • fast/forms/select-size-expected.checksum: Added.
  • fast/forms/select-size-expected.png: Added.
  • fast/forms/select-size-expected.txt: Added.
  • fast/forms/select-size.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

Update the size attribute value for select elements to match the numeric value. This is a special case since this
attribute is used to determine which control to use. We want to make sure that the size attribute is valid when we match
CSS rules.

Test: fast/forms/select-size.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the same as its integer value, then update the attribute value to match the integer.
  • dom/Attribute.h: Made setValue and setPrefix public.
4:33 PM Changeset in webkit [22799] by adachan
  • 4 edits
    1 add in branches/WindowsMerge/WebKitWin

2007-01-19 Ada Chan <​adachan@apple.com>

WebKitWin:

Fixed build.

Reviewed by Anders.
Added IWebResourceLoadDelegatePrivate which has one method: didLoadResourceFromMemoryCache.

  • ChangeLog:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl: Added.
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:


4:32 PM Changeset in webkit [18995] by aroben
  • 3 edits in trunk/WebKit

Reviewed by Beth.

Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
"Font", "Speech", and "Writing Direction" are missing from contextual
menu

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusForOldClients): Change our new SPI tags to WebMenuItemTagOther because old clients aren't expecting the new tags. (fixMenusFromOldClients): Use each menu item's title to figure out its correct tag again. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call fixMenusForOldClients before calling up to the delegate.
  • WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so that we can use it in WebContextMenuClient.
4:14 PM Changeset in webkit [22798] by sullivan
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.


Added mechanism for new callbacks, to try to avoid breaking the Windows build.

  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebFrame.h:
4:02 PM Changeset in webkit [18994] by sullivan
  • 13 edits in trunk

WebCore:

Reviewed by Darin

  • WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in
  • loader/FrameLoaderClient.h: new dispatchDidFinishDocumentLoad call
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): call dispatchDidFinishDocumentLoad


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishDocumentLoad): empty implementation for dispatchDidFinishDocumentLoad

WebKit:

Reviewed by Darin

  • WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in


Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up

  • WebView/WebViewPrivate.h: declare new delegate method
  • WebCoreSupport/WebFrameLoaderClient.h: declare dispatchDidFinishDocumentLoad()
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): new method, calls new delegate method
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): empty default implementation of new delegate method

WebKitQt:

Added stubs for new callbacks, to try to avoid breaking the Qt port.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
  • WebCoreSupport/FrameLoaderClientQt.h:
3:48 PM Changeset in webkit [18993] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php

  • fast/forms/control-restrict-line-height-expected.checksum: Added.
  • fast/forms/control-restrict-line-height-expected.png: Added.
  • fast/forms/control-restrict-line-height-expected.txt: Added.
  • fast/forms/control-restrict-line-height.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php


Test: fast/forms/control-restrict-line-height.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that have restricted font size.
3:18 PM Changeset in webkit [18992] by andersca
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

​http://bugs.webkit.org/show_bug.cgi?id=12308
REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Move code from initWithFrame in here.
3:15 PM Changeset in webkit [18991] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix date.

3:15 PM Changeset in webkit [18990] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug number.

3:12 PM Changeset in webkit [18989] by darin
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test for html4.css problem where we had a missing semicolon and thus missed parsing a style rule
  • fast/forms/radio-no-theme-padding-expected.txt: Added.
  • fast/forms/radio-no-theme-padding.html: Added.
  • fast/forms/select-list-box-mouse-focus-expected.txt: Added.
  • fast/forms/select-list-box-mouse-focus.html: Added.

Note: Only the pixel test shows the failure in the old version.

Note: I generated the pixel results on Leopard -- may need to be
regenated on Tiger.

  • fast/forms/select-list-box-with-height-expected.checksum: Added.
  • fast/forms/select-list-box-with-height-expected.png: Added.
  • fast/forms/select-list-box-with-height-expected.txt: Added.
  • fast/forms/select-list-box-with-height.html: Added.

WebCore:

Reviewed by Adele.

  • fix ​http://bugs.webkit.org/show_bug.cgi?id=11999 <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999) Fix was to use the actual size of the renderer in the RenderListBox case, instead of always using the size specified by the select element.

Test: fast/forms/select-list-box-with-height.html

Test: fast/forms/select-list-box-mouse-focus.html

  • fix bug where auto-scrolling was not working in list box select elements

No test yet.

  • fix a missing semicolon in the radio/checkbox section of html4.css

Test: fast/forms/radio-no-theme-padding.html

  • fix bug where the scroll bars for select elements were pixel-type scroll bars even though the scrolling is line at a time scrolling

No test.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Removed an explicit call to repaint, since the RenderListBox now does that in selectionChanged. (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new selectionChanged instead of the old setSelectionChanged. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call to focus. Removed an explicit call to repaint and added a call to the new setMouseDownMayStartAutoscroll function in EventHandler. Removed an explicit call to repaint as above. (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new selectionChanged instead of the old setSelectionChanged.
  • page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed because the existing code to set that flag won't get triggered when the select element's default event handler handles the event.
  • rendering/RenderListBox.h: Made ScrollbarClient a private base class. Removed setSelectionChanged and m_selectionChanged. Added selectionChanged, which is really just a synonym for repaint for now. Moved valueChanged, the ScrollbarClient function implementations, and itemHeight into the private part of the class. Added numVisibleItems() and listHeight() to the private section. Changed m_vBar to be a RefPtr.
  • rendering/RenderListBox.cpp: Removed unneeded includes. Moved all the constants to the top of the file. (WebCore::RenderListBox::RenderListBox): Removed initialization of m_selectionChanged because it was removed and of m_vBar because it's now a RefPtr which is automaticall initialized. (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of m_vBar because it's a RefPtr. Added null checking for FrameView. (WebCore::RenderListBox::updateFromElement): Use numItems(). (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for FrameView and used RefPtr for the newly-created scroll bar. (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the misleading minDefaultSize to maxDefaultSize, since it's a maximum. (WebCore::RenderListBox::numVisibleItems): Added. Used in many places where size() was used before. This computes the number of rows we have room for. We don't need a row space after the last row, and this takes that into account. (WebCore::RenderListBox::numItems): Tweaked to remove the local variable. (WebCore::RenderListBox::listHeight): Added. Total height of all the rows and spaces between them. (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the row height, and to subtract the last row spacing off since we don't need a space after the last row. Changed the scroll bar setup to make it correspond to row numbers, not pixel numbers. (WebCore::RenderListBox::baselinePosition): Moved the comment to the constant declaration at the top of the file. (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using the itemHeight() function. (WebCore::RenderListBox::paintObject): Changed to use numItems and to use numVisibleItems instead of size. (WebCore::RenderListBox::isPointInScrollbar): Added get() call since m_vBar is now a RefPtr. (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(), itemHeight(), and rearranged a min/max combo so it starts with the low, then the value, then the high value for pinning. (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of size(). (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check of the element. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed to use numItems() and to use numVisibleItems() instead of size(). Also changed scroll bar code to work more simply now that the scroll bar is row-based. (WebCore::RenderListBox::listIndexIsVisible): Changed to use numVisibleItems() instead of size(). (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar is now row-based. Also removed an unnecessary null check. (WebCore::RenderListBox::itemHeight): Updated for name change from optionsSpacingMiddle to rowSpacing. (WebCore::RenderListBox::scrollHeight): Changed to use listHeight(). (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code that does nothing if the computed list index is visible (which did not make sense for this function and seemed a cut and paste error from the scrollToReveal function). The scrollbar part is simpler now that it's row-based. (WebCore::RenderListBox::windowClipRect): Changed to use document()->view() so we don't have to include RenderView.h.
  • css/html4.css: Added a semicolon I noticed was missing.
2:36 PM Changeset in webkit [22797] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

Much more realistic WebDownload interface that delegates will actually have to implement


  • Interfaces/IWebDownload.idl:

Also updated svn:eol-style on .idls

1:57 PM Changeset in webkit [18988] by bdakin
  • 8 edits
    8 adds
    4 deletes in trunk

WebCore:

Reviewed by Maciej and Darin.

Fix for <rdar://problem/4702420> REGRESSION: Null characters need
to be stripped from text nodes (townhall.com)

This was a regression from the fix for <rdar://problem/3727939>
Safari strips \0 characters from HTML tags making them valid, which
was fixed with r12652. We still need to strip null characters in
text nodes.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): No behavior change here, this is just to make Darin happy. (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new createStrippingNull function instead of the normal StringImpl constructor.
  • platform/StringImpl.cpp: (WebCore::StringImpl::createStrippingNull): Strip null.
  • platform/StringImpl.h:

LayoutTests:

Reviewed by Maciej and Darin.

New layout tests and some updates results for the fix for <rdar://
problem/4702420> REGRESSION: Null characters need to be stripped
from text nodes (townhall.com)

  • fast/dom/stripNullFromTextNodes-expected.checksum: Added.
  • fast/dom/stripNullFromTextNodes-expected.png: Added.
  • fast/dom/stripNullFromTextNodes-expected.txt: Added.
  • fast/dom/stripNullFromTextNodes.html: Added.
  • fast/js/null-char-in-string-expected.txt: New results.
  • fast/text/stripNullFromText-expected.checksum: Added.
  • fast/text/stripNullFromText-expected.png: Added.
  • fast/text/stripNullFromText-expected.txt: Added.
  • fast/text/stripNullFromText.html: Added.
  • tables/mozilla/images/adforce_imgis_com-expected.txt: New results.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.checksum: Removed. This is the same test as the one above. The same test was in two places.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.png: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.txt: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com.html: Removed.
1:16 PM Changeset in webkit [18987] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.
12:47 PM Changeset in webkit [22796] by adachan
  • 10 edits
    2 adds in branches/WindowsMerge

2007-01-18 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


WebKitWin:

<rdar://4601522> Activity Window

  • Added some NSURL equivalent constants in IWebURLResponse.idl and IWebError.idl
  • Added IWebErrorPrivate.idl which contains some private error codes
  • Added IWebHTTPURLResponse interface which extends IWebURLResponse. It has the same API as NSHTTPURLResponse.

WebCoreWin:

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • Interfaces/IWebError.idl:
  • Interfaces/IWebErrorPrivate.idl: Added.
  • Interfaces/IWebHTTPURLResponse.idl: Added.
  • Interfaces/IWebResourceLoadDelegate.idl: fixed a typo in parameter name
  • Interfaces/IWebURLResponse.idl: added WebURLResponseUnknownLength
  • WebKit.vcproj/Interfaces.vcproj: for adding IWebErrorPrivate.idl and IWebHTTPURLResponse.idl
  • WebKit.vcproj/WebKitGUID.vcproj: for the new IID_IWebHTTPURLResponse
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): also returns the new IWebHTTPURLResponse interface (WebURLResponse::allHeaderFields): Added stub for IWebHTTPURLResponse::allHeaderFields. (WebURLResponse::localizedStringForStatusCode): Added stub for IWebHTTPURLResponse::localizedStringforStatusCode (WebURLResponse::statusCode): Implemented IWebHTTPURLResponse::statusCode.
  • WebURLResponse.h:


10:25 AM Changeset in webkit [18986] by andersca
  • 3 edits in trunk/WebKit

Yet another build fix.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
10:12 AM Changeset in webkit [22795] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add SVG files.
9:59 AM Changeset in webkit [18985] by andersca
  • 3 edits in trunk/WebKitQt

Try fixing the QT build.


  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::setStatusbarText):
  • WebCoreSupport/ChromeClientQt.h:
9:58 AM Changeset in webkit [22794] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::enabled): Use correct class name.
9:52 AM Changeset in webkit [18984] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::setStatusbarText):
9:42 AM Changeset in webkit [22793] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

The obligatory build fix.


  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
9:38 AM Changeset in webkit [22792] by andersca
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Remove some unused FrameWin functions.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusbarText):
  • WebChromeClient.h: Add new ChromeClient methods.


  • WebFrame.cpp: (WebFrame::userAgent): (WebFrame::updateGlobalHistoryForReload):
  • WebFrame.h: Remove unused FrameWinClient functions.
9:28 AM Changeset in webkit [18983] by andersca
  • 15 edits in trunk

WebCore:

Reviewed by Adam.

Move JavaScript alert and status bar functions to the chrome.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • page/Chrome.cpp: (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusBarText):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText):
  • page/Frame.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::runJavaScriptAlert): (WebCore::SVGEmptyChromeClient::runJavaScriptConfirm): (WebCore::SVGEmptyChromeClient::runJavaScriptPrompt): (WebCore::SVGEmptyChromeClient::setStatusBarText):

WebKit:

Reviewed by Adam.

Move functions from the bridge to the chrome client.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusBarText):
  • WebCoreSupport/WebFrameBridge.mm:
8:02 AM Changeset in webkit [18982] by zack
  • 2 edits in trunk/WebCore

Fix the build

6:27 AM Changeset in webkit [18981] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

More cleanup to SVGAnimated* classes.

No tests possible (only code cleanup)

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseBeginOrEndValue): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::isIndefinite):
  • ksvg2/svg/SVGAnimationElement.h:
6:09 AM Changeset in webkit [18980] by zimmermann
  • 2 edits in trunk/WebCore

Not reviewed.
Remove accidently commited debug output. Shame on me :-)

6:03 AM Changeset in webkit [18979] by zimmermann
  • 44 edits
    31 adds in trunk

Reviewed by Eric.

Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
AFAIK we're the first implementing this SVG feature - after ASV3 (!).

5:42 AM Changeset in webkit [18978] by eseidel
  • 5 edits
    2 adds in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Add support for SVGMPathElement parsing.

No test cases possible (SVGAnimateMotion doesn't work yet)

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • ksvg2/svg/SVGMPathElement.cpp: Added. (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::~SVGMPathElement): (WebCore::SVGMPathElement::parseMappedAttribute): (WebCore::SVGMPathElement::pathElement):
  • ksvg2/svg/SVGMPathElement.h: Added.
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): fix typo in comment
  • ksvg2/svg/svgtags.in: add back mpath
4:59 AM Changeset in webkit [18977] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Implement better parsing for keyTimes, keySplines and keyPoints.

Unfortunately none of this code is used much yet, thus isn't very testable.

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse):
2:09 AM Changeset in webkit [18976] by lars
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

run-webkit-tests does now not generate new results by default anymore.
You'll have to pass the --new-tests flag to it to force it to do so.

This is required to make it possible to have tests running on multiple
platforms peacefully together.

Note: See TracTimeline for information about the timeline view.