⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 22, 2007:

11:00 PM Changeset in webkit [22813] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Implemented search field painting, and did some cleanup.

8:00 PM Changeset in webkit [19038] by bdash
  • 2 edits in trunk/WebCore

2007-01-22 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11692
Bug 11692: REGRESSION(r17352): Disappearing page title

  • dom/Document.cpp: (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript, ignore any changes to it due to encountering <title> tags.
6:23 PM Changeset in webkit [22812] by andersca
  • 6 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.


<rdar://problem/4771115>
Windows Media Player plugin crashes.

  • WebCore.vcproj/WebCore.vcproj: Formatting changes.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add Windows Media Player path.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream):
  • plugins/win/PluginStreamWin.h: New function which sends a JavaScript result stream and handles any errors that the plug-in returns.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): Always call NPP_SetWindow, some plugins (like WMP) relies on it.


(WebCore::PluginViewWin::performRequest):
If a plug-in requests a javascript: URL that doesn't evaluate to a string, call toString on it.
The Windows Media Player plugin calls javascript:document.location and expects to get the location back.

5:36 PM Changeset in webkit [19037] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/listbox-selection-2-expected.checksum: Added.
  • fast/forms/listbox-selection-2-expected.png: Added.
  • fast/forms/listbox-selection-2-expected.txt: Added.
  • fast/forms/listbox-selection-2.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/listbox-selection-2.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::numVisibleItems): Changed height() to contentHeight() since items are visible only in the content box. (WebCore::RenderListBox::listIndexAtOffset): Adjusted for vertical padding and borders. Changed to return -1 instead of the last item's index if the given offset is below the last item. (WebCore::RenderListBox::autoscroll): Adjusted for vertical padding and borders. (WebCore::RenderListBox::controlClipRect): Changed to return the content box since items should not spill into the padding box. This change is the reason the test generates pixel results.
5:30 PM Changeset in webkit [19036] by justing
  • 15 edits
    11 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)

The fixes not only make this test pass, but also fix a bug that
was reflected in the results checked in for this test. The caret
was in the wrong position:

  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt: Added:
  • editing/pasteboard/4944770-1-expected.checksum: Added.
  • editing/pasteboard/4944770-1-expected.png: Added.
  • editing/pasteboard/4944770-1-expected.txt: Added.
  • editing/pasteboard/4944770-1.html: Added.
  • editing/pasteboard/4944770-2-expected.checksum: Added.
  • editing/pasteboard/4944770-2-expected.png: Added.
  • editing/pasteboard/4944770-2-expected.txt: Added.
  • editing/pasteboard/4944770-2.html: Added.
  • editing/pasteboard/4944770-expected.checksum: Added.
  • editing/pasteboard/4944770-expected.png: Added.
  • editing/pasteboard/4944770-expected.txt: Added. Equivalent render trees:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt: Fixed:
  • editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)


This layout test failure demonstrates three bugs:
Smart replace shouldn't be turned on, but is because a word
selection granularity from the previous test isn't cleared.
Smart replace shouldn't add any spaces because the paste is performed
in an empty paragraph.
Smart replace spaces are added to the text of options inside
the select element instead of before/after the select element.


This patch fixes the second two problems. During a
ReplaceSelectionCommand, the VisiblePosition for the end of
the inserted content is the last position in the last leaf
inserted. This is a problem when the last leaf is inside a
select element, since VP creation is inconsistent there.
Second, smart spaces were inserted inside the last leaf, not
at the endOfInsertedContent.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Renamed m_lastNodeInserted to m_lastLeafInserted. Use the start/endOfInsertedContent getters. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Ditto. (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Ditto. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Ditto. (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Added. Special case for when the last leaf inserted is inside a select element: return the VisiblePosition after the select element. (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Added. (WebCore::ReplaceSelectionCommand::doApply): Did renaming. Used the start/endOfInsertedContent getters. Insert smart replace spaces into the right nodes. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renaming. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto. (WebCore::ReplaceSelectionCommand::updateNodesInserted): Ditto.
  • editing/ReplaceSelectionCommand.h:
4:51 PM Changeset in webkit [22811] by darin
  • 3 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Added FileChooser.cpp.
  • platform/win/FileChooserWin.cpp: Removed many now-unneeded functions. (WebCore::FileChooser::FileChooser): Updated for changed parameters and members. (WebCore::FileChooser::openFileChooser): Changed to take document parmaeter and find the FrameView from that instead of the upload control. (WebCore::FileChooser::basenameForWidth): Added ignored Font parameter.
4:46 PM Changeset in webkit [22810] by aroben
  • 9 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders, Brady, and Steve.

WebKit part of <rdar://problem/4601321> HTTP Authentication Alerts

Made WebURLCredential use a registered CLSID so the app can get instantiate it:

  • Interfaces/IWebURLAuthenticationChallenge.idl: Changed method name.
  • Interfaces/WebKit.idl: Added GUIDs for WebURLCredential.
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added case for WebURLCredential.
  • WebKitDLL.cpp: Added WebURLCredential and WebError (it was omitted from r11821). (DllGetClassObject):
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Changed to use CLSID, and return the failing HRESULT. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Changed to return the failing HRESULT.
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::useCredential): Ditto.
  • WebURLCredential.cpp: Removed IID definition. (WebURLCredential::QueryInterface): Switched to use CLSID. (WebURLCredential::initWithUser): Updated method name.
  • WebURLCredential.h: Ditto.
4:40 PM Changeset in webkit [19035] by darin
  • 11 edits
    1 add in trunk/WebCore

Reviewed by Adam.

  • made more of the file chooser code cross-platform
  • fixed an Objective-C garbage collection problem in FileChooser
  • tried to remove layering violations where FileChooser in the platform directory knows about the rendering and DOM trees (but wasn't able to do it entirely)
  • platform/FileChooser.cpp: Added. (WebCore::FileChooser::create): Changed parameters. (WebCore::FileChooser::chooseFile): Changed to call chooseIcon function. (WebCore::FileChooser::chooseIcon): Added.
  • platform/FileChooser.h: Added FileChooserClient so this file doesn't have to know about RenderFileUploadControl. Used RetainPtr instead of retain/release so this works properly with Objective-C GC. Replaced disconnectUploadControl with disconnectClient, which has a simple inline implementation. Moved the Document parameter from the constructor to openFileChooser, along with a comment about why it should not be there. Added a filename parameter to the constructor for the initial filename. Added a font parameter to basenameForWidth so we don't depend on having a pointer to the renderer. Removed the uploadControl() and document() functions since no one calls either of them.
  • platform/mac/FileChooserMac.mm: Removed code that is now cross-platform. (-[OpenPanelController beginSheetWithFrame:]): Added frame parameter, instead of storing a document pointer in the FileChooser. (WebCore::FileChooser::FileChooser): Updated for changed parameters. Also added code to choose the icon based on the initial filename. Pass the adopt parameter to the constructor of the RetainPtr. (WebCore::FileChooser::~FileChooser): Removed the release call, since the RetainPtr will take care of it. Added a call to disconnectFileChooser here. There's no need to disconnect at disconnectClient time, and that lets us have one more cross-platform function. (WebCore::FileChooser::openFileChooser): Added document parameter. Added code to get the frame from the document. And added a nil check since there's no ironclad guarantee the document won't have outlived its frame. (WebCore::FileChooser::basenameForWidth): Added font parameter. Use that instead of going at the upload control's style. The caller can handle that now.
  • rendering/RenderFileUploadControl.h: Removed unnecessary includes. Made class inherit privately from FileChooserClient. Changed constructor parameter to HTMLInputElement rather than Node. Made protected members be private instead, and made a couple function members const.
  • rendering/RenderFileUploadControl.cpp: Moved constants to the top of the file, but after the "using namespace" (WebCore::RenderFileUploadControl::RenderFileUploadControl): Updated for changes to the FileChooser::create function and the parameter types. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed unneeded null check -- there's no case where the FileChooser fails to be created. (WebCore::RenderFileUploadControl::click): Pass document to openFileChooser. (WebCore::RenderFileUploadControl::updateFromElement): Tweaked code a bit by using updateFromElement and setValue instead of casting the renderer to a RenderButton and calling setText directly. Put setInputType call here. (WebCore::RenderFileUploadControl::maxFilenameWidth): Made const. Broke long line. (WebCore::RenderFileUploadControl::createButtonStyle): Made const. (WebCore::RenderFileUploadControl::paintObject): Moved buttonShadowHeight constant to the top of the file. Call isEmpty instead of checking width and height of IntRect for 0. Computed font to pass to FileChooser::basenameForWidth. Broke long lines. (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): Moved the setInputType call to the caller; concept here is that this class is as simple as possible, rather than doing as much of the button job as possible.
  • WebCore.xcodeproj/project.pbxproj: Added FileChooser.cpp.
  • WebCore.pro: Ditto.
  • CMakeLists.txt: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/gdk/TemporaryLinkStubs.cpp: Updated stubs.
  • platform/qt/FileChooserQt.cpp: Updated stubs.
3:39 PM Changeset in webkit [22809] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-22 Steve Falkenburg <​sfalken@apple.com>

Updated strings not to be localized, added native line endings svn flag.

2:51 PM Changeset in webkit [19034] by bdakin
  • 5 edits in trunk/LayoutTests

Reviewed by Darin.

Darin and I looked into these tests that are adding an empty
RenderText, and we think they just need new results. Here they are!

  • editing/execCommand/find-after-replace-expected.txt:
  • fast/css/beforeSelectorOnCodeElement-expected.txt:
  • fast/forms/control-restrict-line-height-expected.txt:
  • fast/forms/select-size-expected.txt:
1:46 PM Changeset in webkit [22808] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4903230>
Boomer crashes at Flickr website when "View as slideshow" is clicked.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): Return null if m_plugin is null (which it can be if the plugin failed to load).
1:37 PM Changeset in webkit [19033] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-item-background-clip-expected.checksum: Added.
  • fast/forms/select-item-background-clip-expected.png: Added.
  • fast/forms/select-item-background-clip-expected.txt: Added.
  • fast/forms/select-item-background-clip.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-item-background-clip.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemBackground): Intersect the item's rect with the list box's clip rect.
1:28 PM Changeset in webkit [19032] by sullivan
  • 2 edits in trunk/WebKit
  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Tiger build fix: remove unused variable for return value of dictionaryServiceWindowShow
1:15 PM Changeset in webkit [19031] by darin
  • 2 edits in trunk/WebCore

Reviewed by Beth.

I caused this a few hours ago. Oops!

  • rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Compute whether the font changed before calling RenderObject::setStyle.
1:09 PM Changeset in webkit [19030] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Adam and Darin

  • fixed <rdar://problem/4794320> "Look Up in Dictionary" does nothing in WebKit (need to adopt new API)
  • Misc/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): random typo correction in comment
  • English.lproj/StringsNotToBeLocalized.txt: updated for these changes
  • WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): new function to convert an AppKit screen point to a CG screen point (-[WebHTMLView _lookUpInDictionaryFromMenu:]): on Leopard now uses new API. There's something of an impedance mismatch between this API and WebKit, but that was true for the SPI we were using in Tiger also. Bug 4945808 covers the ways in which this is not perfect.
1:01 PM Changeset in webkit [22807] by andersca
  • 10 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

  • Interfaces/IWebError.idl: Clean up the IWebError interface.


  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Make it possible for clients to create WebErrors.


  • WebError.cpp: (WebError::QueryInterface): (WebError::init):
  • WebError.h:
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Get rid of IID_WebError and use CLSID_WebError instad.


  • WebView.cpp: (WebView::canHandleRequest): Return true for "about" URLs.


(WebView::canHandleRequest):
Add private COM method.


(WebView::close):
Reset the policy delegate.

12:54 PM Changeset in webkit [19029] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4912129> REGRESSION: Crash occurs at
WebCore::Frame::eventHandler() after clicking to dismiss a
contextual menu on the page

  • page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Added nil-check.
10:42 AM Changeset in webkit [22806] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
10:10 AM Changeset in webkit [22805] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Moved ifdefs to match Darin's suggestion.

9:39 AM Changeset in webkit [19028] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Mitz.

  • a couple tiny tweaks to make --reset-results work better
  • Scripts/run-webkit-tests: Always generate results when --reset-results is specified. Don't make a separate "new" entry while generating results when --reset-results is specified since new results are the norm in that case.
9:30 AM Changeset in webkit [22804] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

9:28 AM Changeset in webkit [19027] by darin
  • 28 edits
    8 adds in trunk

LayoutTests:

Test by Andrew Wellington <​proton@wiretapped.net>.
Reviewed by Darin.


  • fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
  • fast/css/beforeSelectorOnCodeElement.html: Added.

Test by Mitz.
Reviewed by Darin.

  • test for monospace problem mentioned in the above bug


  • fast/text/monospace-width-cache-expected.checksum: Added.
  • fast/text/monospace-width-cache-expected.png: Added.
  • fast/text/monospace-width-cache-expected.txt: Added.
  • fast/text/monospace-width-cache.html: Added.

WebCore:

Reviewed by Mitz.

Inspired by a much simpler patch by Andrew Wellington <​proton@wiretapped.net>.

Test: fast/css/beforeSelectorOnCodeElement.html

  • fix regression I recently introduced where the monospace cache could be used for text that was not ASCII, if text was changed after the style was set

Test: fast/text/monospace-width-cache.html

  • streamline RenderText.h -- remove unneeded functions, make some needlessly virtual functions non-virtual, remove unneeded header includes, replace use of Font* with Font& for consistency with RenderStyle, use "text" consistently instead of "string"
  • rendering/RenderText.h: Removed unneeded include of "Text.h", declarations of SOFT_HYPHEN, DocumentMarker, InlineBox, Position, String. Got rid of friend declaration for InlineTextBox. Changed constructor to take a PassRefPtr since we do take owership of the passed-in text. Made deleteTextBoxes() private. Removed unneeded data(). Made override of length() private so people will use the faster textLength() instead. Renamed string() to text() so it matches up better with setText(). Same for stringLength(), originalString(), and setInternalString(), which are now textLength(), originalText(), and setTextInternal(). Renamed the old text() function to characters(), since it returns a pointer as StringImpl::characters does. Changed Font* to Font& everywhere. Renamed the internal calcMinMaxWidth() function to calcMinMaxWidthInternal() and made it non-virtual since it's not overriden anywhere. Also made the trimmedMinMaxWidth() function non-virtual. Made containsOnlyWhitespace() private. Removed both font() functions (one was needlessly virtual) and element(). Renamed cacheWidths() to updateMonospaceCharacterWidth() and removed the shouldUseMonospaceCache() function. Renamed allAscii() to isAllASCII() and made it an inline function. Removed the m_allAsciiChecked flag and renamed the m_allAscii flag to m_isAllASCII.
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Removed initialization of m_allAsciiChecked. Initialize m_isAllASCII. Changed all occurrences of m_str->length() and m_str->characters () to use the stringLength() and characters() inline functions instead. (WebCore::RenderText::setStyle): Replaced the unconditional call to cacheWidths with a conditional call to updateMonospaceCharacterWidth. This speeds up the common case where style is changed without changing the font. (WebCore::RenderText::originalText): Changed code to not depend on overridden element() function with casts to a Text node -- this was one of only two call sites. Also renamed. (WebCore::RenderText::positionForCoordinates): Name change. (WebCore::RenderText::caretRect): Ditto. (WebCore::RenderText::updateMonospaceCharacterWidth): Renamed from cacheWidths and incorporate the check that was formerly in a separate shouldUseMonospaceCache function. (WebCore::RenderText::widthFromCache): Changed to take a Font& instead of Font*. Changed to take advantage of the fact that the string is known to be all ASCII in the m_monospaceCharacterWidth code path. (WebCore::RenderText::trimmedMinMaxWidth): Ditto. Also use style()->font() instead of font(false). (WebCore::RenderText::calcMinMaxWidth): Ditto. Also changed to use softHyphen instead of SOFT_HYPHEN. (WebCore::RenderText::containsOnlyWhitespace): More of the same. (WebCore::RenderText::setSelectionState): Ditto. (WebCore::RenderText::setTextWithOffset): Ditto. (WebCore::isInlineFlowOrEmptyText): Ditto. (WebCore::RenderText::setTextInternal): Updated for name changes. Also changed to set the m_isAllASCII flag every time, in the more-efficient way we use elsewhere (or'ing all the characters together), and to call updateMonospaceCharacterWidth if the "all ASCII"-ness of the text changes. (WebCore::RenderText::setText): Updated for name changes. (WebCore::RenderText::width): More like above. (WebCore::RenderText::selectionRect): Ditto. (WebCore::RenderText::caretMaxOffset): Ditto. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.
  • dom/Position.cpp:
  • dom/Range.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/VisiblePosition.cpp:
  • html/HTMLElement.cpp: Added now-needed include of "Text.h" which is no longer included by "RenderText.h".
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Update for name changes of stringLength(), string(), and originalString() to textLength(), text(), and originalText(), and to always use textLength() instead of length() when we have a RenderText* rather than a RenderObject*.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto. (WebCore::endOfParagraph): Ditto.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto. Also removed use of the RenderObject::font() function and replaced it with explicit access to the style. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): Ditto. (WebCore::InlineTextBox::isLineBreak): Ditto. (WebCore::InlineTextBox::paint): Ditto. (WebCore::InlineTextBox::selectionStartEnd): Ditto. (WebCore::InlineTextBox::paintSelection): Ditto. (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::offsetForPosition): Ditto. (WebCore::InlineTextBox::positionForOffset): Ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Ditto.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::originalText): Ditto. (WebCore::RenderCounter::calcMinMaxWidth): Ditto.
  • rendering/RenderCounter.h: Ditto.
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): Ditto.
  • rendering/RenderTextFragment.h: Ditto.
  • rendering/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): Ditto. (WebCore::placeBoxesVerticallyWithAbsBaseline): Ditto.
  • rendering/bidi.cpp: (WebCore::BidiIterator::increment): Ditto. (WebCore::BidiIterator::current): Ditto. (WebCore::BidiIterator::direction): Ditto. (WebCore::addRun): Ditto. (WebCore::checkMidpoints): Ditto. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto. (WebCore::RenderBlock::skipWhitespace): Ditto. (WebCore::RenderBlock::findNextLineBreak): Ditto.
  • rendering/RenderBR.h: Updated signature of width function which now takes a Font& instead of a Font*.
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Updated to no longer use the RenderObject::font() function, and added a comment about first-line, which is not handled properly here.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun): Eliminated use of RenderText::data().
  • rendering/RenderObject.h: Removed RenderObject::font(). This had the bad effect of having everyone pass in a boolean rather than using the cleaner style() and firstLineStyle() functions in cases where there's no a firstLineStyle boolean.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition): Replaced use of RenderObject::font() with direct use of the style instead, which is arguably easier to understand anyway. (WebCore::RenderObject::baselinePosition): Ditto.
6:38 AM Changeset in webkit [19026] by weinig
  • 3 edits
    1 move in trunk/WebCore

Reviewed by The Mitz.

Move JSHTMLSelectElementCustom.cpp from bindings to bindings/js
where it belongs.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/JSHTMLSelectElementCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.cpp: Added.
2:54 AM Changeset in webkit [19025] by zack
  • 2 edits in trunk/WebCore

Fix Qt build

Jan 21, 2007:

10:54 PM Changeset in webkit [22803] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Implemented drawing button states and control sizes.

9:23 PM Changeset in webkit [19024] by ap
  • 54 edits
    3 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10934
REGRESSION: prototype.js logs error (HTMLFormElement) on webkit builds

Added constructors for most HTML elements; started auto-generating HTMLSelectElement JS binding.

Test: fast/dom/Window/element-constructors-on-window.html

  • DerivedSources.make: Generate JSHTMLSelectElement.
  • WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElement{Custom}.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: Create a proper binding for SELECT.
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Removed everything related to SELECT. Renamed getHTMLOptionsCollection to toJS for autogenerated code to be happy, and rewrote it using cacheDOMObject.
  • bindings/scripts/CodeGeneratorJS.pm: Added HTMLElement to the list of types that cannot fail conversion.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl: Generate constructors.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::length):
  • html/HTMLSelectElement.h: Make length() return unsigned for auto-generated code to be happy.
  • html/HTMLSelectElement.idl: Adjusted to be usable for JS.
  • bindings/JSHTMLSelectElementCustom.cpp: Added. Implements remove().
  • page/DOMWindow.idl: Added properties for most elements' constructors.
8:54 PM Changeset in webkit [22802] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

7:45 PM Changeset in webkit [19023] by bdash
  • 2 edits in trunk/WebCore

2007-01-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12357
Bug 12357: Reproducible crash in WebCore::Settings::isJavaScriptEnabled in svg/custom/js-update-bounce.svg under guard-malloc

  • page/Frame.cpp: (WebCore::Frame::~Frame): Access the global object directly rather than via Window::retrieveWindow to prevent our reference to a deleted settings object being used.
6:46 PM Changeset in webkit [19022] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4930503> REGRESSION: Page changes title when command-clicking on named anchor link (12299)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Return if shouldContinue is false. This matches the other similar functions and prevents us from doing extra work in the "ignore" case.
6:16 PM Changeset in webkit [19021] by bdash
  • 2 edits in trunk/WebCore

2007-01-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12355
Bug 12355: Reproducible crash in WebCore::parseNumber in svg/custom/js-update-bounce.svg under guard-malloc

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::parseNumber): Parenthesize to prevent reading past end of buffer.
5:41 PM Changeset in webkit [22801] by adele
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Adding RenderThemeSafari.


5:33 PM Changeset in webkit [19020] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-disabled-appearance-expected.checksum: Added.
  • fast/forms/select-disabled-appearance-expected.png: Added.
  • fast/forms/select-disabled-appearance-expected.txt: Added.
  • fast/forms/select-disabled-appearance.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-disabled-appearance.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle):
5:17 PM Changeset in webkit [19019] by darin
  • 4 edits in trunk/WebCore
  • fix non-Mac builds
  • CMakeLists.txt: Added JSDocumentCustom.cpp.
  • WebCore.pro: Ditto.
  • WebCoreSources.bkl: Ditto.
5:09 PM Changeset in webkit [19018] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch-expected.txt: Added.
  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html: Added.

WebCore:

Reviewed by Darin.


Test: fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html

  • bindings/js/kjs_html.cpp: (KJS::ImageConstructorImp::construct): Protect the image element before setting its attributes.
4:54 PM Changeset in webkit [22800] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added JSDocumentCustom.cpp.
4:53 PM Changeset in webkit [19017] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim H.

  • WebInspector/webInspector/inspector.css: Use row-resize for the splitter cursor instead of move. It's a horizontal splitter resizer.
3:42 PM Changeset in webkit [19016] by weinig
  • 4 edits
    4 deletes in trunk

LayoutTests:

Rolling out patch for ​http://bugs.webkit.org/show_bug.cgi?id=8360.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Removed.
  • fast/layers/removed-by-scroll-handler-expected.png: Removed.
  • fast/layers/removed-by-scroll-handler-expected.txt: Removed.
  • fast/layers/removed-by-scroll-handler.html: Removed.

WebCore:

Rolling out patch for ​http://bugs.webkit.org/show_bug.cgi?id=8360.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
2:07 PM Changeset in webkit [19015] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/document-all-select-expected.txt: Added.
  • fast/dom/document-all-select.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/document-all-select.html

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
1:03 PM Changeset in webkit [19014] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • manual-tests/onblur-remove.html: Changed the test to not require pressing Enter, since the correct behavior for Enter is to send a blur event.
12:51 PM Changeset in webkit [19013] by weinig
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

  • fast/dom/gc-10-expected.txt: Added.
  • fast/dom/gc-10.html: Added.
  • fast/dom/resources/gc-10-frame.html: Added.

WebCore:

Reviewed by Darin.

Fix for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

JSDocuments are now responsible for marking the DOM wrappers associated with them, when they get marked.
This fixes a JS object leak when a DOM wrapper has a reference to a JSDocument that is otherwise not reachable.

Test: fast/dom/gc-10.html

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDocumentCustom.cpp: Added. (WebCore::JSDocument::mark):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::mark):
  • bindings/js/kjs_binding.h:
  • dom/Document.idl:

WebKitTools:

Reviewed by Darin.

Test support for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

This adds a getJSObjectCount test-accessible function to allow test scripts to track JSObject usage.

  • DumpRenderTree/GCController.h:
  • DumpRenderTree/GCController.mm: (+[GCController isSelectorExcludedFromWebScript:]): (-[GCController getJSObjectCount]):
12:29 PM Changeset in webkit [19012] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/overflow/position-relative-expected.checksum: Added.
  • fast/overflow/position-relative-expected.png: Added.
  • fast/overflow/position-relative-expected.txt: Added.
  • fast/overflow/position-relative.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/overflow/position-relative.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::lowestPosition): Add the relative position offset only if 'includeSelf' is true. (WebCore::RenderBox::rightmostPosition): Ditto. (WebCore::RenderBox::leftmostPosition): Ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Ditto. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
9:19 AM Changeset in webkit [19011] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLSelectElement/options-collection-detached-expected.txt: Added.
  • fast/dom/HTMLSelectElement/options-collection-detached.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/HTMLSelectElement/options-collection-detached.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection info if the <select> is not in the document. For in-document <select>s this happens anyway as a result of the DOM tree version increasing.
9:05 AM Changeset in webkit [19010] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/file-input-disabled-expected.checksum:
  • fast/forms/file-input-disabled-expected.png:
  • fast/forms/file-input-disabled-expected.txt:

WebCore:

Reviewed by Darin.

Covered by fast/forms/file-input-disabled.html

  • css/html4.css: Changed selectors that had pseudo-classes after the -webkit-file-upload-button pseudo-element to have the pseudo-element at the end. Pseudo-elements must be at the end.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::createButtonStyle): Changed to not overwrite the button's style with its parent's style. getPseudoStyle() handles inheritance properly.
8:55 AM Changeset in webkit [19009] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
8:20 AM Changeset in webkit [19008] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adam and Mitz.

Covered by existing test: fast/forms/listbox-selection.html

  • rendering/RenderListBox.h: Added override of layout(), made selectionChanged() no longer an inline. Added private scrollToRevealSelection(), m_scrollToRevealSelectionAfterLayout, and m_inAutoscroll.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): Initialize new data members. (WebCore::RenderListBox::updateFromElement): Remove scrolling code. (WebCore::RenderListBox::selectionChanged): Moved from header. Calls repaint and then scrollToRevealSelection, but if we need layout, instead schedules scrollToRevealSelection to be done after layout. (WebCore::RenderListBox::layout): Added. After calling base class, calls scrollToRevealSelection if the m_scrollToRevealSelectionAfterLayout is set. (WebCore::RenderListBox::scrollToRevealSelection): Added. Code was originally in updateFromElement. (WebCore::RenderListBox::autoscroll): Set m_inAutoscroll so that the selectionChanged function knows not to scroll. Also removed the repaint() here because updateListBoxSelection() takes care of repainting by calling selectionChanged().
5:07 AM Changeset in webkit [19007] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Changed #if SVG_SUPPORT to #ifdef SVG_SUPPORT.
Note: See TracTimeline for information about the timeline view.