Timeline

Jan 23, 2007:

11:43 PM Changeset in webkit [22825] by beidson

• 16 edits
  6 adds in branches/WindowsMerge

Initial checkin of downloads for boomer

11:05 PM Changeset in webkit [19074] by lars

• 3 edits in trunk/WebKitQt

Fix compilation again.

10:26 PM Changeset in webkit [22824] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

10:16 PM Changeset in webkit [19073] by bdash

• 4 edits in trunk/WebCore

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Brady.

Plug thousands of node leaks seen running layout tests.

• ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::~SVGElementInstance): Disassociate ourselves from our children so they will be destroyed if we were the only thing referencing them.
• ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument):
• ksvg2/svg/SVGUseElement.h:

9:43 PM Changeset in webkit [22823] by aliceli1

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Fixed <rdar://4949278> cut/copy/paste not working in subframes

• WebView.cpp: (WebView::cutEnabled): (WebView::copyEnabled): (WebView::pasteEnabled): (WebView::deleteEnabled): (WebView::editingEnabled): (WebView::deleteSelection): (WebView::copy): (WebView::cut): (WebView::paste): (WebView::copyURL): (WebView::delete_): get the focusedOrMainFrame() instead of mainFrame()

9:33 PM Changeset in webkit [19072] by aliceli1

• 2 edits in trunk/WebCore

Reviewed by Brady.

• editing/Editor.cpp: (WebCore::Editor::appliedEditing): minor change. removing unnecessary call to frame to fetch editor

9:08 PM Changeset in webkit [19071] by aliceli1

• 2 edits in trunk/JavaScriptCore

release build fix

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h

7:44 PM Changeset in webkit [19070] by bdash

• 5 edits
  6 adds in trunk

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

Fix regression by making setTitle/updateTitle/removeTitle logic match document.title
specification at ​http://whatwg.org/specs/web-apps/current-work/#the-title1.

• dom/Document.cpp: (WebCore::Document::setTitle): Materialize a title element into the head if one doesn't exist when setting document.title. Also update the contents of the title element when the title is set via document.title. (WebCore::Document::removeTitle): Update the title based on first title element in the head, if one exists. (WebCore::Document::head): Convenience method to retrieve the head element in an HTML document.
• dom/Document.h:

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Adele.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

• fast/dom/Document/title-property-creates-title-element-expected.txt: Added.
• fast/dom/Document/title-property-creates-title-element.html: Added.
• fast/dom/Document/title-property-set-multiple-times-expected.txt: Added.
• fast/dom/Document/title-property-set-multiple-times.html: Added.
• fast/dom/title-text-property-2.html: Remove in reverse order to preserve test behaviour when removing title elements.
• svg/custom/multiple-title-elements.svg: Added.

6:16 PM Changeset in webkit [19069] by adele

• 3 edits in trunk/WebKit

Reviewed by Adam.

Fixed 2 layout tests that I broke with my last checkin.

• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Use the selected frame to get the WebHTMLView.
• WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Added global to keep track of NSEvent used here. (-[WebHTMLView _interceptEditingKeyEvent:]): Check NSEvent against the event used in performKeyEquivalent. We don't want to intercept these events.

5:24 PM Changeset in webkit [19068] by ggaren

• 2 edits in trunk/JavaScriptCore

build fix

• API/JSStringRef.h:
• JavaScriptCore.xcodeproj/project.pbxproj:

4:17 PM Changeset in webkit [19067] by bdash

• 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo.

4:17 PM Changeset in webkit [19066] by bdash

• 2 edits in trunk/JavaScriptCore

2007-01-24 Mark Rowe <​mrowe@apple.com>

Build fix for DumpRenderTree.

• JavaScriptCore.xcodeproj/project.pbxproj: Make JSStringRefCF.h public so it's copied into build framework.

3:38 PM Changeset in webkit [19065] by bdakin

• 7 edits in trunk

WebCore:

Reviewed by Hyatt.

Follow-up to the fix below for 4843226.

• rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Has to be recursive or we will miss out on grandchildren!

LayoutTests:

Reviewed by Hyatt.

Updated test for 4843226 to include a grandchild.

• fast/clip/nestedTransparencyClip-expected.checksum:
• fast/clip/nestedTransparencyClip-expected.png:
• fast/clip/nestedTransparencyClip-expected.txt:
• fast/clip/nestedTransparencyClip.html:

3:37 PM Changeset in webkit [22822] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:27 PM Changeset in webkit [19064] by sfalken

• 1 copy in tags/Safari-521.32.14b

New tag.

3:23 PM Changeset in webkit [19063] by oliver

• 2 edits in trunk/WebCore

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fixes dropping of files into safari

• page/DragController.cpp: (WebCore::DragController::performDrag):

3:11 PM Changeset in webkit [22821] by aliceli1

• 2 edits in branches/WindowsMerge/WebKitWin

Fix for <rdar://49233536> shift-pageup in textareas
This fix is pretty much identical to the shift-backspace
one I just did, so I'm piggybacking on that review.

3:06 PM Changeset in webkit [22820] by andersca

• 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.

• plugins/win/PluginStreamWin.cpp: Change WebReasonNone to -2, some plugins return -1 to indicate error.

(WebCore::PluginStreamWin::stop):
Just don't clear the loader, stop loading as well.

(WebCore::PluginStreamWin::startStream):
Destroy the stream if newstream returns an error.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): If the call to toString throws an exception, clear it.

WebKitWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.

• Interfaces/IWebError.idl: Add error code.

• WebFrame.cpp: (WebFrame::redirectDataToPlugin): Cancel loading the main resource.

(WebFrame::windowObjectCleared):
Use toRef.

2:47 PM Changeset in webkit [19062] by andersca

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h

2:47 PM Changeset in webkit [19061] by justing

• 1 edit
  4 adds in trunk/LayoutTests

Reviewed by john

<rdar://problem/4947130>
REGRESSION: Items duplicated when moved inside contenteditable element (11766)

• editing/pasteboard/4947130-expected.checksum: Added.
• editing/pasteboard/4947130-expected.png: Added.
• editing/pasteboard/4947130-expected.txt: Added.
• editing/pasteboard/4947130.html: Added.

2:39 PM Changeset in webkit [22819] by aliceli1

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed Maciej.

fixed <rdar://4923536> pressing shift-backspace inserts a bad character

• WebView.cpp: added to keyEntries an entry for the commands accounting for modifiers

2:36 PM Changeset in webkit [22818] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2007-01-23 Steve Falkenburg <​sfalken@apple.com>

Fix release build.

• WebCore.vcproj/WebCore.vcproj:

2:32 PM Changeset in webkit [19060] by beidson

• 3 edits in trunk/WebCore

Reviewed by Darin

Added a couple of CF things previously missed

2:23 PM Changeset in webkit [19059] by ggaren

• 7 edits
  2 adds in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/4885131> Move CFString function declarations from
JSStringRef.h to JSStringRefCF.h

Also removed remaining API FIXMEs and changed them into Radars.

• API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Added Radar numbers for UTF8 conversion.

• API/JSContextRef.cpp: (JSGlobalContextCreate): Replaced FIXME for NULL JSContextRef with Radar number.

• API/JSObjectRef.h: Removed FIXME, which is unprofessional in a public header.

• API/JSStringRef.cpp: Moved CF related implementations to JSStringRefCF.cpp. (JSStringCreateWithUTF8CString): Replaced FIXME with Radar number.
• API/JSStringRef.h: Moved CF related declarations to JSStringRefCF.h. Added #include of JSStringRefCF.h as a stopgap until clients start #including it as needed by themselves.

• API/JSStringRefCF.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString): Replaced JSChar cast with UniChar cast, which is more appropriate for a CF call.
• API/JSStringRefCF.h: Added.
• JavaScriptCore.xcodeproj/project.pbxproj:

2:11 PM Changeset in webkit [19058] by zimmermann

• 3 edits in trunk/WebCore

Reviewed by Maciej.

Fix evil genericContext() assertion, which occours sometimes when running DRT.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12379

1:52 PM Changeset in webkit [19057] by brmorris

• 2 edits in S60/trunk/WebKit

ssareen <​shyam.sareen@nokia.com>

Reviewed by Sachin/Brad.

DESC: Invalid WAP CSS formats not being ignored ( TSW ID: TMCN-6S5K87)
​http://bugs.webkit.org/show_bug.cgi?id=12230

• BrowserCore/Formcontrols/src/FControlformathandler.cpp: (CInputFormatHandler::ConstructL):

1:50 PM Changeset in webkit [22817] by adele

• 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added call to paintThemeTextArea.

1:45 PM Changeset in webkit [19056] by bdakin

• 3 edits
  4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4843226> REGRESSION: Pull down menu appears
clipped at ​http://istweb.apple.com/

• rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Always unite with sibling rects.

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4843226> REGRESSION: Pull down menu
appears clipped at ​http://istweb.apple.com/

• fast/clip/nestedTransparencyClip-expected.checksum: Added.
• fast/clip/nestedTransparencyClip-expected.png: Added.
• fast/clip/nestedTransparencyClip-expected.txt: Added.
• fast/clip/nestedTransparencyClip.html: Added.

1:10 PM Changeset in webkit [19055] by justing

• 4 edits
  6 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteEx

WebCore:

Reviewed by john

<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteExtract()

• dom/Range.cpp: (WebCore::Range::checkDeleteExtract): Return if there is no commonAncestor container or if commonAncestorContainer() throws an exception.
• editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Fixed a bug that reversed the order of the selected paragraphs.

12:55 PM Changeset in webkit [19054] by brmorris

• 3 edits in S60/trunk/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: WAP CSS specific character format causing phone keypad input error ( TSW ID: TMCN-6S5MSE)
​http://bugs.webkit.org/show_bug.cgi?id=12232

12:31 PM Changeset in webkit [19053] by brmorris

• 2 edits in S60/branches/3.1m/WebKit

raalexan

Reviewed by Sachin
DESC: MLIO-6XLCE4 Returning from page overview shows the toolbar
​http://bugs.webkit.org/show_bug.cgi?id=id=12366

• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

12:21 PM Changeset in webkit [19052] by brmorris

• 2 edits in S60/branches/3.1m/WebCore

w3liu <​wei.liu@nokia.com>

Reviewed by Zalan, landed by Brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12371

12:19 PM Changeset in webkit [19051] by brmorris

• 2 edits in S60/trunk/WebCore

w3liu <​wei.liu@nokia.com>

Reviewed by Zalan, landed by brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites

​http://bugs.webkit.org/show_bug.cgi?id=12371

12:04 PM Changeset in webkit [19050] by zimmermann

• 25 edits
  64 adds in trunk

Reviewed by Sam.

Fix dynamic creation/updates of markers, masks, clipPaths, and several tiny pattern issues.
Added 16 (!) new layout tests covering quite some weird scenerios - Batik & Opera do have problems, we don't.

11:48 AM Changeset in webkit [22816] by adele

• 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Reorganized some event handling code for keyPress events to
prepare for another fix.

• WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Added.
• WebEditorClient.h: Removed unnecessary forward declarations.

11:37 AM Changeset in webkit [19049] by adele

• 21 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail

In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix. There's also just a little bit of unrelated cleanup.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Move tab focus behavior into new defaultKeyboardEventHandler method.

• bridge/EditorClient.h: Added handleKeyPress.
• editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Added. Calls over to the client method. (WebCore::Editor::deleteRange): Removed unnecessary propogateDOMException.
• editing/Editor.h: Added handleKeyPress. (WebCore::Editor::addToKillRing): Formatting cleanup.
• editing/mac/EditorMac.mm: Removed unnecessary propogateDOMException.

• page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Added. Checks the tabKeyCyclesThroughElements setting before advancing focus for tab key events. Calls handleKeyPress.
• page/EventHandler.h: Added defaultKeyboardEventHandler.

• page/Page.cpp: (WebCore::Page::Page): Initialize m_tabKeyCyclesThroughElements to true.
• page/Page.h: Added m_tabKeyCyclesThroughElements. (WebCore::Page::setTabKeyCyclesThroughElements): Added. (WebCore::Page::tabKeyCyclesThroughElements): Added.

• platform/PlatformKeyboardEvent.h: Added ability to get NSEvent from PlatformKeyboardEvent.
• platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Initialize m_macEvent to the NSEvent.

• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): Added.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail

In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix.

• WebCoreSupport/WebEditorClient.h: Added handleKeyPress method.
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Added. Code moved from WebHTMLView keyDown method. This is called from the defaultEventHandler so that in the future, we can make the right decision about which selection the keyPress should apply to.
• WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Moved _interceptEditingKeyEvent call to handleKeyPress. (-[WebHTMLView _interceptEditingKeyEvent:]): Prevents intercepting keys for cmd-modified events. Removed tabCycling checks since this is now handled in WebCore.
• WebView/WebHTMLViewInternal.h: Made _interceptEditingKeyEvent SPI.
• WebView/WebView.mm: Use new tabKeyCyclesThroughElements methods on the page. (-[WebViewPrivate init]): ditto. (-[WebView setTabKeyCyclesThroughElements:]): ditto. (-[WebView tabKeyCyclesThroughElements]): ditto. (-[WebView setEditable:]): ditto

10:36 AM Changeset in webkit [19048] by staikos

• 2 edits in trunk

Temporary measure to make it possible to use the Qt port until the official Qt
API is done

10:24 AM Changeset in webkit [22815] by andersca

• 6 edits in branches/WindowsMerge

WebCoreWin:

Build fixes.

• WebCore.vcproj/WebCore.vcproj: Copy plugin and JS headers.

• loader/win/FrameLoaderWin.cpp: Move functions to WebKitWin.

WebKitWin:

Build fixes.

• WebFrame.cpp: (WebFrame::createFrame): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::objectContentType): (WebFrame::overrideMediaType): (WebFrame::windowObjectCleared):
• WebFrame.h: Move functions here from WebFrameLoaderWin in WebCore.

10:18 AM Changeset in webkit [19047] by staikos

• 2 edits in trunk/WebCore

Compile with a released Qt.

8:35 AM Changeset in webkit [19046] by lars

• 6 edits in trunk

Reviewed by Zack

Widget and ScrollView do not own the Qt widgets
anymore. Make sure they can handle the case of
a null QWidget and never delete them.

Fix refcounting of FrameViews (they get created with a
refcount of 1) and add a few safety checks to the
FrameLoaderClientQt.

6:35 AM Changeset in webkit [19045] by zack

• 2 edits in trunk/WebCore

Forgot to add this file to the build (fix the build for real)

5:39 AM Changeset in webkit [19044] by zack

• 4 edits in trunk/WebKitQt

Adjust the DragClient to latest changes.

2:32 AM Changeset in webkit [19043] by zack

• 8 edits in trunk

Fix the Qt build

2:28 AM Changeset in webkit [19042] by lars

• 25 edits
  2 deletes in trunk

Reviewed by Maciej

Make the last remaining pieces of the FrameLoader platform
independent. Move most of the code over to WebFrameLoaderClient.
Some smaller cleanups in the WebFrameBridge, and moved some
platform independent functionality over to the shared code
in WebCore.

Add support for Frames to the Qt build and fix some issues
in the API classes.

1:33 AM Changeset in webkit [22814] by oliver

• 11 edits
  4 adds in branches/WindowsMerge

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebKitWin:

Attaching the DragController logic to the WebView

• Interfaces/IWebUIDelegate.idl: Fixed a couple of function definitions to use IDataObject instead of IDropSource

• WebDragClient.cpp: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction):
• WebDragClient.h: Added. DragClient implementation.

• WebKit.vcproj/WebKit.vcproj:
• WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (dragOperationToDragCursor): (keyStateToDragOperation): (WebView::DragEnter): (WebView::DragOver): (WebView::DragLeave): (WebView::Drop): Set up and register WebView as an IDropTarget, and pass off drag events to the DragController
• WebView.h: Ditto

WebCoreWin:

• WebCore.vcproj/WebCore.vcproj:
• page/win/DragControllerWin.cpp: Added. (WebCore::DragController::dragOperation): (WebCore::DragController::isCopyKeyDown): Platform specific implementation

• platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::isForDragging):
• platform/win/ClipboardWin.h: Migrated common Clipboard functionality from ClipboardMac/Win -> Clipboard

• platform/win/DragDataWin.cpp: Added. (WebCore::DragData::createClipboard): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::DragData::containsURL): (WebCore::extractURL): (WebCore::DragData::asURL): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::containsHTML): (WebCore::fragmentFromHTML): (WebCore::containsFilenames): (WebCore::fragmentFromFilenames): (WebCore::DragData::containsColor): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asFragment): (WebCore::DragData::asColor): Implementation of DragData accesor methods, and helper functions

• platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor

• platform/win/PasteboardWin.cpp: (WebCore::fragmentFromCF_HTML): (WebCore::Pasteboard::documentFragment): Pulled out CF_HTML parsing to a seperate function so logic can be shared with DragDataWin

1:15 AM Changeset in webkit [19041] by oliver

• 2 edits
  2 adds in trunk/WebKitQt

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Qt build stubs for Drop logic

• WebCoreSupport/DragClientQt.cpp: Added. (WebCore::DragClientQt::actionMaskForDrag): (WebCore::DragClientQt::willPerformDragDestinationAction):
• WebCoreSupport/DragClientQt.h: Added.
• WebKitPart/WebKitPart.cpp: (WebKitPart::initView):

1:14 AM Changeset in webkit [19040] by oliver

• 9 edits
  4 adds in trunk/WebKit

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Drop logic bindings for WebKit

• WebCoreSupport/WebDragClient.h: Added.
• WebCoreSupport/WebDragClient.mm: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): Standard client impl
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Updated to use DragController to track drag state

• WebCoreSupport/WebPasteboardHelper.h: Added. (WebPasteboardHelper::WebPasteboardHelper): A *temporary* Helper class to access NSPasteboard access and manipulation functions present in WebKit
• WebCoreSupport/WebPasteboardHelper.mm: Added. (WebPasteboardHelper::urlFromPasteboard): (WebPasteboardHelper::plainTextFromPasteboard): (WebPasteboardHelper::fragmentFromPasteboard): (WebPasteboardHelper::insertablePasteboardTypes): See header comment
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDocumentInternal.h: Remove unnecessary protocol
• WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): Updating to use DragController to track drag state
• WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): ditto (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): ditto (-[WebHTMLView draggingSourceOperationMaskForLocal:]): ditto (-[WebHTMLView draggedImage:endedAt:operation:]): ditto (-[WebHTMLView _documentFragmentForPasteboard:]): Helper method to generate DocumentFragment from NSPasteboard without regressing (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Updating to use DragController to track drag state (-[WebHTMLView _isMoveDrag:]): (-[WebHTMLView _isNSColorDrag:]):
• WebView/WebHTMLViewInternal.h: Removing unnecessary fields and methods
• WebView/WebView.mm: (-[WebViewPrivate dealloc]): Remove obsolete ASSERT (-[WebView _setInitiatedDrag:]): Now passes directly through to DragController (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _loadingDragOperationForDraggingInfo:]): Removed (-[WebView draggingEntered:]): Updated to use DragController (-[WebView draggingUpdated:]): ditto (-[WebView draggingExited:]): ditto (-[WebView performDragOperation:]): ditto (-[WebView _hitTest:dragTypes:]):
• WebView/WebViewInternal.h: remove unnecessary method def

1:12 AM Changeset in webkit [19039] by oliver

• 17 edits
  12 adds in trunk/WebCore

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Added DragController to handled drag and drop state and control logic.
Currently this only handles logic for Dragging and Dropping, and is
unable to initialise a drag itself.

platform/DragData encapsulate the paltform Drag data (NSDraggingInfo on Mac,
QMimeType in Qt). This provides methods to pull data out the drag data as a String,
a URL, a DocumentFragment (for rich content), or a Colour.

• WebCore.exp:
• WebCore.pro:
• WebCore.xcodeproj/project.pbxproj:
• dom/Clipboard.cpp: Added. (WebCore::Clipboard::setAccessPolicy): (WebCore::dragOpFromIEOp): (WebCore::IEOpFromDragOp): (WebCore::Clipboard::sourceOperation): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setSourceOperation): (WebCore::Clipboard::setDestinationOperation): (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed): move platform independent functions from ClipboardMac to Clipboard

• dom/Clipboard.h: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::dropEffect): (WebCore::Clipboard::effectAllowed): (WebCore::Clipboard::policy): as above -- also removed virtual modifier from now platform independent methods

• editing/Editor.cpp: (WebCore::Editor::smartInsertDeleteEnabled): (WebCore::Editor::shouldApplyStyle):
• editing/Editor.h: adding calls through to EditorClient

• page/DragActions.h: Added. (WebCore::): Replicates a number of NS* enums in the WebCore namespace

• page/DragClient.h: Added. (WebCore::DragClient::~DragClient): Standard client interface for dragging UIDelegate

• page/DragController.cpp: Added. (WebCore::createMouseEvent): (WebCore::DragController::DragController): (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::isMoveDrag): (WebCore::visiblePositionForPoint): (WebCore::DragController::cancelDrag): (WebCore::documentAtPoint): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): Class to handle state and logic for dragging and dropping

• page/DragController.h: Added. (WebCore::DragController::client): (WebCore::DragController::didInitiateDrag): (WebCore::DragController::isHandlingDrag): (WebCore::DragController::dragOperation): (WebCore::DragController::document): (WebCore::DragController::dragInitiator): (WebCore::DragController::dragDestinationAction): (WebCore::DragController::dragSourceAction): (WebCore::DragController::dragEnded): (WebCore::DragController::setIsHandlingDrag): (WebCore::DragController::setDidInitiateDrag): (WebCore::DragController::setDragOperation): (WebCore::DragController::setDragSourceAction): (WebCore::DragController::setDragInitiator): See above

• page/Page.cpp: (WebCore::Page::Page): Update Page to have DragController

• page/Page.h: (WebCore::Page::dragController): ditto

• page/mac/DragControllerMac.mm: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Platform specific portions of the DragController

• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::dragSourceEndedAt): Convert from NSDragOperation to WebCore::DragOperation

• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreFrameBridge.mm: Remove obsolete Drag functions

• page/qt/DragControllerQt.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Basic stubs to maintain Qt build

• platform/DragData.cpp: Added. (WebCore::DragData::DragData):
• platform/DragData.h: Added. (WebCore::DragData::clientPosition): (WebCore::DragData::globalPosition): (WebCore::DragData::platformData): (WebCore::DragData::draggingSourceOperationMask): DragData class to encapsulate platform drag data/event

• platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData): Addition of dummy DragClient

• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::~SVGEmptyDragClient): (WebCore::SVGEmptyDragClient::willPerformDragDestinationAction): (WebCore::SVGEmptyDragClient::actionMaskForDrag): (WebCore::SVGEmptyDragClient::dragControllerDestroyed): ditto

• platform/mac/ClipboardMac.h:
• platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): Moving platform independent logic to Clipboard, and updating platform specific methods to use appropriate accessors rather than directly manipulating data they no longer own

• platform/mac/DragDataMac.mm: Added. (WebCore::DragData::DragData): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::imageExistsAtPaths): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Mac implementations of DragData methods. A number of these use a Helper class that accesses WebKit functionality. That functionality should be migrated to WebCore in the future.

• platform/mac/PasteboardHelper.h: Added. (WebCore::PasteboardHelper::~PasteboardHelper): Temporary, and Mac only, helper class to access WebKit functionality from WebCore

• platform/qt/DragDataQt.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Basic stubs to maintain Qt build

• rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Correct HitTestResult copy contructor to copy localPoint

Jan 22, 2007:

11:00 PM Changeset in webkit [22813] by aroben

• 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Implemented search field painting, and did some cleanup.

8:00 PM Changeset in webkit [19038] by bdash

• 2 edits in trunk/WebCore

2007-01-22 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11692
Bug 11692: REGRESSION(r17352): Disappearing page title

• dom/Document.cpp: (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript, ignore any changes to it due to encountering <title> tags.

6:23 PM Changeset in webkit [22812] by andersca

• 6 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4771115>
Windows Media Player plugin crashes.

• WebCore.vcproj/WebCore.vcproj: Formatting changes.

• plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add Windows Media Player path.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream):
• plugins/win/PluginStreamWin.h: New function which sends a JavaScript result stream and handles any errors that the plug-in returns.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): Always call NPP_SetWindow, some plugins (like WMP) relies on it.

(WebCore::PluginViewWin::performRequest):
If a plug-in requests a javascript: URL that doesn't evaluate to a string, call toString on it.
The Windows Media Player plugin calls javascript:document.location and expects to get the location back.

5:36 PM Changeset in webkit [19037] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12344 NativeListBox: item hit testing does not account for top padding and border

• fast/forms/listbox-selection-2-expected.checksum: Added.
• fast/forms/listbox-selection-2-expected.png: Added.
• fast/forms/listbox-selection-2-expected.txt: Added.
• fast/forms/listbox-selection-2.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12344 NativeListBox: item hit testing does not account for top padding and border

Test: fast/forms/listbox-selection-2.html

• rendering/RenderListBox.cpp: (WebCore::RenderListBox::numVisibleItems): Changed height() to contentHeight() since items are visible only in the content box. (WebCore::RenderListBox::listIndexAtOffset): Adjusted for vertical padding and borders. Changed to return -1 instead of the last item's index if the given offset is below the last item. (WebCore::RenderListBox::autoscroll): Adjusted for vertical padding and borders. (WebCore::RenderListBox::controlClipRect): Changed to return the content box since items should not spill into the padding box. This change is the reason the test generates pixel results.

5:30 PM Changeset in webkit [19036] by justing

• 15 edits
  11 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)

The fixes not only make this test pass, but also fix a bug that
was reflected in the results checked in for this test. The caret
was in the wrong position:

• editing/pasteboard/4641033-expected.checksum:
• editing/pasteboard/4641033-expected.png:
• editing/pasteboard/4641033-expected.txt: Added:
• editing/pasteboard/4944770-1-expected.checksum: Added.
• editing/pasteboard/4944770-1-expected.png: Added.
• editing/pasteboard/4944770-1-expected.txt: Added.
• editing/pasteboard/4944770-1.html: Added.
• editing/pasteboard/4944770-2-expected.checksum: Added.
• editing/pasteboard/4944770-2-expected.png: Added.
• editing/pasteboard/4944770-2-expected.txt: Added.
• editing/pasteboard/4944770-2.html: Added.
• editing/pasteboard/4944770-expected.checksum: Added.
• editing/pasteboard/4944770-expected.png: Added.
• editing/pasteboard/4944770-expected.txt: Added. Equivalent render trees:
• editing/execCommand/format-block-from-range-selection-expected.txt:
• editing/pasteboard/drag-drop-modifies-page-expected.txt: Fixed:
• editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
• editing/pasteboard/nested-blocks-with-text-area-expected.png:
• editing/pasteboard/nested-blocks-with-text-area-expected.txt:
• editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
• editing/pasteboard/nested-blocks-with-text-field-expected.png:
• editing/pasteboard/nested-blocks-with-text-field-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)

This layout test failure demonstrates three bugs:
Smart replace shouldn't be turned on, but is because a word
selection granularity from the previous test isn't cleared.
Smart replace shouldn't add any spaces because the paste is performed
in an empty paragraph.
Smart replace spaces are added to the text of options inside
the select element instead of before/after the select element.

This patch fixes the second two problems. During a
ReplaceSelectionCommand, the VisiblePosition for the end of
the inserted content is the last position in the last leaf
inserted. This is a problem when the last leaf is inside a
select element, since VP creation is inconsistent there.
Second, smart spaces were inserted inside the last leaf, not
at the endOfInsertedContent.

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Renamed m_lastNodeInserted to m_lastLeafInserted. Use the start/endOfInsertedContent getters. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Ditto. (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Ditto. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Ditto. (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Added. Special case for when the last leaf inserted is inside a select element: return the VisiblePosition after the select element. (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Added. (WebCore::ReplaceSelectionCommand::doApply): Did renaming. Used the start/endOfInsertedContent getters. Insert smart replace spaces into the right nodes. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renaming. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto. (WebCore::ReplaceSelectionCommand::updateNodesInserted): Ditto.
• editing/ReplaceSelectionCommand.h:

4:51 PM Changeset in webkit [22811] by darin

• 3 edits in branches/WindowsMerge/WebCore

• internal part of fix for ​http://bugs.webkit.org/show_bug.cgi?id=12273 REGRESSION: File input value invisible after removing and re-appending

• WebCore.vcproj/WebCore.vcproj: Added FileChooser.cpp.

• platform/win/FileChooserWin.cpp: Removed many now-unneeded functions. (WebCore::FileChooser::FileChooser): Updated for changed parameters and members. (WebCore::FileChooser::openFileChooser): Changed to take document parmaeter and find the FrameView from that instead of the upload control. (WebCore::FileChooser::basenameForWidth): Added ignored Font parameter.

4:46 PM Changeset in webkit [22810] by aroben

• 9 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders, Brady, and Steve.

WebKit part of <rdar://problem/4601321> HTTP Authentication Alerts

Made WebURLCredential use a registered CLSID so the app can get instantiate it:

• Interfaces/IWebURLAuthenticationChallenge.idl: Changed method name.
• Interfaces/WebKit.idl: Added GUIDs for WebURLCredential.
• WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added case for WebURLCredential.
• WebKitDLL.cpp: Added WebURLCredential and WebError (it was omitted from r11821). (DllGetClassObject):
• WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Changed to use CLSID, and return the failing HRESULT. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Changed to return the failing HRESULT.
• WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::useCredential): Ditto.
• WebURLCredential.cpp: Removed IID definition. (WebURLCredential::QueryInterface): Switched to use CLSID. (WebURLCredential::initWithUser): Updated method name.
• WebURLCredential.h: Ditto.

4:40 PM Changeset in webkit [19035] by darin

• 11 edits
  1 add in trunk/WebCore

Reviewed by Adam.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12273 REGRESSION: File input value invisible after removing and re-appending

• made more of the file chooser code cross-platform

• fixed an Objective-C garbage collection problem in FileChooser

• tried to remove layering violations where FileChooser in the platform directory knows about the rendering and DOM trees (but wasn't able to do it entirely)

• platform/FileChooser.cpp: Added. (WebCore::FileChooser::create): Changed parameters. (WebCore::FileChooser::chooseFile): Changed to call chooseIcon function. (WebCore::FileChooser::chooseIcon): Added.

• platform/FileChooser.h: Added FileChooserClient so this file doesn't have to know about RenderFileUploadControl. Used RetainPtr instead of retain/release so this works properly with Objective-C GC. Replaced disconnectUploadControl with disconnectClient, which has a simple inline implementation. Moved the Document parameter from the constructor to openFileChooser, along with a comment about why it should not be there. Added a filename parameter to the constructor for the initial filename. Added a font parameter to basenameForWidth so we don't depend on having a pointer to the renderer. Removed the uploadControl() and document() functions since no one calls either of them.

• platform/mac/FileChooserMac.mm: Removed code that is now cross-platform. (-[OpenPanelController beginSheetWithFrame:]): Added frame parameter, instead of storing a document pointer in the FileChooser. (WebCore::FileChooser::FileChooser): Updated for changed parameters. Also added code to choose the icon based on the initial filename. Pass the adopt parameter to the constructor of the RetainPtr. (WebCore::FileChooser::~FileChooser): Removed the release call, since the RetainPtr will take care of it. Added a call to disconnectFileChooser here. There's no need to disconnect at disconnectClient time, and that lets us have one more cross-platform function. (WebCore::FileChooser::openFileChooser): Added document parameter. Added code to get the frame from the document. And added a nil check since there's no ironclad guarantee the document won't have outlived its frame. (WebCore::FileChooser::basenameForWidth): Added font parameter. Use that instead of going at the upload control's style. The caller can handle that now.

• rendering/RenderFileUploadControl.h: Removed unnecessary includes. Made class inherit privately from FileChooserClient. Changed constructor parameter to HTMLInputElement rather than Node. Made protected members be private instead, and made a couple function members const.
• rendering/RenderFileUploadControl.cpp: Moved constants to the top of the file, but after the "using namespace" (WebCore::RenderFileUploadControl::RenderFileUploadControl): Updated for changes to the FileChooser::create function and the parameter types. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed unneeded null check -- there's no case where the FileChooser fails to be created. (WebCore::RenderFileUploadControl::click): Pass document to openFileChooser. (WebCore::RenderFileUploadControl::updateFromElement): Tweaked code a bit by using updateFromElement and setValue instead of casting the renderer to a RenderButton and calling setText directly. Put setInputType call here. (WebCore::RenderFileUploadControl::maxFilenameWidth): Made const. Broke long line. (WebCore::RenderFileUploadControl::createButtonStyle): Made const. (WebCore::RenderFileUploadControl::paintObject): Moved buttonShadowHeight constant to the top of the file. Call isEmpty instead of checking width and height of IntRect for 0. Computed font to pass to FileChooser::basenameForWidth. Broke long lines. (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): Moved the setInputType call to the caller; concept here is that this class is as simple as possible, rather than doing as much of the button job as possible.

• WebCore.xcodeproj/project.pbxproj: Added FileChooser.cpp.
• WebCore.pro: Ditto.
• CMakeLists.txt: Ditto.
• WebCoreSources.bkl: Ditto.

• platform/gdk/TemporaryLinkStubs.cpp: Updated stubs.
• platform/qt/FileChooserQt.cpp: Updated stubs.

3:39 PM Changeset in webkit [22809] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2007-01-22 Steve Falkenburg <​sfalken@apple.com>

Updated strings not to be localized, added native line endings svn flag.

2:51 PM Changeset in webkit [19034] by bdakin

• 5 edits in trunk/LayoutTests

Reviewed by Darin.

Darin and I looked into these tests that are adding an empty
RenderText, and we think they just need new results. Here they are!

• editing/execCommand/find-after-replace-expected.txt:
• fast/css/beforeSelectorOnCodeElement-expected.txt:
• fast/forms/control-restrict-line-height-expected.txt:
• fast/forms/select-size-expected.txt:

1:46 PM Changeset in webkit [22808] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4903230>
Boomer crashes at Flickr website when "View as slideshow" is clicked.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): Return null if m_plugin is null (which it can be if the plugin failed to load).

1:37 PM Changeset in webkit [19033] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=12364 REGRESSSION (NativeListBox): Selected option's background is not clipped to the list box

• fast/forms/select-item-background-clip-expected.checksum: Added.
• fast/forms/select-item-background-clip-expected.png: Added.
• fast/forms/select-item-background-clip-expected.txt: Added.
• fast/forms/select-item-background-clip.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12364 REGRESSSION (NativeListBox): Selected option's background is not clipped to the list box

Test: fast/forms/select-item-background-clip.html

• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemBackground): Intersect the item's rect with the list box's clip rect.

1:28 PM Changeset in webkit [19032] by sullivan

• 2 edits in trunk/WebKit

• WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Tiger build fix: remove unused variable for return value of dictionaryServiceWindowShow

1:15 PM Changeset in webkit [19031] by darin

• 2 edits in trunk/WebCore

Reviewed by Beth.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12369 REGRESSION (r19027): amazon.com home page crashes WebKit r19028 debug build

I caused this a few hours ago. Oops!

• rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Compute whether the font changed before calling RenderObject::setStyle.

1:09 PM Changeset in webkit [19030] by sullivan

• 4 edits in trunk/WebKit

Reviewed by Adam and Darin

• fixed <rdar://problem/4794320> "Look Up in Dictionary" does nothing in WebKit (need to adopt new API)

• Misc/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): random typo correction in comment

• English.lproj/StringsNotToBeLocalized.txt: updated for these changes

• WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): new function to convert an AppKit screen point to a CG screen point (-[WebHTMLView _lookUpInDictionaryFromMenu:]): on Leopard now uses new API. There's something of an impedance mismatch between this API and WebKit, but that was true for the SPI we were using in Tiger also. Bug 4945808 covers the ways in which this is not perfect.

1:01 PM Changeset in webkit [22807] by andersca

• 10 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

• Interfaces/IWebError.idl: Clean up the IWebError interface.

• Interfaces/WebKit.idl:
• WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Make it possible for clients to create WebErrors.

• WebError.cpp: (WebError::QueryInterface): (WebError::init):
• WebError.h:
• WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Get rid of IID_WebError and use CLSID_WebError instad.

• WebView.cpp: (WebView::canHandleRequest): Return true for "about" URLs.

(WebView::canHandleRequest):
Add private COM method.

(WebView::close):
Reset the policy delegate.

12:54 PM Changeset in webkit [19029] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4912129> REGRESSION: Crash occurs at
WebCore::Frame::eventHandler() after clicking to dismiss a
contextual menu on the page

• page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Added nil-check.

10:42 AM Changeset in webkit [22806] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:

10:10 AM Changeset in webkit [22805] by aroben

• 3 edits in branches/WindowsMerge/WebCore

Moved ifdefs to match Darin's suggestion.

9:39 AM Changeset in webkit [19028] by darin

• 2 edits in trunk/WebKitTools

Reviewed by Mitz.

• a couple tiny tweaks to make --reset-results work better

• Scripts/run-webkit-tests: Always generate results when --reset-results is specified. Don't make a separate "new" entry while generating results when --reset-results is specified since new results are the norm in that case.

9:30 AM Changeset in webkit [22804] by aroben

• 3 edits in branches/WindowsMerge/WebCore

Build fix.

9:28 AM Changeset in webkit [19027] by darin

• 28 edits
  8 adds in trunk

LayoutTests:

Test by Andrew Wellington <​proton@wiretapped.net>.
Reviewed by Darin.

• test for fix to ​http://bugs.webkit.org/show_bug.cgi?id=11197 REGRESSION: Specifying a counter for a CODE tag's content style property on before or after causes a crash.

• fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
• fast/css/beforeSelectorOnCodeElement-expected.png: Added.
• fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
• fast/css/beforeSelectorOnCodeElement.html: Added.

Test by Mitz.
Reviewed by Darin.

• test for monospace problem mentioned in the above bug

• fast/text/monospace-width-cache-expected.checksum: Added.
• fast/text/monospace-width-cache-expected.png: Added.
• fast/text/monospace-width-cache-expected.txt: Added.
• fast/text/monospace-width-cache.html: Added.

WebCore:

Reviewed by Mitz.

Inspired by a much simpler patch by Andrew Wellington <​proton@wiretapped.net>.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11197 REGRESSION: Specifying a counter for a CODE tag's content style property on before or after causes a crash.

Test: fast/css/beforeSelectorOnCodeElement.html

• fix regression I recently introduced where the monospace cache could be used for text that was not ASCII, if text was changed after the style was set

Test: fast/text/monospace-width-cache.html

• streamline RenderText.h -- remove unneeded functions, make some needlessly virtual functions non-virtual, remove unneeded header includes, replace use of Font* with Font& for consistency with RenderStyle, use "text" consistently instead of "string"

• rendering/RenderText.h: Removed unneeded include of "Text.h", declarations of SOFT_HYPHEN, DocumentMarker, InlineBox, Position, String. Got rid of friend declaration for InlineTextBox. Changed constructor to take a PassRefPtr since we do take owership of the passed-in text. Made deleteTextBoxes() private. Removed unneeded data(). Made override of length() private so people will use the faster textLength() instead. Renamed string() to text() so it matches up better with setText(). Same for stringLength(), originalString(), and setInternalString(), which are now textLength(), originalText(), and setTextInternal(). Renamed the old text() function to characters(), since it returns a pointer as StringImpl::characters does. Changed Font* to Font& everywhere. Renamed the internal calcMinMaxWidth() function to calcMinMaxWidthInternal() and made it non-virtual since it's not overriden anywhere. Also made the trimmedMinMaxWidth() function non-virtual. Made containsOnlyWhitespace() private. Removed both font() functions (one was needlessly virtual) and element(). Renamed cacheWidths() to updateMonospaceCharacterWidth() and removed the shouldUseMonospaceCache() function. Renamed allAscii() to isAllASCII() and made it an inline function. Removed the m_allAsciiChecked flag and renamed the m_allAscii flag to m_isAllASCII.
• rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Removed initialization of m_allAsciiChecked. Initialize m_isAllASCII. Changed all occurrences of m_str->length() and m_str->characters () to use the stringLength() and characters() inline functions instead. (WebCore::RenderText::setStyle): Replaced the unconditional call to cacheWidths with a conditional call to updateMonospaceCharacterWidth. This speeds up the common case where style is changed without changing the font. (WebCore::RenderText::originalText): Changed code to not depend on overridden element() function with casts to a Text node -- this was one of only two call sites. Also renamed. (WebCore::RenderText::positionForCoordinates): Name change. (WebCore::RenderText::caretRect): Ditto. (WebCore::RenderText::updateMonospaceCharacterWidth): Renamed from cacheWidths and incorporate the check that was formerly in a separate shouldUseMonospaceCache function. (WebCore::RenderText::widthFromCache): Changed to take a Font& instead of Font*. Changed to take advantage of the fact that the string is known to be all ASCII in the m_monospaceCharacterWidth code path. (WebCore::RenderText::trimmedMinMaxWidth): Ditto. Also use style()->font() instead of font(false). (WebCore::RenderText::calcMinMaxWidth): Ditto. Also changed to use softHyphen instead of SOFT_HYPHEN. (WebCore::RenderText::containsOnlyWhitespace): More of the same. (WebCore::RenderText::setSelectionState): Ditto. (WebCore::RenderText::setTextWithOffset): Ditto. (WebCore::isInlineFlowOrEmptyText): Ditto. (WebCore::RenderText::setTextInternal): Updated for name changes. Also changed to set the m_isAllASCII flag every time, in the more-efficient way we use elsewhere (or'ing all the characters together), and to call updateMonospaceCharacterWidth if the "all ASCII"-ness of the text changes. (WebCore::RenderText::setText): Updated for name changes. (WebCore::RenderText::width): More like above. (WebCore::RenderText::selectionRect): Ditto. (WebCore::RenderText::caretMaxOffset): Ditto. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.

• dom/Position.cpp:
• dom/Range.cpp:
• editing/CompositeEditCommand.cpp:
• editing/DeleteSelectionCommand.cpp:
• editing/VisiblePosition.cpp:
• html/HTMLElement.cpp: Added now-needed include of "Text.h" which is no longer included by "RenderText.h".

• editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
• editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Update for name changes of stringLength(), string(), and originalString() to textLength(), text(), and originalText(), and to always use textLength() instead of length() when we have a RenderText* rather than a RenderObject*.
• editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto. (WebCore::endOfParagraph): Ditto.
• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto. Also removed use of the RenderObject::font() function and replaced it with explicit access to the style. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): Ditto. (WebCore::InlineTextBox::isLineBreak): Ditto. (WebCore::InlineTextBox::paint): Ditto. (WebCore::InlineTextBox::selectionStartEnd): Ditto. (WebCore::InlineTextBox::paintSelection): Ditto. (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::offsetForPosition): Ditto. (WebCore::InlineTextBox::positionForOffset): Ditto.
• rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Ditto.
• rendering/RenderCounter.cpp: (WebCore::RenderCounter::originalText): Ditto. (WebCore::RenderCounter::calcMinMaxWidth): Ditto.
• rendering/RenderCounter.h: Ditto.
• rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): Ditto.
• rendering/RenderTextFragment.h: Ditto.
• rendering/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): Ditto. (WebCore::placeBoxesVerticallyWithAbsBaseline): Ditto.
• rendering/bidi.cpp: (WebCore::BidiIterator::increment): Ditto. (WebCore::BidiIterator::current): Ditto. (WebCore::BidiIterator::direction): Ditto. (WebCore::addRun): Ditto. (WebCore::checkMidpoints): Ditto. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto. (WebCore::RenderBlock::skipWhitespace): Ditto. (WebCore::RenderBlock::findNextLineBreak): Ditto.

• rendering/RenderBR.h: Updated signature of width function which now takes a Font& instead of a Font*.

• rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Updated to no longer use the RenderObject::font() function, and added a comment about first-line, which is not handled properly here.

• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text):
• rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun): Eliminated use of RenderText::data().

• rendering/RenderObject.h: Removed RenderObject::font(). This had the bad effect of having everyone pass in a boolean rather than using the cleaner style() and firstLineStyle() functions in cases where there's no a firstLineStyle boolean.
• rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition): Replaced use of RenderObject::font() with direct use of the style instead, which is arguably easier to understand anyway. (WebCore::RenderObject::baselinePosition): Ditto.

6:38 AM Changeset in webkit [19026] by weinig

• 3 edits
  1 move in trunk/WebCore

Reviewed by The Mitz.

Move JSHTMLSelectElementCustom.cpp from bindings to bindings/js
where it belongs.

• WebCore.pro:
• WebCore.xcodeproj/project.pbxproj:
• bindings/JSHTMLSelectElementCustom.cpp: Removed.
• bindings/js/JSHTMLSelectElementCustom.cpp: Added.

2:54 AM Changeset in webkit [19025] by zack

• 2 edits in trunk/WebCore

Fix Qt build