⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 24, 2007:

11:21 PM Changeset in webkit [22835] by adele
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady and Oliver.

Moved keyEvent method from FrameWin to EventHandler and updated
call sites. Now this method is shared with the mac.

  • bridge/win/FrameWin.cpp:
  • bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Brady and Oliver.

Moved keyEvent method from FrameWin to EventHandler and updated
call sites. Now this method is shared with the mac.

  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
11:12 PM Changeset in webkit [19108] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady and Oliver.

Test for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node

  • fast/events/keydown-keypress-focus-change-expected.txt: Added.
  • fast/events/keydown-keypress-focus-change.html: Added.

WebCore:

Reviewed by Brady and Oliver.

Fix for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node

Test: fast/events/keydown-keypress-focus-change.html

  • page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): Added for convenience. (WebCore::EventHandler::keyEvent): Moved from EventHandlerMac.mm. After dispatching the keyDown event, recheck the target node for the keyPress event in case its changed.
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): Moved the bulk of this code to EventHandler.cpp.
10:36 PM Changeset in webkit [22834] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Make downloads cancellable

10:07 PM Changeset in webkit [19107] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

  • fix crash seen in layout tests
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): Add back the line of code that sets savedMouseEvents to nil. I thought it was a field of the EventSendingController, but it's actually a global.
9:10 PM Changeset in webkit [19106] by oliver
  • 2 edits in trunk/WebKit

2007-01-24 Oliver Hunt <​oliver@apple.com>

Build fix

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
8:50 PM Changeset in webkit [22833] by ggaren
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej Stachowiak, Steve Falkenberg, Adam Roben.


Fixed 4946729 -- CFNetwork needs some JS API symbols.


Added hack to compile JSStringRefCF symbols with WebKit, to avoid having to fork
the JavaScriptCore project into the internal repository.

  • WebKit.vcproj/WebKit.def: Export the symbols.
  • WebKit.vcproj/WebKit.vcproj:
8:38 PM Changeset in webkit [19105] by ggaren
  • 4 edits
    1 add in trunk

JavaScriptCore:

Fixed up #include order for style. No review necessary.

  • API/JSStringRef.cpp:

WebCore:

New forwarding header. No review necessary.

  • ForwardingHeaders/kjs/ustring.h: Added.
8:36 PM Changeset in webkit [19104] by oliver
  • 5 edits in trunk

Oliver Hunt <​oliver@apple.com>
WebCore:

Reviewed by Maciej.

Migrating more drag state information to WebCore

  • page/DragController.cpp:
  • page/DragController.h: (WebCore::DragController::dragOperation): (WebCore::DragController::setDraggingImageURL): (WebCore::DragController::draggingImageURL): (WebCore::DragController::setDragOffset): (WebCore::DragController::dragOffset):

WebKit:

Reviewed by Maciej.

Migrating more drag state information to WebCore

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView _mayStartDragAtEventLocation:]): (-[WebHTMLView close]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView _delegateDragSourceActionMask]):
  • WebView/WebHTMLViewInternal.h:


8:36 PM Changeset in webkit [19103] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy JSStringRefCF, in case anybody wants to use it. (I just added it recently.)
8:34 PM Changeset in webkit [19102] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/events/autoscroll-expected.checksum: Added.
  • fast/events/autoscroll-expected.png: Added.
  • fast/events/autoscroll-expected.txt: Added.
  • fast/events/autoscroll.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/events/autoscroll.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Adjust position to be relative to the object's corner for the hit test, but not for the scrollRectToVisible call. The previous version accidentally re-used the version that was adjusted for the hit test.
8:27 PM Changeset in webkit [19101] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • changed dragMode to be a property instead of a function
  • DumpRenderTree/EventSendingController.h: Renamed inDragMode to dragMode.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed setDragMode. (+[EventSendingController isKeyExcludedFromWebScript:]): Added dragMode. (-[EventSendingController init]): Updated for name change. (-[EventSendingController leapForward:]): Ditto. (-[EventSendingController mouseUp]): Ditto. (-[EventSendingController mouseMoveToX:Y:]): Ditto.
8:17 PM Changeset in webkit [19100] by bdakin
  • 12 edits
    4 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/4948128> REGRESSION: A crash occurs at
WebCore::Frame::view() after completing a query at mapquest.com
then switching to Bookmarks view

This is just a null-check. If you are in strict mode and ask for
the clientWidth or clientHeight after the document was removed from
it's parent, we no longer have a frameView, so we have to null-
check it. I added null checks for the FrameView in some other
places where it seems like we could potentially run into this
issue.

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/4948128> REGRESSION: A crash occurs at
WebCore::Frame::view() after completing a query at mapquest.com
then switching to Bookmarks view

  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved.html: Added.
8:12 PM Changeset in webkit [19099] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • made the deferral of mouse events until drag completes conditional it's needed for drag testing, and harmful for selection testing
  • DumpRenderTree/EventSendingController.h: Added inDragMode boolean.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Added setDragMode:. (+[EventSendingController webScriptNameForSelector:]): Added name for setDragMode, and remove unneeded clearKillRing name. (-[EventSendingController init]): Initialize inDragMode to true. (-[EventSendingController dealloc]): Removed overzealous assertions -- we should not be asserting things that are dependent on the test content! (-[EventSendingController leapForward:]): Only queue events in drag mode. (-[EventSendingController setDragMode:]): Added. (-[EventSendingController mouseDown]): Removed overzealous assertion. (-[EventSendingController mouseUp]): Removed overzealous assertions. Only queue events in drag mode. (-[EventSendingController mouseMoveToX:Y:]): Only queue events in drag mode.
8:04 PM Changeset in webkit [19098] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma

Reviewed by Zalan.
DESC: ResolveEmbedded link not called for plugins
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12400

8:03 PM Changeset in webkit [19097] by mjs
  • 1 edit
    1 delete in trunk/WebCore

Not reviewed, just removing accidentally committed file.

  • removed file that shouldn't be there
  • Image Viewer/Image Viewer.aps: Removed.
8:01 PM Changeset in webkit [19096] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, trivial property change.


  • JavaScriptCore.vcproj/JavaScriptCore.sln: remove svn:mime-type property which made this binary.
6:31 PM Changeset in webkit [19095] by adele
  • 1 edit in trunk/WebKit/ChangeLog

Updating with correct bug number

6:20 PM Changeset in webkit [19094] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff and Adam.

<rdar://problem/4922655>
​http://galeri.milliyet.com.tr/ reproducibly crashes Safari

  • fast/dom/resources/set-frame-src-while-running-script-in-frame.html: Added.
  • fast/dom/set-frame-src-while-running-script-in-frame-expected.txt: Added.
  • fast/dom/set-frame-src-while-running-script-in-frame.html: Added.

WebCore:

Reviewed by Geoff and Adam.

<rdar://problem/4922655>
​http://galeri.milliyet.com.tr/ reproducibly crashes Safari


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): If the frame already exists, defer the navigation so that we won't end up replacing the document while we're parsing it. This is similar to what setting window.location ends up doing.
6:12 PM Changeset in webkit [22832] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Debug only instrumentation for WebDownload

6:07 PM Changeset in webkit [19093] by adele
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Small improvement to my last checkin to prevent the keyEventWasInterpreted bool from
being overwritten by reentrancy.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:]): Point keyEventWasInterpreted pointer to local variable. (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView/WebHTMLViewInternal.h: Added BOOL pointer that will point to the local variable on the stack in _interceptEditingKeyEvent
5:38 PM Changeset in webkit [19092] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison


Adding this layout test for a bug fixed by the changes
in r19088.

  • editing/execCommand/4916402-expected.checksum: Added.
  • editing/execCommand/4916402-expected.png: Added.
  • editing/execCommand/4916402-expected.txt: Added.
  • editing/execCommand/4916402.html: Added.
5:37 PM Changeset in webkit [22831] by sfalken
  • 8 edits in branches/WindowsMerge
5:34 PM Changeset in webkit [19091] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow

  • fast/events/arrow-navigation-expected.txt: Added.
  • fast/events/arrow-navigation.html: Added.

WebKit:

Reviewed by Darin.

  • Fix for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow

Keep track of whether interpretKeyEvents handles the key event based on whether or not we get
called in insertText or doCommandBySelector.

Test: fast/events/arrow-navigation.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): (-[WebHTMLView _interceptEditingKeyEvent:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView/WebHTMLViewInternal.h:
5:25 PM Changeset in webkit [19090] by bdash
  • 8 edits in trunk

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

  • Info.plist: Update copyright string.
5:10 PM Changeset in webkit [19089] by andersca
  • 5 edits in trunk/LayoutTests

Reviewed by Maciej.

Fix tests and update test results.


  • fast/dom/gc-6-expected.txt:
  • fast/dom/gc-6.html:
  • fast/dom/gc-7-expected.txt:
  • fast/dom/gc-7.html:
5:00 PM Changeset in webkit [19088] by justing
  • 16 edits
    10 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4916235>
<rdar://problem/4857269>
<rdar://problem/4916583>
<rdar://problem/4928635>


Fixed and removed FIXME:

  • editing/execCommand/create-list-from-range-selection-expected.checksum:
  • editing/execCommand/create-list-from-range-selection-expected.png:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-from-range-selection.html: Added:
  • editing/deleting/4916235-1-expected.txt: Added.
  • editing/deleting/4916235-1.html: Added.
  • editing/execCommand/4916235-expected.txt: Added.
  • editing/execCommand/4916235.html: Added.
  • editing/execCommand/4916583-expected.checksum: Added.
  • editing/execCommand/4916583-expected.png: Added.
  • editing/execCommand/4916583-expected.txt: Added.
  • editing/execCommand/4916583.html: Added.
  • editing/execCommand/4928635-expected.txt: Added.
  • editing/execCommand/4928635.html: Added. Equivalent trees:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt: Introduced an extraneous newline because of the poor substitute for VisiblePosition creation in shouldEmitNewlineAfterNode:
  • dom/xhtml/level3/core/nodecomparedocumentposition12-expected.txt:
  • dom/xhtml/level3/core/nodecomparedocumentposition17-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore09-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4916235>
eBay Editor: Crash occurs at WebCore::Range::startPosition() after applying ordered list styling to selected text
<rdar://problem/4857269>
REGRESSION: editing/execCommand/create-list-from-range-selection.html no longer works as intended
<rdar://problem/4916583>
eBay Editor: Removing a indent from a list item actually deletes the list item instead
<rdar://problem/4928635>
designMode outdent causes crash (11750)

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Fixed br insertion after the pruning of empty containers left over after the paragraph to move is removed.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): There are bugs that leave the wrong number of line breaks after a deletion that expands to include special elements (lists/tables). Added a workaround so that moveParagraphs can avoid these until they are fixed. (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto. (WebCore::DeleteSelectionCommand::initializePositionData): Ditto.
  • editing/DeleteSelectionCommand.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): We used to not call exitNode for ancestors of a node where the next node in a pre-order traversal is the ranges's pastEndNode(). This is only correct for ancestors that contain the end of the range. (WebCore::shouldEmitNewlineAfterNode): Added, we should only emit newlines after blocks that have VisiblePositions after them. VisiblePosition creation though is too expensive to do here, what I added here is an OK substitute. (WebCore::shouldEmitNewlineBeforeNode): Added. No special logic yet. (WebCore::TextIterator::handleNonTextNode): Call shouldEmitNewlineBeforeNode. (WebCore::TextIterator::exitNode): Call shouldEmitNewlineAfterNode. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Call shouldEmitNewlineAfterNode.
4:39 PM Changeset in webkit [22830] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

  • WebView.cpp: (WebViewWndProc): Don't send focus/blur events when the previous/newly focused window is a child of ours.
4:22 PM Changeset in webkit [19087] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

  • JavaScriptCore.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.

WebCore:

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.

WebKit:

Reviewed by Mark Rowe.

  • WebKit.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.
4:16 PM Changeset in webkit [19086] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

  • a couple minor tweaks to recently-changed things
  • dom/Document.h: Use HTMLHeadElement as type for the head function.
  • dom/Document.cpp: (WebCore::Document::head):
  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::~SVGElementInstance): Change loop to a for loop and use a local variable for document.
2:45 PM Changeset in webkit [19085] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Minor edit of previous changelog entry

2:40 PM Changeset in webkit [19084] by oliver
  • 3 edits in trunk/WebCore

2007-01-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Adele.

Fixes DragController to allow a null target Document.
This is encountered in new tabs/windows that have not
loaded any page (including about:blank)

  • page/DragController.cpp: (WebCore::documentAtPoint): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeDrag):
  • page/mac/DragControllerMac.mm: (WebCore::DragController::dragOperation):
2:04 PM Changeset in webkit [22829] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-24 Ada Chan <​adachan@apple.com>

Forgot a null check.

  • WebDownload.cpp: (WebDownload::request):


1:49 PM Changeset in webkit [19083] by brmorris
  • 2 edits in S60/branches/3.1m/S60Tools

2007-01-24 brmorris <​thisisbradley@gmail.com>

Reviewed by me :D

DESC: Merge prepare-ChangeLog.bat from s60/trunk to 3.1m branch

1:43 PM Changeset in webkit [19082] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser crashes in tab navigation mode when page load is cancelled
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12397

1:43 PM Changeset in webkit [19081] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser crashes in tab navigation mode when page load is cancelled
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12397

1:28 PM Changeset in webkit [19080] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12394
Cleanup RenderBox

No functionality changes, just a good old fashion cleanup,
thus no tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy): (WebCore::RenderBox::setPos): (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::cacluateBackgroundSize): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::dirtyLineBoxes): (WebCore::RenderBox::position): (WebCore::RenderBox::getAbsoluteRepaintRect): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved): (WebCore::RenderBox::relativePositionOffsetX): (WebCore::RenderBox::relativePositionOffsetY): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcVerticalMargins): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::caretRect):
  • rendering/RenderBox.h: (WebCore::RenderBox::setOverrideSize): (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::setWidth): (WebCore::RenderBox::setHeight): (WebCore::RenderBox::inlineBoxWrapper): (WebCore::RenderBox::setInlineBoxWrapper): (WebCore::RenderBox::stretchesToViewHeight): (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY):
12:11 PM Changeset in webkit [22828] by adachan
  • 7 edits in branches/WindowsMerge/WebKitWin

2007-01-24 Ada Chan <​adachan@apple.com>

Reviewed by Brady.


More hookup of Downloads.


  • Implemented WebDownload::request().
  • Implemented accessors for download delegate in webview.
  • Interfaces/IWebDownload.idl:
  • Interfaces/IWebError.idl:
  • WebDownload.cpp: (WebDownload::WebDownload): (WebDownload::initWithRequest): (WebDownload::request): (WebDownload::willSendRequest):
  • WebDownload.h:
  • WebView.cpp: (WebView::setDownloadDelegate): (WebView::downloadDelegate):
  • WebView.h:
10:54 AM Changeset in webkit [22827] by aroben
  • 3 edits
    1 add in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Added PlatformScrollBarSafari for Aqua scroll bars.

10:48 AM Changeset in webkit [19079] by darin
  • 2 edits in trunk/WebKit

Reviewed by Adele.

  • fix small regression and GC problems noticed by code inspection
  • WebView/WebHTMLView.mm: Move global declarations to the start of the file. (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Add a CFRetain here for GC compatibility. (+[WebHTMLView _insertablePasteboardTypes]): Ditto. (-[WebHTMLView performKeyEquivalent:]): Fix small logic mistake that prevents super from being called if EventHandler::keyEvent returns false. Reformatted the code a bit and added a local variable for the frame. (-[WebHTMLView _interceptEditingKeyEvent:]): Added some comments. (-[WebHTMLView validAttributesForMarkedText]): Add a CFRetain here for GC compatibility.
10:46 AM Changeset in webkit [19078] by eseidel
  • 19 edits in trunk/WebCore

2007-01-24 Eric Seidel <​eric@webkit.org>

Reviewed by ap.

Converted SVGTransform from being Shared<T> to a POD type.

No functional changes, thus no tests.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/misc/SVGTimer.cpp: (WebCore::baseValueTransformList):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::handleStartCondition): (WebCore::SVGAnimateTransformElement::applyAnimationToValue): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientProperties):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternProperties):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientProperties):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGTransform): (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::updateLocalTransform):
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::updateLocalTransform):
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::isValid):
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransform.idl:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate): (SVGTransformList::concatenate):
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
9:12 AM Changeset in webkit [19077] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas <​zbujtas@gmail.com>

Reviewed by Darin.
DESC: 'index' variable is not declared, change it to 'start'
​http://bugs.webkit.org/show_bug.cgi?id=12378

  • kwq/KWQString.cpp: (QString::mid):
5:09 AM Changeset in webkit [19076] by lars
  • 9 edits in trunk

Reviewed by Zack

WebKitQt:
Implement some bits and pieces required by the loader.
Fixes quite a few crashes and hangs in the lyout tests

DumpRenderTree:
Add a signal handler, always dump immediately if we get an
error during a page load and raise the timeout to 5 seconds
(as we get a lot less such failures now)

3:04 AM Changeset in webkit [19075] by bdash
  • 4 edits in trunk/WebCore

2007-01-24 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric.

Plug another bunch of SVG memory leaks.

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Delete memory we have allocated. (WebCore::SVGDocumentExtensions::removePendingResource): Return an auto_ptr to show that we are transferring ownership.
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Update for use of auto_ptr.
12:42 AM Changeset in webkit [22826] by beidson
  • 1 edit in branches/WindowsMerge/WebKitWin/DefaultDownloadDelegate.cpp

Build Fix

Jan 23, 2007:

11:43 PM Changeset in webkit [22825] by beidson
  • 16 edits
    6 adds in branches/WindowsMerge

Initial checkin of downloads for boomer

11:05 PM Changeset in webkit [19074] by lars
  • 3 edits in trunk/WebKitQt

Fix compilation again.

10:26 PM Changeset in webkit [22824] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
10:16 PM Changeset in webkit [19073] by bdash
  • 4 edits in trunk/WebCore

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Brady.

Plug thousands of node leaks seen running layout tests.

  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::~SVGElementInstance): Disassociate ourselves from our children so they will be destroyed if we were the only thing referencing them.
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument):
  • ksvg2/svg/SVGUseElement.h:
9:43 PM Changeset in webkit [22823] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Fixed <rdar://4949278> cut/copy/paste not working in subframes

  • WebView.cpp: (WebView::cutEnabled): (WebView::copyEnabled): (WebView::pasteEnabled): (WebView::deleteEnabled): (WebView::editingEnabled): (WebView::deleteSelection): (WebView::copy): (WebView::cut): (WebView::paste): (WebView::copyURL): (WebView::delete_): get the focusedOrMainFrame() instead of mainFrame()
9:33 PM Changeset in webkit [19072] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): minor change. removing unnecessary call to frame to fetch editor
9:08 PM Changeset in webkit [19071] by aliceli1
  • 2 edits in trunk/JavaScriptCore

release build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h
7:44 PM Changeset in webkit [19070] by bdash
  • 5 edits
    6 adds in trunk

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

Fix regression by making setTitle/updateTitle/removeTitle logic match document.title
specification at ​http://whatwg.org/specs/web-apps/current-work/#the-title1.

  • dom/Document.cpp: (WebCore::Document::setTitle): Materialize a title element into the head if one doesn't exist when setting document.title. Also update the contents of the title element when the title is set via document.title. (WebCore::Document::removeTitle): Update the title based on first title element in the head, if one exists. (WebCore::Document::head): Convenience method to retrieve the head element in an HTML document.
  • dom/Document.h:

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Adele.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

  • fast/dom/Document/title-property-creates-title-element-expected.txt: Added.
  • fast/dom/Document/title-property-creates-title-element.html: Added.
  • fast/dom/Document/title-property-set-multiple-times-expected.txt: Added.
  • fast/dom/Document/title-property-set-multiple-times.html: Added.
  • fast/dom/title-text-property-2.html: Remove in reverse order to preserve test behaviour when removing title elements.
  • svg/custom/multiple-title-elements.svg: Added.
6:16 PM Changeset in webkit [19069] by adele
  • 3 edits in trunk/WebKit

Reviewed by Adam.

Fixed 2 layout tests that I broke with my last checkin.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Use the selected frame to get the WebHTMLView.
  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Added global to keep track of NSEvent used here. (-[WebHTMLView _interceptEditingKeyEvent:]): Check NSEvent against the event used in performKeyEquivalent. We don't want to intercept these events.
5:24 PM Changeset in webkit [19068] by ggaren
  • 2 edits in trunk/JavaScriptCore

build fix

4:17 PM Changeset in webkit [19067] by bdash
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo.

4:17 PM Changeset in webkit [19066] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-01-24 Mark Rowe <​mrowe@apple.com>

Build fix for DumpRenderTree.

  • JavaScriptCore.xcodeproj/project.pbxproj: Make JSStringRefCF.h public so it's copied into build framework.
3:38 PM Changeset in webkit [19065] by bdakin
  • 7 edits in trunk

WebCore:

Reviewed by Hyatt.

Follow-up to the fix below for 4843226.

  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Has to be recursive or we will miss out on grandchildren!

LayoutTests:

Reviewed by Hyatt.

Updated test for 4843226 to include a grandchild.

  • fast/clip/nestedTransparencyClip-expected.checksum:
  • fast/clip/nestedTransparencyClip-expected.png:
  • fast/clip/nestedTransparencyClip-expected.txt:
  • fast/clip/nestedTransparencyClip.html:
3:37 PM Changeset in webkit [22822] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:27 PM Changeset in webkit [19064] by sfalken
  • 1 copy in tags/Safari-521.32.14b

New tag.

3:23 PM Changeset in webkit [19063] by oliver
  • 2 edits in trunk/WebCore

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fixes dropping of files into safari

  • page/DragController.cpp: (WebCore::DragController::performDrag):
3:11 PM Changeset in webkit [22821] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Fix for <rdar://49233536> shift-pageup in textareas
This fix is pretty much identical to the shift-backspace
one I just did, so I'm piggybacking on that review.

3:06 PM Changeset in webkit [22820] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.


  • plugins/win/PluginStreamWin.cpp: Change WebReasonNone to -2, some plugins return -1 to indicate error.


(WebCore::PluginStreamWin::stop):
Just don't clear the loader, stop loading as well.


(WebCore::PluginStreamWin::startStream):
Destroy the stream if newstream returns an error.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): If the call to toString throws an exception, clear it.

WebKitWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.


  • Interfaces/IWebError.idl: Add error code.


  • WebFrame.cpp: (WebFrame::redirectDataToPlugin): Cancel loading the main resource.


(WebFrame::windowObjectCleared):
Use toRef.

2:47 PM Changeset in webkit [19062] by andersca
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h
2:47 PM Changeset in webkit [19061] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by john


<rdar://problem/4947130>
REGRESSION: Items duplicated when moved inside contenteditable element (11766)

  • editing/pasteboard/4947130-expected.checksum: Added.
  • editing/pasteboard/4947130-expected.png: Added.
  • editing/pasteboard/4947130-expected.txt: Added.
  • editing/pasteboard/4947130.html: Added.
2:39 PM Changeset in webkit [22819] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed Maciej.

fixed <rdar://4923536> pressing shift-backspace inserts a bad character

  • WebView.cpp: added to keyEntries an entry for the commands accounting for modifiers
2:36 PM Changeset in webkit [22818] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-23 Steve Falkenburg <​sfalken@apple.com>

Fix release build.

  • WebCore.vcproj/WebCore.vcproj:
2:32 PM Changeset in webkit [19060] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Darin

Added a couple of CF things previously missed

2:23 PM Changeset in webkit [19059] by ggaren
  • 7 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/4885131> Move CFString function declarations from
JSStringRef.h to JSStringRefCF.h


Also removed remaining API FIXMEs and changed them into Radars.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Added Radar numbers for UTF8 conversion.
  • API/JSContextRef.cpp: (JSGlobalContextCreate): Replaced FIXME for NULL JSContextRef with Radar number.
  • API/JSObjectRef.h: Removed FIXME, which is unprofessional in a public header.
  • API/JSStringRef.cpp: Moved CF related implementations to JSStringRefCF.cpp. (JSStringCreateWithUTF8CString): Replaced FIXME with Radar number.
  • API/JSStringRef.h: Moved CF related declarations to JSStringRefCF.h. Added #include of JSStringRefCF.h as a stopgap until clients start #including it as needed by themselves.
  • API/JSStringRefCF.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString): Replaced JSChar cast with UniChar cast, which is more appropriate for a CF call.
  • API/JSStringRefCF.h: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
2:11 PM Changeset in webkit [19058] by zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Fix evil genericContext() assertion, which occours sometimes when running DRT.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12379

1:52 PM Changeset in webkit [19057] by brmorris
  • 2 edits in S60/trunk/WebKit

ssareen <​shyam.sareen@nokia.com>

Reviewed by Sachin/Brad.


DESC: Invalid WAP CSS formats not being ignored ( TSW ID: TMCN-6S5K87)
​http://bugs.webkit.org/show_bug.cgi?id=12230

  • BrowserCore/Formcontrols/src/FControlformathandler.cpp: (CInputFormatHandler::ConstructL):
1:50 PM Changeset in webkit [22817] by adele
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added call to paintThemeTextArea.

1:45 PM Changeset in webkit [19056] by bdakin
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4843226> REGRESSION: Pull down menu appears
clipped at ​http://istweb.apple.com/

  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Always unite with sibling rects.

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4843226> REGRESSION: Pull down menu
appears clipped at ​http://istweb.apple.com/

  • fast/clip/nestedTransparencyClip-expected.checksum: Added.
  • fast/clip/nestedTransparencyClip-expected.png: Added.
  • fast/clip/nestedTransparencyClip-expected.txt: Added.
  • fast/clip/nestedTransparencyClip.html: Added.
1:10 PM Changeset in webkit [19055] by justing
  • 4 edits
    6 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteEx

WebCore:

Reviewed by john

<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteExtract()

  • dom/Range.cpp: (WebCore::Range::checkDeleteExtract): Return if there is no commonAncestor container or if commonAncestorContainer() throws an exception.
  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Fixed a bug that reversed the order of the selected paragraphs.
12:55 PM Changeset in webkit [19054] by brmorris
  • 3 edits in S60/trunk/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: WAP CSS specific character format causing phone keypad input error ( TSW ID: TMCN-6S5MSE)
​http://bugs.webkit.org/show_bug.cgi?id=12232

12:31 PM Changeset in webkit [19053] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

raalexan

Reviewed by Sachin
DESC: MLIO-6XLCE4 Returning from page overview shows the toolbar
​http://bugs.webkit.org/show_bug.cgi?id=id=12366

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
12:21 PM Changeset in webkit [19052] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

w3liu <​wei.liu@nokia.com>

Reviewed by Zalan, landed by Brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12371

12:19 PM Changeset in webkit [19051] by brmorris
  • 2 edits in S60/trunk/WebCore

w3liu <​wei.liu@nokia.com>

Reviewed by Zalan, landed by brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites

​http://bugs.webkit.org/show_bug.cgi?id=12371

12:04 PM Changeset in webkit [19050] by zimmermann
  • 25 edits
    64 adds in trunk

Reviewed by Sam.

Fix dynamic creation/updates of markers, masks, clipPaths, and several tiny pattern issues.
Added 16 (!) new layout tests covering quite some weird scenerios - Batik & Opera do have problems, we don't.

11:48 AM Changeset in webkit [22816] by adele
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.


Reorganized some event handling code for keyPress events to
prepare for another fix.


  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Added.
  • WebEditorClient.h: Removed unnecessary forward declarations.
11:37 AM Changeset in webkit [19049] by adele
  • 21 edits in trunk

WebCore:

Reviewed by Darin.


WebCore part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail

In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix. There's also just a little bit of unrelated cleanup.


  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Move tab focus behavior into new defaultKeyboardEventHandler method.


  • bridge/EditorClient.h: Added handleKeyPress.
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Added. Calls over to the client method. (WebCore::Editor::deleteRange): Removed unnecessary propogateDOMException.
  • editing/Editor.h: Added handleKeyPress. (WebCore::Editor::addToKillRing): Formatting cleanup.
  • editing/mac/EditorMac.mm: Removed unnecessary propogateDOMException.


  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Added. Checks the tabKeyCyclesThroughElements setting before advancing focus for tab key events. Calls handleKeyPress.
  • page/EventHandler.h: Added defaultKeyboardEventHandler.


  • page/Page.cpp: (WebCore::Page::Page): Initialize m_tabKeyCyclesThroughElements to true.
  • page/Page.h: Added m_tabKeyCyclesThroughElements. (WebCore::Page::setTabKeyCyclesThroughElements): Added. (WebCore::Page::tabKeyCyclesThroughElements): Added.


  • platform/PlatformKeyboardEvent.h: Added ability to get NSEvent from PlatformKeyboardEvent.
  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Initialize m_macEvent to the NSEvent.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): Added.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail


In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix.

  • WebCoreSupport/WebEditorClient.h: Added handleKeyPress method.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Added. Code moved from WebHTMLView keyDown method. This is called from the defaultEventHandler so that in the future, we can make the right decision about which selection the keyPress should apply to.
  • WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Moved _interceptEditingKeyEvent call to handleKeyPress. (-[WebHTMLView _interceptEditingKeyEvent:]): Prevents intercepting keys for cmd-modified events. Removed tabCycling checks since this is now handled in WebCore.
  • WebView/WebHTMLViewInternal.h: Made _interceptEditingKeyEvent SPI.
  • WebView/WebView.mm: Use new tabKeyCyclesThroughElements methods on the page. (-[WebViewPrivate init]): ditto. (-[WebView setTabKeyCyclesThroughElements:]): ditto. (-[WebView tabKeyCyclesThroughElements]): ditto. (-[WebView setEditable:]): ditto
10:36 AM Changeset in webkit [19048] by staikos
  • 2 edits in trunk

Temporary measure to make it possible to use the Qt port until the official Qt
API is done

10:24 AM Changeset in webkit [22815] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Build fixes.


  • WebCore.vcproj/WebCore.vcproj: Copy plugin and JS headers.


  • loader/win/FrameLoaderWin.cpp: Move functions to WebKitWin.

WebKitWin:

Build fixes.


  • WebFrame.cpp: (WebFrame::createFrame): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::objectContentType): (WebFrame::overrideMediaType): (WebFrame::windowObjectCleared):
  • WebFrame.h: Move functions here from WebFrameLoaderWin in WebCore.
10:18 AM Changeset in webkit [19047] by staikos
  • 2 edits in trunk/WebCore

Compile with a released Qt.

8:35 AM Changeset in webkit [19046] by lars
  • 6 edits in trunk

Reviewed by Zack

Widget and ScrollView do not own the Qt widgets
anymore. Make sure they can handle the case of
a null QWidget and never delete them.

Fix refcounting of FrameViews (they get created with a
refcount of 1) and add a few safety checks to the
FrameLoaderClientQt.

6:35 AM Changeset in webkit [19045] by zack
  • 2 edits in trunk/WebCore

Forgot to add this file to the build (fix the build for real)

5:39 AM Changeset in webkit [19044] by zack
  • 4 edits in trunk/WebKitQt

Adjust the DragClient to latest changes.

2:32 AM Changeset in webkit [19043] by zack
  • 8 edits in trunk

Fix the Qt build

2:28 AM Changeset in webkit [19042] by lars
  • 25 edits
    2 deletes in trunk

Reviewed by Maciej

Make the last remaining pieces of the FrameLoader platform
independent. Move most of the code over to WebFrameLoaderClient.
Some smaller cleanups in the WebFrameBridge, and moved some
platform independent functionality over to the shared code
in WebCore.

Add support for Frames to the Qt build and fix some issues
in the API classes.

1:33 AM Changeset in webkit [22814] by oliver
  • 11 edits
    4 adds in branches/WindowsMerge

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.


WebKitWin:

Attaching the DragController logic to the WebView

  • Interfaces/IWebUIDelegate.idl: Fixed a couple of function definitions to use IDataObject instead of IDropSource
  • WebDragClient.cpp: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction):
  • WebDragClient.h: Added. DragClient implementation.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (dragOperationToDragCursor): (keyStateToDragOperation): (WebView::DragEnter): (WebView::DragOver): (WebView::DragLeave): (WebView::Drop): Set up and register WebView as an IDropTarget, and pass off drag events to the DragController
  • WebView.h: Ditto


WebCoreWin:

  • WebCore.vcproj/WebCore.vcproj:
  • page/win/DragControllerWin.cpp: Added. (WebCore::DragController::dragOperation): (WebCore::DragController::isCopyKeyDown): Platform specific implementation
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::isForDragging):
  • platform/win/ClipboardWin.h: Migrated common Clipboard functionality from ClipboardMac/Win -> Clipboard
  • platform/win/DragDataWin.cpp: Added. (WebCore::DragData::createClipboard): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::DragData::containsURL): (WebCore::extractURL): (WebCore::DragData::asURL): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::containsHTML): (WebCore::fragmentFromHTML): (WebCore::containsFilenames): (WebCore::fragmentFromFilenames): (WebCore::DragData::containsColor): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asFragment): (WebCore::DragData::asColor): Implementation of DragData accesor methods, and helper functions
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor
  • platform/win/PasteboardWin.cpp: (WebCore::fragmentFromCF_HTML): (WebCore::Pasteboard::documentFragment): Pulled out CF_HTML parsing to a seperate function so logic can be shared with DragDataWin


1:15 AM Changeset in webkit [19041] by oliver
  • 2 edits
    2 adds in trunk/WebKitQt

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Qt build stubs for Drop logic

  • WebCoreSupport/DragClientQt.cpp: Added. (WebCore::DragClientQt::actionMaskForDrag): (WebCore::DragClientQt::willPerformDragDestinationAction):
  • WebCoreSupport/DragClientQt.h: Added.
  • WebKitPart/WebKitPart.cpp: (WebKitPart::initView):
1:14 AM Changeset in webkit [19040] by oliver
  • 9 edits
    4 adds in trunk/WebKit

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Drop logic bindings for WebKit

  • WebCoreSupport/WebDragClient.h: Added.
  • WebCoreSupport/WebDragClient.mm: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): Standard client impl
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Updated to use DragController to track drag state


  • WebCoreSupport/WebPasteboardHelper.h: Added. (WebPasteboardHelper::WebPasteboardHelper): A *temporary* Helper class to access NSPasteboard access and manipulation functions present in WebKit
  • WebCoreSupport/WebPasteboardHelper.mm: Added. (WebPasteboardHelper::urlFromPasteboard): (WebPasteboardHelper::plainTextFromPasteboard): (WebPasteboardHelper::fragmentFromPasteboard): (WebPasteboardHelper::insertablePasteboardTypes): See header comment
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentInternal.h: Remove unnecessary protocol
  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): Updating to use DragController to track drag state
  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): ditto (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): ditto (-[WebHTMLView draggingSourceOperationMaskForLocal:]): ditto (-[WebHTMLView draggedImage:endedAt:operation:]): ditto (-[WebHTMLView _documentFragmentForPasteboard:]): Helper method to generate DocumentFragment from NSPasteboard without regressing (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Updating to use DragController to track drag state (-[WebHTMLView _isMoveDrag:]): (-[WebHTMLView _isNSColorDrag:]):
  • WebView/WebHTMLViewInternal.h: Removing unnecessary fields and methods
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Remove obsolete ASSERT (-[WebView _setInitiatedDrag:]): Now passes directly through to DragController (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _loadingDragOperationForDraggingInfo:]): Removed (-[WebView draggingEntered:]): Updated to use DragController (-[WebView draggingUpdated:]): ditto (-[WebView draggingExited:]): ditto (-[WebView performDragOperation:]): ditto (-[WebView _hitTest:dragTypes:]):
  • WebView/WebViewInternal.h: remove unnecessary method def
1:12 AM Changeset in webkit [19039] by oliver
  • 17 edits
    12 adds in trunk/WebCore

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Added DragController to handled drag and drop state and control logic.
Currently this only handles logic for Dragging and Dropping, and is
unable to initialise a drag itself.

platform/DragData encapsulate the paltform Drag data (NSDraggingInfo on Mac,
QMimeType in Qt). This provides methods to pull data out the drag data as a String,
a URL, a DocumentFragment (for rich content), or a Colour.

  • WebCore.exp:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.cpp: Added. (WebCore::Clipboard::setAccessPolicy): (WebCore::dragOpFromIEOp): (WebCore::IEOpFromDragOp): (WebCore::Clipboard::sourceOperation): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setSourceOperation): (WebCore::Clipboard::setDestinationOperation): (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed): move platform independent functions from ClipboardMac to Clipboard
  • dom/Clipboard.h: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::dropEffect): (WebCore::Clipboard::effectAllowed): (WebCore::Clipboard::policy): as above -- also removed virtual modifier from now platform independent methods
  • editing/Editor.cpp: (WebCore::Editor::smartInsertDeleteEnabled): (WebCore::Editor::shouldApplyStyle):
  • editing/Editor.h: adding calls through to EditorClient


  • page/DragActions.h: Added. (WebCore::): Replicates a number of NS* enums in the WebCore namespace
  • page/DragClient.h: Added. (WebCore::DragClient::~DragClient): Standard client interface for dragging UIDelegate
  • page/DragController.cpp: Added. (WebCore::createMouseEvent): (WebCore::DragController::DragController): (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::isMoveDrag): (WebCore::visiblePositionForPoint): (WebCore::DragController::cancelDrag): (WebCore::documentAtPoint): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): Class to handle state and logic for dragging and dropping
  • page/DragController.h: Added. (WebCore::DragController::client): (WebCore::DragController::didInitiateDrag): (WebCore::DragController::isHandlingDrag): (WebCore::DragController::dragOperation): (WebCore::DragController::document): (WebCore::DragController::dragInitiator): (WebCore::DragController::dragDestinationAction): (WebCore::DragController::dragSourceAction): (WebCore::DragController::dragEnded): (WebCore::DragController::setIsHandlingDrag): (WebCore::DragController::setDidInitiateDrag): (WebCore::DragController::setDragOperation): (WebCore::DragController::setDragSourceAction): (WebCore::DragController::setDragInitiator): See above
  • page/Page.cpp: (WebCore::Page::Page): Update Page to have DragController
  • page/Page.h: (WebCore::Page::dragController): ditto
  • page/mac/DragControllerMac.mm: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Platform specific portions of the DragController
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::dragSourceEndedAt): Convert from NSDragOperation to WebCore::DragOperation
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Remove obsolete Drag functions
  • page/qt/DragControllerQt.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Basic stubs to maintain Qt build
  • platform/DragData.cpp: Added. (WebCore::DragData::DragData):
  • platform/DragData.h: Added. (WebCore::DragData::clientPosition): (WebCore::DragData::globalPosition): (WebCore::DragData::platformData): (WebCore::DragData::draggingSourceOperationMask): DragData class to encapsulate platform drag data/event
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData): Addition of dummy DragClient
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::~SVGEmptyDragClient): (WebCore::SVGEmptyDragClient::willPerformDragDestinationAction): (WebCore::SVGEmptyDragClient::actionMaskForDrag): (WebCore::SVGEmptyDragClient::dragControllerDestroyed): ditto
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): Moving platform independent logic to Clipboard, and updating platform specific methods to use appropriate accessors rather than directly manipulating data they no longer own
  • platform/mac/DragDataMac.mm: Added. (WebCore::DragData::DragData): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::imageExistsAtPaths): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Mac implementations of DragData methods. A number of these use a Helper class that accesses WebKit functionality. That functionality should be migrated to WebCore in the future.
  • platform/mac/PasteboardHelper.h: Added. (WebCore::PasteboardHelper::~PasteboardHelper): Temporary, and Mac only, helper class to access WebKit functionality from WebCore
  • platform/qt/DragDataQt.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Basic stubs to maintain Qt build
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Correct HitTestResult copy contructor to copy localPoint
Note: See TracTimeline for information about the timeline view.