⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 25, 2007:

11:53 PM Changeset in webkit [22846] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fixed DragDataWin behaviour so that it will provide plain text
for a file dropped on the window.

  • platform/win/DragDataWin.cpp: (WebCore::DragData::asPlainText):
11:32 PM Changeset in webkit [22845] by beidson
  • 5 edits in branches/WindowsMerge/WebKitWin

Make WebDownloads no longer start themselves

11:30 PM Changeset in webkit [19136] by lars
  • 2 edits in trunk/JavaScriptCore

Patch from Jan Kraemer.

Reviewed by Maciej

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12382

Fix crash on architectures with 32 bit ints and
64 bit longs (For example Linux on AMD64)

8:25 PM Changeset in webkit [22844] by beidson
  • 1 edit in branches/WindowsMerge/WebCore/platform/network/cf/FormDataStreamCFNet.cpp

Fix the build for people who aren't me and aren't currently running ToT CF

7:18 PM Changeset in webkit [22843] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Prepare for upcoming CF/CFNetwork api changes

7:13 PM Changeset in webkit [22842] by adele
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added support for slider.

4:51 PM Changeset in webkit [22841] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-25 Ada Chan <​adachan@apple.com>

WebDownload.cpp reviewed by Brady.
WebFrame.cpp reviewed by Anders.

  • WebDownload.cpp: (WebDownload::cancel): added null check
  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): fixed bug that we treated loading image urls as downloads.
4:35 PM Changeset in webkit [22840] by aroben
  • 6 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve and Darin.

3:56 PM Changeset in webkit [22839] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:51 PM Changeset in webkit [19135] by kdecker
  • 4 edits in trunk/WebKit

Backed out my last patch because it crashes espn.com. Stay tuned for a newer version..

  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPlugin:]): Removed call to streamIsDead.
  • Plugins/WebBaseNetscapePluginView.h: Removed streamIsDead.
  • Plugins/WebBaseNetscapePluginView.mm: Ditto.
3:46 PM Changeset in webkit [19134] by sfalken
  • 1 copy in tags/Safari-521.32.15b

New tag.

3:05 PM Changeset in webkit [19133] by justing
  • 5 edits in trunk

LayoutTests:

Reviewed by oliver


<​http://bugs.webkit.org/show_bug.cgi?id=12409>
REGRESSION (r19039): Drag caret isn't cleared after a drop

  • editing/pasteboard/4947130-expected.checksum:
  • editing/pasteboard/4947130-expected.png:

WebCore:

Reviewed by oliver


<​http://bugs.webkit.org/show_bug.cgi?id=12409>
REGRESSION (r19039): Drag caret isn't cleared after a drop

No new layout tests because the regression was
caught by current layout tests.

  • page/DragController.cpp: (WebCore::DragController::concludeDrag): Clear the drag caret.
3:01 PM Changeset in webkit [22838] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-25 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
2:46 PM Changeset in webkit [19132] by darin
  • 3 edits in trunk/WebKit

Reviewed by Beth.

  • fix <rdar://problem/4952766> Safari has a top secret color picker that can be used to... uhh... I don't know
  • Panels/English.lproj/WebAuthenticationPanel.nib/info.nib: Let Interface Builder have its way.
  • Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Remove the NSColorWell that was in here (for no good reason).
1:30 PM Changeset in webkit [19131] by kdecker
  • 4 edits in trunk/WebKit

Reviewed by andersca.

A few tweaks with of a fix done by Steve Gehrman.

Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory

​http://bugs.webkit.org/show_bug.cgi?id=11523

  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView streamIsDead:]
  • Plugins/WebBaseNetscapePluginView.h: Added streamIsDead to header.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView streamIsDead:]): Added. Removes the stream from the streams collection.
12:21 PM Changeset in webkit [19130] by ggaren
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoffrey Garen.


Added tests for ​http://bugs.webkit.org/show_bug.cgi?id=12342
REGRESSION: destroying a frame from its own script causes various crashes


Thanks to Alexey Proskuryakov for the original versions of these tests.

  • fast/dom/exception-no-frame-inline-script-crash-expected.txt: Added.
  • fast/dom/exception-no-frame-inline-script-crash.html: Added.
  • fast/dom/exception-no-frame-timeout-crash-expected.txt: Added.
  • fast/dom/exception-no-frame-timeout-crash.html: Added.

WebCore:

Reviewed and landed by Geoffrey Garen.

  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute): Use RefPtr for the frame and the interpreter object so they don't get deleted out from underneath us.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Add a check for a page of 0. This was the only call site for the addMessageToConsole function that did not have a check for a page of 0.
11:52 AM Changeset in webkit [19129] by lars
  • 2 edits
    94 adds in trunk/LayoutTestResults

Add the next 100 test cases.

11:27 AM Changeset in webkit [19128] by lars
  • 2 edits
    300 adds in trunk/LayoutTestResults

Add more test cases that pass on the Qt build.

10:42 AM Changeset in webkit [19127] by lars
  • 2 edits
    157 adds in trunk/LayoutTestResults

The tests in dom/svg and dom/xhtml as well as
most of the remaining tests in tables/ pass now as
well, so lets run the test suite over them.

10:13 AM Changeset in webkit [19126] by bdakin
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

LayoutTests:

Test for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

  • fast/parser/parseCommentsInTitles-expected.checksum: Added.
  • fast/parser/parseCommentsInTitles-expected.png: Added.
  • fast/parser/parseCommentsInTitles-expected.txt: Added.
  • fast/parser/parseCommentsInTitles.html: Added.
10:12 AM Changeset in webkit [19125] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: ISHG-6S8Q5X fix list marker offset problem.
markers get off when the marker image, specified in CSS, is 404.
fix: issue relayout, when the errorImage is set on the marker.

​http://bugs.webkit.org/show_bug.cgi?id=12404


10:12 AM Changeset in webkit [19124] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: ISHG-6S8Q5X fix list marker offset problem.
markers get off when the marker image, specified in CSS, is 404.
fix: issue relayout, when the errorImage is set on the marker.

​http://bugs.webkit.org/show_bug.cgi?id=12404

9:41 AM Changeset in webkit [22837] by aroben
  • 6 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Part of <rdar://problem/4855618> HTML-based load failure pages.

  • Interfaces/IWebError.idl: Added failingURL method declaration.
  • WebError.cpp: (WebError::failingURL): Implemented.
  • WebError.h: Updated for interface changes.
  • WebFrame.cpp: (WebFrame::loadHTMLString): New protected helper method called by IWebFrame::loadHTMLString and IWebFrame::loadAlternateHTMLString. (WebFrame::loadAlternateHTMLString): Calls loadHTMLString.
  • WebFrame.h: Added new declaration.
8:09 AM Changeset in webkit [19123] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

spadma

Reviewed by Zalan.
DESC: ResolveEmbedded link not called for plugins (ASAA-6X5DX8)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12400

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPluginL):
7:39 AM Changeset in webkit [19122] by darin
  • 2 edits in trunk/WebCore
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: Add a couple of comments.
7:33 AM Changeset in webkit [19121] by darin
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for bugs found by code inspection in the SVGPreserveAspectRatio parser
  • svg/dom/preserve-aspect-ratio-parser-expected.txt: Added.
  • svg/dom/preserve-aspect-ratio-parser.html: Added.

WebCore:

Reviewed by Maciej.

  • fix ​http://bugs.webkit.org/show_bug.cgi?id=12365 Reproducible crash in WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio in svg/W3C-SVG-1.1/animate-elem-40-t.svg under guard malloc
  • fix bug where the parser accepts "meet" or "slice" as an entire string
  • fix bug where "slice" is ignored if the old alignment was "none" even if the newly-parsed alignment is something other than "none", and "slice" is not ignored if the old alignment was not "none", but the newly-parsed alignment is "none"
  • optimize to only call notifyAttributeChange if the attribute actually changed

Test: svg/dom/preserve-aspect-ratio-parser-test.html

  • ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::checkString): Added an overload for using char* constants which is much simpler than the old one, and almost as fast. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Fail if there's no more text after "defer". Fail if there's neither "none" nor an x/y specified. Check that there's more text before looking at the "m" and "s" for "meet" and "slice". Merged the failure and success cases. Only call notifyAttributeChange if something changed.

I think all the "optimized" code where we check the first character before
calling checkString isn't really helpful, but I decided to leave it as-is
for now.

6:54 AM Changeset in webkit [19120] by lars
  • 3 edits in trunk/WebCore

Reviewed by Zack

Trivial implementation of getMIMETypeForExtension.
Use the above method in the ResourceHandleManager to set
a mimetype on Resources that don't have one set (which
includes everything loaded from local disk).

Should fix quite a few test cases :)

6:20 AM Changeset in webkit [19119] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Kevin, Geoff, Brady, and Darin


  • fixed <rdar://problem/4918446> Safari's temp files (PDF's) should be in a sub-folder when calling Preview


  • WebView/WebPDFView.mm: (-[WebPDFView _path]): use _temporaryPDFDirectoryPath method instead of #defines for hardwiring strings; stop bad practice of modifying the const char* returned by fileSystemRepresentation (-[WebPDFView _temporaryPDFDirectoryPath]): new method, lazily creates and returns a secure temporary directory created with NSTemporaryDirectory() and mkdtemp
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes
6:03 AM Changeset in webkit [19118] by lars
  • 2 edits
    808 adds in trunk/LayoutTestResults

Add more test results for the Qt build.

5:06 AM Changeset in webkit [19117] by zack
  • 2 edits in trunk/WebCore

Path from Harald Fernengel to fix compile on platforms
where qreal is not a double.
r=me

4:48 AM Changeset in webkit [19116] by zack
  • 7 edits
    1 add in trunk/WebCore

implement wheel event handling and use eventhandler explictly.
r=lars

3:07 AM BuildingOnWindows edited by ext-daniel.knauth@nokia.com
(diff)
2:54 AM Changeset in webkit [19115] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12391
SVG containers with viewports should respect overflow when hit testing
Take into account the overflow property when hit testing <svg>.

2:04 AM Changeset in webkit [19114] by lars
  • 2 edits in trunk/WebKitQt

Reviewed by Zack

Emit the loadDone() signal from teh onload event callback
again. This hangs on one or two test cases, but removes
hundreds of failures elsewhere.

2:04 AM Changeset in webkit [19113] by lars
  • 2 edits in trunk/LayoutTestResults

remove dom/html/level2/html from skipped tests.

12:56 AM Changeset in webkit [19112] by lars
  • 611 adds in trunk/LayoutTestResults

Add css1 and css2.1 test results for the Qt build

12:54 AM Changeset in webkit [19111] by lars
  • 4 edits
    1 delete in trunk/WebKitTools

Reviewed by Darin and Zack

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12398


Move the test results for Qt into a directory of it's own
(WebKit/LayoutTestResults/qt). Leave the Mac results where
they are for now and share the text only results between
Mac and Qt.

Add support for a LayoutTestResults/platform/Skipped file
to run-webkit-tests to be able to ignore certain tests

Remove the old tests-skipped.txt from Qts DumpRenderTree
implementation.

12:47 AM Changeset in webkit [22836] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-25 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Maciej.


Added init methods instead of doing all the initialization in the constructor.
There was a lifetime issue with passing the WebDownload to delegate calls when
its ref count is still 0.

  • WebDownload.cpp: (WebDownload::init): (WebDownload::createInstance):
  • WebDownload.h:


12:38 AM Changeset in webkit [19110] by aliceli1
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

added test for
<rdar://problem/4808039> REGRESSION: eBay ID check never completes
also known as
​http://bugs.webkit.org/show_bug.cgi?id=11230

  • http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • http/tests/misc/location-replace-crossdomain.html: Added.
  • http/tests/misc/resources/failure.html: Added.
  • http/tests/misc/resources/success.html: Added.

WebCore:

Reviewed by Maciej.

fixed <rdar://problem/4808039> REGRESSION: eBay ID check never completes
Also known as ​http://bugs.webkit.org/show_bug.cgi?id=11230

  • bindings/js/kjs_window.cpp: It's not necessary to check safeScript when doing a location.replace, .reload, or .assign (KJS::Location::getOwnPropertySlot): (KJS::LocationFunc::callAsFunction):
12:34 AM Changeset in webkit [19109] by aliceli1
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff and Adele

added test for <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320

  • editing/execCommand/copy-without-selection-expected.txt: Added.
  • editing/execCommand/copy-without-selection.html: Added.

WebCore:

Reviewed by Geoff and Adele.

fixed <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320

  • editing/Editor.cpp: (WebCore::Editor::canDHTMLCut): (WebCore::Editor::canDHTMLCopy): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Reverting some mistakes made in r17504: Anything in r17503 that used to call mayDHTML* still calls canDHTML* as it was changed in r17504, where canDHTML* now calls !selectionController::isInPasswordField instead of editor::canCopy Anything else in r17503 that used to call mayCopy now calls (!)selectionController::isInPasswordField.
  • editing/JSEditor.cpp: copy via JS should be enabled as long as selection is not in a password field. a range selection shouldn't be required.

Jan 24, 2007:

11:21 PM Changeset in webkit [22835] by adele
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady and Oliver.

Moved keyEvent method from FrameWin to EventHandler and updated
call sites. Now this method is shared with the mac.

  • bridge/win/FrameWin.cpp:
  • bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Brady and Oliver.

Moved keyEvent method from FrameWin to EventHandler and updated
call sites. Now this method is shared with the mac.

  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
11:12 PM Changeset in webkit [19108] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady and Oliver.

Test for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node

  • fast/events/keydown-keypress-focus-change-expected.txt: Added.
  • fast/events/keydown-keypress-focus-change.html: Added.

WebCore:

Reviewed by Brady and Oliver.

Fix for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node

Test: fast/events/keydown-keypress-focus-change.html

  • page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): Added for convenience. (WebCore::EventHandler::keyEvent): Moved from EventHandlerMac.mm. After dispatching the keyDown event, recheck the target node for the keyPress event in case its changed.
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): Moved the bulk of this code to EventHandler.cpp.
10:36 PM Changeset in webkit [22834] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Make downloads cancellable

10:07 PM Changeset in webkit [19107] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

  • fix crash seen in layout tests
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): Add back the line of code that sets savedMouseEvents to nil. I thought it was a field of the EventSendingController, but it's actually a global.
9:10 PM Changeset in webkit [19106] by oliver
  • 2 edits in trunk/WebKit

2007-01-24 Oliver Hunt <​oliver@apple.com>

Build fix

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
8:50 PM Changeset in webkit [22833] by ggaren
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej Stachowiak, Steve Falkenberg, Adam Roben.


Fixed 4946729 -- CFNetwork needs some JS API symbols.


Added hack to compile JSStringRefCF symbols with WebKit, to avoid having to fork
the JavaScriptCore project into the internal repository.

  • WebKit.vcproj/WebKit.def: Export the symbols.
  • WebKit.vcproj/WebKit.vcproj:
8:38 PM Changeset in webkit [19105] by ggaren
  • 4 edits
    1 add in trunk

JavaScriptCore:

Fixed up #include order for style. No review necessary.

  • API/JSStringRef.cpp:

WebCore:

New forwarding header. No review necessary.

  • ForwardingHeaders/kjs/ustring.h: Added.
8:36 PM Changeset in webkit [19104] by oliver
  • 5 edits in trunk

Oliver Hunt <​oliver@apple.com>
WebCore:

Reviewed by Maciej.

Migrating more drag state information to WebCore

  • page/DragController.cpp:
  • page/DragController.h: (WebCore::DragController::dragOperation): (WebCore::DragController::setDraggingImageURL): (WebCore::DragController::draggingImageURL): (WebCore::DragController::setDragOffset): (WebCore::DragController::dragOffset):

WebKit:

Reviewed by Maciej.

Migrating more drag state information to WebCore

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView _mayStartDragAtEventLocation:]): (-[WebHTMLView close]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView _delegateDragSourceActionMask]):
  • WebView/WebHTMLViewInternal.h:


8:36 PM Changeset in webkit [19103] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy JSStringRefCF, in case anybody wants to use it. (I just added it recently.)
8:34 PM Changeset in webkit [19102] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/events/autoscroll-expected.checksum: Added.
  • fast/events/autoscroll-expected.png: Added.
  • fast/events/autoscroll-expected.txt: Added.
  • fast/events/autoscroll.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/events/autoscroll.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Adjust position to be relative to the object's corner for the hit test, but not for the scrollRectToVisible call. The previous version accidentally re-used the version that was adjusted for the hit test.
8:27 PM Changeset in webkit [19101] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • changed dragMode to be a property instead of a function
  • DumpRenderTree/EventSendingController.h: Renamed inDragMode to dragMode.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed setDragMode. (+[EventSendingController isKeyExcludedFromWebScript:]): Added dragMode. (-[EventSendingController init]): Updated for name change. (-[EventSendingController leapForward:]): Ditto. (-[EventSendingController mouseUp]): Ditto. (-[EventSendingController mouseMoveToX:Y:]): Ditto.
8:17 PM Changeset in webkit [19100] by bdakin
  • 12 edits
    4 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/4948128> REGRESSION: A crash occurs at
WebCore::Frame::view() after completing a query at mapquest.com
then switching to Bookmarks view

This is just a null-check. If you are in strict mode and ask for
the clientWidth or clientHeight after the document was removed from
it's parent, we no longer have a frameView, so we have to null-
check it. I added null checks for the FrameView in some other
places where it seems like we could potentially run into this
issue.

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/4948128> REGRESSION: A crash occurs at
WebCore::Frame::view() after completing a query at mapquest.com
then switching to Bookmarks view

  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved.html: Added.
8:12 PM Changeset in webkit [19099] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • made the deferral of mouse events until drag completes conditional it's needed for drag testing, and harmful for selection testing
  • DumpRenderTree/EventSendingController.h: Added inDragMode boolean.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Added setDragMode:. (+[EventSendingController webScriptNameForSelector:]): Added name for setDragMode, and remove unneeded clearKillRing name. (-[EventSendingController init]): Initialize inDragMode to true. (-[EventSendingController dealloc]): Removed overzealous assertions -- we should not be asserting things that are dependent on the test content! (-[EventSendingController leapForward:]): Only queue events in drag mode. (-[EventSendingController setDragMode:]): Added. (-[EventSendingController mouseDown]): Removed overzealous assertion. (-[EventSendingController mouseUp]): Removed overzealous assertions. Only queue events in drag mode. (-[EventSendingController mouseMoveToX:Y:]): Only queue events in drag mode.
8:04 PM Changeset in webkit [19098] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma

Reviewed by Zalan.
DESC: ResolveEmbedded link not called for plugins
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12400

8:03 PM Changeset in webkit [19097] by mjs
  • 1 edit
    1 delete in trunk/WebCore

Not reviewed, just removing accidentally committed file.

  • removed file that shouldn't be there
  • Image Viewer/Image Viewer.aps: Removed.
8:01 PM Changeset in webkit [19096] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, trivial property change.


  • JavaScriptCore.vcproj/JavaScriptCore.sln: remove svn:mime-type property which made this binary.
6:31 PM Changeset in webkit [19095] by adele
  • 1 edit in trunk/WebKit/ChangeLog

Updating with correct bug number

6:20 PM Changeset in webkit [19094] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff and Adam.

<rdar://problem/4922655>
​http://galeri.milliyet.com.tr/ reproducibly crashes Safari

  • fast/dom/resources/set-frame-src-while-running-script-in-frame.html: Added.
  • fast/dom/set-frame-src-while-running-script-in-frame-expected.txt: Added.
  • fast/dom/set-frame-src-while-running-script-in-frame.html: Added.

WebCore:

Reviewed by Geoff and Adam.

<rdar://problem/4922655>
​http://galeri.milliyet.com.tr/ reproducibly crashes Safari


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): If the frame already exists, defer the navigation so that we won't end up replacing the document while we're parsing it. This is similar to what setting window.location ends up doing.
6:12 PM Changeset in webkit [22832] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Debug only instrumentation for WebDownload

6:07 PM Changeset in webkit [19093] by adele
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Small improvement to my last checkin to prevent the keyEventWasInterpreted bool from
being overwritten by reentrancy.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:]): Point keyEventWasInterpreted pointer to local variable. (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView/WebHTMLViewInternal.h: Added BOOL pointer that will point to the local variable on the stack in _interceptEditingKeyEvent
5:38 PM Changeset in webkit [19092] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison


Adding this layout test for a bug fixed by the changes
in r19088.

  • editing/execCommand/4916402-expected.checksum: Added.
  • editing/execCommand/4916402-expected.png: Added.
  • editing/execCommand/4916402-expected.txt: Added.
  • editing/execCommand/4916402.html: Added.
5:37 PM Changeset in webkit [22831] by sfalken
  • 8 edits in branches/WindowsMerge
5:34 PM Changeset in webkit [19091] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow

  • fast/events/arrow-navigation-expected.txt: Added.
  • fast/events/arrow-navigation.html: Added.

WebKit:

Reviewed by Darin.

  • Fix for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow

Keep track of whether interpretKeyEvents handles the key event based on whether or not we get
called in insertText or doCommandBySelector.

Test: fast/events/arrow-navigation.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): (-[WebHTMLView _interceptEditingKeyEvent:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView/WebHTMLViewInternal.h:
5:25 PM Changeset in webkit [19090] by bdash
  • 8 edits in trunk

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

  • Info.plist: Update copyright string.
5:10 PM Changeset in webkit [19089] by andersca
  • 5 edits in trunk/LayoutTests

Reviewed by Maciej.

Fix tests and update test results.


  • fast/dom/gc-6-expected.txt:
  • fast/dom/gc-6.html:
  • fast/dom/gc-7-expected.txt:
  • fast/dom/gc-7.html:
5:00 PM Changeset in webkit [19088] by justing
  • 16 edits
    10 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4916235>
<rdar://problem/4857269>
<rdar://problem/4916583>
<rdar://problem/4928635>


Fixed and removed FIXME:

  • editing/execCommand/create-list-from-range-selection-expected.checksum:
  • editing/execCommand/create-list-from-range-selection-expected.png:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-from-range-selection.html: Added:
  • editing/deleting/4916235-1-expected.txt: Added.
  • editing/deleting/4916235-1.html: Added.
  • editing/execCommand/4916235-expected.txt: Added.
  • editing/execCommand/4916235.html: Added.
  • editing/execCommand/4916583-expected.checksum: Added.
  • editing/execCommand/4916583-expected.png: Added.
  • editing/execCommand/4916583-expected.txt: Added.
  • editing/execCommand/4916583.html: Added.
  • editing/execCommand/4928635-expected.txt: Added.
  • editing/execCommand/4928635.html: Added. Equivalent trees:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt: Introduced an extraneous newline because of the poor substitute for VisiblePosition creation in shouldEmitNewlineAfterNode:
  • dom/xhtml/level3/core/nodecomparedocumentposition12-expected.txt:
  • dom/xhtml/level3/core/nodecomparedocumentposition17-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore09-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4916235>
eBay Editor: Crash occurs at WebCore::Range::startPosition() after applying ordered list styling to selected text
<rdar://problem/4857269>
REGRESSION: editing/execCommand/create-list-from-range-selection.html no longer works as intended
<rdar://problem/4916583>
eBay Editor: Removing a indent from a list item actually deletes the list item instead
<rdar://problem/4928635>
designMode outdent causes crash (11750)

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Fixed br insertion after the pruning of empty containers left over after the paragraph to move is removed.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): There are bugs that leave the wrong number of line breaks after a deletion that expands to include special elements (lists/tables). Added a workaround so that moveParagraphs can avoid these until they are fixed. (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto. (WebCore::DeleteSelectionCommand::initializePositionData): Ditto.
  • editing/DeleteSelectionCommand.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): We used to not call exitNode for ancestors of a node where the next node in a pre-order traversal is the ranges's pastEndNode(). This is only correct for ancestors that contain the end of the range. (WebCore::shouldEmitNewlineAfterNode): Added, we should only emit newlines after blocks that have VisiblePositions after them. VisiblePosition creation though is too expensive to do here, what I added here is an OK substitute. (WebCore::shouldEmitNewlineBeforeNode): Added. No special logic yet. (WebCore::TextIterator::handleNonTextNode): Call shouldEmitNewlineBeforeNode. (WebCore::TextIterator::exitNode): Call shouldEmitNewlineAfterNode. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Call shouldEmitNewlineAfterNode.
4:39 PM Changeset in webkit [22830] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

  • WebView.cpp: (WebViewWndProc): Don't send focus/blur events when the previous/newly focused window is a child of ours.
4:22 PM Changeset in webkit [19087] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

  • JavaScriptCore.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.

WebCore:

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.

WebKit:

Reviewed by Mark Rowe.

  • WebKit.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.
4:16 PM Changeset in webkit [19086] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

  • a couple minor tweaks to recently-changed things
  • dom/Document.h: Use HTMLHeadElement as type for the head function.
  • dom/Document.cpp: (WebCore::Document::head):
  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::~SVGElementInstance): Change loop to a for loop and use a local variable for document.
2:45 PM Changeset in webkit [19085] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Minor edit of previous changelog entry

2:40 PM Changeset in webkit [19084] by oliver
  • 3 edits in trunk/WebCore

2007-01-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Adele.

Fixes DragController to allow a null target Document.
This is encountered in new tabs/windows that have not
loaded any page (including about:blank)

  • page/DragController.cpp: (WebCore::documentAtPoint): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeDrag):
  • page/mac/DragControllerMac.mm: (WebCore::DragController::dragOperation):
2:04 PM Changeset in webkit [22829] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-24 Ada Chan <​adachan@apple.com>

Forgot a null check.

  • WebDownload.cpp: (WebDownload::request):


1:49 PM Changeset in webkit [19083] by brmorris
  • 2 edits in S60/branches/3.1m/S60Tools

2007-01-24 brmorris <​thisisbradley@gmail.com>

Reviewed by me :D

DESC: Merge prepare-ChangeLog.bat from s60/trunk to 3.1m branch

1:43 PM Changeset in webkit [19082] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser crashes in tab navigation mode when page load is cancelled
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12397

1:43 PM Changeset in webkit [19081] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser crashes in tab navigation mode when page load is cancelled
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12397

1:28 PM Changeset in webkit [19080] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12394
Cleanup RenderBox

No functionality changes, just a good old fashion cleanup,
thus no tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy): (WebCore::RenderBox::setPos): (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::cacluateBackgroundSize): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::dirtyLineBoxes): (WebCore::RenderBox::position): (WebCore::RenderBox::getAbsoluteRepaintRect): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved): (WebCore::RenderBox::relativePositionOffsetX): (WebCore::RenderBox::relativePositionOffsetY): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcVerticalMargins): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::caretRect):
  • rendering/RenderBox.h: (WebCore::RenderBox::setOverrideSize): (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::setWidth): (WebCore::RenderBox::setHeight): (WebCore::RenderBox::inlineBoxWrapper): (WebCore::RenderBox::setInlineBoxWrapper): (WebCore::RenderBox::stretchesToViewHeight): (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY):
12:11 PM Changeset in webkit [22828] by adachan
  • 7 edits in branches/WindowsMerge/WebKitWin

2007-01-24 Ada Chan <​adachan@apple.com>

Reviewed by Brady.


More hookup of Downloads.


  • Implemented WebDownload::request().
  • Implemented accessors for download delegate in webview.
  • Interfaces/IWebDownload.idl:
  • Interfaces/IWebError.idl:
  • WebDownload.cpp: (WebDownload::WebDownload): (WebDownload::initWithRequest): (WebDownload::request): (WebDownload::willSendRequest):
  • WebDownload.h:
  • WebView.cpp: (WebView::setDownloadDelegate): (WebView::downloadDelegate):
  • WebView.h:
10:54 AM Changeset in webkit [22827] by aroben
  • 3 edits
    1 add in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Added PlatformScrollBarSafari for Aqua scroll bars.

10:48 AM Changeset in webkit [19079] by darin
  • 2 edits in trunk/WebKit

Reviewed by Adele.

  • fix small regression and GC problems noticed by code inspection
  • WebView/WebHTMLView.mm: Move global declarations to the start of the file. (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Add a CFRetain here for GC compatibility. (+[WebHTMLView _insertablePasteboardTypes]): Ditto. (-[WebHTMLView performKeyEquivalent:]): Fix small logic mistake that prevents super from being called if EventHandler::keyEvent returns false. Reformatted the code a bit and added a local variable for the frame. (-[WebHTMLView _interceptEditingKeyEvent:]): Added some comments. (-[WebHTMLView validAttributesForMarkedText]): Add a CFRetain here for GC compatibility.
10:46 AM Changeset in webkit [19078] by eseidel
  • 19 edits in trunk/WebCore

2007-01-24 Eric Seidel <​eric@webkit.org>

Reviewed by ap.

Converted SVGTransform from being Shared<T> to a POD type.

No functional changes, thus no tests.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/misc/SVGTimer.cpp: (WebCore::baseValueTransformList):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::handleStartCondition): (WebCore::SVGAnimateTransformElement::applyAnimationToValue): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientProperties):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternProperties):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientProperties):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGTransform): (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::updateLocalTransform):
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::updateLocalTransform):
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::isValid):
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransform.idl:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate): (SVGTransformList::concatenate):
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
9:12 AM Changeset in webkit [19077] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas <​zbujtas@gmail.com>

Reviewed by Darin.
DESC: 'index' variable is not declared, change it to 'start'
​http://bugs.webkit.org/show_bug.cgi?id=12378

  • kwq/KWQString.cpp: (QString::mid):
5:09 AM Changeset in webkit [19076] by lars
  • 9 edits in trunk

Reviewed by Zack

WebKitQt:
Implement some bits and pieces required by the loader.
Fixes quite a few crashes and hangs in the lyout tests

DumpRenderTree:
Add a signal handler, always dump immediately if we get an
error during a page load and raise the timeout to 5 seconds
(as we get a lot less such failures now)

3:04 AM Changeset in webkit [19075] by bdash
  • 4 edits in trunk/WebCore

2007-01-24 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric.

Plug another bunch of SVG memory leaks.

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Delete memory we have allocated. (WebCore::SVGDocumentExtensions::removePendingResource): Return an auto_ptr to show that we are transferring ownership.
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Update for use of auto_ptr.
12:42 AM Changeset in webkit [22826] by beidson
  • 1 edit in branches/WindowsMerge/WebKitWin/DefaultDownloadDelegate.cpp

Build Fix

Note: See TracTimeline for information about the timeline view.