⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 28, 2007:

10:28 PM Changeset in webkit [19210] by staikos
  • 2 edits in trunk/WebCore

Fix redirects with the Qt resource implementation.

10:17 PM Changeset in webkit [19209] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


First step in fixing <rdar://problem/4485644> REGRESSION: JavaScriptCore
has init routines


Don't rely on a static initializer to store the main thread's ID (which
we would use to detect allocations on secondary threads). Instead, require
the caller to notify fastMalloc if it might allocate on a secondary thread.


Also fixed what seemed like a race condition in do_malloc.


tcmalloc_unittest and my custom versions of JS iBench and PLT show no
regressions.

  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): (1) Renamed from "fastMallocRegisterThread", which was a misleading name because not all threads need to register with fastMalloc -- only secondary threads need to, and only for the purpose of disabling its single-threaded optimization.

(2) Use the pageheap_lock instead of a custom one, since we need to synchronize
with the read of isMultiThreaded inside CreateCacheIfNecessary. This is a new
requirement, now that we can't guarantee that the first call to CreateCacheIfNecessary
will occur on the main thread at init time, before any other threads have been created.

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::do_malloc): Reverted WTF change only to call GetCache() if size <= kMaxSize.
The WTF code would read phinited without holding the pageheap_lock, which
seemed like a race condition. Regardless, calling GetCache reduces the number
of code paths to module initialization, which will help in writing the
final fix for this bug.

10:00 PM Changeset in webkit [19208] by bdash
  • 2 edits in trunk/WebCore

2007-01-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=11085
Bug 11085: REGRESSION: favicon.ico always looked for on port 80

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Copy the port over to the favicon URL.
7:22 PM Changeset in webkit [19207] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12453
REGRESSION(r19197): Tabbing into web page requires two key presses

All layout tests pass.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): If there's no focused frame, actually go ahead and find a focusable node instead of just focusing the main frame and quitting. This behavior was a holdover from a previous desired tabbing behavior with respect to frames.
7:10 PM Changeset in webkit [19206] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin and David Hyatt.

  • fast/block/basic/white-space-pre-wraps-expected.checksum: Added.
  • fast/block/basic/white-space-pre-wraps-expected.png: Added.
  • fast/block/basic/white-space-pre-wraps-expected.txt: Added.
  • fast/block/basic/white-space-pre-wraps.html: Added.

WebCore:

Reviewed by Darin and David Hyatt.

Test: fast/block/basic/white-space-pre-wraps.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Wrap a non-wrapping text run if it appears on a line with previous text runs that do wrap.
6:38 PM Changeset in webkit [19205] by ddkilzer
  • 1 edit in trunk/LayoutTests/ChangeLog

Removed files that were not committed from the ChangeLog entry.

6:36 PM Changeset in webkit [19204] by ddkilzer
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin. Patch by Mitz.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Added.
  • fast/layers/removed-by-scroll-handler-expected.png: Added.
  • fast/layers/removed-by-scroll-handler-expected.txt: Added.
  • fast/layers/removed-by-scroll-handler.html: Added.

WebCore:

Reviewed by Darin. Patch by Mitz.

Test: fast/layers/removed-by-scroll-handler.html

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added a m_enqueueEvents count. (WebCore::FrameView::layout): Raise the enqueue count before starting layout and until after enqueued events are dispatched. (WebCore::FrameView::scheduleEvent): Made this function dispatch the event immediately unless the enqueue count is positive.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): Schedule the scroll event through the FrameView. (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
6:30 PM Changeset in webkit [19203] by ddkilzer
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Creating a function using 'new Function()' was not setting its prototype with the
same flags as 'function() { }'.

Test: fast/js/function-prototype.html

  • kjs/function_object.cpp: (FunctionObjectImp::construct): Change flags from DontEnum|DontDelete|ReadOnly to Internal|DontDelete to match FuncDeclNode::processFuncDecl() and FuncExprNode::evaluate() in kjs/nodes.cpp.

LayoutTests:

Reviewed by Darin.

  • fast/js/function-prototype-expected.txt: Added.
  • fast/js/function-prototype.html: Added.
4:03 PM Changeset in webkit [19202] by eseidel
  • 9 edits
    2 adds in trunk/WebCore

2007-01-28 Charles Ying <​charles_ying@yahoo.com>

Reviewed by eseidel. Landed by eseidel.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12429

animateTransform rotate, with cx/cy is broken


SVGTransform now contains a float point to store the rotation center, needed

to track rotation center for interpolation by animateTransform.


SVGTransform now has an additional constructor:

SVGTransform(type) to make empty base value transforms that match their
distanced values.


Removed m_colorDistance and m_transformDistance from their respective classes

as they are now computed at update time.

Fix a case where animateTransform did not parse transform values correctly

according to BNF in W3C spec:

Test case in:

  • manual-tests/animation/animateTransform-toanimation.svg: Added.

Fix a case where animateTransform only specified a to animation only.

Test case in:

  • manual-tests/animation/animateTransform-parser.svg: Added.
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateColorElement::updateAnimatedValue): (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::updateAnimatedValue): (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateTransformElement::calculateFromAndToValues): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::angle): (SVGTransform::rotationCenter): (SVGTransform::setTranslate): (SVGTransform::setScale): (SVGTransform::setRotate): (SVGTransform::setSkewX): (SVGTransform::setSkewY):
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
  • ksvg2/svg/SVGTransformDistance.h:
  • manual-tests/animation/animateTransform-parser.svg: Added.
  • manual-tests/animation/animateTransform-toanimation.svg: Added.
2:48 PM Changeset in webkit [19201] by brmorris
  • 5 edits in S60/trunk/WebKit

spadma

DESC: Entering or leaving a secure web site causes several confirmations MLIO-6XCCTG
Reviewed by Zalan, merge of r19200 from 3.1 branch to s60/trunk by brad.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12415

2:12 PM Changeset in webkit [19200] by brmorris
  • 5 edits in S60/branches/3.1m/WebKit

spadma <​Sachin.Padma@nokia.com>

Reviewed by Zalan, landed by brad.
DESC: Entering or leaving a secure web site causes several confirmations MLIO-6XCCTG
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12415

11:35 AM Changeset in webkit [19199] by ap
  • 3 edits
    2 deletes in trunk/LayoutTests

Fixed a broken test to actually work (and fail).

  • dom/svg/level3/xpath/Conformance_ID-expected.checksum: Removed.
  • dom/svg/level3/xpath/Conformance_ID-expected.png: Removed.
  • dom/svg/level3/xpath/Conformance_ID-expected.txt:
  • dom/svg/level3/xpath/Conformance_ID.svg:
10:17 AM Changeset in webkit [19198] by brmorris
  • 8 edits in S60/trunk

bujtas <​zbujtas@gmail.com>

Rs'd by Brad
DESC: display fallback content in case of unsupported plugin.
​http://bugs.webkit.org/show_bug.cgi?id=12426

fix: webkit should return null, if the plugin is not supported.

  • bridge/WebCoreBridge.h:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::createPart): (KWQKHTMLPart::createSoundstart):

Jan 27, 2007:

10:00 PM Changeset in webkit [19197] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Ada.

Fix <rdar://problem/4957184> REGRESSION: After creating a new mail
message, the caret is automatically in message body

-[WebHTMLView _updateActiveState] was calling
FocusController::focusedOrMainFrame, which had the surprising
side-effect of setting the focused frame if there was none. The fix
was to remove this side-effect.

No tests possible, as this bug involves focus outside the WebView,
which we have no support for in DRT.

Change inspired by Dave Harrison.

  • page/FocusController.cpp: (WebCore::FocusController::focusedOrMainFrame): Removed this method's non-obvious side-effect of setting the focused frame.
  • WebCore.xcodeproj/project.pbxproj: Version wars.
8:39 PM Changeset in webkit [19196] by ddkilzer
  • 4 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11880: Improve some egregious
Windows form control drawing issues:
Provide Classic mode fallbacks for the button/textfield drawing
routines.
Provide some basic drawing of menulists (still relatively broken).
Some cleanup.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::RenderThemeWin::systemFont):
  • rendering/RenderThemeWin.cpp: (WebCore::m_menuListTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::determineClassicState): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton):
  • rendering/RenderThemeWin.h: (WebCore::ThemeData::m_classicState): (WebCore::RenderThemeWin::setRadioSize): (WebCore::RenderThemeWin::paintTextArea):
8:34 PM Changeset in webkit [19195] by ddkilzer
  • 11 edits in trunk

WebCore:

Reviewed by Adam.

  • loader/win/FrameLoaderWin.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::DocumentLoader::unreachableURL): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::createPlugin):

WebKit:

Reviewed by Adam.

  • COM/ChromeClientWin.cpp: (ChromeClientWin::canTakeFocus): (ChromeClientWin::takeFocus):
  • COM/ChromeClientWin.h:
  • COM/ContextMenuClientWin.cpp: (ContextMenuClientWin::getCustomMenuFromDefaultItems): (ContextMenuClientWin::searchWithGoogle):
  • COM/ContextMenuClientWin.h:
  • COM/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::download):
  • COM/WebFrameLoaderClient.h:
8:29 PM Changeset in webkit [19194] by ddkilzer
  • 1 edit
    4 adds in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (missing pixel test results).

  • fast/dom/gc-10-expected.checksum: Added.
  • fast/dom/gc-10-expected.png: Added.
  • http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
  • http/tests/misc/location-replace-crossdomain-expected.png: Added.
6:58 PM Changeset in webkit [19193] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.


Added some missing JSLocks, which might fix <rdar://problem/4889707>.

We need to lock whenever we might allocate memory because our FastMalloc
implementation requires clients to register their threads, which we do
through JSLock.


We also need to lock whenever modifying ref-counts because they're not
thread-safe.

  • API/JSObjectRef.cpp: (JSClassCreate): Allocates memory (JSClassRetain): Modifies a ref-count (JSClassRelease): Modifies a ref-count (JSPropertyNameArrayRetain): Modifies a ref-count (JSPropertyNameArrayRelease): Modifies a ref-count
  • API/JSStringRef.cpp: (JSStringRetain): Modifies a ref-count
  • API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Might allocate memory if an exception is thrown.
2:37 PM Changeset in webkit [19192] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

  • fast/lists/big-list-marker-expected.checksum: Added.
  • fast/lists/big-list-marker-expected.png: Added.
  • fast/lists/big-list-marker-expected.txt: Added.
  • fast/lists/big-list-marker.html: Added.

WebCore:

Reviewed by Mitz.

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Explicitly set the stroke size to 1.0f.
1:01 PM Changeset in webkit [19191] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/4958902> REGRESSION: Dashboard widgets fail to load


This was caused by the WebView preferences rework in r18417. Specifically, in
_updateWebCoreSettingsFromPreferences when calling setUserStyleSheetLocation,
[NSURL URLWithString:] is now messaged directly with the result of
preferences userStyleSheetLocation] _web_originalDataAsString, which will
be nil if the userStyleSheetLocation has not been set yet. [NSURL URLWithString:]
throws an exception when the string is nil. DashboardClient.app calls
setUserStyleSheetEnabled *before* calling setUserStyleSheetLocation.

  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]): Pass empty string instead of nil string to [NSURL URLWithString:].
12:34 PM Changeset in webkit [19190] by lars
  • 9 edits in trunk

Fix the Qt build and disable the usage
of QScrollbars for PlatformScrollBar for
now as it causes crashes in the layout tests.

7:52 AM Changeset in webkit [19189] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (buildbot build fix).

  • ksvg2/svg/ColorDistance.cpp: (WebCore::ColorDistance::scaledDistance): Added static cast of arguments to int.
7:00 AM Changeset in webkit [19188] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by NOBODY (typo in method name fix).

3:24 AM Changeset in webkit [19187] by eseidel
  • 3 edits
    1 add in trunk/WebCore

2007-01-27 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Fix support for SVG's <set> element.

Manual test added.

  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::updateAnimatedValue): (WebCore::SVGSetElement::calculateFromAndToValues):
  • ksvg2/svg/SVGSetElement.h:
  • manual-tests/animation/set-to.svg: Added.
2:16 AM Changeset in webkit [19186] by ap
  • 2 edits in trunk/WebCore

Release build fix.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
2:02 AM Changeset in webkit [19185] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12389
Chinese decoding error at hk.antispam.yahoo.com

Test: fast/encoding/noscript-in-head.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): We were already allowing NOSCRIPT tags in head, let's actually skip over their content.
12:13 AM Changeset in webkit [22859] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Fix <rdar://problem/4944863> WebError::localizedDescription needs to be implemented.

This was so simple, I don't know why I didn't do this before.

  • WebError.cpp: (WebError::localizedDescription): Implemented.
Note: See TracTimeline for information about the timeline view.