⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 30, 2007:

11:26 PM Changeset in webkit [19292] by bdash
  • 11 edits in trunk

2007-01-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

Enable -Wundef in WebKit, and change misuses of #if to #ifdef or #ifndef as appropriate.

  • Misc/WebKitLogging.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView delete:]): (-[WebHTMLView showGuessPanel:]): (-[WebHTMLView copy:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView validateUserInterfaceItem:]):
  • WebView/WebViewPrivate.h:

2007-01-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • dom/Document.h: Change #if XSLT_SUPPORT to #ifdef XSLT_SUPPORT.
11:20 PM Changeset in webkit [19291] by lars
  • 2 edits in trunk/WebCore

Fix the Qt build.

10:43 PM Changeset in webkit [19290] by zack
  • 6 edits in trunk/WebCore

Implement SVGImage on the Qt platform.
r=Eric

9:45 PM Changeset in webkit [19289] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • fixed <rdar://problem/4939366> REGRESSION: Assertion failure and crash when going back in history (12314)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): special case a frame name of "_blank" (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): ditto
9:24 PM Changeset in webkit [19288] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.

Filed some more Radars in other components, added some more leaks to the
exclusion list.

  • Scripts/run-webkit-tests: Ignore leaks in CFNotificationCenterAddObserver, CFRunLoopRunSpecific, and NSSpellChecker.
8:30 PM Changeset in webkit [19287] by bdash
  • 3 edits in tags/Safari-421.33

Versioning.

8:08 PM Changeset in webkit [19286] by bdash
  • 1 copy in tags/Safari-421.33

New tag.

7:50 PM Changeset in webkit [22876] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:39 PM Changeset in webkit [19285] by sfalken
  • 1 copy in tags/Safari-521.32.17b

New tag.

7:31 PM Changeset in webkit [19284] by ddkilzer
  • 3 edits
    1 copy
    25 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Created webarchive tests that exercise various features of the WebArchive format.

  • webarchive/resources/apple.gif: Copied from fast/canvas/resources/apple.gif.
  • webarchive/resources/dump-webarchive.js: Added.
  • webarchive/resources/test-frame.html: Added.
  • webarchive/resources/test-style.css: Added.
  • webarchive/test-body-background-expected.txt: Added.
  • webarchive/test-body-background.html: Added.
  • webarchive/test-duplicate-resources-expected.txt: Added.
  • webarchive/test-duplicate-resources.html: Added.
  • webarchive/test-frameset-expected.txt: Added.
  • webarchive/test-frameset.html: Added.
  • webarchive/test-img-src-expected.txt: Added.
  • webarchive/test-img-src.html: Added.
  • webarchive/test-input-src-expected.txt: Added.
  • webarchive/test-input-src.html: Added.
  • webarchive/test-link-href-expected.txt: Added.
  • webarchive/test-link-href.html: Added.
  • webarchive/test-object-data-expected.txt: Added.
  • webarchive/test-object-data.html: Added.
  • webarchive/test-script-src-expected.txt: Added.
  • webarchive/test-script-src.html: Added.
  • webarchive/test-table-background-expected.txt: Added.
  • webarchive/test-table-background.html: Added.
  • webarchive/test-td-background-expected.txt: Added.
  • webarchive/test-td-background.html: Added.

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
Alters WebResourceResponse and WebResourceURL properties within WebArchive format
to normalize URLs to remove path where WebKit was checked out. Also converts
WebDataResource properties from data to string if the corresponding
WebResourceMIMEType property starts with "text/" or equals
"application/x-javascript".

  • DumpRenderTree/DumpRenderTree.m: (convertWebResourceDataToString): Added. (normalizeWebResourceURL): Added. (normalizeWebResourceResponse): Added. (serializeWebArchiveToXML): Added. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Added. (runTest):
7:08 PM Changeset in webkit [19283] by brmorris
  • 8 edits in S60/branches/3.1m

yaharon, reviewed by zalan.

DESC: BrowserNG: Redundant password manager notification on secure pages (MLIO-6XXEVU)
​http://bugs.webkit.org/show_bug.cgi?id=12484
merge of r19282 to 3.1

7:03 PM Changeset in webkit [19282] by brmorris
  • 8 edits in S60/trunk

yaharon, reviewed by zalan.

DESC: BrowserNG: Redundant password manager notification on secure pages (MLIO-6XXEVU)
​http://bugs.webkit.org/show_bug.cgi?id=12484


6:40 PM Changeset in webkit [19281] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Anders.

  • fixed <rdar://problem/4963871> REGRESSION: Crash occurs at WebCore::Frame::loader() when attempting to open a saved archive file
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::request): Removed obsolete FIXME. (WebCore::DocumentLoader::initialRequest): Ditto.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): Handle data loads from a timer, otherwise bad things happen. (WebCore::MainResourceLoader::handleDataLoadNow): (WebCore::MainResourceLoader::handleDataLoadSoon): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::didCancel): cancel data load timer
  • loader/MainResourceLoader.h:
6:31 PM Changeset in webkit [19280] by beidson
  • 6 edits in trunk/WebKit

Reviewed by Oliver

This is a corollary to <rdar://problem/4944887> where certain things happened on an alternate thread.
To help catch such behavior in the future, add ASSERT_MAIN_THREAD() to key WebKit API points

  • History/WebHistoryItem.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (-[WebHistoryItem initWithWebCoreHistoryItem:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem target]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem children]): (-[WebHistoryItem URL]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]):
  • Misc/WebIconDatabase.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _iconForFileURL:withSize:]): (webGetNSImage):
  • Misc/WebKitLogging.h: Added ASSERT_MAIN_THREAD()
  • Misc/WebKitLogging.m: (WebKitRunningOnMainThread): Added
  • WebKit.xcodeproj/project.pbxproj: Define DISABLE_THREAD_CHECK until it is safe to run with ASSERT_MAIN_THREAD() active
4:52 PM Changeset in webkit [22875] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Fixes <rdar://problem/4889160>
If there's no backing store bitmap, don't try to update it!

4:08 PM Changeset in webkit [22874] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::setDefersLoading):
4:08 PM Changeset in webkit [22873] by sfalken
  • 12 edits in branches/WindowsMerge/WebKitWin
3:57 PM Changeset in webkit [19279] by hyatt
  • 4 adds in trunk/LayoutTests/fast/css

Add layout test for invalid pseudo-classes.

3:56 PM Changeset in webkit [19278] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4961953> Stop using NSString deprecated methods like initWithCString:

  • Misc/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]):
  • WebKit.xcodeproj/project.pbxproj:
3:55 PM Changeset in webkit [19277] by thatcher
  • 14 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4961953> Stop using NSString deprecated methods like initWithCString:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/svg/filters/cg/WKArithmeticFilter.m: (-[WKArithmeticFilter init]):
  • platform/graphics/svg/filters/cg/WKComponentMergeFilter.m: (-[WKComponentMergeFilter init]):
  • platform/graphics/svg/filters/cg/WKDiffuseLightingFilter.m: (-[WKDiffuseLightingFilter init]):
  • platform/graphics/svg/filters/cg/WKDiscreteTransferFilter.m: (-[WKDiscreteTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKDisplacementMapFilter.m: (-[WKDisplacementMapFilter init]):
  • platform/graphics/svg/filters/cg/WKDistantLightFilter.m: (-[WKDistantLightFilter init]):
  • platform/graphics/svg/filters/cg/WKGammaTransferFilter.m: (-[WKGammaTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKLinearTransferFilter.m: (-[WKLinearTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKNormalMapFilter.m: (-[WKNormalMapFilter init]):
  • platform/graphics/svg/filters/cg/WKPointLightFilter.m: (-[WKPointLightFilter init]):
  • platform/graphics/svg/filters/cg/WKSpecularLightingFilter.m: (-[WKSpecularLightingFilter init]):
  • platform/graphics/svg/filters/cg/WKSpotLightFilter.m: (-[WKSpotLightFilter init]):
  • platform/graphics/svg/filters/cg/WKTableTransferFilter.m: (-[WKTableTransferFilter init]):
3:54 PM Changeset in webkit [19276] by hyatt
  • 5 edits in trunk/WebCore

Fix for Radar bug #4679426, golden gate bridge Web site layout broken.


This is a regression caused by the addition of :lang support. This
feature caused us to accept any pseudo-class/element with function
arguments, even ones we couldn't handle. The site used such a construct
in conjunction with :not, which turned :not(something-crazy) into not(false).
This ended up being "true", and so we started matching a rule we used to
reject.

The fix is to now aggressively parse pseudo-elements and classes and to
cause the rejection of an entire rule if any pseudoclass or element within
any simple selector of that rule is unrecognized.

Reviewed by darin

fast/css/invalid-pseudo-classes.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
3:24 PM Changeset in webkit [19275] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • plugins/createScriptableObject-before-start-expected.txt: Added.
  • plugins/createScriptableObject-before-start.html: Added.

WebKit:

Reviewed by Geoff.

Test: plugins/createScriptableObject-before-start.html

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Return NULL if the plugin is not started.
3:14 PM Changeset in webkit [19274] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


<rdar://problem/4964407> REGRESSION: Mail hangs when replying, forwarding , or creating a new message


  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Set WebDataRequest property on data load requests since Mail specifically checks for this.
3:02 PM Changeset in webkit [19273] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/images/animated-background-image-crash-expected.txt: Added.
  • fast/images/animated-background-image-crash.html: Added.
  • fast/images/resources/animated.gif: Added.
  • fast/images/resources/animated2.gif: Added.

WebCore:

Reviewed by Darin.

Test: fast/images/animated-background-image-crash.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::arenaDelete): Deref() all background images and the border image.
2:57 PM Changeset in webkit [19272] by bdash
  • 1 edit
    2 moves in trunk/LayoutTests

2007-01-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Re-enable editing/pasteboard/paste-{RTFD,TIFF}.html now that a fix has been landed for:
​http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()

  • editing/pasteboard/paste-RTFD.html: Added.
  • editing/pasteboard/paste-RTFD.html-disabled: Removed.
  • editing/pasteboard/paste-TIFF.html: Added.
  • editing/pasteboard/paste-TIFF.html-disabled: Removed.
2:53 PM Changeset in webkit [19271] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • dom/EventTarget.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toNode): Use EventTargetNode instead of Node. Removed unneeded includes. Make EventTarget's destructor protected to make it clear that you should never delete one.
  • dom/EventTargetNode.h: (WebCore::EventTargetNode::toNode): Tweaked formatting. Updated for change to return value.
  • platform/graphics/BitmapImage.h: Updated comment for clarity. Marked FrameData Noncopyable.
  • platform/graphics/Image.h: Tweaked formatting.
  • platform/graphics/ImageAnimationObserver.h: Make ImageAnimationObserver's destructor protected to make it clear that you should never delete one.
2:36 PM Changeset in webkit [19270] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin (by way of Hyatt).

  • fast/table/inline-form-assert-expected.checksum: Added.
  • fast/table/inline-form-assert-expected.png: Added.
  • fast/table/inline-form-assert-expected.txt: Added.
  • fast/table/inline-form-assert.html: Added.

WebCore:

Reviewed by Darin (by way of Hyatt).

Test: fast/table/inline-form-assert.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): Changed the assertion to ignore inlines.
2:25 PM Changeset in webkit [19269] by weinig
  • 5 edits in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found

  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt: These tests now pass.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found

  • xml/XPathNSResolver.idl: added [ConvertNullStringTo=Null].
2:07 PM Changeset in webkit [19268] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/DateMath.cpp: Fix license header to reflect LGPL as the first license mentioned. We still mention the option of using under MPL or GPL since some of this code came from the Mozilla project with those license terms.
2:04 PM Changeset in webkit [19267] by andersca
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

Revert the parts of 19244 that removed deferring NSURLConnections, that was not a correct change.
Remove ASSERTS from loader.cpp that aren't true anymore since the callbacks are invoked without a handle
when loading a subresource from an archive.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading):
  • loader/loader.cpp: (WebCore::Loader::didFail): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):
1:57 PM Changeset in webkit [19266] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fix for <rdar://problem/4911504> REGRESSION: With a image selected, ctrl-clicking on page displays the wrong contextual menu items "Search in Google", "Search in Spotlight" and "Look up in Dictionary"
  • platform/ContextMenu.cpp: (WebCore::selectionContainsPossibleWord): Added. Returns true if there are some non-whitespace characters in the selection. (WebCore::ContextMenu::populate): Don't add SearchSpotlightItem, SearchWebItem, or LookInDictionaryItem if selectionContainsPossibleWord returns false.
12:59 PM Changeset in webkit [19265] by zimmermann
  • 12 edits
    4 adds in trunk

Reviewed by Oliver.

Respect stroke-width in absolute repaint rect calculations for SVG text.
Added test: svg/custom/text-repaint-including-stroke.svg

12:46 PM Changeset in webkit [19264] by sfalken
  • 2 edits in trunk/WebCore

2007-01-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Add missing includes.

  • ksvg2/svg/SVGElementInstance.cpp:
11:34 AM Changeset in webkit [22872] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-30 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
11:01 AM Changeset in webkit [19263] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12452
XPath id() function is not supported

WebCore:

  • xml/XPathFunctions.cpp: (WebCore::XPath::isWhitespace): A helper to detect XML whitespace.

(WebCore::XPath::FunId::isConstant):
(WebCore::XPath::FunId::doEvaluate):
(WebCore::XPath::FunctionMapping::):
Implemented id().

LayoutTests:

  • dom/svg/level3/xpath/Conformance_ID-expected.txt: This test now passes.
  • fast/xpath/complex-id-expected.txt: Added.
  • fast/xpath/complex-id.html: Added. A test for more advanced id() capabilities.
8:58 AM Changeset in webkit [19262] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed by yongjun/brad.
DESC: WAP CSS specific character format causing phone keypad input error TMCN-6S5MSE
​http://bugs.webkit.org/show_bug.cgi?id=12232

  • BrowserCore/Formcontrols/src/FControlformathandler.cpp: (TInputFormatChar::SuggestedCase):
7:47 AM Changeset in webkit [19261] by zack
  • 7 edits in trunk/WebCore

Make the gradients work on the Qt platform.
r=Sam

7:35 AM Changeset in webkit [19260] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed by yongjun
DESC: Invalid WAP CSS formats not being ignored - TMCN-6S5K87
​http://bugs.webkit.org/show_bug.cgi?id=12230

7:25 AM Changeset in webkit [19259] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen

Reviewed by ​joseph.ligman@nokia.com
DESC: Crash is detected when activating "Find" for the second time in page view.
​http://bugs.webkit.org/show_bug.cgi?id=12477

7:15 AM Changeset in webkit [19258] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun.

DESC: S60 3.2 Help: When application is launched via hyperlink, the cursor stays as wait cursor
​http://bugs.webkit.org/show_bug.cgi?id=12421

7:09 AM Changeset in webkit [19257] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed ​yongjun.zhang@nokia.com
DESC: Browser Control: Problem with History Stack when using custom datastore PKAI-6WGSHS
​http://bugs.webkit.org/show_bug.cgi?id=10325
(Additional fix then the last one)

6:22 AM Changeset in webkit [19256] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=12470
svn-create-patch creates duplicate patches for files within an added/modified directory

  • Scripts/svn-create-patch: (sub generateFileList($\%\%)): Ignore directories when generating the file list.
6:04 AM Changeset in webkit [19255] by bdash
  • 1 edit
    2 moves in trunk/LayoutTests

2007-01-31 Mark Rowe <​mrowe@apple.com>

Disable editing/pasteboard/paste-{RTFD,TIFF}.html so tests run to completion until a fix is landed for:
​http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()

  • editing/pasteboard/paste-RTFD.html: Removed.
  • editing/pasteboard/paste-RTFD.html-disabled: Added.
  • editing/pasteboard/paste-TIFF.html: Removed.
  • editing/pasteboard/paste-TIFF.html-disabled: Added.
4:44 AM Changeset in webkit [19254] by zimmermann
  • 21 edits
    36 adds
    1 delete in trunk

Reviewed by Eric & Oliver. Leak related fixes reviewed by Mark.

Finally make the SVG <use> implementation use the proper "shadow tree" concept,
which is also used by the HTML forms implementation. It's the first time in ksvg
history that <use> is not implement as a crude hack, but proper & sane.

4:09 AM Changeset in webkit [19253] by zack
  • 2 edits in trunk/WebKitQt

Improve QtLauncher to make it more useful as a testing tool.

3:09 AM Changeset in webkit [19252] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4928646> REGRESSION: manual-tests/remove-input-file-onchange.html crashes


  • platform/FileChooser.h: (WebCore::FileChooser::disconnected): New method, so the RenderFileControl can tell when it's gotten disconected.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Avoid calling repainted() when onChange() handler destroyed us.
2:20 AM Changeset in webkit [19251] by hausmann
  • 11 edits
    1 move
    1 add in trunk

For the Qt build combine JavaScriptCore and WebKit into one library, to make it possible to
build it with ELF visibility or on Windows without adding EXPORT macros to kjs all over the place.
r=zack

12:46 AM Changeset in webkit [19250] by zack
  • 5 edits in trunk

Make the Qt platform compile.

12:34 AM Changeset in webkit [19249] by zack
  • 2 edits in trunk/WebCore

Compile fix
r=aroben

12:13 AM Changeset in webkit [19248] by zack
  • 5 edits in trunk

Propagate the allows-scrolling property on the frames
correctly. If the frame has been constructed as non-
scrolling, respect that and don't show scrollbars.
r=Lars

Jan 29, 2007:

11:30 PM Changeset in webkit [22871] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: Removed old stub.
11:22 PM Changeset in webkit [22870] by beidson
  • 5 edits in branches/WindowsMerge

More engine download tweaks - still relies on a custom ToT CFNetwork until they submit

11:13 PM Changeset in webkit [22869] by mjs
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam & Steve.


  • hook up new cross-platform data-loading code
  • fixed <rdar://4910106> - Need to support loadData and loadHTMLString
  • WebFrame.cpp: (WebFrame::loadData): add a SharedBuffer overload, and implement IStream* version using that. (WebFrame::loadHTMLString): implement using loadData
  • WebFrame.h: prototype new method
10:09 PM Changeset in webkit [19247] by ggaren
  • 2 edits in trunk/WebCore

I am the chosen one! I have seen the faces of the final five! I will
save the WebKit build!


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):
9:32 PM Changeset in webkit [19246] by ap
  • 83 edits
    6 adds in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12464
Fix XPath test suite conversion problems

  • dom/svg/level3/xpath/svgunit.js: Fixed createXPathEvaluator() to work in Firefox (whose document.getFeature returns null for XPath). Changed load() to use XMLHttpRequest, instead of merely cloning the current document.
  • dom/svg/level3/xpath/resources/internaldtd.xml: Added.
  • dom/svg/level3/xpath/resources/staff.dtd: Added.
  • dom/svg/level3/xpath/resources/staff.xml: Added.
  • dom/svg/level3/xpath/resources/staffNS.dtd: Added.
  • dom/svg/level3/xpath/resources/staffNS.xml: Added. Added external test documents.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt: These tests now run, but fail. They also fail in Firefox, but pass in Opera.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt: These now fail, because XPathResult relies on DOMSubtreeModified event for invalidation, but event listeners cannot be registered on nodes in documents that aren't attached (such as XHR.responseXML). Not yet sure what exactly the bug is, but I think it's good to have the tests fail, as it appears to be a genuine issue.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.js:
  • dom/svg/level3/xpath/XPathResult_numberValue.js: Updated these tests to use /staff instead of /svg paths.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.js:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_stringValue-expected.txt: These tests now pass.
  • dom/svg/level3/xpath/Attribute_Nodes.svg:
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns.svg:
  • dom/svg/level3/xpath/Comment_Nodes.svg:
  • dom/svg/level3/xpath/Conformance_Expressions.svg:
  • dom/svg/level3/xpath/Conformance_ID.svg:
  • dom/svg/level3/xpath/Conformance_hasFeature_3.svg:
  • dom/svg/level3/xpath/Conformance_hasFeature_empty.svg:
  • dom/svg/level3/xpath/Conformance_hasFeature_null.svg:
  • dom/svg/level3/xpath/Conformance_isSupported_3.svg:
  • dom/svg/level3/xpath/Conformance_isSupported_empty.svg:
  • dom/svg/level3/xpath/Conformance_isSupported_null.svg:
  • dom/svg/level3/xpath/Element_Nodes.svg:
  • dom/svg/level3/xpath/Processing_Instruction_Nodes.svg:
  • dom/svg/level3/xpath/Text_Nodes.svg:
  • dom/svg/level3/xpath/XPathEvaluatorCast01.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_document.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml.svg:
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg:
  • dom/svg/level3/xpath/XPathResult_booleanValue_false.svg:
  • dom/svg/level3/xpath/XPathResult_booleanValue_true.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR.svg:
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_numberValue.svg:
  • dom/svg/level3/xpath/XPathResult_resultType.svg:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_stringValue.svg: Removed unneeded inline test data.
9:07 PM Changeset in webkit [19245] by ggaren
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/4485644> REGRESSION: JavaScriptCore has init routines


The TCMalloc module now initializes, if needed, inside GetCache() and
fastMallocSetIsMultiThreaded(). We leverage the same synchronization
technique used for enabling / disabling the single-threaded optimization
to synchronize initialization of the library without requiring a lock
for every malloc.


1,251 runs of tcmalloc_unittest, 2 runs of a custom, massively multi-threaded
tcmalloc_unittest, and my custom version of the PLT show no regressions.
Super-accurate JS iBench reports a .24% regression, which is right at the
limit of its error range, so I'm declaring victory.

  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): Initialize, if needed. (InitModule() checks the "if needed" part.) (WTF::TCMalloc_ThreadCache::GetCache): Restored original TCMalloc code inside #ifdef, for posterity. Added new initialization logic. (WTF::TCMalloc_ThreadCache::InitModule): Call InitTSD(), since we don't have a static initializer to call it for us, now. This means that fastMalloc is not usable as a general libc allocator, but it never was, and if it were the general libc allocator, we wouldn't be here in the first place, so whatever. (WTF::TCMalloc_ThreadCache::InitTSD): Don't try to take the pageheap_lock, since InitModule already has it.

WebKitTools:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/4485644> REGRESSION: JavaScriptCore has init routines


No more mollycoddling for you, FastMalloc.o!


  • Scripts/check-for-global-initializers:
8:57 PM Changeset in webkit [19244] by gdennis
  • 14 edits
    10 adds in trunk

LayoutTests:

Reviewed by Maciej.


  • editing/pasteboard/paste-RTFD-expected.checksum: Added.
  • editing/pasteboard/paste-RTFD-expected.png: Added.
  • editing/pasteboard/paste-RTFD-expected.txt: Added.
  • editing/pasteboard/paste-RTFD.html: Added.
  • editing/pasteboard/paste-TIFF-expected.checksum: Added.
  • editing/pasteboard/paste-TIFF-expected.png: Added.
  • editing/pasteboard/paste-TIFF-expected.txt: Added.
  • editing/pasteboard/paste-TIFF.html: Added.
  • editing/resources/RTFD-pasteboard-data.dat: Added.
  • editing/resources/TIFF-pasteboard-data.dat: Added.

WebCore:

Reviewed by Maciej.

Part of fix for ​http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away


ResourceHandles no longer need to be able to defer loading as that is
now handled by the ResourceLoader.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow): updated to remove defersLoading argument.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): release the deferred request. (WebCore::ResourceLoader::load): defer creating the ResourceHandle instead of asking the ResourceHandle to defer loading. (WebCore::ResourceLoader::setDefersLoading): create the ResourceHandle if we have deferred creating it.
  • loader/ResourceLoader.h:
  • platform/network/ResourceHandle.cpp: ResourceHandle's don't need to know about deferLoading. (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h: ditto.
  • platform/network/ResourceHandleInternal.h: ditto. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: ditto. (WebCore::ResourceHandle::start):

WebKit:

Reviewed by Maciej.

Part of fix for ​http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away


The URLs for images in RTFD data must not be loaded until the resources
have been added to the WebUnarchivingState. This can't happen until
after the RTFD data has been parsed, so we must delay loading while this
RTFD data is being parsed to a document fragment.

  • WebView/WebHTMLView.mm: (uniqueURLWithRelativePart): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): defer loading the resources while RTFD data is being parsed. (+[NSURL _web_uniqueWebDataURL]): Added this back because AppKit uses it.
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]): orkaround for workaround for rdar://problem/4699166 so that other people can use archivedResourceForURL: too.

WebKitTools:

Reviewed by Maciej.


Enables layout test for: ​http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away


  • This method is needed because NSArray's ar bridged to JS Array's, which in turn are bridged back to WebScriptObject's when passed from JS to ObjC. Hence it is not possbile to pass an NSArray from JS.
  • DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreePasteboard declareType:owner:]): Added a convenience method for JS.
8:31 PM Changeset in webkit [22868] by beidson
  • 1 edit in branches/WindowsMerge/WebCore/platform/network/cf/ResourceHandleCFNet.cpp

Emergency build fix + other changes I'll have review after the fact

8:05 PM Changeset in webkit [19243] by bdash
  • 3 edits in trunk/WebKit

2007-01-29 Jim Correia <​jim.correia@pobox.com>

Reviewed by Mark.

Added support for -allowsUndo/-setAllowsUndo: to allow editable WebView
clients to completely disable undo registration. This is functionally
equivalent to the methods with the same names on NSTextView.

  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]): (-[WebView allowsUndo]): (-[WebView setAllowsUndo:]): (-[WebView undoManager]):
  • WebView/WebViewPrivate.h:
7:19 PM Changeset in webkit [19242] by beidson
  • 2 edits in trunk/WebCore

Use a RetainPtr instead of a raw pointer

6:21 PM Changeset in webkit [22867] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Make NotImplemented use a logging channel so you can turn it off independent of other logging

6:11 PM Changeset in webkit [19241] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-01-29 bujtas <​zbujtas@gmail.com>

Reviewed by zalan bujtas
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=12422
jscript->schedule action->turn off jscript->action timeouts->crash. fix: check if the proxy is available in ScheduledAction::execute()

  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
6:08 PM Changeset in webkit [19240] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-01-29 bujtas <​zbujtas@gmail.com>

Reviewed by zalan bujtas
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=12422
jscript->schedule action->turn off jscript->action timeouts->crash. fix: check if the proxy is available in ScheduledAction::execute()

  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
5:13 PM Changeset in webkit [19239] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4960137>
ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)

  • editing/selection/4960137-expected.checksum: Added.
  • editing/selection/4960137-expected.png: Added.
  • editing/selection/4960137-expected.txt: Added.
  • editing/selection/4960137.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4960137>
ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Hand off the selection to the selectionController responsible for it, instead of asserting. A selection object can't be constructed with endpoints in different documents, so this code is only necessary for one endpoint.
4:40 PM Changeset in webkit [19238] by adachan
  • 4 edits in trunk

2007-01-29 Ada Chan <​adachan@apple.com>

Reviewed by Brady.


Moved the update of the title of the current entry in the backforward list to WebCore.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didChangeTitle):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle):
4:26 PM Changeset in webkit [22866] by adele
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Removed EventTargetNode paramenter.
  • WebEditorClient.h:
4:15 PM Changeset in webkit [19237] by adele
  • 17 edits in trunk

WebCore:

Reviewed by Darin.

More preparation for event handling fixes.

  • bridge/EditorClient.h: Removed EventTargetNode parameter from handleKeyPress since we can just get that from the event.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): ditto.
  • page/EventHandler.h: ditto.
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): ditto.
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Removed EventTargetNode parameter. (WebCore::Editor::execCommand): Made commandMap use AtomicStringImpls instead of Strings. (WebCore::Editor::insertText): Moved from the bridge.
  • page/mac/WebCoreFrameBridge.h: Moved insertText method to Editor.
  • page/mac/WebCoreFrameBridge.mm:
  • WebCore.exp: Updated exports.

WebKit:

Reviewed by Darin.

More preparation for event handling fixes.

  • WebCoreSupport/WebEditorClient.h: Removed EventTargetNode parameter, since you can just get this from the KeyboardEvent.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): ditto.
  • WebView/WebHTMLViewInternal.h: Added interpretKeyEventsParameters struct.
  • WebView/WebViewInternal.h: Changed parameter from NSEvent to WebCoreKeyboardEvent in _interceptEditingKeyEvent.
  • WebView/WebHTMLView.mm: (-[WebHTMLView yankAndSelect:]): Updated for new triggeringEvent parameter. (-[WebHTMLView _interceptEditingKeyEvent:]): Set the WebHTMLViewInterpretKeyEventsParameters. (-[WebHTMLView doCommandBySelector:]): Access WebHTMLViewInterpretKeyEventsParameters. (-[WebHTMLView insertText:]): ditto. (-[WebHTMLView _insertText:selectInsertedText:triggeringEvent:]): Added parameter for triggeringEvent.
3:45 PM Changeset in webkit [22865] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools

Build fix.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction):
2:42 PM Changeset in webkit [19236] by andersca
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/4960097>
​http://bugs.webkit.org/show_bug.cgi?id=12444
Assertion failure in -[WebCoreFrameBridge installInFrame:]

  • fast/parser/xhtml-document-with-html-object-expected.txt: Added.
  • fast/parser/xhtml-document-with-html-object.xhtml: Added.

WebCore:

Reviewed by Geoff.

<rdar://problem/4960097>
​http://bugs.webkit.org/show_bug.cgi?id=12444
Assertion failure in -[WebCoreFrameBridge installInFrame:]


The problem was that the XML tokenizer didn't create elements with
createdByParser set to true.


  • dom/Document.cpp: (WebCore::Document::createElement): New method which takes a QName. This is used by both the XML tokenizer and createElementNS.


(WebCore::Document::createElementNS):
Call new createElement method.


  • dom/XMLTokenizer.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): Use an OwnPtr for the pending callbacks object. Also, use String instead of StringImpl in the hash map.


(WebCore::toString):
(WebCore::XMLTokenizer::startElementNs):
Call createElement.

2:00 PM Changeset in webkit [19235] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Oliver

​http://bugs.webkit.org/show_bug.cgi?id=12465
Only set the iconURL port for non-zero ports

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL):
1:58 PM Changeset in webkit [19234] by kmccullo
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff and Oliver.

  • rdar://problem/4955561
  • missusing JavaScript shouldn't crash webkit. Now it doesn't, in this case.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::callAsFunction):

LayoutTests:

Reviewed by Geoff and Oliver.

  • rdar://problem/4955561
  • missusing JavaScript shouldn't crash webkit. Now it doesn't in this case.
  • plugins/call-as-function-test-expected.txt: Added.
  • plugins/call-as-function-test.html: Added.
11:49 AM Changeset in webkit [19233] by oliver
  • 2 edits in trunk/WebKit

2007-01-29 Oliver Hunt <​oliver@apple.com>

build fix

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
10:47 AM Changeset in webkit [22864] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Oliver.

<rdar://problem/4892067>
DnD a font file in Boomer locks it up.

Create a drop target helper so we get snazzy drag images.

  • WebView.cpp: (WebView::WebView): (WebView::DragEnter): (WebView::DragOver): (WebView::DragLeave): (WebView::Drop):
  • WebView.h:
10:38 AM Changeset in webkit [22863] by oliver
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-29 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Basic implementation of new dragclient method

  • WebDragClient.cpp: (WebDragClient::dragSourceActionMaskForPoint):
  • WebDragClient.h:
10:36 AM Changeset in webkit [19232] by sullivan
  • 2 edits in trunk/WebCore
  • platform/network/mac/ResourceRequestMac.mm: Build fix -- removed #import of no-longer-extant WebDataProtocol.h (and also one of the two #imports for WebCoreSystemInterface.h, while I was at it)
10:33 AM Changeset in webkit [19231] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • page/DragController.cpp: (WebCore::DragController::dragEnteredOrUpdated): Only try a drag operation if the drag client explicitly specified that it is OK
10:25 AM Changeset in webkit [19230] by oliver
  • 19 edits in trunk

2007-01-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebKit:

Migrated drag state and logic to WebCore, removed superfluous methods

  • ChangeLog:
  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::dragSourceActionMaskForPoint):
  • WebCoreSupport/WebFrameBridge.mm:

allowDHTMLDrag move to WebCore::EventHandler

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView draggedImage:movedTo:]): (-[WebHTMLView draggedImage:endedAt:operation:]): dragOffset and dragSourecAction is now stored in WebCore::DragController migrated _delegateDragSourceActionMask to WebCore::DragController
  • WebView/WebHTMLViewInternal.h: Removed dragOffset declaration, migrated to WebCore::DragController
  • WebView/WebView.mm: removed unnecessary method, _loadingDragOperationForDraggingInfo

WebKitQt:

Reviewed by Adam.

Stub for new DragClient method

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::dragSourceActionMaskForPoint):
  • WebCoreSupport/DragClientQt.h:

WebCore:

Reviewed by Adam.

Migrated more drag logic and state to WebCore


  • page/DragClient.h:
  • page/DragController.cpp: (WebCore::DragController::delegateDragSourceAction): New forwarding method for the UI delegate
  • page/DragController.h: (WebCore::DragController::dragOffset): Now store the drag offset -- the offset of the cursor relative to the drag image) in DragController
  • page/EventHandler.cpp: (WebCore::EventHandler::allowDHTMLDrag): Moved from WebFrameBridge
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleDrag): EventHandlerMac now uses EventHandler::allowDHTMLDrag rather than the implementation in WebFrameBridge
  • page/mac/WebCoreFrameBridge.h: removed definition of allowDHTMLDrag from WebFrameBridge
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::dragSourceActionMaskForPoint): Updated empty DragClient
10:20 AM Changeset in webkit [19229] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brmorris <​bradley.morrison@nokia.com>

Reviewed by nobody - build fix.
DESC: Fix for build bustage in r19200 - MLIO-6XCCTG

10:18 AM Changeset in webkit [19228] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris <​bradley.morrison@nokia.com>

Reviewed by nobody - build fix.
DESC: Fix for build bustage caused by r19201 - MLIO-6XCCTG

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
10:04 AM Changeset in webkit [19227] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12359
XPathEvaluator may return some nodes more than once in a result set

Test: fast/xpath/nodeset-duplicates.html

  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::doEvaluate): Ensure uniqueness of elements in the node-set.
  • xml/XPathPredicate.cpp: (WebCore::XPath::Union::doEvaluate): Fixed a uniqueness algorithm that was already present here. Added a FIXME about incorrect result ordering.
9:55 AM Changeset in webkit [19226] by ap
  • 4 edits
    2 moves
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12340
XPathEvaluator behavior does not match Firefox - name() and attribute nodes

WebCore:

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunName::doEvaluate): Do not try to append a prefix if it doesn't exist.

LayoutTests:

  • fast/xpath/name-null-namespace-expected.txt: Added.
  • fast/xpath/name-null-namespace.html: Added. Test for the bug.
  • fast/dom/xpath-empty-string-expected.txt: Removed.
  • fast/dom/xpath-empty-string.html: Removed. Moved these to fast/xpath.
  • fast/xpath/xpath-namespaces.html: Fixed an inline document to be well-formed, so the test now passes in Firefox. This is really a quirk of our DOMParser that the test passed in WebKit: on error, a descriptive message is appended to the partially parsed document, instead of replacing it.
9:40 AM Changeset in webkit [19225] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11815
XPathEvaluator behavior does not match Firefox - substring() and empty element

Test: fast/xpath/empty-string-substring.html

  • xml/XPathValue.cpp: (WebCore::XPath::Value::Value):
  • xml/XPathValue.h: Added a constructor taking const char*, so that string literals and arrays don't get converted to boolean values.
8:11 AM Changeset in webkit [19224] by zack
  • 3 edits in trunk/WebCore

Cosmetic fixes - don't resize the widget in the constructor
(it was a hack from the initial port) and fix the paint
signature)

7:23 AM Changeset in webkit [22862] by mjs
  • 4 edits in branches/WindowsMerge

WebCoreWin:

  • fix build
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

  • fix build
  • WebFrame.h:
7:10 AM Changeset in webkit [19223] by mjs
  • 2 edits in trunk/WebCore
  • change from struct to class to make picky compilers happy
  • loader/SubstituteData.h:
6:28 AM Changeset in webkit [19222] by bdash
  • 2 edits in trunk/WebCore

2007-01-30 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12458
Bug 12458: Crash in W3C-SVG-1.1/animate-elem-09-t.svg running layout tests under guard malloc

  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::parseValues): ptr either points to a ';' or off the end of the buffer. We're interested in what comes before the ';', so start there instead.
5:37 AM Changeset in webkit [19221] by zack
  • 4 edits in trunk/WebCore

Take the scrollbars into considation when computing
the contents size of the main frame

5:06 AM Changeset in webkit [19220] by mjs
  • 2 edits in trunk/WebCore
  • fix includes
  • loader/SubstituteData.h:
5:03 AM Changeset in webkit [22861] by mjs
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Mark.


<rdar://problem/4910106> Need to support loadData and loadHTMLString


I added the underlying support, but did not turn on the new cross-platform versions yet as I've
not had sufficient time to test.

  • WebDocumentLoader.cpp: (WebDocumentLoader::WebDocumentLoader):
  • WebDocumentLoader.h:
  • WebFrame.cpp: (WebFrame::createDocumentLoader):
  • WebFrame.h:
5:01 AM Changeset in webkit [19219] by mjs
  • 1 edit
    1 add in trunk/WebCore
  • added new file that I forgot in the last commit
  • loader/SubstituteData.h: Added. (WebCore::SubstituteData::SubstituteData): (WebCore::SubstituteData::isValid): (WebCore::SubstituteData::content): (WebCore::SubstituteData::mimeType): (WebCore::SubstituteData::textEncoding): (WebCore::SubstituteData::failingURL):
4:50 AM Changeset in webkit [19218] by mjs
  • 28 edits
    2 deletes in trunk

WebCore:

Reviewed by Mark.

  • made data loading cross-platform
  • fixed <rdar://problem/4910106>
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedResource.cpp:
  • loader/CachedResource.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::urlForHistory): (WebCore::DocumentLoader::unreachableURL):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::substituteData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::checkNavigationPolicy):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::handleDataLoad): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load):
  • loader/MainResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm:
  • loader/mac/WebDataProtocol.h: Removed.
  • loader/mac/WebDataProtocol.mm: Removed.
  • loader/qt/DocumentLoaderQt.cpp:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):

WebKit:

Reviewed by Mark.

  • updated for cross-platform data loading support


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader):
  • WebView/WebDataSource.mm: (-[WebDataSource initWithRequest:]):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): (-[WebFrame loadArchive:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (uniqueURLWithRelativePart): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):

WebKitQt:

Reviewed by Mark.

  • updated for cross-platform data loading support
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createDocumentLoader):
  • WebCoreSupport/FrameLoaderClientQt.h:
3:57 AM Changeset in webkit [19217] by zack
  • 2 edits in trunk/WebCore

Order the build files alphabetically instead of
the random mess we had before

3:30 AM Changeset in webkit [19216] by zack
  • 3 edits in trunk/WebCore

Use the platform independent scrollbar code.
Remove the redundant empty stubs and forward
few missing platform scrollbar calls
r=Lars

2:37 AM Changeset in webkit [19215] by staikos
  • 4 edits in trunk/WebKitQt

Make window resizing work

2:24 AM Changeset in webkit [19214] by staikos
  • 4 edits in trunk/WebKitQt

Make popup windows work

1:24 AM Changeset in webkit [19213] by lars
  • 11 edits in trunk

Reviewed by Zack

Fix the way we handle native widgets (QWidget) inside
WebCore. Now WebCore::Widget owns the QWidget in all
cases. This is the only way to get well defined semantics
for all teh native widgets we have (currently ScrollView
and ScrollBar, but plugins will follow).

This has the side effect that one cannot rely on a defined
lifetime of a QWebFrame when using the API.

1:01 AM Changeset in webkit [22860] by sfalken
  • 4 edits in branches/WindowsMerge/WebCore

2007-01-29 Steve Falkenburg <​sfalken@apple.com>

Fix build break from RootObject ownership change.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::createRootObject): Added (WebCore::FrameWin::cleanupPluginObjects): change destroy to invalidate (WebCore::FrameWin::bindingRootObject): change new RootObject to RootObject::create
  • bridge/win/FrameWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): change new RootObject to FrameWin::createRootObject.
1:00 AM Changeset in webkit [19212] by staikos
  • 1 edit in trunk/WebKitQt/WebCoreSupport/ChromeClientQt.cpp

Missed saving this file before the previous checkin.

12:47 AM Changeset in webkit [19211] by staikos
  • 7 edits in trunk/WebKitQt

Implement more functions for the Qt build

Note: See TracTimeline for information about the timeline view.