⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 31, 2007:

11:53 PM Changeset in webkit [19334] by lars
  • 2 edits in trunk/WebCore

fix the Qt build

11:18 PM Changeset in webkit [19333] by bdash
  • 4 edits in tags/Safari-521.33

Versioning.

11:08 PM Changeset in webkit [19332] by bdash
  • 3 edits in tags/Safari-521.33/WebKit

Merge in r19308.

10:55 PM Changeset in webkit [19331] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam and Geoff.

  • test for <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text
  • fast/forms/select-width-font-change-expected.txt: Added.
  • fast/forms/select-width-font-change.html: Added.

WebCore:

Reviewed by Adam and Geoff.

  • fix <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text

Test: fast/forms/select-width-font-change.html

  • rendering/RenderMenuList.h: Cleaned up formatting a bit. Removed unneeded include of PopupMenu.h. Made a lot more things private, including the PopupMenuClient base class, all of the virtual functions from PopupMenuClient, and the setTextFromOption function. Added updateOptionsWidth.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Added code to call updateOptionsWidth when the font changes. (WebCore::RenderMenuList::updateOptionsWidth): Added. Factored code out of updateFromElement. Changed to do nothing when m_optionsWidth is already correct. (WebCore::RenderMenuList::updateFromElement): Moved code to recomputed options width to the new updateOptionsWidth function. (WebCore::RenderMenuList::text): Made const.
10:37 PM Changeset in webkit [19330] by bdash
  • 1 copy in tags/Safari-521.33

New tag.

10:04 PM Changeset in webkit [19329] by bdash
  • 2 edits in tags/WebKit-421.33.1/WebKit

Versioning.

10:03 PM Changeset in webkit [22881] by oliver
  • 3 edits in branches/WindowsMerge/WebCore

2007-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCoreWin:

Updating event handler logic to make use of methods migrated from
WebKit to WebCore

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Updating handleDrag to use methods that we've migrated to WebCore
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::messageToEventType): (WebCore::PlatformMouseEvent::PlatformMouseEvent): provide the type of mouse event
10:02 PM Changeset in webkit [19328] by bdash
  • 3 edits in tags/WebKit-421.33.1/WebKit

Merge in r19308.

10:02 PM Changeset in webkit [19327] by oliver
  • 21 edits in trunk

liver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

Migrate more drag and drop logic to WebCore, start preparing
to move EventHandler::handleDrag from EventHandlerMac to EventHandler

  • WebCore.exp: updating methods


  • dom/Clipboard.cpp:
  • dom/Clipboard.h: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::setDragHasStarted): (WebCore::Clipboard::dragStarted): Moving from ClipboardMac to Clipboard
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): PlatformMouseEvent no longer lies about button state, however DOM Events don't allow NoButton, so we need to convert NoButton to LeftButton when we create a DOM Event from PlatformMouseEvent
  • page/DragClient.h: Tidying comment
  • page/DragController.cpp: (WebCore::createMouseEvent): Updated for new PlatformMouseEvent constructors (WebCore::DragController::mayStartDragAtEventLocation): Migrated from WebKit
  • page/DragController.h: Added above function declarations
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::freeClipboard): (WebCore::EventHandler::shouldDragAutoNode): Moved from EventHandlerMac (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleMousePressEvent): Use DragController
  • page/EventHandler.h: Added DragState struct definition to EventHandler
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::mouseDown): Update to use DragController and PlatformMouseEvent
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Use DragController for state

WebKit:

Migrating methods to WebCore

  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:


9:59 PM Changeset in webkit [19326] by bdash
  • 1 copy in tags/WebKit-421.33.1/WebKit

New tag (part 2).

9:58 PM Changeset in webkit [19325] by bdash
  • 1 add in tags/WebKit-421.33.1

New tag.

9:13 PM Changeset in webkit [22880] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-31 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


Adam and I found a missing retain on WebFrame::setUpPolicyListener(). The mac
code returns a RefPtr which retains it, but we are returning the raw pointer.
Changed the code to return a COMPtr. Without this change, loading bogus urls
will crash.

  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::setUpPolicyListener): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):
  • WebFrame.h:
8:26 PM Changeset in webkit [19324] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

  • fast/encoding/pseudo-tags-in-attributes-expected.txt: Added.
  • fast/encoding/pseudo-tags-in-attributes.html: Added.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Skip over quoted attributes.
8:20 PM Changeset in webkit [19323] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/RenderLayer.cpp: (WebCore::Marquee::Marquee):
7:51 PM Changeset in webkit [19322] by andersca
  • 7 edits
    5 adds in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

  • webarchive/loading/resources/helloworld.webarchive: Added.
  • webarchive/loading/test-loading-archive-expected.txt: Added.
  • webarchive/loading/test-loading-archive.html: Added.

WebCore:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadWithData):
  • loader/FrameLoader.h: New function which continues a load but using a given buffer instead.

WebKit:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file


"Revert" the change done in 13734.


  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation loadArchive]): Don't do a new load here, as this would cancel the current load and call the resource load delegate's didFailLoadingWithError: method. Instead, call continueLoadWithData.
7:50 PM Changeset in webkit [22879] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-31 Ada Chan <​adachan@apple.com>

Reviewed by Anders.

WebKitWin:

Implement WebView::mainFrameDocument.

  • WebView.cpp: (WebView::mainFrameDocument):


7:30 PM Changeset in webkit [19321] by andersca
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): Use an NSString here so we can guarantee that -description always returns the same value.
6:14 PM Changeset in webkit [19320] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • fix sporadic crash
  • wtf/ListHashSet.h: (WTF::::remove): remove before deleting
5:55 PM Changeset in webkit [19319] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12516
REGRESSION (r19313): All keyboard navigation has stopped working

For non-editable selections, handleKeyPress doesn't need to call _interceptEditingKeyEvent.

  • editing/Editor.cpp: (WebCore::selectionForEvent): Moved this to the top of the file. (WebCore::Editor::handleKeyPress): Do the equivalent of the _canEdit check that used to be in WebKit WebEditorClient::handleKeyPress.
5:33 PM Changeset in webkit [19318] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

Fix run-pageloadtest to actually work again.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]):
5:03 PM Changeset in webkit [19317] by ggaren
  • 8 edits in trunk

WebCore:

Reviewed by Darin Adler.

Added a Range counter to detect leaks. Tweaked the Node counter.


Also fixed a TextIterator destructive modification bug that I noticed along the
way. No test case for this bug because no clients have been bitten by it
yet.

  • dom/Node.cpp: Renamed NodeImplCounter to NodeCounter, changed counter to unsigned, fixed formatting to match style guidelines. (WebCore::NodeCounter::~NodeCounter): (WebCore::Node::Node): (WebCore::Node::~Node):
  • dom/Range.cpp: (WebCore::RangeCounter::~RangeCounter): Added. (WebCore::Range::Range): (WebCore::Range::~Range): (WebCore::Range::ownerDocument): New accessor, used by TextIterator to avoid annoying NULL checks.
  • dom/Range.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::subrange): (1) Don't initialize result with entireRange -- doing so would create a PassRefPtr that pointed to entireRange, so this function would destructively modify the Range you passed it. Initialize it with a new Range instead. (2) Don't use a PassRefPtr as a local variable, because they have sneaky semantics. Use a RefPtr instead. (3) Don't call CharacterIterator::range() willy-nilly, since it does non-trivial work. Use a local variable instead.

WebKitTools:

Reviewed by Darin Adler.

Added Selection::toRange to the leaks -exclude list, since it comes up
as a false positive (Radar 4967949).


Also added RangeCounter to the global initializer exclude list. I added
a RangeCounter since leaks won't detect all Range leaks anymore.

  • Scripts/check-for-global-initializers:
  • Scripts/run-webkit-tests:
4:31 PM Changeset in webkit [19316] by andersca
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): Don't try to create an identifier if resource loads shouldn't be dumped.
3:00 PM Changeset in webkit [19315] by andersca
  • 4 edits
    2 adds in trunk/WebKitTools

Reviewed by Geoff.

Add dumping of resource loads. This isn't completely tweaked yet since the test results would
rely on resources being delivered in the same order which might not always be true. However, it works good
enough for the simple webarchive tests I want to do right now.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpResourceLoadCallbacks]): (runTest):


  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ResourceLoadDelegate.h: Added.
  • DumpRenderTree/ResourceLoadDelegate.m: Added. Add new resource load delegate.
2:59 PM Changeset in webkit [19314] by zimmermann
  • 2 edits in trunk/WebKit

Reviewed by Maciej.
Fix run-pageloadtest to actually work again.

2:55 PM Changeset in webkit [19313] by adele
  • 17 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

  • fast/events/keypress-focus-change-expected.txt: Added.
  • fast/events/keypress-focus-change.html: Added.
  • fast/events/resources/keypress-frame.html: Added.

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

Test: fast/events/keypress-focus-change.html

  • editing/Editor.cpp: (WebCore::selectionForEvent): Added. This computes a selection that considers the case where an event handler has moved the selection outside of a text control. In that case, we use the target control's selection. (WebCore::Editor::insertText): This gets the selectionForEvent, checks that the selection is editable, and calls TypingCommand::insertText with the correct selection.
  • editing/TypingCommand.h: Added a version of insertText that takes a selection. The old version of insertText will call this, and pass in the frame's selection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added. Uses the passed in selection to set the starting and ending selections correctly so that the editing machinery will insert the text in the correct place.
  • page/Page.h: Added convenience method to get selection from focused or main frame.
  • page/Page.cpp: (WebCore::Page::selection):
  • html/HTMLInputElement.h: Added selection methods to get selection for text controls.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selection):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection):

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Instead of using the selected frame, use the frame for the target of the keyboard event. Also, don't do the canEdit check here, since the target's frame might not have a selection at this point. Do the canEdit check within Editor::insertText, where we determine which selection to use for inserting text.
  • WebView/WebEditingDelegatePrivate.h: Added forward declaration of DOMHTMLElement. This is needed after reordering includes in WebEditorClient.mm.
2:01 PM Changeset in webkit [19312] by ggaren
  • 2 edits in trunk/WebKitTools

Backing out the CFRunLoopRunSpecific exclude command because it was overly
broad. We'll either need to work around this leak in DRT, or do some
custom grep-based leak ignoring.

  • Scripts/run-webkit-tests:
1:50 PM Changeset in webkit [19311] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, Reviewed by zalan.

DESC: cache control present in the HTTP header is not properly supported EAMO-6XTJVX
​http://bugs.webkit.org/show_bug.cgi?id=12478

1:49 PM Changeset in webkit [19310] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen, Reviewed by zalan.

DESC: cache control present in the HTTP header is not properly supported EAMO-6XTJVX
​http://bugs.webkit.org/show_bug.cgi?id=12478

1:24 PM Changeset in webkit [19309] by brmorris
  • 7 edits in S60/branches/3.1m

sareen, reviewed by zalan

DESC: Browser fails to load page after selection from drop-down list. (MLEN-6XRDHA)
​http://bugs.webkit.org/show_bug.cgi?id=12427

1:15 PM Changeset in webkit [19308] by aliceli1
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Turning an accidental API change to an SPI change

  • WebView/WebEditingDelegate.h:
  • WebView/WebEditingDelegatePrivate.h: move some declarations into private header.
1:11 PM Changeset in webkit [22878] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
1:10 PM Changeset in webkit [22877] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2007-01-31 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Fix BString bugs.

  • platform/win/BString.cpp: (WebCore::BString::BString): Call SysAllocString instead of SysAllocStringLen (WebCore::BString::operator=): Add proper null checks (WebCore::operator ==): Add proper null checks
1:04 PM Changeset in webkit [19307] by brmorris
  • 8 edits in S60/trunk

sareen, Reviewed by zalan <​zbujtas@gmail.com>.

DESC: Browser fails to load page after selection from drop-down list MLEN-6XRDHA
​http://bugs.webkit.org/show_bug.cgi?id=12427

8:21 AM Changeset in webkit [19306] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, Reviewed by nobody - build fix.

DESC: add widget registry & engine to rom image.

  • rom/webkit.iby:
7:08 AM Changeset in webkit [19305] by darin
  • 2 edits
    2 adds in trunk

WebCore:

  • fix build
  • ForwardingHeaders/wtf/ListHashSet.h: Added.

WebKit:

  • fix build
  • ForwardingHeaders/wtf/ListHashSet.h: Added.
6:08 AM Changeset in webkit [19304] by zack
  • 2 edits in trunk/WebCore

Implement native colors for selections.
r=Lars

5:44 AM Changeset in webkit [19303] by zack
  • 5 edits in trunk/WebKitQt

Expose the fact that the form has been edited
in the public Qt api.

5:43 AM Changeset in webkit [19302] by mjs
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Mark with help from Lars.


  • added new ListHashSet class, which combines a hashtable and a linked list to provide a set that keeps elements in inserted order


This is to assist in fixing the following:
<rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
​http://bugs.webkit.org/show_bug.cgi?id=10541

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashTable.h: (WTF::HashTable::find): (WTF::HashTable::contains): (WTF::::find): (WTF::::contains):
  • wtf/ListHashSet.h: Added. (WTF::ListHashSetNode::ListHashSetNode): (WTF::ListHashSetNodeHashFunctions::hash): (WTF::ListHashSetNodeHashFunctions::equal): (WTF::ListHashSetIterator::ListHashSetIterator): (WTF::ListHashSetIterator::get): (WTF::ListHashSetIterator::operator*): (WTF::ListHashSetIterator::operator->): (WTF::ListHashSetIterator::operator++): (WTF::ListHashSetIterator::operator--): (WTF::ListHashSetIterator::operator==): (WTF::ListHashSetIterator::operator!=): (WTF::ListHashSetIterator::operator const_iterator): (WTF::ListHashSetIterator::node): (WTF::ListHashSetConstIterator::ListHashSetConstIterator): (WTF::ListHashSetConstIterator::get): (WTF::ListHashSetConstIterator::operator*): (WTF::ListHashSetConstIterator::operator->): (WTF::ListHashSetConstIterator::operator++): (WTF::ListHashSetConstIterator::operator--): (WTF::ListHashSetConstIterator::operator==): (WTF::ListHashSetConstIterator::operator!=): (WTF::ListHashSetConstIterator::node): (WTF::ListHashSetTranslator::hash): (WTF::ListHashSetTranslator::equal): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::operator): (WTF::::~ListHashSet): (WTF::::size): (WTF::::capacity): (WTF::::isEmpty): (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::contains): (WTF::::add): (WTF::::remove): (WTF::::clear): (WTF::::unlinkAndDelete): (WTF::::appendNode): (WTF::::deleteAllNodes): (WTF::::makeIterator): (WTF::::makeConstIterator): (WTF::deleteAllValues):

WebCore:

Reviewed by Mark.

  • dom/Document.cpp: (WebCore::Document::formElementsState):
  • dom/Document.h:


I couldn't figure out the back/forward support in the tests enough
to make an automated test, but this maual test reproduces the
problem 100% without this patch:


  • manual-tests/back.html: Added.
  • manual-tests/form-control-madness.html: Added.
4:59 AM Changeset in webkit [19301] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number. Thanks Mitz!

4:51 AM Changeset in webkit [19300] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Mitz.

No test cases since there is no change in functionality.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Simplify canFitOnLine expression.
4:36 AM Changeset in webkit [19299] by zack
  • 3 edits in trunk/WebCore

Adding comments explaining how the focus ring implementation
works on the Qt platform and just move focus ring rendering
related code to the same spot.

4:20 AM Changeset in webkit [19298] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Eric.


  • add back no-op version of silly method so that shipping Safari can still run the PLT
  • Misc/WebNSWindowExtras.m: (-[NSWindow _webkit_displayThrottledWindows]):
4:00 AM Changeset in webkit [19297] by zack
  • 10 edits in trunk

Clean up key event handling on Qt.
r=Lars

12:57 AM Changeset in webkit [19296] by staikos
  • 2 edits in trunk/WebCore

Fix a double delete on cancel as well as a crash with proxy

12:33 AM Changeset in webkit [19295] by bdash
  • 5 edits in trunk/WebKit

2007-01-31 Mark Rowe <​mrowe@apple.com>

More build fixing.

  • Misc/WebKitLogging.h: Use !defined() rather than !.
  • Plugins/WebNetscapePluginStream.h: Remove #if cplusplus as this file is only included from Obj-C++ files.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Use #ifdef rather than #if.
  • WebView/WebView.mm: (-[WebView isGrammarCheckingEnabled]): Ditto.
12:11 AM Changeset in webkit [19294] by bdash
  • 2 edits in trunk/WebKit

2007-01-31 Mark Rowe <​mrowe@apple.com>

Build fix.

  • WebView/WebView.mm: (-[WebView initWithFrame:frameName:groupName:]):
12:10 AM Changeset in webkit [19293] by staikos
  • 7 edits in trunk/WebKitQt

fix a crash on exit
remove focusFrame
add childFrames

Jan 30, 2007:

11:26 PM Changeset in webkit [19292] by bdash
  • 11 edits in trunk

2007-01-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

Enable -Wundef in WebKit, and change misuses of #if to #ifdef or #ifndef as appropriate.

  • Misc/WebKitLogging.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView delete:]): (-[WebHTMLView showGuessPanel:]): (-[WebHTMLView copy:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView validateUserInterfaceItem:]):
  • WebView/WebViewPrivate.h:

2007-01-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • dom/Document.h: Change #if XSLT_SUPPORT to #ifdef XSLT_SUPPORT.
11:20 PM Changeset in webkit [19291] by lars
  • 2 edits in trunk/WebCore

Fix the Qt build.

10:43 PM Changeset in webkit [19290] by zack
  • 6 edits in trunk/WebCore

Implement SVGImage on the Qt platform.
r=Eric

9:45 PM Changeset in webkit [19289] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • fixed <rdar://problem/4939366> REGRESSION: Assertion failure and crash when going back in history (12314)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): special case a frame name of "_blank" (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): ditto
9:24 PM Changeset in webkit [19288] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.

Filed some more Radars in other components, added some more leaks to the
exclusion list.

  • Scripts/run-webkit-tests: Ignore leaks in CFNotificationCenterAddObserver, CFRunLoopRunSpecific, and NSSpellChecker.
8:30 PM Changeset in webkit [19287] by bdash
  • 3 edits in tags/Safari-421.33

Versioning.

8:08 PM Changeset in webkit [19286] by bdash
  • 1 copy in tags/Safari-421.33

New tag.

7:50 PM Changeset in webkit [22876] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:39 PM Changeset in webkit [19285] by sfalken
  • 1 copy in tags/Safari-521.32.17b

New tag.

7:31 PM Changeset in webkit [19284] by ddkilzer
  • 3 edits
    1 copy
    25 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Created webarchive tests that exercise various features of the WebArchive format.

  • webarchive/resources/apple.gif: Copied from fast/canvas/resources/apple.gif.
  • webarchive/resources/dump-webarchive.js: Added.
  • webarchive/resources/test-frame.html: Added.
  • webarchive/resources/test-style.css: Added.
  • webarchive/test-body-background-expected.txt: Added.
  • webarchive/test-body-background.html: Added.
  • webarchive/test-duplicate-resources-expected.txt: Added.
  • webarchive/test-duplicate-resources.html: Added.
  • webarchive/test-frameset-expected.txt: Added.
  • webarchive/test-frameset.html: Added.
  • webarchive/test-img-src-expected.txt: Added.
  • webarchive/test-img-src.html: Added.
  • webarchive/test-input-src-expected.txt: Added.
  • webarchive/test-input-src.html: Added.
  • webarchive/test-link-href-expected.txt: Added.
  • webarchive/test-link-href.html: Added.
  • webarchive/test-object-data-expected.txt: Added.
  • webarchive/test-object-data.html: Added.
  • webarchive/test-script-src-expected.txt: Added.
  • webarchive/test-script-src.html: Added.
  • webarchive/test-table-background-expected.txt: Added.
  • webarchive/test-table-background.html: Added.
  • webarchive/test-td-background-expected.txt: Added.
  • webarchive/test-td-background.html: Added.

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
Alters WebResourceResponse and WebResourceURL properties within WebArchive format
to normalize URLs to remove path where WebKit was checked out. Also converts
WebDataResource properties from data to string if the corresponding
WebResourceMIMEType property starts with "text/" or equals
"application/x-javascript".

  • DumpRenderTree/DumpRenderTree.m: (convertWebResourceDataToString): Added. (normalizeWebResourceURL): Added. (normalizeWebResourceResponse): Added. (serializeWebArchiveToXML): Added. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Added. (runTest):
7:08 PM Changeset in webkit [19283] by brmorris
  • 8 edits in S60/branches/3.1m

yaharon, reviewed by zalan.

DESC: BrowserNG: Redundant password manager notification on secure pages (MLIO-6XXEVU)
​http://bugs.webkit.org/show_bug.cgi?id=12484
merge of r19282 to 3.1

7:03 PM Changeset in webkit [19282] by brmorris
  • 8 edits in S60/trunk

yaharon, reviewed by zalan.

DESC: BrowserNG: Redundant password manager notification on secure pages (MLIO-6XXEVU)
​http://bugs.webkit.org/show_bug.cgi?id=12484


6:40 PM Changeset in webkit [19281] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Anders.

  • fixed <rdar://problem/4963871> REGRESSION: Crash occurs at WebCore::Frame::loader() when attempting to open a saved archive file
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::request): Removed obsolete FIXME. (WebCore::DocumentLoader::initialRequest): Ditto.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): Handle data loads from a timer, otherwise bad things happen. (WebCore::MainResourceLoader::handleDataLoadNow): (WebCore::MainResourceLoader::handleDataLoadSoon): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::didCancel): cancel data load timer
  • loader/MainResourceLoader.h:
6:31 PM Changeset in webkit [19280] by beidson
  • 6 edits in trunk/WebKit

Reviewed by Oliver

This is a corollary to <rdar://problem/4944887> where certain things happened on an alternate thread.
To help catch such behavior in the future, add ASSERT_MAIN_THREAD() to key WebKit API points

  • History/WebHistoryItem.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (-[WebHistoryItem initWithWebCoreHistoryItem:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem target]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem children]): (-[WebHistoryItem URL]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]):
  • Misc/WebIconDatabase.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _iconForFileURL:withSize:]): (webGetNSImage):
  • Misc/WebKitLogging.h: Added ASSERT_MAIN_THREAD()
  • Misc/WebKitLogging.m: (WebKitRunningOnMainThread): Added
  • WebKit.xcodeproj/project.pbxproj: Define DISABLE_THREAD_CHECK until it is safe to run with ASSERT_MAIN_THREAD() active
4:52 PM Changeset in webkit [22875] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Fixes <rdar://problem/4889160>
If there's no backing store bitmap, don't try to update it!

4:08 PM Changeset in webkit [22874] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::setDefersLoading):
4:08 PM Changeset in webkit [22873] by sfalken
  • 12 edits in branches/WindowsMerge/WebKitWin
3:57 PM Changeset in webkit [19279] by hyatt
  • 4 adds in trunk/LayoutTests/fast/css

Add layout test for invalid pseudo-classes.

3:56 PM Changeset in webkit [19278] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4961953> Stop using NSString deprecated methods like initWithCString:

  • Misc/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]):
  • WebKit.xcodeproj/project.pbxproj:
3:55 PM Changeset in webkit [19277] by thatcher
  • 14 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4961953> Stop using NSString deprecated methods like initWithCString:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/svg/filters/cg/WKArithmeticFilter.m: (-[WKArithmeticFilter init]):
  • platform/graphics/svg/filters/cg/WKComponentMergeFilter.m: (-[WKComponentMergeFilter init]):
  • platform/graphics/svg/filters/cg/WKDiffuseLightingFilter.m: (-[WKDiffuseLightingFilter init]):
  • platform/graphics/svg/filters/cg/WKDiscreteTransferFilter.m: (-[WKDiscreteTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKDisplacementMapFilter.m: (-[WKDisplacementMapFilter init]):
  • platform/graphics/svg/filters/cg/WKDistantLightFilter.m: (-[WKDistantLightFilter init]):
  • platform/graphics/svg/filters/cg/WKGammaTransferFilter.m: (-[WKGammaTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKLinearTransferFilter.m: (-[WKLinearTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKNormalMapFilter.m: (-[WKNormalMapFilter init]):
  • platform/graphics/svg/filters/cg/WKPointLightFilter.m: (-[WKPointLightFilter init]):
  • platform/graphics/svg/filters/cg/WKSpecularLightingFilter.m: (-[WKSpecularLightingFilter init]):
  • platform/graphics/svg/filters/cg/WKSpotLightFilter.m: (-[WKSpotLightFilter init]):
  • platform/graphics/svg/filters/cg/WKTableTransferFilter.m: (-[WKTableTransferFilter init]):
3:54 PM Changeset in webkit [19276] by hyatt
  • 5 edits in trunk/WebCore

Fix for Radar bug #4679426, golden gate bridge Web site layout broken.


This is a regression caused by the addition of :lang support. This
feature caused us to accept any pseudo-class/element with function
arguments, even ones we couldn't handle. The site used such a construct
in conjunction with :not, which turned :not(something-crazy) into not(false).
This ended up being "true", and so we started matching a rule we used to
reject.

The fix is to now aggressively parse pseudo-elements and classes and to
cause the rejection of an entire rule if any pseudoclass or element within
any simple selector of that rule is unrecognized.

Reviewed by darin

fast/css/invalid-pseudo-classes.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
3:24 PM Changeset in webkit [19275] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • plugins/createScriptableObject-before-start-expected.txt: Added.
  • plugins/createScriptableObject-before-start.html: Added.

WebKit:

Reviewed by Geoff.

Test: plugins/createScriptableObject-before-start.html

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Return NULL if the plugin is not started.
3:14 PM Changeset in webkit [19274] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


<rdar://problem/4964407> REGRESSION: Mail hangs when replying, forwarding , or creating a new message


  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Set WebDataRequest property on data load requests since Mail specifically checks for this.
3:02 PM Changeset in webkit [19273] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/images/animated-background-image-crash-expected.txt: Added.
  • fast/images/animated-background-image-crash.html: Added.
  • fast/images/resources/animated.gif: Added.
  • fast/images/resources/animated2.gif: Added.

WebCore:

Reviewed by Darin.

Test: fast/images/animated-background-image-crash.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::arenaDelete): Deref() all background images and the border image.
2:57 PM Changeset in webkit [19272] by bdash
  • 1 edit
    2 moves in trunk/LayoutTests

2007-01-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Re-enable editing/pasteboard/paste-{RTFD,TIFF}.html now that a fix has been landed for:
​http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()

  • editing/pasteboard/paste-RTFD.html: Added.
  • editing/pasteboard/paste-RTFD.html-disabled: Removed.
  • editing/pasteboard/paste-TIFF.html: Added.
  • editing/pasteboard/paste-TIFF.html-disabled: Removed.
2:53 PM Changeset in webkit [19271] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • dom/EventTarget.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toNode): Use EventTargetNode instead of Node. Removed unneeded includes. Make EventTarget's destructor protected to make it clear that you should never delete one.
  • dom/EventTargetNode.h: (WebCore::EventTargetNode::toNode): Tweaked formatting. Updated for change to return value.
  • platform/graphics/BitmapImage.h: Updated comment for clarity. Marked FrameData Noncopyable.
  • platform/graphics/Image.h: Tweaked formatting.
  • platform/graphics/ImageAnimationObserver.h: Make ImageAnimationObserver's destructor protected to make it clear that you should never delete one.
2:36 PM Changeset in webkit [19270] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin (by way of Hyatt).

  • fast/table/inline-form-assert-expected.checksum: Added.
  • fast/table/inline-form-assert-expected.png: Added.
  • fast/table/inline-form-assert-expected.txt: Added.
  • fast/table/inline-form-assert.html: Added.

WebCore:

Reviewed by Darin (by way of Hyatt).

Test: fast/table/inline-form-assert.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): Changed the assertion to ignore inlines.
2:25 PM Changeset in webkit [19269] by weinig
  • 5 edits in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found

  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt: These tests now pass.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found

  • xml/XPathNSResolver.idl: added [ConvertNullStringTo=Null].
2:07 PM Changeset in webkit [19268] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/DateMath.cpp: Fix license header to reflect LGPL as the first license mentioned. We still mention the option of using under MPL or GPL since some of this code came from the Mozilla project with those license terms.
2:04 PM Changeset in webkit [19267] by andersca
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

Revert the parts of 19244 that removed deferring NSURLConnections, that was not a correct change.
Remove ASSERTS from loader.cpp that aren't true anymore since the callbacks are invoked without a handle
when loading a subresource from an archive.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading):
  • loader/loader.cpp: (WebCore::Loader::didFail): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):
1:57 PM Changeset in webkit [19266] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fix for <rdar://problem/4911504> REGRESSION: With a image selected, ctrl-clicking on page displays the wrong contextual menu items "Search in Google", "Search in Spotlight" and "Look up in Dictionary"
  • platform/ContextMenu.cpp: (WebCore::selectionContainsPossibleWord): Added. Returns true if there are some non-whitespace characters in the selection. (WebCore::ContextMenu::populate): Don't add SearchSpotlightItem, SearchWebItem, or LookInDictionaryItem if selectionContainsPossibleWord returns false.
12:59 PM Changeset in webkit [19265] by zimmermann
  • 12 edits
    4 adds in trunk

Reviewed by Oliver.

Respect stroke-width in absolute repaint rect calculations for SVG text.
Added test: svg/custom/text-repaint-including-stroke.svg

12:46 PM Changeset in webkit [19264] by sfalken
  • 2 edits in trunk/WebCore

2007-01-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Add missing includes.

  • ksvg2/svg/SVGElementInstance.cpp:
11:34 AM Changeset in webkit [22872] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-30 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
11:01 AM Changeset in webkit [19263] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12452
XPath id() function is not supported

WebCore:

  • xml/XPathFunctions.cpp: (WebCore::XPath::isWhitespace): A helper to detect XML whitespace.

(WebCore::XPath::FunId::isConstant):
(WebCore::XPath::FunId::doEvaluate):
(WebCore::XPath::FunctionMapping::):
Implemented id().

LayoutTests:

  • dom/svg/level3/xpath/Conformance_ID-expected.txt: This test now passes.
  • fast/xpath/complex-id-expected.txt: Added.
  • fast/xpath/complex-id.html: Added. A test for more advanced id() capabilities.
8:58 AM Changeset in webkit [19262] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed by yongjun/brad.
DESC: WAP CSS specific character format causing phone keypad input error TMCN-6S5MSE
​http://bugs.webkit.org/show_bug.cgi?id=12232

  • BrowserCore/Formcontrols/src/FControlformathandler.cpp: (TInputFormatChar::SuggestedCase):
7:47 AM Changeset in webkit [19261] by zack
  • 7 edits in trunk/WebCore

Make the gradients work on the Qt platform.
r=Sam

7:35 AM Changeset in webkit [19260] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed by yongjun
DESC: Invalid WAP CSS formats not being ignored - TMCN-6S5K87
​http://bugs.webkit.org/show_bug.cgi?id=12230

7:25 AM Changeset in webkit [19259] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen

Reviewed by ​joseph.ligman@nokia.com
DESC: Crash is detected when activating "Find" for the second time in page view.
​http://bugs.webkit.org/show_bug.cgi?id=12477

7:15 AM Changeset in webkit [19258] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun.

DESC: S60 3.2 Help: When application is launched via hyperlink, the cursor stays as wait cursor
​http://bugs.webkit.org/show_bug.cgi?id=12421

7:09 AM Changeset in webkit [19257] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed ​yongjun.zhang@nokia.com
DESC: Browser Control: Problem with History Stack when using custom datastore PKAI-6WGSHS
​http://bugs.webkit.org/show_bug.cgi?id=10325
(Additional fix then the last one)

6:22 AM Changeset in webkit [19256] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=12470
svn-create-patch creates duplicate patches for files within an added/modified directory

  • Scripts/svn-create-patch: (sub generateFileList($\%\%)): Ignore directories when generating the file list.
6:04 AM Changeset in webkit [19255] by bdash
  • 1 edit
    2 moves in trunk/LayoutTests

2007-01-31 Mark Rowe <​mrowe@apple.com>

Disable editing/pasteboard/paste-{RTFD,TIFF}.html so tests run to completion until a fix is landed for:
​http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()

  • editing/pasteboard/paste-RTFD.html: Removed.
  • editing/pasteboard/paste-RTFD.html-disabled: Added.
  • editing/pasteboard/paste-TIFF.html: Removed.
  • editing/pasteboard/paste-TIFF.html-disabled: Added.
4:44 AM Changeset in webkit [19254] by zimmermann
  • 21 edits
    36 adds
    1 delete in trunk

Reviewed by Eric & Oliver. Leak related fixes reviewed by Mark.

Finally make the SVG <use> implementation use the proper "shadow tree" concept,
which is also used by the HTML forms implementation. It's the first time in ksvg
history that <use> is not implement as a crude hack, but proper & sane.

4:09 AM Changeset in webkit [19253] by zack
  • 2 edits in trunk/WebKitQt

Improve QtLauncher to make it more useful as a testing tool.

3:09 AM Changeset in webkit [19252] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4928646> REGRESSION: manual-tests/remove-input-file-onchange.html crashes


  • platform/FileChooser.h: (WebCore::FileChooser::disconnected): New method, so the RenderFileControl can tell when it's gotten disconected.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Avoid calling repainted() when onChange() handler destroyed us.
2:20 AM Changeset in webkit [19251] by hausmann
  • 11 edits
    1 move
    1 add in trunk

For the Qt build combine JavaScriptCore and WebKit into one library, to make it possible to
build it with ELF visibility or on Windows without adding EXPORT macros to kjs all over the place.
r=zack

12:46 AM Changeset in webkit [19250] by zack
  • 5 edits in trunk

Make the Qt platform compile.

12:34 AM Changeset in webkit [19249] by zack
  • 2 edits in trunk/WebCore

Compile fix
r=aroben

12:13 AM Changeset in webkit [19248] by zack
  • 5 edits in trunk

Propagate the allows-scrolling property on the frames
correctly. If the frame has been constructed as non-
scrolling, respect that and don't show scrollbars.
r=Lars

Note: See TracTimeline for information about the timeline view.