Timeline

Feb 2, 2007:

9:54 PM Changeset in webkit [19383] by mjs

• 3 edits
  1 add in trunk

LayoutTests:

Reviewed by Hyatt & Adele.

• test case for <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)

• fast/forms/disabled-select-change-index.html: Added.

WebCore:

Reviewed by Hyatt & Adele.

• <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)

Test case: fast/forms/disabled-select-change-index.html

• html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelected): Allow changing selected state of a disabled option.

8:16 PM Changeset in webkit [19382] by bdash

• 3 edits in tags/Safari-521.34

Versioning.

8:11 PM Changeset in webkit [22894] by aliceli1

• 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Maciej.

Fixed <rdar://4956286> Find: Deleting all text in the Find banner search field should clear the page's selection

• Interfaces/IWebView.idl:
• WebView.cpp: (WebView::clearSelection):
• WebView.h:

Added a clearSelection function to webview so the findbanner can call it.

8:09 PM Changeset in webkit [19381] by bdash

• 21 edits in tags/Safari-521.34

Roll out r19327.

7:58 PM Changeset in webkit [19380] by bdash

• 1 copy in tags/Safari-521.34

New tag.

5:36 PM Changeset in webkit [19379] by zimmermann

• 2 edits in trunk/WebCore

Build fix, not reviewed.
Blind attempt to fix Qt build.

5:33 PM Changeset in webkit [19378] by zimmermann

• 14 edits
  16 adds in trunk

Reviewed by Eric & Maciej.

Fix serveral <use> issues:

• When events are dispatch to a referenced element, the actual event.target

has to be set to the corresponding SVGElementInstance object

• Node::shadowAncestorNode() should _not_ return the shadowParentNode for SVG elements

This is only needed for the HTML forms concept and breaks event dispatching for SVG shadow tree elements.

• Add SVGElementInstance as possible EventTarget in bindings/js/kjs_dom.cpp

(Now event.target returns the actual SVGElementInstance object for a shadow tree element)

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12502 (Reproducible crash when browsing SVG map.)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12511 (<use> has event dispatching issues)

Added test: svg/custom/use-event-handler-on-use-element.svg
Added test: svg/custom/use-event-handler-on-referenced-element.svg
Added test: svg/custom/use-elementInstance-event-target.svg
Added test: svg/custom/use-elementInstance-methods.svg

5:06 PM Changeset in webkit [19377] by ggaren

• 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Added some more known leaks to the leaks ignore list.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Why does XCode hate itself so much?
• Scripts/run-webkit-tests:

4:30 PM Changeset in webkit [22893] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix a crash when running the PLT.

• WebView.cpp: (WebView::initWithFrame):

Added assertions to make catching this easier.

4:25 PM Changeset in webkit [19376] by oliver

• 2 edits in trunk/WebCore

2007-02-02 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff.

Add guard around accessing [NSEvent eventNumber] to ensure
we don't attempt to access it on on non-mouse related NSEvent.

• platform/mac/PlatformMouseEventMac.mm: (WebCore::eventNumberForEvent): (WebCore::PlatformMouseEvent::PlatformMouseEvent):

3:53 PM Changeset in webkit [19375] by aroben

• 2 edits in trunk/WebCore

Reviewed by Anders.

Try to be a little less selfish about DocumentLoader.

Spotted while working on <rdar://problem/4957747>.

• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):

Everyone can open frames in new windows.

3:45 PM Changeset in webkit [19374] by zimmermann

• 9 edits in trunk/WebCore

Reviewed by Eric.

Move xml:space/xml:lang from svgattrs.in to xmlattrs.in where they actually belong.
Now they are actually recognized by SVGLangSpace::parseMappedAttribute.
Patch implementing xml:space="preserve" coming soon, which acts as test for this stuff.

Always build XMLNames.cpp (not only for SVG) and replace all occourences of
"​http://www.w3.org/XML/1998/namespace" by "XMLNames::xmlNamespaceURI".

3:03 PM Changeset in webkit [19373] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Working on a layout test.

Fix for <rdar://problem/4966100> REGRESSION: Reproducible ASSERT
hit at Walgreens.com

• page/Frame.cpp: (WebCore::Frame::setView): If we are setting the view to 0 and detaching the document, call unscheduleRealyout() on the old view before setting it to 0.

12:42 PM Changeset in webkit [19372] by brmorris

• 26 edits in S60/branches/3.1m

yongjzha, Reviewed by zalan.

DESC: backport google.com/ig refreshing memory leak fix in <​http://bugs.webkit.org/show_bug.cgi?id=10773> PPEN-6QYG7L
improve stability under low memory condition.
​http://bugs.webkit.org/show_bug.cgi?id=12541

11:57 AM Changeset in webkit [19371] by ggaren

• 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

add const back, too

11:56 AM Changeset in webkit [19370] by ggaren

• 2 edits in trunk/WebKitTools

Even better build fix than the last.

• ChangeLog:
• DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks):

11:50 AM Changeset in webkit [19369] by brmorris

• 2 edits in S60/branches/3.1m/WebCore

bujtas, Reviewed by yongjun.

Merge of r19368 to 3.1 by Brad.
DESC: browser crashes on www.tays.fi. when multiple layers are referring to the same background image, the render_object does not do proper deref on the image. MLIO-6XJAXG
fix: loop through the background layers and defer background images
​http://bugs.webkit.org/show_bug.cgi?id=12543

11:47 AM Changeset in webkit [19368] by brmorris

• 2 edits in S60/trunk/WebCore

bujtas, Reviewed by yongjun.

DESC: browser crashes on www.tays.fi. when multiple layers are referring to the same background image, the render_object does not do proper deref on the image.
fix: loop through the background layers and defer background images
​http://bugs.webkit.org/show_bug.cgi?id=12543

10:57 AM Changeset in webkit [19367] by ggaren

• 2 edits in trunk/WebKitTools

Fixed build. Added work-around for GCC bug.

• DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks):

10:48 AM Changeset in webkit [22892] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2007-02-02 Steve Falkenburg <​sfalken@apple.com>

Fix build.

• WebCore.vcproj/WebCore.vcproj:

10:36 AM Changeset in webkit [19366] by ggaren

• 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

build fix? i don't think so, but let's see...

10:04 AM Changeset in webkit [22891] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

9:57 AM Changeset in webkit [19365] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

• fix copying and assigning a ListHashSet

No test because the code path with bugs I am fixing is not used yet.

• wtf/ListHashSet.h: Tweaked ListHashSetNodeAllocator a little bit for clarity. Changed m_allocator to be an OwnPtr instead of doing an explicit delete. Fixed bug in copy constructor where we'd have an uninitialized m_allocator. Fixed bug in assignment operator where it would swap only the hash table, and not the head, tail, and allocator pointers.

9:55 AM Changeset in webkit [19364] by ggaren

• 12 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Use WTFLog instead of fprintf for logging KJS::Node leaks.

• kjs/nodes.cpp: (NodeCounter::~NodeCounter): Changed count to unsigned, updated to match style guidelines.

WebCore:

Reviewed by Maciej Stachowiak.

Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

• WebCore.exp:
• dom/Node.cpp: (WebCore::Node::isSupported): Moved isSupported up with the rest of the static functions.

(WebCore::): Added an ignoreSet, which collects WebCore::Nodes whose lifetime
we want to ignore. We need to track which nodes to ignore rather than, say,
just suspending the count, because node destruction depends on lots of
different variables, so it would be nearly impossible to know when exactly
to suspend the count and when exactly to resume it.

(WebCore::NodeCounter::~NodeCounter): Changed to use WTFLog instead of fprintf.

(WebCore::Node::startIgnoringLeaks): Do the ignoring.
(WebCore::Node::stopIgnoringLeaks): ditto
(WebCore::Node::Node): ditto
(WebCore::Node::~Node): ditto

• dom/Node.h: Moved isSupported up with the rest of the static functions.

• platform/mac/LoggingMac.mm: (WebCore::initializeWithUserDefault): Renamed from "initializeLoggingChannel" because the real goal here is to honor a user default -- WTFLoggingChannels need no run-time initialization. Also replaced "off by default, on if a user default says so" behavior with "only override existing setting if a user default says so" behavior. It seemed like a bug that you would specify a channel's on/off state in its definition, but this function would unconditionally blow that state away. (WebCore::InitializeLoggingChannelsIfNecessary):

WebKit:

Reviewed by Maciej Stachowiak.

Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

• Misc/WebCoreStatistics.h:
• Misc/WebCoreStatistics.mm: (+[WebCoreStatistics startIgnoringWebCoreNodeLeaks]): (+[WebCoreStatistics stopIgnoringWebCoreNodeLeaks]):

WebKitTools:

Reviewed by Maciej Stachowiak.

Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

• DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks): Implements a black list of tests whose WebCore::Node leaks we have to ignore. Does this CFString gobbledy-gook confuse anyone else? (runTest):

8:47 AM Changeset in webkit [19363] by brmorris

• 2 edits in S60/trunk/WebKit

yaharon, Reviewed by Yongjun.

DESC: [S60] FUTE_32: If web page included a link, which name is e.g. T0000900 user can't open it, cause phone starts calling to number 0000900. (KDIS-6XYCL5)
​http://bugs.webkit.org/show_bug.cgi?id=12534

8:28 AM Changeset in webkit [19362] by eseidel

• 190 edits
  8 adds in trunk

2007-02-02 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

Fix gradient stop style resolution to be less of a hack, fixing style invalidation:
​http://bugs.webkit.org/show_bug.cgi?id=12193
and fix stop-color and stop-opacity not to inherit:
​http://bugs.webkit.org/show_bug.cgi?id=12193

Tests:

• svg/custom/gradient-stops-style-change.svg: added
• svg/W3C-SVG-1.1/pservers-grad-18-b.svg: updated

• WebCore.xcodeproj/project.pbxproj:
• ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
• ksvg2/css/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
• ksvg2/css/SVGRenderStyle.h:
• ksvg2/svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::createRenderer):
• ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::createRenderer): (WebCore::SVGGradientElement::buildStops):
• ksvg2/svg/SVGGradientElement.h: (WebCore::SVGGradientElement::rendererIsNeeded):
• ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::createRenderer):
• ksvg2/svg/SVGStopElement.h: (WebCore::SVGStopElement::rendererIsNeeded):
• rendering/RenderSVGGradientStop.cpp: Added.
• rendering/RenderSVGGradientStop.h: Added.
• rendering/RenderSVGHiddenContainer.cpp: Added.
• rendering/RenderSVGHiddenContainer.h: Added.
• rendering/RenderSVGContainer.cpp:
• rendering/RenderSVGContainer.h:

6:41 AM Changeset in webkit [19361] by zack

• 2 edits in trunk/WebCore

Fix scrolling-on-selection bug by correctly
scrolling to the offset instead of trying to
ensure visibility with margins
r=Lars

6:09 AM Changeset in webkit [19360] by bdash

• 3 edits in tags/Safari-419.1

Versioning.

6:07 AM Changeset in webkit [19359] by bdash

• 1 copy in tags/Safari-419.1

New tag.

6:06 AM Changeset in webkit [19358] by bdash

• 6 edits in branches/Safari-2-0-branch

Update bundle identifiers.

4:27 AM Changeset in webkit [22890] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Turn on Lucida Grande.

3:06 AM Changeset in webkit [22889] by aroben

• 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Implemented menulist drawing.

2:26 AM Changeset in webkit [19357] by zack

• 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

actually set the pen on color setting

2:24 AM Changeset in webkit [19356] by zack

• 2 edits in trunk/WebCore

Fix drawing of dashed and colored lines. Pen
has to be inherited for stroke to stay consistent.
r=Lars

1:49 AM Changeset in webkit [19355] by zack

• 2 edits in trunk/WebKitQt

Compilation fix: forward declare d-ptr.

1:35 AM Changeset in webkit [19354] by mjs

• 2 edits in trunk/JavaScriptCore

• not reviewed, build fix

• wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): ummm, use union correctly

1:14 AM Changeset in webkit [19353] by mjs

• 1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Darin.

• use a custom allocator for ListHashSet, to fix ~1% perf regression using it for form control

• wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): (WTF::ListHashSetNodeAllocator::allocate): (WTF::ListHashSetNodeAllocator::deallocate): (WTF::ListHashSetNode::operator new): (WTF::ListHashSetNode::operator delete): (WTF::ListHashSetNode::destroy): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::~ListHashSet): (WTF::::add): (WTF::::unlinkAndDelete): (WTF::::deleteAllNodes):

1:09 AM Changeset in webkit [19352] by mjs

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

• use a custom allocator for ListHashSet, to fix ~1% per regression using it for form control

• wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): (WTF::ListHashSetNodeAllocator::allocate): (WTF::ListHashSetNodeAllocator::deallocate): (WTF::ListHashSetNode::operator new): (WTF::ListHashSetNode::operator delete): (WTF::ListHashSetNode::destroy): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::~ListHashSet): (WTF::::add): (WTF::::unlinkAndDelete): (WTF::::deleteAllNodes):

12:41 AM Changeset in webkit [19351] by zack

• 3 edits in trunk/WebKitQt

Make the frames white by default and get the
files that WebCore can handle render inside
the frames.
r=Lars

Feb 1, 2007:

11:43 PM Changeset in webkit [19350] by bdash

• 13 edits
  4 adds in trunk

2007-02-01 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Mark.

Add support for CSS2 font-stretch property.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/cssparser.cpp: (WebCore::CSSParser::parseValue):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
• platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontCache::getCachedFontPlatformData):
• platform/FontDescription.h: (WebCore::): (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::stretch): (WebCore::FontDescription::narrowerStretch): (WebCore::FontDescription::widerStretch): (WebCore::FontDescription::setStretch): (WebCore::FontDescription::operator==):
• platform/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData):
• platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): (+[WebFontCache fontWithFamily:traits:size:]):

2007-02-01 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Mark.

CSS2 font-stretch property; uses American Typewriter and Helvetica Neue fonts,
requiring Regular, Condensed, Bold and Bold Condensed faces.

• fast/css/computed-style-expected.txt: Updated.
• fast/css/font-stretch-expected.checksum: Added.
• fast/css/font-stretch-expected.png: Added.
• fast/css/font-stretch-expected.txt: Added.
• fast/css/font-stretch.html: Added.

2007-02-01 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Mark.

Add support for CSS2 font-stretch property.

• WebInspector/webInspector/inspector.js:
• WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]):

10:57 PM Changeset in webkit [19349] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4969201> REGRESSION: Safari applies the wrong font to BODY element at ​http://www.apple.com/downloads/dashboard/

• platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Don't call [NSFont fontWithName:] with the desiredFamily on Tiger.

9:52 PM Changeset in webkit [19348] by ap

• 4 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

WebCore:

• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Advance the pointer when necessary.

LayoutTests:

• fast/encoding/pseudo-tags-in-attributes-expected.txt: Changing back to success.

9:44 PM Changeset in webkit [19347] by staikos

• 4 edits
  2 adds in trunk

Add a cookie interface for the Qt build.

7:11 PM Changeset in webkit [19346] by bdakin

• 1530 edits in trunk/LayoutTests/tables/mozilla/bugs

un-doing accidental change that made all of the files in tables/mozilla/bugs allow tabs. whoopsie!

6:40 PM Changeset in webkit [19345] by mjs

• 3 edits in trunk/WebCore

Reviewed by Adele.

• fixed <rdar://problem/4922764> ASSERTION: (!m_contentFunction) in PolicyCheck::call trying to visit feed URL (CNN, Apple, etc.)

• loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck): Call new cancel method instead of call(false) on old check. (WebCore::PolicyCheck::cancel): call any callback function that is set with false or PolicyIgnore as appropriate.
• loader/FrameLoader.h:

5:55 PM Changeset in webkit [22888] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:55 PM Changeset in webkit [19344] by sfalken

• 1 copy in tags/Safari-521.33.1b

New tag.

5:41 PM Changeset in webkit [22887] by adachan

• 2 edits in branches/WindowsMerge/WebKitWin

2007-02-01 Ada Chan <​adachan@apple.com>

Reviewed by Anders.

Forgot to assign document to 0 in case of failure in WebView::mainFrameDocument().

• WebView.cpp: (WebView::mainFrameDocument):

5:34 PM Changeset in webkit [19343] by andersca

• 74 edits in trunk

LayoutTests:

Reviewed by Darin.

Update test results that have console messages.

• dom/html/level2/html/HTMLFrameElement09-expected.txt:
• dom/html/level2/html/HTMLIFrameElement11-expected.txt:
• dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
• dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
• dom/xhtml/level2/html/frame-expected.txt:
• dom/xhtml/level2/html/iframe-expected.txt:
• editing/execCommand/4920488-expected.txt:
• editing/selection/contenteditable-click-inside-expected.txt:
• editing/selection/contenteditable-click-outside-expected.txt:
• fast/AppleScript/001-expected.txt:
• fast/dynamic/015-expected.txt:
• fast/events/iframe-object-onload-expected.txt:
• fast/events/updateLayoutForHitTest-expected.txt:
• fast/forms/display-none-in-onchange-keyboard-expected.txt:
• fast/forms/input-text-click-inside-expected.txt:
• fast/forms/input-text-click-outside-expected.txt:
• fast/forms/selected-index-assert-expected.txt:
• fast/js/array-foreach-expected.txt:
• fast/js/array-some-expected.txt:
• fast/js/kde/exception_propagation-expected.txt:
• fast/js/kde/garbage-n-expected.txt:
• fast/js/kde/string-1-n-expected.txt:
• fast/js/kde/string-2-n-expected.txt:
• fast/parser/script-tag-with-trailing-slash-expected.txt:
• fast/table/click-near-anonymous-table-expected.txt:
• fast/tokenizer/002-expected.txt:
• fast/tokenizer/external-script-document-write_2-expected.txt:
• fast/tokenizer/script_extra_close-expected.txt:
• fast/xsl/transform-xhr-doc-expected.txt:
• http/tests/navigation/error404-goback-expected.txt:
• http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
• svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
• svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
• svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
• svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
• svg/custom/dynamic-empty-path-expected.txt:
• svg/custom/js-update-container-expected.txt:
• svg/custom/js-update-gradient-expected.txt:
• svg/custom/js-update-polygon-changes-expected.txt:
• svg/custom/js-update-polygon-removal-expected.txt:
• svg/custom/path-bad-data-expected.txt:
• svg/custom/polyline-hittest-expected.txt:
• svg/custom/polyline-invalid-points-expected.txt:
• svg/custom/polyline-setattribute-points-null-expected.txt:
• svg/custom/svgpolyparser-extra-space-expected.txt:
• svg/custom/use-modify-target-symbol-expected.txt:
• svg/custom/viewbox-syntax-expected.txt:
• tables/mozilla/bugs/bug53690-1-expected.txt:
• tables/mozilla/bugs/bug9024-expected.txt:
• tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
• tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
• tables/mozilla_expected_failures/core/captions1-expected.txt:
• tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
• tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
• tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
• tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:

WebKitTools:

Reviewed by Darin.

• DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:addMessageToConsole:]): Dump console messages.

4:52 PM Changeset in webkit [19342] by bdakin

• 1525 edits
  3 moves
  13 adds
  9 deletes in trunk

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=10517 REGRESSION
(r12065-r12082): Navigation graphic wraps to the next line on
duart.com and <rdar://problem/4960505> REGRESSION: The Awesome
Windows Vista page has a layout error in the header table (10517)

The problem is that we never supported a quirk that other browsers
support where, under very specific circumstances, a table cell will
grow to fit an image inside of it. This is only a regression
because a bug was fixed were we were 1 pixel off in the calculation
of overflow in some cases.

• rendering/RenderBlock.cpp: (WebCore::shouldGrowTableCellForImage): (WebCore::RenderBlock::calcInlineMinMaxWidth):

4:48 PM Changeset in webkit [22886] by adachan

• 3 edits in branches/WindowsMerge/WebKitWin

2007-02-01 Ada Chan <​adachan@apple.com>

Reviewed by Steve, Geoff.

WebKitWin:

<rdar://4969341> Regression: crash: when Resetting Safari
<rdar://4953390> Closing my two open boomer windows produced a crash
Fixed crash when closing second window and doing the close
all safari window option in Reset Safari.

• WebFrame.cpp: WebFramePrivate has a pointer to frameView but does not hold a reference to it. The frame holds a ref to the frameView anyway, so it's safest to get the frameView through the frame. The crash happened because frame already has cleared out its frameView but WebFrame was still accessing the old stale frameView through that data member in WebFramePrivate. (WebFrame::WebFramePrivate::m_policyFunction): (WebFrame::WebFramePrivate::frameView): (WebFrame::initWithWebFrameView): (WebFrame::layoutIfNeeded): (WebFrame::hasFrameView):
• WebView.cpp: (WebView::paintIntoBackingStore): bail if frameView is null. (WebView::setHostWindow): don't set the view window's parent to 0. It'll end up creating a standalone window.

3:35 PM Changeset in webkit [22885] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Make sure to always retain the request we return. (In practice, we were already doing this since client can never be null).

(WebCore::didReceiveResponse):
Remove client null check.

3:06 PM Changeset in webkit [22884] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2007-02-01 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

• WebCore.vcproj/WebCore.vcproj:

11:57 AM Changeset in webkit [22883] by andersca

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4969348>
REGRESSION: Crash loading pdf

• WebView.cpp: (WebView::canShowMIMEType): Return true if the MIME type can be handled by a plug-in.

11:57 AM Changeset in webkit [19341] by lars

• 2 edits in trunk/WebKitQt

Reviewed by Adam.

Fix form loading for the Qt build.

11:53 AM Changeset in webkit [19340] by brmorris

• 2 edits in S60/trunk/WebCore

brmorris, reviewed by zalan

DESC: Updated def file

• BWINS/WEBCOREU.DEF:

9:34 AM Changeset in webkit [19339] by darin

• 2 edits in trunk/LayoutTests

• fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test result to reflect failure because bug 12506 isn't fixed yet; we'll change it back once the bug is re-fixed.

4:27 AM Changeset in webkit [19338] by zack

• 5 edits in trunk/WebCore

Implement native look for comboboxes
and fix/implement popup menus. Also add the m_timestamp
and m_eventType setting to PlatformMouseEvent
r=Lars

12:56 AM Changeset in webkit [19337] by mjs

• 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4730469> REGRESSION: Assertion failure in -[WebDataSource(WebInternal) _bridge] when forwarding message

• WebView/WebDataSource.mm: (-[WebDataSource subresources]): Check for being uncommitted and return emtpy result. (-[WebDataSource subresourceForURL:]): ditto

12:44 AM Changeset in webkit [22882] by aroben

• 7 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Fix <rdar://problem/4849601> Implement printing of individual subframes

This just moves some functions from IWebViewPrivate to IWebFramePrivate.

• Interfaces/IWebFramePrivate.idl: Added declarations.
• Interfaces/IWebViewPrivate.idl: Removed declarations.
• WebFrame.cpp: Added functions from WebView.cpp. (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): (WebFrame::spoolPages):
• WebFrame.h: Added declarations.
• WebView.cpp: Moved functions to WebFrame.cpp.
• WebView.h: Removed declarations.

12:36 AM Changeset in webkit [19336] by darin

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by Maciej.

• test for <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event

• fast/forms/search-event-delay-expected.txt: Added.
• fast/forms/search-event-delay.html: Added.

WebCore:

Reviewed by Maciej.

• fix <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event

• rendering/RenderTextControl.h:
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): Set up timer. (WebCore::RenderTextControl::subtreeHasChanged): Start timer here instead of immediately sending event. (WebCore::RenderTextControl::searchEventTimerFired): Added. Sends search event. (WebCore::RenderTextControl::stopSearchEventTimer): Added. (WebCore::RenderTextControl::startSearchEventTimer): Added. Sends search event right away if there is no text. If there is some text, sets the timer using the same delay rule as NSSearchField. If you keep typing, then the timer keeps getting reset 0.2 seconds into the future until you pause.

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::onSearch): Tell the renderer to stop the timer, since we're sending a search event. This helps when a caller other than the timer decides to send an explicit search event.

12:23 AM Changeset in webkit [19335] by mjs

• 2 edits in trunk/WebCore

Fix by Darin, reviewed by Maciej.

• fix ~10% performance regression from encoding fix

• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix a logic error which made huge strings accidentally.