Context Navigation

← Previous Period
Next Period →

Timeline

Feb 4, 2007:

10:59 PM Changeset in webkit [22900] by adachan

2 edits in branches/WindowsMerge/WebKitWin

2007-02-04 Ada Chan <adachan@apple.com>

Reviewed by Steve.

WebKitWin:

<rdar://4946475> Private browsing is not working correctly
Implemented FrameLoaderClient::privateBrowsingEnabled().

WebFrame.cpp: (WebFrame::privateBrowsingEnabled):

10:06 PM Changeset in webkit [19399] by ap

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12602
XPath functions string(), normalize-space() and string-length() don't work
without arguments

Test: fast/xpath/implicit-node-args.html

xml/XPathFunctions.cpp: (WebCore::XPath::FunString::doEvaluate): (WebCore::XPath::FunStringLength::doEvaluate): (WebCore::XPath::FunNormalizeSpace::doEvaluate): Don't try to pass RefPtr<Node> to the Value ctor.

9:56 PM Changeset in webkit [19398] by ap

11 edits
14 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=8791
XPath should support custom node resolvers

WebCore:

bindings/js/JSCustomXPathNSResolver.cpp: Added. (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::~JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
bindings/js/JSCustomXPathNSResolver.h: Added.
bindings/objc/DOMCustomXPathNSResolver.h: Added.
bindings/objc/DOMCustomXPathNSResolver.mm: Added. (WebCore::DOMCustomXPathNSResolver::DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::~DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::lookupNamespaceURI): Wrappers for JS/ObjC objects that can be used as resolvers.

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm: Use the above wrappers to support custom resolvers.

xml/XPathNSResolver.cpp:
xml/XPathNSResolver.h: Turned this class into an abstract one.

xml/NativeXPathNSResolver.cpp: Added. (WebCore::NativeXPathNSResolver::NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::~NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::lookupNamespaceURI):
xml/NativeXPathNSResolver.h: Added. A XPathNSResolver subclass, doing what XPathNSResolver used to do.

xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver): Create a NativeXPathNSResolver.

WebCore.xcodeproj/project.pbxproj: Added new files.

LayoutTests:

fast/xpath/nsresolver-bad-object-expected.txt: Added.
fast/xpath/nsresolver-bad-object.xhtml: Added.
fast/xpath/nsresolver-exception-expected.txt: Added.
fast/xpath/nsresolver-exception.xhtml: Added.
fast/xpath/nsresolver-function-expected.txt: Added.
fast/xpath/nsresolver-function.xhtml: Added.
fast/xpath/nsresolver-object-expected.txt: Added.
fast/xpath/nsresolver-object.xhtml: Added.

9:55 PM Changeset in webkit [22899] by aliceli1

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix some memory leaks. This fixes WebFrame leak as well.
Can be considered a partial fix for <rdar://4974495> Boomer leaks while running HTML iBench

WebActionPropertyBag.cpp: (WebActionPropertyBag::WebActionPropertyBag):
WebDataSource.cpp: (WebDataSource::representation):
WebURLResponse.cpp: (:m_refCount):

7:52 PM Changeset in webkit [22898] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4972498> REGRESSION: Crash while closing View Source window

WebView.cpp: (WebView::WebView): Initialize new member. (WebViewWndProc): Set flag when we receive WM_DESTROY, and don't handle WM_SIZE if that flag is true. (WebView::mainFrame): Added argument check.
WebView.h: (WebView::setIsBeingDestroyed): Added. (WebView::isBeingDestroyed): Added.

6:54 PM Changeset in webkit [19397] by weinig

19 edits in trunk/LayoutTests

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12562
Fix test cases that are now spewing console errors that
they are not testing for

fast/events/iframe-object-onload-expected.txt:
fast/events/iframe-object-onload.html: Change nil to null.
fast/forms/display-none-in-onchange-keyboard-expected.txt:
fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change its text, and change the resulting text.
fast/forms/input-text-click-inside-expected.checksum:
fast/forms/input-text-click-inside-expected.png:
fast/forms/input-text-click-inside-expected.txt:
fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
fast/forms/input-text-click-outside-expected.txt:
fast/forms/input-text-click-outside.html: Ditto.
fast/js/array-foreach-expected.txt:
fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and general cleanup.
fast/js/array-some-expected.txt:
fast/js/array-some.html: Ditto.
fast/table/click-near-anonymous-table-expected.checksum:
fast/table/click-near-anonymous-table-expected.png:
fast/table/click-near-anonymous-table-expected.txt:
fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and change the amount of time from 500ms to 1000ms to avoid clicking.

6:38 PM Changeset in webkit [22897] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-02-04 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Removed unimplemented EventHandler::handleMouseUp,
as a platform independent version is available now.

page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Now we use this method, it needs to be implemented

6:37 PM Changeset in webkit [19396] by oliver

6 edits in trunk/WebCore

2007-02-04 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Tidying up EventHandler, and moving more of
EventHandlerMac.mm to EventHandler.cpp

Also added EventHandler::eventLoopHandleMouse[Dragged,Up]
these are basically helper functions to allow correct event
handling on MacOS.

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::EventHandler::dispatchDragSrcEvent):

Moved from EventHandlerMac to EventHandler

page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::eventLoopHandleMouseDragged): Null implementations of two Mac helper functions
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::handleDrag): Much tidying, reduced nesting, made less dependent on NS types (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): Helper functions to let us process events properly on MacOS

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):

5:08 PM Changeset in webkit [22896] by aroben

4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Hyatt.

Fix <rdar://problem/4968183> Cross-window frame targeting doesn't work

Interfaces/IWebView.idl: Pass RECT by value.
WebView.cpp: (WebView::initWithFrame): Uses the passed-in RECT for the frame, and sets the frame/group names.
WebView.h: Updated declaration.

6:15 AM Changeset in webkit [19395] by staikos

3 edits in trunk/WebCore

Various Qt related hacks and cleanups to make forms work better

Feb 3, 2007:

11:56 PM Changeset in webkit [19394] by mjs

1 edit
1 delete in trunk/WebCore

Rubber stamped by Adam.

remove obsolete code that has an annoying space in the directory name

WebCore.vcproj/Image Viewer.cpp: Removed.
WebCore.vcproj/Image Viewer.h: Removed.
WebCore.vcproj/Image Viewer.ico: Removed.
WebCore.vcproj/Image Viewer.rc: Removed.
WebCore.vcproj/Image Viewer.reg: Removed.
WebCore.vcproj/Image Viewer.vcproj: Removed.
WebCore.vcproj/Image Viewer/ImageDocument.cpp: Removed.
WebCore.vcproj/Image Viewer/ImageDocument.h: Removed.
WebCore.vcproj/Image Viewer/ImageMainFrame.cpp: Removed.
WebCore.vcproj/Image Viewer/ImageMainFrame.h: Removed.
WebCore.vcproj/Image Viewer/ImageView.cpp: Removed.
WebCore.vcproj/Image Viewer/ImageView.h: Removed.
WebCore.vcproj/Image Viewer/Resource.h: Removed.
WebCore.vcproj/Image Viewer/res/ImageViewer.rc2: Removed.
WebCore.vcproj/Image Viewer/res/Toolbar.bmp: Removed.
WebCore.vcproj/Image Viewer/stdafx.cpp: Removed.
WebCore.vcproj/Image Viewer/stdafx.h: Removed.
WebCore.vcproj/Image iewerDoc.ico: Removed.

11:37 PM Changeset in webkit [19393] by staikos

2 edits in trunk/JavaScriptCore

fix crash on JS that ends with an identifier

11:34 PM Changeset in webkit [19392] by oliver

2 edits in trunk/WebCore

2007-02-04 Mitz Pettel <mitz@webkit.org>

Reviewed by Oliver.

fix http://bugs.webkit.org/show_bug.cgi?id=12564 REGRESSION: Uncaught AppKit exception when using the scrollwheel while Gmail is loading

platform/mac/PlatformMouseEventMac.mm: (WebCore::eventNumberForEvent): Scroll wheel events don't have an event number.

10:50 PM Changeset in webkit [22895] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-02-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

<rdar://problem/4930947> Regression: History is not saved when boomer window is closed.

Fix boolean test causing lost history regression.

WebHistoryItem.cpp: (WebHistoryItem::hasURLString): isEmpty returns true if there is NO url, not if there is one.

6:07 PM Changeset in webkit [19391] by ggaren

1 edit
1 add in trunk/LayoutTests

Landing results that I think Maciej intended to land, to get the buildbot
back to green.

fast/forms/disabled-select-change-index-expected.txt: Added.

5:25 PM Changeset in webkit [19390] by zimmermann

12 edits
4 adds in trunk

Reviewed by Sam.

Add support for xml:space="preserve" for SVG text.
It can be modeled by using white-space="pre" and replace \n by spaces.

Handle xml:space="default" correctly.
Always remove tabs from SVG text - as demanded by spec.

Added test: svg/custom/text-whitespace-handling.svg

12:35 PM Changeset in webkit [19389] by ap

5 edits in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12560
W3C XPath test Text_Nodes.svg fails

Covered by dom/svg/level3/xpath/Text_Nodes.svg

xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Only include the first text sibling in text() matches.

12:22 PM Changeset in webkit [19388] by ap

4 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12485
XPath id() function doesn't work as root in paths

Test: fast/xpath/id-path.html

xml/XPathPath.cpp: (WebCore::XPath::Path::doEvaluate): Implemented. (WebCore::XPath::LocationPath::evaluate): A new overload that takes an initial NodeVector. (WebCore::XPath::LocationPath::doEvaluate): Moved most of the logic to the new evaluate().

xml/XPathPath.h: Added a new evaluate() overload and a using declaration to keep the generic one visible.

12:14 PM Changeset in webkit [19387] by ap

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12559
REGRESSION: Crash in checkForHeadCharset() under GuardMalloc

No tests possible.

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix end of buffer checks; sprinkle a number of new ones over the function.

7:00 AM Changeset in webkit [19386] by weinig