⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 5, 2007:

11:52 PM Changeset in webkit [22903] by beidson
  • 4 edits in branches/WindowsMerge/WebKitWin

Add config.h to some .cpps

9:43 PM Changeset in webkit [19425] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=12619
Non-abbreviated XPaths don't work

Test: fast/xpath/ancestor-axis.html

  • xml/XPathParser.cpp: (WebCore::XPath::Parser::lex): Fix axis name parsing to actually work.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Fix "*" node test to actually work.
8:10 PM Changeset in webkit [19424] by brmorris
  • 5 edits in S60/trunk/WebKit

bujtas, reviewed by Yongjun.

DESC: PartialImage() can end up in a dialog box which starts up a nested active scheduler JELE-6XSH3P

and since the page still being loaded in the background new image
data could come to the image decoder. that's a fatal re-entry on
the image decoder.

​http://bugs.webkit.org/show_bug.cgi?id=12550

7:55 PM Changeset in webkit [19423] by brmorris
  • 5 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by Yongjun.

DESC: PartialImage() can end up in a dialog box which starts up a nested active scheduler JELE-6XSH3P
​http://bugs.webkit.org/show_bug.cgi?id=12550

7:43 PM Changeset in webkit [19422] by ddkilzer
  • 5 edits in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7266
Webarchive format saves duplicate WebSubresources to .webarchive file

  • webarchive/test-duplicate-resources-expected.txt: Duplicate resources removed.
  • webarchive/test-frameset-expected.txt: Ditto.

WebKit:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7266
Webarchive format saves duplicate WebSubresources to .webarchive file

Tests: webarchive/test-duplicate-resources.html

webarchive/test-frameset.html

  • WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): Use an NSMutableSet to prevent duplicate subresources from being added to the webarchive.
6:27 PM Changeset in webkit [19421] by bdash
  • 13 edits
    4 deletes in trunk

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::weight): (WebCore::FontDescription::setWeight): (WebCore::FontDescription::operator==):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData):
  • platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): (+[WebFontCache fontWithFamily:traits:size:]):

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

  • WebInspector/webInspector/inspector.js:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]):

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

  • fast/css/computed-style-expected.txt:
  • fast/css/font-stretch-expected.checksum: Removed.
  • fast/css/font-stretch-expected.png: Removed.
  • fast/css/font-stretch-expected.txt: Removed.
  • fast/css/font-stretch.html: Removed.
6:12 PM Changeset in webkit [19420] by adele
  • 4 edits in trunk/WebCore

Reviewed by Darin.

A few small updates to my bidi patch.

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Moved the declaration of the CharacterBuffer outside the if statement since we use its data outside that scope.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Used a PassRefPtr for the BidiContext.
5:19 PM Changeset in webkit [19419] by justing
  • 3 edits in trunk/LayoutTests/editing/selection

Checked in old results. Fixed.

4:36 PM Changeset in webkit [19418] by adele
  • 4 edits in trunk/WebCore

Reviewed by Adam.

Fix for assertion failure in fast/events/objc-keyboard-event-creation.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectionStart): Check that the selection offsets are not equal to -1 (which is means the selection has never been set) instead of checking for >= 0. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::selection): Return an empty selection if the input is not a text field or if no selection has ever been set in the text field.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): Check that the selection offsets are not equal to -1. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::setValue): ditto. (WebCore::HTMLTextAreaElement::selection): Return an empty selection if no selection has ever been set in the textarea.
  • dom/Position.cpp: Added FIXMEs that we should catch the negative offset earlier. (WebCore::Position::previous): (WebCore::Position::next):
4:20 PM Changeset in webkit [19417] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4947387>
REGRESSION: Shift Command Left should only select to the beginning of the line

  • editing/selection/4947387-expected.checksum: Added.
  • editing/selection/4947387-expected.png: Added.
  • editing/selection/4947387-expected.txt: Added.
  • editing/selection/4947387.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4947387>
REGRESSION Shift Command Left should only select to the beginning of the line

  • editing/Editor.cpp: (WebCore::CommandEntry::): Never copy/paste code.
3:41 PM Changeset in webkit [19416] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/forms/input-select-on-click-expected.txt: Added.
  • fast/forms/input-select-on-click.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/forms/input-select-on-click.html

  • page/EventHandler.h: Added m_mouseDownWasSingleClickInSelection boolean. Organized other booleans a bit more logically.
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Rearrange order to match EventHandler.h, add m_mouseDownWasSingleClickInSelection initialization. (WebCore::EventHandler::handleMousePressEventSingleClick): Set m_mouseDownWasSingleClickInSelection to true in the appropriate special case. (WebCore::EventHandler::handleMousePressEvent): Set m_mouseDownWasSingleClickInSelection to false. (WebCore::EventHandler::handleMouseReleaseEvent): Change code to clear selection or set to caret to only fire if m_mouseDownWasSingleClickInSelection was true rather than firing for any m_mouseDownMayStartSelect case.
3:39 PM Changeset in webkit [19415] by staikos
  • 2 edits in trunk/WebCore

Make http cookies work

3:25 PM Changeset in webkit [19414] by adele
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by Mitz and Anders.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

  • fast/text/international/bidi-listbox-expected.checksum: Added.
  • fast/text/international/bidi-listbox-expected.png: Added.
  • fast/text/international/bidi-listbox-expected.txt: Added.
  • fast/text/international/bidi-listbox.html: Added.
  • fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
  • fast/text/international/bidi-listbox-atsui-expected.png: Added.
  • fast/text/international/bidi-listbox-atsui-expected.txt: Added.
  • fast/text/international/bidi-listbox-atsui.html: Added.

WebCore:

Reviewed by Mitz and Anders.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

​http://bugs.webkit.org/show_bug.cgi?id=11812
<rdar://problem/4960269> REGRESSION (Native file upload): Hebrew filenames are reversed

Tests:
fast/text/international/bidi-listbox.html
fast/text/international/bidi-listbox-atsui.html

  • rendering/RenderBlock.h: Added static bidiReorderCharacters that will run the bidi algorithm on a character buffer.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added. Creates an anonymous RenderBlock and RenderText to feed into bidiReorderLines. (WebCore::RenderBlock::constructLine): Uses the new convenience methods on BidiRun.
  • rendering/bidi.h: (WebCore::BidiRun::reversed): Added convenience method. (WebCore::BidiRun::dirOverride): ditto.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Creates a buffer and calls bidiReorderCharacters to get a correctly ordered character buffer for drawText.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.
3:22 PM Changeset in webkit [22902] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-05 Ada Chan <​adachan@apple.com>

Reviewed by Anders.


<rdar://4945519> Crash when back/forward buttons are clicked several times
Clear loader's previous history item when frame load is completed (got that code from the mac side).

  • WebFrame.cpp: (WebFrame::frameLoadCompleted):
3:19 PM Changeset in webkit [19413] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/selection-gap-overflow-scroll-expected.checksum: Added.
  • fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
  • fast/repaint/selection-gap-overflow-scroll-expected.txt: Added.
  • fast/repaint/selection-gap-overflow-scroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/repaint/selection-gap-overflow-scroll.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects): Adjust for overflow scroll.
3:07 PM Changeset in webkit [19412] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/search-rtl-expected.checksum: Added.
  • fast/forms/search-rtl-expected.png: Added.
  • fast/forms/search-rtl-expected.txt: Added.
  • fast/forms/search-rtl.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/search-rtl.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerBlockStyle): Always make the inner block LTR so that the results button will be on the left and the cancel button will be on the right. (WebCore::RenderTextControl::createInnerTextStyle): Inherit the direction property directly from the control so that it won't be masked by the inner block's LTR override. (WebCore::RenderTextControl::nodeAtPoint): Removed code that swapped the results and cancel buttons for RTL. (WebCore::RenderTextControl::forwardEvent): Ditto. (WebCore::RenderTextControl::clientPaddingLeft): Ditto. (WebCore::RenderTextControl::clientPaddingRight): Ditto.
2:55 PM Changeset in webkit [19411] by weinig
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/search-cancel-button-mouseup-expected.txt: Added.
  • fast/forms/search-cancel-button-mouseup.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/search-cancel-button-mouseup.html

Made the cancel button capturing.

  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
  • html/HTMLTextFieldInnerElement.h:
1:12 PM Changeset in webkit [19410] by ggaren
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Darin Adler.


New script that allows you to ignore leaks by regular expression.

  • Scripts/run-leaks: Added.
1:10 PM Changeset in webkit [19409] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Adam.

Fix for <rdar://problem/4975161> REGRESSION: With BumperCar 2.1.1,
the contextual menu fails to appear when I ctrl-click on page

  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): If the delegate does not respond to contextMenuItemsForElement, return the default menu instead of nil.
1:08 PM Changeset in webkit [19408] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by John Sullivan and Darin Adler.

Focused gc-8.html on the issue it was really trying to test (a crash)
to fix intermittent failures seen on buildbot.


  • fast/dom/gc-8.html: Don't test the value of our custom property, which (legitimately) can be cleared by garbage collection.
  • fast/dom/gc-8-expected.txt:
10:32 AM Changeset in webkit [19407] by ap
  • 4 edits
    1 add in trunk/WebCore

2007-02-05 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

No test possible since Mac OS X only ships with fonts that contain shaping
information.

  • icu/unicode/ushape.h: Added from ​http://www.opensource.apple.com/darwinsource/10.4.8.ppc/ICU-6.2.9/icuSources/common/unicode/
  • platform/FontData.h: (WebCore::FontData::shapesArabic): Added. Returns whether the font contains shaping information for Arabic or not.
  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit): (WebCore::FontData::checkShapesArabic): Added. Checks whether the font contains a glyph metamorphosis table. The heuristic is that if a font contains Arabic glyphs and a metamorphosis table, then it includes shaping information for Arabic.
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): Changed to use the same character buffer passed to ATSUI instead of the original character buffer and to give zero-width spaces zero width. (WebCore::isArabicLamWithAlefLigature): Added. Checks if the character is one of the Arabic presentation forms of Lam with Alef. (WebCore::shapeArabic): Added. This is a wrapper around the ICU Arabic shaping routine that replaces each space following a Lam with Alef ligature resulting from shaping with a zero-width space. (WebCore::ATSULayoutParameters::initialize): Changed to allocate the auxiliary buffer lazily for mirroring and Arabic shaping. Added a call to shapeArabic() when required.
9:24 AM Changeset in webkit [19406] by brmorris
  • 19 edits in S60/trunk

bujtas, merged of r19405 to s60/trunk by mbradley, reviewed by yongjun.

DESC: browser is crashing if it is closed while a page is loading and closing and opening a new window crashes the browser as well TMCN-6XRQP2
fix:

  1. cancel parsing when the document is being closed
  2. flush static image decoder queue. remove images associated with the the view being destroyed


​http://bugs.webkit.org/show_bug.cgi?id=12542

9:07 AM Changeset in webkit [19405] by brmorris
  • 19 edits in S60/branches/3.1m

bujtas <​zbujtas@gmail.com>, reviewed by Yongjun.

DESC: browser is crashing if it is closed while a page is loading and closing and opening a new window crashes the browser as well TMCN-6XRQP2
fix:

  1. change the order of destroying webkit objects.
  2. cancel parsing when the document is being closed
  3. flush static image decoder queue. remove images associated with the the view being destroyed
  4. remove formfill dependency on webkitcontrol. formfill is static object while webkitcontrol is per window.
  5. do not create formfill manager unless browser capabilities say so


​http://bugs.webkit.org/show_bug.cgi?id=12542

9:00 AM Changeset in webkit [19404] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

raalexan, Reviewed by Yongjun Zhang.

DESC: Enhanced Input feature not working in 3.1 [TSW TMCN-6XYSLY]
​http://bugs.webkit.org/show_bug.cgi?id=12533

8:51 AM Changeset in webkit [22901] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add new files.
7:18 AM Changeset in webkit [19403] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Clean up changelog entry. Also testing new svn-co-one-file script.

5:07 AM Changeset in webkit [19402] by eseidel
  • 2 edits in trunk/WebCore

2007-02-05 Eric Seidel <​eric@webkit.org>

No review, build fix only.

  • ksvg2/svg/SVGStyleElement.cpp: add forgotten header.
4:46 AM Changeset in webkit [19401] by eseidel
  • 3 edits in trunk/WebCore

2007-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

Fix style name testcase which I broke in my last commit.

  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::xmlspace): (WebCore::SVGStyleElement::title): override Element::title() (WebCore::SVGStyleElement::parseMappedAttribute):
  • ksvg2/svg/SVGStyleElement.h:
3:21 AM Changeset in webkit [19400] by eseidel
  • 11 edits
    1 add in trunk/WebCore

2007-02-04 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

Fix hand cursor on link hover for SVG
Fix status text on link hover for SVG
Fix tooltips on link hover for SVG
Fix link dragging for SVG
​http://bugs.webkit.org/show_bug.cgi?id=12575


Test: added manual-tests/svg-links.svg

  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
  • dom/Element.cpp: (WebCore::Element::title):
  • dom/Element.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setId): (WebCore::HTMLElement::title): (WebCore::HTMLElement::setTitle): (WebCore::HTMLElement::setLang):
  • html/HTMLElement.h:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::title): (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • manual-tests/svg-links.svg: Added.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::title): (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::isLiveLink): (WebCore::HitTestResult::titleDisplayString):

Feb 4, 2007:

10:59 PM Changeset in webkit [22900] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-04 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

WebKitWin:

<rdar://4946475> Private browsing is not working correctly
Implemented FrameLoaderClient::privateBrowsingEnabled().

  • WebFrame.cpp: (WebFrame::privateBrowsingEnabled):


10:06 PM Changeset in webkit [19399] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12602
XPath functions string(), normalize-space() and string-length() don't work
without arguments

Test: fast/xpath/implicit-node-args.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunString::doEvaluate): (WebCore::XPath::FunStringLength::doEvaluate): (WebCore::XPath::FunNormalizeSpace::doEvaluate): Don't try to pass RefPtr<Node> to the Value ctor.
9:56 PM Changeset in webkit [19398] by ap
  • 11 edits
    14 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=8791
XPath should support custom node resolvers

WebCore:

  • bindings/js/JSCustomXPathNSResolver.cpp: Added. (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::~JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSCustomXPathNSResolver.h: Added.
  • bindings/objc/DOMCustomXPathNSResolver.h: Added.
  • bindings/objc/DOMCustomXPathNSResolver.mm: Added. (WebCore::DOMCustomXPathNSResolver::DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::~DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::lookupNamespaceURI): Wrappers for JS/ObjC objects that can be used as resolvers.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm: Use the above wrappers to support custom resolvers.
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h: Turned this class into an abstract one.
  • xml/NativeXPathNSResolver.cpp: Added. (WebCore::NativeXPathNSResolver::NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::~NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::lookupNamespaceURI):
  • xml/NativeXPathNSResolver.h: Added. A XPathNSResolver subclass, doing what XPathNSResolver used to do.
  • xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver): Create a NativeXPathNSResolver.
  • WebCore.xcodeproj/project.pbxproj: Added new files.

LayoutTests:

  • fast/xpath/nsresolver-bad-object-expected.txt: Added.
  • fast/xpath/nsresolver-bad-object.xhtml: Added.
  • fast/xpath/nsresolver-exception-expected.txt: Added.
  • fast/xpath/nsresolver-exception.xhtml: Added.
  • fast/xpath/nsresolver-function-expected.txt: Added.
  • fast/xpath/nsresolver-function.xhtml: Added.
  • fast/xpath/nsresolver-object-expected.txt: Added.
  • fast/xpath/nsresolver-object.xhtml: Added.
9:55 PM Changeset in webkit [22899] by aliceli1
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix some memory leaks. This fixes WebFrame leak as well.
Can be considered a partial fix for <rdar://4974495> Boomer leaks while running HTML iBench

  • WebActionPropertyBag.cpp: (WebActionPropertyBag::WebActionPropertyBag):
  • WebDataSource.cpp: (WebDataSource::representation):
  • WebURLResponse.cpp: (:m_refCount):
7:52 PM Changeset in webkit [22898] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4972498> REGRESSION: Crash while closing View Source window

  • WebView.cpp: (WebView::WebView): Initialize new member. (WebViewWndProc): Set flag when we receive WM_DESTROY, and don't handle WM_SIZE if that flag is true. (WebView::mainFrame): Added argument check.
  • WebView.h: (WebView::setIsBeingDestroyed): Added. (WebView::isBeingDestroyed): Added.
6:54 PM Changeset in webkit [19397] by weinig
  • 19 edits in trunk/LayoutTests

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12562
Fix test cases that are now spewing console errors that
they are not testing for

  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/iframe-object-onload.html: Change nil to null.
  • fast/forms/display-none-in-onchange-keyboard-expected.txt:
  • fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change its text, and change the resulting text.
  • fast/forms/input-text-click-inside-expected.checksum:
  • fast/forms/input-text-click-inside-expected.png:
  • fast/forms/input-text-click-inside-expected.txt:
  • fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
  • fast/forms/input-text-click-outside-expected.txt:
  • fast/forms/input-text-click-outside.html: Ditto.
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and general cleanup.
  • fast/js/array-some-expected.txt:
  • fast/js/array-some.html: Ditto.
  • fast/table/click-near-anonymous-table-expected.checksum:
  • fast/table/click-near-anonymous-table-expected.png:
  • fast/table/click-near-anonymous-table-expected.txt:
  • fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and change the amount of time from 500ms to 1000ms to avoid clicking.
6:38 PM Changeset in webkit [22897] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Removed unimplemented EventHandler::handleMouseUp,
as a platform independent version is available now.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Now we use this method, it needs to be implemented
6:37 PM Changeset in webkit [19396] by oliver
  • 6 edits in trunk/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Tidying up EventHandler, and moving more of
EventHandlerMac.mm to EventHandler.cpp

Also added EventHandler::eventLoopHandleMouse[Dragged,Up]
these are basically helper functions to allow correct event
handling on MacOS.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::EventHandler::dispatchDragSrcEvent):

Moved from EventHandlerMac to EventHandler

  • page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::eventLoopHandleMouseDragged): Null implementations of two Mac helper functions
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::handleDrag): Much tidying, reduced nesting, made less dependent on NS types (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): Helper functions to let us process events properly on MacOS
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
5:08 PM Changeset in webkit [22896] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Hyatt.

Fix <rdar://problem/4968183> Cross-window frame targeting doesn't work

  • Interfaces/IWebView.idl: Pass RECT by value.
  • WebView.cpp: (WebView::initWithFrame): Uses the passed-in RECT for the frame, and sets the frame/group names.
  • WebView.h: Updated declaration.
6:15 AM Changeset in webkit [19395] by staikos
  • 3 edits in trunk/WebCore

Various Qt related hacks and cleanups to make forms work better

Note: See TracTimeline for information about the timeline view.