⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 8, 2007:

10:49 PM Changeset in webkit [19523] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Linux/gdk build fixes.

  • Projects/gdk/webcore-gdk.bkl: Account for file renaming.
  • platform/gdk/KeyEventGdk.cpp: Make gdk's tab key recognized as tab so that keyboard link walking works on gdk. (WebCore::keyIdentifierForGdkKeyCode):
10:29 PM Changeset in webkit [19522] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

  • fast/frames/iframe-window-focus-expected.txt: Added.
  • fast/frames/iframe-window-focus.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

When a frame's window was focused, the page didn't get updated about the new frame getting focus.
This was causing handleKeyPress to fail because it kept getting a selection for the wrong frame (which wasn't editable).

Test: fast/frames/iframe-window-focus.html

  • page/Frame.cpp: (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow):
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow):
10:29 PM Changeset in webkit [22927] by adele
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

This also fixes a bug where when you called window.focus() on a background window, it did not come to the front.

  • bridge/win/FrameWin.h: Removed focusWindow() and unfocusWindow() stubs since there are now implementations in the base class.
  • platform/win/TemporaryLinkStubs.cpp:
9:44 PM Changeset in webkit [22926] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

  • WebView.cpp: (WebView::searchFor): Ever since 11396, the widget no longer handles frame focus changes. This is now the page's focus controller responsibility
9:43 PM Changeset in webkit [19521] by bdash
  • 2 edits in trunk/WebKitSite

2007-02-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

  • nav.inc: Add link to very work-in-progress DOM documentation.
9:28 PM Changeset in webkit [22925] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Initial checkin for resume support (compiles everywhere, needs ToT CFnetwork to actually work)

8:20 PM Changeset in webkit [19520] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

  • fast/forms/listbox-deselect-scroll-expected.checksum: Added.
  • fast/forms/listbox-deselect-scroll-expected.png: Added.
  • fast/forms/listbox-deselect-scroll-expected.txt: Added.
  • fast/forms/listbox-deselect-scroll.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

Test: fast/forms/listbox-deselect-scroll.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::activeSelectionStartListIndex): Added. Returns the index for the active selection. If there is no active selection, it returns the first selected index. (WebCore::HTMLSelectElement::activeSelectionEndListIndex): Added. If there is no active selection, it returns the last selected index.
  • html/HTMLSelectElement.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollToRevealSelection): Instead of using the first and last selected indices, use the active selection indices to determine which item to reveal. This way, when you're selecting with the keyboard, or the mouse, no unnecessary scrolling will occur if the end of your active selection is already visible.
7:45 PM Changeset in webkit [19519] by brmorris
  • 3 edits in S60/branches/3.1m/WebCore

yaharon, Reviewed by zalan

DESC: crash when selecting the left Soft key Options when the cursor is in textarea field SCHY-6Y7SHD
​http://bugs.webkit.org/show_bug.cgi?id=12706

6:24 PM Changeset in webkit [19518] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

  • fast/forms/select-block-background-expected.checksum: Added.
  • fast/forms/select-block-background-expected.png: Added.
  • fast/forms/select-block-background-expected.txt: Added.
  • fast/forms/select-block-background.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

Test: fast/forms/select-block-background.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Paint the item backgrounds during the PaintPhaseChildBlockBackground or PaintPhaseChildBlockBackgrounds phase.
6:21 PM Changeset in webkit [19517] by bdash
  • 7 edits
    4 adds in trunk

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.


Test: fast/forms/select-empty-option-height.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setText): If the option text is empty, use a RenderBR as inner text, to ensure that the inner div has line height.

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.


  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/select-baseline-expected.txt:
  • fast/forms/select-empty-option-height-expected.checksum: Added.
  • fast/forms/select-empty-option-height-expected.png: Added.
  • fast/forms/select-empty-option-height-expected.txt: Added.
  • fast/forms/select-empty-option-height.html: Added.
  • fast/replaced/three-selects-break-expected.txt:
5:48 PM Changeset in webkit [19516] by ggaren
  • 5 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Added a hard counter for SubresourceLoaders because the leaks tool now
ignores them.


  • loader/SubresourceLoader.cpp: (WebCore::): (WebCore::SubresourceLoaderCounter::~SubresourceLoaderCounter): (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader):
  • page/Frame.cpp: Removed unnecessary #define

WebKitTools:

Reviewed by Beth Dakin.


Ignore another false leak report.

  • Scripts/run-webkit-tests:
5:45 PM Changeset in webkit [22924] by andersca
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4955068>
PluginViewWin leaks memory.


Make streams ref-counted. Remove streams from the hash set once they're done loading.


Don't try to paint if painting is disabled.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::disconnectStream):
  • plugins/win/PluginViewWin.h:
5:44 PM Changeset in webkit [19515] by ggaren
  • 4 edits in trunk

LayoutTests:

Reviewed by Beth Dakin.


Updated results now that we actually return the correct ones.

  • fast/css/computed-style-expected.txt:

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4982374> CSSComputedStyleDeclaration::getPropertyCSSValue
leak reported by buildbot


The leak was a typo: "new" instead of "return new". I also generously
deployed RefPtr in places that were holding ref-counted objects in
bare pointers.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
4:49 PM Changeset in webkit [22923] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Fix scrollbar painting.

3:07 PM Changeset in webkit [19514] by kjk
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • GdkLauncher/main.cpp: Add -exit-after-loading and -dump-render-tree as debugging aid. (strEq): (main):
3:01 PM Changeset in webkit [19513] by ggaren
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

build fix, oops!

2:59 PM Changeset in webkit [19512] by kjk
  • 4 edits
    2 copies in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: Added. Based on qt version. (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::shouldShowDeleteInterface): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::toggleGrammarChecking): (WebCore::EditorClientGdk::handleKeyPress): (WebCore::EditorClientGdk::EditorClientGdk): (WebCore::EditorClientGdk::setPage):
  • platform/gdk/EditorClientGdk.h: Added. Ditto.
  • platform/gdk/FrameGdk.cpp: Add exitAfterLoading and dumpRenderTreeAfterLoading as small debugging features. Remove FrameGdkClient as no other platform has Frame*Client anymore. Adjust for new APIs. (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::onDidFinishLoad): (WebCore::FrameGdk::dumpRenderTree): (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::FrameGdk::focusWindow): (WebCore::FrameGdk::unfocusWindow): (WebCore::FrameGdk::getObjectInstanceForWidget): (WebCore::FrameGdk::getEmbedInstanceForWidget): (WebCore::FrameGdk::bindingRootObject): (WebCore::FrameGdk::print): (WebCore::FrameGdk::getAppletInstanceForWidget): (WebCore::FrameGdk::issueCutCommand): (WebCore::FrameGdk::issueCopyCommand): (WebCore::FrameGdk::issuePasteCommand): (WebCore::FrameGdk::issueTransposeCommand): (WebCore::FrameGdk::issuePasteAndMatchStyleCommand): (WebCore::FrameGdk::markedTextRange): (WebCore::FrameGdk::shouldChangeSelection): (WebCore::FrameGdk::respondToChangedSelection): (WebCore::FrameGdk::mimeTypeForFileName):
  • platform/gdk/FrameGdk.h: Ditto. (WebCore::FrameGdk::setExitAfterLoading): (WebCore::FrameGdk::exitAfterLoading): (WebCore::FrameGdk::setDumpRenderTreeAfterLoading): (WebCore::FrameGdk::dumpRenderTreeAfterLoading): (WebCore::GdkFrame):
  • platform/gdk/TemporaryLinkStubs.cpp: Adjust to new APIs. Small cleanups. (FrameView::updateBorder): (Widget::setEnabled): (Widget::isEnabled): (Widget::enableFlushDrawing): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::findWordBoundary): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (Path::apply): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (PageCache::close): (Editor::ignoreSpelling): (Editor::learnSpelling): (Editor::isSelectionUngrammatical): (Editor::isSelectionMisspelled): (Editor::guessesForMisspelledSelection): (Editor::guessesForUngrammaticalSelection): (Editor::markMisspellingsAfterTypingToPosition): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenu::setPlatformDescription): (ContextMenu::platformDescription): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::systemBeep): (WebCore::userIdleTime):
2:37 PM Changeset in webkit [22922] by andersca
  • 6 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4972772>
Implement IWebResource::Data.


<rdar://problem/4972777>
Implement IWebDataSource::subresourceForURL.


  • MemoryStream.cpp: (MemoryStream::MemoryStream): (MemoryStream::createInstance): (MemoryStream::Clone):
  • MemoryStream.h: Remove notion of buffer owner, it's not needed now that the buffer itself is reference counted.


  • WebDataSource.cpp: (WebDataSource::subresourceForURL): Implement this.


  • WebKit.vcproj/WebKit.vcproj: Add WebResource.cpp and WebResource.h


  • WebResource.cpp: Added. (WebResource::WebResource): (WebResource::~WebResource): (WebResource::createInstance): (WebResource::QueryInterface): (WebResource::AddRef): (WebResource::Release): (WebResource::initWithData): (WebResource::data): (WebResource::URL): (WebResource::MIMEType): (WebResource::textEncodingName): (WebResource::frameName):
  • WebResource.h: Added.


  • WebView.cpp: (WebView::formDelegate): Return E_FAIL if there's no form delegate.
2:37 PM Changeset in webkit [19511] by kjk
  • 8 edits
    1 delete in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • platform/GlyphPageTreeNode.h: Fix header guard name.
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor):
  • platform/gdk/MouseEventGdk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gdk/PageGdk.cpp: Removed. No longer used.
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::getThemeData): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::adjustTextFieldStyle): (WebCore::RenderThemeGdk::paintTextField): (WebCore::RenderThemeGdk::paintTextArea): (WebCore::RenderThemeGdk::systemFont):
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
2:33 PM Changeset in webkit [19510] by ggaren
  • 2 edits in trunk/WebKitTools

Minor fixup based on Maciej's review last night.


  • Scripts/run-webkit-tests: Use normal "increment at end of loop" behavior, and do a little math to make it work.
2:31 PM Changeset in webkit [22921] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:30 PM Changeset in webkit [19509] by sfalken
  • 1 copy in tags/Safari-521.34.2b

New tag.

2:15 PM Changeset in webkit [19508] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes for cairo.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::toCairoOperator): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::fillRoundedRect):
2:07 PM Changeset in webkit [19507] by kjk
  • 6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • webcore-base.bkl:

WebKitTools:

Reviewed by Adam Roben..

Linux/gdk build fixes.

  • GdkLauncher/gdklauncher.bkl:
1:03 PM Changeset in webkit [22920] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Remove unused stub.


  • platform/win/TemporaryLinkStubs.cpp:
1:01 PM Changeset in webkit [19506] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher

Tweaked the thread violation behavior to be disabled by default, and to provide
an easy breakpoint to set.
The possibilities for the "WebCoreThreadCheck" user defaults key are -

  • The value "None" disables thread checking
  • The value "Log" causes an NSLog on a violation
  • The value "Exception" causes exceptions to be raised on a violation
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation): In the global namespace, making breakpoints cake!
12:56 PM Changeset in webkit [19505] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben, Darin Adler.


Updated results for tests that started failing after my run-webkit-tests
check-in.


These failures were not regressions. My check-in just caused the regular
bot to behave more like the leaks bot, so it started reporting the results
that the leaks bot had been reporting all along.

There does seem to be an underlying bug in the way XHTML documents report
line numbers for JavaScript exceptions. I've file that bug along with a
reduction:


​http://bugs.webkit.org/show_bug.cgi?id=12700
JavaScript errors in XML documents have incorrect line numbers


However, that bug is not a regression, so I think we should treat it separately.

  • dom/xhtml/level2/html/frame-expected.txt:
  • dom/xhtml/level2/html/iframe-expected.txt:
12:45 PM S60Webkit edited by franklin.davis@nokia.com
(diff)
12:42 PM S60Reindeer edited by franklin.davis@nokia.com
(diff)
12:38 PM S60Webkit edited by bradley.morrison@nokia.com
minor update to urls on s60webkit page (diff)
12:23 PM Changeset in webkit [19504] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by

  • Fix layout test failures.
  • Scripts/run-webkit-tests:
11:59 AM Changeset in webkit [22919] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Add shouldInterruptJavaScript to the API.


  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebChromeClient.cpp: (WebChromeClient::addMessageToConsole): (WebChromeClient::shouldInterruptJavaScript):
11:58 AM Changeset in webkit [19503] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4983515> Need mechanism to protect against WebKit calls from secondary threads
This initial landing is a conservative move until we can be certain of performance impact.
By writing to the user defaults key @"WebCoreThreadCheck" for the WebKit app you're running -

  • The value "None" disables thread checking
  • The value "Exception" causes exceptions to be raised on a violation
  • The default is to do the check, and NSLog each violation
  • bindings/objc/ExceptionHandlers.h: Add a "Is Main Thread" assert macro
  • bindings/scripts/CodeGeneratorObjC.pm: Use new mechanism in allocs and deallocs for now
  • platform/Logging.h: Added WebCoreThreadViolationCheck macro
  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Check for main-threadedness, and do some stuff
11:48 AM Changeset in webkit [22918] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

<rdar://problem/4888871>
Need to support synchronous XMLHttpRequest.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
11:19 AM Changeset in webkit [19502] by kmccullo
  • 2 edits in trunk/WebKit

Reviewed by

  • fixing a build breakage.
  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
10:52 AM Changeset in webkit [19501] by brmorris
  • 8 edits in S60/trunk

brmorris <​bradley.morrison@nokia.com>, rs'd by zalan

DESC: merge from s60/branches/3.1m to s60/trunk of r19464, r19466, r19472 & r19499

10:39 AM Changeset in webkit [19500] by kmccullo
  • 18 edits
    17 adds in trunk

LayoutTests:

Reviewed by Maciej, Darin and Mark.

rdar://problem/4922454

  • No longer allow remote sites to access local resources.
  • fast/loader/local-JavaScript-from-local-expected.txt: Added.
  • fast/loader/local-JavaScript-from-local.html: Added.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Added.
  • fast/loader/local-iFrame-source-from-local.html: Added.
  • fast/loader/local-image-from-local-expected.txt: Added.
  • fast/loader/local-image-from-local.html: Added.
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
  • http/tests/security/local-JavaScript-from-remote.html: Added.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Added.
  • http/tests/security/local-iFrame-from-remote.html: Added.
  • http/tests/security/local-image-from-remote-expected.txt: Added.
  • http/tests/security/local-image-from-remote.html: Added.
  • http/tests/security/resources/compass.jpg: Added.
  • http/tests/security/resources/localPage.html: Added.
  • http/tests/security/resources/localPage.html.orig: Added.
  • http/tests/security/resources/localScript.js: Added.

WebCore:

Reviewed by Maciej, Darin, and Mark.

rdar://problem/4922454

  • Prevents remote sites from executing local scripts.
  • bindings/objc/DOM.mm: - renamed a function that is now in the base class (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/XMLTokenizer.cpp: - removed needless asserts (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLImageLoader.cpp: - renamed a function that is now in the base class (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLTokenizer.cpp: - removed needless asserts (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: - renamed a function that is now in the base class (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: - return early if an error occured (WebCore::Cache::requestResource): (WebCore::Cache::remove):
  • loader/CachedImage.h: - renamed a function that is now in the base class (WebCore::CachedImage::canRender):
  • loader/CachedResource.h: - renamed a function that is now in the base class (WebCore::CachedResource::errorOccurred):
  • loader/CachedScript.h: - renamed a function that is now in the base class (WebCore::CachedScript::schedule):
  • loader/DocLoader.cpp: - The heart of the fix, prevents resources from being created or retrieved from the cache if a remote site is requesting the local resource. (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • page/EventHandler.cpp: - renamed a function that is now in the base class (WebCore::selectCursor):
  • rendering/HitTestResult.cpp: - renamed a function that is now in the base class (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: - renamed a function that is now in the base class (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: - renamed a function that is now in the base class (WebCore::RenderImage::errorOccurred):
  • rendering/RenderListItem.cpp: - renamed a function that is now in the base class (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: - renamed a function that is now in the base class (WebCore::RenderListMarker::isImage):
10:28 AM Changeset in webkit [19499] by brmorris
  • 4 edits in S60/branches/3.1m/WebKit

yaharon, reviewed by yongjun.

DESC: [S60] Daily BAT 3.2: S60NG_Login- Password field is not filled automatically KDEA-6XZEDY
​http://bugs.webkit.org/show_bug.cgi?id=12696

10:19 AM Changeset in webkit [19498] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

  • Scripts/check-for-global-initializers: For speed, only check files that have been modified since the last time we linked. For tidiness, capture stderr from nm, and prevent "nm: no name list" messages from going out.
12:43 AM Changeset in webkit [22917] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontCacheWin.cpp

Remove my garbled fixme that I didn't intend to leave in. :)

12:42 AM Changeset in webkit [19497] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej Stachowiak, Adam Roben.


Added 'nthly' support to run-webkit-tests. It's like 'singly', for an
arbitrary number n.


Plus some renames:

  • DumpRenderTree => "dumpTool" (to match abstraction elsewhere)
  • checkLeaks => "shouldCheckLeaks" (to match style guidelines)
  • tool => dumpTool (to match abstraction elsewhere)
  • httpdOpen => isHttpdOpen (to match style guidelines)


Plus a few logic fixups:

  • Don't check isDumpToolOpen when we know we've called openDumpTool().
  • Use a single code path to decide when to shut down dumpTool and when to check for leaks, since the operations are coincidental.
  • Use a single code path for running the leaks tool, since the only thing that varies between configurations is the output file name.
  • Increment $count after each test finishes, instead of at the end of the loop, to help with comparing to the length of the array and %-ing by n.
  • Use a more robust test inside the loop to determine if we need to close dumpTool, instead of copying the closing code outside the loop.


Layout tests pass.

  • Scripts/run-webkit-tests:
12:40 AM Changeset in webkit [22916] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore/platform/win

Make Lucida Grande bold work in the engine. Required sick special case hackery for now. Also fix the validity check for initial font construction. r=aroben

Feb 7, 2007:

11:56 PM Changeset in webkit [22915] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Fix mini search field painting.

10:29 PM Changeset in webkit [19496] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Add updateGeometry() to gdk's ScrollView. Needed to fix resizing of the window
in gdk.

  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::updateGeometry): (WebCore::ScrollView::setDrawable):
10:25 PM Changeset in webkit [19495] by kjk
  • 3 edits
    1 move
    1 delete in trunk/WebCore

Reviewed by Maciej.

Linux/gdk build fixes.

  • platform/ContextMenuItem.h:
  • platform/PlatformMenuDescription.h:
  • platform/gdk/PopupMenuGdk.cpp: Added. Renamed from RenderPopupMenuGdk.cpp for consistency with other platforms. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu):
  • platform/gdk/RenderPopupMenuGdk.cpp: Removed.
  • platform/gdk/RenderPopupMenuGdk.h: Removed.
10:24 PM Changeset in webkit [22914] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Draw a single down arrow for styled menu lists.

9:41 PM Changeset in webkit [19494] by aroben
  • 2 edits in trunk/WebKit

2007-02-07 Charles Ying <​charles_ying@yahoo.com>

Reviewed by Adam.

Code suggestion by aroben


Fix ​http://bugs.webkit.org/show_bug.cgi?id=12688

REGRESSION (r19469): ASSERT when right clicking on hyperlinks! in TOT webkit


  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients):
  • fixMenusReceivedFromOldClients was hitting an ASSERT incorrectly because it could not match [item title] to any of the contentMenuItemTags using pointer comparison ==. Instead, it needs to do a string comparison between [item title] and the various contentMenuItemTags using isEqualToString instead of ==. You would encounter this whenever the context menu was activated, e.g., from a hyperlink right click (or control click).
9:19 PM Changeset in webkit [22913] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

rs=adam

9:12 PM Changeset in webkit [19493] by bdash
  • 3 edits
    4 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/block/float/nowrap-clear-min-width.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlineMinMaxWidth):

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/block/float/nowrap-clear-min-width-expected.checksum: Added.
  • fast/block/float/nowrap-clear-min-width-expected.png: Added.
  • fast/block/float/nowrap-clear-min-width-expected.txt: Added.
  • fast/block/float/nowrap-clear-min-width.html: Added.
9:10 PM Changeset in webkit [19492] by bdash
  • 8 edits
    4 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/repaint/intermediate-layout-position.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Adjust the old bounds by the layout delta, to get the block's absolute bounds as they were before its ancestors moved it during layout. (WebCore::RenderBlock::collapseMargins): Update the layout delta for the child when moving it. (WebCore::RenderBlock::clearFloatsIfNeeded): Ditto. (WebCore::RenderBlock::determineHorizontalPosition): Ditto. (WebCore::RenderBlock::layoutBlockChildren): Ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Adjust the old bounds by the current layout delta.
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Ditto.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Ditto.
  • rendering/RenderView.h: (WebCore::RenderView::layoutDelta): Added. Keeps track of the offset between the position of the object currently being laid out and its position at the end of the last layout. (WebCore::RenderView::addLayoutDelta): Added.

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/intermediate-layout-position-expected.checksum: Added.
  • fast/repaint/intermediate-layout-position-expected.png: Added.
  • fast/repaint/intermediate-layout-position-expected.txt: Added.
  • fast/repaint/intermediate-layout-position.html: Added.
9:06 PM Changeset in webkit [19491] by bdash
  • 2 edits in trunk/WebCore

2007-02-07 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=6286
Very large (~500MB) images cause reproducible Safari crash

  • loader/CachedImage.cpp: (WebCore::CachedImage::bufferData): Detect failure to create a large Vector<> and call error() when that happens.
8:56 PM Changeset in webkit [19490] by bdash
  • 25 edits
    6 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/backgrounds/repeat/negative-offset-repeat.html

Test: fast/repaint/table-col-background.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Added. Finds the border and/or background layer(s) that use the image and invalidates only the rect in which the image actually paints. There are two special cases in this function: 1) for the body element, the background is propagated to the root; 2) inline flows do a full repaint. (WebCore::RenderBox::calculateBackgroundImageGeometry): Added. Factored out, simplified and corrected the calculation of the rectangle into which the background image paints, the tile size and the pattern phase. (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderBox.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::imageChanged): Moved the implementation to RenderBox.
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::getAbsoluteRepaintRect): Overridden to return the table's repaint rect. (WebCore::RenderTableCol::imageChanged): Overridden to do a full repaint, which currently repaints the entire table.
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::imageChanged): Overridden to do a full repaint of the row, since the backgrounds are painted by the cells.
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::imageChanged): Overridden to do a full repaint of the section, since the backgrounds are painted by the cells.
  • rendering/RenderTableSection.h:

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.


  • fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • fast/backgrounds/repeat/negative-offset-repeat-expected.txt: Added.
  • fast/backgrounds/repeat/negative-offset-repeat.html: Added. Based on a test by Mark Rowe.
  • fast/backgrounds/repeat/resources/gradient.gif: Added.
  • fast/repaint/table-col-background-expected.checksum: Added.
  • fast/repaint/table-col-background-expected.png: Added.
  • fast/repaint/table-col-background-expected.txt: Added.
  • fast/repaint/table-col-background.html: Added.
  • tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • tables/mozilla/marvin/backgr_position-table-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
7:58 PM Changeset in webkit [19489] by darin
  • 2 edits in trunk/JavaScriptCore
7:32 PM Changeset in webkit [22912] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Rubberstamped by Maciej.

Turn on SafariTheme so we can try it out.

  • WebCore.vcproj/WebCore.vcproj:
7:22 PM Changeset in webkit [22911] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin
  • WebChromeClient.cpp:
  • WebChromeClient.h: Build fix.
7:07 PM Changeset in webkit [19488] by andersca
  • 3 edits in trunk/WebKitQt

Try fixing the Qt build.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::shouldInterruptJavaScript):
  • WebCoreSupport/ChromeClientQt.h:
7:05 PM Changeset in webkit [19487] by andersca
  • 14 edits in trunk

WebCore:

Reviewed by Maciej.

Move shouldInterruptJavaScript to the Chrome.

  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):
  • page/Chrome.cpp: (WebCore::Chrome::shouldInterruptJavaScript):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript):

WebKit:

Reviewed by Maciej.

Move shouldInterruptJavaScript to the Chrome.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript):
  • WebCoreSupport/WebFrameBridge.mm:
6:46 PM Changeset in webkit [22910] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

6:20 PM Changeset in webkit [19486] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • <rdar://problem/4826861> WebKit tests show memory leaks in NSHTMLReader, caused by method named "hash"
  • bindings/scripts/CodeGeneratorObjC.pm: Added a list of method names we should never use, since they are in base classes WebScriptObject and NSObject. Luckily, only "hash" is causing trouble. Added "hash" to the existing special case for "id". Now "hash" is "hashName" just as "id" is "idName".
5:35 PM Changeset in webkit [19485] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Kevin Decker

  • fixed all places in WebKit where _web_userVisibleString was used where _web_originalDataAsString should have been used instead.
  • History/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): use _web_originalDataAsString when writing since these aren't displayed to the user (+[WebURLsWithTitles URLsFromPasteboard:]): use _web_URLWithDataAsString when reading, to match what we used when writing
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeURL:andTitle:types:]): use _web_originalDataAsString when writing the NSURL type; continue using _web_userVisibleString when writing the plain text type
  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): added comment about why _web_userVisibleString is appropriate here (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): use _web_originalDataAsString when setting the href attribute of an anchor tag
5:29 PM Changeset in webkit [19484] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4943650> REGRESSION: insertion point blink redraws entire web page, making everything slow

Problem is that AppKit recently changed NSControl to trigger a full redraw if the control has a focus ring.
WebHTMLView is a subclass of NSControl, but the focus ring type was the default value, though we actually
draw no focus ring. Fix is to formally set our focus ring type.


  • WebView/WebHTMLView.mm: (-[WebHTMLView initWithFrame:]): Send [self setFocusRingType:NSFocusRingTypeNone].
4:49 PM Changeset in webkit [19483] by sullivan
  • 2 edits in trunk/WebKit

Undid changes that I hadn't intended to check in

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
4:41 PM Changeset in webkit [19482] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Ollie and Geoff

  • fixed <rdar://problem/4982345> KURL::createCFURL leak inside -[WebFrameBridge startDraggingImage...] reported by buildbot

(-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
don't retain the imageURL we pass to the drag controller -- it's just automagically
converted to a KURL anyway

3:09 PM Changeset in webkit [19481] by kjk
  • 4 edits in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes for graphics-related stuff.

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::drawPattern):
2:54 PM Changeset in webkit [19480] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • fixed <rdar://problem/4974420> REGRESSION: Dragging a saved image into the browser window displays a error (No File exists at the address "null") (12662)
  • WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::urlFromPasteboard): use _web_originalDataAsString instead of _web_userVisibleString, since _web_userVisibleString can return a string with non-ASCII characters -- suitable for display but not for code
2:35 PM Changeset in webkit [19479] by kjk
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

Linux/gdk build fixes related to networking.

  • platform/network/ResourceHandleInternal.h: Add accessor for m_client. (WebCore::ResourceHandleInternal::client):
  • platform/network/gdk/ResourceHandleCurl.cpp: Add missing functions and massage for changed APIs. (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: Rename get() to sharedInstance(). Massaged for changed APIs. (WebCore::ResourceHandleManager::sharedInstance): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):
  • platform/network/gdk/ResourceHandleManager.h: Ditto.
2:16 PM Changeset in webkit [19478] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Mismatched type of alloc/free function crashes gdk build.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::close):
2:11 PM Changeset in webkit [19477] by kjk
  • 2 edits
    1 copy in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add file based on qt implementation.

  • platform/DragData.h:
  • platform/gdk/DragDataGdk.cpp: Added.
1:53 PM Changeset in webkit [19476] by kjk
  • 1 edit
    2 copies
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add new files based on qt implementation.

  • page/gdk/DragControllerGdk.cpp: Added. (WebCore::DragController::dragOperation):
  • page/gdk/EventHandlerGdk.cpp: Added. (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::eventActivatedView):
1:32 PM Changeset in webkit [19475] by kjk
  • 1 edit
    3 copies
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add new files based on Qt implementation.

  • loader/gdk/DocumentLoaderGdk.cpp: Added. (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: Added. (WebCore::FrameLoaderClientGdk::FrameLoaderClientGdk): (WebCore::FrameLoaderClientGdk::frame): (WebCore::FrameLoaderClientGdk::userAgent): (WebCore::FrameLoaderClientGdk::createDocumentLoader): (WebCore::FrameLoaderClientGdk::dispatchWillSubmitForm): (WebCore::FrameLoaderClientGdk::committedLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::postProgressStartedNotification): (WebCore::FrameLoaderClientGdk::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientGdk::postProgressFinishedNotification): (WebCore::FrameLoaderClientGdk::frameLoaderDestroyed): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::setMainFrameDocumentReady): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoad): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::didChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload): (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
  • loader/gdk/FrameLoaderClientGdk.h: Added. (WebCore::FrameLoaderClientGdk::~FrameLoaderClientGdk): (WebCore::FrameLoaderClientGdk::setFrame):
12:52 PM Changeset in webkit [19474] by kjk
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Linux/gdk fixes related to fonts.

  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit): remove a work-around for older cairo versions since Ubuntu 6.10 ships with cairo that is new enough
  • platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
  • platform/gdk/FontPlatformDataGdk.cpp: Remove unused variables. (WebCore::FontPlatformData::FontPlatformData):
12:15 PM Changeset in webkit [19473] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12582
REGRESSION: Unclosed <title> makes the window display garbage or empty title

Automatic testing is not possible, and manual testing probably doesn't make sense.

  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Bail out early if the passed in string is all whitespace.
12:08 PM Changeset in webkit [19472] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

yadavall, Reviewed by Zalan

DESC: Unclosed object tag causing problem MPAK-6XC86M
​http://bugs.webkit.org/show_bug.cgi?id=12680

12:02 PM Changeset in webkit [19471] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • another build fix; this time for sure
  • pcre/pcre_exec.c: (match): The compiler caught an incorrect use of the othercase variable across a call to RMATCH in character repeat processing. Local variables can change in the crazy NO_RECURSE mode that we use, so we instead need the value in othercase to be in one of the special stack frame variables. Added a new stack frame variable for this purpose named repeat_othercase. Also noted a similar error in the non-UTF-16 side of the #ifdef, but didn't try to fix that one. Also removed a SUPPORT_UCP #ifdef from the PCRE_UTF16 side; that code doesn't work without the Unicde properties table, and we don't try to use it that way.
11:49 AM Changeset in webkit [19470] by andersca
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4977952>
REGRESSION: Yahoo Messenger IM is totally blank


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkContentPolicy): Don't ask the policy delegate for content that has valid substitute data.


(WebCore::FrameLoader::checkNavigationPolicy):
If the loader has substitute data but doesn't have an unreachable URL, let the policy
delegate decide what to do.

11:48 AM Changeset in webkit [19469] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • added some clarity to some menu-handling shenanigans
  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): renamed from fixMenusForOldClients; added comments, FIXME, and assertion (fixMenusReceivedFromOldClients): renamed from fixMenusFromOldClients; added comments, FIXME, and assertion (WebContextMenuClient::getCustomMenuFromDefaultItems): updated for name changes
11:46 AM Changeset in webkit [19468] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Restoring some of the functionality I removed in r19445. It's insufficient for
each page to cancel keepAlive only for its child frames, because a frame
can be removed from the page before we get a chance to cancel its keepAlive.
So, the page destructor has to cancel keepAlive for all frames. This is safe
because we prohibit closing a WebView while JavaScript is executing.

  • page/Frame.cpp: (WebCore::keepAliveSet): (WebCore::Frame::keepAlive): (WebCore::Frame::cancelAllKeepAlive): (WebCore::Frame::lifeSupportTimerFired):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::~Page):
10:58 AM Changeset in webkit [19467] by ap
  • 5 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12603
A crash when trying to use XPath functions normalize-space(), string-length() and number()

Test: fast/xpath/implicit-node-args.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunNumber::doEvaluate): Implemented zero parameter case. (WebCore::XPath::FunctionMapping::): Corrected descriptions of these functions, as they do allow zero parameters. (WebCore::XPath::createFunction): Combined the two failure cases to ensure that this function never returns 0.
8:11 AM Changeset in webkit [19466] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by yngjun.

DESC: Highlighting lost when browser toolbar is dismissed TMCN-6XWLEC


Toolbar consumes the keyrelease event and the webcore gets stuck in a keypressed state.
fix: send keyrelease event to the webcore


​http://bugs.webkit.org/show_bug.cgi?id=12642

8:06 AM Changeset in webkit [19465] by zack
  • 2 edits in trunk/WebCore

Fix compilation of the Qt code.

8:04 AM Changeset in webkit [19464] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

rathnasa, reviewed by Zalan Bujtas.

DESC: [S60] EMGH-6XTG9Y: Browser: Bookmarks with an URL containing spaces do not work
​http://bugs.webkit.org/show_bug.cgi?id=12635

Note: See TracTimeline for information about the timeline view.