⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 9, 2007:

9:15 PM Changeset in webkit [22932] by sfalken
  • 7 edits in branches/WindowsMerge/WebKitWin

Land Maciej's patch so I can check in.
(Looks like he forgot, since he did move the bug to integrate)

5:57 PM Changeset in webkit [22931] by aliceli1
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): The scrollview's scrolloffset wasn't getting set in cases where there were no scrollbars You can have a scrolloffset even if you don't have scrollbars

WebKitWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor
fix depends on corresponding fix in WebCoreWin

  • WebView.cpp: (WebViewWndProc): call the editor to handle inserting text and scrolling/focus changes
5:39 PM Changeset in webkit [19550] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4985497> - Plugs a potential null DocumentLoader deref when
transitioning out of the Bookmarks View

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::recursiveGoToItem): add a null check
4:58 PM Changeset in webkit [19549] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Darin & Maciej.

Fixed: <rdar://problem/4930688> REGRESSION: missing images when reloading webarchives (11962)


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canUseArchivedResource): The bug here is that because a reload sets a cache policy of NSURLRequestReloadIgnoringCacheData (rightfully so), this method was refusing to load subresources in WebArchives. It's OK to use archive subresources for the NSURLRequestReloadIgnoringCacheData cache policy because we're not worried about the actual contents of a WebArchive changing on disk.
4:15 PM Changeset in webkit [19548] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Attempt to fix the build when using buildit.

3:53 PM Changeset in webkit [19547] by bdakin
  • 2 edits in trunk/WebCore

Rubber-stamped by John . . . and Adam.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Missing break.
3:27 PM Changeset in webkit [19546] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

  • editing/selection/4975120-expected.checksum: Added.
  • editing/selection/4975120-expected.png: Added.
  • editing/selection/4975120-expected.txt: Added.
  • editing/selection/4975120.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • page/mac/WebCoreFrameBridge.h: Removed two unused methods left over from the old form control implementation.

WebKit:

Reviewed by darin


<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • WebCoreSupport/WebFrameBridge.mm: Removed unused methods.
  • WebView/WebHTMLView.mm: Ditto. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Don't appear focused if a descendant view is firstResponder. (-[WebHTMLView _updateActiveState]): Removed the check for a BOOL that was always false.
  • WebView/WebHTMLViewInternal.h: Removed a BOOL that's always false.
2:51 PM Changeset in webkit [19545] by sullivan
  • 2 edits in trunk/WebCore
  • rendering/bidi.cpp: (WebCore::bidiNext): At Darin's suggestion, moved the "next = 0" line from my previous patch to the start of the loop body
2:37 PM Changeset in webkit [19544] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

yaharon, Reviewed by yongjun

DESC: [S60] BrowserNG: Passwords stored without notifying the user MLIO-6XXE6N
​http://bugs.webkit.org/show_bug.cgi?id=12712

2:35 PM Changeset in webkit [19543] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/selection/4960116-expected.checksum: Added.
  • editing/selection/4960116-expected.png: Added.
  • editing/selection/4960116-expected.txt: Added.
  • editing/selection/4960116.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/SelectionController.cpp: (WebCore::SelectionController::xPosForVerticalArrowNavigation): Null check. VisiblePosition creation can fail if a node that contains the selection was made invisible after the selection was made and before this function is called during a selection modification operation.
2:25 PM Changeset in webkit [19542] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line


  • editing/selection/4983858-expected.checksum: Added.
  • editing/selection/4983858-expected.png: Added.
  • editing/selection/4983858-expected.txt: Added.
  • editing/selection/4983858.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::exitNode): We recently split shouldEmitNewlineForNode into shouldEmitNewline{Before, After}Node, so this function now needs an implementation that is different from SimplifiedBackwardsTextIterator::handleNonTextNode. The difference is that we must call shouldEmit*BeforeNode instead of shouldEmit*AfterNode since we are a) exiting nodes and b) moving backward.
2:11 PM Changeset in webkit [19541] by justing
  • 13 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration


Added:

  • editing/execCommand/4916541-expected.checksum: Added.
  • editing/execCommand/4916541-expected.png: Added.
  • editing/execCommand/4916541-expected.txt: Added.
  • editing/execCommand/4916541.html: Added. Fixed:
  • editing/execCommand/4641880-2-expected.checksum:
  • editing/execCommand/4641880-2-expected.png:
  • editing/execCommand/4641880-2-expected.txt:
  • editing/execCommand/indent-selection-expected.checksum:
  • editing/execCommand/indent-selection-expected.png:
  • editing/execCommand/indent-selection-expected.txt: Added a FIXME:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-list-item.html:

WebCore:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration

  • editing/IndentOutdentCommand.cpp: (WebCore::indexForVisiblePosition): Added. (WebCore::IndentOutdentCommand::indentRegion): Use rangeLength and rangeFromLocationAndLength to restore the selection after the repeated moveParagraph calls necessary to perform indent are finished.
2:05 PM Changeset in webkit [19540] by brmorris
  • 5 edits in S60/branches/3.1m/WebKit

bujtas, Reviewed by Yongjun.

DESC: Can not open the Browser application. fix: delay formmanager construct ALES-6Y9GG7
​http://bugs.webkit.org/show_bug.cgi?id=12714

2:05 PM Changeset in webkit [19539] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker


  • fixed <rdar://problem/4960095> REPRODUCIBLE HANG: WebKit freezes when printing as PDF a certain kind of code (12449)


No test case because I don't know how to make the bug occur without printing.

  • rendering/bidi.cpp: (WebCore::bidiNext): reset loop's "next" variable after using it; we were setting "current" to the same value of "next" each subsequent time through the loop, which is not helpful.
1:50 PM Changeset in webkit [22930] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • WebCore.vcproj/WebCore.vcproj: Add new files, remove obsolete files.
1:49 PM Changeset in webkit [19538] by darin
  • 14 edits
    3 adds
    4 deletes in trunk/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add new files, remove obsolete files.
  • DerivedSources.make: Add TextEvent to the Objective-C and JavaScript bindings lists.
  • WebCore.exp: Export DOMTextEvent Objective-C wrapper.
  • bindings/js/kjs_events.cpp: (KJS::toJS): Added TextEvent to the list of Event subclasses so we make the right kind of JS wrapper.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): Same thing, for Objective-C.
  • bindings/objc/DOMInternal.h: Added DOMTextEventInternal.h.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): Added "TextEvents", "3.0" to the list of things we'll answer true for (as specified in the DOM Level 3 documentation). This isn't so great until we actually send textInput events, but that's coming soon.
  • dom/Document.cpp: (WebCore::Document::createEvent): Add "TextEvent" as a way to make a TextEvent (as specified in the DOM Level 3 documentation).
  • dom/Event.h:
  • dom/Event.cpp: (WebCore::Event::isTextEvent): Added virtual function to be used for runtime type checking of Event objects (as for other event types).
  • dom/TextEvent.cpp: Added.
  • dom/TextEvent.h: Added.
  • dom/TextEvent.idl: Added.
  • platform/mac/WebCoreWidgetHolder.h: Removed.
  • rendering/CounterListItem.h: Removed.
  • rendering/CounterResetNode.cpp: Removed.
  • rendering/CounterResetNode.h: Removed.
1:16 PM Changeset in webkit [22929] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Add the stream to the m_streams hash set.
12:33 PM Changeset in webkit [19537] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)


The bug was that the NNW policy delegate never calls back on the policy listener so we'll try to do a load
while there's a policy decision underway. The extra call to setPolicyDocumentLoader would cause a detached (and deallocated)
WebDataSource to be reattached and thus causing a crash.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove extra call to setPolicyDocumentLoader.
12:06 PM Changeset in webkit [19536] by bdakin
  • 8 edits in trunk

WebCore:

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Acrobat 8 was relying on a WebKit bug that was fixed about a year
ago with r12753. The bug was that we would not reload a page if the
source of an iframe was set to the same value it already was. Now
that we have fixed the bug, Acrobat constantly reloads their EULA,
making it blinky and impossible to read.

No layout test since the fix is to add an Acrobat-specific quirk.

  • WebCore.exp:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setLocation): If the new url is the same as the old one and we are honoring the Acrobat quirk, don't do anything.
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setNeedsAcrobatFrameReloadingQuirk):
  • page/Settings.h: (WebCore::Settings::needsAcrobatFrameReloadingQuirk):

WebKit:

Reviewed by Darin.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Allow quirk if the Application was linked before 3.0 and if the
application is Adobe Acrobat.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
12:00 PM Changeset in webkit [19535] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Dave Harrison

Disable the thread-check assertion in WebCore, as well as Webkit

  • WebCore.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [19534] by andersca
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

<rdar://problem/4930614>
Safari complains about "Slow Script" if GMail is left open and machine is busy


<rdar://problem/4649516>
Turn off slow script dialog or crank up time that makes it come up


<rdar://problem/4963589>
Slow script warning is displayed after closing of PROMPT or PRINT dialog


Re-do the way script timeouts are handled. No longer use a unix timer that sends signals. Instead, add a
tick count and increment it in loop bodies. If the tick count reaches a threshold, do a timeout check. If the total time executing
is higher than the timeout value, (possibly) interrupt the script. The timeout checker also adjusts the threshold dynamically
to prevent doing the timeout check too often.



  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add winmm.lib.
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::startTimeoutCheck): (KJS::Interpreter::stopTimeoutCheck): (KJS::Interpreter::resetTimeoutCheck): (KJS::getCurrentTime): (KJS::Interpreter::checkTimeout):
  • kjs/interpreter.h: (KJS::Interpreter::timedOut):
  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute):

WebCore:

Reviewed by Geoff.

No need to pause timeout checks anymore.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
11:07 AM Changeset in webkit [19533] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun.

DESC: Input element deactivation methods not working (TSW TMCN-6XYRVX)
​http://bugs.webkit.org/show_bug.cgi?id=12699

11:04 AM Changeset in webkit [19532] by brmorris
  • 3 edits in S60/trunk/WebCore

yaharon, reviewed by zalan

DESC: [S60] Browser crashes when selecting the left Soft key Options when the cursor is in textarea field (SCHY-6Y7SHD)
​http://bugs.webkit.org/show_bug.cgi?id=12706

10:48 AM Changeset in webkit [19531] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Brady.

  • WebKit.exp: Add WebBaseNetscapePluginView to the export list.
10:44 AM Changeset in webkit [19530] by thatcher
  • 1 edit in trunk/WebKitTools/DumpRenderTree/EventSendingController.m

Build fix. Use 0 or 0.0 instead of nil to prevent a compile warning.

8:50 AM Changeset in webkit [22928] by sullivan
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Beth

  • WebKitWin part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • Interfaces/IWebUIDelegate.idl: bumped enum value for new SPI tags to match change in WebCore/WebKit
8:48 AM Changeset in webkit [19529] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Beth


  • WebCore part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • platform/ContextMenuItem.h: (WebCore::): Tweaked comment; bumped enum value for new SPI tags to avoid conflict with pre-3.0 SPI tag values.

WebKit:

Reviewed by Beth

  • WebKit part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • WebKit.xcodeproj/project.pbxproj: Changed DYLIB_CURRENT_VERSION to 2 (was 1)
  • Misc/WebKitVersionChecks.h: Added constant WEBKIT_FIRST_VERSION_WITH_3_0_CONTEXT_MENU_TAGS, which is 2 but in the weird format that these version checks use.
  • WebView/WebUIDelegatePrivate.h: Tweaked comments; included the old values for three tags for context menu items that changed from SPI to API in 3.0; renamed WEBMENUITEMTAG_SPI_START to WEBMENUITEMTAG_WEBKIT_3_0_SPI_START for clarity, and bumped its value to avoid conflict with the three old values
  • WebCoreSupport/WebContextMenuClient.mm: (isAppleMail): new helper function that checks the bundle identifier (fixMenusToSendToOldClients): Removed return value for clarity; now checks linked-on version and also makes special case for Mail; now replaces three API tags with their old SPI values for clients that linked against old WebKit version, in addition to replacing new API with WebMenuItemTagOther for items that had no specific tag before. (fixMenusReceivedFromOldClients): Removed return value for clarity; removed defaultMenuItems parameter because it's no longer necessary; removed code that tried to recognize menus that got confused by the SPI -> API change (we now pass the old SPI values to these clients to avoid confusing them); now restores the tags for the items whose tags were replaced in fixMenusToSendToOldClients (this used to restore the tags of the default items rather than the new items, which was incorrect but happened to work since the clients we tested were using the objects from the default items array in their new items array) (WebContextMenuClient::getCustomMenuFromDefaultItems): Updated to account for the removed return values for the two fix-up methods; moved the autorelease of newItems here, which is clearer and was the source of a leak before.
5:55 AM Changeset in webkit [19528] by bdash
  • 6 edits
    18 adds in trunk

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors
Test results show red indicating property unsupported
Previous behaviour was to erroneously make everything green

  • css3/expected_failures/css3-modsel-33-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-33-expected.png: Added.
  • css3/expected_failures/css3-modsel-33-expected.txt: Added.
  • css3/expected_failures/css3-modsel-33.html: Added.
  • css3/expected_failures/css3-modsel-35-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-35-expected.png: Added.
  • css3/expected_failures/css3-modsel-35-expected.txt: Added.
  • css3/expected_failures/css3-modsel-35.html: Added.
  • css3/expected_failures/css3-modsel-36-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-36-expected.png: Added.
  • css3/expected_failures/css3-modsel-36-expected.txt: Added.
  • css3/expected_failures/css3-modsel-36.html: Added.
  • css3/expected_failures/css3-modsel-37-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-37-expected.png: Added.
  • css3/expected_failures/css3-modsel-37-expected.txt: Added.
  • css3/expected_failures/css3-modsel-37.html: Added.
5:24 AM Changeset in webkit [19527] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mark.

<rdar://problem/4980176>

  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): Since this frame is getting disconnected from its page, ensure it is not the focus node.
2:57 AM Changeset in webkit [19526] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

gdklauncher crashes when compiled with NDEBUG defined.

  • Projects/gdk/webcore-gdk.bkl:
2:44 AM Changeset in webkit [19525] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/4971224> REGRESSION: ASSERT in WebCore with Mail (12491)
​http://bugs.webkit.org/show_bug.cgi?id=12491

No test case. Not testable since there is no way to do substitute
data loads from layout tests.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Don't dispatch data load callback when loading empty data.
12:50 AM Changeset in webkit [19524] by bdash
  • 4 edits in trunk/WebCore

2007-02-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12705
REGRESSION: Crash with user stylesheet set

Allow the Frame::canLoad check to skipped so that user stylesheets can be loaded in remote documents.

  • ChangeLog:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Skip canLoad check if this is a user stylesheet. (WebCore::DocLoader::requestUserCSSStyleSheet): (WebCore::DocLoader::requestResource): Allow canLoad check to be skipped.
  • loader/DocLoader.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):

Feb 8, 2007:

10:49 PM Changeset in webkit [19523] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Linux/gdk build fixes.

  • Projects/gdk/webcore-gdk.bkl: Account for file renaming.
  • platform/gdk/KeyEventGdk.cpp: Make gdk's tab key recognized as tab so that keyboard link walking works on gdk. (WebCore::keyIdentifierForGdkKeyCode):
10:29 PM Changeset in webkit [19522] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

  • fast/frames/iframe-window-focus-expected.txt: Added.
  • fast/frames/iframe-window-focus.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

When a frame's window was focused, the page didn't get updated about the new frame getting focus.
This was causing handleKeyPress to fail because it kept getting a selection for the wrong frame (which wasn't editable).

Test: fast/frames/iframe-window-focus.html

  • page/Frame.cpp: (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow):
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow):
10:29 PM Changeset in webkit [22927] by adele
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

This also fixes a bug where when you called window.focus() on a background window, it did not come to the front.

  • bridge/win/FrameWin.h: Removed focusWindow() and unfocusWindow() stubs since there are now implementations in the base class.
  • platform/win/TemporaryLinkStubs.cpp:
9:44 PM Changeset in webkit [22926] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

  • WebView.cpp: (WebView::searchFor): Ever since 11396, the widget no longer handles frame focus changes. This is now the page's focus controller responsibility
9:43 PM Changeset in webkit [19521] by bdash
  • 2 edits in trunk/WebKitSite

2007-02-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

  • nav.inc: Add link to very work-in-progress DOM documentation.
9:28 PM Changeset in webkit [22925] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Initial checkin for resume support (compiles everywhere, needs ToT CFnetwork to actually work)

8:20 PM Changeset in webkit [19520] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

  • fast/forms/listbox-deselect-scroll-expected.checksum: Added.
  • fast/forms/listbox-deselect-scroll-expected.png: Added.
  • fast/forms/listbox-deselect-scroll-expected.txt: Added.
  • fast/forms/listbox-deselect-scroll.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

Test: fast/forms/listbox-deselect-scroll.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::activeSelectionStartListIndex): Added. Returns the index for the active selection. If there is no active selection, it returns the first selected index. (WebCore::HTMLSelectElement::activeSelectionEndListIndex): Added. If there is no active selection, it returns the last selected index.
  • html/HTMLSelectElement.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollToRevealSelection): Instead of using the first and last selected indices, use the active selection indices to determine which item to reveal. This way, when you're selecting with the keyboard, or the mouse, no unnecessary scrolling will occur if the end of your active selection is already visible.
7:45 PM Changeset in webkit [19519] by brmorris
  • 3 edits in S60/branches/3.1m/WebCore

yaharon, Reviewed by zalan

DESC: crash when selecting the left Soft key Options when the cursor is in textarea field SCHY-6Y7SHD
​http://bugs.webkit.org/show_bug.cgi?id=12706

6:24 PM Changeset in webkit [19518] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

  • fast/forms/select-block-background-expected.checksum: Added.
  • fast/forms/select-block-background-expected.png: Added.
  • fast/forms/select-block-background-expected.txt: Added.
  • fast/forms/select-block-background.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

Test: fast/forms/select-block-background.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Paint the item backgrounds during the PaintPhaseChildBlockBackground or PaintPhaseChildBlockBackgrounds phase.
6:21 PM Changeset in webkit [19517] by bdash
  • 7 edits
    4 adds in trunk

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.


Test: fast/forms/select-empty-option-height.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setText): If the option text is empty, use a RenderBR as inner text, to ensure that the inner div has line height.

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.


  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/select-baseline-expected.txt:
  • fast/forms/select-empty-option-height-expected.checksum: Added.
  • fast/forms/select-empty-option-height-expected.png: Added.
  • fast/forms/select-empty-option-height-expected.txt: Added.
  • fast/forms/select-empty-option-height.html: Added.
  • fast/replaced/three-selects-break-expected.txt:
5:48 PM Changeset in webkit [19516] by ggaren
  • 5 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Added a hard counter for SubresourceLoaders because the leaks tool now
ignores them.


  • loader/SubresourceLoader.cpp: (WebCore::): (WebCore::SubresourceLoaderCounter::~SubresourceLoaderCounter): (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader):
  • page/Frame.cpp: Removed unnecessary #define

WebKitTools:

Reviewed by Beth Dakin.


Ignore another false leak report.

  • Scripts/run-webkit-tests:
5:45 PM Changeset in webkit [22924] by andersca
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4955068>
PluginViewWin leaks memory.


Make streams ref-counted. Remove streams from the hash set once they're done loading.


Don't try to paint if painting is disabled.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::disconnectStream):
  • plugins/win/PluginViewWin.h:
5:44 PM Changeset in webkit [19515] by ggaren
  • 4 edits in trunk

LayoutTests:

Reviewed by Beth Dakin.


Updated results now that we actually return the correct ones.

  • fast/css/computed-style-expected.txt:

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4982374> CSSComputedStyleDeclaration::getPropertyCSSValue
leak reported by buildbot


The leak was a typo: "new" instead of "return new". I also generously
deployed RefPtr in places that were holding ref-counted objects in
bare pointers.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
4:49 PM Changeset in webkit [22923] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Fix scrollbar painting.

3:07 PM Changeset in webkit [19514] by kjk
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • GdkLauncher/main.cpp: Add -exit-after-loading and -dump-render-tree as debugging aid. (strEq): (main):
3:01 PM Changeset in webkit [19513] by ggaren
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

build fix, oops!

2:59 PM Changeset in webkit [19512] by kjk
  • 4 edits
    2 copies in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: Added. Based on qt version. (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::shouldShowDeleteInterface): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::toggleGrammarChecking): (WebCore::EditorClientGdk::handleKeyPress): (WebCore::EditorClientGdk::EditorClientGdk): (WebCore::EditorClientGdk::setPage):
  • platform/gdk/EditorClientGdk.h: Added. Ditto.
  • platform/gdk/FrameGdk.cpp: Add exitAfterLoading and dumpRenderTreeAfterLoading as small debugging features. Remove FrameGdkClient as no other platform has Frame*Client anymore. Adjust for new APIs. (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::onDidFinishLoad): (WebCore::FrameGdk::dumpRenderTree): (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::FrameGdk::focusWindow): (WebCore::FrameGdk::unfocusWindow): (WebCore::FrameGdk::getObjectInstanceForWidget): (WebCore::FrameGdk::getEmbedInstanceForWidget): (WebCore::FrameGdk::bindingRootObject): (WebCore::FrameGdk::print): (WebCore::FrameGdk::getAppletInstanceForWidget): (WebCore::FrameGdk::issueCutCommand): (WebCore::FrameGdk::issueCopyCommand): (WebCore::FrameGdk::issuePasteCommand): (WebCore::FrameGdk::issueTransposeCommand): (WebCore::FrameGdk::issuePasteAndMatchStyleCommand): (WebCore::FrameGdk::markedTextRange): (WebCore::FrameGdk::shouldChangeSelection): (WebCore::FrameGdk::respondToChangedSelection): (WebCore::FrameGdk::mimeTypeForFileName):
  • platform/gdk/FrameGdk.h: Ditto. (WebCore::FrameGdk::setExitAfterLoading): (WebCore::FrameGdk::exitAfterLoading): (WebCore::FrameGdk::setDumpRenderTreeAfterLoading): (WebCore::FrameGdk::dumpRenderTreeAfterLoading): (WebCore::GdkFrame):
  • platform/gdk/TemporaryLinkStubs.cpp: Adjust to new APIs. Small cleanups. (FrameView::updateBorder): (Widget::setEnabled): (Widget::isEnabled): (Widget::enableFlushDrawing): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::findWordBoundary): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (Path::apply): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (PageCache::close): (Editor::ignoreSpelling): (Editor::learnSpelling): (Editor::isSelectionUngrammatical): (Editor::isSelectionMisspelled): (Editor::guessesForMisspelledSelection): (Editor::guessesForUngrammaticalSelection): (Editor::markMisspellingsAfterTypingToPosition): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenu::setPlatformDescription): (ContextMenu::platformDescription): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::systemBeep): (WebCore::userIdleTime):
2:37 PM Changeset in webkit [22922] by andersca
  • 6 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4972772>
Implement IWebResource::Data.


<rdar://problem/4972777>
Implement IWebDataSource::subresourceForURL.


  • MemoryStream.cpp: (MemoryStream::MemoryStream): (MemoryStream::createInstance): (MemoryStream::Clone):
  • MemoryStream.h: Remove notion of buffer owner, it's not needed now that the buffer itself is reference counted.


  • WebDataSource.cpp: (WebDataSource::subresourceForURL): Implement this.


  • WebKit.vcproj/WebKit.vcproj: Add WebResource.cpp and WebResource.h


  • WebResource.cpp: Added. (WebResource::WebResource): (WebResource::~WebResource): (WebResource::createInstance): (WebResource::QueryInterface): (WebResource::AddRef): (WebResource::Release): (WebResource::initWithData): (WebResource::data): (WebResource::URL): (WebResource::MIMEType): (WebResource::textEncodingName): (WebResource::frameName):
  • WebResource.h: Added.


  • WebView.cpp: (WebView::formDelegate): Return E_FAIL if there's no form delegate.
2:37 PM Changeset in webkit [19511] by kjk
  • 8 edits
    1 delete in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • platform/GlyphPageTreeNode.h: Fix header guard name.
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor):
  • platform/gdk/MouseEventGdk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gdk/PageGdk.cpp: Removed. No longer used.
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::getThemeData): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::adjustTextFieldStyle): (WebCore::RenderThemeGdk::paintTextField): (WebCore::RenderThemeGdk::paintTextArea): (WebCore::RenderThemeGdk::systemFont):
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
2:33 PM Changeset in webkit [19510] by ggaren
  • 2 edits in trunk/WebKitTools

Minor fixup based on Maciej's review last night.


  • Scripts/run-webkit-tests: Use normal "increment at end of loop" behavior, and do a little math to make it work.
2:31 PM Changeset in webkit [22921] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:30 PM Changeset in webkit [19509] by sfalken
  • 1 copy in tags/Safari-521.34.2b

New tag.

2:15 PM Changeset in webkit [19508] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes for cairo.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::toCairoOperator): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::fillRoundedRect):
2:07 PM Changeset in webkit [19507] by kjk
  • 6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Linux/gdk build fixes.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • webcore-base.bkl:

WebKitTools:

Reviewed by Adam Roben..

Linux/gdk build fixes.

  • GdkLauncher/gdklauncher.bkl:
1:03 PM Changeset in webkit [22920] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Remove unused stub.


  • platform/win/TemporaryLinkStubs.cpp:
1:01 PM Changeset in webkit [19506] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher

Tweaked the thread violation behavior to be disabled by default, and to provide
an easy breakpoint to set.
The possibilities for the "WebCoreThreadCheck" user defaults key are -

  • The value "None" disables thread checking
  • The value "Log" causes an NSLog on a violation
  • The value "Exception" causes exceptions to be raised on a violation
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation): In the global namespace, making breakpoints cake!
12:56 PM Changeset in webkit [19505] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben, Darin Adler.


Updated results for tests that started failing after my run-webkit-tests
check-in.


These failures were not regressions. My check-in just caused the regular
bot to behave more like the leaks bot, so it started reporting the results
that the leaks bot had been reporting all along.

There does seem to be an underlying bug in the way XHTML documents report
line numbers for JavaScript exceptions. I've file that bug along with a
reduction:


​http://bugs.webkit.org/show_bug.cgi?id=12700
JavaScript errors in XML documents have incorrect line numbers


However, that bug is not a regression, so I think we should treat it separately.

  • dom/xhtml/level2/html/frame-expected.txt:
  • dom/xhtml/level2/html/iframe-expected.txt:
12:45 PM S60Webkit edited by franklin.davis@nokia.com
(diff)
12:42 PM S60Reindeer edited by franklin.davis@nokia.com
(diff)
12:38 PM S60Webkit edited by bradley.morrison@nokia.com
minor update to urls on s60webkit page (diff)
12:23 PM Changeset in webkit [19504] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by

  • Fix layout test failures.
  • Scripts/run-webkit-tests:
11:59 AM Changeset in webkit [22919] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Add shouldInterruptJavaScript to the API.


  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebChromeClient.cpp: (WebChromeClient::addMessageToConsole): (WebChromeClient::shouldInterruptJavaScript):
11:58 AM Changeset in webkit [19503] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4983515> Need mechanism to protect against WebKit calls from secondary threads
This initial landing is a conservative move until we can be certain of performance impact.
By writing to the user defaults key @"WebCoreThreadCheck" for the WebKit app you're running -

  • The value "None" disables thread checking
  • The value "Exception" causes exceptions to be raised on a violation
  • The default is to do the check, and NSLog each violation
  • bindings/objc/ExceptionHandlers.h: Add a "Is Main Thread" assert macro
  • bindings/scripts/CodeGeneratorObjC.pm: Use new mechanism in allocs and deallocs for now
  • platform/Logging.h: Added WebCoreThreadViolationCheck macro
  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Check for main-threadedness, and do some stuff
11:48 AM Changeset in webkit [22918] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

<rdar://problem/4888871>
Need to support synchronous XMLHttpRequest.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
11:19 AM Changeset in webkit [19502] by kmccullo
  • 2 edits in trunk/WebKit

Reviewed by

  • fixing a build breakage.
  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
10:52 AM Changeset in webkit [19501] by brmorris
  • 8 edits in S60/trunk

brmorris <​bradley.morrison@nokia.com>, rs'd by zalan

DESC: merge from s60/branches/3.1m to s60/trunk of r19464, r19466, r19472 & r19499

10:39 AM Changeset in webkit [19500] by kmccullo
  • 18 edits
    17 adds in trunk

LayoutTests:

Reviewed by Maciej, Darin and Mark.

rdar://problem/4922454

  • No longer allow remote sites to access local resources.
  • fast/loader/local-JavaScript-from-local-expected.txt: Added.
  • fast/loader/local-JavaScript-from-local.html: Added.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Added.
  • fast/loader/local-iFrame-source-from-local.html: Added.
  • fast/loader/local-image-from-local-expected.txt: Added.
  • fast/loader/local-image-from-local.html: Added.
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
  • http/tests/security/local-JavaScript-from-remote.html: Added.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Added.
  • http/tests/security/local-iFrame-from-remote.html: Added.
  • http/tests/security/local-image-from-remote-expected.txt: Added.
  • http/tests/security/local-image-from-remote.html: Added.
  • http/tests/security/resources/compass.jpg: Added.
  • http/tests/security/resources/localPage.html: Added.
  • http/tests/security/resources/localPage.html.orig: Added.
  • http/tests/security/resources/localScript.js: Added.

WebCore:

Reviewed by Maciej, Darin, and Mark.

rdar://problem/4922454

  • Prevents remote sites from executing local scripts.
  • bindings/objc/DOM.mm: - renamed a function that is now in the base class (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/XMLTokenizer.cpp: - removed needless asserts (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLImageLoader.cpp: - renamed a function that is now in the base class (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLTokenizer.cpp: - removed needless asserts (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: - renamed a function that is now in the base class (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: - return early if an error occured (WebCore::Cache::requestResource): (WebCore::Cache::remove):
  • loader/CachedImage.h: - renamed a function that is now in the base class (WebCore::CachedImage::canRender):
  • loader/CachedResource.h: - renamed a function that is now in the base class (WebCore::CachedResource::errorOccurred):
  • loader/CachedScript.h: - renamed a function that is now in the base class (WebCore::CachedScript::schedule):
  • loader/DocLoader.cpp: - The heart of the fix, prevents resources from being created or retrieved from the cache if a remote site is requesting the local resource. (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • page/EventHandler.cpp: - renamed a function that is now in the base class (WebCore::selectCursor):
  • rendering/HitTestResult.cpp: - renamed a function that is now in the base class (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: - renamed a function that is now in the base class (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: - renamed a function that is now in the base class (WebCore::RenderImage::errorOccurred):
  • rendering/RenderListItem.cpp: - renamed a function that is now in the base class (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: - renamed a function that is now in the base class (WebCore::RenderListMarker::isImage):
10:28 AM Changeset in webkit [19499] by brmorris
  • 4 edits in S60/branches/3.1m/WebKit

yaharon, reviewed by yongjun.

DESC: [S60] Daily BAT 3.2: S60NG_Login- Password field is not filled automatically KDEA-6XZEDY
​http://bugs.webkit.org/show_bug.cgi?id=12696

10:19 AM Changeset in webkit [19498] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

  • Scripts/check-for-global-initializers: For speed, only check files that have been modified since the last time we linked. For tidiness, capture stderr from nm, and prevent "nm: no name list" messages from going out.
12:43 AM Changeset in webkit [22917] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontCacheWin.cpp

Remove my garbled fixme that I didn't intend to leave in. :)

12:42 AM Changeset in webkit [19497] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej Stachowiak, Adam Roben.


Added 'nthly' support to run-webkit-tests. It's like 'singly', for an
arbitrary number n.


Plus some renames:

  • DumpRenderTree => "dumpTool" (to match abstraction elsewhere)
  • checkLeaks => "shouldCheckLeaks" (to match style guidelines)
  • tool => dumpTool (to match abstraction elsewhere)
  • httpdOpen => isHttpdOpen (to match style guidelines)


Plus a few logic fixups:

  • Don't check isDumpToolOpen when we know we've called openDumpTool().
  • Use a single code path to decide when to shut down dumpTool and when to check for leaks, since the operations are coincidental.
  • Use a single code path for running the leaks tool, since the only thing that varies between configurations is the output file name.
  • Increment $count after each test finishes, instead of at the end of the loop, to help with comparing to the length of the array and %-ing by n.
  • Use a more robust test inside the loop to determine if we need to close dumpTool, instead of copying the closing code outside the loop.


Layout tests pass.

  • Scripts/run-webkit-tests:
12:40 AM Changeset in webkit [22916] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore/platform/win

Make Lucida Grande bold work in the engine. Required sick special case hackery for now. Also fix the validity check for initial font construction. r=aroben

Note: See TracTimeline for information about the timeline view.