⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 10, 2007:

11:31 PM Changeset in webkit [22934] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Oliver.

10:01 PM Changeset in webkit [22933] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4989705> Loading eBay puts many items into back list

The bug was that WebFrame::createFrame was calling loadRequest on the
new child frame, which would initiate a load of FrameLoadTypeStandard,
when in fact we wanted to do a FrameLoadTypeInternal load. I ported
-[WebFrame _loadURL:referrer:intoChild:] to WebFrame, which contains
the logic we need.

  • WebFrame.cpp: (WebFrame::createFrame): Use a COMPtr to manage the new WebFrame, and call loadURLIntoChild instead of just calling loadRequest. (WebFrame::loadURLIntoChild): Ported from Mac WebFrame.
  • WebFrame.h: Added declaration.
6:59 PM Changeset in webkit [19562] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

  • Scripts/svn-create-patch: (findSourceFileAndRevision($)): Use File::Spec->abs2rel() instead of substr() to generate a relative path to the copied file.
6:32 PM Changeset in webkit [19561] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Sam Weinig.

  • Drosera/Drosera.icns: updated the icon with 512px and 256px variants
6:29 PM Changeset in webkit [19560] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy.

  • Scripts/svn-apply: Binary patches don't need a trailing newline after the base64 encoded text.
6:17 PM Changeset in webkit [19559] by ddkilzer
  • 5 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • bindings/jni/jni_utility.h: added new type for array, array_type
  • bindings/jni/jni_runtime.cpp: add support for new array type (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod): (JavaMethod::signature):
  • bindings/jni/jni_utility.cpp: add support for new array type (KJS::Bindings::callJNIMethod): (KJS::Bindings::callJNIStaticMethod): (KJS::Bindings::callJNIMethodIDA): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertArrayInstanceToJavaArray): new method converts the Javascript array to the requested Java array. (KJS::Bindings::convertValueToJValue):

WebCore:

Reviewed by Maciej.

Manual tests for ​http://bugs.webkit.org/show_bug.cgi?id=12636
Call different Java methods that take a variety of Array parameters
from Javascript, passing a Javascript array.

  • manual-tests/liveconnect-applet-array-parameters.html: Added.
  • manual-tests/resources/ArrayParameterTestApplet.class: Added.
  • manual-tests/resources/ArrayParameterTestApplet.java: Added.
6:06 PM Changeset in webkit [19558] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12724
Crash when enumerating XPath namespace axis

Test adapted from Python-based 4XPath test suite,
<​http://sourceforge.net/projects/foursuite/>

  • fast/xpath/namespace-nodes-expected.txt: Added.
  • fast/xpath/namespace-nodes.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12724
Crash when enumerating XPath namespace axis

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Namespace axis enumeration was broken in that it crashed, and also in that it returned attribute nodes instead of XPath namespace ones. Removed it altogether.
5:05 PM Changeset in webkit [19557] by ddkilzer
  • 2 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Adam.

  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::parseValues): Changed the string length math to avoid truncating the last character of each value.
  • manual-tests/svg-animation-parseValues.svg: Added.
5:01 PM Changeset in webkit [19556] by ddkilzer
  • 2 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Adam.

No automated test case because dumping the render tree updates layer positions anyway.

  • manual-tests/slider-thumb-tracking.html: Added.
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setCurrentPosition): Added call to updateLayerPosition() for the thumb's layer.
4:52 PM Changeset in webkit [19555] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Adam.

  • fast/events/frame-click-focus-expected.txt: Update results to include main frame blur.
  • fast/events/frame-click-focus.html: Update to click in main frame first.
6:00 AM Changeset in webkit [19554] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebInspector/webInspector/inspector.css: Added the search field to the undraggable dashboard-region.
2:38 AM Changeset in webkit [19553] by beidson
  • 6 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

Added a new category of http tests - "local" where the test is run as a local file but
the test involves remote resources from the httpd.
This test had to be done with cached subresources to tickle the code path that was failing before,
hence the bizarre different-sized images instead of simple success/failure text

  • http/tests/local/file-url-sent-as-referer-expected.txt: Added.
  • http/tests/local/file-url-sent-as-referer.html: Added - document.writes an img source that ends up testing the http-referer
  • http/tests/security/resources/green250x50.png: Added.
  • http/tests/security/resources/red200x100.png: Added.
  • http/tests/security/resources/showRefererImage.php: Added - By scanning the referrer, sends back either the success or failure image

WebCore:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): In SubresourceLoader::create(), we make a copy of the original request to use for the load. We then call FrameLoader::canLoad() which tells us if we should hide the referer. Before this fix if it said to hide the referrer, we would simply not apply a new referrer to our copy of the request. But if the original request already had a referrer, so did our copy. We simply have to clear the referrer from the copied request.

WebKitTools:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

  • Scripts/run-webkit-tests: Enhanced the http tests so that we can run layout tests on local files, but have an httpd for remote resources
2:35 AM Changeset in webkit [19552] by mjs
  • 3 edits
    1 add in trunk/LayoutTests
  • add missing result and update tests to work right from DumpRenderTree
  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt: Added.
  • fast/dom/Window/window-appendages-cleared.html:
1:12 AM Changeset in webkit [19551] by mjs
  • 4 edits
    2 adds in trunk

LayoutTests:

Regression not reviewed, based loosely on test case from Ian Eng.

  • test case for <rdar://problem/4988091> objects attached to Window not cleared (memory leak)


  • fast/dom/Window/resources/window-appendages-cleared-results.html: Added.
  • fast/dom/Window/window-appendages-cleared.html: Added.

WebCore:

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)


Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:

Feb 9, 2007:

9:15 PM Changeset in webkit [22932] by sfalken
  • 7 edits in branches/WindowsMerge/WebKitWin

Land Maciej's patch so I can check in.
(Looks like he forgot, since he did move the bug to integrate)

5:57 PM Changeset in webkit [22931] by aliceli1
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): The scrollview's scrolloffset wasn't getting set in cases where there were no scrollbars You can have a scrolloffset even if you don't have scrollbars

WebKitWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor
fix depends on corresponding fix in WebCoreWin

  • WebView.cpp: (WebViewWndProc): call the editor to handle inserting text and scrolling/focus changes
5:39 PM Changeset in webkit [19550] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4985497> - Plugs a potential null DocumentLoader deref when
transitioning out of the Bookmarks View

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::recursiveGoToItem): add a null check
4:58 PM Changeset in webkit [19549] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Darin & Maciej.

Fixed: <rdar://problem/4930688> REGRESSION: missing images when reloading webarchives (11962)


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canUseArchivedResource): The bug here is that because a reload sets a cache policy of NSURLRequestReloadIgnoringCacheData (rightfully so), this method was refusing to load subresources in WebArchives. It's OK to use archive subresources for the NSURLRequestReloadIgnoringCacheData cache policy because we're not worried about the actual contents of a WebArchive changing on disk.
4:15 PM Changeset in webkit [19548] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Attempt to fix the build when using buildit.

3:53 PM Changeset in webkit [19547] by bdakin
  • 2 edits in trunk/WebCore

Rubber-stamped by John . . . and Adam.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Missing break.
3:27 PM Changeset in webkit [19546] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

  • editing/selection/4975120-expected.checksum: Added.
  • editing/selection/4975120-expected.png: Added.
  • editing/selection/4975120-expected.txt: Added.
  • editing/selection/4975120.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • page/mac/WebCoreFrameBridge.h: Removed two unused methods left over from the old form control implementation.

WebKit:

Reviewed by darin


<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • WebCoreSupport/WebFrameBridge.mm: Removed unused methods.
  • WebView/WebHTMLView.mm: Ditto. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Don't appear focused if a descendant view is firstResponder. (-[WebHTMLView _updateActiveState]): Removed the check for a BOOL that was always false.
  • WebView/WebHTMLViewInternal.h: Removed a BOOL that's always false.
2:51 PM Changeset in webkit [19545] by sullivan
  • 2 edits in trunk/WebCore
  • rendering/bidi.cpp: (WebCore::bidiNext): At Darin's suggestion, moved the "next = 0" line from my previous patch to the start of the loop body
2:37 PM Changeset in webkit [19544] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

yaharon, Reviewed by yongjun

DESC: [S60] BrowserNG: Passwords stored without notifying the user MLIO-6XXE6N
​http://bugs.webkit.org/show_bug.cgi?id=12712

2:35 PM Changeset in webkit [19543] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/selection/4960116-expected.checksum: Added.
  • editing/selection/4960116-expected.png: Added.
  • editing/selection/4960116-expected.txt: Added.
  • editing/selection/4960116.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/SelectionController.cpp: (WebCore::SelectionController::xPosForVerticalArrowNavigation): Null check. VisiblePosition creation can fail if a node that contains the selection was made invisible after the selection was made and before this function is called during a selection modification operation.
2:25 PM Changeset in webkit [19542] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line


  • editing/selection/4983858-expected.checksum: Added.
  • editing/selection/4983858-expected.png: Added.
  • editing/selection/4983858-expected.txt: Added.
  • editing/selection/4983858.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::exitNode): We recently split shouldEmitNewlineForNode into shouldEmitNewline{Before, After}Node, so this function now needs an implementation that is different from SimplifiedBackwardsTextIterator::handleNonTextNode. The difference is that we must call shouldEmit*BeforeNode instead of shouldEmit*AfterNode since we are a) exiting nodes and b) moving backward.
2:11 PM Changeset in webkit [19541] by justing
  • 13 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration


Added:

  • editing/execCommand/4916541-expected.checksum: Added.
  • editing/execCommand/4916541-expected.png: Added.
  • editing/execCommand/4916541-expected.txt: Added.
  • editing/execCommand/4916541.html: Added. Fixed:
  • editing/execCommand/4641880-2-expected.checksum:
  • editing/execCommand/4641880-2-expected.png:
  • editing/execCommand/4641880-2-expected.txt:
  • editing/execCommand/indent-selection-expected.checksum:
  • editing/execCommand/indent-selection-expected.png:
  • editing/execCommand/indent-selection-expected.txt: Added a FIXME:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-list-item.html:

WebCore:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration

  • editing/IndentOutdentCommand.cpp: (WebCore::indexForVisiblePosition): Added. (WebCore::IndentOutdentCommand::indentRegion): Use rangeLength and rangeFromLocationAndLength to restore the selection after the repeated moveParagraph calls necessary to perform indent are finished.
2:05 PM Changeset in webkit [19540] by brmorris
  • 5 edits in S60/branches/3.1m/WebKit

bujtas, Reviewed by Yongjun.

DESC: Can not open the Browser application. fix: delay formmanager construct ALES-6Y9GG7
​http://bugs.webkit.org/show_bug.cgi?id=12714

2:05 PM Changeset in webkit [19539] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker


  • fixed <rdar://problem/4960095> REPRODUCIBLE HANG: WebKit freezes when printing as PDF a certain kind of code (12449)


No test case because I don't know how to make the bug occur without printing.

  • rendering/bidi.cpp: (WebCore::bidiNext): reset loop's "next" variable after using it; we were setting "current" to the same value of "next" each subsequent time through the loop, which is not helpful.
1:50 PM Changeset in webkit [22930] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • WebCore.vcproj/WebCore.vcproj: Add new files, remove obsolete files.
1:49 PM Changeset in webkit [19538] by darin
  • 14 edits
    3 adds
    4 deletes in trunk/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add new files, remove obsolete files.
  • DerivedSources.make: Add TextEvent to the Objective-C and JavaScript bindings lists.
  • WebCore.exp: Export DOMTextEvent Objective-C wrapper.
  • bindings/js/kjs_events.cpp: (KJS::toJS): Added TextEvent to the list of Event subclasses so we make the right kind of JS wrapper.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): Same thing, for Objective-C.
  • bindings/objc/DOMInternal.h: Added DOMTextEventInternal.h.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): Added "TextEvents", "3.0" to the list of things we'll answer true for (as specified in the DOM Level 3 documentation). This isn't so great until we actually send textInput events, but that's coming soon.
  • dom/Document.cpp: (WebCore::Document::createEvent): Add "TextEvent" as a way to make a TextEvent (as specified in the DOM Level 3 documentation).
  • dom/Event.h:
  • dom/Event.cpp: (WebCore::Event::isTextEvent): Added virtual function to be used for runtime type checking of Event objects (as for other event types).
  • dom/TextEvent.cpp: Added.
  • dom/TextEvent.h: Added.
  • dom/TextEvent.idl: Added.
  • platform/mac/WebCoreWidgetHolder.h: Removed.
  • rendering/CounterListItem.h: Removed.
  • rendering/CounterResetNode.cpp: Removed.
  • rendering/CounterResetNode.h: Removed.
1:16 PM Changeset in webkit [22929] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Add the stream to the m_streams hash set.
12:33 PM Changeset in webkit [19537] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)


The bug was that the NNW policy delegate never calls back on the policy listener so we'll try to do a load
while there's a policy decision underway. The extra call to setPolicyDocumentLoader would cause a detached (and deallocated)
WebDataSource to be reattached and thus causing a crash.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove extra call to setPolicyDocumentLoader.
12:06 PM Changeset in webkit [19536] by bdakin
  • 8 edits in trunk

WebCore:

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Acrobat 8 was relying on a WebKit bug that was fixed about a year
ago with r12753. The bug was that we would not reload a page if the
source of an iframe was set to the same value it already was. Now
that we have fixed the bug, Acrobat constantly reloads their EULA,
making it blinky and impossible to read.

No layout test since the fix is to add an Acrobat-specific quirk.

  • WebCore.exp:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setLocation): If the new url is the same as the old one and we are honoring the Acrobat quirk, don't do anything.
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setNeedsAcrobatFrameReloadingQuirk):
  • page/Settings.h: (WebCore::Settings::needsAcrobatFrameReloadingQuirk):

WebKit:

Reviewed by Darin.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Allow quirk if the Application was linked before 3.0 and if the
application is Adobe Acrobat.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
12:00 PM Changeset in webkit [19535] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Dave Harrison

Disable the thread-check assertion in WebCore, as well as Webkit

  • WebCore.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [19534] by andersca
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

<rdar://problem/4930614>
Safari complains about "Slow Script" if GMail is left open and machine is busy


<rdar://problem/4649516>
Turn off slow script dialog or crank up time that makes it come up


<rdar://problem/4963589>
Slow script warning is displayed after closing of PROMPT or PRINT dialog


Re-do the way script timeouts are handled. No longer use a unix timer that sends signals. Instead, add a
tick count and increment it in loop bodies. If the tick count reaches a threshold, do a timeout check. If the total time executing
is higher than the timeout value, (possibly) interrupt the script. The timeout checker also adjusts the threshold dynamically
to prevent doing the timeout check too often.



  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add winmm.lib.
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::startTimeoutCheck): (KJS::Interpreter::stopTimeoutCheck): (KJS::Interpreter::resetTimeoutCheck): (KJS::getCurrentTime): (KJS::Interpreter::checkTimeout):
  • kjs/interpreter.h: (KJS::Interpreter::timedOut):
  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute):

WebCore:

Reviewed by Geoff.

No need to pause timeout checks anymore.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
11:07 AM Changeset in webkit [19533] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun.

DESC: Input element deactivation methods not working (TSW TMCN-6XYRVX)
​http://bugs.webkit.org/show_bug.cgi?id=12699

11:04 AM Changeset in webkit [19532] by brmorris
  • 3 edits in S60/trunk/WebCore

yaharon, reviewed by zalan

DESC: [S60] Browser crashes when selecting the left Soft key Options when the cursor is in textarea field (SCHY-6Y7SHD)
​http://bugs.webkit.org/show_bug.cgi?id=12706

10:48 AM Changeset in webkit [19531] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Brady.

  • WebKit.exp: Add WebBaseNetscapePluginView to the export list.
10:44 AM Changeset in webkit [19530] by thatcher
  • 1 edit in trunk/WebKitTools/DumpRenderTree/EventSendingController.m

Build fix. Use 0 or 0.0 instead of nil to prevent a compile warning.

8:50 AM Changeset in webkit [22928] by sullivan
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Beth

  • WebKitWin part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • Interfaces/IWebUIDelegate.idl: bumped enum value for new SPI tags to match change in WebCore/WebKit
8:48 AM Changeset in webkit [19529] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Beth


  • WebCore part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • platform/ContextMenuItem.h: (WebCore::): Tweaked comment; bumped enum value for new SPI tags to avoid conflict with pre-3.0 SPI tag values.

WebKit:

Reviewed by Beth

  • WebKit part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • WebKit.xcodeproj/project.pbxproj: Changed DYLIB_CURRENT_VERSION to 2 (was 1)
  • Misc/WebKitVersionChecks.h: Added constant WEBKIT_FIRST_VERSION_WITH_3_0_CONTEXT_MENU_TAGS, which is 2 but in the weird format that these version checks use.
  • WebView/WebUIDelegatePrivate.h: Tweaked comments; included the old values for three tags for context menu items that changed from SPI to API in 3.0; renamed WEBMENUITEMTAG_SPI_START to WEBMENUITEMTAG_WEBKIT_3_0_SPI_START for clarity, and bumped its value to avoid conflict with the three old values
  • WebCoreSupport/WebContextMenuClient.mm: (isAppleMail): new helper function that checks the bundle identifier (fixMenusToSendToOldClients): Removed return value for clarity; now checks linked-on version and also makes special case for Mail; now replaces three API tags with their old SPI values for clients that linked against old WebKit version, in addition to replacing new API with WebMenuItemTagOther for items that had no specific tag before. (fixMenusReceivedFromOldClients): Removed return value for clarity; removed defaultMenuItems parameter because it's no longer necessary; removed code that tried to recognize menus that got confused by the SPI -> API change (we now pass the old SPI values to these clients to avoid confusing them); now restores the tags for the items whose tags were replaced in fixMenusToSendToOldClients (this used to restore the tags of the default items rather than the new items, which was incorrect but happened to work since the clients we tested were using the objects from the default items array in their new items array) (WebContextMenuClient::getCustomMenuFromDefaultItems): Updated to account for the removed return values for the two fix-up methods; moved the autorelease of newItems here, which is clearer and was the source of a leak before.
5:55 AM Changeset in webkit [19528] by bdash
  • 6 edits
    18 adds in trunk

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors
Test results show red indicating property unsupported
Previous behaviour was to erroneously make everything green

  • css3/expected_failures/css3-modsel-33-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-33-expected.png: Added.
  • css3/expected_failures/css3-modsel-33-expected.txt: Added.
  • css3/expected_failures/css3-modsel-33.html: Added.
  • css3/expected_failures/css3-modsel-35-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-35-expected.png: Added.
  • css3/expected_failures/css3-modsel-35-expected.txt: Added.
  • css3/expected_failures/css3-modsel-35.html: Added.
  • css3/expected_failures/css3-modsel-36-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-36-expected.png: Added.
  • css3/expected_failures/css3-modsel-36-expected.txt: Added.
  • css3/expected_failures/css3-modsel-36.html: Added.
  • css3/expected_failures/css3-modsel-37-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-37-expected.png: Added.
  • css3/expected_failures/css3-modsel-37-expected.txt: Added.
  • css3/expected_failures/css3-modsel-37.html: Added.
5:24 AM Changeset in webkit [19527] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mark.

<rdar://problem/4980176>

  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): Since this frame is getting disconnected from its page, ensure it is not the focus node.
2:57 AM Changeset in webkit [19526] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

gdklauncher crashes when compiled with NDEBUG defined.

  • Projects/gdk/webcore-gdk.bkl:
2:44 AM Changeset in webkit [19525] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/4971224> REGRESSION: ASSERT in WebCore with Mail (12491)
​http://bugs.webkit.org/show_bug.cgi?id=12491

No test case. Not testable since there is no way to do substitute
data loads from layout tests.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Don't dispatch data load callback when loading empty data.
12:50 AM Changeset in webkit [19524] by bdash
  • 4 edits in trunk/WebCore

2007-02-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12705
REGRESSION: Crash with user stylesheet set

Allow the Frame::canLoad check to skipped so that user stylesheets can be loaded in remote documents.

  • ChangeLog:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Skip canLoad check if this is a user stylesheet. (WebCore::DocLoader::requestUserCSSStyleSheet): (WebCore::DocLoader::requestResource): Allow canLoad check to be skipped.
  • loader/DocLoader.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
Note: See TracTimeline for information about the timeline view.