⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 18, 2007:

11:58 PM Changeset in webkit [22965] by mjs
  • 20 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • bridge/win/FrameWin.cpp: (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::computePageRects): (WebCore::drawRectIntoContext): (WebCore::imageFromSelection): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • bridge/win/FrameWin.h:
  • page/win/EventHandlerWin.cpp:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::addToDirtyRegion): (WebCore::ScrollView::scrollBackingStore): (WebCore::ScrollView::updateBackingStore):
  • platform/win/TemporaryLinkStubs.cpp: (Frame::print): (Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection):
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView):
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::createNullPluginView): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:

WebKitWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • WebChromeClient.cpp: (WebChromeClient::tabsToLinks): (WebChromeClient::windowResizerRect): (WebChromeClient::addToDirtyRegion): (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebChromeClient.h:
  • WebEditorClient.cpp: (WebEditorClient::shouldChangeSelectedRange): (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):
  • WebFrame.cpp: (kit): (WebFrame::initWithWebFrameView): (WebFrame::searchForLabelsBeforeElement): (WebFrame::matchLabelsAgainstElement): (WebFrame::createPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): (WebFrame::spoolPages):
  • WebFrame.h:
  • WebView.cpp: (WebView::handleEditingKeyboardEvent): (WebView::keyDown): (WebView::generateSelectionImage):
  • WebView.h:
11:58 PM Changeset in webkit [19704] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Oliver

<rdar://problem/4985321> - Can't edit templates for Web Gallery/Web Page Export in Aperture

  • Misc/WebKitVersionChecks.h: Add a #define for this APERTURE quirk
  • WebView/WebView.mm: (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): If the current app is Aperture and it was linked against Tiger WebKit, always allow selection change
11:57 PM Changeset in webkit [19703] by lars
  • 2 edits in trunk/WebCore

fix compilation.

11:54 PM Changeset in webkit [19702] by mjs
  • 91 edits
    4 adds
    2 deletes in trunk

WebCore:

Reviewed by Maciej.


Additional coding by Maciej, additional review by Oliver.

Get rid of the FrameMac and FrameQt classes. Instead
move all methods into Frame directly, and implement
some platform specific methods in foo/FrameFoo.cpp.

Some general cleanup in Frame:

  • Move some methods out of Frame, to the place where they belong.
  • Unify the different ways of creating the JavaScript wrappers for <object>, <embed> and <applet>
  • Some cleanup of the WebCoreFrameBridge
  • ForwardingHeaders/bindings/NP_jsobject.h: Added.
  • ForwardingHeaders/bindings/npruntime_impl.h: Added.
  • ForwardingHeaders/bindings/runtime_root.h: Added.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):
  • bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/EditorClient.h:
  • bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateBorder): (WebCore::FrameView::updateDashboardRegions):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • dom/Position.cpp: (WebCore::Position::next):
  • editing/CommandByName.cpp: (WebCore::Frame::execCopy): (WebCore::Frame::execCut): (WebCore::Frame::execPaste):
  • editing/Editor.cpp: (WebCore::Editor::canEdit): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::paste): (WebCore::Editor::pasteAsPlainText):
  • editing/Editor.h:
  • editing/JSEditor.cpp:
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::getInstance):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::detachFromParent):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/qt/DocumentLoaderQt.cpp:
  • page/Chrome.cpp: (WebCore::Chrome::shouldInterruptJavaScript):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::markedTextRange): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::shouldDeleteSelection): (WebCore::Frame::isContentEditable): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject): (WebCore::Frame::windowScriptNPObject): (WebCore::Frame::cleanupScriptObjects): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): (WebCore::EventHandler::keyboardUIMode):
  • page/mac/FrameMac.h: Removed.
  • page/mac/FrameMac.mm: (WebCore::Frame::setBridge): (WebCore::Frame::bridge): (WebCore::Frame::searchForLabelsAboveCell): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::fontAttributesForSelectionStart): (WebCore::Frame::baseWritingDirectionForSelectionStart): (WebCore::Frame::print): (WebCore::Frame::issuePasteCommand): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::textFieldDidBeginEditing): (WebCore::Frame::textFieldDidEndEditing): (WebCore::Frame::textDidChangeInTextField): (WebCore::Frame::textDidChangeInTextArea): (WebCore::Frame::doTextFieldCommandFromEvent): (WebCore::Frame::textWillBeDeletedInTextField): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::setMarkedTextRange): (WebCore::Frame::dashboardRegionsDictionary): (WebCore::Frame::dashboardRegionsChanged): (WebCore::Frame::willPopupMenu): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::customHighlightLineRect): (WebCore::Frame::paintCustomHighlight): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::windowScriptObject): (WebCore::Frame::cleanupPlatformScriptObjects):
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (createRootObject): (bridge): (-[WebCoreFrameBridge _frame]):
  • page/qt/EventHandlerQt.cpp:
  • page/qt/FrameQt.cpp: (WebCore::Frame::unfocusWindow): (WebCore::Frame::focusWindow): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::print): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • page/qt/FrameQt.h: Removed.
  • platform/MimeTypeRegistry.h:
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript): (WebCore::SVGEmptyEditorClient::shouldChangeSelectedRange):
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac):
  • platform/mac/FileChooserMac.mm: (-[OpenPanelController beginSheetWithFrame:]):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): (WebCore::Widget::setIsSelected):
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/ResourceHandleManagerQt.cpp:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start):
  • platform/qt/MimeTypeRegistryQt.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ScrollViewCanvasQt.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Added implementations for the new callbacks in EditorClient
and ChromeClient (basically moved from WebFrameBridge).
Cleaned up some code paths that are not called anymore
and done fully inside WebCore now.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebNSAttributedStringExtras.mm:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView getVariable:value:]):
  • Plugins/WebNetscapePluginEmbeddedView.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.mm:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldChangeSelectedRange):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): (-[WebFrameBridge fini]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchiver.mm:
  • WebView/WebFrame.mm: (core): (kit): (-[WebFrame _updateBackground]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm:
  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _isEditable]): (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView maintainsInactiveSelection]): (-[WebHTMLView scrollWheel:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView selectedAttributedString]):
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView shouldClose]): (-[WebView setEditable:]):

WebKitQt:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Add stubs for the new methods in ChormeClient and EditorClient,
remove all references to FrameQt.

  • Api/qwebframe.cpp: (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::shouldInterruptJavaScript):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldChangeSelectedRange): (WebCore::EditorClientQt::isEditable):
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): (WebCore::FrameLoaderClientQt::webFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:
11:18 PM Changeset in webkit [19701] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Oops, missed a 'const'

  • platform/qt/ClipboardQt.h:
11:04 PM Changeset in webkit [19700] by oliver
  • 3 edits
    2 adds in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Adding stubbed out implementation of Clipboard for Qt to stop
it crashing whenever someone drags the mouse.

  • WebCore.pro:
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/qt/ClipboardQt.cpp: Added. (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::types): (WebCore::ClipboardQt::dragLocation): (WebCore::ClipboardQt::dragImage): (WebCore::ClipboardQt::setDragImage): (WebCore::ClipboardQt::dragImageElement): (WebCore::ClipboardQt::setDragImageElement): (WebCore::ClipboardQt::createDragImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h: Added. (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::isForDragging):
11:00 PM Changeset in webkit [22964] by adachan
  • 9 edits
    4 adds in branches/WindowsMerge

2007-02-18 Ada Chan <​adachan@apple.com>

WebCoreWin:

Reviewed by Adam.

Move app text controls to use WebView.

  • added a method to let us render text using WebKit.
  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/WebCoreTextRenderer.cpp: Added. (WebCore::WebCoreDrawTextAtPoint):
  • platform/win/WebCoreTextRenderer.h: Added.

WebKitWin:

Reviewed by Adam.


Move app text controls to use webview

10:14 PM WebKit Team edited by oliver@apple.com
I appear to be the DnD guy now (diff)
10:07 PM Changeset in webkit [19699] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Don't even attempt to do a document based drag if there isn't a document
Fixes rdar://problem/4960109

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):

Null check m_document

(WebCore::DragController::tryDHTMLDrag):

ASSERT(m_document) -- tryDocumentDrag is the only
thing that will ever call us, but lets play it safe


4:42 PM Changeset in webkit [22963] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Rubberstamped by Hyatt.

Fix <rdar://problem/5006918> All selected text is black, even if it is
some other color when not selected

4:28 PM Changeset in webkit [22962] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix <rdar://problem/5006872> <select> popups need Aqua scroll bars

PopupMenuWin now uses a PlatformScrollbar.

4:26 PM Changeset in webkit [19698] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

A little preparation for <rdar://problem/5006872>.

  • platform/PopupMenu.h:
1:07 PM Changeset in webkit [19697] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12807
XPath incorrectly converts NaN to boolean

Test: fast/xpath/nan-to-boolean.html

  • xml/XPathValue.cpp: (WebCore::XPath::Value::toBoolean): Convert NaN to false.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstringAfter::doEvaluate): Fix substring-after to actually work.
8:15 AM Changeset in webkit [19696] by ap
  • 128 edits
    12 adds in trunk

2007-02-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Tests: fast/repaint/float-overflow.html

fast/repaint/float-overflow-right.html
fast/repaint/table-cell-vertical-overflow.html

Reflected in existing test results.

Unified floats and overflow for the purposes of painting and hit-testing.
Overhanging and overflowing floats are now factored into a block's overflow
unless their painting has been propagated to an ancestor.

Changed table cells to no longer expand to enclose overflow, thus making
it purely "visual overflow", having no effect on layout in WebCore. It
still determines scrolling dimensions.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks' horizontal overflow in the inline box's dimensions.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows behavior. Added code to add this block's floats (and their overflow) to its overflow rect if it is not in a block formatting context. Otherwise, the inclusion of floats in the overflow is deferred until this block's parent examines its floats and possibly adopts overhanging floats. (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::floatRect): Made non-virtual and changed to return an empty rect if there are no floats or the floats are clipped, instead of returning the border box. (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that are not to be painted by the parent are added to the child's overflow rect. (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow bounds to include the given rect. (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal child, add its floats to its overflow, since painting of floats does not propagate to flexible boxes. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.h: Removed the override of overflowHeight() since now tables can have vertical overflow.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): Made sure that overflow is repainted.
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats): Removed.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Factor in vertical overflow from cells. (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowHeight): (WebCore::RenderTableSection::overflowTop):
6:23 AM Changeset in webkit [19695] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix for the build fix -- can't call something that isn't a function

  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:48 AM Changeset in webkit [19694] by oliver
  • 3 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Adding platform/DragImage.cpp and platform/qt/DragImageQt.cpp to the Qt
project files

Stubbed method for WebCore::notAllowedCursor -- not sure what it should return,
have returned blank cursor, possibly needs to return something else

  • WebCore.pro:
  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:07 AM Changeset in webkit [19693] by oliver
  • 3 edits in trunk/WebKitQt

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix -- adding DragClientQt method stubs

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::willPerformDragSourceAction): (WebCore::DragClientQt::startDrag): (WebCore::DragClientQt::createDragImageForLink):
  • WebCoreSupport/DragClientQt.h:
4:59 AM Changeset in webkit [19692] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Sigh, obnoxious occasional auto conversion from float to int

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::createDragImage):


4:48 AM Changeset in webkit [19691] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12799
REGRESSION: Webpage doesn't load correctly (www.cincinnati.com
redirects to the wrong URL)

Test: http/tests/misc/refresh-meta-with-newline.html

  • platform/network/HTTPParsers.cpp: (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
  • platform/network/HTTPParsers.h: In HTML, all characters with codes <= 0x20 are whitespace, while in HTTP, only space and tab are such.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Pass parseHTTPRefresh() a flag telling about the source of data.
4:44 AM Changeset in webkit [19690] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Buld fix -- surprisingly RetainPtr doesn't exist on Qt

  • platform/DragImage.h:


4:35 AM Changeset in webkit [22961] by oliver
  • 10 edits
    1 add in branches/WindowsMerge

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

Updated to include stubs for drag and drop methods
Added DragImage[Win].cpp to project file
Now uses platform independent EventHandler::handleDrag

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::Frame::dragImageForSelection): Just wrap the platform specific selectionImage method
  • page/win/DragControllerWin.cpp: Defining constants for drag images -- basically copied the Mac definitions
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Basic implementation -- needs to create an IDataObject to be useful but ClipboardWin is basically unimplemented anyway so not yet a problem
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Stubs
  • platform/win/ClipboardWin.h: Updated interface
  • platform/win/DragImageWin.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Stubs to keep the build going

  • WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink):
  • WebDragClient.h:
4:30 AM Changeset in webkit [19689] by oliver
  • 28 edits
    4 adds in trunk

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

More drag and drop migration, now the entirety of the
drag initiation logic has been rendered platform independent
This has required a number of new interfaces, and a reasonable
amount of logic migration.

As a side effect, this patch also fixes rdar://problem/4945341

There are some basic Qt stubs that should stop the build from failing,
however the absence of ClipboardQt means any attempt to initiate a drag
may cause a crash.

  • WebCore.exp:

Exporting new symbols

  • WebCore.xcodeproj/project.pbxproj:

New files

  • dom/Clipboard.cpp: (WebCore::Clipboard::canSaveAsWebArchive): Migrated from WebKit
  • dom/Clipboard.h: Added more methods to allow Clipboard to be used as a platform independent container for drag and drop
  • page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage): This is a mac only helper function, so i've made it have an empty implementation, that way we won't need a PLATFORM(MAC) block in SVGImageEmptyClients
  • page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::tryDHTMLDrag): Using RefPtrs now (WebCore::getCachedImage): (WebCore::getImage): Helper functions (WebCore::dragLocForDHTMLDrag): (WebCore::dragLocForSelectionDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): Logic that generates drag images and clipboard content, and initiates the actual system drag operation
  • page/DragController.h: Method and variable declarations
  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): handleDrag is now platform independent (WebCore::EventHandler::handleTextInputEvent):

formatting

  • page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseDragged): Forgot to define this stub function
  • page/Frame.h: Declaring dragImageForSelection to provide drag image for selected content
  • page/mac/DragControllerMac.mm: Defining drag images control vars
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard): Migrated old clipboard creation to here
  • page/mac/FrameMac.mm: (WebCore::Frame::dragImageForSelection): Wrap FrameMac::selectionImage
  • page/qt/DragControllerQt.cpp: Defining drag images control vars
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard): stub
  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection): stub
  • platform/DragImage.cpp: Added. (WebCore::fitDragImageToMaxSize): (WebCore::createDragImageForSelection):

Platform independent processing for drag images

  • platform/DragImage.h: Added.

Declaring typedefs and wrapper functions to abstract the handling
of drag images

  • platform/Pasteboard.h: Declaring extracted writeURL and writeSelection methods
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::willPerformDragSourceAction): (WebCore::SVGEmptyDragClient::startDrag): (WebCore::SVGEmptyDragClient::createDragImageForLink): Stubs FTW!
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::pasteboard): Provide accessor for underlying NSPasteboard
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::hasData): (WebCore::ClipboardMac::writeRange): (WebCore::ClipboardMac::writeURL): (WebCore::ClipboardMac::declareAndWriteDragImage): (WebCore::ClipboardMac::createDragImage):

Implemented new Clipboarid functionality.

(WebCore::ClipboardMac::dragNSImage):

Made this a const method

  • platform/mac/DragImageMac.mm: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):

Implemented platform specific DragImage functions

  • platform/mac/PasteboardMac.mm: (WebCore::writeSelection): (WebCore::Pasteboard::writeSelection): (WebCore::writeURL): (WebCore::Pasteboard::writeURL):

Extracted member implementations of these functions, so that
Clipboard could also make use of this functionality.
Pasteboard methods now call the new non-member implementations.
Also fixed implementations to respect the list of requested types.

  • platform/qt/DragImageQt.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Moving the drag initiation logic to WebCore.
The redundant code in webkit will be moved out in a later patch.

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (getTopHTMLView): Helper function (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink): Implemented new DragClient methods (WebDragClient::declareAndWriteDragImage): Helper function for the Mac to allow new drag and drop code to match behaviour


  • WebView/WebHTMLView.mm: (-[WebHTMLView _dragImageForURL:withLabel:]): (-[WebHTMLView _dragImageForLinkElement:]): Refactoring old _dragImageForLinkElement function so that the link drag image can be created with just a URL and label, rather than requiring the original element (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Removed logic that is no longer necessary (-[WebHTMLView _mouseDownEvent]): The WebDragClient may need the original mouseDownEvent of a drag when initiating a drag
  • WebView/WebHTMLViewInternal.h: Declaring _mouseDownEvent
  • WebView/WebHTMLViewPrivate.h: Declaring _dragImageForURL



12:48 AM Changeset in webkit [19688] by ap
  • 4 edits in trunk/JavaScriptCore

2007-02-18 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Roben.

Fix cases where MSVC-specific code was identified as Win32 platform
code. (as it should be compiled for e.g. wx port when using MSVC too)


  • wtf/Assertions.h:
  • wtf/MathExtras.h:
  • wtf/StringExtras.h: changed PLATFORM(WIN) sections to COMPILER(MSVC) as necessary

Feb 17, 2007:

10:28 PM Changeset in webkit [22960] by aroben
  • 2 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Removed bogus single-file configuration for MimeTypeRegistryWin.cpp.
10:04 PM Changeset in webkit [22959] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-02-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

  • Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
  • WebView.cpp: (WebView::scrollOffset): Add null check (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here) (WebView::visibleContentRect): Added so we can size find overlay appropriately (not including scroll bars)
  • WebView.h: Added scrollBy, visibleContentRect
5:59 PM Changeset in webkit [22958] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Part of the OpenSource fix to make sure the fill color starts off as transparent. Make sure our CG context
has its state properly in sync with the CGContext.

Reviewed by aroben

  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
5:58 PM Changeset in webkit [19687] by hyatt
  • 2 edits in trunk/WebCore

Fix textarea resizers to not fill with black by making sure the fill color starts off as
transparent instead of black.

Reviewed by aroben

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
5:52 PM Changeset in webkit [22957] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Build fix.

  • platform/win/CursorWin.cpp: (WebCore::notAllowedCursor):
2:23 PM Changeset in webkit [19686] by aroben
  • 2 edits in trunk

Added missing Radar references to ChangeLogs.

2:21 PM Changeset in webkit [19685] by aroben
  • 3 edits
    4 adds in trunk

2007-02-17 Lars Knoll <​lars@trolltech.com>

LayoutTests:

Reviewed by Adam.

test for ​http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

  • fast/images/image-in-map-expected.checksum: Added.
  • fast/images/image-in-map-expected.png: Added.
  • fast/images/image-in-map-expected.txt: Added.
  • fast/images/image-in-map.html: Added.

WebCore:

Reviewed by Adam.

fix ​http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

Test: fast/images/image-in-map.html

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD):
2:09 PM Changeset in webkit [19684] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • fast/xpath/namespace-vs-predicate-expected.txt: Added.
  • fast/xpath/namespace-vs-predicate.xhtml: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • xml/XPathGrammar.y: NAMETEST is different from other NodeTests in that its resulting type is an expanded name, rather than a string. It is not really possible to store the namespace inside Parser, because it gets used in wrong steps then.
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::expandQName):
  • xml/XPathParser.h: Moved code that expands a QName from XPathGrammar.y. Removed m_currentNamespaceURI.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::Step):
  • xml/XPathStep.h: Added a constructor that takes a namespace.
11:03 AM Changeset in webkit [19683] by adele
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/loader/resources/simultaneous-reloads-assert-frame.html: Added.
  • fast/loader/simultaneous-reloads-assert-expected.txt: Added.
  • fast/loader/simultaneous-reloads-assert.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/loader/simultaneous-reloads-assert.html

  • loader/Cache.cpp: (WebCore::Cache::remove): Replaced the assertion with a check whether the resource is in the cache. The resource could have been removed from the cache as a result of a reload occurring simultaneously in a different document.
10:58 AM Changeset in webkit [19682] by adele
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12711
Prettier and more distinct cursors

  • Resources/crossHairCursor.png: Added.
  • Resources/northEastSouthWestResizeCursor.png:
  • Resources/northWestSouthEastResizeCursor.png:
  • Resources/notAllowedCursor.png: Added.
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::crossCursor): (WebCore::notAllowedCursor):
10:35 AM Changeset in webkit [19681] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/shadow-boundary-crossing-expected.txt: Added.
  • fast/events/shadow-boundary-crossing.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/shadow-boundary-crossing.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Changed to use the new eventParentNode() function for constructing the chain of ancestors for capture and bubbling.
  • dom/Node.h: (WebCore::Node::eventParentNode): Added. Returns the node's parent for the purpose of of event capture and bubbling. The base class implementation is to return the parent node.
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::eventParentNode): Added. Since in SVG events bubble to and can be captured across the shadow DOM boundary, returns the shadow parent for shadow nodes.
1:58 AM Changeset in webkit [22956] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix how resizers invalidate so that there aren't glitches in the lower right corner of the window as you switch pages.

1:50 AM Changeset in webkit [19680] by hyatt
  • 2 edits in trunk/WebCore

Improve textarea resizer painting.

1:07 AM Changeset in webkit [19679] by kjk
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
by Mike Emmel.

  • kjs/ustring.cpp: compile-time assert to make sure sizeof(UChar) == 2
  • kjs/ustring.h: pack UChar struct to ensure that sizeof(UChar) == 2
  • wtf/Assertions.h: add COMPILE_ASSERT macro for compile-time assertions

WebCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
from Mike Emmel.

  • platform/DeprecatedString.cpp: compile-time assert to make sure sizeof(DeprecatedChar) == 2
  • platform/DeprecatedString.h: pack DeprecatedChar struct to ensure that sizeof(DeprecatedChar) == 2. Move _internalBuffer in DeprecatedStringData to the end, to avoid crashes on ARM due to different struct packing.
12:27 AM Changeset in webkit [19678] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

  • fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • fast/forms/input-readonly-autoscroll-expected.png: Added.
  • fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • fast/forms/input-readonly-autoscroll.html: Added.

WebCore:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

Test: fast/forms/input-readonly-autoscroll.html

Implemented autoscroll methods for RenderTextControl, so this works on non-editable text controls.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::shouldAutoscroll):
12:21 AM Changeset in webkit [22955] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea

  • WebView.cpp: (WebView::handleEditingKeyboardEvent): Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text). This will also reveal the selection properly.
12:14 AM Changeset in webkit [19677] by kjk
  • 7 edits in trunk/WebCore

Reviewed by Adam Roben.

Curl networking improvements inspired by Mike Emmel's patches in
​http://bugs.webkit.org/show_bug.cgi?id=11332.
Fix FrameLoaderClientGdk due to changed FrameLoaderClient API.

  • loader/gdk/FrameLoaderClientGdk.cpp: Massage for changed API. (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::willUseArchive):
  • loader/gdk/FrameLoaderClientGdk.h: Ditto.
  • platform/network/ResourceHandleInternal.h: Remember url and custom headers for the request lifetime and free them at the end. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleCurl.cpp: Ditto. (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleManager.cpp: url improvements:
  • remove m_useSimple code-path since it wasn't used anywhere
  • don't use hashmap for keeping track of outstanding jobs - curl does it anyway
  • set custom headers from request
  • enable gzip and deflate through Accept-Encoding
  • setup curl to share cookies and DNS cache between requests
  • enable persisting of cookies in a file (if client provides file name for cookies via ResourceHandleManager::setCookieJarFileName()) (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h:
12:09 AM Changeset in webkit [19676] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Gdk fixes.

  • page/gdk/EventHandlerGdk.cpp: Comment out chatty message. (WebCore::EventHandler::handleDrag):
  • platform/gdk/EditorClientGdk.cpp: Enable entering text into text field. (WebCore::EditorClientGdk::shouldInsertText):
Note: See TracTimeline for information about the timeline view.