⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 19, 2007:

9:35 PM Changeset in webkit [22971] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeSafari.


I just merged some of the code I wrote for RenderThemeMac.


9:33 PM Changeset in webkit [19726] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeMac.


No test case because 'leaks' can't detect these leaks inside DRT, even if
DRT forces the WebView to paint. ('leaks' can detect these leaks inside
Safari. Weird.)


  • rendering/RenderThemeMac.h:
    • Renamed data members to m_*, to match our style guidelines.
    • Renamed *Is* to is, to match our style guidelines.
    • Removed a few unnecessary data members.
    • Made cached values like m_checkbox mutable, since they can change inside functions that don't change the logical state of a RenderTheme object. (The alternative was to make some const functions non-const.)

(WebCore::RenderThemeMac::paintMenuList): Took CFType pointers that just
used to leak and placed them in RetainPtrs.
(WebCore::RenderThemeMac::paintMenuListButtonGradients): ditto

Factored inline implementations of lazy initialization into these accessor
functions, for better encapsulation:


(WebCore::RenderThemeMac::checkbox):
(WebCore::RenderThemeMac::radio):
(WebCore::RenderThemeMac::button):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::sliderThumbHorizontal): The inline version of
this initialization used to confuse the retained data member with a local
stack value, causing both a leak and a failure to initialize. Fixed now.
(WebCore::RenderThemeMac::sliderThumbVertical): ditto
(WebCore::RenderThemeMac::resizeCornerImage):

9:19 PM Changeset in webkit [19725] by thatcher
  • 4 edits in trunk/JavaScriptGlue

Reviewed by Geoff.

<rdar://problem/4636301> Deprecate JavaScriptGlue

  • JavaScriptGlue.h: adds DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER to everything
  • JavaScriptGlue.xcodeproj/project.pbxproj: use -Wno-deprecated-declarations to keep the project building
  • config.h: define DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER as empty on other systems
8:38 PM Changeset in webkit [19724] by bdash
  • 3 edits in tags/Safari-521.35

Versioning.

8:33 PM Changeset in webkit [19723] by bdash
  • 2 edits in tags/Safari-521.35/WebCore

Merge in r19665.

8:31 PM Changeset in webkit [19722] by bdash
  • 10 edits in tags/Safari-521.35/WebCore

Merge in r19662.

8:30 PM Changeset in webkit [19721] by bdash
  • 6 edits in tags/Safari-521.35/WebCore

Merge in r19660.

8:24 PM Changeset in webkit [19720] by bdash
  • 1 copy in tags/Safari-521.35

New tag.

7:01 PM Changeset in webkit [19719] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/table-outer-border-expected.checksum: Added.
  • fast/repaint/table-outer-border-expected.png: Added.
  • fast/repaint/table-outer-border-expected.txt: Added.
  • fast/repaint/table-outer-border.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/repaint/table-outer-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow after table sections have computed their outer horizontal borders.
6:39 PM Changeset in webkit [19718] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4613701> REGRESSION: A line break in the source HTML of a link becomes visible after drag & drop
  • page/DragController.cpp: (WebCore::DragController::startDrag): Call simplifyWhiteSpace() on the proposed link title to match what's displayed on the web page, instead of using the raw source HTML text.
5:41 PM Changeset in webkit [19717] by hyatt
  • 60 edits
    4 adds in trunk

Fix for Radar 4981605, regression where button grows randomly when a select is
opened. With the new form controls, the WinIE quirk for using line width
ended up being used for them more.

This patch removes the quirk after verifying that Firefox doesn't implement
the quirk at all. usesLineWidth is being renamed to shrinksToAvoidFloats to
make it clear that the new method only applies to block objects that avoid floats
and that have auto width.

Also fixed a regression where whitespace after a floating <select> at the start
of a block got incorrectly rendered. Make sure skipWhitespace always skips
through floating/positioned elements regardless of the whitespace setting (this
way the white-space:pre value on floating <select>s doesn't cause trouble).

Reviewed by darin

fast/block/float/float-avoidance.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidth):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shrinkToAvoidFloats):
  • rendering/RenderObject.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::skipWhitespace):
5:22 PM Changeset in webkit [19716] by weinig
  • 5 edits
    9 adds in trunk

LayoutTests:

Reviewed by Darin.

  1. Test for background image with relative url, when base url element is present. .html has a base url, which according to the html spec is supposed to be absolute, is actually a relative url. Absolute url would not work with ​file:// scheme.
  2. Test for base element and @import with relative url. ​http://bugs.webkit.org/show_bug.cgi?id=12214


  • fast/css/background-image-with-baseurl-expected.checksum: Added.
  • fast/css/background-image-with-baseurl-expected.png: Added.
  • fast/css/background-image-with-baseurl-expected.txt: Added.
  • fast/css/background-image-with-baseurl.html: Added.
  • fast/css/import_with_baseurl-expected.checksum: Added.
  • fast/css/import_with_baseurl-expected.png: Added.
  • fast/css/import_with_baseurl-expected.txt: Added.
  • fast/css/import_with_baseurl.html: Added.
  • fast/css/resources/background_image.css: Added.

WebCore:

Reviewed by Darin.

Update stylesheet href, when document's baseUrl changes. It needs
update when the stylesheet is constructed before the parser hits the base tag.
​http://bugs.webkit.org/show_bug.cgi?id=12214

  • css/StyleSheet.h: (WebCore::StyleSheet::setHref):
  • dom/Document.cpp: (WebCore::Document::setBaseURL):
  • dom/Document.h:
5:05 PM Changeset in webkit [19715] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam.

The FrameLoader's responseMIMEType was not being updated when a page was
brought back from the page cache.


Moved the line that updates the MIME type from commitProvisionalLoad() to
transitionToCommitted().

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):
4:01 PM Changeset in webkit [19714] by ggaren
  • 2 edits in trunk/WebKitTools

Build fix.


  • Scripts/check-for-global-initializers: Ignore the global counter I added for SubresourceLoaders.
3:36 PM Changeset in webkit [22970] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru

The fix for the bug was to zero out WebFrame's Frame pointer in
WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
non-null as appropriate. All IWebFrame methods that depend on the Frame
pointer will return E_FAIL if it is null, and everywhere within
WebFrame that wasn't null-checking before will now explicitly ASSERT.

I also changed all uses of d->frame and WebFrame::impl() to use the
core() function for consistency, and so that there is only one code
path for getting from a WebFrame to a Frame.

Additional more specific comments below.

  • WebChromeClient.cpp: (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebFrame.cpp: (kit): Null-check the frame parameter. (core): Added two overloads of this. (WebFrame::DOMDocument): Added argument checking. (WebFrame::currentForm): (WebFrame::loadRequest): (WebFrame::loadData): (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null. (WebFrame::provisionalDataSource): Ditto. (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::parentFrame): (WebFrame::renderTreeAsExternalRepresentation): Added argument checking. (WebFrame::firstLayoutDone): Ditto. (WebFrame::loadType): Ditto. (WebFrame::invalidate): (WebFrame::setTextSizeMultiplier): (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT. (WebFrame::setInViewSourceMode): Changed to return an HRESULT. (WebFrame::searchForLabelsBeforeElement): Added argument checking. (WebFrame::matchLabelsAgainstElement): Ditto. (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed. (WebFrame::createFrame): (WebFrame::loadURLIntoChild): Added some assertions. (WebFrame::dispatchWillSubmitForm): (WebFrame::frameLoadCompleted): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchCreatePage): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::windowObjectCleared): (WebFrame::setPrinting): (WebFrame::setInPrintingMode): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding. (WebFrame::spoolPages): (WebFrame::forceLayoutWithPageWidthRange):
  • WebFrame.h:
  • WebView.cpp: (WebView::paint): Silently fail on a null Frame, because this method could be called at any time. (WebView::mouseWheel): Ditto. (WebViewWndProc): Ditto. (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns. (WebView::setInViewSourceMode): Ditto. (WebView::setCustomTextEncodingName): Replaced check for a null FrameLoader with a check for a null Frame, which is equivalent but, as a bonus, won't crash. (WebView::stringByEvaluatingJavaScriptFromString): (WebView::elementAtPoint): Added argument checking. (WebView::selectedText): Ditto. (WebView::centerSelectionInVisibleArea):
3:34 PM Changeset in webkit [22969] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix build.

  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize):
3:32 PM Changeset in webkit [19713] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Make DragController::maxDragImageSize a function to get rid of the global initializer.


  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
  • page/DragController.h:
  • page/mac/DragControllerMac.mm: (WebCore::DragController::maxDragImageSize):
  • page/qt/DragControllerQt.cpp: (WebCore::DragController::maxDragImageSize):
3:19 PM Changeset in webkit [22968] by adele
  • 4 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Fix for <rdar://problem/5006882> PlatformScrollbarSafari doesn't support small scroll bars

3:19 PM Changeset in webkit [19712] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/check-for-global-initializers: Delete the linked executable if the check fails. Without this, you only see the global initializer error once, which makes it very easy to miss them.
3:09 PM Changeset in webkit [19711] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4841078> Remove the Mail.app editable link clicking behavior workaround when it is no longer needed

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (-[WebView setPreferences:]):
2:47 PM Changeset in webkit [22967] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5008424>
Regression: Crash loading mp3.com


  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Handle null resource errrors.
1:44 PM Changeset in webkit [19710] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5006414> REGRESSION: Crash occurs at WebCore::Frame::loader() when loading AFL Ladder widget
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Add missing null check so this fails without crashing when called on an element that's no longer in a frame.
1:39 PM Changeset in webkit [19709] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4868242>
​http://bugs.webkit.org/show_bug.cgi?id=12670
REGRESSION: Many 3rd Party Apps crash in WebCore::DocumentLoader::frameLoader() (12670)


Bring back the semantic we had that a web view should be retained for as long as something is loading. Use the identifier
to object hash map for this.

  • WebView/WebView.mm: (-[WebView _addObject:forIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
11:41 AM Changeset in webkit [19708] by thatcher
  • 3 edits in trunk/WebKit

Remove two imports of FrameMac.h, fixes clean Mac builds.

7:43 AM Changeset in webkit [19707] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.


  • fast/forms/select-accesskey-expected.checksum: Added.
  • fast/forms/select-accesskey-expected.png: Added.
  • fast/forms/select-accesskey-expected.txt: Added.
  • fast/forms/select-accesskey.html: Added.

WebCore:

Reviewed by Mitz.


Focus the select element too in accessKeyAction.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction):
1:20 AM Changeset in webkit [19706] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.


Avoid double painting caret when it is on a block element.


Layout test for this already went in previous try (it only fails in pixel mode) in r19626.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
12:35 AM Changeset in webkit [22966] by aroben
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Build fix.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame): This is no longer an instance method of Frame.
  • bridge/win/FrameWin.h:

WebKitWin:

Build fix.

  • WebFrame.cpp: (WebFrame::computePageRects):
12:13 AM Changeset in webkit [19705] by lars
  • 3 edits in trunk/WebCore

Added a one line patch from Olliej to create the
clipboard on demand (to stop things from crashing),
and added lots of notImplemented() warnings all
over the place.

Feb 18, 2007:

11:58 PM Changeset in webkit [22965] by mjs
  • 20 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • bridge/win/FrameWin.cpp: (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::computePageRects): (WebCore::drawRectIntoContext): (WebCore::imageFromSelection): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • bridge/win/FrameWin.h:
  • page/win/EventHandlerWin.cpp:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::addToDirtyRegion): (WebCore::ScrollView::scrollBackingStore): (WebCore::ScrollView::updateBackingStore):
  • platform/win/TemporaryLinkStubs.cpp: (Frame::print): (Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection):
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView):
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::createNullPluginView): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:

WebKitWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • WebChromeClient.cpp: (WebChromeClient::tabsToLinks): (WebChromeClient::windowResizerRect): (WebChromeClient::addToDirtyRegion): (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebChromeClient.h:
  • WebEditorClient.cpp: (WebEditorClient::shouldChangeSelectedRange): (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):
  • WebFrame.cpp: (kit): (WebFrame::initWithWebFrameView): (WebFrame::searchForLabelsBeforeElement): (WebFrame::matchLabelsAgainstElement): (WebFrame::createPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): (WebFrame::spoolPages):
  • WebFrame.h:
  • WebView.cpp: (WebView::handleEditingKeyboardEvent): (WebView::keyDown): (WebView::generateSelectionImage):
  • WebView.h:
11:58 PM Changeset in webkit [19704] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Oliver

<rdar://problem/4985321> - Can't edit templates for Web Gallery/Web Page Export in Aperture

  • Misc/WebKitVersionChecks.h: Add a #define for this APERTURE quirk
  • WebView/WebView.mm: (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): If the current app is Aperture and it was linked against Tiger WebKit, always allow selection change
11:57 PM Changeset in webkit [19703] by lars
  • 2 edits in trunk/WebCore

fix compilation.

11:54 PM Changeset in webkit [19702] by mjs
  • 91 edits
    4 adds
    2 deletes in trunk

WebCore:

Reviewed by Maciej.


Additional coding by Maciej, additional review by Oliver.

Get rid of the FrameMac and FrameQt classes. Instead
move all methods into Frame directly, and implement
some platform specific methods in foo/FrameFoo.cpp.

Some general cleanup in Frame:

  • Move some methods out of Frame, to the place where they belong.
  • Unify the different ways of creating the JavaScript wrappers for <object>, <embed> and <applet>
  • Some cleanup of the WebCoreFrameBridge
  • ForwardingHeaders/bindings/NP_jsobject.h: Added.
  • ForwardingHeaders/bindings/npruntime_impl.h: Added.
  • ForwardingHeaders/bindings/runtime_root.h: Added.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):
  • bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/EditorClient.h:
  • bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateBorder): (WebCore::FrameView::updateDashboardRegions):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • dom/Position.cpp: (WebCore::Position::next):
  • editing/CommandByName.cpp: (WebCore::Frame::execCopy): (WebCore::Frame::execCut): (WebCore::Frame::execPaste):
  • editing/Editor.cpp: (WebCore::Editor::canEdit): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::paste): (WebCore::Editor::pasteAsPlainText):
  • editing/Editor.h:
  • editing/JSEditor.cpp:
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::getInstance):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::detachFromParent):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/qt/DocumentLoaderQt.cpp:
  • page/Chrome.cpp: (WebCore::Chrome::shouldInterruptJavaScript):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::markedTextRange): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::shouldDeleteSelection): (WebCore::Frame::isContentEditable): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject): (WebCore::Frame::windowScriptNPObject): (WebCore::Frame::cleanupScriptObjects): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): (WebCore::EventHandler::keyboardUIMode):
  • page/mac/FrameMac.h: Removed.
  • page/mac/FrameMac.mm: (WebCore::Frame::setBridge): (WebCore::Frame::bridge): (WebCore::Frame::searchForLabelsAboveCell): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::fontAttributesForSelectionStart): (WebCore::Frame::baseWritingDirectionForSelectionStart): (WebCore::Frame::print): (WebCore::Frame::issuePasteCommand): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::textFieldDidBeginEditing): (WebCore::Frame::textFieldDidEndEditing): (WebCore::Frame::textDidChangeInTextField): (WebCore::Frame::textDidChangeInTextArea): (WebCore::Frame::doTextFieldCommandFromEvent): (WebCore::Frame::textWillBeDeletedInTextField): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::setMarkedTextRange): (WebCore::Frame::dashboardRegionsDictionary): (WebCore::Frame::dashboardRegionsChanged): (WebCore::Frame::willPopupMenu): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::customHighlightLineRect): (WebCore::Frame::paintCustomHighlight): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::windowScriptObject): (WebCore::Frame::cleanupPlatformScriptObjects):
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (createRootObject): (bridge): (-[WebCoreFrameBridge _frame]):
  • page/qt/EventHandlerQt.cpp:
  • page/qt/FrameQt.cpp: (WebCore::Frame::unfocusWindow): (WebCore::Frame::focusWindow): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::print): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • page/qt/FrameQt.h: Removed.
  • platform/MimeTypeRegistry.h:
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript): (WebCore::SVGEmptyEditorClient::shouldChangeSelectedRange):
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac):
  • platform/mac/FileChooserMac.mm: (-[OpenPanelController beginSheetWithFrame:]):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): (WebCore::Widget::setIsSelected):
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/ResourceHandleManagerQt.cpp:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start):
  • platform/qt/MimeTypeRegistryQt.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ScrollViewCanvasQt.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Added implementations for the new callbacks in EditorClient
and ChromeClient (basically moved from WebFrameBridge).
Cleaned up some code paths that are not called anymore
and done fully inside WebCore now.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebNSAttributedStringExtras.mm:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView getVariable:value:]):
  • Plugins/WebNetscapePluginEmbeddedView.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.mm:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldChangeSelectedRange):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): (-[WebFrameBridge fini]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchiver.mm:
  • WebView/WebFrame.mm: (core): (kit): (-[WebFrame _updateBackground]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm:
  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _isEditable]): (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView maintainsInactiveSelection]): (-[WebHTMLView scrollWheel:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView selectedAttributedString]):
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView shouldClose]): (-[WebView setEditable:]):

WebKitQt:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Add stubs for the new methods in ChormeClient and EditorClient,
remove all references to FrameQt.

  • Api/qwebframe.cpp: (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::shouldInterruptJavaScript):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldChangeSelectedRange): (WebCore::EditorClientQt::isEditable):
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): (WebCore::FrameLoaderClientQt::webFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:
11:18 PM Changeset in webkit [19701] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Oops, missed a 'const'

  • platform/qt/ClipboardQt.h:
11:04 PM Changeset in webkit [19700] by oliver
  • 3 edits
    2 adds in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Adding stubbed out implementation of Clipboard for Qt to stop
it crashing whenever someone drags the mouse.

  • WebCore.pro:
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/qt/ClipboardQt.cpp: Added. (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::types): (WebCore::ClipboardQt::dragLocation): (WebCore::ClipboardQt::dragImage): (WebCore::ClipboardQt::setDragImage): (WebCore::ClipboardQt::dragImageElement): (WebCore::ClipboardQt::setDragImageElement): (WebCore::ClipboardQt::createDragImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h: Added. (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::isForDragging):
11:00 PM Changeset in webkit [22964] by adachan
  • 9 edits
    4 adds in branches/WindowsMerge

2007-02-18 Ada Chan <​adachan@apple.com>

WebCoreWin:

Reviewed by Adam.

Move app text controls to use WebView.

  • added a method to let us render text using WebKit.
  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/WebCoreTextRenderer.cpp: Added. (WebCore::WebCoreDrawTextAtPoint):
  • platform/win/WebCoreTextRenderer.h: Added.

WebKitWin:

Reviewed by Adam.


Move app text controls to use webview

10:14 PM WebKit Team edited by oliver@apple.com
I appear to be the DnD guy now (diff)
10:07 PM Changeset in webkit [19699] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Don't even attempt to do a document based drag if there isn't a document
Fixes rdar://problem/4960109

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):

Null check m_document

(WebCore::DragController::tryDHTMLDrag):

ASSERT(m_document) -- tryDocumentDrag is the only
thing that will ever call us, but lets play it safe


4:42 PM Changeset in webkit [22963] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Rubberstamped by Hyatt.

Fix <rdar://problem/5006918> All selected text is black, even if it is
some other color when not selected

4:28 PM Changeset in webkit [22962] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix <rdar://problem/5006872> <select> popups need Aqua scroll bars

PopupMenuWin now uses a PlatformScrollbar.

4:26 PM Changeset in webkit [19698] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

A little preparation for <rdar://problem/5006872>.

  • platform/PopupMenu.h:
1:07 PM Changeset in webkit [19697] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12807
XPath incorrectly converts NaN to boolean

Test: fast/xpath/nan-to-boolean.html

  • xml/XPathValue.cpp: (WebCore::XPath::Value::toBoolean): Convert NaN to false.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstringAfter::doEvaluate): Fix substring-after to actually work.
8:15 AM Changeset in webkit [19696] by ap
  • 128 edits
    12 adds in trunk

2007-02-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Tests: fast/repaint/float-overflow.html

fast/repaint/float-overflow-right.html
fast/repaint/table-cell-vertical-overflow.html

Reflected in existing test results.

Unified floats and overflow for the purposes of painting and hit-testing.
Overhanging and overflowing floats are now factored into a block's overflow
unless their painting has been propagated to an ancestor.

Changed table cells to no longer expand to enclose overflow, thus making
it purely "visual overflow", having no effect on layout in WebCore. It
still determines scrolling dimensions.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks' horizontal overflow in the inline box's dimensions.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows behavior. Added code to add this block's floats (and their overflow) to its overflow rect if it is not in a block formatting context. Otherwise, the inclusion of floats in the overflow is deferred until this block's parent examines its floats and possibly adopts overhanging floats. (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::floatRect): Made non-virtual and changed to return an empty rect if there are no floats or the floats are clipped, instead of returning the border box. (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that are not to be painted by the parent are added to the child's overflow rect. (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow bounds to include the given rect. (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal child, add its floats to its overflow, since painting of floats does not propagate to flexible boxes. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.h: Removed the override of overflowHeight() since now tables can have vertical overflow.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): Made sure that overflow is repainted.
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats): Removed.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Factor in vertical overflow from cells. (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowHeight): (WebCore::RenderTableSection::overflowTop):
6:23 AM Changeset in webkit [19695] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix for the build fix -- can't call something that isn't a function

  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:48 AM Changeset in webkit [19694] by oliver
  • 3 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Adding platform/DragImage.cpp and platform/qt/DragImageQt.cpp to the Qt
project files

Stubbed method for WebCore::notAllowedCursor -- not sure what it should return,
have returned blank cursor, possibly needs to return something else

  • WebCore.pro:
  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:07 AM Changeset in webkit [19693] by oliver
  • 3 edits in trunk/WebKitQt

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix -- adding DragClientQt method stubs

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::willPerformDragSourceAction): (WebCore::DragClientQt::startDrag): (WebCore::DragClientQt::createDragImageForLink):
  • WebCoreSupport/DragClientQt.h:
4:59 AM Changeset in webkit [19692] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Sigh, obnoxious occasional auto conversion from float to int

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::createDragImage):


4:48 AM Changeset in webkit [19691] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12799
REGRESSION: Webpage doesn't load correctly (www.cincinnati.com
redirects to the wrong URL)

Test: http/tests/misc/refresh-meta-with-newline.html

  • platform/network/HTTPParsers.cpp: (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
  • platform/network/HTTPParsers.h: In HTML, all characters with codes <= 0x20 are whitespace, while in HTTP, only space and tab are such.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Pass parseHTTPRefresh() a flag telling about the source of data.
4:44 AM Changeset in webkit [19690] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Buld fix -- surprisingly RetainPtr doesn't exist on Qt

  • platform/DragImage.h:


4:35 AM Changeset in webkit [22961] by oliver
  • 10 edits
    1 add in branches/WindowsMerge

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

Updated to include stubs for drag and drop methods
Added DragImage[Win].cpp to project file
Now uses platform independent EventHandler::handleDrag

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::Frame::dragImageForSelection): Just wrap the platform specific selectionImage method
  • page/win/DragControllerWin.cpp: Defining constants for drag images -- basically copied the Mac definitions
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Basic implementation -- needs to create an IDataObject to be useful but ClipboardWin is basically unimplemented anyway so not yet a problem
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Stubs
  • platform/win/ClipboardWin.h: Updated interface
  • platform/win/DragImageWin.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Stubs to keep the build going

  • WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink):
  • WebDragClient.h:
4:30 AM Changeset in webkit [19689] by oliver
  • 28 edits
    4 adds in trunk

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

More drag and drop migration, now the entirety of the
drag initiation logic has been rendered platform independent
This has required a number of new interfaces, and a reasonable
amount of logic migration.

As a side effect, this patch also fixes rdar://problem/4945341

There are some basic Qt stubs that should stop the build from failing,
however the absence of ClipboardQt means any attempt to initiate a drag
may cause a crash.

  • WebCore.exp:

Exporting new symbols

  • WebCore.xcodeproj/project.pbxproj:

New files

  • dom/Clipboard.cpp: (WebCore::Clipboard::canSaveAsWebArchive): Migrated from WebKit
  • dom/Clipboard.h: Added more methods to allow Clipboard to be used as a platform independent container for drag and drop
  • page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage): This is a mac only helper function, so i've made it have an empty implementation, that way we won't need a PLATFORM(MAC) block in SVGImageEmptyClients
  • page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::tryDHTMLDrag): Using RefPtrs now (WebCore::getCachedImage): (WebCore::getImage): Helper functions (WebCore::dragLocForDHTMLDrag): (WebCore::dragLocForSelectionDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): Logic that generates drag images and clipboard content, and initiates the actual system drag operation
  • page/DragController.h: Method and variable declarations
  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): handleDrag is now platform independent (WebCore::EventHandler::handleTextInputEvent):

formatting

  • page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseDragged): Forgot to define this stub function
  • page/Frame.h: Declaring dragImageForSelection to provide drag image for selected content
  • page/mac/DragControllerMac.mm: Defining drag images control vars
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard): Migrated old clipboard creation to here
  • page/mac/FrameMac.mm: (WebCore::Frame::dragImageForSelection): Wrap FrameMac::selectionImage
  • page/qt/DragControllerQt.cpp: Defining drag images control vars
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard): stub
  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection): stub
  • platform/DragImage.cpp: Added. (WebCore::fitDragImageToMaxSize): (WebCore::createDragImageForSelection):

Platform independent processing for drag images

  • platform/DragImage.h: Added.

Declaring typedefs and wrapper functions to abstract the handling
of drag images

  • platform/Pasteboard.h: Declaring extracted writeURL and writeSelection methods
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::willPerformDragSourceAction): (WebCore::SVGEmptyDragClient::startDrag): (WebCore::SVGEmptyDragClient::createDragImageForLink): Stubs FTW!
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::pasteboard): Provide accessor for underlying NSPasteboard
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::hasData): (WebCore::ClipboardMac::writeRange): (WebCore::ClipboardMac::writeURL): (WebCore::ClipboardMac::declareAndWriteDragImage): (WebCore::ClipboardMac::createDragImage):

Implemented new Clipboarid functionality.

(WebCore::ClipboardMac::dragNSImage):

Made this a const method

  • platform/mac/DragImageMac.mm: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):

Implemented platform specific DragImage functions

  • platform/mac/PasteboardMac.mm: (WebCore::writeSelection): (WebCore::Pasteboard::writeSelection): (WebCore::writeURL): (WebCore::Pasteboard::writeURL):

Extracted member implementations of these functions, so that
Clipboard could also make use of this functionality.
Pasteboard methods now call the new non-member implementations.
Also fixed implementations to respect the list of requested types.

  • platform/qt/DragImageQt.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Moving the drag initiation logic to WebCore.
The redundant code in webkit will be moved out in a later patch.

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (getTopHTMLView): Helper function (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink): Implemented new DragClient methods (WebDragClient::declareAndWriteDragImage): Helper function for the Mac to allow new drag and drop code to match behaviour


  • WebView/WebHTMLView.mm: (-[WebHTMLView _dragImageForURL:withLabel:]): (-[WebHTMLView _dragImageForLinkElement:]): Refactoring old _dragImageForLinkElement function so that the link drag image can be created with just a URL and label, rather than requiring the original element (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Removed logic that is no longer necessary (-[WebHTMLView _mouseDownEvent]): The WebDragClient may need the original mouseDownEvent of a drag when initiating a drag
  • WebView/WebHTMLViewInternal.h: Declaring _mouseDownEvent
  • WebView/WebHTMLViewPrivate.h: Declaring _dragImageForURL



12:48 AM Changeset in webkit [19688] by ap
  • 4 edits in trunk/JavaScriptCore

2007-02-18 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Roben.

Fix cases where MSVC-specific code was identified as Win32 platform
code. (as it should be compiled for e.g. wx port when using MSVC too)


  • wtf/Assertions.h:
  • wtf/MathExtras.h:
  • wtf/StringExtras.h: changed PLATFORM(WIN) sections to COMPILER(MSVC) as necessary
Note: See TracTimeline for information about the timeline view.