⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 21, 2007:

11:20 PM Changeset in webkit [19788] by kjk
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Improve notImplemented() macro for gdk. Rename to notImplementedGdk() to
give it a unique name (so that it doesn't clash with notImplemented()
for other platforms).
Make it print a given warning only once, so that frequently called
functions don't clutter the output.
Don't print the warning if DISABLE_NI_WARNING env variable is set.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload): (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::adjustTextFieldStyle):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (Widget::setEnabled): (Widget::isEnabled): (Widget::focusPolicy): (Widget::enableFlushDrawing): (Widget::disableFlushDrawing): (Widget::lockDrawingFocus): (Widget::unlockDrawingFocus): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (Font::drawComplexText): (Font::floatWidthForComplexText): (Font::offsetForPositionForComplexText): (PageCache::close): (Editor::ignoreSpelling): (Editor::learnSpelling): (Editor::isSelectionUngrammatical): (Editor::isSelectionMisspelled): (Editor::guessesForMisspelledSelection): (Editor::guessesForUngrammaticalSelection): (Editor::markMisspellingsAfterTypingToPosition): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::writeImage): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::supportedKeySizes): (WebCore::systemBeep): (WebCore::userIdleTime):
10:40 PM Changeset in webkit [19787] by staikos
  • 2 adds in trunk/WebKitQt/WebCoreSupport

Add missing files from last commit

10:17 PM Changeset in webkit [19786] by ggaren
  • 86 edits in trunk

LayoutTests:

Reviewed by Adam Roben.


Updated results to new, more correct values produced by painting SVGs
before dumping their render trees.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/carto.net/button-expected.txt:
  • svg/carto.net/colourpicker-expected.txt:
  • svg/carto.net/combobox-expected.txt:
  • svg/carto.net/scrollbar-expected.txt:
  • svg/carto.net/selectionlist-expected.txt:
  • svg/carto.net/slider-expected.txt:
  • svg/carto.net/tabgroup-expected.txt:
  • svg/carto.net/textbox-expected.txt:
  • svg/carto.net/window-expected.txt:
  • svg/custom/gradient-stop-style-change-expected.txt:
  • svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • svg/custom/js-late-clipPath-creation-expected.txt:
  • svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-text-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/text-repaint-including-stroke-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-on-text-expected.txt:

WebKitTools:

Reviewed by Adam Roben.


Added hack to force painting when running an SVG test. This is a work-around
for ​http://bugs.webkit.org/show_bug.cgi?id=12849 SVG renderers update at
paint time instead of style resolution time.

We need this so that --leaks mode, which always paints, doesn't appear to
fail SVG tests. We also need this if we ever want to test style application
in SVG, since many SVGs don't apply style to their renderers until they paint.

  • Scripts/run-webkit-tests:
8:31 PM Changeset in webkit [22982] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix

7:31 PM Changeset in webkit [22981] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders' rubberstamp


  • WebDownload.cpp: (WebDownload::initToResumeWithBundle): Make a copy of the string we truncate so it doesn't affect the original
7:12 PM Changeset in webkit [19785] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12820
REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033

add test for caret before <select> case too

  • editing/selection/caret-before-select-expected.checksum: Added.
  • editing/selection/caret-before-select-expected.png: Added.
  • editing/selection/caret-before-select-expected.txt: Added.
  • editing/selection/caret-before-select.html: Added.

WebCore:

Reviewed by Hyatt.

Yet another attempt to figure out exactly who should paint the caret.

  • editing/SelectionController.cpp: (WebCore::SelectionController::isInsideNode):
  • editing/SelectionController.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
7:07 PM Changeset in webkit [22980] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

<rdar://problem/4964763> - Hookup resume downloads on the engine side


NOTE: Resume downloads are broken in the current ChickenCat - this functionality requires
a custom ToT CFNetwork as of CFNetwork r3372, or will require CFNetwork 172 or later


  • WebDownload.cpp: (WebDownload::initWithRequest): Changed some logging, plugged some potential leaks (WebDownload::initToResumeWithBundle): Added a real implementation - this now works! (WebDownload::didFinish): Added some logging and fixed up some lifetime issues (extractResumeDataFromBundle): Renamed to imply the modification of the file. Truncate the resume data from the file once it is extracted
6:58 PM Changeset in webkit [19784] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dynamic/staticY-marking-parents-regression-expected.checksum: Added.
  • fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
  • fast/dynamic/staticY-marking-parents-regression-expected.txt: Added.
  • fast/dynamic/staticY-marking-parents-regression.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/dynamic/staticY-marking-parents-regression.html

Changed calls to setChildNeedsLayout(true) during layout to
setChildNeedsLayout(true, false). Prior to r19148, the default behavior
of marking containers did not matter because the caller was the container
and was already marked, but r19148 added marking of the parent of
objects with static Y, which can be different from the caller and not
necessarily marked already.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticY):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
6:54 PM Changeset in webkit [19783] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison

<rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
after regaining network connection

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Leave an assertion for debug build exploration, but gracefully handle the release build case
5:14 PM Changeset in webkit [19782] by thatcher
  • 2 edits in trunk/WebCore

Rubber-stamped by Darin.

  • bindings/objc/PublicDOMInterfaces.h: Add missing classes that are really public. Also adds the deprecated selector for getComputedStyle: on DOMDocument.
4:30 PM Changeset in webkit [19781] by andersca
  • 3 edits in trunk/WebKitLibraries

Add new version with WKCGContextIsBitmapContext.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:10 PM Changeset in webkit [19780] by justing
  • 11 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/5012665>
Removing indent from list moves the caret to the line below

No new layout tests needed because the new results
for these tests and the removed FIXMEs cover the bug fix:

  • editing/execCommand/indent-list-item.html:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/remove-list-1.html:
  • editing/execCommand/remove-list-1-expected.checksum:
  • editing/execCommand/remove-list-1-expected.png:
  • editing/execCommand/remove-list-1-expected.txt:

WebCore:

Reviewed by john


<rdar://problem/5012665>
Removing indent from list moves the caret to the line below

Selection preservation during indent, outdent and list
operations uses rangeFromLocationAndLength. Ranges returned
by rangeFromLocationAndLength were incorrect for locations
just before the line breaks that are emitted after blocks.
This is because TextIterator emitted bad ranges for these line
breaks (ranges that started and ended *after* the block).
The fix corrects the start but not the end. This is acceptible
because there is code in rangeFromLocationAndLength that corrects
the ends of runs using the start of the run and VisiblePosition
creation.


  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Emit a position *inside* the block, after its contents.
2:56 PM Changeset in webkit [19779] by ggaren
  • 2 edits in trunk/WebKitTools

Reduced --leaks mode to running only 750 tests at a time, in the hopes
of fixing intermittent crasher that may be caused by out of memory
conditions.

  • Scripts/run-webkit-tests:
2:32 PM Changeset in webkit [19778] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Made DRT paint when running run-webkit-tests in --leaks mode, to check
for painting leaks.

  • DumpRenderTree/DumpRenderTree.m: Removed some "NO" initializations, since that's the default for statics. (dumpRenderTree): Added --paint command line option, which specifies that DRT should paint at the end of every test. (displayWebView): New function, called by dump() and -[LayoutTestController display].
  • Scripts/run-webkit-tests: Use the --paint command line option when checking for leaks.
  • Scripts/run-webkit-tests: Added a new, painting leak to the ignore list. Removed stale comment about THRD leaks -- we now ignore them reliably.
2:06 PM Changeset in webkit [22979] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Updated for SafariTheme changes.

1:52 PM Changeset in webkit [22978] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore.vcproj: Added JSHTMLSelectElementCustom.h
1:49 PM Changeset in webkit [19777] by adele
  • 7 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

  • fast/forms/select-index-setter-expected.txt: Added.
  • fast/forms/select-index-setter.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

Test: fast/forms/select-index-setter.html

Added indexSetter for HTMLSelectElement.

  • WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElementCustom.h
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter): Moved code to selectIndexSetter so it can be shared between these classes.
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::selectIndexSetter): Added. Moved from JSHTMLOptionsCollection::indexSetter. (WebCore::JSHTMLSelectElement::indexSetter): Calls selectIndexSetter.
  • bindings/js/JSHTMLSelectElementCustom.h: Added.
  • html/HTMLSelectElement.idl: Added HasCustomIndexSetter keyword.
  • bindings/scripts/CodeGeneratorJS.pm: When generating "put" methods, if the propertyName is a number, call the indexSetter first, and then call the version of lookupPut that will also try to use the parent's lookup table. This matches the order of our old code, before we autogenerated the JSHTMLSelectElement class.
12:48 PM Changeset in webkit [19776] by ggaren
  • 2 edits in trunk/WebKitTools

Tools tweak. No review necessary.


  • Scripts/parse-malloc-history: Enabled multiple merge-regexp command line arguments. Changed command line argument variables from special implicit no-op values to specific empty values that we test explicitly.
12:00 PM Changeset in webkit [19775] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 12834: Drosera should remember scroll position of open files like Xcode
​http://bugs.webkit.org/show_bug.cgi?id=12834

  • Drosera/debugger.js: Implemented scrolling memory
10:55 AM Changeset in webkit [19774] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

brmorris, reviewed by Sachin.

DESC: r19404 caused some regresion, so I'm reverting it. TMCN-6XYSLY
This was a fix for Enhanced Input feature not working in 3.1
​http://bugs.webkit.org/show_bug.cgi?id=12533

8:55 AM Changeset in webkit [19773] by staikos
  • 8 edits in trunk

Add undo/redo support and more editing commands.

5:59 AM Changeset in webkit [19772] by zack
  • 6 edits
    2 adds in trunk/WebCore

Implementing popups for the Qt platform.
r=Lars

4:00 AM Changeset in webkit [19771] by staikos
  • 2 edits in trunk/WebCore

Remove unneeded hack

3:18 AM Changeset in webkit [19770] by zack
  • 2 edits in trunk/WebCore

Fix rendering of lineedits and remove the spurious
padding on push-buttons.
r=Lars

1:13 AM Changeset in webkit [19769] by zack
  • 5 edits in trunk

fixing compilation with Qt

Feb 20, 2007:

11:30 PM Changeset in webkit [19768] by aroben
  • 2 edits in trunk/WebCore

Preemptive build fix.

  • platform/mac/FontCacheMac.mm: Remove unused (and non-existent) header.
10:20 PM Changeset in webkit [19767] by bdash
  • 4 edits in tags/Safari-421.35

Versioning.

10:11 PM Changeset in webkit [19766] by bdash
  • 1 copy in tags/Safari-421.35

New tag.

10:04 PM Changeset in webkit [22977] by bdakin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej.

Some changes needed to match moving writeImage() to the Pasteboard
on the Mac.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeURL): Now takes a bool indicating if the url if for an image. (WebCore::Pasteboard::writeImage): This is just a stub for now. I am putting it here instead of on TemporaryLinkStubs because I plan on implementing it very soon.

WebKitWin:

Reviewed by Maciej.

Move copyImage functionality from the ContextMenuClient to the
Pasteboard.

  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/PasteboardWin.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

10:02 PM Changeset in webkit [19765] by aroben
  • 2 edits in trunk/WebCore

Fix the build the right way.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Keep all widths as floats.
10:00 PM Changeset in webkit [19764] by bdakin
  • 26 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

Implement writeImage() on Pasteboard so that the context menus can
call into the editor for the "Copy image" command instead of
calling across the clients.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::copyImage): Call into the Pasteboard.
  • editing/Editor.h:
  • loader/mac/LoaderNSURLExtras.h: A new NSURL extra needed inside WebCore.
  • loader/mac/LoaderNSURLExtras.m: Made this file Objective-C++ (from Objective-C) since the call into the MIMETypeRegistry will return a Vector. (urlByRemovingComponent): Cast to build as Obj-C++ (urlWithDataRelativeToURL): Same. (vectorContainsString): Helper. (suggestedFilenameWithMIMEType): New function.
  • page/ContextMenuClient.h: Remove copyImageToClipboard()
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the editor instead of the client.
  • page/mac/WebCoreViewFactory.h: New localized String.
  • platform/LocalizedStrings.h: Same.
  • platform/MimeTypeRegistry.h: Expose two additional functions for MIMEType information from WebCore System Interface.
  • platform/Pasteboard.h:
  • platform/SharedBuffer.h: Make platformData() and platformDataSize () public since they are needed to write the image to the pasteboard.
  • platform/mac/LocalizedStringsMac.mm: New localized string. (WebCore::copyImageUnknownFileLabel):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getExtensionsForMIMEType): (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
  • platform/mac/PasteboardMac.mm: (WebCore::writableTypesForImage): (WebCore::Pasteboard::writeURL): Write the correct types if the url is for an image. (WebCore::fileWrapperForImage): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage):
  • platform/mac/WebCoreNSStringExtras.h: Added. Some the the NSStringExtras that were in WebKit are now needed by WebCore. To avoid having two copies of these functions, I just moved the implementations to WebCore. The WebKit functions just call into WebCore.
  • platform/mac/WebCoreNSStringExtras.mm: Added. (hasCaseInsensitiveSuffix): (hasCaseInsensitiveSubstring): (filenameByFixingIllegalCharacters):
  • platform/mac/WebCoreSystemInterface.h: wkGetPreferredExtensionForMIMEType and wkGetExtensionsForMIMEType are now needed in WebCore as well as WebKit.
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Maciej.

WebKit changes needed to implement writeImage() in WebCore's
Pasteboard class.

  • Misc/WebKitNSStringExtras.m: Call into WebCore for these implementations. (-[NSString _webkit_hasCaseInsensitiveSuffix:]): (-[NSString _webkit_hasCaseInsensitiveSubstring:]): (-[NSString _webkit_filenameByFixingIllegalCharacters]):
  • Misc/WebNSURLExtras.m: Same. (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
  • WebCoreSupport/WebContextMenuClient.h: Remove copyImageToClipboard()
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebSystemInterface.m: Expose GetExtensionsForMIMEType and GetPreferredExtensionForMIMEType to WebCore. (InitWebCoreSystemInterface):
  • WebCoreSupport/WebViewFactory.mm: New localized string for WebCore. (-[WebViewFactory copyImageUnknownFileLabel]):
9:16 PM Changeset in webkit [19763] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Added explicit casts.
9:06 PM Changeset in webkit [22976] by aroben
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin and Anders.

  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): Added truncation.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
  • platform/win/WebCoreTextRenderer.h: Ditto.

WebKitWin:

Reviewed by Darin and Anders.

9:03 PM Changeset in webkit [19762] by aroben
  • 10 edits
    2 moves in trunk

WebCore:

Reviewed by Darin and Anders.

Fix <rdar://problem/4736215> Make WebCoreStringTruncator use WebCore types

  • WebCore.exp: Updated symbols.
  • WebCore.xcodeproj/project.pbxproj: Updated file names.
  • bridge/mac/WebCoreStringTruncator.h: Removed.
  • bridge/mac/WebCoreStringTruncator.mm: Removed.
  • platform/StringTruncator.cpp: Added. Moved from bridge/mac/WebCoreStringTruncator.mm. (WebCore::textBreakAtOrPreceding): Added. (WebCore::boundedTextBreakFollowing): Added. (WebCore::centerTruncateToBuffer): (WebCore::rightTruncateToBuffer): (WebCore::stringWidth): Now takes a const Font& instead of a Font*. (WebCore::truncateString): (WebCore::StringTruncator::centerTruncate): (WebCore::StringTruncator::rightTruncate): (WebCore::StringTruncator::width):
  • platform/StringTruncator.h: Added.
  • platform/TextBreakIterator.h: Added isTextBreak declaration.
  • platform/TextBreakIteratorICU.cpp: (WebCore::isTextBreak): Implemented.
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): Updated for changes to WebCoreStringTruncator.
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::isTextBreak): Stubbed out.

WebKit:

Reviewed by Darin and Anders.

Update WebKit for WebCore fix for <rdar://problem/4736215> Make
WebCoreStringTruncator use WebCore types.

  • Misc/WebStringTruncator.m: (defaultMenuFont): Moved from WebCoreStringTruncator.mm. (core): Added. (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebKit.xcodeproj/project.pbxproj: Changed WebStringTruncator to ObjC++.
7:58 PM Changeset in webkit [19761] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text

  • editing/pasteboard/5006779-expected.checksum: Added.
  • editing/pasteboard/5006779-expected.png: Added.
  • editing/pasteboard/5006779-expected.txt: Added.
  • editing/pasteboard/5006779.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text


We decided to change the copy/paste behavior in both
the Paste and the Paste and Match Style cases.

  • editing/markup.cpp: (WebCore::createMarkup): Don't add mail blockquote wrappers unless the user selected one or more paragraphs.
5:48 PM Changeset in webkit [19760] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4912899> WebCore project ObjC @property cleanup

  • bindings/objc/DOMObject.h: Add the new style @property
  • bindings/objc/PublicDOMInterfaces.h: Update to the new style @property
  • bindings/scripts/CodeGeneratorObjC.pm: Export both new and old style @properties
5:39 PM Changeset in webkit [19759] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Fixes the build!

4:54 PM Changeset in webkit [19758] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Build fix for the no-SVG build.

4:48 PM Changeset in webkit [19757] by thatcher
  • 2 edits in trunk/WebCore/bindings/objc

Better build fix, rolling out part of r19579.

4:40 PM Changeset in webkit [19756] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOM.mm

Build fix.

4:36 PM Changeset in webkit [19755] by ggaren
  • 2 edits in trunk/WebKitTools

Tools tweak. No review necessary.


Made parse-malloc-history executable. (Oops!)


Made parse-malloc-history parse 'leaks' output in addition to 'malloc_history"
output.


Added the ability to merge callstacks by regexp, not just depth, so you
can ask questions like, "How many of these allocations were due to that one
call to ...?"


  • Scripts/parse-malloc-history:
4:12 PM Changeset in webkit [19754] by staikos
  • 2 edits in trunk/WebKitQt

Fix compile

4:07 PM Changeset in webkit [19753] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

<rdar://problem/5007248> need to export symbols for DOM exception constants

  • WebCore.exp: Adds DOMEventException, DOMException, DOMRangeException, DOMXPathException
3:56 PM Changeset in webkit [19752] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

Fixes the version number returned when using a CFBundleVersion of "420+".

  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): Check the length up to the first non-decimal digit, so this works with versions that have "." and "+".
3:38 PM Changeset in webkit [19751] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker


  • fixed <rdar://problem/4989344> REGRESSION: After clicking on page, Find won't find anything if all hits are before the clicked point


This was caused by a mismatch between WebCore's search code's notion of "selection" and
WebView's search code's notion of "selection". WebCore's search code was starting
just before or just after the "selection", which included collapsed, zero-length
selections. WebKit's search code was only considering non-zero-length selections,
and would not search all of the content when there was a zero-length selection.
The fix was to make WebKit ignore the selection. This has a side effect of increasing
the amount of redundantly-searched content in the case where no matches are found. To
compensate for that, I special-cased the most common case of WebViews with a single frame,
to avoid ever searching redundantly in those.

  • WebView/WebView.mm: (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): remove startHasSelection ivar; special-case WebViews with only one frame; clarify the code that leads to redundant searching with comments.
3:26 PM Changeset in webkit [19750] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Build fix.

3:26 PM Changeset in webkit [19749] by ggaren
  • 2 edits in trunk/WebKitTools
  • Scripts/parse-malloc-history: Added copyright info.
2:57 PM Changeset in webkit [19748] by brmorris
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by zalan

DESC: Merge of r19731 to s60/trunk: Browser crashes when trying to open rss link HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

2:55 PM Changeset in webkit [22975] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:53 PM Changeset in webkit [19747] by thatcher
  • 21 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject initialize]):
  • bridge/mac/WebCoreScriptDebugger.mm: (+[WebCoreScriptDebugger initialize]):
  • platform/mac/SharedBufferMac.mm: (+[SharedBufferData initialize]):
  • platform/mac/WebCoreObjCExtras.c: Added. (WebCoreObjCFinalizeOnMainThread):
  • platform/mac/WebCoreObjCExtras.h: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread. Assert in finalize that we
are on the main thread.

  • Carbon/CarbonWindowAdapter.m: (+[CarbonWindowAdapter initialize]): (-[CarbonWindowAdapter finalize]):
  • History/WebBackForwardList.mm: (+[WebBackForwardList initialize]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary finalize]):
  • Plugins/WebBaseNetscapePluginStream.m: (+[WebBaseNetscapePluginStream initialize]): (-[WebBaseNetscapePluginStream finalize]):
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView initialize]): (-[WebBaseNetscapePluginView finalize]):
  • Plugins/WebBasePluginPackage.m: (+[WebBasePluginPackage initialize]): (-[WebBasePluginPackage finalize]):
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream finalize]):
  • WebCoreSupport/WebEditorClient.mm: (+[WebEditCommand initialize]): (-[WebEditCommand finalize]):
  • WebCoreSupport/WebFrameBridge.mm: (+[WebFrameBridge initialize]): (-[WebFrameBridge finalize]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (+[WebFramePolicyListener initialize]): (-[WebFramePolicyListener finalize]):
  • WebView/WebHTMLView.mm: (+[WebHTMLView initialize]): (-[WebHTMLView finalize]):
  • WebView/WebView.mm: (+[WebViewPrivate initialize]): (-[WebViewPrivate finalize]):
2:53 PM Changeset in webkit [19746] by sfalken
  • 1 copy in tags/Safari-521.35.1b

New tag.

2:44 PM Changeset in webkit [19745] by justing
  • 3 edits in trunk/WebKit

Reviewed by darin


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Mail overrides paste: because it has different
preferred pasteboard types, but it should use our
fragment creation code.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Moved fragment creation code into a new method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:]): Moved fragment creation code here.
  • WebView/WebHTMLViewPrivate.h: Exposed _documentFragmentFromPasteboard:forType:inContext: as SPI.
2:32 PM Changeset in webkit [19744] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: removed _webkit_userVisibleBundleVersionFromFullVersion; we decided to do this without adding SPI for it.
  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): new method, moved here from WebKitNSStringExtras, and is now a WebView method rather than an NSString method (-[WebView _computeUserAgent]): updated for method signature change
2:09 PM Changeset in webkit [19743] by ggaren
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Darin Adler.


New script to parse the output from malloc_history, so we can determine
what's using memory in WebKit.

  • Scripts/parse-malloc-history: Added.
1:32 PM Changeset in webkit [19742] by ggaren
  • 2 edits in trunk/WebCore

Not not reviewed by Mitz Pettel.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12827 | <rdar://problem/5006671>
REGRESSION: -[DOMCSSStyleDeclaration setValue:forKey:] doesn't have an
immediate effect


Let's just pretend this never happened.


I attempted a layout test but I couldn't get the old code to fail because
there's no obvious way to isolate the ObjC bindings in a test that's
controlled by JS.


  • bindings/objc/WebScriptObject.mm: (_didExecute):
1:21 PM Changeset in webkit [19741] by kjk
  • 14 edits
    2 copies in trunk/WebCore

Reviewed by Maciej S.

Gdk build fixes for recent refactorings.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/gdk/DragControllerGdk.cpp: (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/DragImage.h:
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/EditorClientGdk.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::dragImageForSelection):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/MimeTypeRegistryGdk.cpp: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore):
  • webcore-base.bkl:
1:13 PM Changeset in webkit [19740] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Allow over-writting Product, ProductSub, Vendor and VendorSub
js properties via #define WEBCORE_NAVIGATOR_*

  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
12:41 PM Changeset in webkit [19739] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by John.

  • Misc/WebKitNSStringExtras.h: Added _webkit_userVisibleBundleVersionFromFullVersion.
  • Misc/WebKitNSStringExtras.m: (-[NSString _webkit_userVisibleBundleVersionFromFullVersion]): If the version is 4 digits long or longer, then the first digit represents the version of the OS. Our user agent string should not include this first digit, so strip it off and report the rest as the version.
  • WebView/WebView.mm: (-[WebView _computeUserAgent]): Call _webkit_userVisibleBundleVersionFromFullVersion on the CFBundleVersion.
11:33 AM Changeset in webkit [22974] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/WebCore.vcproj: Added PositionIterator.cpp & h
11:27 AM Changeset in webkit [19738] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog-2006-12-31
10:56 AM Changeset in webkit [22973] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-20 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
10:20 AM Changeset in webkit [22972] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

  • WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to FrameLoader and DocumentLoader.
10:18 AM Changeset in webkit [19737] by darin
  • 12 edits in trunk

WebCore:

Reviewed by Anders.

  • prepare to fix some "stop loading" bugs by moving state from the FrameLoader class to the DocumentLoader class
  • WebCore.exp: Update since cancelMainResourceLoad is now on the document loader.
  • html/HTMLDocument.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): Removed unused bodyElement and htmlElement data members. (WebCore::HTMLDocument::lastModified): Call getResponseModifiedHeader directly on the document loader.
  • loader/DocumentLoader.h: Moved m_mainResourceLoader, m_subresourceLoaders, and m_plugInStreamLoaders here.
  • loader/DocumentLoader.cpp: (WebCore::cancelAll): Moved here from FrameLoader. (WebCore::setAllDefersLoading): Ditto. (WebCore::DocumentLoader::mainResourceData): Moved the body of FrameLoader's mainResourceData function here. (WebCore::DocumentLoader::stopLoading): Replaced calls to hasMainResourceLoader and cancelMainResourceLoad with code that works directly on m_mainResourceLoader. Call the stop functions moved from FrameLoader here on ourselves. (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ditto. (WebCore::DocumentLoader::setPrimaryLoadComplete): Moved the code to store the main resource data here; it doesn't require separate functions. (WebCore::DocumentLoader::isLoadingInAPISense): Removed call to isLoadingSubresources and instead just check if the m_subresourceLoaders set is empty. (WebCore::DocumentLoader::setDefersLoading): Moved code here from FrameLoader. (WebCore::DocumentLoader::stopLoadingPlugIns): Ditto. (WebCore::DocumentLoader::stopLoadingSubresources): Ditto. (WebCore::DocumentLoader::addSubresourceLoader): Ditto. (WebCore::DocumentLoader::removeSubresourceLoader): Ditto. (WebCore::DocumentLoader::addPlugInStreamLoader): Ditto. (WebCore::DocumentLoader::removePlugInStreamLoader): Ditto. (WebCore::DocumentLoader::isLoadingSubresources): Ditto. (WebCore::DocumentLoader::isLoadingPlugIns): Ditto. (WebCore::DocumentLoader::startLoadingMainResource): Ditto. (WebCore::DocumentLoader::cancelMainResourceLoad): Ditto.
  • loader/FrameLoader.h: Removed stopLoadingPlugIns, stopLoadingSubresources, cancelMainResourceLoad, hasMainResourceLoader, isLoadingSubresources, mainResourceData, releaseMainResourceLoader, lastModified, startLoadingMainResource, isLoadingPlugIns, m_mainResourceLoader, m_subresourceLoaders, m_plugInStreamLoaders, m_responseRefreshHeader, and m_responseModifiedHeader.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): Call setDefersLoading on all the document loaders. (WebCore::FrameLoader::stopLoading): Get rid of code to set m_responseRefreshHeader and m_responseModifiedHeader. (WebCore::FrameLoader::receivedFirstData): Call httpHeaderField on the response here to get the Refresh, instead of storing it in a data member. (WebCore::FrameLoader::addPlugInStreamLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removePlugInStreamLoader): Ditto. (WebCore::FrameLoader::isLoading): Change to call isLoadingSubresources and isLoadingPlugIns on the document loader. (WebCore::FrameLoader::addSubresourceLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removeSubresourceLoader): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Call stopLoadingSubresources and stopLoadingPlugIns on the document loader. Removed code to set m_responseModifiedHeader. (WebCore::FrameLoader::startLoading): Call isLoadingMainResource and startLoadingMainResource on the document loader.
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): Call mainResourceData() on the document loader instead of the frame loader.
  • other changes
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus): Fixed indentation.

WebKit:

Reviewed by Anders.

  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]): Call cancelMainResourceLoad on the document loader instead of the frame loader.
9:24 AM Changeset in webkit [19736] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5009627> REGRESSION: Repro overrelease of WebView in failed load, seen in DumpRenderTree


  • WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]): Return early if the identifier can't be found in the map.
9:19 AM Changeset in webkit [19735] by zack
  • 3 edits in trunk/WebCore

Fix focus handling and make the forms
work as expected.
r=Lars

8:00 AM Changeset in webkit [19734] by weinig
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Darin and then Sam.

No test since there is no change in functionality.

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj: Added PositionIterator.{cpp,h}.
  • WebCoreSources.bkl:
  • dom/Position.cpp: (WebCore::Position::Position): Added converting constructor from PositionIterator. (WebCore::Position::previous): Changed assert() to ASSERT(). (WebCore::Position::next): Ditto. (WebCore::isStreamer): Changed the argument to a PositionIterator. (WebCore::Position::upstream): Changed to use PositionIterator. (WebCore::Position::downstream): Ditto. (WebCore::Position::inRenderedText): Made public. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Changed into a static member function. (WebCore::Position::nodeIsUserSelectNone): Ditto.
  • dom/Position.h:
  • dom/PositionIterator.cpp: Added. A Position iterator with constant-time increment, decrement, and several predicates on the Position it is at. Conversion to/from Position is O(n) in the offset. (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atStart): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atStartOfNode): (WebCore::PositionIterator::atEndOfNode): (WebCore::PositionIterator::isCandidate):
  • dom/PositionIterator.h: Added. (WebCore::PositionIterator::PositionIterator): (WebCore::PositionIterator::node): (WebCore::PositionIterator::offsetInLeafNode):
  • editing/htmlediting.cpp: (WebCore::nextCandidate): Changed to use PositionIterator. (WebCore::previousCandidate): Changed to use PositionIterator.
7:43 AM Changeset in webkit [19733] by brmorris
  • 2 edits in S60/trunk/WebCore

hongzhao, reviewed by Zalan

DESC: [S60] - Browser NG, ReTe: Some call links on "cti_attribute.html " page are highlighted incorrectly ESZG-6TU9N9
Fix: Add hover sto a[cti].s
​http://bugs.webkit.org/show_bug.cgi?id=12814

7:39 AM Changeset in webkit [19732] by rwlbuis
  • 30 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12439
SVG parser complains about points attribute in polygon and polyline element

Return true when the parsed points specification is valid.

7:07 AM Changeset in webkit [19731] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

yadavall, Reviewed by Zalan Bujtas (​zbujtas@gmail.com).

DESC: Browser crashes when trying to open rss link hs.fi/rss HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

6:46 AM Changeset in webkit [19730] by zack
  • 10 edits in trunk

Make editing of forms work plus make sure that non-void methods
always return something.
r=Lars

4:30 AM Changeset in webkit [19729] by zack
  • 2 edits
    1 add in trunk/WebCore

Redo form-theming (aka. make Qt pretty, so very, very pretty)
r=Lars

2:33 AM Changeset in webkit [19728] by ap
  • 2 edits in trunk/WebCore

2007-02-19 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12815
Two image files not included in project file

  • WebCore.xcodeproj/project.pbxproj: Added crossHairCursor.png and notAllowedCursor.png.
2:11 AM Changeset in webkit [19727] by gdennis
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin Adler.


Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12802
WebKit.framework is built with SVG_SUPPORT for No-SVG build

  • Scripts/build-webkit: Pass the "FEATURE_DEFINES=" option when building WebKit as well.
Note: See TracTimeline for information about the timeline view.