⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 23, 2007:

11:42 PM Changeset in webkit [19838] by kdecker
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)


There were two problems here:


  • page/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said "if there is no text encoding name than assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
  • platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.
8:35 PM Changeset in webkit [22992] by andersca
  • 2 adds in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

<rdar://problem/4516049>
Basic Infrastructure: Get regression tests running.


Make boomer-run-webkit-tests work with our internal setup.


  • Scripts/boomer-run-webkit-tests:
6:55 PM Changeset in webkit [19837] by weinig
  • 4 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

Reviewed by Maciej.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted is empty, first delete the selection, and only then bail out.
6:52 PM Changeset in webkit [19836] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5001923>
REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

Fix an error that was introduced in revision r18541. We should check if the provisional document loader
has an unreachable URL, not the actual document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit):
6:35 PM Changeset in webkit [19835] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/selectstart-during-autoscroll-expected.txt: Added.
  • fast/events/selectstart-during-autoscroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/selectstart-during-autoscroll.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() -- which dispatches the selection DOM event and gives it a chance to cancel the selection -- before updating the selection during autoscroll.
6:22 PM Changeset in webkit [19834] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController endRevertingChange:moveLeft:]):
6:21 PM Changeset in webkit [22991] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543>
nike.com doesn't finish loading if Flash plugin is installed.


If a plugin requests a JavaScript URL with a non null frame target, execute the JavaScript expression. If the result
is not "undefined", replace the contents of the frame with the result converted to a string.

  • plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired):
5:25 PM Changeset in webkit [19833] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Correcting ChangeLog

5:22 PM Changeset in webkit [19832] by oliver
  • 2 edits
    1 add in trunk/WebCore

2007-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12870

It turns out short circuiting DragData::containsURL() was bad

  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/directory-drop-on-view.html: Added.
  • platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL):
2:35 PM Changeset in webkit [19831] by brmorris
  • 2 edits in S60/trunk/WebKit

forrest, reviewed by sachin

DESC: re-insert ability to handle EDoNothing case for disposition of downloaded content SXUU-6XZ232

11:13 AM Changeset in webkit [19830] by thatcher
  • 5 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5016395> _recursive_pauseNullEventsForAllNetscapePlugins still gone

  • WebView/WebFrameInternal.h: Remove _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFramePrivate.h: Add _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFrame.mm: More _recursive_pauseNullEventsForAllNetscapePlugins
8:43 AM Changeset in webkit [19829] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Added missing bug numbers.

8:32 AM Changeset in webkit [19828] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

  • 12.5% speedup on BenchJS test 6


It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
and calling visibleRect even more so. Take measures to call them less often.

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible. (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use documentVisibleRect when possible.
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect if we don't have a parent frame, since the ScrollView will do that anyway. Also, don't get contentX and contentY separately since they are in the viewRect already. (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each coordinate individually, to avoid calling documentVisibleRect repeatedly.
8:25 AM Changeset in webkit [19827] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • 2% speedup on BenchJS test 6
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Use format() instead of number() followed by append of a constant string.
7:34 AM Changeset in webkit [19826] by staikos
  • 2 edits in trunk/JavaScriptCore

add return values (!!)

7:26 AM Changeset in webkit [19825] by staikos
  • 2 edits in trunk/WebCore

Fix the Qt build.

7:08 AM Changeset in webkit [19824] by zack
  • 2 edits in trunk/WebKitQt

Adding a little bit of eye-candy to the last
commit (animations on hover events)

6:21 AM Changeset in webkit [19823] by zack
  • 7 edits in trunk/WebKitQt

Adding API and code for notification of when the
mouse is hovering over a link and adding code to
the sample app to showcase it.
r=Lars

Feb 22, 2007:

10:54 PM Changeset in webkit [22990] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

rs = adam


Replacing radar numbers from previous patch with one
the isn't fictitious <rdar://problem/5018591>

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor):
10:48 PM Changeset in webkit [19822] by kjk
  • 14 edits
    1 add in trunk/WebCore

Reviewed by Adam Roben, who never sleeps.

To avoid code duplication, move notImplementedGdk() macro to a separate
header file. Remove existing notImplementedGdk() macros and replace
remaining notImplemented() to notImplementedGdk() in gdk code.

  • loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView):
  • page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/EventHandlerGdk.cpp:
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
  • platform/gdk/EditorClientGdk.cpp:
  • platform/gdk/NotImplementedGdk.h: Added.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/RenderThemeGdk.cpp:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::drawPattern):
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
10:30 PM Changeset in webkit [22989] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.

Implemented a couple more cursor methods

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): Added radar bug reference <rdar://problem/5018452> (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::notAllowedCursor): Making them return the correct cursor


8:32 PM Changeset in webkit [19821] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12852
Bug#12852: Drosera should select function name, not "function" keyword when selecting from function list pop-up

  • Drosera/debugger.js: Fixed some logic errors resulting in generating double IDs and names.
7:48 PM Changeset in webkit [19820] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/events/remove-event-listener-expected.txt: Added.
  • fast/events/remove-event-listener.html: Added.

WebCore:

Reviewed by Maciej.

and

Problem: RemoveEventListener leaks memory if the listener is not
registered.
Fix: Added Window::findJSEventListener function w/o creating a
JSEventListener; Renamed getJSEventListener to findOrCreateJSEventListener;

As an enhancement, added a leak counter for EventListeners.

Added a test case, LayoutTests/fast/events/remove-event-listener.html.

  • WebCore/bindings/js/kjs_dom.cpp:
  • WebCore/bindings/js/kjs_window.h:
  • WebCore/bindings/js/kjs_window.cpp:
  • WebCore/bindings/js/kjs_event.cpp: Add a leak counter.
  • WebCore/bindings/js/JSXMLHttpRequest.cpp:
  • LayoutTests/fast/events/remove-event-listener.html:
7:38 PM Changeset in webkit [19819] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4998203>
REGRESSION: Back-forward list gets messed up when navigating to error pages with back-forward cache turned off


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove call to setPolicyDocumentLoader(), the policy document loader is set immediately after, and setting it before calling shouldReloadToHandleUnreachableURL causes us to get the wrong URL.


(WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
Check if the unreachable URL is equal to the document loader's request.


(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Check the provisional document loader's unreachable URL.

6:47 PM Changeset in webkit [22988] by oliver
  • 5 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Removing accessive COMPtr use from ClipboardWin constructors
Adding data verification to ClipoardWin::SetData
Small amount code tidying, and allowing for failure when writing an URL

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Updated for new ClipboardWin constructor
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::writeURL): (WebCore::ClipboardWin::getData): Tidying code, and allowing failure (WebCore::ClipboardWin::setData): Verifying that we're writing a valid url


  • platform/win/ClipboardWin.h:
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor
5:13 PM Changeset in webkit [19818] by bdash
  • 4 edits in trunk

Versioning.

4:35 PM Changeset in webkit [19817] by bdash
  • 4 edits in tags/Safari-5522

Versioning.

4:32 PM Changeset in webkit [19816] by bdash
  • 2 edits in tags/Safari-5522/WebCore

Merge in r19806.

2007-02-22 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.
4:29 PM Changeset in webkit [19815] by bdash
  • 3 edits in tags/Safari-5522/JavaScriptGlue

Merge in r19805.

2007-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
4:26 PM Changeset in webkit [19814] by bdash
  • 2 edits in tags/Safari-5522/WebCore

Merge in r19783.

2007-02-21 Brady Eidson <​beidson@apple.com>

Reviewed by Dave Harrison

<rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
after regaining network connection

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Leave an assertion for debug build exploration, but gracefully handle the release build case
4:21 PM Changeset in webkit [19813] by bdash
  • 1 copy in tags/Safari-5522

New tag.

4:12 PM Changeset in webkit [22987] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Updating this file to match WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
4:03 PM Changeset in webkit [19812] by adele
  • 3 edits in trunk/WebKit

Reviewed by John.

Updating this image to match the one in WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
3:59 PM Changeset in webkit [22986] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView.cpp: (WebView::handleContextMenuEvent): Clear the controller's context menu before propagating a new context menu event through the DOM.
3:51 PM Changeset in webkit [19811] by justing
  • 19 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

Added, tests the removal of the use of the
recalc bool from xPosForVerticalArrowNavigation(...):

  • editing/selection/5007143-2-expected.checksum: Added.
  • editing/selection/5007143-2-expected.png: Added.
  • editing/selection/5007143-2-expected.txt: Added.
  • editing/selection/5007143-2.html: Added. Added, demonstrate the changes to modify:
  • editing/selection/5007143-expected.checksum: Added.
  • editing/selection/5007143-expected.png: Added.
  • editing/selection/5007143-expected.txt: Added.
  • editing/selection/5007143.html: Added. Demonstrates a bug (filed 5017312):
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt: Fixed:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-011-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize m_xPosForVerticalArrowNavigation. (WebCore::SelectionController::setSelection): Call the new setter. (WebCore::SelectionController::modifyMovingRightForward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. Use the x position of the *start*, not the end of the selection if there is no saved xPosForVerticalArrowNavigation. This matches TextEdit's behavior. (WebCore::SelectionController::modifyMovingLeftBackward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. (WebCore::SelectionController::modify): Preserve the xPosForVerticalArrowNavigation for line and paragraph granularities. (WebCore::SelectionController::xPosForVerticalArrowNavigation): Removed the recalc bool because it is now always false. (WebCore::SelectionController::setXPosForVerticalArrowNavigation): Added.
  • editing/SelectionController.h: Moved m_xPosForVerticalArrowNavigation from Frame.
  • page/Frame.cpp: Moved m_xPosForVerticalArrowNavigation to SelectionController.
  • page/Frame.h: Ditto.
  • page/FramePrivate.h: Ditto.
3:49 PM Changeset in webkit [19810] by bdakin
  • 6 edits
    1 add in trunk

WebCore:

Reviewed by Adam. Manual test added.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

This problem appeared because of two facets of the current context
menu design. First, all context menu events are now considered to
be "swallowed" since we take care of building up the regular
context menu through the defaultEventHandler(). Second, the context
menu controller holds onto it's context menu until a new one is
created. There would be logistical problems changing this since
AppKit relies on the menu being around for as long as it is
visible on the screen and we don't get any notification once the
menu is popped-down.

This patch fixes the problem by giving WebKit a way to clear the
controller's context menu. WebKit now clears the menu before it
propagates a new context menu event through the DOM.

  • WebCore.exp:
  • manual-tests/DOMContextMenuEvent.html: Added.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::clearContextMenu):
  • page/ContextMenuController.h:

WebKit:

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Clear the controller's context menu before propagating a new context menu event through the DOM.
3:44 PM Changeset in webkit [22985] by oliver
  • 15 edits
    1 move
    4 adds in branches/WindowsMerge

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou, and Steve.

WebKit:

Last of the major changes for drag and drop

  • Move COMPtr.h to WebCore
  • Added WebDragSource, a modified version of SDataSource from the App that can notify a WebView's eventhandler of drag events
  • Implement the last bits of the DragClient
  • As part of drag client added code to draw the "doubled" text used by drag links. May be useful for other parts of WebKit/App


  • COMPtr.h: Removed. Moving to WebCore
  • WebDragClient.cpp: (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): (WebDragClient::dragSourceActionMaskForPoint): (WebDragClient::willPerformDragSourceAction):
Removing WebCore
as i'm now using the WebCore namespace (WebDragClient::startDrag): Implemented client method (allocImage): (dragLabelFont): Helper functions for generating the link dragging image (WebDragClient::createDragImageForLink): Implemented client method
  • WebDropSource.cpp: Added. (WebDropSource::createInstance): (WebDropSource::WebDropSource): (WebDropSource::QueryInterface): (WebDropSource::AddRef): (WebDropSource::Release): (generateMouseEvent): Generates a mouse event for the EventHandler (WebDropSource::QueryContinueDrag): (WebDropSource::GiveFeedback): Copied from SDataObject in the App. Minor changes per suggestions from Ada and Steve (error codes, potential leaks) Also includes logic to notify the source WebView of drag events (moving and drag end)
  • WebDropSource.h: Added. Header for the above
  • WebKit.vcproj/WebKit.vcproj: Removing COMPtr.h, and adding WebDropSource.{h,cpp}
  • WebKitGraphics.cpp: (DrawDoubledTextAtPoint): Utility function for drawing double text, as used by link dragging image
This resolves <rdar://problem/4821407> Cannot drag link to bookmarks bar to create new link <rdar://problem/4869496> User Interaction Essentials: Drag
  • WebCore.vcproj/WebCore.vcproj: Adding new files


  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize): Maximum size of drag image to allow sharp edges is 208x208


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Properly implemented now


  • platform/win/ClipboardWin.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::~ClipboardWin): (WebCore::writeURL): Helper function to write a url to a WCDataObject (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::setData): (WebCore::addMimeTypesForFormat): Helper function for ClipboardWin::types (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::setDragImage): (WebCore::ClipboardWin::setDragImageElement): General setters, match behaviour of WebKit/Mac (WebCore::ClipboardWin::createDragImage): Creates a drag image for a DOM specified Image is specified can't currently generate an image for an arbitrary element (WebCore::imageToMarkup): Wraps a url in an img tag (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Implement Clipboard required by DragController. Provides read/write DOM Clipboard implementation for dragging, read only when accessing system clipboard.


  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::dataObject): Provide an accessor for the dataObject


  • platform/win/DragDataWin.cpp: (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::DragData::asURL): (WebCore::getPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment): Refactoring and removing of a few static modifiers to allow sharing with Clipboard


  • platform/win/DragImageWin.cpp: (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::allocImage): (WebCore::createCgContextFromBitmap): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Implement DragImage functions


  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Creating a Clipboard that wraps the system clipboard


  • platform/win/PasteboardWin.cpp: (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNBSP): removing 'static'


  • platform/win/WCDataObject.cpp: Added. (WebCore::WCEnumFormatEtc::WCEnumFormatEtc): (WebCore::WCEnumFormatEtc::QueryInterface): (WebCore::WCEnumFormatEtc::AddRef): (WebCore::WCEnumFormatEtc::Release): (WebCore::WCEnumFormatEtc::Next): (WebCore::WCEnumFormatEtc::Skip): (WebCore::WCEnumFormatEtc::Reset): (WebCore::WCEnumFormatEtc::Clone): (WebCore::WCDataObject::createInstance): (WebCore::WCDataObject::WCDataObject): (WebCore::WCDataObject::~WCDataObject): (WebCore::WCDataObject::QueryInterface): (WebCore::WCDataObject::AddRef): (WebCore::WCDataObject::Release): (WebCore::WCDataObject::GetData): (WebCore::WCDataObject::GetDataHere): (WebCore::WCDataObject::QueryGetData): (WebCore::WCDataObject::GetCanonicalFormatEtc): (WebCore::WCDataObject::SetData): (WebCore::WCDataObject::CopyMedium): (WebCore::WCDataObject::EnumFormatEtc): (WebCore::WCDataObject::DAdvise): (WebCore::WCDataObject::DUnadvise): (WebCore::WCDataObject::EnumDAdvise): (WebCore::WCDataObject::clearData): Copied from SDataObject in the App createInstance and clearData are the only new functions. clearData removes any entries in the object with a specified CLIPFORMAT. Have also made a few error and memory handling changes suggested by Steve and Ada
  • platform/win/WCDataObject.h: Added. Header for the above


3:42 PM Changeset in webkit [19809] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Kevin and Adele


  • fixed <rdar://problem/4129417> Need final art for textarea's resize corner


This probably broke some layout pixel tests since the image changed. I'm going to
track those down in a moment (non-trivial since there are a bunch failing for other
reasons).

  • Resources/textAreaResizeCorner.tiff: new art
  • Resources/deleteButton.tiff:
  • Resources/deleteButtonPressed.tiff: these got smaller when I ran compress-tiffs on this directory
3:40 PM Changeset in webkit [19808] by oliver
  • 7 edits in trunk/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou and Steve.

Moving basic components of ClipboardMac to Clipboard,
last of the basic common code merge will come later (namely setting the
drag element/image).


Tidying up in DragController including a few bad PassRefPtr uses and
removing unnecessary accessors. Also initialise fields properly to
fix <rdar:/problems/5014889>

  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): New constructor


  • dom/Clipboard.h: (WebCore::Clipboard::isForDragging): (WebCore::Clipboard::dragLocation): (WebCore::Clipboard::dragImage): (WebCore::Clipboard::dragImageElement): Exposing common data


  • page/DragController.cpp: (WebCore::DragController::DragController): Initialise m_isHandlingDrag (oops) (WebCore::documentFragmentFromDragData): (WebCore::DragController::tryDocumentDrag): Fixing PassRefPtr misuse (WebCore::DragController::canProcessDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doSystemDrag): Make sure we're using the correct coordinate space


  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Reset drag source correctly


  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): update constructor to use new Clipboard constructor
3:07 PM Changeset in webkit [22984] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Make sure we always paint the right size search results icon.

3:02 PM Changeset in webkit [22983] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:00 PM Changeset in webkit [19807] by sfalken
  • 1 copy in tags/Safari-521.35.2b

New tag.

2:20 PM Changeset in webkit [19806] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • fast/events/keypress-insert-tab-expected.txt: Added.
  • fast/events/keypress-insert-tab.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.

WebKitTools:

Reviewed by Darin.

Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2:10 PM Changeset in webkit [19805] by ggaren
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
1:55 PM Changeset in webkit [19804] by brmorris
  • 4 edits in S60/trunk/WebKit

naguo, reviewed by sachin

DESC: Open while downloading UI setting functionality is not working correctly SCHY-6YFQ66
​http://bugs.webkit.org/show_bug.cgi?id=12846

1:25 PM Changeset in webkit [19803] by brmorris
  • 2 edits in S60/trunk/WebCore

hongzhao, reviewed by Zalan, merged by mbradley++

DESC: merge of r19802 to s60 trunk. Cache memory collector is not initialized in 3.2 HZHO-6YMQCK
Fix: Initialize the initial size of cache memory collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

1:22 PM Changeset in webkit [19802] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

hongzhao, Reviewed by Zalan

DESC: [S60] Cache memory collector is not initialized in 3.1m HZHO-6YMQCK
Fix: Initialze the initial size of cache mem collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

1:16 PM Changeset in webkit [19801] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen by yongjun

DESC: Merge of r19655 to s60/3.1m. Selection list not shown correctly in www.elisa.fi HMNN-6XQJMX
​http://bugs.webkit.org/show_bug.cgi?id=12719

1:00 PM Changeset in webkit [19800] by thatcher
  • 8 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard

  • bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
  • bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
  • dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
  • html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.
12:50 PM Changeset in webkit [19799] by adele
  • 2 edits in trunk/WebCore

Reviewed by John.

Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.
12:19 PM Changeset in webkit [19798] by ggaren
  • 87 edits in trunk

LayoutTests:

Used svn merge -r19786:19785 to roll out previous SVG results produced by
hack to work around SVG painting issue in DRT.


The new work-around preserves the old SVG results -- both text and pixel.
This should fix the ~400 new pixel failures introduced in r19786.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/carto.net/button-expected.txt:
  • svg/carto.net/colourpicker-expected.txt:
  • svg/carto.net/combobox-expected.txt:
  • svg/carto.net/scrollbar-expected.txt:
  • svg/carto.net/selectionlist-expected.txt:
  • svg/carto.net/slider-expected.txt:
  • svg/carto.net/tabgroup-expected.txt:
  • svg/carto.net/textbox-expected.txt:
  • svg/carto.net/window-expected.txt:
  • svg/custom/gradient-stop-style-change-expected.txt:
  • svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • svg/custom/js-late-clipPath-creation-expected.txt:
  • svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-text-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/text-repaint-including-stroke-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-on-text-expected.txt:

WebKitTools:

Used svn merge -r19786:19785 to roll out previous hack to work around
SVG painting issue in DRT.


Implemented new work-around, which makes --paint paint *after* dumping
the render tree instead of before, so that painting doesn't influence
the SVG render tree.

This should fix the ~400 new pixel failures introduced in r19786.

  • DumpRenderTree/DumpRenderTree.m: (dump):
  • Scripts/run-webkit-tests:
11:57 AM Changeset in webkit [19797] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


  • fast/forms/select-initial-position-expected.checksum: Added.
  • fast/forms/select-initial-position-expected.png: Added.
  • fast/forms/select-initial-position-expected.txt: Added.
  • fast/forms/select-initial-position.html: Added.

WebCore:

Reviewed by Darin.


Initiate scroll when selected <option> is added to <select>.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoDocument):
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::scrollToSelection):
  • html/HTMLSelectElement.h:
11:32 AM Changeset in webkit [19796] by zack
  • 2 edits in trunk/WebCore

Fix sites with fixed positioned backgrounds. (my blog =) )
r=Lars,George

11:18 AM Changeset in webkit [19795] by ggaren
  • 2 edits in trunk/WebKitTools

Resetting --leaks mode default to run 1000 tests at a time because setting it
to 750 didn't stop the stack logging related crashes, and running more tests
at a time is faster. The crashes seem to be a real bug in stack logging,
not an out of memory condition.

  • Scripts/run-webkit-tests:
9:38 AM Changeset in webkit [19794] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


Removed some unused keyView-related code that I happened to run across.
Replacement code is now in WebChromeClient.

  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.mm: removed unused stuff
8:52 AM Changeset in webkit [19793] by zack
  • 4 edits in trunk/WebKitQt

Fixing the default scroll offset, cleaning
up private methods and making the default
look not use any frames.
r=Lars

8:17 AM Changeset in webkit [19792] by zack
  • 9 edits
    2 deletes in trunk

Properly implement canvas/scrollview's. Get
rid of ScrollViewCanvasQt and replace it with
a tailor abstractscrollview (now in qwebframe).
Scrolling of pages is finally completely smooth :)
r=Lars

7:59 AM Changeset in webkit [19791] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fix ARM-specific alignment problem in FastMalloc
​http://bugs.webkit.org/show_bug.cgi?id=12841

  • wtf/FastMalloc.cpp: Modify how pageheap_memory is declared to ensure proper alignment on architectures such as ARM
7:45 AM Changeset in webkit [19790] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

This patch also fixes a bug where using the arrow keys while
the suggestion popup is open moves the caret instead of changing the
selection in the popup (for up/down) or accepting the selection and
closing the popup (for left/right).

  • WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Changed to close the popup only if it was open before the current event, so that the Option-Esc that opens the popup will not close it immediately. (-[WebHTMLView _interceptEditingKeyEvent:]): Give the completion popup a chance to intercept keydown events. (-[WebTextCompleteController popupWindowIsOpen]): Added. Returns whether the suggestion popup is open.
7:34 AM Changeset in webkit [19789] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Mark (age 21).

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow SPI that forces the scroll bar to look active. Also replaced a call to the deprecated NSTableView method setAutoresizesAllColumnsToFit: with the new method setColumnAutoresizingStyle: to eliminate console spew.
Note: See TracTimeline for information about the timeline view.