Context Navigation

In bidi.cpp, some functions allocate BidiRuns and put them in a global data
structure, while others uses the BidiRuns in the global data structure.
The caller is responsible for knowing which functions may allocate runs
and which may use them, and calling deleteBidiRuns() at the appropriate time.

The fix is to add some calls to deleteBidiRuns() where they were missing.

I also added a BidiRun counter because these two leaks were introduced by
our two bidi.cpp experts, so the odds that leaks will creep in again
in the future seem pretty high.

rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added missing call to deleteBidiRuns(). (WebCore::BidiRunCounter::~BidiRunCounter): (WebCore::BidiRun::operator delete): (WebCore::RenderBlock::layoutInlineChildren): Added missing call to deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to bidiReorderLine(), to emphasize that they go together like new/delete. In theory, the old code was just as good, but I didn't want to rely on theory.

WebKitTools:

Reviewed by Darin Adler.

Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're fixed.

6:35 AM Changeset in webkit [19842] by harrison

2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/4961431> Image with empty string alt tag should be ignored

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Ignore img element that has an alt attribute, but that string is empty.

5:14 AM Changeset in webkit [19841] by zack

2 edits in trunk/WebKitQt

Adjust the animation a little bit to make it more natural.

3:14 AM Changeset in webkit [19840] by ap

4 edits in trunk/LayoutTests

Reviewed by Anders.

Fix the test not to include any custom content in its auto-generated HTML wrapper.

fast/js/resources/select-options-add.js:
fast/js/select-options-add-expected.txt:
fast/js/select-options-add.html:

12:45 AM Changeset in webkit [19839] by kjk

6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Gdk improvements.

platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup. (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
platform/network/gdk/ResourceHandleManager.cpp: don't free memory that doesn't belong to us. (WebCore::ResourceHandleManager::downloadTimerCallback):

WebKitTools:

Reviewed by Adam Roben.

Improve gdklauncher: add text field for entering url.

GdkLauncher/gdklauncher.bkl:
GdkLauncher/main.cpp: (strEmpty): (strEq): (handleGdkEvent): (goToUrlBarText): (goButtonClickedCb): (urlBarEnterCb): (registerRenderingAreaEvents): (frameResizeCb): (frameDestroyCb): (main):

Feb 23, 2007:

11:42 PM Changeset in webkit [19838] by kdecker

3 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)

There were two problems here:

page/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said "if there is no text encoding name than assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.

8:35 PM Changeset in webkit [22992] by andersca

2 adds in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

<rdar://problem/4516049>
Basic Infrastructure: Get regression tests running.

Make boomer-run-webkit-tests work with our internal setup.

Scripts/boomer-run-webkit-tests:

6:55 PM Changeset in webkit [19837] by weinig

4 edits in trunk

LayoutTests:

Reviewed by Maciej.

updated test result for http://bugs.webkit.org/show_bug.cgi?id=12856 REGRESSION (r13685): Canceling the suggestion popup does not revert the change

editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=12856 REGRESSION (r13685): Canceling the suggestion popup does not revert the change

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted is empty, first delete the selection, and only then bail out.

6:52 PM Changeset in webkit [19836] by andersca

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5001923>
REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

Fix an error that was introduced in revision r18541. We should check if the provisional document loader
has an unreachable URL, not the actual document loader.

loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit):

6:35 PM Changeset in webkit [19835] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=12823 REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event

fast/events/selectstart-during-autoscroll-expected.txt: Added.
fast/events/selectstart-during-autoscroll.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=12823 REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event

Test: fast/events/selectstart-during-autoscroll.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() -- which dispatches the selection DOM event and gives it a chance to cancel the selection -- before updating the selection during autoscroll.

6:22 PM Changeset in webkit [19834] by weinig

2 edits in trunk/WebKit

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=11573 REGRESSION: pressing option-left arrow while in suggestion popup moves the insertion point to the left

WebView/WebHTMLView.mm: (-[WebTextCompleteController endRevertingChange:moveLeft:]):

6:21 PM Changeset in webkit [22991] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543>
nike.com doesn't finish loading if Flash plugin is installed.

If a plugin requests a JavaScript URL with a non null frame target, execute the JavaScript expression. If the result
is not "undefined", replace the contents of the frame with the result converted to a string.

plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired):

5:25 PM Changeset in webkit [19833] by oliver

1 edit in trunk/WebCore/ChangeLog

Correcting ChangeLog

5:22 PM Changeset in webkit [19832] by oliver

2 edits
1 add in trunk/WebCore

2007-02-23 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=12870

It turns out short circuiting DragData::containsURL() was bad

ChangeLog:
WebCore.xcodeproj/project.pbxproj:
manual-tests/directory-drop-on-view.html: Added.
platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL):

2:35 PM Changeset in webkit [19831] by brmorris

2 edits in S60/trunk/WebKit

forrest, reviewed by sachin

DESC: re-insert ability to handle EDoNothing case for disposition of downloaded content SXUU-6XZ232

11:13 AM Changeset in webkit [19830] by thatcher

5 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5016395> _recursive_pauseNullEventsForAllNetscapePlugins still gone

WebView/WebFrameInternal.h: Remove _recursive_pauseNullEventsForAllNetscapePlugins
WebView/WebFramePrivate.h: Add _recursive_pauseNullEventsForAllNetscapePlugins
WebView/WebFrame.mm: More _recursive_pauseNullEventsForAllNetscapePlugins

8:43 AM Changeset in webkit [19829] by mjs

1 edit in trunk/WebCore/ChangeLog

Added missing bug numbers.

8:32 AM Changeset in webkit [19828] by mjs

3 edits in trunk/WebCore

Reviewed by Mitz.

12.5% speedup on BenchJS test 6

It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
and calling visibleRect even more so. Take measures to call them less often.

platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible. (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use documentVisibleRect when possible.
rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect if we don't have a parent frame, since the ScrollView will do that anyway. Also, don't get contentX and contentY separately since they are in the viewRect already. (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each coordinate individually, to avoid calling documentVisibleRect repeatedly.

8:25 AM Changeset in webkit [19827] by mjs