⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 25, 2007:

9:31 PM Changeset in webkit [19852] by bdash
  • 3 edits
    4 adds in trunk

2007-02-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by David Hyatt.

Test: fast/dynamic/float-withdrawal.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Detect when a child block had intruding floats in a previous layout, and in that case force it to relayout.

2007-02-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by David Hyatt.

  • fast/dynamic/float-withdrawal-expected.checksum: Added.
  • fast/dynamic/float-withdrawal-expected.png: Added.
  • fast/dynamic/float-withdrawal-expected.txt: Added.
  • fast/dynamic/float-withdrawal.html: Added.
7:00 PM Changeset in webkit [19851] by hyatt
  • 3 edits in trunk/WebCore

Revert my change to the default fill color. Just set the color to transparent explicitly when
drawing textarea resizer frames.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):
6:28 PM Changeset in webkit [19850] by weinig
  • 2 edits in trunk/WebCore

Update forgotten files.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
6:07 PM Changeset in webkit [19849] by hyatt
  • 1 edit in trunk/WebCore/page/FrameView.cpp

Forgot to land FrameView.cpp in previous commit.

5:29 PM Changeset in webkit [19848] by hyatt
  • 5 edits in trunk/WebCore

Fix for regression caused by changing the containing block of positioned elements with no positioned ancestor
to be the initial containing block (represented in our tree by the RenderView). Rework RenderView's layout
to have very few special cases. Now it will just relayout its children when the width/height of the
view actually changes. Positioned elements no longer get a special additional layout, since width/height
adjustments are caught by the base class already anyway.

Reviewed by mjs, darin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::layout):
  • rendering/RenderView.h:
4:47 PM Changeset in webkit [22996] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • fixed layout test failure in fast/overflow/scrollRevealButton


I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrolView::fullyClippedContentRect):
4:41 PM Changeset in webkit [19847] by mjs
  • 3 edits in trunk/WebCore

Not reviewed, build fix.

  • fix build breakage
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::fullyClippedContentRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::fullyClippedContentRect):
3:44 PM Changeset in webkit [19846] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Adam.

  • fixed layout test failure in fast/overflow/scrollRevealButton


I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

  • page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setIsActive): (WebCore::Frame::markAllMatchesForText):
  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrolView::fullyClippedContentRect):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::fullyClippedContentRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrolView::fullyClippedContentRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
2:23 PM Changeset in webkit [19845] by andersca
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej.

  • building/checkout.html: Add Trac link to our SVN repository,

Feb 24, 2007:

11:20 PM Changeset in webkit [22995] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Change #if to #ifdef to match style.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
11:14 PM Changeset in webkit [22994] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix <rdar://problem/5013502> REGRESSION: <select> menus are not
animating smoothly

This was caused by making the menus partially transparent in r12250.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Disable animations.
11:12 PM Changeset in webkit [19844] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Steve.

"Look Up in Dictionary" context menu item should be Mac-only for now,
since it's only implemented on that platform (<rdar://problem/5021468>)

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Wrap all instances of the dictionary menu item in #if PLATFORM(MAC).
8:35 PM Changeset in webkit [22993] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-24 Steve Falkenburg <​sfalken@apple.com>

Pre-emptive build fix.
Removed CGPThreads DLL copy

  • WebKit.vcproj/WebKit.vcproj:
6:14 PM Changeset in webkit [19843] by ggaren
  • 5 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin Adler.


Layout tests for BidiRun leaks.


  • fast/leaks/001-expected.txt: Added.
  • fast/leaks/001.html: Added.
  • fast/leaks/002-expected.txt: Added.
  • fast/leaks/002.html: Added.

WebCore:

Reviewed by Darin Adler.


Fixed <rdar://problem/4987649> leaks in BidiRun::operator new seen while
running WebKit unit tests


In bidi.cpp, some functions allocate BidiRuns and put them in a global data
structure, while others uses the BidiRuns in the global data structure.
The caller is responsible for knowing which functions may allocate runs
and which may use them, and calling deleteBidiRuns() at the appropriate time.

The fix is to add some calls to deleteBidiRuns() where they were missing.


I also added a BidiRun counter because these two leaks were introduced by
our two bidi.cpp experts, so the odds that leaks will creep in again
in the future seem pretty high.

  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added missing call to deleteBidiRuns(). (WebCore::BidiRunCounter::~BidiRunCounter): (WebCore::BidiRun::operator delete): (WebCore::RenderBlock::layoutInlineChildren): Added missing call to deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to bidiReorderLine(), to emphasize that they go together like new/delete. In theory, the old code was just as good, but I didn't want to rely on theory.

WebKitTools:

Reviewed by Darin Adler.


  • Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're fixed.
6:35 AM Changeset in webkit [19842] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/4961431> Image with empty string alt tag should be ignored

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Ignore img element that has an alt attribute, but that string is empty.
5:14 AM Changeset in webkit [19841] by zack
  • 2 edits in trunk/WebKitQt

Adjust the animation a little bit to make it more natural.

3:14 AM Changeset in webkit [19840] by ap
  • 4 edits in trunk/LayoutTests

Reviewed by Anders.

Fix the test not to include any custom content in its auto-generated HTML wrapper.

  • fast/js/resources/select-options-add.js:
  • fast/js/select-options-add-expected.txt:
  • fast/js/select-options-add.html:
12:45 AM Changeset in webkit [19839] by kjk
  • 6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Gdk improvements.

  • platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup. (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
  • platform/network/gdk/ResourceHandleManager.cpp: don't free memory that doesn't belong to us. (WebCore::ResourceHandleManager::downloadTimerCallback):

WebKitTools:

Reviewed by Adam Roben.

Improve gdklauncher: add text field for entering url.

  • GdkLauncher/gdklauncher.bkl:
  • GdkLauncher/main.cpp: (strEmpty): (strEq): (handleGdkEvent): (goToUrlBarText): (goButtonClickedCb): (urlBarEnterCb): (registerRenderingAreaEvents): (frameResizeCb): (frameDestroyCb): (main):
Note: See TracTimeline for information about the timeline view.