Timeline

Mar 4, 2007:

10:18 PM Changeset in webkit [19959] by ap

• 2 edits in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12961
shouldBe() should support NaN

• fast/js/resources/js-test-pre.js: Make shouldBe() succeed if both sides are NaN numbers.

9:40 PM Changeset in webkit [19958] by adele

• 4 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

• fast/events/keydown-keypress-preventDefault-expected.txt: Added.
• fast/events/keydown-keypress-preventDefault.html: Added.

WebCore:

Reviewed by Darin.

Change to dispatch the keypress event during the defaultEventHandler for keydown events. This matches IE behavior.
This is preparation for fixing event dispatch with input methods (​http://bugs.webkit.org/show_bug.cgi?id=10871)

Test: fast/events/keydown-keypress-preventDefault.html

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Call the defaultKeyboardEventHandler for keydown events.
• page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): Return 0 instead of false since the return type in EventTargetNode. (WebCore::EventHandler::keyEvent): Removed dispatch of keypress event, since this is now done in the default event handler. (WebCore::EventHandler::defaultKeyboardEventHandler): For keydown events, create and dispatch a keypress event.

9:34 PM Changeset in webkit [19957] by ap

• 3 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann (yay!).

​http://bugs.webkit.org/show_bug.cgi?id=12962
4XPath tests crash on lang() function

Covered by 4XPath tests, to be landed later.

• platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind): Do not crash with empty strings.
• xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::doEvaluate): Do not crash when an element has no attributes. Use a proper namespace for xml:lang (not sure where "xms" came from). Rewrote the algorithm for suffix removing to match the spec.

5:33 PM Changeset in webkit [19956] by ddkilzer

• 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Nikolas Zimmermann.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12950 Assertions.cpp should not #define macros that are already defined

• wtf/Assertions.cpp: Don't #define WINVER and _WIN32_WINNT if they are already defined.

3:30 PM Changeset in webkit [19955] by andersca

• 6 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5028165>
​http://bugs.webkit.org/show_bug.cgi?id=12915
REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)

• http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
• http/tests/xmlhttprequest/abort-should-cancel-load.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5028165>
​http://bugs.webkit.org/show_bug.cgi?id=12915
REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)

• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading): Save the value of m_loading since calling FrameLoader::stopLoading could set it to false.

• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didCancel):
• loader/SubresourceLoader.h: Get rid of didCancel now, it's not needed anymore.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): Call cancel() instead of stopLoading(). Also, set m_aborted to true so the XMLHttpRequest object won't be dereferenced in didFail when aborting.

1:24 PM Changeset in webkit [19954] by kjk

• 6 edits in trunk

WebCore:

Reviewed by Nikolas Zimmermann.

Move ScrollView stubs to ScrollViewGdk.cpp

• platform/gdk/FrameGdk.h: remove comment that no longer makes sense
• platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
• platform/gdk/TemporaryLinkStubs.cpp:

WebKitTools:

Reviewed by Nikolas Zimmermann.

Load a url given on a command line in a way that also
works for local (​file://) urls.

• GdkLauncher/main.cpp: (main):

7:47 AM Changeset in webkit [19953] by ddkilzer

• 1 edit
  2 moves in trunk/LayoutTests

LayoutTests:

Reviewed by Nikolas Zimmermann.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12951 REGRESSION (r19949): LayoutTests/fast/xsl/xslt-processer.html fails

Fixed spelling of "processer" to "processor" in file names.

• fast/xsl/xslt-processer-expected.txt: Removed.
• fast/xsl/xslt-processer.html: Removed.
• fast/xsl/xslt-processor-expected.txt: Added. Results progressed after fixing Bugzilla Bug 12735 (<rdar://problem/4545040>).
• fast/xsl/xslt-processor.html: Added.