⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 9, 2007:

7:23 PM Changeset in webkit [23055] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by John.

Fix the doubled text in the image used to drag a link

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawDoubledTextAtPoint):


5:06 PM Changeset in webkit [23054] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Implement setting the suggested filename for a response.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::filenameFromHTTPContentDisposition): (WebCore::filenameHasSaneExtension): (WebCore::suggestedFilenameForResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/win/MimeTypeRegistryWin.cpp: (WebCore::getMIMETypeForUTI):


(WebCore::mimeTypeForExtension):
Fix two bugs in this function.


(WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):

WebKitWin:

Reviewed by Adam.

  • WebURLResponse.cpp: (WebURLResponse::suggestedFilename): Get the suggested filename from the ResourceResponse object.
4:41 PM Changeset in webkit [20095] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Force diff to treat files that svn-create-patch thinks are text as text.

  • Scripts/svn-create-patch: Added -a switch to diff command.
4:07 PM Changeset in webkit [23053] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Adam.

Fix build and do some general cleanup.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runBeforeUnloadConfirmPanelWithMessage): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction): (WaitUntilDoneDelegate::contextMenuItemSelected): (WaitUntilDoneDelegate::trackCustomPopupMenu): (WaitUntilDoneDelegate::measureCustomMenuItem): (WaitUntilDoneDelegate::drawCustomMenuItem): (WaitUntilDoneDelegate::cleanUpCustomMenuDrawingData): (WaitUntilDoneDelegate::canTakeFocus): (WaitUntilDoneDelegate::takeFocus): (WaitUntilDoneDelegate::registerUndoWithTarget): (WaitUntilDoneDelegate::removeAllActionsWithTarget): (WaitUntilDoneDelegate::setActionTitle): (WaitUntilDoneDelegate::undo): (WaitUntilDoneDelegate::redo): (WaitUntilDoneDelegate::canUndo): (WaitUntilDoneDelegate::canRedo): (WaitUntilDoneDelegate::addCustomMenuDrawingData):
2:58 PM Changeset in webkit [20094] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4976254> Please get off _NSSoftLinkingGetFrameworkFuncPtr

Use dlopen and dlsym to access the DCSShowDictionaryServiceWindow function.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
12:02 PM Changeset in webkit [23052] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Steve.

B&I build fix.

  • WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
11:45 AM Changeset in webkit [20093] by darin
  • 2 edits in trunk/WebKitSite
  • blog/wp-content/themes/webkit/style.css: Removed rule for code since we want it to match pre, and the default font looks fine -- no need to ask for "Courier New" explicitly.
10:54 AM Changeset in webkit [20092] by darin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/paste-xml-expected.checksum: Added.
  • editing/pasteboard/paste-xml-expected.png: Added.
  • editing/pasteboard/paste-xml-expected.txt: Added.
  • editing/pasteboard/paste-xml.xhtml: Added.

WebCore:

Reviewed by Justin.

Test: editing/pasteboard/paste-xml.xhtml

  • editing/markup.cpp: (WebCore::createFragmentFromMarkup): Added a check for 0 here, since createContextualFragment can return 0 for XML documents that fail to parse. In my testing, callers all seem equipped to handle 0.

WebKit:

Reviewed by Justin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _hasHTMLDocument]): Added. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Don't call AppKit's conversion from the DOM to an attributed string if the document is not an HTML document, to work around an AppKit limitation (Radar 5052390).
8:32 AM Changeset in webkit [23051] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Fixup comments and remove an obsolete FIXME.
8:19 AM Changeset in webkit [20091] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
8:05 AM Changeset in webkit [20090] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • http/tests/misc/onload-remove-iframe-crash-2-expected.txt: Added.
  • http/tests/misc/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe.html: Added.

WebCore:

Reviewed by Darin.

Test: http/tests/misc/onload-remove-iframe-crash-2.html

The resulted from an iframe's load event handler removing the iframe
from the document.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Bail out early if an event handler removed the frame.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): Protect the frame from deletion by event handlers. (WebCore::FrameLoader::checkCompletedTimerFired): (WebCore::FrameLoader::scheduleCheckCompleted): (WebCore::FrameLoader::detachFromParent): Schedule a completion check on the parent (in case the child is what has been keeping it from completing).
  • loader/FrameLoader.h:
4:35 AM Changeset in webkit [20089] by rwlbuis
  • 1 edit in trunk/WebCore/ChangeLog

I forgot to commit my ChangeLog as part of r20028, sorry about that.

2:00 AM Changeset in webkit [20088] by bdash
  • 3 edits
    2 deletes in trunk

Roll out r20078 as it's causing a crash during layout tests.

1:23 AM Changeset in webkit [23050] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

1:20 AM Changeset in webkit [20087] by sfalken
  • 1 copy in tags/Safari-521.35.7b

New tag.

1:08 AM Changeset in webkit [23049] by oliver
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Forgot to save changelog with reviewer name, correcting

1:01 AM Changeset in webkit [23048] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Steve.

Executing a script for a plugin can cause cause this to be deleted
so we take a reference to our parent prior to executing the script

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

Mar 8, 2007:

11:59 PM Changeset in webkit [23047] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Oliver Hunt <​oliver@apple.com>

WebCoreWin:

Allow webloc files to be dropped onto the webview


<rdar://problem/4883564> Regression: cannot open webloc file by dnd to Boomer's window

  • platform/win/DragDataWin.cpp: (WebCore::cfHDropFormat):

Clipboard format for HDROP, non-static as i will need it elsewhere in the future

(WebCore::getWebLocData):

Extract a url from a webloc file

(WebCore::getURL):

Call getWebLocData


11:20 PM Changeset in webkit [23046] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Steve Falkenburg <​sfalken@apple.com>

Fix B&I build more

  • WebCore.vcproj/WebCore.vcproj:
10:23 PM Changeset in webkit [20086] by bdash
  • 4 edits in tags/Safari-4522.4

Versioning.

10:18 PM Changeset in webkit [20085] by bdash
  • 1 copy in tags/Safari-4522.4

New tag.

10:05 PM Changeset in webkit [20084] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Beth.

No tests added since LayoutTests/fast/forms/document-write.html was timing out
and causing a layout test failure.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Removed stray code.
9:52 PM Changeset in webkit [23045] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
8:55 PM Changeset in webkit [20083] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex): add empty stub
8:23 PM Changeset in webkit [20082] by bdash
  • 2 edits in trunk/WebKit

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5051616> Mouse clicks and movement are ignored in HIWebView on 64-bit

Mouse events are not being handled correctly as GetControlKind is returning an error
on 64-bit. The more modern HIObjectIsOfClass behaves correctly for this use.

  • Carbon/HIWebView.m: (HIWebViewDestructor): (WindowHandler): Use HIObjectIsOfClass in place of GetControlKind. (HIWebViewEventHandler): Don't leak the NSEvent.
8:06 PM Changeset in webkit [20081] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-09 Mark Rowe <​mrowe@apple.com>

Unreviewed. Use the new SVN URL on the buildbot.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
7:57 PM Changeset in webkit [20080] by bdash
  • 1 edit
    1 add in trunk/WebKitSite

2007-03-09 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Tim Hatcher.

Sexy blog permalinks!

  • blog/.htaccess: Added.
7:11 PM Changeset in webkit [20079] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-08 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13018
Bug 13018: allow embedders to override the definition of CRASH.

  • wtf/Assertions.h: make it possible to override CRASH.
7:08 PM Changeset in webkit [20078] by bdash
  • 3 edits
    2 adds in trunk

2007-03-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Brady.

Test: fast/loader/onunload-form-submit-crash-2.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): Added null check.

2007-03-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Brady.

  • fast/loader/onunload-form-submit-crash-2-expected.txt: Added.
  • fast/loader/onunload-form-submit-crash-2.html: Added.
7:02 PM Changeset in webkit [20077] by bdash
  • 2 edits in trunk/WebKit

2007-03-08 Bruce Q Hammond <​bruceq@apple.om>

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13009
Console spews "CGContextGetType: invalid context" non-stop on web site

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
6:37 PM Changeset in webkit [20076] by bdash
  • 2 edits in trunk/WebKitSite

2007-03-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Adam.

  • building/checkout.html: Update repository URL.
6:37 PM Changeset in webkit [20075] by justing
  • 31 edits in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4903193>
On particular page, Copy is so slow it seems like a hang

Less messy DOM trees:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.txt:
  • editing/pasteboard/testcase-9507-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • fast/lists/drag-into-marker-expected.txt: Styles from style sheets are now inlined:
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-link-href-expected.txt:\ Two levels of nesting are removed, but text nodes are no longer coalesced when they should be, investigating:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4903193>
On particular page, Copy is so slow it seems like a hang


~2x speedup copying:
​http://shakespeare.mit.edu/henryviii/full.html
Also produces less bloated markup.

  • editing/markup.cpp: (WebCore::startMarkup): Don't wrap text nodes in style spans. For Elements, don't inline styles inherited from ancestors. (WebCore::createMarkup): No longer necessary to find the root's default style and pass it to startMarkup. Add a wrapper span around the markup with the styles that all nodes in the markup inherit (the inheritable styles from the common ancestor container's computed style). Added a FIXME about unecessary markup for inline ancestors up to the commonAncestorBlock.
6:25 PM Changeset in webkit [20074] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adele.

  • <rdar://problem/4470381> multipart/form-data boundary security vulnerability

By making the form data boundary a string with some random data in it, we reduce
the possibility that anyone could take advantage of it by creating a file that
intentionally has the boundary string in it.

  • html/HTMLFormElement.h: Removed boundary(), setBoundary(), and m_boundary. Marked a lot more stuff private.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Removed code to initialize m_boundary. (WebCore::randomNumber): Added. Function that returns a random number, including seeding the random number generator the first time it's called. For now, usees the more random function random() on Mac OS X and the more-standard rand() on other platforms. (WebCore::HTMLFormElement::formData): Take a parameter with the form boundary string, and use that instead of m_boundary. (WebCore::getUniqueBoundaryString): Added. Makes a boundary string using random numbers and base 64 encoding. (WebCore::HTMLFormElement::submit): Call getUniqueBoundaryString and pass the boundary string into formData for multipart form posts.
6:15 PM Changeset in webkit [20073] by bdash
  • 7 edits
    1 delete in trunk/WebKit

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/4561772> HIWebView does not exist for 64-bit

Update HIWebView and friends to work without QuickDraw.

Changes are gleaned from the 64-bit support inside HICocoaView. The main
fact of interest are that all Carbon windows must have compositing enabled
so the code paths that aren't accessible are #ifdef'd out. Conveniently
these are the exact code paths that make use of QuickDraw.

There are currently minor event-handling and invalidation issues running as
64-bit that are not present in 32-bit.

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (Click): (SyncFrame): (StartUpdateObserver): (StopUpdateObserver): (UpdateObserver):
  • WebKit.LP64.exp: Removed.
  • WebKit.xcodeproj/project.pbxproj: Always use WebKit.exp.
6:12 PM Changeset in webkit [20072] by mjs
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
​http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents, these test cases cover every focus call I could find.


  • fast/forms/focus-selection-input-expected.txt: Added.
  • fast/forms/focus-selection-input.html: Added.
  • fast/forms/focus-selection-textarea-expected.txt: Added.
  • fast/forms/focus-selection-textarea.html: Added.
  • fast/forms/onselect-textfield-expected.txt:

WebCore:

Reviewed by Adele.


<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
​http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents.


Tests:
fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html


  • dom/Element.cpp: (WebCore::Element::focus):
  • dom/Element.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::accessKeyAction):
  • html/HTMLInputElement.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::focus): (WebCore::HTMLLabelElement::accessKeyAction):
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::focus):
  • html/HTMLLegendElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus):
  • html/HTMLTextAreaElement.h:
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
4:33 PM Changeset in webkit [20071] by justing
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=12244>
FCKeditor: Find dialog doesn't work

  • editing/execCommand/12244-expected.txt: Added.
  • editing/execCommand/12244.html: Added.
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by harrison

<​http://bugs.webkit.org/show_bug.cgi?id=12244>
FCKeditor: Find dialog doesn't work

  • bindings/js/kjs_window.cpp: (KJS::Window::find): Added. This function doesn't yet support whole word searches, searching in subframes, or opening the find dialog. (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
3:58 PM Changeset in webkit [20070] by hyatt
  • 4 edits in trunk/WebCore

Fix regression from throwing away frames of large animated images. Alter
animated images so that they refuse to advance the animation until the
current displayed frame has been fully decoded.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):
3:45 PM Changeset in webkit [23044] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Steve.


Fix <rdar://problem/4969070> Failed error pages show "unknown error"
rather than specific error

Make ResourceError aware of kCFErrorDomainCFNetwork.

  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Added case for kCFErrorDomainCFNetwork.
3:33 PM Changeset in webkit [20069] by hyatt
  • 2 edits in trunk/WebCore

Fix 2% performance regression on the PLT. Increase the large animated
image cutoff from 1MB to 5MB.

In addition when pruning we will aggressively discard image sources.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
2:42 PM Changeset in webkit [20068] by justing
  • 1 edit in trunk/LayoutTests/fast/dom/Range/13000-expected.txt
2:16 PM Changeset in webkit [20067] by thatcher
  • 12 edits in trunk

WebCore:

Reviewed by John.

<rdar://problem/4664697> highlighter SPI needs a node parameter to give more context

Pass the RenderObject's node to customHighlightLineRect and paintCustomHighlight.

  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::customHighlightLineRect): (WebCore::Frame::paintCustomHighlight):
  • page/mac/WebCoreFrameBridge.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

Reviewed by John.

<rdar://problem/4664697> highlighter SPI needs a node parameter to give more context

Added new methods to the WebHTMLHighlighter protocol that include the DOMNode being painted.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge customHighlightRect:forLine:representedNode:WebCore::]): (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:representedNode:WebCore::]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLViewPrivate.h:
2:00 PM Changeset in webkit [20066] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=13000>
Range.createContextualFragment is not supported

  • fast/dom/Range/13000-expected.txt: Added.
  • fast/dom/Range/13000.html: Added.

WebCore:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=13000>
Range.createContextualFragment is not supported

  • dom/Range.cpp: (WebCore::Range::createContextualFragment): The "startContainer" may not be a container, if the range starts inside text. In that case, look to the parent of the start node for an HTMLElement.
12:49 PM Changeset in webkit [20065] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar::/problem/5049671>
Gmail Editor: With linked text, Remove Formatting doesn't always remove underline

  • editing/execCommand/5049671-expected.checksum: Added.
  • editing/execCommand/5049671-expected.png: Added.
  • editing/execCommand/5049671-expected.txt: Added.
  • editing/execCommand/5049671.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/5049671>
Gmail Editor: With linked text, Remove Formatting doesn't always remove underline

  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Clear removed anchors after the deletion.
10:33 AM Changeset in webkit [20064] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

Attempt to fix the build.

9:47 AM Changeset in webkit [20063] by brmorris
  • 3 edits in S60/trunk/S60Internals

brmorris, reviewed by nobody (bustage fix)

DESC: add some icons to fix build bustage caused by r20034

7:03 AM Changeset in webkit [20062] by ddkilzer
  • 1 edit
    1 add in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

Added missing file for r20059:
<rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.

File was taken from this svn repository which contained versions of ucnv.h and ucnv_err.h
that were identical to ours:
​http://source.icu-project.org/repos/icu/icu/tags/release-3-2/source/common/unicode/ucnv_cb.h

  • icu/unicode/ucnv_cb.h: Added.
5:57 AM Changeset in webkit [20061] by bdash
  • 2 edits in trunk/WebCore

2007-03-09 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
4:09 AM Changeset in webkit [20060] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

Fix compiler warnings when building Drosera as 64-bit.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument breakpointEditorHTML]): Move away from deprecated NSString method. (-[DebuggerDocument scriptConfirmSheetDidEnd:returnCode:contextInfo:]): Update type. (-[DebuggerDocument webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Update type to accommodate constant.
3:08 AM Changeset in webkit [20059] by oliver
  • 6 edits in trunk

2007-03-08 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

To match old TEC behaviour when using ICU we need to use
a few manual fallback encodings for the GBK/EUC-CN charsets

<rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.

  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::TextCodecICU): (WebCore::TextCodecICU::createICUConverter): (WebCore::gbkEscapes): (WebCore::gbkCallbackEscape): (WebCore::gbkCallbackSubstitute): (WebCore::TextCodecICU::encode):
  • platform/TextCodecICU.h: (WebCore::TextCodecICU::needsGBKFallbacks): (WebCore::TextCodecICU::setNeedsGBKFallbacks):


LayoutTests:

Adding GBK character encoding tests

  • fast/encoding/char-encoding-expected.txt:
  • fast/encoding/char-encoding.html:


2:00 AM Changeset in webkit [23043] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.


  • WebView.cpp: (WebView::isLoading):
1:21 AM Changeset in webkit [23042] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Implement WebView::isLoading.


  • WebView.cpp: (WebView::isLoading):
1:12 AM Changeset in webkit [20058] by andersca
  • 2 edits in trunk/WebKit

Try fixing the buildbot build.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
12:48 AM Changeset in webkit [20057] by ap
  • 5 edits in trunk

WebCore:

Build fix.

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue):

LayoutTests:

Added a test for attribute node string-value.

  • fast/xpath/string-value-expected.txt:
  • fast/xpath/string-value.html:
12:43 AM Changeset in webkit [20056] by hyatt
  • 4 edits in trunk/WebCore

This patch dramatically reduces the memory consumed by animated images. For large animated GIFs (defined for
now as >1mb in terms of decoded frame buffer size), we will now aggressively flush previous frames of the
animated GIF and just re-decode them on the fly if the animation loops.

Whenever a large animated GIF has its animation reset, we will also just throw out everything and start
the animation over (in order to get rid of any cached detritus held in the ImageSource).

With this patch and the sample GIF used to test, WebKit's memory consumption went from 160MB down to 16MB.

Reviewed by mjs

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::resetAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
12:16 AM Changeset in webkit [20055] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13006
XPath string-value is broken for some node types

Test: fast/xpath/string-value.html

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Fix it :-)
12:02 AM Changeset in webkit [20054] by ddkilzer
  • 1 edit in trunk/WebKit/ChangeLog

Added bug number and fixed email address.

Note: See TracTimeline for information about the timeline view.