⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 10, 2007:

3:37 PM Changeset in webkit [20100] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13028
REGRESSION: textField:doCommandBySelector:inFrame: not being called properly

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Before calling the base class defaultEventHandler, which will call handleKeypress, call doTextFieldCommandFromEvent.
2:46 PM Changeset in webkit [20099] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/listbox-typeahead-scroll-expected.txt: Added.
  • fast/forms/listbox-typeahead-scroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/listbox-typeahead-scroll.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Reordered to set the active selection's anchor and end before selecting the option, since the active selection is used to decide where to scroll when the selection is made. (WebCore::HTMLSelectElement::defaultEventHandler): Removed redundant check.
2:43 PM Changeset in webkit [20098] by ddkilzer
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/css-cached-import-rule-expected.checksum: Added.
  • fast/dom/css-cached-import-rule-expected.png: Added.
  • fast/dom/css-cached-import-rule-expected.txt: Added.
  • fast/dom/css-cached-import-rule.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/css-cached-import-rule.html

Replaced some direct calls to document->stylesheetLoaded() with calls to
the sheet's checkLoaded(). The latter calls back to the element's sheetLoaded() --
which notifies the document of the load -- and then updates the sheet's
loadCompleted() flag, ensuring that it stays in sync with whether the stylesheet
is still considered pending by the document.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::parseStyleSheet):
  • dom/StyleElement.cpp: (WebCore::StyleElement::childrenChanged):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h:
2:38 PM Changeset in webkit [20097] by ddkilzer
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

  • WebCore.exp: Export WebCore::Image::loadPlatformResource(const char*) for use in [WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:].

WebKit:

Reviewed by Darin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Use WebCore::Image::loadPlatformResource(const char*) to load the missingImage image.
12:17 AM Changeset in webkit [23056] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • DOMCoreClasses.cpp: (DOMNode::textContent): Implement this.
12:08 AM Changeset in webkit [20096] by bdash
  • 2 edits in trunk/WebKit

2007-03-10 Mark Rowe <​mrowe@apple.com>

Reviewed by John.

<rdar://problem/5051827> HIWebView handling of kEventControlGetData is broken in 64-bit

On Leopard the kEventParamControlDataBufferSize event parameter is of type typeByteCount.
The 32-bit implementation of GetEventParameter will coerce between integer types and
typeByteCount while the 64-bit version will return a failure. As typeByteCount is new
in Leopard we must continue using typeSInt32 when building for Tiger.

  • Carbon/HIWebView.m: (HIWebViewEventHandler):

Mar 9, 2007:

7:23 PM Changeset in webkit [23055] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by John.

Fix the doubled text in the image used to drag a link

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawDoubledTextAtPoint):


5:06 PM Changeset in webkit [23054] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Implement setting the suggested filename for a response.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::filenameFromHTTPContentDisposition): (WebCore::filenameHasSaneExtension): (WebCore::suggestedFilenameForResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/win/MimeTypeRegistryWin.cpp: (WebCore::getMIMETypeForUTI):


(WebCore::mimeTypeForExtension):
Fix two bugs in this function.


(WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):

WebKitWin:

Reviewed by Adam.

  • WebURLResponse.cpp: (WebURLResponse::suggestedFilename): Get the suggested filename from the ResourceResponse object.
4:41 PM Changeset in webkit [20095] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Force diff to treat files that svn-create-patch thinks are text as text.

  • Scripts/svn-create-patch: Added -a switch to diff command.
4:07 PM Changeset in webkit [23053] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Adam.

Fix build and do some general cleanup.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runBeforeUnloadConfirmPanelWithMessage): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction): (WaitUntilDoneDelegate::contextMenuItemSelected): (WaitUntilDoneDelegate::trackCustomPopupMenu): (WaitUntilDoneDelegate::measureCustomMenuItem): (WaitUntilDoneDelegate::drawCustomMenuItem): (WaitUntilDoneDelegate::cleanUpCustomMenuDrawingData): (WaitUntilDoneDelegate::canTakeFocus): (WaitUntilDoneDelegate::takeFocus): (WaitUntilDoneDelegate::registerUndoWithTarget): (WaitUntilDoneDelegate::removeAllActionsWithTarget): (WaitUntilDoneDelegate::setActionTitle): (WaitUntilDoneDelegate::undo): (WaitUntilDoneDelegate::redo): (WaitUntilDoneDelegate::canUndo): (WaitUntilDoneDelegate::canRedo): (WaitUntilDoneDelegate::addCustomMenuDrawingData):
2:58 PM Changeset in webkit [20094] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4976254> Please get off _NSSoftLinkingGetFrameworkFuncPtr

Use dlopen and dlsym to access the DCSShowDictionaryServiceWindow function.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
12:02 PM Changeset in webkit [23052] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Steve.

B&I build fix.

  • WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
11:45 AM Changeset in webkit [20093] by darin
  • 2 edits in trunk/WebKitSite
  • blog/wp-content/themes/webkit/style.css: Removed rule for code since we want it to match pre, and the default font looks fine -- no need to ask for "Courier New" explicitly.
10:54 AM Changeset in webkit [20092] by darin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/paste-xml-expected.checksum: Added.
  • editing/pasteboard/paste-xml-expected.png: Added.
  • editing/pasteboard/paste-xml-expected.txt: Added.
  • editing/pasteboard/paste-xml.xhtml: Added.

WebCore:

Reviewed by Justin.

Test: editing/pasteboard/paste-xml.xhtml

  • editing/markup.cpp: (WebCore::createFragmentFromMarkup): Added a check for 0 here, since createContextualFragment can return 0 for XML documents that fail to parse. In my testing, callers all seem equipped to handle 0.

WebKit:

Reviewed by Justin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _hasHTMLDocument]): Added. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Don't call AppKit's conversion from the DOM to an attributed string if the document is not an HTML document, to work around an AppKit limitation (Radar 5052390).
8:32 AM Changeset in webkit [23051] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Fixup comments and remove an obsolete FIXME.
8:19 AM Changeset in webkit [20091] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
8:05 AM Changeset in webkit [20090] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • http/tests/misc/onload-remove-iframe-crash-2-expected.txt: Added.
  • http/tests/misc/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe.html: Added.

WebCore:

Reviewed by Darin.

Test: http/tests/misc/onload-remove-iframe-crash-2.html

The resulted from an iframe's load event handler removing the iframe
from the document.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Bail out early if an event handler removed the frame.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): Protect the frame from deletion by event handlers. (WebCore::FrameLoader::checkCompletedTimerFired): (WebCore::FrameLoader::scheduleCheckCompleted): (WebCore::FrameLoader::detachFromParent): Schedule a completion check on the parent (in case the child is what has been keeping it from completing).
  • loader/FrameLoader.h:
4:35 AM Changeset in webkit [20089] by rwlbuis
  • 1 edit in trunk/WebCore/ChangeLog

I forgot to commit my ChangeLog as part of r20028, sorry about that.

2:00 AM Changeset in webkit [20088] by bdash
  • 3 edits
    2 deletes in trunk

Roll out r20078 as it's causing a crash during layout tests.

1:23 AM Changeset in webkit [23050] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

1:20 AM Changeset in webkit [20087] by sfalken
  • 1 copy in tags/Safari-521.35.7b

New tag.

1:08 AM Changeset in webkit [23049] by oliver
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Forgot to save changelog with reviewer name, correcting

1:01 AM Changeset in webkit [23048] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Steve.

Executing a script for a plugin can cause cause this to be deleted
so we take a reference to our parent prior to executing the script

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
Note: See TracTimeline for information about the timeline view.