⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 13, 2007:

10:37 PM Changeset in webkit [20181] by justing
  • 14 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5046875>
Gmail Editor: Applying alignment to selected text in message also applies alignment to signature

Added:

  • editing/style/5046875-1-expected.checksum: Added.
  • editing/style/5046875-1-expected.png: Added.
  • editing/style/5046875-1-expected.txt: Added.
  • editing/style/5046875-1.html: Added.
  • editing/style/5046875-2-expected.checksum: Added.
  • editing/style/5046875-2-expected.png: Added.
  • editing/style/5046875-2-expected.txt: Added.
  • editing/style/5046875-2.html: Added. moveParagraphs doesn't move unnecessary brs:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt: moveParagraphs clears out unrendered text during the move:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5046875>
Gmail Editor: Applying alignment to selected text in message also applies alignment to signature

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Don't call applyBlockStyle unless there is a block style to apply. (WebCore::ApplyStyleCommand::applyBlockStyle): Don't do the remove step. It was unnecessary and removed properties from blocks that could contain content outside the range being operated on (added a testcase). (WebCore::ApplyStyleCommand::addBlockStyleIfNeeded): Used an early return instead of if-nesting.
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Return the new block, if one was created. Use moveParagraphs to move paragraphs into the new block, instead of moving nodes. The old code moved too much (added a testcase).
  • editing/CompositeEditCommand.h:
10:00 PM Changeset in webkit [20180] by oliver
  • 6 edits
    2 adds in trunk

2007-03-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

WebCore:

To fix <rdar://problem/5044366> we now pass a NSString
representation of the URL extracted with _web_originalDataAsString
instead of relying on [NSURL absoluteString] in the bridge

  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]):

WebKit:

Modify subresourceForURL to take NSString argument
so we can avoid [NSURL absoluteString]

  • WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]):

LayoutTests:

Test for <rdar://problem/5044366> make sure we can create
a WebArchive from a page with a partially decoded url.

  • webarchive/archive-with-unencoded-url-expected.txt: Added.
  • webarchive/archive-with-unencoded-url.html: Added.
9:44 PM Changeset in webkit [20179] by beidson
  • 3 edits in trunk/WebKit

Rubberstamped by Alice

Meant to be part of my previous checkin... pruning unused code from WebKit

  • WebView/WebFrame.mm: Removed _canCachePage
  • WebView/WebFrameInternal.h: Ditto
8:59 PM Changeset in webkit [20178] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Anders

<rdar://problem/5048818> - REGRESSION: Incompletely loaded resources being saved to the object cache

Due to a subtle change in loader behavior back in 10904, we would stop all loaders before calling
didFail() on them in the Cache loader. As a result, we basically cleared all of the Subresource Loaders
out of the Cache loader before more properly failing them as errored out. The result? Partially loaded
resources being cached.


Since Loader::didFail() both calls error() on the object *and* removes the loader, the solution is to call
didFail() for all cancelled loaders instead of *only* removing them from the set of active loaders.


In addition, pages that didn't completely load were being saved to the back/forward cache. To fix that,
I added a null check on the DocumentLoader's error to see if the page ended in an error, or did indeed
completely load.

Note that the layout test for this - if possible - will require other enhancements including possibly adding
support for window.stop(). That task is documented in <rdar://problem/5061826>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): Fixed a few bugs relating to my original BFCache rewrite to more perfectly restore the original behavior - including only caching HTML documents via the m_client->canCachePage() call (WebCore::FrameLoader::canCachePage): Don't make the call to m_client->canCachePage() as that serves a different purpose
    • Check the mainDocumentError to see if the load ended in error as a further criteria in determining the cachability of a page
  • loader/loader.cpp: (WebCore::Loader::cancelRequests): Call didFail(cancelledError()) instead of just removing the loaders from the loaders-in-progress set. This adds the effect of properly cleaning up the cached object.
8:56 PM Changeset in webkit [20177] by bdakin
  • 6 edits
    4 adds in trunk

WebCore:

Rendering part reviewed by Hyatt. Editing part consulted with and
rubber stamped by Justin and Harrison.

Fix for <rdar://problem/5025925> A hang occurs in Safari when
attempting to print page at ​http://www.pcadvisor.co.uk

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): RenderBlock::makeChildrenNonInline() takes a block's inline children and turns them into block children. If the children had line boxes, those boxes were being leaked. In the layout test I added with the change (and at pcadvisor.co.uk during printing) children were being made non-inline, and then they were being made inline again. This meant that some of the children ended up pointing to totally stale line boxes that are normally just leaked. This caused an infinite loop in RenderFlow::destroy(). This patch simply deletes everyone's line boxes in RenderBlock::makeChildrenNonInline()
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): The other part of this fix is that I added a call to updateLayout in InsertParagraphSeparatorCommand::doApply(). One layout test (editing/spelling/spelling.html) was changed by my patch to RenderBlock. doApply() inserts a node into the render tree. In at least one case in spelling.html, that caused some line boxes to be deleted. Back in doApply() this meant that the RenderTree was out- of-date, and we mistakenly thought we were at the end of the paragraph. This caused us to insert a RenderBR() at the end of the tree instead of an empty RenderText(). No one seems to know exactly why we insert either, or if the change is necessarily a problem. It is clear, though, that the RenderTree in doApply() is out-of-date after inserting the node and deleting some line boxes, so it seems prudent to call into updateLayout().

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5025925> A hang occurs in Safari when
attempting to print page at ​http://www.pcadvisor.co.uk

  • fast/block/float/nestedAnonymousBlocks-expected.checksum: Added.
  • fast/block/float/nestedAnonymousBlocks-expected.png: Added.
  • fast/block/float/nestedAnonymousBlocks-expected.txt: Added.
  • fast/block/float/nestedAnonymousBlocks.html: Added.
7:42 PM Changeset in webkit [23069] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Anders.

  • platform/win/FontDataWin.cpp: (WebCore::scaleEmToUnits): Ported from FontDataMac. (WebCore::FontData::platformInit): Use CG for metrics, and apply Mac's line-height hack for Times, Helvetica, and Courier. (WebCore::FontData::platformWidthForGlyph): Call wkGetGlyphAdvances to use some CG SPI to match Mac.
7:37 PM Changeset in webkit [20176] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • platform/FontData.h: Added m_isSystemFont parameter to match NSFont.
5:39 PM Changeset in webkit [20175] by harrison
  • 3 edits in trunk/LayoutTests

<rdar://problem/5031181> cntl-k at end of paragraph adds nothing to the kill ring
<rdar://problem/5031189> REGRESSION: cntl-y yanks only the most recently killed content

Updated results.

  • editing/deleting/delete-to-end-of-paragraph-expected.checksum:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
4:55 PM Changeset in webkit [20174] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

typo fix. thanks aroben!

4:51 PM Changeset in webkit [20173] by bdakin
  • 4 edits in trunk

WebCore:

Reviewed by Maciej.

Export DocumentLoader::setFrame(). Part for fix for <rdar://
problem/4277074> 8F32: Help Viewer crashed on clicking link -
KHTMLView::viewportMouseReleaseEvent (12647)

  • WebCore.exp:

WebKit:

Reviewed by Maciej.

Fix for <rdar://problem/4277074> 8F32: Help Viewer crashed on
clicking link - KHTMLView::viewportMouseReleaseEvent (12647)

Re-set the DocumentLoader's frame when loading it from the page
cache before setting the document view.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache):
4:32 PM Changeset in webkit [23068] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:29 PM Changeset in webkit [20172] by sfalken
  • 1 copy in tags/Safari-521.35.8b

New tag.

4:25 PM Changeset in webkit [20171] by darin
  • 1 edit in trunk/WebCore/ChangeLog

of -> be

4:18 PM Changeset in webkit [20170] by darin
  • 6 edits
    12 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/canvas/canvas-hides-fallback-expected.txt: Added.
  • fast/canvas/canvas-hides-fallback.html: Added.
  • fast/canvas/script-inside-canvas-fallback-expected.txt: Added.
  • fast/canvas/script-inside-canvas-fallback.html: Added.
  • fast/canvas/unclosed-canvas-1-expected.txt: Added.
  • fast/canvas/unclosed-canvas-1.html: Added.
  • fast/canvas/unclosed-canvas-2-expected.txt: Added.
  • fast/canvas/unclosed-canvas-2.html: Added.
  • fast/canvas/unclosed-canvas-3-expected.txt: Added.
  • fast/canvas/unclosed-canvas-3.html: Added.
  • fast/canvas/unclosed-canvas-4-expected.txt: Added.
  • fast/canvas/unclosed-canvas-4.html: Added.

WebCore:

Reviewed by Maciej.

Change <canvas> elements so that their contents are parsed normally,
but not rendered. This change fixes the bug, because normal parsing
rules close the <canvas> element in that case. The special parser
stuff was just getting in the way.

Also do some basic cleanup to the HTML parser. This was motivated by
an earlier version of this patch that made even more changes to the
parser, but the cleanup is still worth landing.

Test: fast/canvas/canvas-hides-fallback.html
Test: fast/canvas/script-inside-canvas-fallback.html
Test: fast/canvas/unclosed-canvas-1.html
Test: fast/canvas/unclosed-canvas-2.html
Test: fast/canvas/unclosed-canvas-3.html
Test: fast/canvas/unclosed-canvas-4.html

  • html/HTMLCanvasElement.h: Added a data member to keep track of whether the renderer is a RenderHTMLCanvas or not.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer): If JavaScript is enabled, create a RenderHTMLCanvas. If it's not, let the default code create the default type of renderer, which will result in fallback content being visible. The RenderHTMLCanvas class already hides all of its children. Set the m_rendererIsCanvas boolean accordingly. Since the actual storage for the canvas is allocated lazily when you actually get a drawing context, we don't need to do anything special to prevent it when JavaScript is disabled; the relevant functions won't be called. (WebCore::HTMLCanvasElement::reset): Protect the code that manipulates the RenderHTMLCanvas with a check of m_rendererIsCanvas. This is the only code inside the DOM element that relies on the renderer type.
  • html/HTMLParser.h: Removed unneeded includes. Marked HTMLParser as Noncopyable. Changed the Document parameter to the constructor to instead of HTMLDocument. Renamed discard_until to m_skipModeTag for clarity. Removed unused noSpaces function and unneeded public doc() function. Moved data members all down to the end so you can see them together in order. Renamed map to m_currentMapElement and isindex to m_isindexElement. Removed unused end and headLoaded data members. Renamed m_fragment to m_isParsingFragment to make it clearer that it's a boolean, not a fragment.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Changed to use member construction syntax instead of calling reset(). This is especially helpful in the fragment case, where calling reset() later on is illegal, so not using it in the constructor lets us assert. (WebCore::HTMLParser::~HTMLParser): Did an explicit deref instead of calling setCurrent for its side effect. (WebCore::HTMLParser::reset): Updated for member name changes and removal and to use document instead of doc(). (WebCore::HTMLParser::setCurrent): Use document instead of doc(). (WebCore::HTMLParser::setSkipMode): Added. No longer inline. Now sets the m_inCanvasBeforeFirstOpenTag data member to false. (WebCore::HTMLParser::parseToken): Tightened up the skip mode logic at the top of the function, and added a FIXME about the strange case there where we don't skip yet stay in skip mode. Updated for renaming and doc(). (WebCore::HTMLParser::insertNode): Updated for renaming and doc(). (WebCore::HTMLParser::handleError): Ditto. (WebCore::HTMLParser::framesetCreateErrorCheck): Ditto. (WebCore::HTMLParser::isindexCreateErrorCheck): Changed to use RefPtr. (WebCore::HTMLParser::noscriptCreateErrorCheck): Updated for renaming and doc(). (WebCore::HTMLParser::mapCreateErrorCheck): Ditto. (WebCore::HTMLParser::getNode): Removed the special case for canvas here. Canvas fallback is now handled in the DOM, not the parser. Updated for renaming and doc(). (WebCore::HTMLParser::allowNestedRedundantTag): Changed a #define into a C++ constant. (WebCore::HTMLParser::processCloseTag): Updated for renaming and doc(). (WebCore::HTMLParser::isInline): Ditto. (WebCore::HTMLParser::tagIsOnStack): Added. Used by new canvas logic. (WebCore::HTMLParser::popBlock): Updated for renaming and doc(). Also renamed the local variable Elem to elem. (WebCore::HTMLParser::createHead): Ditto. (WebCore::HTMLParser::handleIsindex): Changed to use RefPtr. (WebCore::HTMLParser::startBody): Updated for renaming and doc(). (WebCore::HTMLParser::finished): Ditto.
4:07 PM Changeset in webkit [20169] by hyatt
  • 3 edits in trunk/WebCore

Two more cleanup fixes to the cache. Don't call destroyDecodedData in the BitmapImage destructor, since
clearing the image source and calling setData on it again causes it to do an extra copy of the encoded
data. Since we're about to be destroyed this is just wasteful.

When the cache prunes, don't allow it to destroy the decoded data of an image that is still actively loading,
since we've established that ImageIO can actually crash if you yank the rug out from under it like that.

Reviewed by ggaren

  • loader/Cache.cpp: (WebCore::Cache::prune):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::~BitmapImage):
3:46 PM Changeset in webkit [20168] by andersca
  • 2 edits in trunk/WebCore

Try fixing the Qt build.


  • editing/Editor.h: (WebCore::Editor::setStartNewKillRingSequence):
3:40 PM Changeset in webkit [20167] by thatcher
  • 8 edits in trunk

Reviewed by Geoff.

<rdar://problem/5057117> Spoof user agent on Yahoo.com with Safari and WebKit as version 4xx

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView userAgent]): Stop using the deprecated lossyCString method.
  • WebCoreSupport/WebFrameBridge.mm: Removed dead code, userAgentForURL: wasn't used.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::userAgent): Call WebView's _userAgentForURL:.
  • WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Call userAgentForURL: instead of _userAgent. (-[WebView userAgentForURL:]): Call _userAgentForURL:. (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): New method to construct a UA. (-[WebView _computeUserAgent]): Ractored out into _userAgentWithApplicationName:andWebKitVersion: (-[WebView _userAgentForURL:]): Tail compare for Yahoo.com, and return a UA with an older WebKit version.
  • WebView/WebViewInternal.h: Declare _userAgentForURL:.
3:31 PM Changeset in webkit [20166] by harrison
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

<rdar://problem/5031181> cntl-k at end of paragraph adds nothing to the kill ring
<rdar://problem/5031189> REGRESSION: cntl-y yanks only the most recently killed content

  • editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.png: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001.html: Added.

WebCore:

Reviewed by Justin.

<rdar://problem/5031181> cntl-k at end of paragraph adds nothing to the kill ring
<rdar://problem/5031189> REGRESSION: cntl-y yanks only the most recently killed content

For rdar://5031181, properly extend the selection before the killring handling, and
make sure plainText of that selection returns a linefeed.


For rdar://5031189, restore Editor::deleteRange() code that continued current killring,
even though the range deletion implicitly stopped it via changing the selection.


A byproduct of this change is the elimination of RUNDFINDER vs CONTENT TextIterator. The
only difference between the two was whether to emit a newline when the range started
with a blockflow element. No callers actually need that any more.

Tests added:

  • editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.png: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001.html: Added.
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): Clear the "start new kill ring sequence" setting, because it was set to true when the selection was updated by deleting the range.


(WebCore::Editor::deleteWithDirection):
If extending the selection to the end of paragraph resulted in a caret selection,
extend by character, to handle the case when the selection started as a caret at
the end of paragraph.


  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Initialize new member variables for tracking handling of the beginning of the range.


(WebCore::TextIterator::advance):
Call representNodeOffsetZero on the m_endContainer.
Move visibility checks into handleTextNode and handleReplacedElement.


(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
Call emitText.


(WebCore::TextIterator::handleReplacedElement):
Moved visibility check into here.


(WebCore::shouldEmitNewlinesBeforeAndAfterNode):


(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
(WebCore::TextIterator::representNodeOffsetZero):
New. Emits proper sequence when encountering offset 0 of a node, including the
m_endContainer. Started with code from handleNonTextNode.


(WebCore::TextIterator::handleNonTextNode):
Call representNodeOffsetZero.


(WebCore::TextIterator::exitNode):
Similar to shouldRepresentNodeOffsetZero, do not emit the newline if the node
was collapsed, and before any other emitted content.


(WebCore::TextIterator::emitCharacter):


(WebCore::TextIterator::emitText):
New. Consolidates code used by handleText and handleTextBox.


(WebCore::CharacterIterator::CharacterIterator):
Removed RUNFINDER.

(WebCore::WordAwareIterator::WordAwareIterator):
Removed RUNFINDER.


(WebCore::WordAwareIterator::advance):
Formatting.

(WebCore::TextIterator::rangeLength):
Formatting.


  • editing/TextIterator.h: Added member variables for tracking handling of the beginning of the range. Eliminated concept of RUNDFINDER vs CONTENT TextIterator.


  • editing/visible_units.cpp: (WebCore::nextBoundary): Eliminated concept of RUNDFINDER vs CONTENT TextIterator.
3:11 PM Changeset in webkit [20165] by hyatt
  • 2 edits in trunk/WebCore

Clean up the null image case in CachedImage::data to make sure the size totals will stay accurate.
I'm not convinced this case can even be hit, but I'm cleaning it up just in case.

  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
3:10 PM Changeset in webkit [20164] by lars
  • 2 edits in trunk/LayoutTestResults

Add a test that currently crashes the Qt build.

3:03 PM Changeset in webkit [20163] by hyatt
  • 2 edits in trunk/WebCore

Reorder the call to allReferencesRemoved, since otherwise the live object size will become
incorrect.

  • loader/CachedResource.cpp: (WebCore::CachedResource::deref):
3:00 PM Changeset in webkit [20162] by lars
  • 2 edits in trunk/WebKitQt

Reviewed by George.

Don't try to load <object> tags with an invalid url.
Fixes LayoutTests/fast/dom/object-plugin-hides-properties.html
which hit an assertion in the frameloader.

2:57 PM Changeset in webkit [20161] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brmorris, rs'd by sachin

DESC: merge of r20160 to s60's 3.1m branch. MLIO-6Y2BV3

2:54 PM Changeset in webkit [20160] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, rubberstamped by sachin

DESC: Content change for SCM sync MLIO-6Y2BV3

  • BrowserView/src/LoadListeners.cpp: copyright update
2:41 PM Changeset in webkit [20159] by antti
  • 3 edits
    6 adds in trunk

LayoutTests:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=11083
REGRESSION: Typing tab key fails to insert a tab character in Google Docs editable area
<rdar://problem/4757650>

  • editing/inserting/typing-tab-designmode-expected.txt: Added.
  • editing/inserting/typing-tab-designmode-forms-expected.checksum: Added.
  • editing/inserting/typing-tab-designmode-forms-expected.png: Added.
  • editing/inserting/typing-tab-designmode-forms-expected.txt: Added.
  • editing/inserting/typing-tab-designmode-forms.html: Added.
  • editing/inserting/typing-tab-designmode.html: Added.

WebCore:

Reviewed by Darin.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=11083
REGRESSION: Typing tab key fails to insert a tab character in Google Docs editable area
<rdar://problem/4757650>


Allow inserting tabs in designMode. Backtab behaves like before (matches FF).

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):
2:31 PM Changeset in webkit [20158] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fixes builds using buildit.

1:25 PM Changeset in webkit [20157] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by .

  • Adding expected failures until the are truly fixed.
  • rdar://problem/5060302
  • tests/mozilla/expected.html:
1:18 PM Changeset in webkit [20156] by hyatt
  • 2 edits in trunk/WebCore

Fix two counting errors in the decoded size of objects in the WebCore cache. We need to explicitly
destroy decoded data when clearing out a partially loaded image that had an error, since the destructor
(although it does destroy the data) disconnects the observer so that the notification doesn't happen.

Some CachedImages aren't in the cache (like image documents). When the decoded size of such an image
changes we should not notify the cache, since - newsflash - we aren't actually in it.

Reviewed by ggaren

  • loader/CachedImage.cpp: (WebCore::CachedImage::clear): (WebCore::CachedImage::decodedSizeChanged):
1:06 PM Changeset in webkit [20155] by brmorris
  • 2 edits in S60/trunk/WebKit

spaltis, reviewed by padmae

DESC: 3.2 IDO: Got Error message for Non-Drm downloads: TSW HLUU-6YUVE6
Fix: Removal of old code to prevent setting HTTP Request Accept Header in case of WML page.
​http://bugs.webkit.org/show_bug.cgi?id=13058

12:33 PM Changeset in webkit [20154] by thatcher
  • 1 edit in trunk/WebKitSite/contact.html

Silly wrapping change for testing a post-commit hook change.

12:20 PM Changeset in webkit [20153] by lars
  • 3 edits in trunk/WebKitQt

Fix 99% of the crashes in the loader I've been seeing lately.

11:22 AM Changeset in webkit [20152] by darin
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher and John Sullivan.

  • fix <rdar://problem/4915303> CrashTracer: 36 crashes in Safari at com.apple.AppKit: -[NSView getRectsBeingDrawn:count:] + 502
  • page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): This was calling drawRect: directly, but NSView's getRectsBeingDrawn:count: method was never really safe to call unless it was AppKit that called your drawRect: method. Changed it to call drawSingleRect: instead. A little ugly, but seems to work and will almost certainly fix the bug.
9:53 AM Changeset in webkit [20151] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12974

Call forgetGenericContext in JSSVGPathSeg destructor, otherwhise
we'll hit an ASSERT in a debug build, when running svg/custom/js-update-path-changes.svg
a few dozen times in a single WebKit instance. The ASSERT is good and just warns that
there was already a generic context pointer registered, and the new "to be registered"
object already exists, but pointing to a different object. That's because garbage collection
calls the JSSVGPathSeg destructor, but that didn't cleanup the generic context map.

Only JSSVGPathSeg is hit by this problem, as it's the only non SVGAnimated* type
using the generic context system while using a custom JSSVGPathSegList implementation.

Also cleanup JSSVGPathSegListCustom code to call the static forgetGenericContext
method instead of doing the same using custom code.

  • bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::removeFromPathSegContextMap): (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::removeItem):
  • bindings/scripts/CodeGeneratorJS.pm:
8:12 AM Changeset in webkit [20150] by brmorris
  • 2 edits in S60/branches/3.1m/MemoryManager

spadma, Reviewed by Yongjun.

DESC: Browsers OOM Plug-in functionality is disabled HMAA-6Z3HMM
​http://bugs.webkit.org/show_bug.cgi?id=13047

7:47 AM Changeset in webkit [20149] by darin
  • 2 edits in trunk/LayoutTests
  • fast/js/kde/RegExp-expected.txt: Fix the one other test affected by the js-test-pre.js change.
7:19 AM Changeset in webkit [20148] by darin
  • 21 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/old-names-expected.txt: Added.
  • fast/forms/old-names.html: Added.
  • check in files that were somehow left out in the last check-in
  • fast/js/resources/js-test-pre.js: Improve the format of the failure message when both the real results and expected results are strings.
  • fast/dom/wrapper-classes-expected.txt: Changed back to use the new format.

WebCore:

Reviewed by Adele.

Test: fast/forms/old-names.html

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName): If the form collection has nothing for a given name, try the form's oldNamedElement function. (WebCore::JSHTMLFormElement::nameGetter): Ditto.
  • bindings/js/kjs_dom.h: Removed the DOMNamedNodesCollection. Instead we will use a class derived from NodeList.
  • bindings/js/kjs_dom.cpp: Ditto.
  • bindings/js/kjs_html.cpp: (KJS::VectorNodeList::VectorNodeList): Added. Constructor for a new class derived from NodeList to be used for the named items result from a collection -- uses a vector of node pointers. (KJS::VectorNodeList::length): Added. (KJS::VectorNodeList::item): Added. (KJS::JSHTMLCollection::getNamedItems): Use VectorNodeList and the existing wrapper for NodeList rather than a custom JavaScript class, DOMNamedNodesCollection.
  • dom/ChildNodeList.h:
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): Updated to derive from TreeNodeList, since NodeList is now a simpler class. (WebCore::ChildNodeList::elementMatches): Updated for name and parameter change.
  • dom/NameNodeList.h:
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): Updated to derive from TreeNodeList, since NodeList is now a simpler class. (WebCore::NameNodeList::rootNodeAttributeChanged): Updated for name and parameter change.
  • dom/Node.h: Change register/unregister functions to take TreeNodeList.
  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Updated to derive from TreeNodeList, since NodeList is now a simpler abstract class. (WebCore::TagNodeList::elementMatches): Updated for name and parameter change. (WebCore::Node::registerNodeList): Changed type from NodeList to TreeNodeList. (WebCore::Node::unregisterNodeList): Ditto.
  • dom/NodeList.h: Broke NodeList into a simpler base class and a derived class with the machinery for iterating a tree, called TreeNodeList.
  • dom/NodeList.cpp: (WebCore::NodeList::~NodeList): Added. (WebCore::NodeList::itemWithName): Factored out of the old itemWithName. (WebCore::TreeNodeList::TreeNodeList): Renamed from NodeList. (WebCore::TreeNodeList::~TreeNodeList): Ditto. (WebCore::TreeNodeList::recursiveLength): Ditto. (WebCore::TreeNodeList::itemForwardsFromCurrent): Ditto. (WebCore::TreeNodeList::itemBackwardsFromCurrent): Ditto. (WebCore::TreeNodeList::recursiveItem): Ditto. (WebCore::TreeNodeList::itemWithName): Factored half of this into this function, the other half in NodeList::itemWithName. (WebCore::TreeNodeList::rootNodeAttributeChanged): Added. No longer inline. (WebCore::TreeNodeList::rootNodeChildrenChanged): Renamed from NodeList.
  • html/HTMLFormElement.h: Added formElementNameChanged and oldNamedElement fucntions, and a map called m_oldNames. Also removed m_boundary, which I thought I had already done.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Initialize m_oldNames to 0. Switched the rest of the members to initialization syntax. (WebCore::HTMLFormElement::~HTMLFormElement): Delete m_oldNames. (WebCore::HTMLFormElement::formElementNameChanged): Added. Stores a reference to one element under each of its old names. (WebCore::HTMLFormElement::oldNamedElement): Added. Returns the old element that once had a given name.
  • html/HTMLGenericFormElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::parseMappedAttribute): When the name attribute changes, tell the form about the old name. (WebCore::HTMLGenericFormElement::insertedIntoTree): When telling a form about an element, also store away the old name so that we can use it when the name changes later.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Added a call to the base class in the nameAttr case, so the code in HTMLGenericFormElement above will get called in the input element case.
7:17 AM Changeset in webkit [20147] by weinig
  • 5 edits in trunk/LayoutTests

Reviewed by Lars.

Update text in tests to match expected output.

  • fast/dom/gc-6-expected.txt:
  • fast/dom/gc-6.html:
  • fast/dom/gc-7-expected.txt:
  • fast/dom/gc-7.html:
6:36 AM Changeset in webkit [20146] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Alexey.


Test for DOS using composed character.

  • fast/text/large-text-composed-char-dos-expected.txt: Added.
  • fast/text/large-text-composed-char-dos.html: Added.

WebCore:

Reviewed by Alexey.

Alexey spotted a DOS by using string of 64k unbreakable character in
fix for ​http://bugs.webkit.org/show_bug.cgi?id=12833

  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
5:54 AM Changeset in webkit [20145] by thatcher
  • 10 edits in trunk/LayoutTests

Reviewed by Tim H.

  • fast/dom/gc-6-expected.txt: Renamed DOMHTMLElement to HTMLElement.
  • fast/dom/gc-7-expected.txt: Ditto.
  • fast/dom/prototype-chain-expected.txt: Renamed DOMHTMLElementPrototype to HTMLElementPrototype.
  • fast/dom/undetectable-document-all-expected.txt: Renamed Collection to HTMLCollection.
  • fast/dom/wrapper-classes-expected.txt: Updated for change to output for string comparison failure in fast/js/resources/js-test-pre.js.
  • fast/events/mouseclick-target-and-positioning-expected.txt: Renamed DOMHTMLElement to HTMLElement.
  • fast/tokenizer/external-script-document-write-expected.checksum: Ditto.
  • fast/tokenizer/external-script-document-write-expected.png: Ditto.
  • fast/tokenizer/external-script-document-write-expected.txt: Ditto.
3:13 AM Changeset in webkit [20144] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Tweaked again.

3:11 AM Changeset in webkit [20143] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added bug references and a period.

3:03 AM Changeset in webkit [20142] by lars
  • 2 edits in trunk/WebCore

Fix the Qt build.

2:21 AM Changeset in webkit [20141] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Have the nightly launcher prefer Safari found in /Applications or ~/Applications
if present, otherwise fall back on using LaunchServices to locate it elsewhere
on the system. The motivation for this is to make the behaviour of the nightly
builds more predictable on machines with multiple copies of Safari present.

  • WebKitLauncher/main.m: (locateSafariBundle): (main):
1:00 AM Changeset in webkit [20140] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12576
WebKit does not support xlink:show attributes

Make an exception for non-empty targets, these should be opened
in a new window, unless the value is _self.

12:32 AM Changeset in webkit [20139] by hyatt
  • 2 edits in trunk/WebCore

Double the encoded size of images for now. We do this to account for a bug in ImageIO where they hold
a separate copy of image data.

Reviewed by aroben

  • loader/CachedImage.cpp: (WebCore::CachedImage::data):

Mar 12, 2007:

9:24 PM Changeset in webkit [20138] by harrison
  • 6 edits in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4743256> ctrl-y key binding (yank) should do nothing when kill ring is empty

  • editing/pasteboard/emacs-cntl-y-001-expected.checksum:
  • editing/pasteboard/emacs-cntl-y-001-expected.png:
  • editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • editing/pasteboard/emacs-cntl-y-001.html:

WebKit:

Reviewed by Darin.

<rdar://problem/4743256> ctrl-y key binding (yank) should do nothing when kill ring is empty

Test updated:

  • editing/pasteboard/emacs-cntl-y-001.html:


  • WebView/WebHTMLView.mm: (-[WebHTMLView yank:]): (-[WebHTMLView yankAndSelect:]): Do nothing if the killring is empty.
9:05 PM Changeset in webkit [20137] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (SearchPopupMenu::enabled): add missing stub.
8:57 PM Changeset in webkit [23067] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Added new JavaScript wrapper derived source files.
8:52 PM Changeset in webkit [20136] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

  • html/HTMLFormElement.cpp: (WebCore::getUniqueBoundaryString): Speculative fix: remove dashes from the boundary prefix that appear after non-dash characters.
8:48 PM Changeset in webkit [20135] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders.

  • fast/loader/onunload-form-submit-crash-2-expected.txt: Added.
  • fast/loader/onunload-form-submit-crash-2.html: Added.

WebCore:

Reviewed by Anders.

Test: fast/loader/onunload-form-submit-crash-2.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): Added null check.
7:13 PM Changeset in webkit [20134] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove conflict marker.

7:11 PM Changeset in webkit [20133] by andersca
  • 1 edit
    1 add in trunk/LayoutTests

Add expected results.


  • fast/frames/frame-navigation-expected.txt: Added.
6:09 PM Changeset in webkit [20132] by andersca
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4900071>
​http://bugs.webkit.org/show_bug.cgi?id=6454
ASSERTION: Navigating 'back' in frameset: !_private->previousItem (6454)

  • fast/frames/frame-navigation.html: Added.
  • fast/frames/resources/frame-navigation-child.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4900071>
​http://bugs.webkit.org/show_bug.cgi?id=6454
ASSERTION: Navigating 'back' in frameset: !_private->previousItem (6454)

Change back the behavior of checkLoadComplete to traverse the entire frame tree instead of
just the parent frames of the current frame. This is needed in order to reset the previous history item
for all frames when doing a frame navigation. (This was changed in revision 11819)


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::recursiveCheckLoadComplete): (WebCore::FrameLoader::checkLoadComplete):
  • loader/FrameLoader.h:
5:53 PM Changeset in webkit [20131] by justing
  • 3 edits
    4 adds in trunk

Reviewed by darin


<rdar://problem/5056619>
REGRESSION: Gmail Editor: Dragging text into Reply (textarea) field results in a crash at WebCore::InsertNodeBeforeCommand::doApply()


  • editing/SelectionController.cpp: (WebCore::removingNodeRemovesPosition): Added. (WebCore::SelectionController::nodeWillBeRemoved): Clear the selection if it's inside a shadow tree.
  • page/DragController.cpp: (WebCore::setSelectionToDragCaret): Return false to signal to clients that a drop shouldn't be performed if the second attempt to set a selection ends up in non-editable content.
5:49 PM Changeset in webkit [20130] by darin
  • 39 edits
    2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • added a test that checks the classes of wrappers created by both the JavaScript binding and the Objective-C binding
  • fast/dom/wrapper-classes-expected.txt: Added.
  • fast/dom/wrapper-classes.html: Added.
  • fast/js/resources/js-test-pre.js: Improve the format of the failure message when both the real results and expected results are strings.

WebCore:

Reviewed by Tim Hatcher.

  • fixed JavaScript wrapper classes to be correct for a variety of cases that a new test uncovered: was broken for at least 5 classes
  • fixed Objective-C wrapper classes to be correct for a variety of cases that a test case uncovered: was broken for ast least 50 classes
  • added missing DOM API for creating OverflowEvent and WheelEvent instances

Test: fast/dom/wrapper-classes.html

  • DerivedSources.make: Added missing bindings: HTMLCanvasElement for ObjC, CDATASection, Comment, and EntityReference for JavaScript.
  • WebCore.xcodeproj/project.pbxproj: Added those new generated files.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper): Corrected the wrapper classes for <keygen>, which needs an HTMLSelectElement wrapper, and <xmp>, which needs an HTMLPreElement wrapper.
  • bindings/objc/DOMInternal.h: Updated for new naming scheme. Also moved createDOMWrapper from the KJS namespace to the WebCore namespace.
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper): Broke the core function into a separate one, and left it in the KJS namespace because Objective-C++ rules make it impossible for it to work in the WebCore namespace. Used a macro-based implementation to cut down on repeated code, and added missing cases for Counter, HTMLOptionsCollection, Range, XPathExpression, XPathResult, Event, RGBColor, Rect, Window, DOMImplementation, NodeIterator, TreeWalker, and HTMLCollection. (WebCore::createDOMWrapper): The other half of the function.
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): Corrected the wrapper classes for <canvas>, which needs a DOMHTMLCanvasElement wrapper, <del>, which needs a DOMHTMLModElement wrapper, <embed>, which needs a DOMHTMLEmbedElement wrapper, <ins>, which needs a DOMHTMLModElement wrapper, <th>, which needs a DOMHTMLTableCellElement wrapper, and <xmp>, which needs an DOMHTMLPreElement wrapper. (+[DOMNode _wrapNode:]): Updated for new naming scheme. (+[DOMNode _wrapEventTarget:]): Ditto. (+[DOMNodeFilter _wrapNodeFilter:]): Ditto. (ObjCNodeFilterCondition::acceptNode): Ditto. (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Ditto. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Ditto. (WebCore::ObjCEventListener::handleEvent): Ditto.
  • dom/Document.cpp: (WebCore::Document::createEvent): Added cases for OverflowEvent and WheelEvent.
  • dom/OverflowEvent.h: Added empty constructor and initOverflowEvent.
  • dom/OverflowEvent.cpp: (WebCore::OverflowEvent::OverflowEvent): Added. (WebCore::OverflowEvent::initOverflowEvent): Added.
  • dom/OverflowEvent.idl: Added initOverflowEvent.
  • bindings/objc/PublicDOMInterfaces.h: Added initOverflowEvent.
  • bindings/objc/DOMCSS.mm: (+[DOMStyleSheet _wrapStyleSheet:]): Updated for new naming scheme. (+[DOMCSSRule _wrapCSSRule:]): Corrected wrapper for CSSUnknownRule. (+[DOMCSSValue _wrapCSSValue:]): Updated for new naming scheme.
  • bindings/js/kjs_css.h: (KJS::DOMRGBColor::impl): Added. Used when making an ObjC wrapper. (KJS::DOMRect::impl): Ditto.
  • bindings/js/kjs_dom.cpp: (KJS::toJS): Corrected the wrapper classes for CDATASection, Comment, and EntityReference.
  • bindings/js/kjs_html.cpp: Corrected the class name for HTMLElement (was "DOMHTMLElement") and HTMLCollection (was "Collection").
  • bindings/objc/DOMImplementationFront.h:
  • bindings/objc/DOMImplementationFront.cpp: (WebCore::implementationFront): Added new overload that returns a front given a JavaScript wrapper. Needed by the code that makes the Objective-C wrapper.
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]): Updated since createDOMWrapper is now in the WebCore namespace.
  • bindings/scripts/CodeGeneratorObjC.pm: Update the naming scheme for the wrapper creation functions to use _wrapElement: rather then _elementWith: style. Removed now-unneeded special cases for things that needed to stay upper-case, since we don't have to do the whole lcfirst thing.
  • html/HTMLCanvasElement.idl: Added #if so we can successfully generate the Objective-C wrapper for this class, even though we can't yet handle the DOMObject return type.
  • html/HTMLOptionsCollection.idl: Added GenerateNativeConverter so we get an appropriate toJS function.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]):
  • bindings/objc/DOMObject.mm: (-[DOMObject sheet]):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (+[DOMRGBColor _wrapRGBColor:]):
  • bindings/objc/DOMSVGPathSegInternal.mm: (+[DOMSVGPathSeg _wrapSVGPathSeg:]):
  • bindings/objc/DOMXPath.mm: (+[DOMNativeXPathNSResolver _wrapXPathNSResolver:]):
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nodesFromList:]): (-[WebCoreFrameBridge elementWithName:inForm:]): (-[WebCoreFrameBridge formForElement:]): (-[WebCoreFrameBridge currentForm]): (-[WebCoreFrameBridge controlsInForm:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge convertNSRangeToDOMRange:]): (-[WebCoreFrameBridge markDOMRange]): (-[WebCoreFrameBridge markedTextDOMRange]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreFrameBridge documentFragmentWithText:inContext:]): (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]): (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]): (-[WebCoreFrameBridge dragCaretDOMRange]): (-[WebCoreFrameBridge editableDOMRangeForPoint:]): (-[WebCoreFrameBridge characterRangeAtPoint:]): (-[WebCoreFrameBridge typingStyle]): (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): Updated for new naming scheme.

WebKit:

Reviewed by Tim Hatcher.

  • update for the new naming scheme for the Objective-C wrapper-creation functions: _wrapElement: instead of _elementWith:, etc.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): (WebFrameLoaderClient::createJavaAppletWidget):
  • WebView/WebFrame.mm: (kit): Use the _wrapElement-style functions.
5:34 PM Changeset in webkit [20129] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4990691> REGRESSION: Selecting text in Adium's Messages field causes horizontal shift

Corrected the recursive point conversion and scrolling done in scrollPointRecursively to use the
document view of each NSClipView.

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollPointRecursively): Call convertPoint:fromView: on the document views, not the clip views as we encounter them. Then call constrainScrollPoint: on the converted point to constrain to the document view bounds. And finally call scrollPoint: on the document view, not the clip view.
5:07 PM Changeset in webkit [20128] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • add a DumpRenderTree feature where you can get the Objective-C class name of a JavaScript object
  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): Add the objCClassNameOf: selector. (+[LayoutTestController webScriptNameForSelector:]): Add the objCClassNameOf: selector, with the name "objCClassName". (-[LayoutTestController objCClassNameOf:]): Added.
4:57 PM Changeset in webkit [20127] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Alexey


Test that this works correctly with composed characters
​http://bugs.webkit.org/show_bug.cgi?id=12833
REGRESSION: Selecting text in 6.6MB txt file is sluggish as of the Feb 19th nightly
<rdar://problem/5028159>

  • fast/text/large-text-composed-char-expected.checksum: Added.
  • fast/text/large-text-composed-char-expected.png: Added.
  • fast/text/large-text-composed-char-expected.txt: Added.
  • fast/text/large-text-composed-char.html: Added.

WebCore:

Reviewed by Alexey.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12833
REGRESSION: Selecting text in 6.6MB txt file is sluggish as of the Feb 19th nightly
<rdar://problem/5028159>


Divide large text blocks (>64kB) over multiple text nodes. This limits linebox searches to
a manageable subset.


  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  • dom/Text.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
4:48 PM Changeset in webkit [20126] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression in printing. Printer fonts need to be part of the
font cache key, since printer fonts have different glyph widths.
(Integer antialiasing is used for screen fonts but not for printer fonts.)

Reviewed by aroben

  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontCache::getCachedFontPlatformData):
4:07 PM Changeset in webkit [20125] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/5057575>
REGRESSION: Repro Crash in FrameLoader::frame loading about:blank in PLT


Always get the web view from the current web frame, since the document loader's frame can have been zeroed out
(for example when detaching the document loader).


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading):
2:58 PM Changeset in webkit [23066] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5054694>
Repro crash when viewing fast/dom/HTMLObjectElement/object-as-frame.html


  • bridge/win/FrameWin.cpp: (WebCore::Frame::createScriptInstanceForWidget): Return 0 for frame views.
2:32 PM Changeset in webkit [20124] by lars
  • 2 edits in trunk/WebCore

add missing symbol to fix the Qt build again.

2:23 PM Changeset in webkit [23065] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5054713>
Crash in suggestedFilenameForResponse in two fast/encoding tests.


Add null checks.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::suggestedFilenameForResponse):
1:45 PM Changeset in webkit [23064] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix for <rdar://problem/5053618> Disable "recent searches" search field menu.

  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::enabled):
1:43 PM Changeset in webkit [20123] by adele
  • 4 edits in trunk/WebCore

Reviewed by Oliver.

Adding the ability to enable or disable a SearchPopupMenu.

  • platform/SearchPopupMenu.h:
  • platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenu::enabled):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::showPopup):
1:17 PM Changeset in webkit [20122] by rwlbuis
  • 17 edits in trunk

Reviewed by Nikolas Zimmermann.

​http://bugs.webkit.org/show_bug.cgi?id=12500
SVG fails to correctly handle all link style selectors
​http://bugs.webkit.org/show_bug.cgi?id=12567
<text> elements ignore <a> children

Allow <a> inside svg text and handle xlink:show.

12:05 PM Changeset in webkit [20121] by kmccullo
  • 32 edits in trunk/JavaScriptCore

Reviewed by .

  • Actually update tests for new DST rules.
  • tests/mozilla/ecma/Date/15.9.3.1-1.js:
  • tests/mozilla/ecma/Date/15.9.3.1-2.js:
  • tests/mozilla/ecma/Date/15.9.3.1-3.js:
  • tests/mozilla/ecma/Date/15.9.3.1-4.js:
  • tests/mozilla/ecma/Date/15.9.3.1-5.js:
  • tests/mozilla/ecma/Date/15.9.3.2-1.js:
  • tests/mozilla/ecma/Date/15.9.3.2-2.js:
  • tests/mozilla/ecma/Date/15.9.3.2-3.js:
  • tests/mozilla/ecma/Date/15.9.3.2-4.js:
  • tests/mozilla/ecma/Date/15.9.3.2-5.js:
  • tests/mozilla/ecma/Date/15.9.3.8-1.js:
  • tests/mozilla/ecma/Date/15.9.3.8-2.js:
  • tests/mozilla/ecma/Date/15.9.3.8-3.js:
  • tests/mozilla/ecma/Date/15.9.3.8-4.js:
  • tests/mozilla/ecma/Date/15.9.3.8-5.js:
  • tests/mozilla/ecma/Date/15.9.5.10-1.js:
  • tests/mozilla/ecma/Date/15.9.5.10-10.js:
  • tests/mozilla/ecma/Date/15.9.5.10-11.js:
  • tests/mozilla/ecma/Date/15.9.5.10-12.js:
  • tests/mozilla/ecma/Date/15.9.5.10-13.js:
  • tests/mozilla/ecma/Date/15.9.5.10-2.js:
  • tests/mozilla/ecma/Date/15.9.5.10-3.js:
  • tests/mozilla/ecma/Date/15.9.5.10-4.js:
  • tests/mozilla/ecma/Date/15.9.5.10-5.js:
  • tests/mozilla/ecma/Date/15.9.5.10-6.js:
  • tests/mozilla/ecma/Date/15.9.5.10-7.js:
  • tests/mozilla/ecma/Date/15.9.5.10-8.js:
  • tests/mozilla/ecma/Date/15.9.5.10-9.js:
  • tests/mozilla/ecma/jsref.js:
  • tests/mozilla/ecma_2/jsref.js:
  • tests/mozilla/ecma_3/Date/shell.js:
11:56 AM Changeset in webkit [23063] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Anders.

  • Skipped: Updated for current set of crashing tests.
11:56 AM Changeset in webkit [23062] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Darin.

Get DRT to size the WebView correctly, and added font family prefs.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Make the DRT window an off-screen tool window so it isn't visible to the user despite having been "shown". (initializePreferences): Set font preferences. (main): Initially size the WebView to 0x0, then do a SetWindowPos to the desired size (this is what Boomer does).
11:52 AM Changeset in webkit [23061] by adele
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.


WebCore part of fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)

  • platform/win/KeyEventWin.cpp: (WebCore::singleCharacterString): Added inline keyword. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Renamed arguments to be more meaningful. Added characterCode argument to be used when constructing m_text.

WebKitWin:

Reviewed by Oliver.

Fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)

Removed special handling of the WM_CHAR message. All this work is now done by WM_KEYDOWN, which will dispatch the keydown event,
which causes the keypress event to be dispatched, which calls WebEditorClient::handleKeyPress to do all the hard work.


  • WebEditorClient.cpp: (WebEditorClient::handleKeypress): Removed special call to doTextFieldCommandFromEvent since this will now happen during normal key event processing. Call handleEditingKeyboardEvent. Now editing actions can be prevented from the keypress event handler.
  • WebView.cpp: (WebView::WebView): Added m_currentCharacterCode, so we can reuse the computed code from keyDown for keyUp events. (WebView::keyUp): Renamed arguments. Don't dispatch event for shift, ctrl, or capslock keys. Use m_currentCharacterCode when constructing the PlatformKeyboardEvent. (WebView::handleEditingKeyboardEvent): Now takes a KeyboardEvent instead of a PlatformKeyboardEvent. If no editCommand is created from the event, then call handleTextInputEvent. (WebView::keyDown): Peek at the next message in the message loop. If its a WM_CHAR, then get the character code and remove that message from the queue. Renamed arguments. Don't dispatch event for shift, ctrl, or capslock keys. Set m_currentCharacterCode and use it when constructing the PlatformKeyboardEvent. (WebViewWndProc): Removed handling of WM_CHAR, since this is now done from WM_KEYDOWN by dispatching the keydown event, which will eventually call handleKeyPress.
  • WebView.h: Made handleEditingKeyboardEvent public so it can be accessed from WebEditorClient.
11:49 AM Changeset in webkit [20120] by adele
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Add a missing parameter to the constructor.

  • platform/PlatformKeyboardEvent.h:
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
11:45 AM Changeset in webkit [20119] by brmorris
  • 2 edits in S60/trunk/WebKit

hongzhao, reviewed by ​Yongjun.zhang@nokia.com

DESC: Part 2/2 (see also r20116). Plugin Window shouldn't cover the scroll bars when it's oversize HZHO-6YZR4X
Fix: Calculate the clipRect based on the Browser mainframe rect and the plugin object rect and use it as the plugin cliprect.
​http://bugs.webkit.org/show_bug.cgi?id=13003

11:15 AM Changeset in webkit [23060] by adele
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Updating ChangeLog w/ revision

11:11 AM Changeset in webkit [23059] by adele
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Forking KeyEventWin.cpp.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/KeyEventWin.cpp: Added.
10:44 AM Changeset in webkit [20118] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by .

  • Update tests for new DST rules.
  • tests/mozilla/ecma/shell.js:
9:47 AM Changeset in webkit [20117] by brmorris
  • 23 edits in S60/trunk

borges, reviewed by Bradley

DESC: related with task 14594 for S60 build feature work
​http://bugs.webkit.org/show_bug.cgi?id=13027

8:31 AM Changeset in webkit [20116] by brmorris
  • 4 edits in S60/trunk/WebKit

hongzhao, reviewed by ​Yongjun.zhang@nokia.com

DESC: Plugin Window shouldn't cover the scroll bars if they are oversize HZHO-6YZR4X
Fix: Intersects the plugin object rect and the rect of main frame in Browser, then set it as clip rect to pass for plugin window.
​http://bugs.webkit.org/show_bug.cgi?id=13003

8:09 AM Changeset in webkit [20115] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/4681051> Installer crashes in KJS::Collector::
markOtherThreadConservatively(KJS::Collector::Thread*) trying to install
iLife 06 using Rosetta on an Intel Machine


The problem was that our thread-specific data destructor would modify the
list of active JavaScript threads without holding the JSLock, corrupting
the list. Corruption was especially likely if one JavaScript thread exited
while another was starting up.

  • JavaScriptCore.exp:
  • kjs/JSLock.cpp: Don't conflate locking the JSLock with registering a thread, since the thread-specific data destructor needs to lock without registering a thread. Instead, treat thread registration as a part of the convenience of the JSLock object, and whittle down JSLock::lock() to just the bits that actually do the locking. (KJS::JSLock::lock): (KJS::JSLock::registerThread):
  • kjs/JSLock.h: Updated comments to mention the new behavior above, and other recent changes. (KJS::JSLock::JSLock):
  • kjs/collector.cpp: (KJS::destroyRegisteredThread): Lock here. (KJS::Collector::registerThread): To match, assert that we're locked here.

JavaScriptGlue:

Reviewed by Oliver Hunt.


Updated in light of fix for <rdar://problem/4681051> Installer crashes
in KJS::Collector::markOtherThreadConservatively(KJS::Collector::Thread*)
trying to install iLife 06 using Rosetta on an Intel Machine


  • JavaScriptGlue.cpp: (JSLockInterpreter): Ensure backwards compatibility by calling registerThread() when explicitly taking the JSLock. (This doesn't happen automatically anymore.) I doubt this actally matters, but in JavaScriptGlue territory, that kind of thinking will get you killed.

WebKitTools:

Reviewed by Oliver Hunt.


Beefed up --threaded mode in light of <rdar://problem/4681051> Installer
crashes in KJS::Collector::markOtherThreadConservatively(KJS::Collector::Thread*)
trying to install iLife 06 using Rosetta on an Intel Machine


--threaded mode now runs a bunch of different JavaScript threads, randomly
killing and respawning them. This was sufficient for reproducing the
bug on my MacBook Pro.

  • DumpRenderTree/DumpRenderTree.m: (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads): (dumpRenderTree):
8:02 AM Changeset in webkit [20114] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

fhodgkin, Reviewed by sachin

DESC: merge r20113 to s60's 3.1m branch. crash when exiting browser after trying to load a big file: TMCN-6YDJPJ
​http://bugs.webkit.org/show_bug.cgi?id=12967

8:00 AM Changeset in webkit [20113] by brmorris
  • 2 edits in S60/trunk/WebKit

fhodgkin, Reviewed by sachin

DESC: crash when exiting browser after trying to load a big file: TSW TMCN-6YDJPJ
​http://bugs.webkit.org/show_bug.cgi?id=12967

2:18 AM Changeset in webkit [20112] by lars
  • 7 edits in trunk/WebCore

Fix the Qt build. I still get crashes though :/

Note: See TracTimeline for information about the timeline view.