⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 16, 2007:

9:59 PM Changeset in webkit [20258] by oliver
  • 14 edits in trunk

2007-03-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.

WebCore:

The old canSaveAsWebArchive call was necessary as stand alone
images used to be rendered by ImageDocument.

Fixes rdar://problem/5061252

  • dom/Clipboard.cpp:
  • dom/Clipboard.h: (WebCore::Clipboard::setDragHasStarted):
  • page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage):

WebKit:

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage):
  • WebKit.xcodeproj/project.pbxproj:

LayoutTests:

Updating layout test to allow stand alone image to be
dragged into a content editable div

  • fast/events/standalone-image-drag-to-editable-expected.checksum:
  • fast/events/standalone-image-drag-to-editable-expected.png:
  • fast/events/standalone-image-drag-to-editable-expected.txt:
  • fast/events/standalone-image-drag-to-editable.html:
6:23 PM Changeset in webkit [23100] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver

Make the WebDownload fix a little more correct.


  • WebDownload.cpp: (WebDownload::init): Release the connection from the ResourceHandle after the CFURLDownload has been created
6:01 PM Changeset in webkit [20257] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4869095>
default content type changed for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
5:43 PM Changeset in webkit [20256] by thatcher
  • 4 edits in trunk

64-bit build fix.

5:36 PM Changeset in webkit [20255] by beidson
  • 2 edits in trunk/LayoutTests

Reviewed by Braveheart

Updated layouttest results because I added a window property

  • fast/dom/Window/window-properties-expected.txt:
4:57 PM Changeset in webkit [20254] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Tim Hatcher

Update the hash table header for Window object properties

  • bindings/js/kjs_window.cpp:
4:49 PM Changeset in webkit [20253] by beidson
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders

<rdar://problem/5061826> and
​http://bugs.webkit.org/show_bug.cgi?id=12863
Implement window.stop()

  • http/tests/misc/window-dot-stop-expected.txt: Added.
  • http/tests/misc/window-dot-stop.html: Added.

WebCore:

Reviewed by Anders

<rdar://problem/5061826> and
​http://bugs.webkit.org/show_bug.cgi?id=12863
Implement window.stop()

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add case Window::Stop
  • bindings/js/kjs_window.h: (KJS::Window::): Add "Stop"
4:41 PM Changeset in webkit [23099] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Lou.

Fix for <rdar://problem/5065040> cannot mousedown + drag in a <select> menu

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Set the capture when the popup window comes up. (WebCore::PopupWndProc): Release the capture only when the mouse is not down, and the mouse moves outside the popup window, or if you mouse up inside the window, and you're about to hide the popup. The mouse will get recaptured if you mouse down again in the window.
4:19 PM Changeset in webkit [20252] by thatcher
  • 4 edits in trunk

Adding ChangeLog markers.

4:18 PM Changeset in webkit [20251] by thatcher
  • 1 edit in tags/Safari-5522.4/JavaScriptGlue/Info.plist

Versioning.

4:16 PM Changeset in webkit [20250] by thatcher
  • 1 edit in tags/Safari-5522.4/JavaScriptCore/Info.plist

Versioning.

4:14 PM Changeset in webkit [20249] by thatcher
  • 1 edit in tags/Safari-5522.4/WebKit/Info.plist

Versioning.

4:12 PM Changeset in webkit [20248] by thatcher
  • 1 edit in tags/Safari-5522.4/WebCore/Info.plist

Versioning.

4:11 PM Changeset in webkit [23098] by ggaren
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Dave Hyatt.


Fixed "called Frame::paint with nil renderer" console messages.
You can now launch and exit the app without seeing any
error messages!

  • WebView.cpp: (WebView::paintIntoBackingStore): Only tell the FrameView to paint if it has a renderer. This isn't an issue on the Mac because we don't create a FrameView until you load a page.
4:11 PM Changeset in webkit [20247] by thatcher
  • 3 edits in tags/Safari-5522.4/WebCore

Merging fix for r20228.

4:09 PM Changeset in webkit [20246] by thatcher
  • 18 edits in tags/Safari-5522.4/WebCore

Merging fix for r20214.

4:03 PM Changeset in webkit [20245] by thatcher
  • 1 copy in tags/Safari-5522.4

New tag from r20197.

3:39 PM Changeset in webkit [20244] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

fixed changelog order -- do you need a changelog entry for a changelog fix???

3:37 PM Changeset in webkit [20243] by ggaren
  • 2 edits in trunk/WebCore

Fix for 13084, assertion failure in the Cache. Convert the client list
to a HashCountedSet so that multiple refs and derefs are allowed.

Fix RenderImage so that if it has the same image used as a background/border
and as the foreground that it will repaint properly (can be tested using
border-image and a foreground image).

Optimize list marker so that it doesn't waste time in the base class method,
since list markers don't support background or border images.

Reviewed by andersca

  • ChangeLog:
  • loader/CachedResource.cpp: (WebCore::CachedResource::ref):
  • loader/CachedResource.h:
  • loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
  • loader/CachedResourceClientWalker.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged):
3:29 PM Changeset in webkit [20242] by hyatt
  • 7 edits in trunk/WebCore

Fix for 13084, assertion failure in the Cache. Convert the client list
to a HashCountedSet so that multiple refs and derefs are allowed.

Fix RenderImage so that if it has the same image used as a background/border
and as the foreground that it will repaint properly (can be tested using
border-image and a foreground image).

Optimize list marker so that it doesn't waste time in the base class method,
since list markers don't support background or border images.

Reviewed by andersca

  • ChangeLog:
  • loader/CachedResource.cpp: (WebCore::CachedResource::ref):
  • loader/CachedResource.h:
  • loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
  • loader/CachedResourceClientWalker.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged):
3:26 PM Changeset in webkit [20241] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Attempt to fix the 64-bit build.

3:04 PM Changeset in webkit [23097] by andersca
  • 5 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Add setters and getters for cookie storage accept policy.


  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::cookieStorageAcceptPolicy): (WebPreferences::setCookieStorageAcceptPolicy):
  • WebPreferences.h:
1:22 PM Changeset in webkit [23096] by andersca
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Add Radar

1:16 PM Changeset in webkit [23095] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam and Dave Hyatt.

Fix acid2 test.


  • WebFrame.cpp: (WebFrame::shouldFallBack): Implement this function.
1:10 PM Changeset in webkit [20240] by ggaren
  • 5 edits in trunk/WebCore

Reviewed by Anders Carlsson.


Fixed <rdar://problem/5065399> REGRESSION: leaks in Frame::bindingRootObject
seen on buildbot

The problem was that we were initializing the same WebScriptObject twice.
This caused it to leak its original set of ivars.


I think some refactoring could prevent this situation from arising in the
first place, but I'm just adding a check at the call site for now, to do
the simplest thing.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setImp:originRootObject:rootObject:]): Added ASSERTs against multiple calls.
  • bindings/objc/WebScriptObjectPrivate.h: Renamed _initializeWithObjectImp to setImp because "init" vs "initialize" was a too subtle indication that one was a Cocoa initializer and one was not.
12:27 PM Changeset in webkit [23094] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-03-16 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Steve.


Implemented a couple of DOM methods so we can set the font-size of an element directly in the app.

  • DOMCSSClasses.cpp: (DOMCSSStyleDeclaration::setProperty):
  • DOMCoreClasses.cpp: (DOMElement::style):
10:47 AM Changeset in webkit [20239] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by <yongjun>

DESC: Prevent unnecessary redraws.
​http://bugs.webkit.org/show_bug.cgi?id=13093
TSW ID: RCHI-6Z2V49

10:45 AM Changeset in webkit [20238] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

yinxcai, reviewed by <Yongjun>

DESC: TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly
​http://bugs.webkit.org/show_bug.cgi?id=12901

7:33 AM Changeset in webkit [20237] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan.
DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
​http://bugs.webkit.org/show_bug.cgi?id=13074

5:40 AM Changeset in webkit [20236] by lars
  • 2 edits in trunk/WebCore

don't use #import in .cpp files.

5:36 AM Changeset in webkit [20235] by lars
  • 6 edits in trunk

Fix the Qt build once again.

2:52 AM Changeset in webkit [23093] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/PasteboardWin.cpp

Fix boomer build bustage.

Mar 15, 2007:

11:52 PM Changeset in webkit [20234] by bdash
  • 3 edits in trunk/WebCore

2007-03-15 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Gdk build fix.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::blockedError):
  • loader/gdk/FrameLoaderClientGdk.h:
11:50 PM Changeset in webkit [20233] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13088 REGRESSION
(r19761-19779): Copy image no longer includes image address
(rdar://5067927)

writeURL() does not need an isImage parameter. Now that it accepts
the types as a parameter, we can just declare the appropriate image
types within writeImage and send them to writeURL(). Also,
declaring the types twice is what broke this.

  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage):
11:18 PM Changeset in webkit [20232] by adele
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

Fix for <rdar://problem/4926179> Text in menulist control should never update if menu is open

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Only setTextFromOption if the menu isn't visible.
10:36 PM Changeset in webkit [23092] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Ada.

Fixing some leaks

  • WebFrame.cpp: (WebFrame::dispatchDidReceiveAuthenticationChallenge): (WebFrame::dispatchDidCancelAuthenticationChallenge):
10:31 PM Changeset in webkit [23091] by beidson
  • 4 edits in branches/WindowsMerge

WebKitWin:

Reviewed by Oliver

CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
This might fix some of the random crashers we see on stress testing if they end up
downloading links.

  • WebDownload.cpp: (WebDownload::init): Release the connection from the handle so it no longer refers to it

WebCoreWin:

Reviewed by Oliver

CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
This might fix some of the random crashers we see on stress testing if they end up
downloading links.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Always call cancel if theres a connection - the ref-count-check hack is no longer neccesary (WebCore::ResourceHandle::releaseConnectionForDownload): Give up the CFURLConnection without derefing it


10:25 PM Changeset in webkit [20231] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Oliver

A few platform specific tweaks

  • platform/cf/RetainPtr.h: (WebCore::RetainPtr::releaseRef): Fixed releaseRef to work with CF


  • platform/network/ResourceHandle.h: Added a "releaseRef" style call
10:25 PM Changeset in webkit [20230] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed.


  • build fix
  • wtf/TCSystemAlloc.cpp:
10:22 PM Changeset in webkit [23090] by mjs
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff and Steve.


  • fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
  • fixes to use FastMalloc on Windows
  • config.h: Don't force USE_SYSTEM_MALLOC

WebKitWin:

Reviewed by Geoff and Steve.


  • fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
  • fixes to use FastMalloc on Windows
  • WebKit.vcproj/WebKit.def: Add exports of WTF symbols.
  • WebKit.vcproj/WebKit_debug.def: ditto
  • WebKit.vcproj/WebKit.vcproj: Link pthreads, now needed by WTF.
10:12 PM Changeset in webkit [20229] by mjs
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff and Steve.


  • fix some portability issues with TCMalloc.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • kjs/config.h:
  • wtf/FastMalloc.cpp: (WTF::SizeClass): (WTF::InitSizeClasses): (WTF::TCMalloc_PageHeap::Split): (WTF::TCMalloc_PageHeap::RegisterSizeClass): (WTF::TCMalloc_Central_FreeList::length): (WTF::TCMalloc_ThreadCache::InitTSD): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
  • wtf/TCSpinLock.h:
  • wtf/TCSystemAlloc.cpp: (TryVirtualAlloc): (TCMalloc_SystemAlloc):

WebCore:

Reviewed by Geoff and Steve.

  • config.h: Remove unneeded hack.
9:45 PM Changeset in webkit [23089] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Alice


Due to OpenSource r20178, all of the sudden we were trying to handle page caching on Windows
even though it is not hooked up yet. The resulted in very particular cases ending up calling
clear() in FrameLoader::provisionalLoadStarted(). One such particular case was if a page *would*
be "cachable" (no frames, no passwords, etc etc), and you start a download from that page.


The fix for now is to manually set the pageCacheSize to 0 whenever we create new pages on Windows.
This prevents the "Should I cache this page?" checking from getting far enough to clear the document.
It so happens this involves exactly one line.


  • WebView.cpp: (WebView::initWithFrame): Set page cache size to zero on new pages, and add a fixme to remove later
9:22 PM Changeset in webkit [20228] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5062376>
REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied

  • editing/execCommand/5062376-expected.checksum: Added.
  • editing/execCommand/5062376-expected.png: Added.
  • editing/execCommand/5062376-expected.txt: Added.
  • editing/execCommand/5062376.html: Added.

WebCore:

Reviewed by john


<rdar://problem/5062376>
REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied


Bring back the remove step in applyBlockStyle. It's
necessary because addBlockStyleIfNeeded assumes that
the properties it adds aren't already on the block that
it adds them to.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Bring back the remove step (added a testcase). Don't do the add step if m_removeOnly is true (no testcase because there aren't any clients using removeOnly functionality to remove styles yet, only styled elemets). Moved the code for creating new blocks up one level to this function so that we can pass blocks to removeCSSStyle. When converting VisiblePositions to indices and vice versa, use the highest node in the shadow tree if we're in one as the scope (working on a testcase). (WebCore::ApplyStyleCommand::addBlockStyle): Moved code to applyBlockStyle.
  • editing/ApplyStyleCommand.h:
8:16 PM Changeset in webkit [23088] by beidson
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's


  • Interfaces/IWebError.idl: Add the custom error code for blocked error
  • WebFrame.cpp: (WebFrame::blockedError): FrameLoaderClient fill-in + a Fixme (WebFrame::interruptForPolicyChangeError): Add a Fixme for localization
  • WebFrame.h:
8:12 PM Changeset in webkit [20227] by beidson
  • 17 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adele

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's

The layout test attempts to load an image at an invalid domain name on each
of the black listed ports. Using dumpResourceLoadCallbacks(), DRT is able
to see the error codes for each resource. A successful test shows the blocked
error for each image load except for the few that are standard or should
succeed due to exemptions.

  • security/block-test-expected.txt: Added.
  • security/block-test.html: Added.

WebCore:

Reviewed by Maciej

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::blockedError): Call through to the client for blockedError
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h: Get the "port blocked" error for the current platform
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::wasBlocked): ResourceHandleClient method to pass on the didFail(error) (WebCore::ResourceLoader::blockedError): Following the pattern of "CancelledError()", get the error to fail with for the didFail() call
  • loader/ResourceLoader.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::blockedError): Added stub
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): If the port is blocked, create the handle but schedule it for deferred failure on a timer (WebCore::ResourceHandle::scheduleBlockedFailure): Do the timer scheduling (WebCore::ResourceHandle::fireBlockedFailure): Fire the timer here (WebCore::ResourceHandle::portAllowed): Implements checking of Mozilla's
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::wasBlocked): Virtual for clients to get the "blocked" message

WebKit:

Reviewed by Maciej

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's

  • English.lproj/Localizable.strings: Added localizable string for port blocked error code
  • Misc/WebKitErrors.h:
  • Misc/WebKitErrors.m: (registerErrors): Add new port blocked error code to WebKitErrorDomain
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::cancelledError): Fixed coding style (WebFrameLoaderClient::blockedError): Return a ResourceError with the new custom error code
6:16 PM Changeset in webkit [20226] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Yet another build fix.

5:55 PM Changeset in webkit [20225] by thatcher
  • 8 edits in trunk

Finally a real build fix.

5:37 PM Changeset in webkit [20224] by thatcher
  • 1 edit in trunk/JavaScriptGlue/JavaScriptGlue.h

Yet another build fix. Sigh.

5:33 PM Changeset in webkit [23087] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Ada.

Second part of two-step dance to rename AHEM.TTF to AHEM.ttf.

This is to work around <rdar://problem/5063416>.

Also made all the ttf files in DumpRenderTree/Resources executable again to appease Windows.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/AHEM.ttf: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/renameMe.ttf: Removed.
5:25 PM Changeset in webkit [20223] by thatcher
  • 1 edit in trunk/JavaScriptGlue/Configurations/JavaScriptGlue.xcconfig

Another build fix attempt.

5:15 PM Changeset in webkit [20222] by thatcher
  • 1 edit in trunk/JavaScriptCore/Configurations/JavaScriptCore.xcconfig

Attempt to fix the build.

5:07 PM Changeset in webkit [20221] by thatcher
  • 4 edits in trunk

Build fix.

5:04 PM Changeset in webkit [20220] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5065396> REGRESSION: leaks in
RenderBlock::layoutInlineChildren seen on buildbot

This leak appeared after ​http://trac.webkit.org/projects/webkit/
changeset/20188. This change shifted line boxes around in
removeChild(). But since removeChild() calls
setNeedsLayoutAndMinMaxRecalc(), all of the line boxes will be
removed once we actually lay out anyway. So this patch fixes the
leak by deleting the line boxes instead of shifting them around.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): Call into updateLayout(). This fixes an assertion I got in editing/ execCommand/4976800.html This is very similar to the line box fix I made recently (​http://trac.webkit.org/projects/webkit/changeset/ 20177). We need to update layout before relying on VisiblePositions after removing a node.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::deleteLinesForBlock): New helper function since this functionality is needed in three places now. (WebCore::RenderBlock::makeChildrenNonInline): Call into new deleteLinesForBlock(). (WebCore::RenderBlock::removeChild): Same.
  • rendering/RenderBlock.h:
4:50 PM Changeset in webkit [20219] by thatcher
  • 14 edits
    20 adds in trunk

JavaScriptCore:

Reviewed by John.

  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/JavaScriptCore.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Info.plist:
  • JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by John.

  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/JavaScriptGlue.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Info.plist:
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by John.

  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Configurations/WebCore.xcconfig: Added.
  • Info.plist:
  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by John.

  • Fixes: <rdar://problem/4927747> WebKit's Current Library Version number should match the Info.plist Version
  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Make WebKit use the same warning flags as the other projects. This required two casts to be added to fix new warnings.
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Configurations/WebKit.xcconfig: Added.
  • Info.plist:
  • Misc/WebKitVersionChecks.h:
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
  • WebKit.xcodeproj/project.pbxproj:
4:33 PM Changeset in webkit [23086] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:30 PM Changeset in webkit [20218] by sfalken
  • 1 copy in tags/Safari-521.35.9b

New tag.

3:25 PM Changeset in webkit [23085] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Ada.

First part of a two-step dance to rename AHEM.TTF to AHEM.ttf.

First, rename AHEM.TTF to renameMe.ttf.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/AHEM.TTF: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/renameMe.ttf: Added.
3:20 PM Changeset in webkit [23084] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Rubberstamped by Hyatt.

  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): Move the code to get the font face to the top of the function for easier debugging.
  • platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): ASSERT that we got a valid CGFontRef back from CG, as CG and GDI should agree on the fonts installed.
2:42 PM Changeset in webkit [23083] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Adele.

  • Skipped: Turn off AppleScript tests.
2:37 PM Changeset in webkit [23082] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Brady.

  • WebKitLogging.cpp: Turn of Download logging by default.
2:28 PM Changeset in webkit [20217] by kdecker
  • 5 edits in trunk/WebKit

Reviewed by Anders.

Fixed: <rdar://problem/5001428> stationery background images do not display


Change 19244 fixed the method -[WebResource _shouldIgnoreWhenUnarchiving], but also broke Mail stationery.


The problem was that with archivedResourceForURL now fixed, the engine will try to decode the images. These images wouldn't decode because
Mail re-encodes and directly manipulates the image data in such a way that prevented WebKit from decoding the image. Because Mail was giving
us bad data, the images wouldn't render. This was never an issue before because archivedResourceForURL (broken) always returned nil, thus the
engine would never attempt to decode the resource, therefore the responsibility was delegated to Mail's protocol handler, which would do the
right thing and load the image.


Since Mail is relying on the fact it can store arbitrary data in WebArchives, I've introduced SPI that acts as a hint for us to ignore certain
subresources while unarchiving. This SPI is -[WebResource _shouldIgnoreWhenUnarchiving].


  • WebView/WebResource.mm: Addd private ivar shouldIgnoreWhenUnarchiving. (-[WebResource _ignoreWhenUnarchiving]): Added. (-[WebResource _shouldIgnoreWhenUnarchiving]): Added.
  • WebView/WebResourcePrivate.h: Added two methods to private header.
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]): Check if we should ignore the resource.
1:51 PM Changeset in webkit [23081] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Anders.

  • Skipped: Added editing, http, and webarchive directories since they all rely on unimplemented parts of DRT, boomer-run-webkit-tests, and WebKit, respectively. Also re-enabled tests that no longer crash.
1:20 PM Changeset in webkit [20216] by kjk
  • 4 edits in trunk/WebCore

Not reviewed - gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::handleKeypress):
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::loadPlatformResource):
12:12 PM Changeset in webkit [20215] by justing
  • 29 edits in trunk

LayoutTests:

Reviewed by john

Removed an unnecessary block (one that was fully
selected but whose markup wasn't needed to preserve
appearance):

  • editing/pasteboard/paste-text-011-expected.txt: Removed unnecessary style spans:
  • editing/pasteboard/merge-end-blockquote-expected.txt: Removed unnecessary empty anonymous blocks:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt: Now (correctly) includes fully selected root:
  • editing/pasteboard/paste-text-015-expected.checksum:
  • editing/pasteboard/paste-text-015-expected.png:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt: Demonstrates a bug that already existed (we don't inline the font styles from the Preference Pane on copy):
  • editing/pasteboard/5027857-expected.checksum:
  • editing/pasteboard/5027857-expected.png:
  • editing/pasteboard/5027857-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.checksum:
  • editing/pasteboard/paste-pre-002-expected.png:
  • editing/pasteboard/paste-pre-002-expected.txt:

WebCore:

Reviewed by john


~2x speed up of 5k rich text paste:
​http://shakespeare.mit.edu/hamlet/full.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Remove the top level style span if its unnecessary before inserting into the document, its faster than doing it after.
  • editing/ReplaceSelectionCommand.h: Exposed ReplacementFragment::removeNodePreservingChildren so that the style span can be removed using non-undoable removes, like the rest of the removes done on the ReplacementFragment.
  • editing/markup.cpp: (WebCore::createMarkup): Make the style span the top level element, otherwise it's useless. This also facilitates the optimization mentioned above. When including markup for a fully selected root, include markup for all the nodes beneath that fully selected root, to preserve the structure and appearance of the copied markup. Did this by merging with the code for adding markup for descendants of special commonAncestorBlocks.
12:07 PM Changeset in webkit [20214] by bdakin
  • 19 edits
    2 deletes in trunk

Rubber-stamped by Adele.

Rolling out ​http://trac.webkit.org/projects/webkit/changeset/20148
(which is a fix for ​http://bugs.webkit.org/show_bug.cgi?id=12595
and rdar://4722863) because it causes a horrible memory-trasher.

6:26 AM Changeset in webkit [20213] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-16 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Gdk build fix.

  • kjs/DateMath.cpp: gettimeofday comes from <sys/time.h> on Linux.
5:15 AM Changeset in webkit [20212] by bdash
  • 2 edits in trunk/WebKit

2007-03-15 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

Fix for <rdar://problem/5065060> ASSERTION FAILURE: newUsername && newPassword
when submitting an authentication form without password.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): Don't omit form fields with empty values from the dictionary passed to the delegate.
12:11 AM Changeset in webkit [20211] by ggaren
  • 2 edits in trunk/WebCore

Added an assert to help catch a bug. Hopefully someone will hit it!


  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
12:07 AM Changeset in webkit [23080] by adachan
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-03-14 Ada Chan <​adachan@apple.com>

Reviewed by Lou.

<rdar://4966656> dragging scrollbar thumb in suggestion window does not work
<rdar://5056925> Should be able to select items from autocomplete list with the mouse
Added some tricks to get mouse clicking to work in auto-complete windows without
them going away.

WebKitWin:

Added a method in IWebViewPrivate to clear the current focus node. This is called in the app
when focus has been transferred to the address field or search field.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::clearFocusNode):
  • WebView.h:
Note: See TracTimeline for information about the timeline view.