Timeline

Mar 17, 2007:

10:23 PM Changeset in webkit [23105] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

The internal side of the patch that ensures Boomer paints twice on ibench. Don't let the timer beat out
that first paint.

Reviewed by aroben

• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::update):

10:18 PM Changeset in webkit [20268] by hyatt

• 4 edits in trunk/WebCore

Make onload do an explicit paint when a top-level document is ready (to ensure that a first paint always
happens before any timers set by the onload can fire).

Reviewed by aroben

• dom/Document.cpp: (WebCore::Document::implicitClose):
• platform/ScrollView.h:
• platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::update):

10:01 PM Changeset in webkit [23104] by aroben

• 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

Implemented console message dumping.

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::QueryInterface): Added cases for IWebUIDelegate[Private] (WaitUntilDoneDelegate::webViewAddMessageToConsole): Implemented.
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Now inherits from IWebUIDelegatePrivate

7:26 PM Changeset in webkit [23103] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix fast/dom/isindex-002.html.

Add default strings to our two remaining unimplemented localizable
strings in WebCore.

• platform/win/TemporaryLinkStubs.cpp: (WebCore::searchableIndexIntroduction): Added English string from Mac. (WebCore::inputElementAltText): Ditto.

5:54 PM Changeset in webkit [20267] by hyatt

• 2 edits in trunk/WebCore

Tweaks to prevent timers from starving user input or painting.

5:11 PM Changeset in webkit [20266] by ggaren

• 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/5070967> REGRESSION (r20211): Repro crash when
closing View Source window

I award myself 0 points, and may God have mercy on my soul.

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):

5:04 PM Changeset in webkit [20265] by kjk

• 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

• platform/gdk/TemporaryLinkStubs.cpp: (Pasteboard::writeURL):

4:39 PM Changeset in webkit [20264] by hyatt

• 2 edits in trunk/WebCore

Fix tiny PLT regression. Don't examine the border/background data for RenderImage when images change
unless we actually have a border/background.

Reviewed by Brady

• rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):

4:17 PM Changeset in webkit [23102] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Fix repro ASSERT when logging in to facebook.com.

• WebMutableURLRequest.cpp: (WebMutableURLRequest::valueForHTTPHeaderField): Implemented.

10:21 AM Changeset in webkit [20263] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

Discovered while working on <rdar://problem/5070334> that many WebView calls will crash if called
after -[WebView close] has executed because _private->page is deferenced after it's been set to 0.
It might be silly/wrong to call these methods after -close, but obviously it shouldn't crash. Made
each use of _private->page robust against nil-dereferencing.

• WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _updateWebCoreSettingsFromPreferences:]): (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]): (-[WebView setEditable:]):

8:38 AM Changeset in webkit [20262] by zimmermann

• 3 edits
  4 adds in trunk

Reviewed by Sam Weinig.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13046 (CSS styles on hover and focus are broken for <use>)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> CSS styles broken)
Added test: svg/custom/use-css-events.svg

In general this fixes the peepo.co.uk website.

Forgot to pass the actual StyleChange to the recalcStyle() function,
when calling it on the shadow tree root element.

7:49 AM Changeset in webkit [20261] by thatcher

• 12 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

• Configurations/JavaScriptCore.xcconfig:
• Configurations/Version.xcconfig:

JavaScriptGlue:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

• Configurations/JavaScriptGlue.xcconfig:
• Configurations/Version.xcconfig:

WebCore:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

• Configurations/Version.xcconfig:
• Configurations/WebCore.xcconfig:

WebKit:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

• Configurations/Version.xcconfig:
• Configurations/WebKit.xcconfig:

4:53 AM Changeset in webkit [20260] by antti

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by Adele.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12595
REGRESSION: Can't add item to cart at lnt.com (JS type error)
<rdar://problem/4722863>

Expanded version of Darin's test case.

• fast/forms/old-names-expected.txt: Added.
• fast/forms/old-names.html: Added.

WebCore:

Reviewed by Adele.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12595
REGRESSION: Can't add item to cart at lnt.com (JS type error)
<rdar://problem/4722863>

Emulate Firefox behavior where form elements accessed by a name
can be accessed with that name later even if the name changes or
even if element is removed from the document.

This is loosely based on Darin's earlier patch for the same problem but
is much less expansive. It takes somewhat different approach to more closely
mimic Firefox behavior. Includes expanded test case.

• bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName):

Use new the HTMLFormElement::getNamedElements() method

(WebCore::JSHTMLFormElement::nameGetter):

Use new the HTMLFormElement::getNamedElements() method

• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::elementForAlias): (WebCore::HTMLFormElement::addElementAlias):

Maintain a map of known element aliases

(WebCore::HTMLFormElement::getNamedElements):

Get a list of elements matching the name, based both their
current names and known aliases (earlier names).
Keep the alias list in sync.

• html/HTMLFormElement.h:

12:46 AM Changeset in webkit [23101] by adele

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4960391> REGRESSION (r18922): onChange never fired after selecting an item from a menulist

• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Initialize m_focusedIndex to 0. Instead of using the client to track the focused index, we'll keep track of it internally. Our old behavior was trying to match Firefox by updating the selected index as you focus items, but that doesn't seem necessary if the selection never gets committed. (WebCore::PopupMenu::show): Initialize the focused index to the client's selected index. (WebCore::PopupMenu::setFocusedIndex): Remove the fireOnChange argument. Remove the call to valueChanged. (WebCore::PopupMenu::focusedIndex): Return m_focusedIndex instead of getting this from the client. (WebCore::PopupMenu::down): Use the focusedIndex. (WebCore::PopupMenu::up): ditto. (WebCore::PopupMenu::paint): Paint a selected appearance for the item with the focused index.

12:40 AM Changeset in webkit [20259] by adele

• 9 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated test for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
​http://bugs.webkit.org/show_bug.cgi?id=12725

• fast/forms/listbox-onchange-expected.txt:
• fast/forms/listbox-onchange.html:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
​http://bugs.webkit.org/show_bug.cgi?id=12725

Test: updated fast/forms/listbox-onchange.html

Added HTMLSelectElement::saveLastSelection that is called before changing a selection that could result
in onChange being called. m_lastOnChangeIndex and m_lastOnChangeSelection no longer have to be up-to date all the time,
they just have to be up-to-date before we execute an action that may trigger onChange.

• html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): Added. The HTMLSelectElement will only set an option's selected state with this method. This ensures that notifyOptionSelected won't get called when the call originates from the select element.
• html/HTMLOptionElement.h:

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Calls setSelectedState. (WebCore::HTMLSelectElement::setSelectedIndex): ditto. Don't update the last selection variables here. Scroll to the new selection. The scrolling call used to only be in notifyOptionSelected. There's no reason we shouldn't scroll when the selection is set through the HTMLSelectElement. (WebCore::HTMLSelectElement::setValue): Call setSelectedIndex to update all options selected state. (WebCore::HTMLSelectElement::restoreState): Call setSelectedState. (WebCore::HTMLSelectElement::selectAll): Call saveLastSelection before making the selection, and calling onChange. (WebCore::HTMLSelectElement::recalcListItems): Call setSelectedState. Don't need to save selection here anymore, since it will get saved before we call onChange. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::dispatchFocusEvent): Added. Call saveLastSelection for menu lists, since onChange can be fired on blur. (WebCore::HTMLSelectElement::dispatchBlurEvent): Call menuListOnChange. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Call saveLastSelection before showing the popup window. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Call saveLastSelection during mousedown (to prepare for an onchange during mouseup, or after autoscroll). (WebCore::HTMLSelectElement::updateListBoxSelection): Call setSelectedState.

(WebCore::HTMLSelectElement::menuListOnChange): Added. Compares the m_lastOnChangeIndex to the selectedIndex().
(WebCore::HTMLSelectElement::listBoxOnChange): Move the m_lastOnChangeSelection creation to saveLastSelection.
(WebCore::HTMLSelectElement::saveLastSelection): Added. Sets m_lastOnChangeIndex or m_lastOnChangeSelection.

• html/HTMLSelectElement.h:
• platform/PopupMenu.h:

Mar 16, 2007:

9:59 PM Changeset in webkit [20258] by oliver

• 14 edits in trunk

2007-03-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.

WebCore:

The old canSaveAsWebArchive call was necessary as stand alone
images used to be rendered by ImageDocument.

Fixes rdar://problem/5061252

• dom/Clipboard.cpp:
• dom/Clipboard.h: (WebCore::Clipboard::setDragHasStarted):
• page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage):
• platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage):

WebKit:

• WebCoreSupport/WebDragClient.h:
• WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage):
• WebKit.xcodeproj/project.pbxproj:

LayoutTests:

Updating layout test to allow stand alone image to be
dragged into a content editable div

• fast/events/standalone-image-drag-to-editable-expected.checksum:
• fast/events/standalone-image-drag-to-editable-expected.png:
• fast/events/standalone-image-drag-to-editable-expected.txt:
• fast/events/standalone-image-drag-to-editable.html:

6:23 PM Changeset in webkit [23100] by beidson

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver

Make the WebDownload fix a little more correct.

• WebDownload.cpp: (WebDownload::init): Release the connection from the ResourceHandle after the CFURLDownload has been created

6:01 PM Changeset in webkit [20257] by andersca

• 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4869095>
default content type changed for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

5:43 PM Changeset in webkit [20256] by thatcher

• 4 edits in trunk

64-bit build fix.

5:36 PM Changeset in webkit [20255] by beidson

• 2 edits in trunk/LayoutTests

Reviewed by Braveheart

Updated layouttest results because I added a window property

• fast/dom/Window/window-properties-expected.txt:

4:57 PM Changeset in webkit [20254] by beidson

• 2 edits in trunk/WebCore

Rubberstamped by Tim Hatcher

Update the hash table header for Window object properties

• bindings/js/kjs_window.cpp:

4:49 PM Changeset in webkit [20253] by beidson

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by Anders

<rdar://problem/5061826> and
​http://bugs.webkit.org/show_bug.cgi?id=12863
Implement window.stop()

• http/tests/misc/window-dot-stop-expected.txt: Added.
• http/tests/misc/window-dot-stop.html: Added.

WebCore:

Reviewed by Anders

<rdar://problem/5061826> and
​http://bugs.webkit.org/show_bug.cgi?id=12863
Implement window.stop()

• bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add case Window::Stop
• bindings/js/kjs_window.h: (KJS::Window::): Add "Stop"

4:41 PM Changeset in webkit [23099] by adele

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Lou.

Fix for <rdar://problem/5065040> cannot mousedown + drag in a <select> menu

• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Set the capture when the popup window comes up. (WebCore::PopupWndProc): Release the capture only when the mouse is not down, and the mouse moves outside the popup window, or if you mouse up inside the window, and you're about to hide the popup. The mouse will get recaptured if you mouse down again in the window.

4:19 PM Changeset in webkit [20252] by thatcher

• 4 edits in trunk

Adding ChangeLog markers.

4:18 PM Changeset in webkit [20251] by thatcher

• 1 edit in tags/Safari-5522.4/JavaScriptGlue/Info.plist

Versioning.

4:16 PM Changeset in webkit [20250] by thatcher

• 1 edit in tags/Safari-5522.4/JavaScriptCore/Info.plist

Versioning.

4:14 PM Changeset in webkit [20249] by thatcher

• 1 edit in tags/Safari-5522.4/WebKit/Info.plist

Versioning.

4:12 PM Changeset in webkit [20248] by thatcher

• 1 edit in tags/Safari-5522.4/WebCore/Info.plist

Versioning.

4:11 PM Changeset in webkit [23098] by ggaren

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Dave Hyatt.

Fixed "called Frame::paint with nil renderer" console messages.
You can now launch and exit the app without seeing any
error messages!

• WebView.cpp: (WebView::paintIntoBackingStore): Only tell the FrameView to paint if it has a renderer. This isn't an issue on the Mac because we don't create a FrameView until you load a page.

4:11 PM Changeset in webkit [20247] by thatcher

• 3 edits in tags/Safari-5522.4/WebCore

Merging fix for r20228.

4:09 PM Changeset in webkit [20246] by thatcher

• 18 edits in tags/Safari-5522.4/WebCore

Merging fix for r20214.

4:03 PM Changeset in webkit [20245] by thatcher

• 1 copy in tags/Safari-5522.4

New tag from r20197.

3:39 PM Changeset in webkit [20244] by ggaren

• 1 edit in trunk/WebCore/ChangeLog

fixed changelog order -- do you need a changelog entry for a changelog fix???

3:37 PM Changeset in webkit [20243] by ggaren

• 2 edits in trunk/WebCore

Fix for 13084, assertion failure in the Cache. Convert the client list
to a HashCountedSet so that multiple refs and derefs are allowed.

Fix RenderImage so that if it has the same image used as a background/border
and as the foreground that it will repaint properly (can be tested using
border-image and a foreground image).

Optimize list marker so that it doesn't waste time in the base class method,
since list markers don't support background or border images.

Reviewed by andersca

• ChangeLog:
• loader/CachedResource.cpp: (WebCore::CachedResource::ref):
• loader/CachedResource.h:
• loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
• loader/CachedResourceClientWalker.h:
• rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged):

3:29 PM Changeset in webkit [20242] by hyatt

• 7 edits in trunk/WebCore

Fix for 13084, assertion failure in the Cache. Convert the client list
to a HashCountedSet so that multiple refs and derefs are allowed.

Fix RenderImage so that if it has the same image used as a background/border
and as the foreground that it will repaint properly (can be tested using
border-image and a foreground image).

Optimize list marker so that it doesn't waste time in the base class method,
since list markers don't support background or border images.

Reviewed by andersca

• ChangeLog:
• loader/CachedResource.cpp: (WebCore::CachedResource::ref):
• loader/CachedResource.h:
• loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
• loader/CachedResourceClientWalker.h:
• rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged):

3:26 PM Changeset in webkit [20241] by thatcher

• 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Attempt to fix the 64-bit build.

3:04 PM Changeset in webkit [23097] by andersca

• 5 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Add setters and getters for cookie storage accept policy.

• Interfaces/IWebPreferences.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::cookieStorageAcceptPolicy): (WebPreferences::setCookieStorageAcceptPolicy):
• WebPreferences.h:

1:22 PM Changeset in webkit [23096] by andersca

• 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Add Radar

1:16 PM Changeset in webkit [23095] by andersca

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam and Dave Hyatt.

Fix acid2 test.

• WebFrame.cpp: (WebFrame::shouldFallBack): Implement this function.

1:10 PM Changeset in webkit [20240] by ggaren

• 5 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Fixed <rdar://problem/5065399> REGRESSION: leaks in Frame::bindingRootObject
seen on buildbot

The problem was that we were initializing the same WebScriptObject twice.
This caused it to leak its original set of ivars.

I think some refactoring could prevent this situation from arising in the
first place, but I'm just adding a check at the call site for now, to do
the simplest thing.

• bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setImp:originRootObject:rootObject:]): Added ASSERTs against multiple calls.

• bindings/objc/WebScriptObjectPrivate.h: Renamed _initializeWithObjectImp to setImp because "init" vs "initialize" was a too subtle indication that one was a Cocoa initializer and one was not.

12:27 PM Changeset in webkit [23094] by adachan

• 3 edits in branches/WindowsMerge/WebKitWin

2007-03-16 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Steve.

Implemented a couple of DOM methods so we can set the font-size of an element directly in the app.

• DOMCSSClasses.cpp: (DOMCSSStyleDeclaration::setProperty):
• DOMCoreClasses.cpp: (DOMElement::style):

10:47 AM Changeset in webkit [20239] by brmorris

• 2 edits in S60/trunk/WebKit

spadma, reviewed by <yongjun>

DESC: Prevent unnecessary redraws.
​http://bugs.webkit.org/show_bug.cgi?id=13093
TSW ID: RCHI-6Z2V49

10:45 AM Changeset in webkit [20238] by brmorris

• 3 edits in S60/branches/3.1m/WebKit

yinxcai, reviewed by <Yongjun>

DESC: TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly
​http://bugs.webkit.org/show_bug.cgi?id=12901

7:33 AM Changeset in webkit [20237] by brmorris

• 2 edits in S60/branches/3.1m/WebCore

rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan.
DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
​http://bugs.webkit.org/show_bug.cgi?id=13074

5:40 AM Changeset in webkit [20236] by lars

• 2 edits in trunk/WebCore

don't use #import in .cpp files.

5:36 AM Changeset in webkit [20235] by lars

• 6 edits in trunk

Fix the Qt build once again.

2:52 AM Changeset in webkit [23093] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/PasteboardWin.cpp

Fix boomer build bustage.