Context Navigation

← Previous Period
Next Period →

Timeline

Mar 21, 2007:

10:55 PM Changeset in webkit [20384] by ggaren

2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Re-worked the fix in r20375. 'M' and 'm' are not the only commands that
accept "extra" coordinates -- virtually all commands accept them.

ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):

10:54 PM Changeset in webkit [20383] by ddkilzer

2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by NOBODY (more word tweaking).

building/checkout.html: By popular demand, the link to the svn 1.3 client has been removed.

10:48 PM Changeset in webkit [20382] by ddkilzer

2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by NOBODY (tweaked wording).

building/checkout.html: Got rid of "click here" link and restructured sentences linking to svn clients.

10:17 PM Changeset in webkit [23159] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

Force SVG tests to paint to match the Mac results.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Force a paint if we're running an SVG test.

9:31 PM Changeset in webkit [20381] by harrison

5 edits in trunk/WebCore

Reviewed by hyatt.

<rdar://problem/5072460> CrashTracer: [USER] 1 crashes in Xcode at com.apple.ImageIO.framework: getBandProcPNG + 168

An NSData object was being alloc/init'd, then returned callers who cast the pointer as a
CFDataRef, including calling CFRelease on it. The problem is that under garbage collection, the NS
retain count is ignored (it's always 0), but the CFRetain and CFRelease are not ignored. This
caused the object to be over-released. The solution that works in both GC and non-GC is to "transfer"
the initial NS retain count to the CF retain count, using HardRetainWithNSRelease.

The creator of the NSData was SharedBuffer::createNSData. The callers were PDFDocumentImage::dataChanged()
and ImageSource::setData(). This particular crash involved the ImageSource::setData() case.

platform/SharedBuffer.h: Declare createCFData().

platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData): Call createCFData instead of createNSData.

platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Call createCFData instead of createNSData.

platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData): Implement createCFData(). Use HardRetainWithNSRelease for gc safety.

9:16 PM Changeset in webkit [20380] by ddkilzer

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin. Patch by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=13145 Regression: Scrollbar not resizing after display none

fast/dynamic/view-overflow-expected.checksum: Added.
fast/dynamic/view-overflow-expected.png: Added.
fast/dynamic/view-overflow-expected.txt: Added.
fast/dynamic/view-overflow.html: Added.

WebCore:

Reviewed by Darin. Patch by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=13145 Regression: Scrollbar not resizing after display none

Test: fast/dynamic/view-overflow.html

rendering/RenderView.cpp: (WebCore::RenderView::layout): Reset overflowHeight() and overflowWidth() before calling docHeight() and docWidth(), since the former act as a lower bound for the latter.

9:11 PM Changeset in webkit [20379] by ddkilzer

2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by Adam.

building/checkout.html: Add link to svn 1.4 client for Mac OS X 10.4.

9:09 PM Changeset in webkit [20378] by ggaren

2 edits in trunk/LayoutTests

Fixed bad version of results that I check in accidentally.

svg/dom/string-list-parser-expected.txt:

9:05 PM Changeset in webkit [20377] by ggaren

4 edits in trunk/WebCore

Reviewed by Beth Dakin.

A little cleanup based work I've been doing on the SVG parsers.

ksvg2/svg/SVGParserUtilities.h: (WebCore::skipString):
ksvg2/svg/SVGPreserveAspectRatio.cpp: Moved checkString into SVGParserUtilities.h, so it could be with all its friends. Renamed "checkString" to "skipString" to match the rest of the code and to be clear about which functions move the buffer pointer. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute): Changed gotos into returns. Removed unnecessary magic number.

8:50 PM Changeset in webkit [20376] by ggaren

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Added fuzz tester for the SVG rgb color parser.

svg/dom/rgb-color-parser-expected.txt: Added.
svg/dom/rgb-color-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/5078471> SVG rgb color parser runs past end of
buffer when running fuzzing test

ksvg2/svg/SVGColor.cpp: (WebCore::parseNumberOrPercent): Check for past the end condition. (WebCore::SVGColor::colorFromRGBColorString): Reversed "read past end of buffer, then check if you're past the end" logic.

8:37 PM Changeset in webkit [20375] by ggaren

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Added fuzz tester for the path parser.

svg/dom/path-parser-expected.txt: Added.
svg/dom/path-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/5079410> SVG path parser hangs, exhausts memory when
running fuzzer test

ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): Don't assume that extra digits are always preceded by an 'M' or an 'm'.

8:28 PM Changeset in webkit [20374] by ggaren

1 edit
2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.

Added fuzz tester for the string list parser.

svg/dom/string-list-parser-expected.txt: Added.
svg/dom/string-list-parser.html: Added.

8:26 PM Changeset in webkit [20373] by ggaren

1 edit
2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.

Added fuzz tester for the length list parser.

svg/dom/length-list-parser-expected.txt: Added.
svg/dom/length-list-parser.html: Added.

8:21 PM Changeset in webkit [20372] by ggaren

2 edits
2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.

Factored randomizing functions into their own file, in preparation for future
tests that rely on them.

svg/dom/resources/scripted-random.js: Added.
svg/dom/transform-parser.html: Factored out scripted-random.js, added a small string that increases the normal-seemingness of the last test.

8:12 PM Changeset in webkit [20371] by thatcher

4 edits in trunk/LayoutTests

New results after rolling out r19828 in r20352.

fast/overflow/scrollRevealButton-expected.checksum:
fast/overflow/scrollRevealButton-expected.png:
fast/overflow/scrollRevealButton-expected.txt:

6:42 PM Changeset in webkit [20370] by sullivan

2 edits in trunk/WebCore

Reviewed by Adam

fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled or saved for .Mac homepage login

page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): don't count empty strings as valid results

6:21 PM Changeset in webkit [23158] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Oliver.

Skipped: Added an SVG test that causes a debug ASSERT in the C Runtime.

6:15 PM Changeset in webkit [23157] by aroben

2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Oliver.

Make W3C SVG tests render at the correct dimensions.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Resize the WebView if we're running a W3C SVG test. (runTest): Save the current test filename.

5:48 PM Changeset in webkit [20369] by justing

4 edits in trunk

Reviewed by darin

editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Release the RefPtr to avoid increasing/decreasing the refcount unnecessarily. (WebCore::propertyMissingOrEqualToNone): Added and used instead of converting values to strings. (WebCore::elementHasTextDecorationProperty): (WebCore::createMarkup):

5:31 PM Changeset in webkit [20368] by thatcher

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/5076599> JavaScriptCore has a weak export (vtable for KJS::JSCell)

JavaScriptCore.exp: Remove ZTVN3KJS6JSCellE.

5:07 PM Changeset in webkit [23156] by andersca

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

WebView.cpp: (WebView::initWithFrame): Remove #ifdef now that DRT no longer crashes.

4:59 PM Changeset in webkit [20367] by mjs

1 edit
6 adds in trunk/WebKitSite

some specs to propose by email

specs/HTML_Timed_Media_Elements.html: Added.
specs/Timed_Media_CSS.html: Added.
specs/Timed_Media_Elements-Open_Issues.html: Added.
specs/mediaelement.css: Added.
specs/movie-status-states.png: Added.

4:58 PM Changeset in webkit [20366] by justing

3 edits
12 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text

Tests for the bug:

editing/pasteboard/5075944-expected.checksum: Added.
editing/pasteboard/5075944-expected.png: Added.
editing/pasteboard/5075944-expected.txt: Added.
editing/pasteboard/5075944.html: Added. Tests that the element that has the text-decoration and all its descendants down to the common ancestor are included in the copied markup (instead of the text-decoration property being treated as though it were inheritable and placed on the style span wrapper):
editing/pasteboard/5075944-2-expected.checksum: Added.
editing/pasteboard/5075944-2-expected.png: Added.
editing/pasteboard/5075944-2-expected.txt: Added.
editing/pasteboard/5075944-2.html: Added. Tests that moveParagraphs gets underlining right (it doesn't use annotation):
editing/pasteboard/5075944-3-expected.checksum: Added.
editing/pasteboard/5075944-3-expected.png: Added.
editing/pasteboard/5075944-3-expected.txt: Added.
editing/pasteboard/5075944-3.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text

We stopped adding markup for all the ancestors
of lastClosed up to the commonAncestorBlock
because it was adding a lot of unnecessary markup.
This caused us to lose underlining when copying a
partially selected underlined element (even though
we put all styles that the copied markup inherits
into a style span, because the text-decoration
isn't inheritable).

editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Moved code here. (WebCore::elementHasTextDecorationProperty): Added. (WebCore::createMarkup): If the copied markup has a text-decoration because some common ancestor has a text-decoration property set, include that ancestor and all its descendants in the copied markup.

4:40 PM Changeset in webkit [23155] by hyatt

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Fix broken changelog.

4:37 PM Changeset in webkit [23154] by hyatt

3 edits in branches/WindowsMerge/WebCore

Advanced text improvements.

4:28 PM Changeset in webkit [20365] by thatcher

1 copy in branches/Safari-522

New branch.

2:59 PM Changeset in webkit [20364] by oliver

5 edits
2 adds in trunk

2007-03-21 Oliver Hunt <oliver@apple.com>

Reviewed by Antti.

WebCore:

Update a few SVG attribute parsers to be more defensive against
reading beyond the end of input.

Fixes rdar://problem/5077218 -- SVG transform parser runs past
end of buffer when running fuzzing test

ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
ksvg2/svg/SVGParserUtilities.h: (WebCore::skipOptionalSpacesOrDelimiter):
ksvg2/svg/SVGTransformable.cpp: (WebCore::parseTransformParamList): (WebCore::SVGTransformable::parseTransformAttribute):

LayoutTests:

Fuzz test for SVG transform parser

svg/dom/transform-parser-expected.txt: Added.
svg/dom/transform-parser.html: Added.

2:34 PM Changeset in webkit [23153] by bdakin

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/5074274> right-clicking in certain iframes ends up
left-clicking, and context menu appears far away

WebView.cpp: (WebView::handleContextMenuEvent): We were always calling sendContextMenuEvent() on the main frame!! Instead, call it on the focused or main frame.

2:22 PM Changeset in webkit [23152] by aroben

2 edits in branches/WindowsMerge/LayoutTests

LayoutTestsWin:

Reviewed by David Kilzer (yay!).

Re-enable the editing tests, except for two crashers.

Skipped:

12:06 PM Changeset in webkit [20363] by ap

3 edits
2 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=13140
Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)

Test: svg/carto.net/frameless-svg-parse-error.html

ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportError): Added a null check. (WebCore::SVGDocumentExtensions::reportWarning): Ditto.

11:03 AM Changeset in webkit [23151] by adele

7 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Adam.

Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails

Call updateActiveState on the WebView in didCommitLoadForFrame. This is required so that nodes can be properly focused in the document.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didCommitLoadForFrame):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:

WebKitWin:

Reviewed by Adam.

Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails

Added updateActiveState SPI for DumpRenderTree.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus. We should merge this logic into updateActiveState eventually. (WebView::updateActiveState):
WebView.h:

10:55 AM Changeset in webkit [20362] by adele

2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

API/JSStringRef.cpp: (JSStringIsEqual): Added JSLock.

2:30 AM Changeset in webkit [20361] by zack

2 edits in trunk/JavaScriptCore

Fix the compile when USE(MULTIPLE_THREADS) isn't defined

12:24 AM Changeset in webkit [20360] by bdakin

5 edits in trunk/WebCore

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

I tried to fix this earlier today but my fix caused a regression
scrolling through RSS pages. It turns out that sometimes scroll
events need to propagate immediately, and sometimes they must be
delayed or they risk deleting objects that are expected to be
around after the event has propagated. Mitz's original fix made
sheduleEvent() only delay events that happen during layout. This
fix marks two other places in addition to layout where events also
need to be delayed. These two places are places that were marked
with FIXMEs that Mitz removed in his original patch. (There was a
third FIXME in RenderLayer::updateScrollInfoAfterLayout() but that
case is only called through layout and is covered by Mitz's
original patch.)

page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added assertion. (WebCore::FrameView::layout): Call new functions to increment and decrement the queued events count. (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): Decrement queued events count and dispatch events if the count has zeroed.
page/FrameView.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::Marquee::start):

12:21 AM Changeset in webkit [20359] by bdash

2 edits in trunk/WebCore

2007-03-21 Mitz Pettel <mitz@webkit.org>

Reviewed by John Sullivan.

fix http://bugs.webkit.org/show_bug.cgi?id=13130 REGRESSION: Sometimes a frame resizer keeps following the mouse after mouseup

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Reordered the code to allow resizing to be terminated by a mouseup event regardless of whether the frameset needs layout.

Mar 20, 2007:

10:46 PM Changeset in webkit [20358] by andersca

2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5077252>
In NetNewsWire 2.1.1 and 3.0d62, a crash occurs after triple-clicking a link on the page

loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Move the m_inStopAllLoaders check to the load function that's common for loading a request or substitute data.

10:39 PM Changeset in webkit [20357] by beidson

3 edits in trunk/WebCore

Reviewed by Anders

<rdar://problem/5073391> and http://bugs.webkit.org/show_bug.cgi?id=13137

Crash in IconDatabase when private browsing is enabled.

The problem was caused by http://trac.webkit.org/projects/webkit/changeset/20182
which changed many uses of char[] and Vector<char> to SharedBuffer. The patch
tended to literally replace a Vector<char> with RefPtr<SharedBuffers> but forgot
to enforce the concept that Vector<char>'s always exist, whereas RefPtr<SharedBuffers>
can be null. This led to derefs.

I took the opportunity to rework the iconDB functions to live in a SharedBuffer
world, as that didn't exist when they were originally written - now they just return
SharedBuffers instead of taking a Vector<char>& as a parameter

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): Return a SharedBuffer (WebCore::IconDatabase::iconForPageURL): Null check the SharedBuffer before asking it if it's empty (WebCore::IconDatabase::imageDataForIconURLQuery): Return a new SharedBuffer

loader/icon/IconDatabase.h: Return SharedBuffer's instead of taking Vector<char>&'s

9:25 PM Changeset in webkit [23150] by aroben

5 edits in branches/WindowsMerge/WebKitTools

Reviewed by Brady.

Always use CCom* smart pointers when possible to avoid memory management issues.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed _T() to TEXT(). (dump): (runTest): (initializePreferences): (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (mouseDownCallback): (doMouseUp): (mouseClickCallback): (doMouseMove): (keyDownCallback):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setAcceptsEditingCallback): (setTabKeyCyclesThroughElementsCallback):

8:53 PM Changeset in webkit [23149] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

8:49 PM Changeset in webkit [20356] by sfalken

1 copy in tags/Safari-522.4.1b

New tag.

6:50 PM Changeset in webkit [23148] by mjs

1 edit in branches/WindowsMerge/WebKitTools/ChangeLog

Removed conflict markers.

6:47 PM Changeset in webkit [23147] by mjs

4 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Geoff and Adam.

fixed some bugs in --threaded fond in the course of testing.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runJavaScriptThread): Be smarter about thread dictionary. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Account for --threaded command-line argument better.

WebKitWin:

Reviewed by Geoff and Adam.

<rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows

WebView.cpp: (WebView::WebView): Tell JavaScriptCore what the main thread is.

6:29 PM Changeset in webkit [23146] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Adele.

Roll out r12355 now that OpenSource r20348 has been rolled out.

Skipped: Also removed a crash that was caused by 20348.

6:24 PM Changeset in webkit [20355] by aroben

2 edits in trunk/WebCore

Rubberstamped by Adele.

Roll out r20348 because it was causing crashes.

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):

5:54 PM Changeset in webkit [23145] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Install Helevetica Neue.

5:46 PM Changeset in webkit [20354] by bdash

2 edits in trunk/WebKitSite

2007-03-20 Matt Lilek <pewtermoose@gmail.com>

Reviewed by Darin.

Clear up the steps necessary to get a patch landed.

http://bugs.webkit.org/show_bug.cgi?id=12877 - Bug 12877: "Contributing Code" page could be clearer
http://bugs.webkit.org/show_bug.cgi?id=8690 - Bug 8690: Contributing code doesn't mention what to do with new files

coding/contributing.html:

5:13 PM Changeset in webkit [23144] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Beth.

Skipped: Added the real crasher (arrow-navigation.html just fails, doesn't crash).

5:11 PM Changeset in webkit [20353] by thatcher

1 edit in trunk/JavaScriptCore/kjs/collector.cpp

Build fix.

4:57 PM Changeset in webkit [20352] by thatcher

3 edits in trunk/WebCore

Reviewed by Kevin Decker.

Rolling out part of r19828 that caused a scrolling regression in Mail.

<rdar://problem/4820817> Message jumps around when trying to select text

platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::updateContents):

4:57 PM Changeset in webkit [20351] by mjs

10 edits in trunk/JavaScriptCore

Reviewed by Geoff and Adam.

make USE(MULTIPLE_THREADS) support more portable http://bugs.webkit.org/show_bug.cgi?id=13069

fixed a threadsafety bug discovered by testing this

enhanced threadsafety assertions in collector

API/JSCallbackObject.cpp: (KJS::JSCallbackObject::~JSCallbackObject): This destructor can't DropAllLocks around the finalize callback, because it gets called from garbage collection and we can't let other threads collect!

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
kjs/JSLock.cpp: (KJS::JSLock::currentThreadIsHoldingLock): Added new function to allow stronger assertions than just that the lock is held by some thread (you can now assert that the current thread is holding it, given the new JSLock design).
kjs/JSLock.h:
kjs/collector.cpp: Refactored for portability plus added some stronger assertions. (KJS::Collector::allocate): (KJS::currentThreadStackBase): (KJS::Collector::registerAsMainThread): (KJS::onMainThread): (KJS::PlatformThread::PlatformThread): (KJS::getCurrentPlatformThread): (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::Collector::registerThread): (KJS::Collector::markCurrentThreadConservatively): (KJS::suspendThread): (KJS::resumeThread): (KJS::getPlatformThreadRegisters): (KJS::otherThreadStackPointer): (KJS::otherThreadStackBase): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::collect):
kjs/collector.h:
wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded):
wtf/FastMallocInternal.h:
wtf/Platform.h:

4:25 PM Changeset in webkit [23143] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed bogus extra linker options.

4:24 PM Changeset in webkit [20350] by beidson

2 edits in trunk/WebCore

Reviewed by John

<rdar://5071341> - Crash in IconLoader::finishLoading()

Though the reproducibility of the crash is still elusive, there's been a crasher likely uncovered
Hyatt's recent caching changings to the IconLoader. This crash tends to hit on sites without favicons,
that serve up complex 404 pages, often when the load is cancelled or redirected. Occasionally, it *seems*
the IconLoader is getting failed/cancelled twice.

This patch adds some assertions and a "fail gracefully in a release build" check that will have to
serve us until we know more about the cause.

loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail): Add an assertion to catch this case (WebCore::IconLoader::finishLoading): Add an assertion to catch the case, and fail gracefully in debug builds. Also add an efficiency check to not commit to the DB if there is no IconURL

4:15 PM Changeset in webkit [23142] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Beth.

Skipped: Added another crasher.

3:06 PM Changeset in webkit [23141] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Adele.

Added some tests that fail due to font metric differences.

Skipped:

3:01 PM Changeset in webkit [20349] by antti

8 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=10747 REGRESSION: Using two fingers on a trackpad to scroll inside a text area makes the whole page move <rdar://problem/5045710>

Eat smooth scroll events in WebCore if pointer is over scrollable area. Not
really a good fix, smooth scrolling should be supported properly. It should do for now.

page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::isScrollable):
rendering/RenderListBox.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::isScrollable):
rendering/RenderObject.h:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::isScrollable):
rendering/RenderTextControl.h:

2:02 PM Changeset in webkit [23140] by adele

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

Explicitly pass VK_RETURN when using keyDown for "\n".

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):

1:47 PM Changeset in webkit [23139] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set libpath.

1:29 PM Changeset in webkit [23138] by bdakin

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

Re-enabling fast/layers/removed-by-scroll-handler.html because
5072678 is fixed.

1:13 PM Changeset in webkit [20348] by bdakin

2 edits in trunk/WebCore

Reviewed by Geoff.

Covered by existing test case.

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

This removes some code that was added with http://bugs.webkit.org/
show_bug.cgi?id=8360. This code was not needed to fix that bug, but
the idea behind it was that there are times when it is safe for
scheduleEvent() to propagate the event immediately. The
MallocScribble crash revealed that this assumption was a bit too
broad; the cause of the crash was that we were propagating events
immediately when it was not safe. Mitz and I discussed this online
and we agree that the safest solution is to revert to the old
behavior here, and always delay the propagation of the event.

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):

12:56 PM Changeset in webkit [20347] by beidson

2 edits in trunk/WebCore

Reviewed by John Sullivan

Add some very helpful logging to the IconLoader's SubresourceLoaderClient impl.

loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):

12:09 PM Changeset in webkit [20346] by justing

5 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions

editing/pasteboard/5071074-2-expected.checksum: Added.
editing/pasteboard/5071074-2-expected.png: Added.
editing/pasteboard/5071074-2-expected.txt: Added.
editing/pasteboard/5071074-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions

moveParagraphs calls createMarkup without annotation, which leaves
out anchor elements that aren't fully selected.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): We don't want createMarkup to do full annotation here. Doing so could include special ancestor blocks, which would prevent the copied content from appearing in the destination paragraph when it's re-inserted. Annotation would also inline styles from style sheets, which is unnecessary because the content is being moved to the same document it's being moved from. Added a new bool to createMarkup that when true allows markup for special ancestors as long as they are inline when annotation is off.
editing/markup.cpp: (WebCore::createMarkup): Don't set specialCommonAncestor if annotation is off, unless it's inline and we've been told it's ok to include such elements.
editing/markup.h:

11:48 AM Changeset in webkit [23137] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Added null-checks for ResourceHandle::cookieStorage() before passing it
into CFNetwork functions, which are not null-safe.

platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):

11:20 AM Changeset in webkit [23136] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj: Added XPathNodeSet.(cpp|h).

10:21 AM Changeset in webkit [20345] by ap

30 edits
5 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12497
Implement XPath result ordering.

WebCore:

XPath::NodeVector typedef is replaced with a real XPath::NodeSet class that knows how
to sort itself, and can remember whether it has been already sorted.

CMakeLists.txt:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Added XPathNodeSet files.

xml/XPathExpression.cpp: Fixed includes.

xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Mark the resulting node-set as unsorted. (WebCore::XPath::FunLocalName::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunCount::evaluate): Ditto. (WebCore::XPath::FunSum::evaluate): Ditto.

xml/XPathNodeSet.cpp: Added. (WebCore::XPath::parentWithDepth): (WebCore::XPath::sortBlock): (WebCore::XPath::NodeSet::sort): Sort the node-set in document order. (WebCore::XPath::NodeSet::reverse): Reverse the order (useful for making axes such as parent or ancestor sorted). (WebCore::XPath::NodeSet::firstNode): Returns the first node in document order; currently implemented via fully sorting the node-set, but this can obviously be optimized. (WebCore::XPath::NodeSet::anyNode): Added for symmetry with firstNode().

xml/XPathNodeSet.h: Added. (WebCore::XPath::NodeSet::NodeSet): (WebCore::XPath::NodeSet::operator=): (WebCore::XPath::NodeSet::size): (WebCore::XPath::NodeSet::isEmpty): (WebCore::XPath::NodeSet::operator[]): (WebCore::XPath::NodeSet::reserveCapacity): (WebCore::XPath::NodeSet::clear): (WebCore::XPath::NodeSet::swap): (WebCore::XPath::NodeSet::append): (WebCore::XPath::NodeSet::markSorted): (WebCore::XPath::NodeSet::isSorted): Most of these methods just call Vector counterparts.

xml/XPathParser.cpp: Updated the copyright notice.

xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::Path::evaluate): Ditto. (WebCore::XPath::LocationPath::evaluate): Replacing NodeVector with NodeSet. This function always marks the result as unsorted, because it is hard to tell whether a step breaks node order. Identifying and implementing special cases when it is not necessary to do so is an important future optimization.

xml/XPathPath.h: Replacing NodeVector with NodeSet.
xml/XPathPredicate.cpp: (WebCore::XPath::EqTestOp::compare): Replacing NodeVector with NodeSet. (WebCore::XPath::Union::evaluate): Replacing NodeVector with NodeSet. Currently, Union just marks the result as unordered; we can consider using merge sort to avoid this.

xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): Replacing NodeVector with NodeSet. (WebCore::XPathResult::singleNodeValue): Ditto. (WebCore::XPathResult::snapshotLength): Ditto. (WebCore::XPathResult::iterateNext): Ditto. (WebCore::XPathResult::snapshotItem): Ditto. (WebCore::XPathResult::convertTo): Ditto. Sort the result when requested to.

xml/XPathResult.h: Replacing NodeVector with NodeSet.

xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): If the input is not sorted, mark the output as such, too. (WebCore::XPath::Step::nodesInAxis): Fixed a number of bugs when enumerating with an attribute context node. (WebCore::XPath::Step::nodeTestMatches): Replacing NodeVector with NodeSet.
xml/XPathStep.h: Ditto.

xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): XPath data model doesn't put attribute data into child nodes, so passing such node as a context could cause problems.

xml/XPathUtil.h: Removed NodeVector typedef.

xml/XPathValue.cpp: (WebCore::XPath::Value::Value): (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
xml/XPathValue.h: (WebCore::XPath::Value::): (WebCore::XPath::Value::isNodeSet): Replacing NodeVector with NodeSet.

LayoutTests:

fast/xpath/document-order-expected.txt: Added.
fast/xpath/document-order.html: Added.

fast/xpath/text-nodes-expected.txt:
fast/xpath/text-nodes.html:
fast/xpath/4XPath/Core/test_step-expected.txt: Updated results for tests that now pass.

fast/xpath/xpath-test-pre.js: Added.
fast/xpath/4XPath/Core/test.js: Moved checkSnapshot() to a separate file.

fast/xpath/4XPath/Core/test_core_functions.html:
fast/xpath/4XPath/Core/test_location_path.html:
fast/xpath/4XPath/Core/test_nodeset_expr.html:
fast/xpath/4XPath/Core/test_parser.html:
fast/xpath/4XPath/Core/test_predicate_list.html:
fast/xpath/4XPath/Core/test_step.html: Load xpath-test-pre.js for checkSnapshot().

9:44 AM Open Source Contributors created by ddkilzer@webkit.org

Initial page with fake contributor.

9:37 AM WikiStart edited by ddkilzer@webkit.org

Added link to page for open source contributors. (diff)

8:18 AM Changeset in webkit [20344] by bdash

2 edits in trunk/WebCore

2007-03-21 Mark Rowe <mrowe@apple.com>

Build fix.

bindings/objc/WebScriptObject.mm: (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]):

8:11 AM Changeset in webkit [20343] by bdash

3 edits in trunk/WebCore

2007-03-21 Mark Rowe <mrowe@apple.com>

Reviewed by Tim Hatcher.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13129.
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup.

Some cross-language scripting bridges use the presence of -(int)count to determine
whether to treat objects as sequence-like. All WebScriptObject's exposed this method
which lead to non-collection WebScriptObject's being mishandled by PyObjC. We now
expose -count only when the object we wrap looks like a collection from a JavaScript
point of view (eg, it has a length property).

bindings/objc/WebScriptObject.mm: (-[WebScriptObject _shouldRespondToCount]): (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]): (-[WebScriptObject _count]):
bindings/objc/WebScriptObjectPrivate.h:

7:51 AM Changeset in webkit [20342] by darin

2 edits in trunk/WebCore

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Fix obvious typo in the change from last night -- forgot to assign to the variable.

4:51 AM Changeset in webkit [23135] by andersca

4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

<rdar://problem/5050512>
Need invalid/expired certificate alerts

Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it
call down to WebCore.

Interfaces/IWebMutableURLRequest.idl:
WebMutableURLRequest.cpp: (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
WebMutableURLRequest.h:

4:24 AM Changeset in webkit [23134] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Made the metrics of styled selects match those on the Mac to get
fast/forms/001.html passing.

4:22 AM Changeset in webkit [23133] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

Workaround a CFNetwork crash that affects DRT.

WebView.cpp: (WebView::initWithFrame): Commented out cookie storage initialization.

3:27 AM Changeset in webkit [23132] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebView.cpp: Added missing #include.

3:18 AM Changeset in webkit [23131] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Fix typo.

3:14 AM Changeset in webkit [23130] by aroben

8 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Implemented layoutTestController.setTabKeyCyclesThroughElements() to
fix fast/events/keypress-insert-tab.html.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Removed unnecessary string comparison.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setTabKeyCyclesThroughElementsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented [set]TabKeyCyclesThroughElements.

Interfaces/IWebViewPrivate.idl: Added new declarations.
WebView.cpp: (WebView::setTabKeyCyclesThroughElements): Implemented. (WebView::tabKeyCyclesThroughElements): Implemented.
WebView.h: Updated.

2:45 AM Changeset in webkit [23129] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Oliver.

Implemented layoutTestController.clearBackForwardList() to fix
fast/dom/location-hash.html.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (clearBackForwardListCallback): Implemented.

2:13 AM Changeset in webkit [23128] by hyatt

5 edits
2 adds in branches/WindowsMerge/WebCore

Land advanced text ( turned off )

2:12 AM Changeset in webkit [23127] by hyatt

2 edits in branches/WindowsMerge/WebKitWin

Land advanced text ( turned off )

2:11 AM Changeset in webkit [23126] by andersca

6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
(WebCore::willCacheResponse):
Remove FIXMEs.

(WebCore::makeFinalRequest):
New function that makes a final CFURLRequest depending on cookie policy and whether any
invalid SSL certificates should be ignored.

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
Use makeFinalRequest.

(WebCore::ResourceHandle::cookieStorageAcceptPolicy):
(WebCore::ResourceHandle::setCookieStorageAcceptPolicy):
(WebCore::ResourceHandle::cookieStorage):
(WebCore::ResourceHandle::setCookieStorage):
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
New functions for setting cookie policy, the deafult cookie storage and whether invalid
SSL certificates should result in an error.

platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Set cookie storage, cookie policy and SSL properties.

platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Use same functions as the mac (sorta).

(WebCore::cookiesEnabled):
Implement this.

WebKitWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable

WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Update the cookie storage accept policy.

(WebView::initWithFrame):
Initialize the cookie storage.

2:11 AM Changeset in webkit [20341] by hyatt

5 edits in trunk/WebCore

Refactor fonts a bit for portability.

2:06 AM Changeset in webkit [23125] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Oliver.

Remove Arial fonts because of <rdar://problem/5074441>.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Don't install Arial.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold Italic.ttf: Removed.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold.ttf: Removed.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Italic.ttf: Removed.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial.ttf: Removed.

2:04 AM Changeset in webkit [20340] by aroben