⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 22, 2007:

11:14 PM Changeset in webkit [23172] by hyatt
  • 3 edits in branches/WindowsMerge/WebKitWin

Fix for print stylesheets not being honored.

11:07 PM Changeset in webkit [20425] by hyatt
  • 4 edits in trunk/WebCore

printing changes

10:59 PM Changeset in webkit [23171] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben.


Fixed <rdar://problem/5082985> Select menus are too see-through

Upped alpha value from 90 to 95. Menus will still seem a little
more see-through than on the mac, since their backgrounds are
white, not grey, but white matches other Windows browsers.


  • ChangeLog:
  • platform/win/PopupMenuWin.cpp:
10:58 PM Changeset in webkit [20424] by bdash
  • 4 edits in tags/Safari-4522.5

Versioning.

10:55 PM Changeset in webkit [20423] by sfalken
  • 1 copy in tags/Safari-522.4.2b

New tag.

10:55 PM Changeset in webkit [20422] by aroben
  • 1 edit
    8 adds in trunk/JavaScriptCore

Reviewed/landed by Adam.

  • Adding mac project files for apollo port of JavaScriptCore. Currently project just builds dftables.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Added.
10:50 PM Changeset in webkit [20421] by bdash
  • 2 edits in tags/Safari-4522.5/WebCore

Merge in r20390.

10:47 PM Changeset in webkit [20420] by bdash
  • 1 copy in tags/Safari-4522.5

New tag.

10:00 PM Changeset in webkit [20419] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5074974>
CrashTracer: [USER] repro crash in Safari at com.apple.WebCore: WebCore::FrameLoader::activeDocumentLoader const + 6


  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Don't use ResourceResponse:isHTTP here since that only looks at the protocol instead of if the response came from a HTTP server (and not a web archive).
9:41 PM Changeset in webkit [20418] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged 20416 from TOT

9:07 PM Changeset in webkit [20417] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp:
8:36 PM Changeset in webkit [20416] by hyatt
  • 2 edits in trunk/WebCore

Fix wheeling issue on gamespot.com

8:33 PM Changeset in webkit [20415] by thatcher
  • 1 copy in branches/Safari-522

New branch.

8:33 PM Changeset in webkit [20414] by thatcher
  • 1 delete in branches/Safari-522

Removing this branch.

6:43 PM Changeset in webkit [23170] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

<rdar://problem/5081539>
QT content is dupped on a page, if page is being previewed or printed.


Don't update the frame geometry if the document is in printing mode.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):
6:26 PM Changeset in webkit [23169] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

<rdar://problem/5082270>
Crash in windows media player at MTV.COM


Ignore any WM_PAINT events we get while painting.


  • WebView.cpp: (WebView::WebView): (WebView::updateBackingStore): (WebView::paint): (WebViewWndProc):
  • WebView.h: (WebView::isPainting):
5:32 PM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Removed mouseClick() since it's been removed in r20407. (diff)
5:25 PM Changeset in webkit [20413] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by kevin


<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty


  • editing/selection/5081257-1-expected.checksum: Added.
  • editing/selection/5081257-1-expected.png: Added.
  • editing/selection/5081257-1-expected.txt: Added.
  • editing/selection/5081257-1.html: Added.
  • editing/selection/5081257-2-expected.checksum: Added.
  • editing/selection/5081257-2-expected.png: Added.
  • editing/selection/5081257-2-expected.txt: Added.
  • editing/selection/5081257-2.html: Added.

WebCore:

Reviewed by kevin

<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from positions inside the document into an editable body.
5:16 PM Changeset in webkit [23168] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Fix by Hyatt, reviewed and committed by me.

Fix for <rdar://problem/5082360> Incomplete frame paint when
shrinking window @ google.com

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setFrameGeometry): Wrong order!
5:15 PM Changeset in webkit [20412] by ddkilzer
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

Use BUILDING_ON_TIGER from WebKitPrefix.h instead of local
MAC_OS_X_VERSION_MAX_ALLOWED <= MAC_OS_X_VERSION_10_4 tests.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
4:57 PM Changeset in webkit [20411] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele and John

<rdar://5043528> - Prepare for new API


  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication): Clear CF type
4:26 PM Changeset in webkit [23167] by aroben
  • 5 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adele.

Implemented layoutTestController.dumpTitleChanges.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpTitleChangesCallback): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didReceiveTitle): Implemented.
3:14 PM Changeset in webkit [20410] by bdakin
  • 2 edits in trunk/WebCore

Patch by Hyatt, reviewed and committed by me.

Does not reproduce consistently, so a layout test does not seem
possible.

Fix for <rdar://problem/5082421> Constantly hitting ASSERT(!
needsLayout()) in RenderView::paint()

  • page/FrameView.cpp: (WebCore::FrameView::layoutPending): It is not enough to ask if the layout timer is active. There may be times that we don't have a body yet so we cannot schedule layout yet, but the root still needs layout.
3:08 PM Changeset in webkit [20409] by spadma
  • 7 edits in S60/branches/3.1m

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
3:08 PM Changeset in webkit [20408] by spadma
  • 7 edits in S60/trunk

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
2:58 PM Changeset in webkit [23166] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Rubberstamped by Geoff.

Removed eventSender.mouseClick now that it isn't used.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
2:53 PM Changeset in webkit [20407] by aroben
  • 8 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Geoff.

Replaced all calls to eventSender.mouseClick with paired calls to
mouseDown/mouseUp.

  • fast/events/click-count.html:
  • fast/events/event-sender-mouse-click-expected.txt: Removed.
  • fast/events/event-sender-mouse-click.html: Removed.
  • fast/events/frame-click-focus.html:
  • fast/events/objc-event-api.html:
  • fast/forms/focus-selection-input.html:
  • fast/forms/focus-selection-textarea.html:

WebKitTools:

Reviewed by Geoff.

Removed eventSender.mouseClick because it was only useful for AppKit
controls, which we don't use anymore.

  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed mouseClick.
2:52 PM Changeset in webkit [23165] by adele
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)

  • Interfaces/IWebURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty. On the mac, NSURLRequests created from empty ResourceRequests are nil. We may want to consider that in the future, but there were too many places in the app that expected the IWebURLRequest to be non-null.
  • WebMutableURLRequest.h:
2:52 PM Changeset in webkit [20406] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-21 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
​http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
2:50 PM Changeset in webkit [20405] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-21 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
​http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
2:20 PM Changeset in webkit [20404] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


Followup for recent fix to 5079700, found by assertion added to Safari.

  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): Fixed another place in this method where an empty NSString was being returned instead of nil. Cleaned up the style a little too.
2:03 PM Changeset in webkit [20403] by thatcher
  • 1 edit in tags/JavaScriptCore-5522.4.1/JavaScriptCore/Info.plist

Versioning

2:03 PM Changeset in webkit [20402] by thatcher
  • 2 edits in tags/JavaScriptCore-5522.4.1/JavaScriptCore

Merging fix from r20368.

2:00 PM Changeset in webkit [20401] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.1/JavaScriptCore

New tag (part 2.)

2:00 PM Changeset in webkit [20400] by thatcher
  • 1 delete in tags/JavaScriptCore-5522.4.1/JavaScriptCore

Removing bad tag.

1:59 PM Changeset in webkit [20399] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.1/JavaScriptCore

New tag (part 2.)

1:58 PM Changeset in webkit [20398] by thatcher
  • 1 add in tags/JavaScriptCore-5522.4.1

New tag (part 1.)

1:56 PM Changeset in webkit [20397] by thatcher
  • 1 move in tags/WebCore-5522.4.1

Move this tag.

1:53 PM Changeset in webkit [20396] by thatcher
  • 1 edit in tags/Safari-5522.4.1/WebCore/Info.plist

Versiong.

1:52 PM Changeset in webkit [20395] by thatcher
  • 5 edits in tags/Safari-5522.4.1/WebCore

Merging fix from r20381.

1:51 PM Changeset in webkit [20394] by thatcher
  • 1 copy in tags/Safari-5522.4.1/WebCore

New tag (part 2.)

1:50 PM Changeset in webkit [20393] by thatcher
  • 1 add in tags/Safari-5522.4.1

New tag (part 1.)

1:45 PM Changeset in webkit [20392] by hyatt
  • 4 edits in trunk/WebCore

Remove unnecessary destroyFrameAtIndex call. Now that we throw away
the image source, it is no longer needed.

Reviewed by beth

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
12:28 PM Changeset in webkit [20391] by brmorris
  • 2 edits in S60/trunk/WebKit

borges, reviewed by bradley

DESC: minor fix to renderer.mmpi for new build system
​http://bugs.webkit.org/show_bug.cgi?id=13027

  • group/renderer.mmpi:
12:09 PM Changeset in webkit [20390] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Geoff, Darin.

<rdar://problem/5077892> In RapidWeaver 3.5.1, a crash occurs when attempting to load Safari Bookmarks in iMedia Browser


  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Change default on Tiger to NSLog rather than raise an exception.
11:22 AM Changeset in webkit [20389] by darin
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • use binary_search instead of hash table; slightly better performance and less memory use
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use binary_search.
11:17 AM Changeset in webkit [20388] by darin
  • 4 edits in trunk

WebCore:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDocumentLoader): Add a call to detachChildren() after the call to prepareForDataSourceReplacement(). There was no reason for this crucial loading step to be left to the client.

WebKit:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::prepareForDataSourceReplacement): Remove call to detachChildren. This should be a WebCore responsibility.
3:55 AM Changeset in webkit [23164] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix crasher in RenderTableSection::paint

3:55 AM Changeset in webkit [23163] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Fix crasher in RenderTableSection::paint

3:55 AM Changeset in webkit [23162] by hyatt
  • 4 edits in branches/WindowsMerge/WebKitWin

Fix crasher in RenderTableSection::paint

3:47 AM Changeset in webkit [20387] by hyatt
  • 1 edit in trunk/WebCore/platform/ScrollView.h


2:21 AM Changeset in webkit [20386] by aroben
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Ada.

Added a new test to make sure that eventSender.mouseClick works
correctly.

  • fast/events/click-count-expected.txt: Added.
  • fast/events/click-count.html: Added.

Updated results for some tests that depended on the broken version of
eventSender.mouseClick.

  • fast/events/objc-event-api-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebKitTools:

Reviewed by Ada.

Make eventSender.mouseClick actually send a mouse up event.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseClick]):
2:13 AM Changeset in webkit [20385] by hyatt
  • 5 edits in trunk/WebCore

Minor refactoring and cleanup of the bridge calls that want to control layout settings on the RenderView.
Have the bridge talk through the FrameView instead of just asking for the RenderView directly.

Add an assert to help catch situations where the RenderView needs layout at paint time, since this is a known
catastrophic scenario that will (much of the time) result in a crash in RenderTableSection::paint.

Reviewed by aroben

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout):
  • page/FrameView.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge needsLayout]): (-[WebCoreFrameBridge setNeedsLayout]):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
1:51 AM Changeset in webkit [23161] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-22 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Hyatt and Alice.


Changed the mouse event processing in the WebView wndproc so we actually
allow a mouse event with click count > 3, which matches the mac safari behavior.


Set globalPrevButton and globalPrevPoint also in mouse down.

  • WebView.cpp: (WebView::handleMouseEvent):
12:04 AM Changeset in webkit [23160] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix wheel events.

Mar 21, 2007:

10:55 PM Changeset in webkit [20384] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.


Re-worked the fix in r20375. 'M' and 'm' are not the only commands that
accept "extra" coordinates -- virtually all commands accept them.

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
10:54 PM Changeset in webkit [20383] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by NOBODY (more word tweaking).

  • building/checkout.html: By popular demand, the link to the svn 1.3 client has been removed.
10:48 PM Changeset in webkit [20382] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by NOBODY (tweaked wording).

  • building/checkout.html: Got rid of "click here" link and restructured sentences linking to svn clients.
10:17 PM Changeset in webkit [23159] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

Force SVG tests to paint to match the Mac results.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Force a paint if we're running an SVG test.
9:31 PM Changeset in webkit [20381] by harrison
  • 5 edits in trunk/WebCore

Reviewed by hyatt.

<rdar://problem/5072460> CrashTracer: [USER] 1 crashes in Xcode at com.apple.ImageIO.framework: getBandProcPNG + 168

An NSData object was being alloc/init'd, then returned callers who cast the pointer as a
CFDataRef, including calling CFRelease on it. The problem is that under garbage collection, the NS
retain count is ignored (it's always 0), but the CFRetain and CFRelease are not ignored. This
caused the object to be over-released. The solution that works in both GC and non-GC is to "transfer"
the initial NS retain count to the CF retain count, using HardRetainWithNSRelease.


The creator of the NSData was SharedBuffer::createNSData. The callers were PDFDocumentImage::dataChanged()
and ImageSource::setData(). This particular crash involved the ImageSource::setData() case.

  • platform/SharedBuffer.h: Declare createCFData().


  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData): Call createCFData instead of createNSData.


  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Call createCFData instead of createNSData.


  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData): Implement createCFData(). Use HardRetainWithNSRelease for gc safety.
9:16 PM Changeset in webkit [20380] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin. Patch by Mitz.

  • fast/dynamic/view-overflow-expected.checksum: Added.
  • fast/dynamic/view-overflow-expected.png: Added.
  • fast/dynamic/view-overflow-expected.txt: Added.
  • fast/dynamic/view-overflow.html: Added.

WebCore:

Reviewed by Darin. Patch by Mitz.

Test: fast/dynamic/view-overflow.html

  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Reset overflowHeight() and overflowWidth() before calling docHeight() and docWidth(), since the former act as a lower bound for the latter.
9:11 PM Changeset in webkit [20379] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by Adam.

  • building/checkout.html: Add link to svn 1.4 client for Mac OS X 10.4.
9:09 PM Changeset in webkit [20378] by ggaren
  • 2 edits in trunk/LayoutTests

Fixed bad version of results that I check in accidentally.

  • svg/dom/string-list-parser-expected.txt:
9:05 PM Changeset in webkit [20377] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Beth Dakin.


A little cleanup based work I've been doing on the SVG parsers.

  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipString):
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: Moved checkString into SVGParserUtilities.h, so it could be with all its friends. Renamed "checkString" to "skipString" to match the rest of the code and to be clear about which functions move the buffer pointer. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute): Changed gotos into returns. Removed unnecessary magic number.
8:50 PM Changeset in webkit [20376] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the SVG rgb color parser.

  • svg/dom/rgb-color-parser-expected.txt: Added.
  • svg/dom/rgb-color-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5078471> SVG rgb color parser runs past end of
buffer when running fuzzing test

  • ksvg2/svg/SVGColor.cpp: (WebCore::parseNumberOrPercent): Check for past the end condition. (WebCore::SVGColor::colorFromRGBColorString): Reversed "read past end of buffer, then check if you're past the end" logic.
8:37 PM Changeset in webkit [20375] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the path parser.

  • svg/dom/path-parser-expected.txt: Added.
  • svg/dom/path-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5079410> SVG path parser hangs, exhausts memory when
running fuzzer test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): Don't assume that extra digits are always preceded by an 'M' or an 'm'.
8:28 PM Changeset in webkit [20374] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.


Added fuzz tester for the string list parser.

  • svg/dom/string-list-parser-expected.txt: Added.
  • svg/dom/string-list-parser.html: Added.
8:26 PM Changeset in webkit [20373] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.


Added fuzz tester for the length list parser.

  • svg/dom/length-list-parser-expected.txt: Added.
  • svg/dom/length-list-parser.html: Added.
8:21 PM Changeset in webkit [20372] by ggaren
  • 2 edits
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.


Factored randomizing functions into their own file, in preparation for future
tests that rely on them.


  • svg/dom/resources/scripted-random.js: Added.
  • svg/dom/transform-parser.html: Factored out scripted-random.js, added a small string that increases the normal-seemingness of the last test.
8:12 PM Changeset in webkit [20371] by thatcher
  • 4 edits in trunk/LayoutTests

New results after rolling out r19828 in r20352.

  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:
6:42 PM Changeset in webkit [20370] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adam


  • fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled or saved for .Mac homepage login
  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): don't count empty strings as valid results
6:21 PM Changeset in webkit [23158] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Oliver.

  • Skipped: Added an SVG test that causes a debug ASSERT in the C Runtime.
6:15 PM Changeset in webkit [23157] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Oliver.

Make W3C SVG tests render at the correct dimensions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Resize the WebView if we're running a W3C SVG test. (runTest): Save the current test filename.
5:48 PM Changeset in webkit [20369] by justing
  • 4 edits in trunk

Reviewed by darin

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Release the RefPtr to avoid increasing/decreasing the refcount unnecessarily. (WebCore::propertyMissingOrEqualToNone): Added and used instead of converting values to strings. (WebCore::elementHasTextDecorationProperty): (WebCore::createMarkup):
5:31 PM Changeset in webkit [20368] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/5076599> JavaScriptCore has a weak export (vtable for KJS::JSCell)

5:07 PM Changeset in webkit [23156] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • WebView.cpp: (WebView::initWithFrame): Remove #ifdef now that DRT no longer crashes.
4:59 PM Changeset in webkit [20367] by mjs
  • 1 edit
    6 adds in trunk/WebKitSite
  • some specs to propose by email
  • specs/HTML_Timed_Media_Elements.html: Added.
  • specs/Timed_Media_CSS.html: Added.
  • specs/Timed_Media_Elements-Open_Issues.html: Added.
  • specs/mediaelement.css: Added.
  • specs/movie-status-states.png: Added.
4:58 PM Changeset in webkit [20366] by justing
  • 3 edits
    12 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text

Tests for the bug:

  • editing/pasteboard/5075944-expected.checksum: Added.
  • editing/pasteboard/5075944-expected.png: Added.
  • editing/pasteboard/5075944-expected.txt: Added.
  • editing/pasteboard/5075944.html: Added. Tests that the element that has the text-decoration and all its descendants down to the common ancestor are included in the copied markup (instead of the text-decoration property being treated as though it were inheritable and placed on the style span wrapper):
  • editing/pasteboard/5075944-2-expected.checksum: Added.
  • editing/pasteboard/5075944-2-expected.png: Added.
  • editing/pasteboard/5075944-2-expected.txt: Added.
  • editing/pasteboard/5075944-2.html: Added. Tests that moveParagraphs gets underlining right (it doesn't use annotation):
  • editing/pasteboard/5075944-3-expected.checksum: Added.
  • editing/pasteboard/5075944-3-expected.png: Added.
  • editing/pasteboard/5075944-3-expected.txt: Added.
  • editing/pasteboard/5075944-3.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text


We stopped adding markup for all the ancestors
of lastClosed up to the commonAncestorBlock
because it was adding a lot of unnecessary markup.
This caused us to lose underlining when copying a
partially selected underlined element (even though
we put all styles that the copied markup inherits
into a style span, because the text-decoration
isn't inheritable).

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Moved code here. (WebCore::elementHasTextDecorationProperty): Added. (WebCore::createMarkup): If the copied markup has a text-decoration because some common ancestor has a text-decoration property set, include that ancestor and all its descendants in the copied markup.
4:40 PM Changeset in webkit [23155] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Fix broken changelog.

4:37 PM Changeset in webkit [23154] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Advanced text improvements.

4:28 PM Changeset in webkit [20365] by thatcher
  • 1 copy in branches/Safari-522

New branch.

2:59 PM Changeset in webkit [20364] by oliver
  • 5 edits
    2 adds in trunk

2007-03-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti.

WebCore:

Update a few SVG attribute parsers to be more defensive against
reading beyond the end of input.

Fixes rdar://problem/5077218 -- SVG transform parser runs past
end of buffer when running fuzzing test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipOptionalSpacesOrDelimiter):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::parseTransformParamList): (WebCore::SVGTransformable::parseTransformAttribute):

LayoutTests:

Fuzz test for SVG transform parser

  • svg/dom/transform-parser-expected.txt: Added.
  • svg/dom/transform-parser.html: Added.
2:34 PM Changeset in webkit [23153] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/5074274> right-clicking in certain iframes ends up
left-clicking, and context menu appears far away

  • WebView.cpp: (WebView::handleContextMenuEvent): We were always calling sendContextMenuEvent() on the main frame!! Instead, call it on the focused or main frame.
2:22 PM Changeset in webkit [23152] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

LayoutTestsWin:

Reviewed by David Kilzer (yay!).

Re-enable the editing tests, except for two crashers.

  • Skipped:
12:06 PM Changeset in webkit [20363] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=13140
Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)

Test: svg/carto.net/frameless-svg-parse-error.html

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportError): Added a null check. (WebCore::SVGDocumentExtensions::reportWarning): Ditto.
11:03 AM Changeset in webkit [23151] by adele
  • 7 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Call updateActiveState on the WebView in didCommitLoadForFrame. This is required so that nodes can be properly focused in the document.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didCommitLoadForFrame):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:

WebKitWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Added updateActiveState SPI for DumpRenderTree.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus. We should merge this logic into updateActiveState eventually. (WebView::updateActiveState):
  • WebView.h:
10:55 AM Changeset in webkit [20362] by adele
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • API/JSStringRef.cpp: (JSStringIsEqual): Added JSLock.
2:30 AM Changeset in webkit [20361] by zack
  • 2 edits in trunk/JavaScriptCore

Fix the compile when USE(MULTIPLE_THREADS) isn't defined

12:24 AM Changeset in webkit [20360] by bdakin
  • 5 edits in trunk/WebCore

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

I tried to fix this earlier today but my fix caused a regression
scrolling through RSS pages. It turns out that sometimes scroll
events need to propagate immediately, and sometimes they must be
delayed or they risk deleting objects that are expected to be
around after the event has propagated. Mitz's original fix made
sheduleEvent() only delay events that happen during layout. This
fix marks two other places in addition to layout where events also
need to be delayed. These two places are places that were marked
with FIXMEs that Mitz removed in his original patch. (There was a
third FIXME in RenderLayer::updateScrollInfoAfterLayout() but that
case is only called through layout and is covered by Mitz's
original patch.)

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added assertion. (WebCore::FrameView::layout): Call new functions to increment and decrement the queued events count. (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): Decrement queued events count and dispatch events if the count has zeroed.
  • page/FrameView.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::Marquee::start):
12:21 AM Changeset in webkit [20359] by bdash
  • 2 edits in trunk/WebCore

2007-03-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by John Sullivan.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Reordered the code to allow resizing to be terminated by a mouseup event regardless of whether the frameset needs layout.
Note: See TracTimeline for information about the timeline view.