Context Navigation

test for http://bugs.webkit.org/show_bug.cgi?id=13156 REGRESSION (r19621): Pasting breakable content where wrapped line is too long to fit in a textarea fails to draw a horizontal scrollbar

fast/text/midword-break-after-breakable-char-expected.checksum: Added.
fast/text/midword-break-after-breakable-char-expected.png: Added.
fast/text/midword-break-after-breakable-char-expected.txt: Added.
fast/text/midword-break-after-breakable-char.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13156 REGRESSION (r19621): Pasting breakable content where wrapped line is too long to fit in a textarea fails to draw a horizontal scrollbar

Test: fast/text/midword-break-after-breakable-char.html

Breaking in the middle of the word
is allowed only if no breaking opportunity between words has occurred yet. The
first position on the line should not be considered "between words" even if
it is a breaking opportunity.

rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed according to the above. Also cleaned up a couple of lines.

10:53 PM Changeset in webkit [20478] by hyatt

13 edits in trunk/WebCore

Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data that WebCore will keep
around even on live pages (pages being displayed in tabs/windows or in the back/forward cache).
Images will decode to paint and once the decoded data exceeds the cache size, the decoded data will be
tossed.

Refine the flushing algorithm to apply the two-pass decode/evict model to each LRU-SP queue individually, rather
than to all the lists at once. This allows the cache to evict large encoded resources before flushing small
or frequently accessed decoded onces.

Added information on live/decoded data to the cache statistics.

Reviewed by darin

loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneAllResources): (WebCore::Cache::setMaximumSize): (WebCore::Cache::remove): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::liveLRUListFor): (WebCore::Cache::removeFromLiveResourcesList): (WebCore::Cache::insertInLiveResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::getStatistics):
loader/Cache.h: (WebCore::Cache::TypeStatistic::TypeStatistic):
loader/CachedImage.cpp: (WebCore::CachedImage::decodedSizeWillChange): (WebCore::CachedImage::decodedSizeChanged):
loader/CachedImage.h:
loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::ref): (WebCore::CachedResource::deref): (WebCore::CachedResource::setEncodedSize): (WebCore::CachedResource::liveResourceAccessed):
loader/CachedResource.h: (WebCore::CachedResource::liveAccessCount): (WebCore::CachedResource::resetLiveAccessCount): (WebCore::CachedResource::increaseLiveAccessCount):
platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::cacheFrame):
platform/graphics/ImageObserver.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):

10:14 PM Changeset in webkit [23186] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-03-24 Steve Falkenburg <sfalken@apple.com>

Build fix.

WebDownload.h: Remove WebCore namespace

9:31 PM Changeset in webkit [23185] by aroben

9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

Unfortunately the ported code is mostly untested due to
<rdar://problem/5086934>.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (compareHistoryItems): Ported from Mac. (dumpHistoryItem): Ditto. (dumpBackForwardList): Ditto. (dump): Dump the back-forward list if requested. (runTest): Initialize new globals.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpBackForwardListCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
WebFrame.cpp: (WebFrame::childFrames): Removed unused variable.
WebHistoryItem.cpp: (WebHistoryItem::target): Implemented. (WebHistoryItem::isTargetItem): Implemented. (WebHistoryItem::children): Implemented.
WebHistoryItem.h: Added declarations.

7:48 PM Changeset in webkit [20477] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=13123 CSS selectors that use :lang, :not, and namespaces do not serialize correctly

fast/css/css-selector-text-expected.txt: Added.
fast/css/css-selector-text.html: Added.

WebCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=13123 CSS selectors that use :lang, :not, and namespaces do not serialize correctly

Test: fast/css/css-selector-text.html

css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText): Add the namespace prefix for tag or attribute names, the sub-selector for :not, and the argument for :lang.

6:27 PM Changeset in webkit [23184] by aroben

4 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix <rdar://problem/5076610> Crash in PluginViewWin::updateWindow when
loading a PDF page for the first time after installing Acrobat Reader

Don't call PluginPackageWin::load() until the PluginViewWin has been
inserted into the Widget tree. load() can result in arbitrary code
execution (in this case, a EULA window appears which takes focus from
the WebView, causing Frame::setIsActive(false) to be called), and we
don't want to be in a transitional state when that happens.

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): Call PluginViewWin's one and only constructor.
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setParent): Call init() after inserting ourselves into the Widget tree. (WebCore::PluginViewWin::PluginViewWin): Defer all real work until init() is called. (WebCore::PluginViewWin::init): Added. Calls m_plugin->load(), then does the rest of the work that was once done by the constructor.
plugins/win/PluginViewWin.h: Removed createNullPlugin and simplified constructor, added setParent override and new init method.

6:22 PM Changeset in webkit [20476] by beidson

8 edits in trunk

JavaScriptCore:

Reviewed by Adam

Whoops, RetainPtr should be in the WTF namespace

wtf/RetainPtr.h:

WebKit:

Reviewed by Adam

RetainPtr is no longer in the WebCore namespace

History/WebBackForwardList.mm:
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebFrameLoaderClient.h:
WebView/WebDocumentLoaderMac.h:

4:27 PM Changeset in webkit [23183] by beidson

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF for WebKitWin and the App

WebCore.vcproj/WebCore.vcproj: Add the ForwardingHeader to the vcprojs

4:21 PM Changeset in webkit [20475] by beidson

30 edits
1 move
2 adds in trunk

JavaScriptCore:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF

wtf/RetainPtr.h: Added
JavaScriptCore.xcodeproj/project.pbxproj: Add it to the project file
JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto

WebCore:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF

ForwardingHeaders/wtf/RetainPtr.h: Added.
WebCore.xcodeproj/project.pbxproj: Removed WebCore/RetainPtr.h

history/HistoryItem.h: Changed #include to <wtf/RetainPtr.h>
history/PageCache.h: Ditto
page/mac/WebCoreFrameBridge.mm: Ditto
platform/ContextMenu.h: Ditto
platform/ContextMenuItem.h: Ditto
platform/DragImage.h: Ditto
platform/FileChooser.h: Ditto
platform/PlatformKeyboardEvent.h: Ditto
platform/PopupMenu.h: Ditto
platform/SharedBuffer.h: Ditto
platform/cf/RetainPtr.h: Removed.
platform/graphics/Icon.h: Changed #include
platform/mac/ClipboardMac.h: Ditto
platform/mac/PasteboardMac.mm: Ditto
platform/mac/WidgetMac.mm: Ditto
platform/network/AuthenticationChallenge.h: Ditto
platform/network/ResourceError.h: Ditto
platform/network/ResourceHandle.h: Ditto
platform/network/ResourceRequest.h: Ditto
platform/network/ResourceResponse.h: Ditto
rendering/RenderThemeMac.mm: Ditto

WebKit:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF

ForwardingHeaders/wtf/RetainPtr.h: Added.
History/WebBackForwardList.mm: Changed #import to <wtf/RetainPtr.h>
WebCoreSupport/WebEditorClient.h: Ditto
WebCoreSupport/WebFrameLoaderClient.h: Ditto
WebView/WebDocumentLoaderMac.h: Ditto

4:15 PM Changeset in webkit [20474] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5086797>, layoutPending is now reporting incorrect results, which will lead
to all sorts of layout issues. This is in bugzilla as 13179.

Reviewed by hyatt

fix http://bugs.webkit.org/show_bug.cgi?id=13179 REGRESSION (r20410): In debug builds, loading a certain page is suspended until redisplay is forced

Moved the root->needsLayout() check from layoutPending() to needsLayout()
to restore the behavior before r20324.

page/FrameView.cpp: (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout):

3:13 PM Changeset in webkit [20473] by ddkilzer

2 edits in trunk/WebCore

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=13180

<rdar://problem/5084478>

Another debug build crash from ASSERTION FAILED: !needsLayout()

No test possible because updateRendering() is always called after script
execution.

page/FrameView.cpp: (WebCore::FrameView::layout): Get the layout root after calling recalcStyle() since a style recalc may result in needing to do start layout at the root.

2:53 PM Changeset in webkit [20472] by zimmermann

2 edits in trunk/WebCore

Not reviewed. Build fix.
Fix FloatRect vs. IntRect confusion.

10:25 AM Changeset in webkit [20471] by sullivan

5 edits in trunk/WebKit

Reviewed by Adele

fixed <rdar://problem/5084872> Need to add flickr to spoof list in WebKit
only do site-specific spoofing if a preference is set

WebView/WebPreferenceKeysPrivate.h: added WebKitUseSiteSpecificSpoofingPreferenceKey

WebView/WebPreferences.m: (+[WebPreferences initialize]): initialize WebKitUseSiteSpecificSpoofingPreferenceKey to false (-[WebPreferences _useSiteSpecificSpoofing]): get value of WebKitUseSiteSpecificSpoofingPreferenceKey (-[WebPreferences _setUseSiteSpecificSpoofing:]): set value of WebKitUseSiteSpecificSpoofingPreferenceKey

WebView/WebPreferencesPrivate.h: declare _useSiteSpecificSpoofing and _setUseSiteSpecificSpoofing

WebView/WebView.mm: cache the value of WebKitUseSiteSpecificSpoofingPreferenceKey in a bool in _private (-[WebView _preferencesChangedNotification:]): update the cached value (-[WebView setPreferences:]): ditto (-[WebView WebCore::_userAgentForURL:WebCore::]): Only spoof here if the new site-specific spoofing preference is enabled. If it is, pass Safari 2.0.4's user agent string for flickr.com. We can remove this case when 5081617 is addressed.

6:26 AM Changeset in webkit [20470] by bdash

2 edits in trunk/WebCore

Fix incorrect radar number.

5:27 AM Changeset in webkit [20469] by zimmermann

3 edits
4 adds in trunk

Reviewed by Oliver.

Fix all known RenderSVGImage problems.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12126 (RenderSVGImage seems to suffer from integer overflow)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12442 (raster images disappearing during script execution (SVG))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12572 (WebKit does not properly invalidate image region after image load)

Added test: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html

3:25 AM Changeset in webkit [20468] by bdash

2 edits in trunk/WebCore

2007-03-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13177 Suppress control characters in the ATSUI code path

platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):

3:16 AM Changeset in webkit [20467] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5086400>, images scrolled offscreen continue to animate. Safari 2 would
halt animations when images were no longer visible.

Reviewed by mjs, olliej

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):

2:24 AM Changeset in webkit [20466] by bdash

1 edit in tags/Safari-4522.5.2/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

2:24 AM Changeset in webkit [20465] by bdash

2 edits in tags/Safari-4522.5.2/JavaScriptGlue

Merge in r20461.

2:22 AM Changeset in webkit [20464] by bdash

1 copy in tags/Safari-4522.5.2/JavaScriptGlue

New tag (part 2).

2:21 AM Changeset in webkit [20463] by bdash

1 add in tags/Safari-4522.5.2

New tag (part 1).

2:20 AM Changeset in webkit [20462] by bdash

2 edits in trunk/JavaScriptGlue

2007-03-24 Mark Rowe <mrowe@apple.com>

Reviewed by Dave Hyatt.

JavaScriptGlue.xcodeproj/project.pbxproj: Use GCC 4.0 for testjsglue.

12:07 AM Changeset in webkit [20461] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/508328>, sluggish text entry in search field. Make sure
our size actually changed before we decide to do a full repaint because of background/border
complexities.

Reviewed by aroben

rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):

Mar 23, 2007:

11:24 PM Changeset in webkit [20460] by hyatt

4 edits in trunk/WebCore

Fix Gmail spurious glyphs issue.

9:38 PM Changeset in webkit [20459] by adele

5 edits
4 adds in trunk

LayoutTests:

Reviewed by Adele.

pixel test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13153 REGRESSION: Visual highlighting of pre-populated blank line in textarea is broken

editing/selection/doubleclick-crash-expected.checksum:
editing/selection/doubleclick-crash-expected.png:
fast/text/selection-hard-linebreak-expected.checksum: Added.
fast/text/selection-hard-linebreak-expected.png: Added.
fast/text/selection-hard-linebreak-expected.txt: Added.
fast/text/selection-hard-linebreak.html: Added.

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=13153 REGRESSION: Visual highlighting of pre-populated blank line in textarea is broken

fix a bug where selecting across a soft line break did not highlight to the end of the first line if it contained skipped whitespace

Test: fast/text/selection-hard-linebreak.html

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): Changed to treat a selection that ends on the end of a hard line break as if it ends after the line break. Fixed the case of a selection that starts and ends in the same text object as the box but does not intersect it to return SelectionNone instead of selectionBoth.

9:05 PM Changeset in webkit [20458] by adele

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

test for http://bugs.webkit.org/show_bug.cgi?id=13124 REGRESSION: Reproducible crash in Widget::getView

fast/frames/hover-timer-crash-expected.txt: Added.
fast/frames/hover-timer-crash.html: Added.

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=13124 REGRESSION: Reproducible crash in Widget::getView

Test: fast/frames/hover-timer-crash.html

page/Frame.cpp: (WebCore::Frame::setView): Added a call to EventHandler::clear().

8:56 PM Changeset in webkit [23182] by beidson

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

<rdar://5086194> - WebHistory overreleases a CFNumber

WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't legitimately get a ref for!

6:41 PM Changeset in webkit [23181] by aroben

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
hacks" menu item to the Debug menu

Added new IWebPrivate::setAllowSiteSpecificHacks SPI.

Interfaces/IWebViewPrivate.idl: Added declaration.
WebView.cpp: (WebView::userAgentForKURL): Only give a site-specific UA if site-specific hacks are turned on. (WebView::setAllowSiteSpecificHacks): Added.
WebView.h: (WebView::allowSiteSpecificHacks): Added.

6:18 PM Changeset in webkit [20457] by justing

1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Forgot to include these nil checks in my previous checkin.

5:58 PM Changeset in webkit [20456] by justing

3 edits
2 adds in trunk

LayoutTests:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

editing/pasteboard/5078739-expected.txt: Added.
editing/pasteboard/5078739.html: Added.

WebCore:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Check for an empty fragment after removing a redundant style span instead of before.

3:54 PM Changeset in webkit [23180] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5083928> In editable webviews, caps lock key is ignored

platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Removed code to store lowercase characters in m_text. Now that we use the character code to create m_text this is already taken care of. This does mean that m_unmodifiedText is not right. This is used for accesskeys, which don't work yet, so that is covered in rdar://5085596. This also fixes line endings in this file.

3:32 PM Changeset in webkit [23179] by bdakin

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5083914> Cursor is wrong for all context
menus

WebView.cpp: (WebView::handleContextMenuEvent): Set the cursor to the pointer cursor.

3:26 PM Changeset in webkit [20455] by aroben

3 edits
2 adds in trunk/JavaScriptCore

Reviewed/landed by Adam.

Bug 13175: Make apollo mac project files for JavaScriptCore actually
build something
http://bugs.webkit.org/show_bug.cgi?id=13175

Changing apollo mac project files for JavaScriptCore such that they actually build JavaScriptCore source code.

JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:

2:48 PM Changeset in webkit [20454] by hyatt

2 edits in trunk/WebCore

<rdar://problem/5085063>

Fix non-looping animation on cuteoverload.com. Just always flush
decoded data for large animated images to avoid our cache getting
out of sync with the image source.

Reviewed by ggaren

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):

2:09 PM Changeset in webkit [20453] by adele

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
http://bugs.webkit.org/show_bug.cgi?id= 13020

No known way to add a layout test for this. We would need a way to know exactly how the event was consumed.

page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): If the keypress event has its default behavior prevented, then we should consider the keydown event handled.

1:53 PM Changeset in webkit [20452] by brmorris

2 edits in S60/trunk/WebCore

rathnasa, reviewed by zalan

DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
http://bugs.webkit.org/show_bug.cgi?id=13074

1:53 PM Changeset in webkit [23178] by aroben

2 edits in branches/WindowsMerge

Being a Boy Scout.

1:50 PM Changeset in webkit [23177] by aliceli1

1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Reviewed by Adam.

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

WebView.cpp: (WebView::userAgentForKURL): added flickr spoof

1:49 PM Changeset in webkit [23176] by aliceli1

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by NOBODY (OOPS!).

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

WebView.cpp: (WebView::userAgentForKURL): added flickr spoof

1:48 PM Changeset in webkit [20451] by zbujtas

2 edits in S60/trunk/WebCore

2007-03-23 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
http://bugs.webkit.org/show_bug.cgi?id=13172

kwq/KWQKHTMLPart.cpp:

1:43 PM Changeset in webkit [20450] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-03-23 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
http://bugs.webkit.org/show_bug.cgi?id=13172

kwq/KWQKHTMLPart.cpp:

1:42 PM Changeset in webkit [20449] by justing

7 edits
8 adds in trunk

LayoutTests:

Reviewed by darin

Fixed (was missing a newline):

editing/execCommand/4917055-expected.txt: Tests setting a caet before the image and changing its alignment:
editing/execCommand/5080333-1-expected.checksum: Added.
editing/execCommand/5080333-1-expected.png: Added.
editing/execCommand/5080333-1-expected.txt: Added.
editing/execCommand/5080333-1.html: Added. Tests selecting the image and changing its alignment:
editing/execCommand/5080333-2-expected.checksum: Added.
editing/execCommand/5080333-2-expected.png: Added.
editing/execCommand/5080333-2-expected.txt: Added.
editing/execCommand/5080333-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5080333>
REGRESSION: Selection changes when changing the alignment of an image

Regression occurred when we started using moveParagraphs
to move content in applyBlockStyle. moveParagraphs
moves by copying, deleting and reinserting content, and
so must be accompanied by selection preservation code.
That code uses rangeFromLocationAndLength and rangeLength,
which use TextIterators, which don't emit anything for images
and other replaced elements, causing this bug.

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Ask rangeLength and rangeFromLocationAndLength to request that their TextIterators emit spaces for replaced elements. Use rangeCompliantEquivalent()s when creating a Range from VisiblePositions, since some VisiblePositions have illegal deepEquivalent()s.
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::handleReplacedElement): Emit a space if requested. (WebCore::TextIterator::representNodeOffsetZero): Emit ranges before m_node, not around m_lastTextNode. These ranges should represent the part of the document associated with the emitted character. (WebCore::TextIterator::rangeLength): Take in the new bool. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto. Also, don't loop an extra time after finding the end of the range when we're looking for zero length ranges. This appeared to be a workaround for the bugs fixed in representNodeOffsetZero in this patch.
editing/TextIterator.h:

1:05 PM Changeset in webkit [20448] by bdash

4 edits in tags/Safari-4522.5.1

Versioning.

1:03 PM Changeset in webkit [20447] by bdash

8 edits in tags/Safari-4522.5.1

Merge in r20445.

12:58 PM Changeset in webkit [20446] by bdash

1 copy in tags/Safari-4522.5.1

New tag.

12:51 PM Changeset in webkit [20445] by bdash

8 edits in trunk

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

Configurations/JavaScriptCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

Configurations/JavaScriptGlue.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

Configurations/WebCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

Configurations/WebKit.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

12:13 PM Changeset in webkit [20444] by zbujtas

2 edits in S60/trunk/WebCore

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Fix NULL pointer check for CacheImage
http://bugs.webkit.org/show_bug.cgi?id=13094

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor):

11:39 AM Changeset in webkit [20443] by darin

2 edits in trunk/WebCore

html/HTMLBodyElement.cpp: Fix comment typo.

11:38 AM Changeset in webkit [20442] by staikos

2 edits in trunk/WebCore

Patch from Adam Treat to make the Qt build work without SVG and XSLT as well as
with.

11:25 AM Changeset in webkit [20441] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5074439> handle margins on frame and iframe elements without involving FrameView, FrameLoader, etc.

html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument): Grab the margin from the frame directly here. There was no real benefit to doing this via FrameView. Later we can delete quite a bit of unneeded code here and in WebKit that exists only to set up the margin values in FrameView, which are now unused.

11:24 AM Changeset in webkit [20440] by adele

5 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
http://bugs.webkit.org/show_bug.cgi?id=13121

fast/dom/HTMLInputElement/input-hidden-value-expected.txt: Added.
fast/dom/HTMLInputElement/input-hidden-value.html: Added.
fast/forms/input-value-expected.txt:

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
http://bugs.webkit.org/show_bug.cgi?id=13121

Rolled out the change for 11866 that made hidden input elements store the value separately from the value attribute.
Added an m_originalValue field that gets set when the element is done being parsed (in closeRenderer). In reset,
use the m_originalValue for hidden input elements.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::closeRenderer): (WebCore::HTMLInputElement::reset): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
html/HTMLInputElement.h:

11:01 AM Changeset in webkit [20439] by staikos

2 edits in trunk/WebKitTools

Patch by Adam Treat. Removes hardcoded path to .pro file.

10:48 AM Changeset in webkit [20438] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-03-22 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):

10:45 AM Changeset in webkit [20437] by spadma

2 edits in S60/trunk/WebKit

2007-03-22 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):

8:08 AM Changeset in webkit [20436] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-03-20 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2

ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):

8:07 AM Changeset in webkit [20435] by spadma

2 edits in S60/trunk/WebKit

2007-03-20 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2

ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):

8:05 AM Changeset in webkit [20434] by spadma

4 edits in S60/trunk

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):

8:02 AM Changeset in webkit [20433] by spadma

4 edits in S60/branches/3.1m

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):

7:57 AM Changeset in webkit [20432] by spadma

2 edits in S60/trunk/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13151

BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):

7:56 AM Changeset in webkit [20431] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13151

BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):

4:47 AM Changeset in webkit [23175] by aroben

9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Implemented dumping of frame scroll positions.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): Ported from Mac. (dump): Added call to dumpFrameScrollPosition. (runTest): Initialize new global.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpChildFrameScrollPositionsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented some WebFrame methods to support dumping frame scroll
offsets in DRT.

Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
WebFrame.cpp: (WebFrame::name): Implemented. (WebFrame::childFrames): Implemented. (WebFrame::scrollOffset): Implemented.
WebFrame.h: Updated/added declarations.

4:41 AM Changeset in webkit [20430] by bdash

1 edit in trunk/WebCore/ChangeLog

Add radar reference.

4:37 AM Changeset in webkit [20429] by bdash

3 edits
4 adds in trunk

2007-03-23 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13157 List markers positioned incorrectly and don't repaint properly on Oxford homepage

Test: fast/lists/marker-image-error.html

rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged): Mark ourselves for relayout if the image failed to load, since that means we will use a bullet instead.

2007-03-23 Mitz Pettel <mitz@webkit.org>