⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 28, 2007:

11:20 PM Changeset in webkit [20569] by dsmith
  • 13 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

  • holes in arrays should be skipped, not treated as undefined, by all such methods
  • an element with value undefined is not a hole
  • Array.prototype.forEach should return undefined
  • kjs/array_object.cpp: (ArrayInstance::getOwnPropertySlot): (ArrayProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

  • holes in arrays should be skipped, not treated as undefined, by all such methods
  • an element with value undefined is not a hole
  • Array.prototype.forEach should return undefined
  • fast/js/array-every-expected.txt:
  • fast/js/array-filter-expected.txt: Added.
  • fast/js/array-filter.html: Added.
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html:
  • fast/js/array-indexof-expected.txt:
  • fast/js/array-indexof.html:
  • fast/js/array-lastIndexOf-expected.txt:
  • fast/js/array-map-expected.txt: Added.
  • fast/js/array-map.html: Added.
  • fast/js/array-some-expected.txt:
  • fast/js/array-some.html:
  • fast/js/resources/array-every.js:
  • fast/js/resources/array-lastIndexOf.js:
11:15 PM Changeset in webkit [20568] by oliver
  • 5 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.

Rename DocLoader::setPasteInProgress, etc to more generic
setAllowStaleResources, etc

  • editing/Editor.cpp: (WebCore::Editor::paste):
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::checkForReload):
  • loader/DocLoader.h: (WebCore::DocLoader::setAllowStaleResources):
  • page/DragController.cpp: (WebCore::DragController::concludeDrag):
9:59 PM Changeset in webkit [20567] by oliver
  • 19 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders and Steve.

Add a flag to DocLoader to prevent it from reloading
when performing a paste or drop operation.


Remove m_cachePolicy from CachedResource as it is never used


Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures
dragging image into GMail message in _web_writeImage and
documentFragmentFromDragData

  • editing/Editor.cpp: (WebCore::Editor::paste): prevent the docloader from reloading resources on paste
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::createResource):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader):

Tidy up constructor initialise new field

(WebCore::DocLoader::checkForReload):

Prevent reload when pasting

  • loader/DocLoader.h: (WebCore::DocLoader::setPasteInProgress): new field and setter
  • page/DragController.cpp: (WebCore::DragController::concludeDrag): prevent the docloader from reloading resources on drop
6:45 PM Changeset in webkit [20566] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - fix typo in gdk build.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::contentsToWindow):
6:18 PM Changeset in webkit [23203] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • updates for <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
6:17 PM Changeset in webkit [20565] by mjs
  • 14 edits in trunk

LayoutTests:

Reviewed by Darin.


  • <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:

WebCore:

Reviewed by Darin.


  • fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)


Handle scrolling external scrollviews around the webview during
autoscroll or when scrolling into view.


This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.

  • page/FrameView.cpp: (WebCore::FrameView::scrollRectIntoViewRecursively):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::updateContents):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
5:15 PM Changeset in webkit [20564] by thatcher
  • 1 edit in tags/JavaScriptCore-5522.4.2/JavaScriptCore/Info.plist

Versioning.

5:14 PM Changeset in webkit [20563] by thatcher
  • 2 edits in tags/JavaScriptCore-5522.4.2/JavaScriptCore

Merge a minimal version of r20351.

5:13 PM Changeset in webkit [20562] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.2

New tag.

4:48 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
4:45 PM Changeset in webkit [20561] by sfalken
  • 1 copy in tags/Safari-522.5.2b

New tag.

3:18 PM Changeset in webkit [20560] by adele
  • 3 edits in trunk/WebKit

Reviewed by Brady.

Update to last fix.

  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): Added check to only use the VitalSource workaround if the app is not linked on or after the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.
2:52 PM Changeset in webkit [20559] by darin
  • 2 edits in trunk/WebCore

Reviewed and landed by Darin

Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
​http://bugs.webkit.org/show_bug.cgi?id=13138

  • platform/StringImpl.cpp: (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::equalIgnoringCase):
2:28 PM Changeset in webkit [20558] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix <rdar://problem/5092653>
REGRESSION: Image decoding making scrolling slow


If decoder gave back a null frame (which I think happens regularly if you don't have full frame
data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
led to massive growth in calculated image size and eventually made cache prune constantly.


No test, I don't know how to make one for this.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame):
2:19 PM Changeset in webkit [20557] by thatcher
  • 2 edits in branches/Safari-522/WebKit

<rdar://problem/5093473> incomplete render of menu (assertion failing in -[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]) (13026)

Rolling out r20042, and these build fixes that followed: r20050, r20058, r20064 and r20077.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
2:13 PM Changeset in webkit [20556] by yongjzha
  • 4 edits in S60/branches/3.1m/WebCore

2007-03-28 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan <​zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

​http://bugs.webkit.org/show_bug.cgi?id=13219

  • khtml/html/htmltokenizer.cpp: (khtml::):
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):
1:59 PM Changeset in webkit [20555] by adele
  • 4 edits in trunk

WebCore:

Reviewed by Kevin M.

WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Convert return value to a string. This matches the behavior in Safari 2.0.

WebKit:

Reviewed by Kevin M.

WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings. We used to allow this
but now we throw a JavaScript exception for return statements that aren't in functions.

Filed this evangelism bug so we can notify VitalSource of the problem:
<rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
9:48 AM Changeset in webkit [20554] by ap
  • 8 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13190
XPath incorrectly handles namespaces on attributes

WebCore:

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but measurable performance improvement for bug 13021. (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::NodeTest): (WebCore::XPath::Step::NodeTest::namespaceURI): (WebCore::XPath::Step::nodeTest): (WebCore::XPath::Step::setNodeTest): Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
  • xml/XPathGrammar.y:
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::optimizeStepPair): Accounted for the above change.

LayoutTests:

  • fast/xpath/attr-namespace-expected.txt: Added.
  • fast/xpath/attr-namespace.html: Added.
  • fast/xpath/xpath-namespaces-expected.txt:
  • fast/xpath/xpath-namespaces.html: Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
8:39 AM Changeset in webkit [20553] by sfalken
  • 1 copy in tags/Safari-522.5.1b

New tag.

4:31 AM Changeset in webkit [20552] by antti
  • 2 edits in trunk/WebKitLibraries

Update libWebKitSystemInterface, previous version was out of date.

  • libWebKitSystemInterface.a:
1:41 AM Changeset in webkit [20551] by oliver
  • 2 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

rs=Hyatt.

Rollout local changes :-/

  • loader/Cache.cpp: (WebCore::Cache::pruneAllResources): (WebCore::Cache::remove):
1:38 AM Changeset in webkit [20550] by oliver
  • 2 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.

Roll out r20511 due to incredible badness

  • loader/Cache.cpp: (WebCore::Cache::pruneAllResources): (WebCore::Cache::remove):
12:18 AM Changeset in webkit [20549] by sfalken
  • 2 copies in branches/Safari-522

Add files missed by svn merge.

Mar 27, 2007:

11:19 PM Changeset in webkit [20548] by sfalken
  • 7 edits
    1 add in branches/Safari-522

Merge fix from r20476.

11:10 PM Changeset in webkit [20547] by sfalken
  • 30 edits
    1 delete in branches/Safari-522

Merge fix from r20475.

10:05 PM Changeset in webkit [20546] by darin
  • 2 edits in trunk/LayoutTests
  • svg/hixie/text/003-expected.txt: Updated results for this one test that now has different results due to the painting Adele added to DumpRenderTree. Long term, we just have to fix SVG so that painting doesn't cause changes to the render tree!
9:22 PM Changeset in webkit [20545] by oliver
  • 3 edits
    4 adds in trunk

2007-03-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Don't enforce text-selection drag delay when we are
going to drag an image anyway.

Fixes rdar://problem/4668935

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):

Layout tests:

Test to ensure there is no delay forced when dragging a selected image

  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
4:38 PM Changeset in webkit [20544] by andersca
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): Call JSObject:call for native JavaScript objects.

LayoutTests:

Reviewed by Geoff.

Add NPN_InvokeDefault test.


  • plugins/netscape-invoke-default-expected.txt: Added.
  • plugins/netscape-invoke-default.html: Added.

WebKitTools:

Reviewed by Geoff.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Add new function which takes a function and calls it using NPN_InvokeDefault.
4:29 PM Changeset in webkit [20543] by justing
  • 2 edits in trunk/WebCore

Build fix


  • editing/markup.cpp: (WebCore::startMarkup):
3:55 PM Changeset in webkit [20542] by justing
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

Demonstrates the bug fixed:

  • editing/style/5091898-expected.checksum: Added.
  • editing/style/5091898-expected.png: Added.
  • editing/style/5091898-expected.txt: Added.
  • editing/style/5091898.html: Added. Demonstrates a related bug fixed (deleting the line break before a paragraph could remove its underlining):
  • editing/deleting/5091898-expected.checksum: Added.
  • editing/deleting/5091898-expected.png: Added.
  • editing/deleting/5091898-expected.txt: Added.
  • editing/deleting/5091898.html: Added. Demonstrates that a link now (correctly) exists, instead of just underlined text:
  • editing/pasteboard/4840662-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family


createMarkup skipped elements if they were blocks
when called from moveParagraphs (because that function
must receive only inline content). This patch adds
code to inline these blocks instead of skipping them
so that we don't lose any of the style that they
contribute to the copied markup.

  • editing/markup.cpp: (WebCore::startMarkup): Add an inlineBlocks option. Make sure to overwrite display:block coming from a style sheet or the inline style declaration. (WebCore::createMarkup): Don't refuse to include a specialCommonAncestor that's a block if we were asked to include only inline content, since we can now inline block elements in startMarkup.
3:53 PM Changeset in webkit [20541] by adele
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

Oops- my comment was missing a word.

3:50 PM Changeset in webkit [20540] by adele
  • 2 edits in trunk/WebKitTools

Adding comment.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
3:41 PM Changeset in webkit [20539] by adele
  • 2 edits in trunk/WebKitTools

Fix svg tests by calling displayIfNeeded.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
3:13 PM Changeset in webkit [20538] by zbujtas
  • 12 edits in S60/trunk

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Rich File Upload implementation
​http://bugs.webkit.org/show_bug.cgi?id=13195

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreFormControls.h:
  • khtml/html/html_formimpl.cpp: (DOM::):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
  • kwq/KWQFileButton.cpp: (KWQFileButton::setAccept):
  • kwq/KWQFileButton.h:
3:10 PM Changeset in webkit [20537] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim


  • fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]
2:59 PM Changeset in webkit [20536] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge fix from r20456 and r20457.

2:58 PM Changeset in webkit [20535] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery

This disables the paint that occurs after WebCore finishes loading the document. We should reenable this when we
move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call. See <rdar://problem/5092361>.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
2:56 PM Changeset in webkit [20534] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20441.

2:52 PM Changeset in webkit [20533] by thatcher
  • 4 edits in branches/Safari-522/WebCore

Merge fix from r20425.

2:22 PM Changeset in webkit [20532] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20474.

2:18 PM Changeset in webkit [20531] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20473.

2:16 PM Changeset in webkit [20530] by thatcher
  • 5 edits in branches/Safari-522/WebKit

Merge fix from r20471.

2:14 PM Changeset in webkit [20529] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20461.

2:12 PM Changeset in webkit [20528] by thatcher
  • 3 edits in branches/Safari-522/WebKit

Merge build fix from r20427.

1:47 PM Changeset in webkit [20527] by thatcher
  • 4 edits in branches/Safari-522/WebCore

Merge fix from r20460.

1:45 PM Changeset in webkit [20526] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge fix from r20458.

1:43 PM Changeset in webkit [20525] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20454.

1:41 PM Changeset in webkit [20524] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20453.

1:39 PM Changeset in webkit [20523] by thatcher
  • 7 edits
    8 copies in branches/Safari-522

Merge fix from r20449.

1:35 PM Changeset in webkit [20522] by thatcher
  • 5 edits
    2 copies in branches/Safari-522

Merge fix from r20440.

1:29 PM Changeset in webkit [20521] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20419.

1:21 PM Changeset in webkit [23202] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix for 5090964, arabic text piled on top of itself.

1:09 PM Changeset in webkit [20520] by justing
  • 3 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • editing/pasteboard/5065605-expected.checksum: Added.
  • editing/pasteboard/5065605-expected.png: Added.
  • editing/pasteboard/5065605-expected.txt: Added.
  • editing/pasteboard/5065605.html: Added.
  • editing/style/4916887-expected.checksum: Added.
  • editing/style/4916887-expected.png: Added.
  • editing/style/4916887-expected.txt: Added.
  • editing/style/4916887.html: Added.
  • editing/style/5065910-expected.checksum: Added.
  • editing/style/5065910-expected.png: Added.
  • editing/style/5065910-expected.txt: Added.
  • editing/style/5065910.html: Added.
  • editing/style/5084241-expected.checksum: Added.
  • editing/style/5084241-expected.png: Added.
  • editing/style/5084241-expected.txt: Added.
  • editing/style/5084241.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): If a node's text fill color is invalid, then its children use their font-color as their text fill color (they don't inherit it). Likewise for stroke color.
1:07 PM Changeset in webkit [23201] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Fixed <rdar://problem/5085076> WebView stops painting after
loading stand-alone netflix movie preview in WMP format


The stand-alone WMP plug-in seems to do all its drawing in
the WM_ERASEBKGN phase, not the WM_PAINT phase, so our
InvalidateRect call for plug-in windows needs to specify
'true' for whether the background region should be erased.


A smart plug-in that wants to avoid background draws can
still do so by just returning 1 in response to WM_ERASEBKGN,
or by setting its background brush to NULL.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):
12:58 PM Changeset in webkit [20519] by yongjzha
  • 2 edits in S60/trunk/WebKit

yaharon, reviewed by <reviewer>

DESC: [S60] S60 3.2 Touch Help: Application crash when tapping scroll bar of XHTML topic
​http://bugs.webkit.org/show_bug.cgi?id=13196

  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::HandleScrollEventL):
11:06 AM Changeset in webkit [23200] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

<rdar://problem/5091459>
Crash when destroying "null plugin"


<rdar://problem/5056845>
Invoking itunes page has missing plugin icon on it


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paintMissingPluginIcon): Clip before painting.


(WebCore::freeStringArray):
Add null-check.


(WebCore::PluginViewWin::PluginViewWin):
Initialize plugin names and values.

9:40 AM Changeset in webkit [20518] by andersca
  • 2 edits in trunk/WebCore
  • platform/ScrollBar.h: Use wtf/MathExtras.h instead of math.h
6:02 AM Changeset in webkit [20517] by bdash
  • 1 edit in tags/Safari-4522.5.3/WebKit/Configurations/Version.xcconfig

Versioning.

6:02 AM Changeset in webkit [20516] by bdash
  • 2 edits in tags/Safari-4522.5.3/WebKit

Merge in r20513.

5:58 AM Changeset in webkit [20515] by bdash
  • 1 copy in tags/Safari-4522.5.3/WebKit

New tag (part 2).

5:57 AM Changeset in webkit [20514] by bdash
  • 1 add in tags/Safari-4522.5.3

New tag (part 1).

5:49 AM Changeset in webkit [20513] by bdash
  • 2 edits in trunk/WebKit

2007-03-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Harrison.

  • Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.
4:08 AM Changeset in webkit [20512] by zack
  • 2 edits in trunk/WebCore

Fix the build

3:02 AM Changeset in webkit [20511] by oliver
  • 2 edits
    1 add in trunk/WebCore

2007-03-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

The WebArchiver needs all the subresources of a document to be accessible
through the DocLoader, so we can't remove a CachedResource simultaneously
from the global Cache and all DocLoaders, just because it needs to be
reloaded in one.

Fixes rdar://problem/5044366

  • loader/Cache.cpp: (WebCore::Cache::remove):

Don't evict the resource from all DocLoaders

  • manual-tests/test-iframes-loading-the-same-resource.html: Added.

Alas it wasn't possible to make a nice layout test, even this manual test
is not entirely deterministic

2:14 AM Changeset in webkit [20510] by bdash
  • 2 edits in trunk/WebCore

2007-03-27 Mark Rowe <​mrowe@apple.com>

Build fix.

  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear):
2:04 AM Changeset in webkit [20509] by zack
  • 3 edits in trunk/WebKitQt

Fix the rendering crashes due to triggered
asserts and improve a bit the layout scheduling in the
Qt port

1:59 AM Changeset in webkit [23199] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Add support for glyph offsets to the GlyphBuffer.

1:52 AM Changeset in webkit [20508] by hyatt
  • 3 edits in trunk/WebCore

Add support for glyph offsets to the GlyphBuffer.

1:32 AM Changeset in webkit [20507] by antti
  • 2 edits in trunk/WebCore

Keep buildbot happy.

  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::scrollbarHit):
1:10 AM Changeset in webkit [23198] by antti
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Darin.


Initialize new m_isContinuous field in WheelEvent

  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1:03 AM Changeset in webkit [20506] by antti
  • 18 edits in trunk

WebCore:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
​http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCore.exp:

Export _wkGetWheelEventDeltas

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):

Remove (0, 0) scroll event hack, it is not needed anymore.
Do per-pixel scrolling for fine grained events.

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::isContinuous):

Add new m_isContinuous boolean to indicate fine grained wheel events.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
  • platform/ScrollBar.h: (WebCore::Scrollbar::value):

Use float to represent current position to support finer grained scrolling.
Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)

  • platform/ScrollTypes.h: (WebCore::):
  • platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add wkGetWheelEventDeltas for getting fine grained wheel events

  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Get the wheel deltas using new wkGetWheelEventDeltas interface

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight):

Pass item height to scrollbar

WebKit:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
​http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Expose GetWheelEventDeltas()

WebKitLibraries:

Reviewed by Darin.


Added wkGetWheelEventDeltas

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
12:02 AM Changeset in webkit [23197] by hyatt
  • 6 edits in branches/WindowsMerge

Enable complex text.

Note: See TracTimeline for information about the timeline view.