Context Navigation

← Previous Period
Next Period →

Timeline

Mar 29, 2007:

8:17 PM Changeset in webkit [20608] by ggaren

1 edit
2 adds in trunk/LayoutTests

Layout test for <rdar://problem/5061807>. (This one's for you, Boyscout!)

fast/frames/remove-frame-with-scrollbars-crash-expected.txt: Added.
fast/frames/remove-frame-with-scrollbars-crash.html: Added.

7:36 PM Changeset in webkit [20607] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13166 REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table

fast/tokenizer/write-partial-entity-expected.txt: Added.
fast/tokenizer/write-partial-entity.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13166 REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table

Test: fast/tokenizer/write-partial-entity.html

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position after script execution which can write to the buffer.

5:11 PM Changeset in webkit [20606] by justing

3 edits
8 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position

Tests for the bug:

editing/deleting/5099303-expected.checksum: Added.
editing/deleting/5099303-expected.png: Added.
editing/deleting/5099303-expected.txt: Added.
editing/deleting/5099303.html: Added. Tests that extending an editable selection skips non-editable content:
editing/selection/5099303-expected.checksum: Added.
editing/selection/5099303-expected.png: Added.
editing/selection/5099303-expected.txt: Added.
editing/selection/5099303.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position

We were failing to create the correct selection
for DeleteSelectionCommand because the selection extension
operations don't skip over non-editable content for editable
selections.

editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): When extending an editable selection, don't extend into non-editable content. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.

5:04 PM Changeset in webkit [20605] by thatcher

1 edit in tags/Safari-5522.5/WebKit/Configurations/Version.xcconfig

Versioning.

5:04 PM Changeset in webkit [20604] by thatcher

1 edit in tags/Safari-5522.5/WebCore/Configurations/Version.xcconfig

Versioning.

5:03 PM Changeset in webkit [20603] by thatcher

1 edit in tags/Safari-5522.5/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

5:03 PM Changeset in webkit [20602] by thatcher

1 edit in tags/Safari-5522.5/JavaScriptCore/Configurations/Version.xcconfig

Versioning.

4:58 PM Changeset in webkit [20601] by thatcher

2 edits in tags/Safari-5522.5/WebKit

Merge fix from r20516.

4:50 PM Changeset in webkit [20600] by thatcher

10 edits in tags/Safari-5522.5/WebCore

Merge fix from r20565.

4:49 PM Changeset in webkit [20599] by thatcher

3 edits in tags/Safari-5522.5/WebCore

Merge fix from r20542.

4:47 PM Changeset in webkit [20598] by thatcher

2 edits in tags/Safari-5522.5/WebCore

Merge fix from r20520.

4:26 PM Changeset in webkit [20597] by ggaren

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)

plugins/destroy-stream-twice-expected.txt: Added.
plugins/destroy-stream-twice.html: Added.

WebKit:

Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.

Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)

Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
every time you run it.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]):

WebKitTools:

Reviewed by Beth Dakin.

Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)

Added hasStream property and destroyStream function, used by layout test.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): (pluginInvoke): (pluginAllocate):
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_NewStream):

4:24 PM Changeset in webkit [20596] by bdakin

3 edits in trunk/WebKitLibraries

Rubber-stamped by Adam.

Keep OpenSource building.

WebKitSystemInterface.h:
libWebKitSystemInterface.a:

4:24 PM Changeset in webkit [20595] by pyeh

2 edits in trunk/WebCore

<rdar://problem/4918397> Exception raise inspecting note contents in the background

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject subrole]): (-[WebCoreAXObject title]): Check that attachment supports the attribute before requesting it.

4:16 PM Changeset in webkit [20594] by justing

1 add in trunk/LayoutTests/editing/deleting/5032066-expected.txt

I forgot add this expected result in my previous checkin.

4:13 PM Changeset in webkit [20593] by bdakin

4 edits in trunk/WebKit

Reviewed by Brady.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

-and-

<rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround
methodology

The fix for the first bug is to compare against the bundle
identifiers for Adobe Reader and the non-Pro Adobe Acrobat in
addition to Adobe Acrobat Pro. The fix for the second bug is to
check the version number of Acrobat/Reader through
WebKitSystemInterface instead of checking which version of WebKit
it has been linked against.

English.lproj/StringsNotToBeLocalized.txt: Two new bundle identifiers.
Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

4:01 PM Changeset in webkit [20592] by thatcher

1 copy in tags/Safari-5522.5

New tag based on r20497.

3:34 PM Changeset in webkit [20591] by justing

126 edits
3 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/5032066> <Delete> should work between To Dos

Demonstrates the fix:

editing/deleting/5032066-expected.checksum: Added.
editing/deleting/5032066-expected.png: Added.
editing/deleting/5032066-expected.txt: Added.
editing/deleting/5032066.html: Added.

Fixed:

editing/deleting/delete-block-table-expected.checksum:
editing/deleting/delete-block-table-expected.png:
editing/deleting/delete-block-table-expected.txt:

shouldInsertNode:... now being called during moves:

editing/deleting/delete-3857753-fix-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
editing/deleting/delete-block-merge-contents-001-expected.txt:
editing/deleting/delete-block-merge-contents-002-expected.txt:
editing/deleting/delete-block-merge-contents-003-expected.txt:
editing/deleting/delete-block-merge-contents-004-expected.txt:
editing/deleting/delete-block-merge-contents-005-expected.txt:
editing/deleting/delete-block-merge-contents-006-expected.txt:
editing/deleting/delete-block-merge-contents-007-expected.txt:
editing/deleting/delete-block-merge-contents-008-expected.txt:
editing/deleting/delete-block-merge-contents-009-expected.txt:
editing/deleting/delete-block-merge-contents-010-expected.txt:
editing/deleting/delete-block-merge-contents-012-expected.txt:
editing/deleting/delete-block-merge-contents-013-expected.txt:
editing/deleting/delete-block-merge-contents-014-expected.txt:
editing/deleting/delete-block-merge-contents-015-expected.txt:
editing/deleting/delete-block-merge-contents-016-expected.txt:
editing/deleting/delete-block-merge-contents-017-expected.txt:
editing/deleting/delete-block-merge-contents-018-expected.txt:
editing/deleting/delete-block-merge-contents-019-expected.txt:
editing/deleting/delete-block-merge-contents-020-expected.txt:
editing/deleting/delete-block-merge-contents-021-expected.txt:
editing/deleting/delete-block-merge-contents-022-expected.txt:
editing/deleting/delete-br-010-expected.txt:
editing/deleting/delete-line-002-expected.txt:
editing/deleting/delete-line-004-expected.txt:
editing/deleting/delete-line-006-expected.txt:
editing/deleting/delete-line-007-expected.txt:
editing/deleting/delete-line-008-expected.txt:
editing/deleting/delete-line-011-expected.txt:
editing/deleting/delete-line-012-expected.txt:
editing/deleting/delete-listitem-001-expected.txt:
editing/deleting/delete-to-end-of-paragraph-expected.txt:
editing/deleting/merge-different-styles-expected.txt:
editing/deleting/merge-no-br-expected.txt:
editing/deleting/pruning-after-merge-1-expected.txt:
editing/deleting/pruning-after-merge-2-expected.txt:
editing/execCommand/create-list-from-range-selection-expected.txt:
editing/execCommand/create-list-with-hr-expected.txt:
editing/execCommand/format-block-expected.txt:
editing/execCommand/format-block-from-range-selection-expected.txt:
editing/execCommand/format-block-with-braces-expected.txt:
editing/execCommand/format-block-with-trailing-br-expected.txt:
editing/execCommand/indent-list-item-expected.txt:
editing/execCommand/indent-selection-expected.txt:
editing/execCommand/insert-list-and-stitch-expected.txt:
editing/execCommand/insert-list-with-id-expected.txt:
editing/execCommand/nsresponder-indent-expected.txt:
editing/execCommand/outdent-selection-expected.txt:
editing/execCommand/queryCommandState-01-expected.txt:
editing/execCommand/remove-list-1-expected.txt:
editing/execCommand/remove-list-from-range-selection-expected.txt:
editing/execCommand/remove-list-item-1-expected.txt:
editing/execCommand/remove-list-items-expected.txt:
editing/execCommand/switch-list-type-expected.txt:
editing/inserting/insert-3907422-fix-expected.txt:
editing/inserting/insert-div-026-expected.txt:
editing/inserting/multiple-lines-selected-expected.txt:
editing/inserting/return-key-with-selection-001-expected.txt:
editing/inserting/return-key-with-selection-002-expected.txt:
editing/pasteboard/4076267-2-expected.txt:
editing/pasteboard/4700297-expected.txt:
editing/pasteboard/8145-3-expected.txt:
editing/pasteboard/display-block-on-spans-expected.txt:
editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
editing/pasteboard/interchange-newline-1-expected.txt:
editing/pasteboard/interchange-newline-2-expected.txt:
editing/pasteboard/merge-after-delete-1-expected.txt:
editing/pasteboard/merge-after-delete-2-expected.txt:
editing/pasteboard/merge-after-delete-expected.txt:
editing/pasteboard/merge-end-1-expected.txt:
editing/pasteboard/merge-end-2-expected.txt:
editing/pasteboard/merge-end-3-expected.txt:
editing/pasteboard/merge-end-4-expected.txt:
editing/pasteboard/merge-end-5-expected.txt:
editing/pasteboard/merge-end-blockquote-expected.txt:
editing/pasteboard/merge-end-borders-expected.txt:
editing/pasteboard/merge-end-list-expected.txt:
editing/pasteboard/merge-end-table-expected.txt:
editing/pasteboard/paste-line-endings-007-expected.txt:
editing/pasteboard/paste-line-endings-008-expected.txt:
editing/pasteboard/paste-line-endings-009-expected.txt:
editing/pasteboard/paste-match-style-001-expected.txt:
editing/pasteboard/paste-text-002-expected.txt:
editing/pasteboard/paste-text-003-expected.txt:
editing/pasteboard/paste-text-004-expected.txt:
editing/pasteboard/paste-text-005-expected.txt:
editing/pasteboard/paste-text-006-expected.txt:
editing/pasteboard/paste-text-008-expected.txt:
editing/pasteboard/paste-text-009-expected.txt:
editing/pasteboard/paste-text-010-expected.txt:
editing/pasteboard/smart-paste-001-expected.txt:
editing/pasteboard/smart-paste-002-expected.txt:
editing/pasteboard/smart-paste-003-expected.txt:
editing/pasteboard/smart-paste-004-expected.txt:
editing/pasteboard/smart-paste-005-expected.txt:
editing/pasteboard/smart-paste-006-expected.txt:
editing/pasteboard/smart-paste-007-expected.txt:
editing/pasteboard/smart-paste-008-expected.txt:
editing/style/create-block-for-style-001-expected.txt:
editing/style/create-block-for-style-002-expected.txt:
editing/style/create-block-for-style-003-expected.txt:
editing/style/create-block-for-style-004-expected.txt:
editing/style/create-block-for-style-007-expected.txt:
editing/style/create-block-for-style-009-expected.txt:
editing/style/create-block-for-style-010-expected.txt:
editing/style/create-block-for-style-011-expected.txt:
editing/style/create-block-for-style-012-expected.txt:
editing/style/create-block-for-style-013-expected.txt:
editing/style/smoosh-styles-001-expected.txt:
editing/style/smoosh-styles-002-expected.txt:
editing/style/style-boundary-005-expected.txt:
editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/5032066> Delete should work between ToDos

Stop selecting the table when the user attempts to delete
the line break just after it, instead, extend the selection
into the last table cell.
Let deletion merge content into table cells (as long as
its not from another table cell).
Start calling shouldInsertNode:replacingDOMRange:givenAction:
when moving content with moveParagraphs, so that Mail can
modify content before it is moved into a ToDo during a delete.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ask the delegate before performing the move. This will let Mail prevent styles from entering a ToDo. Added a FIXME about adding a new WebViewInsertAction
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Allow merging into table cells from content not in a table.
editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): Don't select the table when extending by character/word from just before it. This code was here to make it easier to select tables in order to delete them, but the deletion UI makes it largely unnecessary. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
editing/TypingCommand.cpp: (WebCore::isFirstPositionAfterTable): Added. (WebCore::isLastPositionBeforeTable): Ditto. (WebCore::TypingCommand::deleteKeyPressed): When pressing the delete key with a caret at the beginning of a paragraph just after a table, move the paragraph into the last table cell. Do not do this if it would mean moving a block table. Removed some old irrelevant comments.
editing/htmlediting.cpp: Removed unused functions.
editing/htmlediting.h:

3:14 PM Changeset in webkit [20590] by thatcher

1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Build fix for Leopard.

1:39 PM Changeset in webkit [20589] by yongjzha

2 edits in S60/trunk/WebKit

vbradley, reviewed by yongjun

DESC: Fix cursor when browser is brought back from background and a

plugin has focus.

http://bugs.webkit.org/show_bug.cgi?id=13225

Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):

1:37 PM Changeset in webkit [20588] by yongjzha

2 edits in S60/branches/3.1m/WebKit

2007-03-29 vbradley <vincent.bradley@nokia.com>

Reviewed by Yongjan.
DESC: Fix cursor when browser is brought back from background and a plugin has focus.
http://bugs.webkit.org/show_bug.cgi?id=13225

Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):

1:36 PM Changeset in webkit [20587] by yongjzha

4 edits in S60/trunk/WebCore

yongjzha <yongjun.zhang@nokia.com>

Reviewed by Zalan <zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

http://bugs.webkit.org/show_bug.cgi?id=13219

khtml/html/htmltokenizer.cpp: (khtml::):
khtml/html/htmltokenizer.h:
khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):

1:18 PM Changeset in webkit [20586] by yongjzha

2 edits in S60/trunk/WebCore

2007-03-28 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
http://bugs.webkit.org/show_bug.cgi?id=13217

khtml/rendering/render_table.h:

1:11 PM Changeset in webkit [20585] by yongjzha

2 edits in S60/branches/3.1m/WebKit

2007-03-27 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun.
DESC: Regression due to patch r20436
TSW Id: TKWG-6Z477F-Browser auto exit when browsing web Page
http://bugs.webkit.org/show_bug.cgi?id=13207

ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::ResponseCompleteL):

1:03 PM Changeset in webkit [20584] by yongjzha

2 edits in S60/trunk/WebKit

Steve, reviewed by Yongjun Zhang

DESC:
http://bugs.webkit.org/show_bug.cgi?id=13296

BrowserControl/src/BrCtl.cpp: (CBrCtl::SizeChanged):

1:01 PM Changeset in webkit [20583] by yongjzha

4 edits in S60/trunk/WebKit

hongzhao, reviewed by yongjun.zhang@nokia.com.

DESC: [S60] Browser doesn't support for DRM image content in 3.2.
Fix: Add function to handle DRM image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13220

BrowserCore/Renderers/inc/StaticImageDecoder.h:
BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
group/webkit.mmp:

12:13 PM Changeset in webkit [20582] by bdash

1 edit in tags/WebCore-5522.4.2/WebCore/Info.plist

Versioning.

12:12 PM Changeset in webkit [20581] by bdash

10 edits in tags/WebCore-5522.4.2/WebCore

Merge in r20565.

12:10 PM Changeset in webkit [20580] by bdash

1 copy in tags/WebCore-5522.4.2

New tag.

12:00 PM Changeset in webkit [20579] by staikos

1 edit in trunk/WebCore/platform/qt/FontQt.cpp

Add a comment since our current fix is not really acceptable.

11:44 AM Changeset in webkit [20578] by staikos

2 edits in trunk/WebCore

Remove redundant line.

11:18 AM Changeset in webkit [20577] by yongjzha

2 edits in S60/branches/3.1m/WebCore

2007-03-28 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
http://bugs.webkit.org/show_bug.cgi?id=13217

khtml/rendering/render_table.h:

11:05 AM BuildingOnWindows edited by tommy@ech-wel.nl

(diff)

10:34 AM Changeset in webkit [20576] by yongjzha

4 edits in S60/branches/3.1m/WebKit

2007-03-29 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by yongjun.zhang@nokia.com.
DESC: [S60] Browser doesn't support for DRM image content.
Fix: Make some changes based on Yongjun's comments for the previous 3.1m patch.
http://bugs.webkit.org/show_bug.cgi?id=13220

BrowserCore/Renderers/inc/StaticImageDecoder.h:
BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
group/webkit.mmp:

10:07 AM Changeset in webkit [20575] by staikos

2 edits in trunk

correct the changelog entry for the patch author.

10:05 AM Changeset in webkit [20574] by staikos

2 edits in trunk/WebCore

Take into account the entire run length to get a proper selection.
Doesn't seem to affect the Mac build but is a problem for Qt.

10:01 AM Changeset in webkit [20573] by ggaren

2 edits
1 move in trunk/WebKit

Rubber stamped by Beth Dakin.

WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
it's ObjC++ now.

Plugins/WebBaseNetscapePluginStream.m: Removed.
WebKit.xcodeproj/project.pbxproj:

9:59 AM Changeset in webkit [20572] by darin

4 edits
2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4545060>, technorati and arstechnica fail
because of getComputedStyle not reporting display:none.
http://bugs.webkit.org/show_bug.cgi?id=13103

fast/css/computed-style-display-none.html: Added.
fast/css/computed-style-display-none-expected.txt: Added.

fast/css/computed-style-negative-top.html: Updated to work with Gecko.
fast/css/computed-style-negative-top-expected.txt: Newline change needed because of change above.

fast/css/computed-style.html: Updated to work with Gecko.

8:18 AM Changeset in webkit [20571] by ggaren

5 edits in trunk/WebKit

Reluctantly tolerated by Darin Adler.

Fixed <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)

The problem was that the DivX plug-in would ask us to destroy an NPStream
that had already been destroyed, causing us to wander off into freed
memory. (I believe the reason this was a regression was that we never used
to destroy plug-in streams, period.)

The solution here is to track the NPStreams belonging to a plug-in, and
guard against plug-ins making calls with NPStreams that don't belong to
them. (It turns out that NPN_DestroyStream is the only stream-based
plug-in call we support.)

(CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix. Use helper method to guard against a plug-in using an NPStream that doesn't belong to it.
WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++ so I could use HashMap.

1:41 AM Changeset in webkit [20570] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
reporting display:none properly when it is set. This is bugzilla bug 13103.

Reviewed by mitz

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

12:49 AM Changeset in webkit [23204] by hyatt

2 edits in branches/WindowsMerge/WebCore

Enable CG's local font cache.

Mar 28, 2007:

11:20 PM Changeset in webkit [20569] by dsmith

13 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

holes in arrays should be skipped, not treated as undefined, by all such methods
an element with value undefined is not a hole
Array.prototype.forEach should return undefined

kjs/array_object.cpp: (ArrayInstance::getOwnPropertySlot): (ArrayProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

holes in arrays should be skipped, not treated as undefined, by all such methods
an element with value undefined is not a hole
Array.prototype.forEach should return undefined

fast/js/array-every-expected.txt:
fast/js/array-filter-expected.txt: Added.
fast/js/array-filter.html: Added.
fast/js/array-foreach-expected.txt:
fast/js/array-foreach.html:
fast/js/array-indexof-expected.txt:
fast/js/array-indexof.html:
fast/js/array-lastIndexOf-expected.txt:
fast/js/array-map-expected.txt: Added.
fast/js/array-map.html: Added.
fast/js/array-some-expected.txt:
fast/js/array-some.html:
fast/js/resources/array-every.js:
fast/js/resources/array-lastIndexOf.js:

11:15 PM Changeset in webkit [20568] by oliver

5 edits in trunk/WebCore

2007-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Hyatt.

Rename DocLoader::setPasteInProgress, etc to more generic
setAllowStaleResources, etc

editing/Editor.cpp: (WebCore::Editor::paste):
loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::checkForReload):
loader/DocLoader.h: (WebCore::DocLoader::setAllowStaleResources):
page/DragController.cpp: (WebCore::DragController::concludeDrag):

9:59 PM Changeset in webkit [20567] by oliver

19 edits in trunk/WebCore

2007-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Anders and Steve.

Add a flag to DocLoader to prevent it from reloading
when performing a paste or drop operation.

Remove m_cachePolicy from CachedResource as it is never used

Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures
dragging image into GMail message in _web_writeImage and
documentFragmentFromDragData

editing/Editor.cpp: (WebCore::Editor::paste): prevent the docloader from reloading resources on paste
html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
loader/Cache.cpp: (WebCore::createResource):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
loader/CachedCSSStyleSheet.h:
loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
loader/CachedImage.h:
loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
loader/CachedResource.h:
loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader):

Tidy up constructor initialise new field

(WebCore::DocLoader::checkForReload):

Prevent reload when pasting

loader/DocLoader.h: (WebCore::DocLoader::setPasteInProgress): new field and setter
page/DragController.cpp: (WebCore::DragController::concludeDrag): prevent the docloader from reloading resources on drop

6:45 PM Changeset in webkit [20566] by kjk

2 edits in trunk/WebCore

Not reviewed - fix typo in gdk build.

platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::contentsToWindow):

6:18 PM Changeset in webkit [23203] by mjs

2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

updates for <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):

6:17 PM Changeset in webkit [20565] by mjs

14 edits in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

fast/overflow/scrollRevealButton-expected.checksum:
fast/overflow/scrollRevealButton-expected.png:
fast/overflow/scrollRevealButton-expected.txt:

WebCore:

Reviewed by Darin.

fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

Handle scrolling external scrollviews around the webview during
autoscroll or when scrolling into view.

This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.

page/FrameView.cpp: (WebCore::FrameView::scrollRectIntoViewRecursively):
page/FrameView.h:
platform/ScrollView.h:
platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::updateContents):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):

5:15 PM Changeset in webkit [20564] by thatcher

1 edit in tags/JavaScriptCore-5522.4.2/JavaScriptCore/Info.plist

Versioning.

5:14 PM Changeset in webkit [20563] by thatcher

2 edits in tags/JavaScriptCore-5522.4.2/JavaScriptCore

Merge a minimal version of r20351.

5:13 PM Changeset in webkit [20562] by thatcher

1 copy in tags/JavaScriptCore-5522.4.2

New tag.

4:48 PM JavaScript and DOM Benchmarks edited by mjs@apple.com

(diff)

4:45 PM Changeset in webkit [20561] by sfalken

1 copy in tags/Safari-522.5.2b

New tag.

3:18 PM Changeset in webkit [20560] by adele

3 edits in trunk/WebKit

Reviewed by Brady.

Update to last fix.

Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): Added check to only use the VitalSource workaround if the app is not linked on or after the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.

2:52 PM Changeset in webkit [20559] by darin

2 edits in trunk/WebCore

Reviewed and landed by Darin

Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
http://bugs.webkit.org/show_bug.cgi?id=13138

platform/StringImpl.cpp: (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::equalIgnoringCase):

2:28 PM Changeset in webkit [20558] by antti

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix <rdar://problem/5092653>
REGRESSION: Image decoding making scrolling slow

If decoder gave back a null frame (which I think happens regularly if you don't have full frame
data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
led to massive growth in calculated image size and eventually made cache prune constantly.

No test, I don't know how to make one for this.

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame):

2:19 PM Changeset in webkit [20557] by thatcher

2 edits in branches/Safari-522/WebKit

<rdar://problem/5093473> incomplete render of menu (assertion failing in -[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]) (13026)

Rolling out r20042, and these build fixes that followed: r20050, r20058, r20064 and r20077.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):

2:13 PM Changeset in webkit [20556] by yongjzha

4 edits in S60/branches/3.1m/WebCore

2007-03-28 yongjzha <yongjun.zhang@nokia.com>

Reviewed by Zalan <zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

http://bugs.webkit.org/show_bug.cgi?id=13219

khtml/html/htmltokenizer.cpp: (khtml::):
khtml/html/htmltokenizer.h:
khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):

1:59 PM Changeset in webkit [20555] by adele

4 edits in trunk

WebCore:

Reviewed by Kevin M.

WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Convert return value to a string. This matches the behavior in Safari 2.0.

WebKit:

Reviewed by Kevin M.

WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings. We used to allow this
but now we throw a JavaScript exception for return statements that aren't in functions.

Filed this evangelism bug so we can notify VitalSource of the problem:
<rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):

9:48 AM Changeset in webkit [20554] by ap

8 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13190
XPath incorrectly handles namespaces on attributes

WebCore:

xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but measurable performance improvement for bug 13021. (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.

xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::NodeTest): (WebCore::XPath::Step::NodeTest::namespaceURI): (WebCore::XPath::Step::nodeTest): (WebCore::XPath::Step::setNodeTest): Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).

xml/XPathGrammar.y:
xml/XPathPath.cpp: (WebCore::XPath::LocationPath::optimizeStepPair): Accounted for the above change.

LayoutTests:

fast/xpath/attr-namespace-expected.txt: Added.
fast/xpath/attr-namespace.html: Added.

fast/xpath/xpath-namespaces-expected.txt:
fast/xpath/xpath-namespaces.html: Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).

8:39 AM Changeset in webkit [20553] by sfalken