⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 30, 2007:

8:39 PM Changeset in webkit [20633] by sfalken
  • 1 copy in tags/Safari-522.5.3b

New tag.

7:41 PM Changeset in webkit [20632] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20543

7:25 PM Changeset in webkit [20631] by ddkilzer
  • 1 edit in trunk/LayoutTests/fast/js/resources/dot-node-base-exception.js

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

4:13 PM Changeset in webkit [23208] by adele
  • 4 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Beth.

Fix for <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Added hack to convert option-delete to ctrl-delete. Also fixed this to correctly convert ascii codes to virtual key codes, which removes the need for the special conversion of '\n' to VK_RETURN.

WebKitWin:

Reviewed by Beth.

Fix <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing

  • WebView.cpp: Add DeleteWordForward and DeleteWordBackward to key command table.
3:31 PM Changeset in webkit [23207] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adele.

<rdar://problem/5101970>
Crash when submitting form, running under App Verifier


  • WebActionPropertyBag.cpp: (findMouseEvent): Return the right event.
2:56 PM Changeset in webkit [20630] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20558

2:53 PM Changeset in webkit [20629] by sfalken
  • 5 edits
    8 copies in branches/Safari-522

Merge fix from r20542

2:51 PM Changeset in webkit [20628] by sfalken
  • 2 edits in branches/Safari-522/WebKit

Merge fix from r20537

2:46 PM Changeset in webkit [20627] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20535

2:43 PM Changeset in webkit [20626] by sfalken
  • 3 edits
    16 copies in branches/Safari-522

Merge fix from r20520

2:41 PM Changeset in webkit [20625] by andersca
  • 5 edits in trunk

LayoutTests:

Reviewed by Geoff.

  • plugins/destroy-stream-twice.html: Put the scripts before the embed element. Set the timeout in the onstreamload handler.

WebKitTools:

Reviewed by Geoff.

Add an "onstreamload" attribute to the plugin which is called when a stream starts loading.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): Look for the onstreamload attribute.


(NPP_Destroy):
Free the onstreamload attribute.


(NPP_NewStream):
Call the onstreamload handler.

2:40 PM Changeset in webkit [20624] by sfalken
  • 3 edits
    4 copies in branches/Safari-522

Merge fix from r20503

2:33 PM Changeset in webkit [20623] by sfalken
  • 4 edits
    3 copies in branches/Safari-522

Merge fix from r20502

1:57 PM Changeset in webkit [20622] by ap
  • 2 edits in trunk/WebCore

Debug build fix.

  • xml/XPathValue.cpp: (WebCore::XPath::): Define Value::adopt.
1:54 PM Changeset in webkit [20621] by ggaren
  • 2 edits in trunk/WebKitTools

Removing an assertion I just added because it's crashing the Leopard
buildbot. The related layout test will still report a failure, so we
don't really need this assertion.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke):
1:31 PM Changeset in webkit [20620] by ap
  • 11 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

This patch finally makes us faster than Firefox 2.0 on this test case.

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunConcat::evaluate): Use a Vector buffer for faster appending. (WebCore::XPath::FunId::evaluate): Move the result NodeSet into Value instead of copying it. (WebCore::XPath::FunLocalName::evaluate): Cosmetic changes. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunNormalizeSpace::evaluate): Ditto.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::modifiableNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xml/XPathValue.h: (WebCore::XPath::ValueData::ValueData): (WebCore::XPath::Value::Value): Made Value copying faster by putting large data members into a separate refcounted ValueData class. Added provisions for moving a NodeSet in and out of Value without copying. Made construction safer by moving bool version to a template constructor. Removed an (almost) unused default constructor.
  • xml/XPathPredicate.h: Store a Value for literal string and number expressions to avoid constructing one each time.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): (WebCore::XPath::LocationPath::evaluate): (WebCore::XPath::Path::evaluate):
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp: (WebCore::XPath::NumericOp::evaluate): (WebCore::XPath::Union::evaluate):
  • xml/XPathResult.cpp: (WebCore::XPathResult::snapshotItem):
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis):
  • xml/XPathStep.h: Got rid of unnecessary NodeSet copying in many cases.
1:13 PM Changeset in webkit [20619] by andersca
  • 3 edits in trunk/WebKitTools

Reviewed by Geoff.

  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: (testAllocate): (testEnumerate): Add casts.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Don't use #import, use #include.
1:12 PM Changeset in webkit [23206] by andersca
  • 12 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::addExtraPluginPath):
  • plugins/win/PluginDatabaseWin.h: New function for adding an extra plugin path, to be used by DRT.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Set the current directory tho the plugin directory while loading the plugin. Add new NPN callbacks.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::invalidateRegion): (WebCore::PluginViewWin::forceRedraw): Don't do anything if the plugin is windowed.


  • plugins/win/npapi.cpp: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Add stubs.


  • plugins/win/npfunctions.h: Add new methods and merge some fixes from the open source version.

WebKitWin:

Reviewed by Geoff.

  • Interfaces/IWebViewPrivate.idl: Add addAdditionalPluginPath method.


  • WebKit.vcproj/WebKit.vcproj: Copy NP includes so they can be included by the test plugin.


  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): Hold JSLock while we call JSValue::getString().


(WebView::addAdditionalPluginPath):

  • WebView.h: Implement addAdditionalPluginPath.
12:59 PM Changeset in webkit [20618] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed by Alexey.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Free the identifier string.
12:50 PM Changeset in webkit [20617] by justing
  • 4 edits
    9 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5076323> Only one To Do can be created by a selection in a message

  • editing/selection/5076323-1-expected.checksum: Added.
  • editing/selection/5076323-1-expected.txt: Added.
  • editing/selection/5076323-1.html: Added.
  • editing/selection/5076323-2-expected.checksum: Added.
  • editing/selection/5076323-2-expected.txt: Added.
  • editing/selection/5076323-2.html: Added.
  • editing/selection/5076323-3-expected.checksum: Added.
  • editing/selection/5076323-3-expected.txt: Added.
  • editing/selection/5076323-3.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5076323> Only one To Do can be created by a selection in a message

When Mail's ToDoify operation called moveToEndOfDocument:
with a selection that started just before a ToDo, we'd
move them to the end of the document, not to the end
of the editable root, because we incorrectly checked
for the editability of positions before ToDos. Then Mail
would refuse to create a ToDo because the selection was
outside of the region where they allowed editing.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): Check the position for editability, not the position's node, since there are editable positions of the form [node, offset] where node is contenteditable=false. Re-use pos. Nothing that happens after it's created can invalidate it or the position and affinity used to create it. (WebCore::SelectionController::modifyMovingRightForward): Ditto. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto. (WebCore::SelectionController::modifyMovingLeftBackward): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Ditto.
11:24 AM Changeset in webkit [20616] by beidson
  • 3 edits in trunk/LayoutTests

Reviewed by Brian Dash

Fixes an intermittent failure in the port blocking layout test where
some sort of indeterminacy would change the error code the networking
layer reported.

  • security/block-test-expected.txt:
  • security/block-test.html: Use 255.255.255.255 instead of a bogus domain name
11:13 AM Changeset in webkit [20615] by adele
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

Added DeleteWordBackward and DeleteWordForward to execCommand.

  • editing/Editor.cpp: (WebCore::execDeleteWordBackward): (WebCore::execDeleteWordForward): (WebCore::CommandEntry::):

WebKit:

Reviewed by Darin.

Call execCommand for deleteWordForward and deleteWordBackward instead of calling
deleteWithDirection directly.

  • WebView/WebHTMLView.mm: (-[WebHTMLView deleteWordForward:]): (-[WebHTMLView deleteWordBackward:]):
11:10 AM Changeset in webkit [20614] by andersca
  • 2 edits in trunk/JavaScriptCore

Build fix.


  • bindings/NP_jsobject.cpp: (_NPN_Enumerate):
10:45 AM Changeset in webkit [23205] by andersca
  • 1 edit
    2 adds in branches/WindowsMerge/WebKitTools

Reviewed by Geoff.

10:29 AM Changeset in webkit [20613] by andersca
  • 20 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Implement _NPN_Enumerate support.


  • JavaScriptCore.exp:
  • bindings/NP_jsobject.cpp: (_NPN_Enumerate):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::getPropertyNames):
  • bindings/c/c_instance.h:
  • bindings/npapi.h:
  • bindings/npruntime.h:
  • bindings/npruntime_impl.h:
  • bindings/runtime.h: (KJS::Bindings::Instance::getPropertyNames):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::getPropertyNames):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

LayoutTests:

Reviewed by Geoff.

Add enumeration test.


  • plugins/netscape-enumerate-expected.txt: Added.
  • plugins/netscape-enumerate.html: Added.

WebKit:

Reviewed by Geoff.

  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Initialize pushpopupsenabledstate, poppopupsenabledstate and enumerate.


  • Plugins/npapi.m: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Add stubs for these functions.


  • Plugins/npfunctions.h: Add new methods to NPNetscapeFuncs.

WebKitTools:

Reviewed by Geoff.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add TestObject.c and TestObject.h


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): Implement the testObject property.


(pluginInvoke):
Implement testEnumerate which takes an object and an array and enumerates
the properties of the object and adds them to the array.


(pluginAllocate):
Allocate the test object.


(pluginDeallocate):
Free the test object.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Added.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Added. Add a test object with two enumerable properties.
8:33 AM Changeset in webkit [20612] by hausmann
  • 2 edits in trunk/WebCore

Fix Qt release builds

5:55 AM Changeset in webkit [20611] by antti
  • 2 edits in trunk/WebCore

Reviewed by bdash.

Spotted an int that should be float in previous patch.

  • platform/Font.cpp: (WebCore::WidthIterator::advance):
2:59 AM Changeset in webkit [20610] by antti
  • 12 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 1


  • Eliminate caching of monospace char width from RenderText. This optimization is not needed anymore since Font already caches space width (RenderText -4 bytes)
  • Eliminate caching of tab width from RenderBlock. Similary this optimization has become obsolete (RenderBlock -4 bytes)
  • platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::Font::spaceWidth):
  • platform/Font.h: (WebCore::Font::tabWidth):
  • platform/TextStyle.h: (WebCore::TextStyle::TextStyle): (WebCore::TextStyle::allowTabs):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::setStyle):
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setStyle): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidthInternal): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::width):
  • rendering/RenderText.h: (WebCore::RenderText::allowTabs):
  • rendering/bidi.cpp:
2:51 AM Changeset in webkit [20609] by hyatt
  • 4 edits
    4 adds in trunk

Fix (take 2) for bug 4334, flickering when floating elements gain/lose transparency.

Reviewed by mitz

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):

Mar 29, 2007:

8:17 PM Changeset in webkit [20608] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/5061807>. (This one's for you, Boyscout!)

  • fast/frames/remove-frame-with-scrollbars-crash-expected.txt: Added.
  • fast/frames/remove-frame-with-scrollbars-crash.html: Added.
7:36 PM Changeset in webkit [20607] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/tokenizer/write-partial-entity-expected.txt: Added.
  • fast/tokenizer/write-partial-entity.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/tokenizer/write-partial-entity.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position after script execution which can write to the buffer.
5:11 PM Changeset in webkit [20606] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position

Tests for the bug:

  • editing/deleting/5099303-expected.checksum: Added.
  • editing/deleting/5099303-expected.png: Added.
  • editing/deleting/5099303-expected.txt: Added.
  • editing/deleting/5099303.html: Added. Tests that extending an editable selection skips non-editable content:
  • editing/selection/5099303-expected.checksum: Added.
  • editing/selection/5099303-expected.png: Added.
  • editing/selection/5099303-expected.txt: Added.
  • editing/selection/5099303.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position


We were failing to create the correct selection
for DeleteSelectionCommand because the selection extension
operations don't skip over non-editable content for editable
selections.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): When extending an editable selection, don't extend into non-editable content. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
5:04 PM Changeset in webkit [20605] by thatcher
  • 1 edit in tags/Safari-5522.5/WebKit/Configurations/Version.xcconfig

Versioning.

5:04 PM Changeset in webkit [20604] by thatcher
  • 1 edit in tags/Safari-5522.5/WebCore/Configurations/Version.xcconfig

Versioning.

5:03 PM Changeset in webkit [20603] by thatcher
  • 1 edit in tags/Safari-5522.5/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

5:03 PM Changeset in webkit [20602] by thatcher
  • 1 edit in tags/Safari-5522.5/JavaScriptCore/Configurations/Version.xcconfig

Versioning.

4:58 PM Changeset in webkit [20601] by thatcher
  • 2 edits in tags/Safari-5522.5/WebKit

Merge fix from r20516.

4:50 PM Changeset in webkit [20600] by thatcher
  • 10 edits in tags/Safari-5522.5/WebCore

Merge fix from r20565.

4:49 PM Changeset in webkit [20599] by thatcher
  • 3 edits in tags/Safari-5522.5/WebCore

Merge fix from r20542.

4:47 PM Changeset in webkit [20598] by thatcher
  • 2 edits in tags/Safari-5522.5/WebCore

Merge fix from r20520.

4:26 PM Changeset in webkit [20597] by ggaren
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)

  • plugins/destroy-stream-twice-expected.txt: Added.
  • plugins/destroy-stream-twice.html: Added.

WebKit:

Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
every time you run it.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]):

WebKitTools:

Reviewed by Beth Dakin.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


Added hasStream property and destroyStream function, used by layout test.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): (pluginInvoke): (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_NewStream):
4:24 PM Changeset in webkit [20596] by bdakin
  • 3 edits in trunk/WebKitLibraries

Rubber-stamped by Adam.

Keep OpenSource building.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:24 PM Changeset in webkit [20595] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4918397> Exception raise inspecting note contents in the background

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject subrole]): (-[WebCoreAXObject title]): Check that attachment supports the attribute before requesting it.
4:16 PM Changeset in webkit [20594] by justing
  • 1 add in trunk/LayoutTests/editing/deleting/5032066-expected.txt

I forgot add this expected result in my previous checkin.

4:13 PM Changeset in webkit [20593] by bdakin
  • 4 edits in trunk/WebKit

Reviewed by Brady.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

-and-

<rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround
methodology

The fix for the first bug is to compare against the bundle
identifiers for Adobe Reader and the non-Pro Adobe Acrobat in
addition to Adobe Acrobat Pro. The fix for the second bug is to
check the version number of Acrobat/Reader through
WebKitSystemInterface instead of checking which version of WebKit
it has been linked against.

  • English.lproj/StringsNotToBeLocalized.txt: Two new bundle identifiers.
  • Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
4:01 PM Changeset in webkit [20592] by thatcher
  • 1 copy in tags/Safari-5522.5

New tag based on r20497.

3:34 PM Changeset in webkit [20591] by justing
  • 126 edits
    3 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/5032066> <Delete> should work between To Dos

Demonstrates the fix:

  • editing/deleting/5032066-expected.checksum: Added.
  • editing/deleting/5032066-expected.png: Added.
  • editing/deleting/5032066-expected.txt: Added.
  • editing/deleting/5032066.html: Added.


Fixed:

  • editing/deleting/delete-block-table-expected.checksum:
  • editing/deleting/delete-block-table-expected.png:
  • editing/deleting/delete-block-table-expected.txt:


shouldInsertNode:... now being called during moves:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/format-block-with-trailing-br-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/insert-list-with-id-expected.txt:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/queryCommandState-01-expected.txt:
  • editing/execCommand/remove-list-1-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/multiple-lines-selected-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4700297-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/merge-after-delete-1-expected.txt:
  • editing/pasteboard/merge-after-delete-2-expected.txt:
  • editing/pasteboard/merge-after-delete-expected.txt:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-borders-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/style-boundary-005-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/5032066> Delete should work between ToDos


Stop selecting the table when the user attempts to delete
the line break just after it, instead, extend the selection
into the last table cell.
Let deletion merge content into table cells (as long as
its not from another table cell).
Start calling shouldInsertNode:replacingDOMRange:givenAction:
when moving content with moveParagraphs, so that Mail can
modify content before it is moved into a ToDo during a delete.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ask the delegate before performing the move. This will let Mail prevent styles from entering a ToDo. Added a FIXME about adding a new WebViewInsertAction
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Allow merging into table cells from content not in a table.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): Don't select the table when extending by character/word from just before it. This code was here to make it easier to select tables in order to delete them, but the deletion UI makes it largely unnecessary. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
  • editing/TypingCommand.cpp: (WebCore::isFirstPositionAfterTable): Added. (WebCore::isLastPositionBeforeTable): Ditto. (WebCore::TypingCommand::deleteKeyPressed): When pressing the delete key with a caret at the beginning of a paragraph just after a table, move the paragraph into the last table cell. Do not do this if it would mean moving a block table. Removed some old irrelevant comments.
  • editing/htmlediting.cpp: Removed unused functions.
  • editing/htmlediting.h:
3:14 PM Changeset in webkit [20590] by thatcher
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Build fix for Leopard.

1:39 PM Changeset in webkit [20589] by yongjzha
  • 2 edits in S60/trunk/WebKit

vbradley, reviewed by yongjun

DESC: Fix cursor when browser is brought back from background and a

plugin has focus.

​http://bugs.webkit.org/show_bug.cgi?id=13225

  • Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
1:37 PM Changeset in webkit [20588] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-29 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongjan.
DESC: Fix cursor when browser is brought back from background and a plugin has focus.
​http://bugs.webkit.org/show_bug.cgi?id=13225

  • Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
1:36 PM Changeset in webkit [20587] by yongjzha
  • 4 edits in S60/trunk/WebCore

yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan <​zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

​http://bugs.webkit.org/show_bug.cgi?id=13219

  • khtml/html/htmltokenizer.cpp: (khtml::):
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):
1:18 PM Changeset in webkit [20586] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-03-28 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
​http://bugs.webkit.org/show_bug.cgi?id=13217

  • khtml/rendering/render_table.h:
1:11 PM Changeset in webkit [20585] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-27 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun.
DESC: Regression due to patch r20436
TSW Id: TKWG-6Z477F-Browser auto exit when browsing web Page
​http://bugs.webkit.org/show_bug.cgi?id=13207

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::ResponseCompleteL):


1:03 PM Changeset in webkit [20584] by yongjzha
  • 2 edits in S60/trunk/WebKit

Steve, reviewed by Yongjun Zhang

DESC:
​http://bugs.webkit.org/show_bug.cgi?id=13296

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SizeChanged):
1:01 PM Changeset in webkit [20583] by yongjzha
  • 4 edits in S60/trunk/WebKit

hongzhao, reviewed by ​yongjun.zhang@nokia.com.

DESC: [S60] Browser doesn't support for DRM image content in 3.2.
Fix: Add function to handle DRM image decoder.
​http://bugs.webkit.org/show_bug.cgi?id=13220

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
  • group/webkit.mmp:
12:13 PM Changeset in webkit [20582] by bdash
  • 1 edit in tags/WebCore-5522.4.2/WebCore/Info.plist

Versioning.

12:12 PM Changeset in webkit [20581] by bdash
  • 10 edits in tags/WebCore-5522.4.2/WebCore

Merge in r20565.

12:10 PM Changeset in webkit [20580] by bdash
  • 1 copy in tags/WebCore-5522.4.2

New tag.

12:00 PM Changeset in webkit [20579] by staikos
  • 1 edit in trunk/WebCore/platform/qt/FontQt.cpp

Add a comment since our current fix is not really acceptable.

11:44 AM Changeset in webkit [20578] by staikos
  • 2 edits in trunk/WebCore

Remove redundant line.

11:18 AM Changeset in webkit [20577] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-28 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
​http://bugs.webkit.org/show_bug.cgi?id=13217

  • khtml/rendering/render_table.h:
11:05 AM BuildingOnWindows edited by tommy@ech-wel.nl
(diff)
10:34 AM Changeset in webkit [20576] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2007-03-29 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] Browser doesn't support for DRM image content.
Fix: Make some changes based on Yongjun's comments for the previous 3.1m patch.
​http://bugs.webkit.org/show_bug.cgi?id=13220

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
  • group/webkit.mmp:
10:07 AM Changeset in webkit [20575] by staikos
  • 2 edits in trunk

correct the changelog entry for the patch author.

10:05 AM Changeset in webkit [20574] by staikos
  • 2 edits in trunk/WebCore

Take into account the entire run length to get a proper selection.
Doesn't seem to affect the Mac build but is a problem for Qt.

10:01 AM Changeset in webkit [20573] by ggaren
  • 2 edits
    1 move in trunk/WebKit

Rubber stamped by Beth Dakin.


WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
it's ObjC++ now.

  • Plugins/WebBaseNetscapePluginStream.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
9:59 AM Changeset in webkit [20572] by darin
  • 4 edits
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4545060>, technorati and arstechnica fail
because of getComputedStyle not reporting display:none.
​http://bugs.webkit.org/show_bug.cgi?id=13103

  • fast/css/computed-style-display-none.html: Added.
  • fast/css/computed-style-display-none-expected.txt: Added.
  • fast/css/computed-style-negative-top.html: Updated to work with Gecko.
  • fast/css/computed-style-negative-top-expected.txt: Newline change needed because of change above.
  • fast/css/computed-style.html: Updated to work with Gecko.
8:18 AM Changeset in webkit [20571] by ggaren
  • 5 edits in trunk/WebKit

Reluctantly tolerated by Darin Adler.


Fixed <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


The problem was that the DivX plug-in would ask us to destroy an NPStream
that had already been destroyed, causing us to wander off into freed
memory. (I believe the reason this was a regression was that we never used
to destroy plug-in streams, period.)


The solution here is to track the NPStreams belonging to a plug-in, and
guard against plug-ins making calls with NPStreams that don't belong to
them. (It turns out that NPN_DestroyStream is the only stream-based
plug-in call we support.)

(CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix. Use helper method to guard against a plug-in using an NPStream that doesn't belong to it.
  • WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++ so I could use HashMap.
1:41 AM Changeset in webkit [20570] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
reporting display:none properly when it is set. This is bugzilla bug 13103.

Reviewed by mitz

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
12:49 AM Changeset in webkit [23204] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Enable CG's local font cache.

Note: See TracTimeline for information about the timeline view.