Timeline
Apr 1, 2007:
- 8:04 PM Changeset in webkit [20652] by
-
- 1 copy in tags/Safari-522.5.4b
New tag.
- 4:29 PM Changeset in webkit [20651] by
-
- 2 edits in branches/Safari-522/WebCore
Merge fix from r20570
- 4:27 PM Changeset in webkit [20650] by
-
- 14 edits in branches/Safari-522
Merge fix from r20565
- 4:01 PM Changeset in webkit [20649] by
-
- 2 edits in trunk/WebCore
Not reviewed - gdk build fix.
- platform/gdk/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText): (Font::drawComplexText):
Mar 31, 2007:
- 10:41 PM Changeset in webkit [20648] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12778
REGRESSION: Nightly won't load Curl plugin for full page use
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Re-order cases to give more priority to plugins. This also fixes Adobe SVG Viewer and any plugins that register XML MIME types. Added a case for XHTML to avoid enumerating plugins.
- 10:33 PM Changeset in webkit [23212] by
-
- 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp
Remove bogus comment.
- 10:30 PM Changeset in webkit [23211] by
-
- 5 edits in branches/WindowsMerge/WebCore
Fix layout of justified selected text.
- 10:21 PM Changeset in webkit [20647] by
-
- 4 adds in trunk/LayoutTests/fast/text
- 10:20 PM Changeset in webkit [20646] by
-
- 13 edits in trunk/WebCore
Fix for bug 13234, layout of selected justified text is broken. Rework TextRuns to avoid having
from/to members. Let those be passed in only by the functions that need them (drawing and selection rect).
Reviewed by mitz
fast/text/justified-selection-at-edge.html
- platform/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPositionForSimpleText):
- platform/Font.h: (WebCore::TextRun::m_len):
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
- platform/graphics/GraphicsContext.h:
- platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- platform/qt/FontQt.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText):
- platform/qt/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
- rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::width):
- 10:04 PM Changeset in webkit [20645] by
-
- 2 edits in trunk/WebCore
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
<rdar://problem/5103226>
REGRESSION (r20506): Repro crash/assert when using scroll wheel on a list box taller than its contents
- platform/ScrollBar.cpp: (WebCore::Scrollbar::setValue): Cleaned up a little. (WebCore::Scrollbar::scroll): Changed to apply the minimum and maximum constraints in the right order, and cleaned up a little.
- 9:59 PM Changeset in webkit [20644] by
-
- 3 edits2 adds in trunk
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=13242 REGRESSION: Repro crash when specifying the content property for an image
- fast/images/text-content-crash-expected.txt: Added.
- fast/images/text-content-crash.html: Added.
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13242 REGRESSION: Repro crash when specifying the content property for an image
Test: fast/images/text-content-crash.html
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Added a check that the renderer is an image. (WebCore::HTMLImageElement::attach): Ditto.
- 9:50 PM Changeset in webkit [20643] by
-
- 2 edits in trunk/WebKitTools
2007-03-31 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=13239
Bug 13239: REGRESSION (r20343): Drosera hits exception trying to call "count" cross-process
Use -[WebScriptObject valueForKey:@"length"] to retrieve the length of a JavaScript array
rather than -[WebScriptObject count].
- Drosera/DebuggerDocument.m: (-[DebuggerDocument webScriptAttributeKeysForScriptObject:]):
- 9:48 PM Changeset in webkit [20642] by
-
- 3 edits in trunk/WebCore
2007-03-31 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
A more correct fix for http://bugs.webkit.org/show_bug.cgi?id=13129
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup
The previous attempt at a fix in r20343 attempted to conditionally expose the 'count'
method. It did not work which resulted in 'count' always being hidden. This change
disables -[WebScriptObject count] completely until it can be determined whether it is
needed and how to support it without breaking third-party applications.
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject count]):
- bindings/objc/WebScriptObjectPrivate.h:
- 9:28 PM Changeset in webkit [23210] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Filesystem layout changes:
<rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
- 11:24 AM Changeset in webkit [23209] by
-
- 2 edits in branches/WindowsMerge/WebKitTools
Reviewed by Adam.
A little cleanup from my last change. Added a comment, and moved a JSStringRelease call to a better place.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):
- 8:32 AM Changeset in webkit [20641] by
-
- 3 edits in trunk/LayoutTests
Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.
Fixed one instance where 'allow-tabs' property and 'true' value were reversed.
- 4:30 AM Changeset in webkit [20640] by
-
- 2 edits in trunk/LayoutTests/fast/js/resources
Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.
- 3:25 AM Changeset in webkit [20639] by
-
- 2 edits4 adds in trunk
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Sam Weinig.
- pixel test for partially selected justified text
- fast/text/justified-selection-expected.checksum: Added.
- fast/text/justified-selection-expected.png: Added.
- fast/text/justified-selection-expected.txt: Added.
- fast/text/justified-selection.html: Added.
- 3:18 AM Changeset in webkit [20638] by
-
- 1 edit4 adds in trunk/LayoutTests
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
A layout test documenting shrink-to-fit width calculation for floating elements.
- fast/block/float/shrink-to-fit-width-expected.checksum: Added.
- fast/block/float/shrink-to-fit-width-expected.png: Added.
- fast/block/float/shrink-to-fit-width-expected.txt: Added.
- fast/block/float/shrink-to-fit-width.html: Added.
- 3:07 AM Changeset in webkit [20637] by
-
- 3 edits2 adds in trunk
2007-03-31 Nicholas Shanks <webkit@nickshanks.com>
Reviewed by Adele.
http://bugs.webkit.org/show_bug.cgi?id=13184
HTMLImageElement longdesc should be complete resolved URL
Test: fast/dom/HTMLImageElement/image-longdesc-absolute-url.html
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::longDesc): Return absolute URL. Behaviour now matches Firefox and Opera.
- 1:26 AM Changeset in webkit [20636] by
-
- 5 edits4 adds in trunk
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13209 REGRESSION (r18756-18765): Incomplete list marker repaint when resizing list item
Test: fast/repaint/list-marker-2.html
A list marker can increase the horizontal overflow after layoutInlineChildren(),
so made that function return only the vertical bounds of the repaint rect. As the
horizontal bounds, made layoutBlock() just use the overflow bounds after layout.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 12:59 AM Changeset in webkit [20635] by
-
- 3 edits4 adds in trunk
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- http://bugs.webkit.org/show_bug.cgi?id=13178 Helvetica zero-width space has non-zero width
Test: fast/text/wide-zero-width-space.html
- platform/FontData.cpp: (WebCore::FontData::FontData): Force the ZERO WIDTH SPACE glyph to have width 0, unless the SPACE character maps to the same glyph.
- 12:49 AM Changeset in webkit [20634] by
-
- 11 edits2 adds in trunk
2007-03-31 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=8016 REPRO: Safari hangs loading 18 MB page (deeply nested DOM tree)
WebCore:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Made "<" terminate tag and attribute names. This matches Firefox.
LayoutTests:
- fast/overflow/002-expected.checksum:
- fast/overflow/002-expected.png:
- fast/overflow/002-expected.txt:
- fast/overflow/002.html: Added missing ">" to one of the BR tags.
- fast/text/atsui-multiple-renderers-expected.checksum:
- fast/text/atsui-multiple-renderers-expected.png:
- fast/text/atsui-multiple-renderers-expected.txt:
- fast/text/atsui-multiple-renderers.html: Added missing ">" to the TITLE tag.
- fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt: Added.
- fast/tokenizer/lessthan-terminates-tags-and-attrs.html: Added.