Context Navigation

← Previous Period
Next Period →

Timeline

Apr 2, 2007:

10:54 PM Changeset in webkit [20675] by adele

2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

Hardcode disabled text colors for the most common cases- black and white.

rendering/RenderTextControl.cpp: (WebCore::disabledTextColor):

6:11 PM Changeset in webkit [20674] by hyatt

19 edits in trunk/WebCore

Fix for <rdar://problem/5105784>, assertion failure in cache. Encoded sizes were being set to
garbage by accident because of a mismatch between derived class and base class constructors. This
patch cleans all of this up and gets rid of expiration date as a concept separate from the response.

Reviewed by anders

dom/Document.cpp: (WebCore::Document::processHttpEquiv):
html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
loader/Cache.h:
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
loader/CachedCSSStyleSheet.h:
loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
loader/CachedImage.h:
loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::finish):
loader/CachedResource.h:
loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::requestResource):
loader/DocLoader.h:

6:01 PM Changeset in webkit [20673] by antti

7 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 3

These changes shrink all RenderBlocks by additional 28 bytes. Together with parts 1 and 2
RenderBlock goes from 172 bytes to 128 bytes, a saving of 26%.

Pack bitfields together in RenderFlow
Move top/bottom min/max margin values to a struct that is only allocated in case these variables have non default values. Usually this is <5% of all blocks.
Move rarely used column variables to hash

rendering/RenderBlock.cpp: (WebCore::ColumnInfo::ColumnInfo): (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::setDesiredColumnCountAndWidth): (WebCore::RenderBlock::desiredColumnWidth): (WebCore::RenderBlock::desiredColumnCount): (WebCore::RenderBlock::columnRects): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents): (WebCore::RenderBlock::adjustRectForColumns): (WebCore::RenderBlock::setMaxTopMargins): (WebCore::RenderBlock::setMaxBottomMargins):
rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::maxTopPosMargin): (WebCore::RenderBlock::maxTopNegMargin): (WebCore::RenderBlock::maxBottomPosMargin): (WebCore::RenderBlock::maxBottomNegMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::MaxMargin::MaxMargin): (WebCore::RenderBlock::MaxMargin::topPosDefault): (WebCore::RenderBlock::MaxMargin::topNegDefault): (WebCore::RenderBlock::MaxMargin::bottomPosDefault): (WebCore::RenderBlock::MaxMargin::bottomNegDefault):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow): (WebCore::RenderFlow::hasColumns):
rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline):
rendering/RenderInline.h:

6:00 PM Changeset in webkit [23220] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

5:54 PM Changeset in webkit [23219] by andersca

4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Check that NPStream pointers passed to NPN_DestroyStream are valid.

plugins/win/PluginStreamWin.cpp: (WebCore::streams): (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::ownerForStream):
plugins/win/PluginStreamWin.h:
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream):

5:22 PM Changeset in webkit [20672] by antti

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test you don't crash when you have abs positioned elements inside rel inline.

fast/block/positioning/abs-inside-inline-rel-expected.checksum: Added.
fast/block/positioning/abs-inside-inline-rel-expected.png: Added.
fast/block/positioning/abs-inside-inline-rel-expected.txt: Added.
fast/block/positioning/abs-inside-inline-rel.html: Added.

WebCore:

Reviewed by Hyatt.

Fix asserts, these may also be called for rel positioned elements

rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY):

4:49 PM Changeset in webkit [20671] by andersca

4 edits in trunk/WebKit

Reviewed by Geoff.

Fix crash when running plugins/destroy-stream-twice.html under GuardMalloc

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (+[WebBaseNetscapePluginStream ownerForStream:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): Change the streams hash map to contain an NPStream*, and change ownerForStream to take an NPStream*.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): Check that the NPStream pointer is valid before accessing stream->ndata.

4:41 PM Changeset in webkit [20670] by hyatt

2 edits in trunk/WebCore

Throw in an assert to try to track down a problem where an image is being set to a smaller encoded
size.

loader/CachedResource.cpp: (WebCore::CachedResource::setEncodedSize):

4:32 PM Changeset in webkit [23218] by andersca

4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5095582>
PluginViewWin doesn't implement NPN_DestroyStream.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Handle the case where NPN_DestroyStream is called from the newstream handler.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream): Implement this.

3:29 PM Changeset in webkit [20669] by adachan

2 edits in trunk/WebCore

2007-04-02 Ada Chan <adachan@apple.com>

Reviewed by Adele.

<rdar://5105331> Missing null check in Editor::execCommand
Added null check.

editing/Editor.cpp: (WebCore::Editor::execCommand):

3:19 PM Changeset in webkit [23217] by andersca

3 edits in branches/WindowsMerge/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/5097225>
Mouse cursors don't work with windowless plugins

platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor): Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Store away the current cursor and make sure that it won't be reset.

2:28 PM Changeset in webkit [23216] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix logic in windowless paint functions.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::invalidateRegion): (WebCore::PluginViewWin::forceRedraw):

2:15 PM Changeset in webkit [20668] by darin

3 edits in trunk/WebKit

Reviewed by Geoff.

fix http://bugs.webkit.org/show_bug.cgi?id=13026 <rdar://problem/5061026> incomplete render of menu (assertion failing in -[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:])

fix http://bugs.webkit.org/show_bug.cgi?id=13120 <rdar://problem/5080339> Plug-ins that draw through the QuickDraw interface may crash by hanging onto old GWorlds.

set clip path for CoreGraphics plug-ins in the same way we do for QuickDraw plug-ins this is a better fix for <rdar://problem/4939511> WebKit should set the the CG clip path for plug-ins that draw using Core Graphics

Incorporates changes from a patch by Mark Ambachtsheer.

Here are the changes:

1) Don't try to use the offscreen code path if GGBitmapContextGetData returns 0.
2) Handle kCGBitmapByteOrderDefault when computing the QD pixel format, even though

we don't have any evidence that this happens in practice.

3) Keep the GWorld around until we create a new one or the plug-in is destroyed.
4) Use the GWorld pointer itself as a flag to indicate whether we are using an

offscreen GWorld.

5) Set up clipping for CoreGraphics in the same way we do for QuickDraw; remove an

earlier attempt that handled CoreGraphics differently.

Plugins/WebBaseNetscapePluginView.h: Added a field named offscreenGWorld to hold the GWorld until it's needed.
Plugins/WebBaseNetscapePluginView.mm: (getQDPixelFormatForBitmapContext): Replaced QDPixelFormatFromCGBitmapInfo. Used the "get" prefix so we don't intrude on the QD namespace. Added code to handle the kCGBitmapByteOrderDefault case, although I'm not sure it will really come up in practice -- it wasn't really coming up in the buggy case. (getNPRect): Added helper functions. Used to make the code below clearer. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Use getNPRect to streamline code. Use GetGWorld to save the port since we use SetGWorld to restore it later. Store the GWorld we create in the offscreenGWorld field and dispose the existing one. Don't treat the CGBitmapContext as an offscreen bitmap if it has a data pointer of 0. Set up the clip based on the result of -[NSView getRectsBeingDrawn:count] when setting up the port for CoreGraphics (after saving the port state). (-[WebBaseNetscapePluginView restorePortState:]): Remove now-unneeded code to destroy the offscreen GWorld, and simplified the code that restores the port so we don't need a separate case for offscreen. (-[WebBaseNetscapePluginView fini]): Renamed from freeAttributeKeysAndValues, since this method now does more than just the attributes. This is the shared method that does things needed in both dealloc and finalize. Added a call to DisposeGWorld here. (-[WebBaseNetscapePluginView dealloc]): Updated for name change. (-[WebBaseNetscapePluginView finalize]): Ditto. (-[WebBaseNetscapePluginView drawRect:]): Removed code to set clip. This is done in the saveAndSetNewPortStateForUpdate: method instead.

1:38 PM Changeset in webkit [20667] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-03-30 jadhan <jade.han@nokia.com>

Reviewed by Zalan <zbujtas@gmail.com>
DESC: special handling for utf8 encoding of danish character. Merged fix from 3.2 to 3.1
http://bugs.webkit.org/show_bug.cgi?id=13231

WARNING: NO TEST CASES ADDED OR CHANGED

ChangeLog:
kwq/KWQTextCodec.cpp: (validateUtf8):

1:30 PM Changeset in webkit [23215] by andersca

2 edits in branches/WindowsMerge/WebKitTools

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Add TestNetscapeObject project.

1:23 PM Changeset in webkit [23214] by andersca

1 edit in branches/WindowsMerge/WebKitTools/ChangeLog

Adam is not a nobody.

1:23 PM Changeset in webkit [23213] by andersca

4 edits
4 adds in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by NOBODY (OOPS!).

Add netscape test plugin VC project. Make DumpRenderTree look for the test plugin.

12:46 PM Changeset in webkit [20666] by bdash

5 edits in branches/Safari-522/WebKit

Merge r20571.

12:37 PM Changeset in webkit [20665] by bdash

7 edits in branches/Safari-522

Merge r20593 and r20596.

12:33 PM Changeset in webkit [20664] by andersca

2 edits in trunk/WebKitTools

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Don't use #import in a header included by C files.

12:23 PM Changeset in webkit [20663] by bdash

5 edits in branches/Safari-522

Merge r20555 and r20560.

11:37 AM Changeset in webkit [20662] by spadma

4 edits in S60/trunk/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
http://bugs.webkit.org/show_bug.cgi?id=13257

BrowserView/inc/WebKitControl.h:
BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):

11:37 AM Changeset in webkit [20661] by spadma

4 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
http://bugs.webkit.org/show_bug.cgi?id=13257

BrowserView/inc/WebKitControl.h:
BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):

11:23 AM Changeset in webkit [20660] by justing

3 edits
8 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

editing/inserting/5058163-1-expected.checksum: Added.
editing/inserting/5058163-1-expected.png: Added.
editing/inserting/5058163-1-expected.txt: Added.
editing/inserting/5058163-1.html: Added.
editing/inserting/5058163-2-expected.checksum: Added.
editing/inserting/5058163-2-expected.png: Added.
editing/inserting/5058163-2-expected.txt: Added.
editing/inserting/5058163-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Removed refPos, it was unused. Don't assume that upstream() moves to a different node. This assumption caused the line break to be inserted *after* the caret and a bad position to be set (added a testcase). Use isStartOfParagraph instead of checking for the existence of a br because the line might be broken by a newline character in text that preserves newlines. Paragraphs that are created in other ways, like with blocks, are handled above (added a testcase).

11:22 AM Changeset in webkit [20659] by spadma

5 edits in S60/trunk/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
http://bugs.webkit.org/show_bug.cgi?id=13256

BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):

11:22 AM Changeset in webkit [20658] by spadma

5 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
http://bugs.webkit.org/show_bug.cgi?id=13256

BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):

10:39 AM Changeset in webkit [20657] by zbujtas

3 edits in S60/trunk/WebCore

2007-04-02 yongjzha <yonjun.zhang@nokia.com>

Reviewed by bjutas@gmail.com.
DESC: suppress false memory leaking alert.
http://bugs.webkit.org/show_bug.cgi?id=13253

khtml/css/css_base.h: (DOM::):
khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):

10:36 AM Changeset in webkit [20656] by harrison

2 edits in trunk/WebCore

2007-04-02 David Harrison <harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4906488> text attributes are not working for frame based web page

Attribute handling now treats each WebArea as its own world, rather than sometimes
referring back up to the top WebArea. e.g. getting/setting the selection now
operates on the WebArea containing the WebCoreAXObject that is being messaged (self).
The methods that sit above this and are able to go into arbitrary WebAreas
are accessibilityFocusedUIElement and doAXTextMarkerForPosition, allowing VoiceOver
to navigate between frames.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject topRenderer]): (-[WebCoreAXObject frameView]): (-[WebCoreAXObject topFrameView]): Removed topDocument, renamed topView to topFrameView, added frameView.

(-[WebCoreAXObject accessibilityAttributeValue:]):
AXSelectedTextMarkerRange, AXStartTextMarker, and AXEndTextMarker now use
self's WebArea, rather than the top WebArea.

(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
Use self's WebArea, rather than the top WebArea.

(-[WebCoreAXObject doAXTextMarkerForPosition:]):
Use renamed methods for accessing top WebArea.

(-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
Use renamed methods for accessing self's WebArea.

(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
(AXAttributeStringSetElement):
(-[WebCoreAXObject rendererForView:]):
Clean up uses of nil and NULL.

(-[WebCoreAXObject accessibilityFocusedUIElement]):
Find the focused node on the whole page. If there is no focused node,
return the WebArea for the focused document.

(-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
Use self's WebArea, rather than the top WebArea.

10:36 AM Changeset in webkit [20655] by zbujtas

3 edits in S60/branches/3.1m/WebCore

2007-04-02 yongjzha <yonjun.zhang@nokia.com>

Reviewed by bjutas@gmail.com.
DESC: suppress false memory leaking alert.
http://bugs.webkit.org/show_bug.cgi?id=13253

khtml/css/css_base.h: (DOM::):
khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):

3:06 AM Changeset in webkit [20654] by antti

2 edits in trunk/WebCore

Fix build. This one was not supposed to be checked in.

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):

2:43 AM Changeset in webkit [20653] by antti

9 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 2

Move staticX and staticY variables to RenderLayer since they are only applicable to positioned objects
Move very rarely used overrideSize variable to hash

These changes shrink all box types by 12 bytes

rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::overrideSize): (WebCore::RenderBox::setOverrideSize): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::position): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::staticX): (WebCore::RenderBox::staticY): (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
rendering/RenderBox.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
rendering/RenderLayer.h: (WebCore::RenderLayer::staticX): (WebCore::RenderLayer::staticY): (WebCore::RenderLayer::setStaticX): (WebCore::RenderLayer::setStaticY):
rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasOverrideSize): (WebCore::RenderObject::setHasOverrideSize):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):