Context Navigation

← Previous Period
Next Period →

Timeline

Apr 5, 2007:

11:45 PM Changeset in webkit [20746] by oliver

3 edits
4 adds in trunk

2007-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

WebCore:

Fix for rdar://problem/4849948 -- JSCanvasRenderingContext2D::drawImage
crashes when given invalid arguments.

JSCanvasRenderingContext2D frequently casts from JSValue* to JSObject*
and then checks isObject *after* the cast. JSObject::isObject is unsafe
if applied to a JSImmediate value (null, undefined, etc). This patch
corrects the logic in a number of places by performing the isObject check
before casting to JSObject.

bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::createPattern):

LayoutTests:

Layout tests for rdar://problem/4849948
Make sure we don't crash when passing invalid args to Canvas::drawImage

fast/canvas/drawImage-with-invalid-args-expected.checksum: Added.
fast/canvas/drawImage-with-invalid-args-expected.png: Added.
fast/canvas/drawImage-with-invalid-args-expected.txt: Added.
fast/canvas/drawImage-with-invalid-args.html: Added.

11:19 PM Changeset in webkit [20745] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.css

Add -webkit-dashboard-region to select and input elements to prevent dragging the window in those areas.

11:09 PM Changeset in webkit [20744] by aroben

2 edits in branches/WebInspectorRefresh/WebKit

Reviewed by Tim.

When navigating to a parent node via the inspector's popup menu, don't
blow away all the children in the list so that it's easy to get back
to them later.

WebInspector/webInspector/inspector.js: (function updateTreeOutline): Don't reset the popup if we're navigating to a node already in the popup.

10:25 PM Changeset in webkit [20743] by adele

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/4965597> REGRESSION: mouseup doesn't fire for slider (causes it to always default to max)

fast/forms/slider-mouse-events-expected.txt: Added.
fast/forms/slider-mouse-events.html: Added.

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/4965597> REGRESSION: mouseup doesn't fire for slider (causes it to always default to max)

Test: fast/forms/slider-mouse-events.html

page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Since the actual target node of the event can't be a shadow node, set the target node to the capturing node before adjusting it.

8:05 PM Changeset in webkit [20742] by andersca

10 edits
3 adds in trunk

LayoutTests:

Reviewed by Adam.

<rdar://problem/5083023>
REGRESSION: In Real Player (10.1.0), video continues to play after closing window

Add a test where a window containing a plugin is opened and then closed. The window is closed
without calling -[WebView close].

plugins/open-and-close-window-with-plugin-expected.txt: Added.
plugins/open-and-close-window-with-plugin.html: Added.
plugins/resources/open-and-close-window-with-plugin.html: Added.

WebKit:

Reviewed by Adam.

<rdar://problem/5083023>
REGRESSION: In Real Player (10.1.0), video continues to play after closing window

This broke in revision 18422 because now the plugin isn't stopped when the window is closed. Since the window is retained
by the plugin view for as long as it is running (so that removeTrackingRect works even though the window has been closed),
we would end up with a reference cycle (NSWindow -> WebView -> PluginView -> NSWindow) and stopping the plug-in when the window
was closed would break that cycle.

Applications that call -[WebView close] when closing aren't affected, but RealPlayer doesn't do this.

The bug that 18422 was supposed to fix was fixed by 19275, which is why it's safe to add back the check.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (-[WebBaseNetscapePluginView windowWillClose:]):

WebKitTools:

Reviewed by Adam.

Add support for opening new windows in DumpRenderTree.

(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setCallCloseOnWebViews:]):
(-[LayoutTestController setCanOpenWindows]):
Add two new methods callable from JavaScript. setCanOpenWindows controls whether a test
can open new windows, and setCallCloseOnWebViews controls whether -[WebView close] should be called on
web views that are about to be closed.

(runTest):
Make sure that only the main window is around when a test has finished running.

(-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
(-[DumpRenderTreeWindow dealloc]):
Manage the set of windows.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_Destroy): Add a "logDestroy" property which controls whether plugins should print when they are destroyed or not.

DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:createWebViewWithRequest:]): Create new windows.

(-[UIDelegate webViewClose:]):
Close windows.

6:46 PM Changeset in webkit [20741] by andersca

2 edits in trunk/WebKitTools

Reviewed by Maciej.

Move WebView and NSWindow creation to a separate function in preparation of supporting opening new
windows in DRT.

DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree):

6:05 PM Changeset in webkit [20740] by kmccullo

14 edits in trunk

LayoutTests:

Reviewed by Darin.

Now we add a console message when local resources are blocked.

http/tests/security/local-CSS-from-remote-expected.txt:
http/tests/security/local-JavaScript-from-remote-expected.txt:
http/tests/security/local-iFrame-from-remote-expected.txt:
http/tests/security/local-image-from-remote-expected.txt:

WebCore:

Reviewed by Darin.

Added reportLocalLoadFailed to FrameLoader to send an error to the console when calls to canLoad fail.

loader/Cache.cpp: (WebCore::Cache::requestResource):
loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::load): (WebCore::FrameLoader::reportLocalLoadFailed):
loader/FrameLoader.h:
loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):

WebKit:

Reviewed by Darin.

Moved registerURLSchemeAsLocal to the public API.

WebView/WebView.h:
WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):
WebView/WebViewPrivate.h:

5:42 PM Changeset in webkit [20739] by adele

2 edits in trunk/WebCore

Reviewed by Maciej.

Add text-align: -webkit-auto for form controls. Buttons already override this property to center their text.

css/html4.css:

3:52 PM Changeset in webkit [20738] by kjk

2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fix. Coverity says:
"Event check_after_deref: Pointer "dateString" dereferenced before NULL check"

kjs/date_object.cpp: (KJS::parseDate):

3:50 PM Changeset in webkit [20737] by kjk

2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fix. Coverity says:
"Event check_after_deref: Pointer "re" dereferenced before NULL check"

pcre/pcre_study.c: (pcre_study):

3:45 PM Changeset in webkit [20736] by kjk

2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fixes. Coverity says:
"Event leaked_storage: Returned without freeing storage "buffer""
and:
"Event leaked_storage: Returned without freeing storage "script""

kjs/testkjs.cpp: (doIt): (createStringWithContentsOfFile):

3:42 PM Changeset in webkit [20735] by kjk

2 edits in trunk/WebCore

Reviewed by rwlbuis.

Coverity fix. Coverity says:
"Event var_deref_model: Variable "page" tracked as NULL was passed to a function that dereferences it."

platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):

3:38 PM Changeset in webkit [20734] by kjk

2 edits in trunk/WebCore

Reviewed by darin.

Coverity fix. Coverity says:
"Event var_deref_model: Variable "unicode" tracked as NULL was passed to a
function that dereferences it."

platform/DeprecatedString.cpp: (WebCore::DeprecatedString::DeprecatedString):

3:33 PM Changeset in webkit [20733] by kjk

2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fix: in single-threaded case currentThreadIsMainThread is always true
so the code in if (!currentThreadIsMainThread) cannot possibly be reached
and Coverity complains about dead code.

kjs/collector.cpp: (KJS::Collector::collect):

2:26 PM Changeset in webkit [20732] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5113593> REGRESSION: Search fields in RSS pages don't show ibeam cursor

css/html4.css: Set the cursor values explicitly for input, textarea (to auto), & select (to default).

2:21 PM Changeset in webkit [20731] by hyatt

3 edits in trunk/WebCore

Fix for <rdar://problem/5078866> tables should only reset text-align
in quirks mode.

Reviewed by beth

css/html4.css:
css/quirks.css:

1:40 PM Changeset in webkit [20730] by sfalken

1 copy in tags/Safari-522.5.5b

New tag.

1:36 PM Changeset in webkit [20729] by adele

2 edits in trunk/WebCore

Fixing typo that's crashing.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use evt instead of null variable k.

1:30 PM Changeset in webkit [20728] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5021500> Cursor should stay as pointer when slider is being dragged

Don't set the selection ibeam cursor when there's a node that's capturing mouse events.

page/EventHandler.cpp: (WebCore::selectCursor): (WebCore::EventHandler::handleMouseMoveEvent):

12:55 PM Changeset in webkit [20727] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-04-04 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Setting status to KErrCancel when the request dispatcher does not define a loader causes a problem for the history stack, reverting to previous.
http://bugs.webkit.org/show_bug.cgi?id=13232

BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):

12:55 PM Changeset in webkit [20726] by spadma

2 edits in S60/trunk/WebKit

2007-04-04 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Setting status to KErrCancel when the request dispatcher does not define a loader causes a problem for the history stack, reverting to previous.
http://bugs.webkit.org/show_bug.cgi?id=13232

BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):

12:33 PM Changeset in webkit [20725] by ggaren

12 edits in trunk/WebCore

Reviewed by Beth Dakin.

More clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

Layout tests pass.

Removed more superfluous document NULL checks. (Node::document() never
returns NULL, and it asserts as much.)

Merged some duplicate editing code into a static inline function.

page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings): Removed superfluous static_cast.

11:41 AM Changeset in webkit [20724] by adele

8 edits in trunk/WebCore

Reviewed by Darin.

A little cleanup from my last checkin. Always check if an Event is really a MouseEvent or a KeyboardEvent
before casting it.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

10:48 AM Changeset in webkit [20723] by ggaren

9 edits in trunk/WebCore

Reviewed by Beth Dakin.

Some clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

Removed superfluous document NULL checks. (Node::document() never returns
NULL, and it asserts as much.)

Removed duplicate implementation of displayString.

Layout tests pass.

bindings/objc/DOMInternal.h:
bindings/objc/DOMInternal.mm:
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::supportsFocus):
html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
rendering/HitTestResult.cpp: (WebCore::displayString):
rendering/HitTestResult.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState):

9:35 AM Changeset in webkit [20722] by mjs

2 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

remove the concept of oversize objects, now that there aren't any (for now only enforced with an assert).

This change is a .66% speedup on JS iBench for 32-bit platforms, probably much more
for 64-bit since it finally gives a reasonable cell size, but I did not test that.

kjs/collector.cpp: (KJS::): Use different cell size for 32-bit and 64-bit, now that there is no oversize allocation. (KJS::Collector::allocate): Remove oversize allocator. (KJS::Collector::markStackObjectsConservatively): Don't check oversize objects. (KJS::Collector::markMainThreadOnlyObjects): Ditto. (KJS::Collector::collect): Ditto.

8:24 AM Changeset in webkit [20721] by yongjzha

4 edits in S60/trunk/WebKit

hongzhao, reviewed by yongjun.zhang@nokia.com

DESC: [S60]Animated images with DRM content won't be displayed in Browser in 3.2
Fix: Handle DRM image content during construct the content.
http://bugs.webkit.org/show_bug.cgi?id=13258

BrowserCore/Renderers/inc/AnimationDecoder.h:
BrowserCore/Renderers/inc/StaticImageDecoder.h:
BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CRawData::DecodeDRMImageContentL): (CStaticImageDecoder::LoadNextImage):

3:20 AM Changeset in webkit [20720] by oliver

3 edits
3 adds in trunk

2007-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

WebCore:

Fix rdar://problem/5030934 -- landscape PDFs embedded as an image are cut off
also fixes scaling of pdf images

PDFDocumentImage was not accounting for page rotation in a number of places

platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::size): we need to account for rotation of the pdf image effecting our bounds (WebCore::PDFDocumentImage::draw): When compensating for flipped coords we need to use the correct rect for the coordinate space. We can't pass size() to CGContextDrawPDFDocument as it returns the rotated bounds now -- this is also save the old FloatSize -> IntSize -> FloatSize conversions.

LayoutTests:

Testcase for landscape pdfs as image

rdar://problem/5030934 -- landscape PDFs embedded as an image are cut off

fast/images/pdf-as-image-landscape-expected.txt: Added.
fast/images/pdf-as-image-landscape.html: Added.
fast/images/resources/pdf_test_landscape.pdf: Added.

3:08 AM Changeset in webkit [20719] by mjs

4 edits in branches/js-collector-tweaks/WebCore

Not reviewed - experimental work.

move most of Window's data members into a separate private object, to avoid needing to use the oversize allocator for it

It was the only remaining JSObject subclass to use the ocersize
allocator on 32-bit platforms, and having oversize objects around
makes garbage collection slower so this would hurt performance
with many tabs/windows open.

No significant effect on JS iBench.

bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): (KJS::JSEventListener::JSEventListener): (KJS::JSEventListener::~JSEventListener): (KJS::JSLazyEventListener::parseCode):
bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::Window): (KJS::Window::~Window): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::findJSEventListener): (KJS::Window::findJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear): (KJS::Window::setCurrentEvent): (KJS::Window::setReturnValueSlot): (KJS::Window::clearAllTimeouts): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::Window::clearTimeout): (KJS::Window::timerFired): (KJS::Window::disconnectFrame): (KJS::Window::jsEventListeners): (KJS::Window::jsHTMLEventListeners): (KJS::Window::jsUnprotectedEventListeners): (KJS::Window::jsUnprotectedHTMLEventListeners):
bindings/js/kjs_window.h:

3:03 AM Changeset in webkit [20718] by mjs

1 copy in branches/js-collector-tweaks

vn cp svn+ssh://mjs@svn.opensource.apple.com/svn/webkit/trunk/JavaScriptCore svn+ssh://mjs@svn.opensource.apple.com/svn/webkit/branches/js-collector-tweaks/JavaScriptCore
Enter passphrase for key '/Users/mjs/.ssh/id_rsa':
subversion/libsvn_repos/commit.c:392: (apr_err=160016)
svn: Path 'branches/js-collector-tweaks' not present

Apr 4, 2007:

11:04 PM Changeset in webkit [20717] by thatcher

4 edits in branches/WebInspectorRefresh/WebKit/WebInspector

Move the tree splitter resize code down into JavaScript. Some other cleanup work.

10:24 PM Changeset in webkit [20716] by bdash

2 edits in trunk/WebKitSite

2007-04-05 Mark Malone <markmalone@mac.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13273
Bug 13273: DOM Interfaces Nav link should go somewhere more useful

nav.inc: Link directly to the hierarchy.

10:22 PM Changeset in webkit [20715] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Make selecting a new root element from the root popup menu work. Also reverse the order of the parent nodes shown in the popup, with the document at the top. Fixes bug 6615.

9:40 PM Changeset in webkit [20714] by ap

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13278
REGRESSION: cannot change SELECT option

Test: fast/forms/option-change-single-selected.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): If multiple selection is not allowed, be sure to deselect the previous option.

9:39 PM Changeset in webkit [20713] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/WebInspector.m

Remove my machine specific path.

9:37 PM Changeset in webkit [20712] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/AppleScrollbar.js

Only call this.refresh() if this.hidden is true. This was causing a 'maximum call stack size' exception.

9:26 PM Changeset in webkit [20711] by thatcher

3 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Move our override scrollbar and scroll-area code to our copies of AppleScrollbar.js and AppleScrollArea.js.

8:43 PM Changeset in webkit [20710] by thatcher

2 edits
2 adds in branches/WebInspectorRefresh/WebKit/WebInspector

Keep our own copy of AppleScrollbar.js and AppleScrollArea.js, copied /System/Library/WidgetResources/AppleClasses.

6:39 PM Changeset in webkit [23228] by oliver

2 edits in branches/WindowsMerge/WebKitWin

2007-04-04 Oliver Hunt <oliver@apple.com>

Reviewed by Ada.

Fix <rdar://problem/5111027> Dragging a link on page
shows URL thumbnail as nearly-transparent instead
semi-transparent

Error in createDragImageForLink led me to get wrong
maximum drag image size, now logic and maximum drag
image size corrected.

WebDragClient.cpp: (WebDragClient::createDragImageForLink):

6:05 PM Changeset in webkit [20709] by adele

9 edits in trunk/WebCore

Reviewed by Oliver.

Fix for <rdar://5105009> Prepare for fix to send mousedown and mouseup (but not click) events when right-clicking

page/EventHandler.cpp: Don't ever send click events for right-clicks. (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):

Check that the mousedown and mouseup are not with the right button before performing default behavior.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
ksvg2/svg/SVGAElement.cpp:(WebCore::SVGAElement::defaultEventHandler):
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

2:40 PM Changeset in webkit [23227] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Release build fix for TestNetscapePlugin.

WebKit.vcproj/WebKit.vcproj: Make the Release post-build step the same as the Debug one so that the npapi headers get copied.

1:52 PM Changeset in webkit [20708] by sfalken

19 edits in branches/Safari-522/WebCore

Re-merge fix from r20674

1:49 PM Changeset in webkit [20707] by justing

4 edits
12 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5026848> Can cut/delete To Do subunits

This tests to make sure that non-editable content
that is in both the start and end editable roots
is removed:

editing/deleting/5026848-1-expected.checksum: Added.
editing/deleting/5026848-1-expected.png: Added.
editing/deleting/5026848-1-expected.txt: Added.
editing/deleting/5026848-1.html: Added. This tests to make sure that non-editable content that is not in both the start and end editable roots is not removed:
editing/deleting/5026848-2-expected.checksum: Added.
editing/deleting/5026848-2-expected.png: Added.
editing/deleting/5026848-2-expected.txt: Added.
editing/deleting/5026848-2.html: Added. This tests to make sure that editable regions that are not in both the start and end editable roots are cleared (not removed, unless they are in another editable region):
editing/deleting/5026848-3-expected.checksum: Added.
editing/deleting/5026848-3-expected.png: Added.
editing/deleting/5026848-3-expected.txt: Added.
editing/deleting/5026848-3.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5026848> Can cut/delete ToDo subunits

We were removing non-editable content during a delete.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Set m_startRoot and m_endRoot. (WebCore::DeleteSelectionCommand::removeNode): If a node is not inside both the start and end roots, remove it only if it is in editable content.
editing/DeleteSelectionCommand.h: Added m_startRoot and m_endRoot, the editable roots that contain the start and end of the selection, respectively. We consult these every time we remove a node, and don't want to recompute them on every call to removeNode().

1:39 PM Changeset in webkit [20706] by sfalken

19 edits in branches/Safari-522/WebCore

Roll out r20705,r20701

11:24 AM Changeset in webkit [20705] by sfalken

1 edit in branches/Safari-522/WebCore/loader/DocLoader.cpp

Fix merge from r20674

10:33 AM Changeset in webkit [20704] by zbujtas

3 edits in S60/trunk/WebCore

2007-04-04 bujtas <zbujtas@gmail.com>

Reviewed by Sriram.
DESC: change nested <q> behavior so that q q {} gets ' instead of " -antti(c).
http://bugs.webkit.org/show_bug.cgi?id=13280

khtml/css/html4.css:
khtml/css/html4_gcce.css:

10:30 AM Changeset in webkit [20703] by andersca

2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5107536>
http://bugs.webkit.org/show_bug.cgi?id=13264
REGRESSION: Crash when canceling about:blank in Activity viewer

WebView/WebFrame.mm: (-[WebFrame stopLoading]): Add a null check for the frame loader - it can be null when the frame has been disconnected from the web page.

10:28 AM Changeset in webkit [20702] by zbujtas