Context Navigation

Fix minor error when writing selection to pasteboard.
This shouldn't have an effect as selectedRange should be the
selected range from source frame, however this is safer.

platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):

11:11 PM Changeset in webkit [20798] by hyatt

3 edits in trunk/WebCore

Fix mouseover/out failing layout tests.

Reviewed by aroben

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateMouseEventTargetNode): (WebCore::EventHandler::dispatchMouseEvent):
page/EventHandler.h:

10:50 PM Changeset in webkit [23242] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20797.

WebInspector/webInspector/inspector.js:

10:49 PM Changeset in webkit [23241] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20796.

WebInspector/webInspector/inspector.js:

10:46 PM Changeset in webkit [23240] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

<rdar://problem/5119804> Web Inspector isn't resizable
<rdar://problem/5119805> Can't move Web Inspector

WebInspector/WebInspector.cpp: (WebInspectorPrivate::WebInspectorPrivate): (WebInspector::WebInspector): Subclass the WebView so we can intercept its messages. (WebInspector::onDestroy): Undo the subclassing. (WebInspector::handleMessageSentToWebView): Added. (WebInspector::onLButtonDown): Added. (WebInspector::onLButtonUp): Added. (WebInspector::onMouseMove): Added. (WebInspectorWndProc): Added cases for mouse messages. (SubclassedWebViewWndProc): Added.
WebInspector/WebInspector.h:

10:04 PM Changeset in webkit [20797] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Search comment nodes also.

9:51 PM Changeset in webkit [20796] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

A better Xpath query for the simple search case.

9:30 PM Changeset in webkit [20795] by oliver

2 edits in trunk/WebCore

2007-04-08 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/5113621> REGRESSION: Dragging PDF as image does not give any feedback

If we fail when attempting to create a drag image for a dragged
image, we fall back to the appropriate icon.

page/DragController.cpp: (WebCore::DragController::doImageDrag):

8:55 PM Changeset in webkit [23239] by aroben

4 edits
3 adds
2 deletes in branches/WindowsMerge/WebKitWin

Merge in r20793.

WebInspector/webInspector/AppleScrollArea.js: Removed.
WebInspector/webInspector/AppleScrollbar.js: Removed.
WebInspector/webInspector/Images/resize.png: Added.
WebInspector/webInspector/inspector.css:
WebInspector/webInspector/inspector.html:
WebInspector/webInspector/inspector.js:
WebInspector/webInspector/scrollarea.js: Added.
WebInspector/webInspector/scrollbar.js: Added.

8:42 PM Changeset in webkit [23238] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20792.

WebInspector/webInspector/inspector.js:

8:41 PM Changeset in webkit [23237] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20791.

WebInspector/webInspector/inspector.js:

8:38 PM Changeset in webkit [23236] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Stubbed out Frame::dashboardRegionsChanged now that it's not
Mac-specific.

bridge/win/FrameWin.cpp: (WebCore::Frame::dashboardRegionsChanged):

8:32 PM Changeset in webkit [20794] by aroben

18 edits
1 delete in trunk/WebCore

Reviewed by Oliver.

Bestowed the gift of -webkit-dashboard-region upon all platforms, since
there's nothing Mac-specific about it other than the name. This also
allowed me to get rid of FrameViewMac.mm.

Removed a lot of #if PLATFORM(MAC):

css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getDashboardRegionValue): (WebCore::CSSPrimitiveValue::):
css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseDashboardRegions):
css/cssparser.h:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h:
page/Frame.cpp: (WebCore::Frame::paint):
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::updateDashboardRegions): Moved from FrameViewMac.mm.
page/FrameView.h:
page/qt/FrameQt.cpp: (WebCore::Frame::dashboardRegionsChanged): Stubbed out.
platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged): Ditto.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):

WebCore.xcodeproj/project.pbxproj: Removed FrameViewMac.mm.
bridge/mac/FrameViewMac.mm: Removed.

7:52 PM Changeset in webkit [20793] by thatcher

3 edits
2 moves
1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Rename our AppleScrollbar and AppleScrollArea classes and copy in the resize.png image.

5:51 PM Changeset in webkit [20792] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Fixes a typo that was showing the id attribute twice in the tree.

5:50 PM Changeset in webkit [20791] by thatcher

1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Use Xpath for the plain text search case. This is faster than walking the DOM in JavaScript.

5:48 PM Changeset in webkit [20790] by bdash

2 edits in branches/WebInspectorRefresh/WebKit

2007-04-09 Mark Rowe <mrowe@apple.com>

Build fix.

WebInspector/WebInspector.m:

5:20 PM Changeset in webkit [23235] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20789.

WebInspector/webInspector/inspector.js:

2:15 PM Changeset in webkit [20789] by thatcher

3 edits in branches/WebInspectorRefresh/WebKit

Implement document searching in JavaScript.

12:08 PM WikiStart edited by kevino@theolliviers.com

Making the page more general so it can fit more info. (diff)

12:02 PM WikiStart edited by kevino@theolliviers.com

Adding page about the Bakefile build system (diff)

11:57 AM Changeset in webkit [23234] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebInspector/WebInspector.cpp:

4:32 AM BuildingQtOnLinux created by sil-webkit@kryogenix.org

4:26 AM WikiStart edited by sil-webkit@kryogenix.org

(diff)

3:15 AM Changeset in webkit [20788] by bdash

2 edits in trunk/WebCore

2007-04-08 Mark Rowe <mrowe@apple.com>

Qt build fix.

platform/qt/TemporaryLinkStubs.cpp:

2:45 AM Changeset in webkit [20787] by mjs

3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

shrink RegexpObjectImp by 4 bytes

Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.

kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
kjs/regexp_object.h:

2:33 AM Changeset in webkit [20786] by mjs

3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

shrink ArrayInstance objects by 4 bytes

I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

kjs/array_instance.h: (KJS::ArrayInstance::capacity):
kjs/array_object.cpp: (allocateStorage): (reallocateStorage): (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):

2:22 AM Changeset in webkit [20785] by mjs

3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

fix build issue with last change

kjs/function.h:
kjs/function.cpp: (KJS::ActivationImp::createArgumentsObject):

1:51 AM Changeset in webkit [23233] by aroben

12 edits
1 move
2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

<rdar://problem/4769828> Web Inspector

WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported Mac code. Some parts are left commented out to aid later implementation.
WebInspector/WebInspector.h: Ditto.

1:48 AM Changeset in webkit [20784] by mjs

6 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

discard the arguments List for an ActivationImp when the corresponding Context is destroyed (1.7% speedup)

Based an idea by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.

This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.

Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).

kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
kjs/function.h:
kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto

Apr 7, 2007:

11:35 PM Changeset in webkit [23232] by aroben

1 edit
28 adds in branches/WindowsMerge/WebKitWin

Forked most of the WebInspector directory from
r20780 of branches/WebInspectorRefresh/WebKit/WebInspector.

WebInspector/WebInspector.h: Added.
WebInspector/WebInspector.m: Added. (+sharedWebInspector): (-init): (-initWithWebFrame:): (-dealloc): (-window): (-windowWillClose:): (-showWindow:): (-setWebFrame:): (-webFrame): (-setRootDOMNode:): (-rootDOMNode): (-setFocusedDOMNode:): (-focusedDOMNode): (-setSearchQuery:): (-searchQuery): (-showOptionsMenu): (-_toggleIgnoreWhitespace:): (-_toggleShowUserAgentStyles:): (-_highlightNode:): (-_nodeHighlightExpired:): (-_update): (-_updateRoot): (-_updateSystemColors): (-_applicationWillResignActive): (-_applicationDidBecomeActive): (-_webFrameDetached:): (+isSelectorExcludedFromWebScript:): (+webScriptNameForSelector:): (+isKeyExcludedFromWebScript:): (-inspectedWebViewProgressFinished:): (-webView:didFinishLoadForFrame:): (-webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:): (-webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:): (-webView:exceptionWasRaised:sourceId:line:forWebFrame:): (-[WebInspectorPrivate dealloc]): (-[DOMNode _isAncestorOfNode:]):
WebInspector/webInspector/AppleScrollArea.js: Added.
WebInspector/webInspector/AppleScrollbar.js: Added.
WebInspector/webInspector/Images/button.png: Added.
WebInspector/webInspector/Images/buttonDivider.png: Added.
WebInspector/webInspector/Images/buttonPressed.png: Added.
WebInspector/webInspector/Images/close.png: Added.
WebInspector/webInspector/Images/closePressed.png: Added.
WebInspector/webInspector/Images/downTriangle.png: Added.
WebInspector/webInspector/Images/menu.png: Added.
WebInspector/webInspector/Images/menuPressed.png: Added.
WebInspector/webInspector/Images/popup.png: Added.
WebInspector/webInspector/Images/popupPressed.png: Added.
WebInspector/webInspector/Images/rightTriangle.png: Added.
WebInspector/webInspector/Images/scrollThumbBottom.png: Added.
WebInspector/webInspector/Images/scrollThumbMiddle.png: Added.
WebInspector/webInspector/Images/scrollThumbTop.png: Added.
WebInspector/webInspector/Images/scrollTrackBottom.png: Added.
WebInspector/webInspector/Images/scrollTrackMiddle.png: Added.
WebInspector/webInspector/Images/scrollTrackTop.png: Added.
WebInspector/webInspector/Images/upTriangle.png: Added.
WebInspector/webInspector/inspector.css: Added.
WebInspector/webInspector/inspector.html: Added.
WebInspector/webInspector/inspector.js: Added.

1:25 PM Changeset in webkit [20783] by kevino

1 copy in branches/wx-port-alpha/trunk

Initial copy for wx experimental branch.

1:23 PM Changeset in webkit [20782] by kevino

1 add in branches/wx-port-alpha

Creating wx experimental branch.

12:32 PM Changeset in webkit [20781] by ggaren

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.

Layout tests for one more case of <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

fast/dom/null-document-xmlhttprequest-open-expected.txt: Added.
fast/dom/null-document-xmlhttprequest-open.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed one more case of <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed